From patchwork Tue Mar 3 19:25:52 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 37 Received: from mail.zeus03.de (zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97F2426F46E for ; Tue, 3 Mar 2026 19:31:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772566300; cv=none; b=XPsXtlu0Rmg4a0SDRVyRpscGdEO5R6WLnIRs7yOsyzJla/yXpvBYHYO+Ca9/m0vzNgeVLoZ3kfS0m6SPVlL6Tgk+EKLjwwJfB8M/WDfmWvufCqdXF3crvf0owkIvhQ8lL7J9430GFNcdZMx3BcRjoFH5zoByLtdNBRCKHk30eN0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772566300; c=relaxed/simple; bh=+G/DTapTeKGN5hxk3oLgQA92dCCGah5RYraucKRmfsk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=uUhDQYtYH8o0ViIO22Wzh/a/uGQKkeDwvg6MgcTjrZxNsXp1Aj4ZTIvl8aqZA0QDnPQj7h6ClfNIjfKG6XMf3+I6ylD8wL5FbY6L+fWmHssE5hyalIqhmCn/47EAob2TTa3DMggBv2tSBx460/tuWPoVfxtooKJRi1YLNxydqBQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=SZ59QVo9; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="SZ59QVo9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; s=k1; bh=LvaEYI1DkC3gG8 HSqLFIO8B3jdRzN35AWnw6uUmoiyo=; b=SZ59QVo9Z5/LC1KfkTHdINIkg4qQIh rrARNwidjwPh4FKHOt0EL84P2O15m3+cCEZk6b8gT8MOaaJRfGsLvgDIR0LQ0Q2i IizIk//hhKHAKMRpvRMgiGd/fPGi8Ro4+e1jpL3y18MzVBYvCgHDLFLg46wp3WqG u5yTUg2nxeqjszTbODaculaZYCl99Bk8pSnyYDUp3UAhdUFw4stnLjBrnCY2T07l Brbf3ZVbrD0FXw1J0oO27SJHkbAfIvGkeSpFFEoCBZn/8P4M9MvOIRGh5ko0C9ng Cu7IHYKRvVYo5KM7IuoMnQC61BW1ILt1pDlLhg/PWyTKX/tsJn/rLmBg== Received: (qmail 430333 invoked from network); 3 Mar 2026 20:31:25 +0100 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 3 Mar 2026 20:31:25 +0100 X-UD-Smtp-Session: l3s3148p1@m8u8vyNM4qcujnu+ From: Wolfram Sang To: linux-renesas-soc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Wolfram Sang , Alexandre Torgue , Andy Shevchenko , Antonio Borneo , Arnd Bergmann , Baolin Wang , Bjorn Andersson , Boqun Feng , Chen-Yu Tsai , Chunyan Zhang , Danilo Krummrich , David Lechner , driver-core@lists.linux.dev, Greg Kroah-Hartman , Ingo Molnar , Jernej Skrabec , Jonathan Cameron , Jonathan Corbet , Konrad Dybcio , Lee Jones , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-doc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-iio@vger.kernel.org, linux-omap@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-spi@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, Mark Brown , Maxime Coquelin , =?utf-8?q?Nuno_S=C3=A1?= , Orson Zhai , Peter Zijlstra , "Rafael J. Wysocki" , Samuel Holland , Shuah Khan , Srinivas Kandagatla , Thomas Gleixner , Waiman Long , Wilken Gottwalt , Will Deacon Subject: [PATCH v3 00/15] hwspinlock: move device alloc into core and refactor includes Date: Tue, 3 Mar 2026 20:25:52 +0100 Message-ID: <20260303192600.7224-17-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Status: O Changes since RFC v2: * u8500 and platform_data removal included in this series to make the dependency crystal clear * fixed a build failure when adding the callback (Thanks, Sergey!) This series passes now my improved buildscripts. Buildbots are happy, too. * mention why "Contact:" information was dropped (Thanks, Andy!) * small changes to commit messages * added tags (Thanks, everyone!) * dropped RFC status * rebased to 7.0-rc2 My ultimate goal is to allow hwspinlock provider drivers outside of the subsystem directory. It turned out that a simple split of the headers files into a public provider and a public consumer header file is not enough because core internal structure need to stay hidden. Even more, their opaqueness could and should even be increased. That would also allow the core to handle the de-/allocation of the hwspinlock device itself. This series does all that. Patches 1-2 remove the meanwhile unused platform_data. Patches 3-9 abstract access to internal structures away using helpers. Patch 10 then moves hwspinlock device handling to the core, simplifying drivers. The remaining patches refactor the headers until the internal one is gone and the public ones are divided into provider and consumer parts. More details are given in the patch descriptions. One note about using a callback to initialize hwspinlock priv: I also experimented with a dedicated 'set_priv' helper function. It felt a bit clumsy to me. Drivers would need to save the 'bank' pointer again and iterate over it. Because most drivers will only have a simple callback anyhow, it looked leaner to me. This series has been tested on a Renesas SparrowHawk board (R-Car V4H) with a yet-to-be-upstreamed hwspinlock driver for the MFIS IP core. A branch can be found here (the MFIS driver is still WIP): git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/hwspinlock/refactor-alloc-buildtest Happy hacking, Wolfram Wolfram Sang (15): hwspinlock: u8500: delete driver hwspinlock: remove now unused pdata from header file hwspinlock: add helpers to retrieve core data hwspinlock: add callback to fill private data of a hwspinlock hwspinlock: omap: use new callback to initialize hwspinlock priv hwspinlock: qcom: use new callback to initialize hwspinlock priv hwspinlock: sprd: use new callback to initialize hwspinlock priv hwspinlock: stm32: use new callback to initialize hwspinlock priv hwspinlock: sun6i: use new callback to initialize hwspinlock priv hwspinlock: handle hwspinlock device allocation in the core hwspinlock: move entries from internal to public header hwspinlock: remove internal header hwspinlock: sort include and update copyright hwspinlock: refactor provider.h from public header hwspinlock/treewide: refactor consumer.h from public header Documentation/locking/hwspinlock.rst | 2 +- MAINTAINERS | 3 +- drivers/base/regmap/regmap.c | 2 +- drivers/hwspinlock/Kconfig | 10 -- drivers/hwspinlock/Makefile | 1 - drivers/hwspinlock/hwspinlock_core.c | 129 +++++++++++---- drivers/hwspinlock/hwspinlock_internal.h | 72 -------- drivers/hwspinlock/omap_hwspinlock.c | 29 ++-- drivers/hwspinlock/qcom_hwspinlock.c | 69 ++++---- drivers/hwspinlock/sprd_hwspinlock.c | 41 ++--- drivers/hwspinlock/stm32_hwspinlock.c | 28 ++-- drivers/hwspinlock/sun6i_hwspinlock.c | 38 ++--- drivers/hwspinlock/u8500_hsem.c | 155 ------------------ drivers/iio/adc/sc27xx_adc.c | 2 +- drivers/irqchip/irq-stm32mp-exti.c | 2 +- drivers/mfd/syscon.c | 2 +- drivers/nvmem/sc27xx-efuse.c | 2 +- drivers/nvmem/sprd-efuse.c | 2 +- drivers/pinctrl/stm32/pinctrl-stm32.c | 2 +- drivers/soc/qcom/smem.c | 2 +- drivers/spi/spi-sprd-adi.c | 2 +- .../{hwspinlock.h => hwspinlock/consumer.h} | 57 +------ include/linux/hwspinlock/provider.h | 60 +++++++ 23 files changed, 268 insertions(+), 444 deletions(-) delete mode 100644 drivers/hwspinlock/hwspinlock_internal.h delete mode 100644 drivers/hwspinlock/u8500_hsem.c rename include/linux/{hwspinlock.h => hwspinlock/consumer.h} (87%) create mode 100644 include/linux/hwspinlock/provider.h