From patchwork Thu Mar 19 10:59:22 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 12 Received: from mail.zeus03.de (zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B3763C65F6 for ; Thu, 19 Mar 2026 11:00:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773918007; cv=none; b=cSRrye3OhmDfIHOHGBixF9igtql/jR1u+uBFOlwKKFZWGxydDa6S7sUF/93ELJwqP3hA/DqTWBmcsd5kd+e93iFLENONDe+D1gKFIzVGp8GQwF3gYRVk32gwLJkT5GIHknMKhWR0MGBbBLKQVG0N6ktQqczkHM+GzpqyhMm6zMY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773918007; c=relaxed/simple; bh=lDsTKKOW0M02gxeWI5CUcjsdvvgs0U6RXB5vNRUgEMA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=tWmnqb2fTue84lccJ3WEjMEfAuENzB53mMk6kmiF6nqof/c9yRxyPw4UCEnTOQOZnrLuzWYuI7CgzVlei5epyYkdOAGs5b1+lsyl//4bfHwCVnYWRsRYtEliuA3znqHeEu8iprrhgsVfRSUbkF/pqUpdsIMu8acqJKgPMa6WRp4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=PcDkGLK+; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="PcDkGLK+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; s=k1; bh=KB81XvoxVzxPeO i/26wCRtiORDc5p8n0JHh4CTp/OTA=; b=PcDkGLK+SGUtnsfgW6hOFscnOGL+BT dKa1bQM2q3f+KMWLx51FbKecyKl3CTTGMdyGB6dqrwuL5JkEEudobAqxgeU6ZFMr Q/egIiyx6OHRYc21xA0Sg6RHS9duWIff1CFbEaPP2CfF36ozg9i4SuaRZ7MV6c5H eCWWVJZ5KtG2AIocqV87rCfe50t4kw5N3wmJEAYynvgH2nsxCmP0QR9PCNreuRFf mKmqzGl/3S3bTfYmXZSe0hhxeuBYswfqzt+swtd5l3aIkB5Df3owLfa84N3Fk1B2 xEr2d5idm1V67Pg0LjLzpw4DgNEnINr8JKle2ffApkdPHx/l3cXj3/1g== Received: (qmail 1099341 invoked from network); 19 Mar 2026 11:59:51 +0100 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 19 Mar 2026 11:59:51 +0100 X-UD-Smtp-Session: l3s3148p1@AI+1d15Nvt0gAwDPXzF+ANZpdrMKUeLI From: Wolfram Sang To: linux-renesas-soc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Wolfram Sang , Alexandre Torgue , Andy Shevchenko , Antonio Borneo , Arnd Bergmann , Baolin Wang , Bjorn Andersson , Boqun Feng , Chen-Yu Tsai , Chunyan Zhang , Danilo Krummrich , David Lechner , driver-core@lists.linux.dev, Greg Kroah-Hartman , Ingo Molnar , Jernej Skrabec , Jonathan Cameron , Jonathan Corbet , Konrad Dybcio , Lee Jones , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-doc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-iio@vger.kernel.org, linux-omap@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-spi@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, Mark Brown , Maxime Coquelin , =?utf-8?q?Nuno_S=C3=A1?= , Orson Zhai , Peter Zijlstra , "Rafael J. Wysocki" , Samuel Holland , Shuah Khan , Srinivas Kandagatla , Thomas Gleixner , Waiman Long , Wilken Gottwalt , Will Deacon Subject: [PATCH v5 00/15] hwspinlock: move device alloc into core and refactor includes Date: Thu, 19 Mar 2026 11:59:22 +0100 Message-ID: <20260319105947.6237-1-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Status: O Changes since v4: * update Documentation, too, when ABI gets changed (Thanks Antonio!) * rebased to 7.0-rc4 * added more tags (Thanks!) My ultimate goal is to allow hwspinlock provider drivers outside of the subsystem directory. It turned out that a simple split of the headers files into a public provider and a public consumer header file is not enough because core internal structures need to stay hidden. Even more, their opaqueness could and should even be increased. That would also allow the core to handle the de-/allocation of the hwspinlock device itself. This series does all that. Patches 1-2 remove the meanwhile unused platform_data to ease further refactoring. Patches 3-9 abstract access to internal structures away using helpers. Patch 10 then moves hwspinlock device handling to the core, simplifying drivers. The remaining patches refactor the headers until the internal one is gone and the public ones are divided into provider and consumer parts. More details are given in the patch descriptions. One note about using a callback to initialize hwspinlock priv: I also experimented with a dedicated 'set_priv' helper function. It felt a bit clumsy to me. Drivers would need to save the 'bank' pointer again and iterate over it. Because most drivers will only have a simple callback anyhow, it looked leaner to me. This series has been tested on a Renesas SparrowHawk board (R-Car V4H) with a yet-to-be-upstreamed hwspinlock driver for the MFIS IP core. A branch can be found here (without the MFIS driver currently): git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/hwspinlock/refactor-alloc-buildtest Build bots reported success. Happy hacking, Wolfram Wolfram Sang (15): hwspinlock: u8500: delete driver hwspinlock: remove now unused pdata from header file hwspinlock: add helpers to retrieve core data hwspinlock: add callback to fill private data of a hwspinlock hwspinlock: omap: use new callback to initialize hwspinlock priv hwspinlock: qcom: use new callback to initialize hwspinlock priv hwspinlock: sprd: use new callback to initialize hwspinlock priv hwspinlock: stm32: use new callback to initialize hwspinlock priv hwspinlock: sun6i: use new callback to initialize hwspinlock priv hwspinlock: handle hwspinlock device allocation in the core hwspinlock: move entries from internal to public header hwspinlock: remove internal header hwspinlock: sort include and update copyright hwspinlock: refactor provider.h from public header hwspinlock/treewide: refactor consumer.h from public header Documentation/locking/hwspinlock.rst | 7 +- MAINTAINERS | 3 +- drivers/base/regmap/regmap.c | 2 +- drivers/hwspinlock/Kconfig | 10 -- drivers/hwspinlock/Makefile | 1 - drivers/hwspinlock/hwspinlock_core.c | 129 +++++++++++---- drivers/hwspinlock/hwspinlock_internal.h | 72 -------- drivers/hwspinlock/omap_hwspinlock.c | 27 ++- drivers/hwspinlock/qcom_hwspinlock.c | 69 ++++---- drivers/hwspinlock/sprd_hwspinlock.c | 39 ++--- drivers/hwspinlock/stm32_hwspinlock.c | 26 +-- drivers/hwspinlock/sun6i_hwspinlock.c | 36 ++-- drivers/hwspinlock/u8500_hsem.c | 155 ------------------ drivers/iio/adc/sc27xx_adc.c | 2 +- drivers/irqchip/irq-stm32mp-exti.c | 2 +- drivers/mfd/syscon.c | 2 +- drivers/nvmem/sc27xx-efuse.c | 2 +- drivers/nvmem/sprd-efuse.c | 2 +- drivers/pinctrl/stm32/pinctrl-stm32.c | 2 +- drivers/soc/qcom/smem.c | 2 +- drivers/spi/spi-sprd-adi.c | 2 +- .../{hwspinlock.h => hwspinlock/consumer.h} | 57 +------ include/linux/hwspinlock/provider.h | 60 +++++++ 23 files changed, 263 insertions(+), 446 deletions(-) delete mode 100644 drivers/hwspinlock/hwspinlock_internal.h delete mode 100644 drivers/hwspinlock/u8500_hsem.c rename include/linux/{hwspinlock.h => hwspinlock/consumer.h} (87%) create mode 100644 include/linux/hwspinlock/provider.h