From patchwork Tue Sep 8 14:46:31 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 369 Return-Path: X-Original-To: noreply@patchwork.local Delivered-To: noreply@patchwork.local Received: from sin.lore.kernel.org (sin.lore.kernel.org [104.64.211.4]) by mxe881.netcup.net (Postfix) with ESMTPS id D50B81C2D7D for ; Tue, 8 Sep 2026 20:17:20 +0200 (CEST) Authentication-Results: mxe881; spf=pass (sender IP is 104.64.211.4) smtp.mailfrom=linux-sunxi+bounces-25708-noreply=patchwork.local@lists.linux.dev smtp.helo=sin.lore.kernel.org Received-SPF: pass (mxe881: domain of lists.linux.dev designates 104.64.211.4 as permitted sender) client-ip=104.64.211.4; envelope-from=linux-sunxi+bounces-25708-noreply=patchwork.local@lists.linux.dev; helo=sin.lore.kernel.org; Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sin.lore.kernel.org (Postfix) with ESMTP id 4DB3F2FD09 for ; Tue, 8 Sep 2026 14:47:13 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7AB125476F4; Tue, 8 Sep 2026 14:47:11 +0000 (UTC) X-Original-To: linux-sunxi@lists.linux.dev Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E056B1FECCD; Tue, 8 Sep 2026 14:47:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788878830; cv=none; b=qCk3UVhgTL3WR99Myp3H6qfH20qHM+XlfzQj3FYdp05IED/an6Fi+/s6kj6Ob96y65nyKeXm8eZhcva+dIpHhnD5RdigAiVyPy5HOf/mYQ7lJPp+lqZ1ZaSasjicn97Cf/RyLCtOMwJ5Cr3AU/TLr6MswwO6CaYSvY8BffH+nuw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788878830; c=relaxed/simple; bh=l37WHPmKc+pkVQCgzua1uuu+eJaWszMqVMVDI1COPuc=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=NPGVg1cmWoDtdAnxAsHZR6CZcKV2naNC5OhNsdGlS2kp/KXm658YF6c3ECzL2rQmqU3WBBvI8pDt0AVSyLQFs2RwHmwBlSmcqWvE4cWkm2xQHBlEgB82NPYNhTriLxZlZEsmG/V+wBKSk8xz8QWYwZlWbiX4+Wv8N4HoqeOMfyc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 Received: by smtp.kernel.org (Postfix) with ESMTPSA id A387D1F00A3D; Tue, 8 Sep 2026 14:46:58 +0000 (UTC) From: Maxime Ripard Subject: [PATCH v4 00/41] drm/plane: Convert all drivers to atomic_create_state and remove reset Date: Tue, 08 Sep 2026 16:46:31 +0200 Message-Id: <20260908-drm-no-more-plane-reset-v4-0-a31b3fcfc989@kernel.org> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAAAAAAAC/3XQPW7DMAwF4KsYmstCf7bsTL1H0EGxqERoLKWUY qQIcvfK8dAWhcdHgN8DeWcZKWBmu+bOCOeQQ4o16JeGjScbjwjB1cwklx3v5ACOJogJpkQIl7O NCIQZC3A9tNxridx4VrcvhD7cnvL+veZTyCXR17NoFst0NQ3fNmcBHBSXbug7j63nbx9IEc+vi Y5sQWf5A/VCb0OyQr10cuiUc0Lpf5D6BSmxDakKid6Y0VjbmoP6Az3Wuwk/r/WRZT2eHWxGGNM 0hbJrFngKeYSItwJLH9QHcFWXH98vrXvkjQEAAA== X-Change-ID: 20260629-drm-no-more-plane-reset-04950f42e07f To: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, Maxime Ripard , hamohammed.sa@gmail.com, louis.chauvet@bootlin.com, melissa.srw@gmail.com, alexander.deucher@amd.com, amd-gfx@lists.freedesktop.org, christian.koenig@amd.com, alison.wang@nxp.com, stefan@agner.ch, John Stultz , sumit.semwal@linaro.org, xinliang.liu@linaro.org, yongqin.liu@linaro.org, Frank.Li@nxp.com, Sascha Hauer , festevam@gmail.com, imx@lists.linux.dev, kernel@pengutronix.de, victor.liu@nxp.com, anitha.chrisanthus@intel.com, paulk@sys-base.io, chenhuacai@kernel.org, jeffbai@aosc.io, lvjianmin@loongson.cn, wuqianhai@loongson.cn, xry111@xry111.site, zhengxingda@iscas.ac.cn, marex@denx.de, airlied@redhat.com, kraxel@redhat.com, spice-devel@lists.freedesktop.org, virtualization@lists.linux.dev, andy.yan@rock-chips.com, heiko@sntech.de, hjc@rock-chips.com, linux-rockchip@lists.infradead.org, Baolin Wang , orsonzhai@gmail.com, zhang.lyra@gmail.com, alain.volmat@foss.st.com, rgallaispou@gmail.com, alexandre.torgue@foss.st.com, mcoquelin.stm32@gmail.com, philippe.cornu@foss.st.com, raphael.gallais-pou@foss.st.com, yannick.fertre@foss.st.com, jyri.sarha@iki.fi, tomi.valkeinen@ideasonboard.com, hansg@kernel.org, dmitry.osipenko@collabora.com, gurchetansingh@chromium.org, olvaffe@gmail.com, michal.simek@amd.com, harry.wentland@amd.com, siqueira@igalia.com, sunpeng.li@amd.com, linux@armlinux.org.uk, Dharma Balasubiramani , Ludovic Desroches , Manikandan Muralidharan , alexandre.belloni@bootlin.com, claudiu.beznea@tuxon.dev, nicolas.ferre@microchip.com, alim.akhtar@samsung.com, inki.dae@samsung.com, krzk@kernel.org, kyungmin.park@samsung.com, linux-samsung-soc@vger.kernel.org, sw0312.kim@samsung.com, p.zabel@pengutronix.de, angelogioacchino.delregno@collabora.com, chunkuang.hu@kernel.org, matthias.bgg@gmail.com, Lyude Paul , dakr@kernel.org, nouveau@lists.freedesktop.org, geert+renesas@glider.be, kieran.bingham+renesas@ideasonboard.com, laurent.pinchart+renesas@ideasonboard.com, linux-renesas-soc@vger.kernel.org, magnus.damm@gmail.com, tomi.valkeinen+renesas@ideasonboard.com, Biju Das , linux-sunxi@lists.linux.dev, samuel@sholland.org, wens@kernel.org, Zack Rusin , bcm-kernel-feedback-list@broadcom.com X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=8156; i=mripard@kernel.org; h=from:subject:message-id; bh=l37WHPmKc+pkVQCgzua1uuu+eJaWszMqVMVDI1COPuc=; b=owGbwMvMwCmsHn9OcpHtvjLG02pJDFkL5M9+N3zquIldctcjh6zVJ5NmOG1YUWOo2rHq8/q7p Zu6P/xZ1jGVhUGYk0FWTJHliUzY6eXti6sc7Ff+gJnDygQyhIGLUwAmYqvHWKchq3FG6ZWx2ie5 v66F/x6m/m/vrtnPGt4wVbjJMlYwqCgh4+We7Unqft3C12ak/pPvYayvll+1y2BL6adFCRdf+oV 3G2205BMV38l3xN6RiU+ea418wO6TJ323ShvvKbuzO57tyBcA X-Developer-Key: i=mripard@kernel.org; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-MORS-Enabled: yes X-MORS-DOMAIN: patchwork.local X-MORS-HOSTING: hosting172546 X-MORS-USER: hosting172546 X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= This is a follow-up to the bridge reset removal series, and part of a larger effort to remove the reset hook from all KMS objects. The plane reset hook is overloaded: it is called both at probe time to create the initial software state and during suspend/resume to reset hardware and software state. These two roles have different requirements, and the reset hook is not fallible, making error handling difficult for the initial state allocation path. While reset has the semantics to reset both the software and hardware state, the vast majority of implementations and all the helpers only reset the software state, making them equivalent to atomic_create_state in practice. The atomic_create_state hook makes this explicit: it only allocates and initializes a pristine state without any side effect, and returns the state pointer or an ERR_PTR on failure. This series first adds the necessary infrastructure in the simple-kms and GEM atomic helpers, then converts all 51 plane drivers tree-wide from the reset hook to atomic_create_state. The conversions were done using a combination of Coccinelle semantic patches and manual adjustments. Once all drivers are converted, the old helpers and the reset hook itself are removed from struct drm_plane_funcs. Signed-off-by: Maxime Ripard Reviewed-by: Thomas Zimmermann --- Changes in v4: - Fix a NULL pointer dereference with vkms - Rebase on drm-misc-next-2026-09-03 - Link to v3: https://lore.kernel.org/r/20260831-drm-no-more-plane-reset-v3-0-1877c7aa57b3@kernel.org Changes in v3: - Drop leftover state destruction in sun4i - Rebase on current drm-misc-next - Link to v2: https://lore.kernel.org/r/20260814-drm-no-more-plane-reset-v2-0-82d2963dd134@kernel.org Changes in v2: - Rebase on latest drm-misc-next tag - Fix sashiko reviews - Fix atmel-hlcdc breakage - Link to v1: https://lore.kernel.org/r/20260709-drm-no-more-plane-reset-v1-0-302d986fe5f0@kernel.org --- Maxime Ripard (41): drm/simple-kms: Remove unused reset_plane hook drm/vkms: Move frame_info into vkms_plane_state drm/vkms: Convert to atomic_create_state drm/gem-atomic-helper: Remove __drm_gem_reset_shadow_plane() drm/amdgpu: Convert to atomic_create_state drm/fsl-dcu: Convert to atomic_create_state drm/hisilicon/kirin: Convert to atomic_create_state drm/imx/dc: Convert to atomic_create_state drm/kmb: Convert to atomic_create_state drm/logicvc: Convert to atomic_create_state drm/loongson: Convert to atomic_create_state drm/lcdif: Convert to atomic_create_state drm/mxsfb: Convert to atomic_create_state drm/qxl: Convert to atomic_create_state drm/rockchip: Convert to atomic_create_state drm/sprd: Convert to atomic_create_state drm/sti: Convert to atomic_create_state drm/stm: Convert to atomic_create_state drm/tests: kunit: Convert to atomic_create_state drm/tilcdc: Convert to atomic_create_state drm/vboxvideo: Convert to atomic_create_state drm/verisilicon: Convert to atomic_create_state drm/virtio: Convert to atomic_create_state drm/xlnx: Convert to atomic_create_state drm/atomic-state-helper: Remove drm_atomic_helper_plane_reset() drm/amdgpu_dm: Convert to atomic_create_state drm/armada: Convert to atomic_create_state drm/atmel-hlcdc: Drop spurious csc_init call from reset drm/atmel-hlcdc: Convert to atomic_create_state drm/exynos: Convert to atomic_create_state drm/imx/ipuv3: Convert to atomic_create_state drm/mediatek: Convert to atomic_create_state drm/nouveau: Convert to atomic_create_state drm/omap: Convert to atomic_create_state drm/rcar-du: Convert to atomic_create_state drm/rz-du: Convert to atomic_create_state drm/shmobile: Convert to atomic_create_state drm/sun4i: layer: Convert to atomic_create_state drm/vmwgfx: Convert to atomic_create_state drm/atomic-state-helper: Remove __drm_atomic_helper_plane_reset() drm/plane: Remove reset drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c | 2 +- .../drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 28 ++++++++----- .../drm/amd/display/amdgpu_dm/amdgpu_dm_plane.h | 2 +- .../display/amdgpu_dm/tests/amdgpu_dm_plane_test.c | 30 +++++--------- drivers/gpu/drm/armada/armada_overlay.c | 39 ++++++++---------- drivers/gpu/drm/armada/armada_plane.c | 15 +++---- drivers/gpu/drm/armada/armada_plane.h | 2 +- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 33 +++++++-------- drivers/gpu/drm/drm_atomic_state_helper.c | 41 ------------------ drivers/gpu/drm/drm_gem_atomic_helper.c | 20 --------- drivers/gpu/drm/drm_mode_config.c | 4 +- drivers/gpu/drm/exynos/exynos_drm_plane.c | 22 ++++------ drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c | 2 +- drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 2 +- drivers/gpu/drm/imx/dc/dc-plane.c | 2 +- drivers/gpu/drm/imx/ipuv3/ipuv3-plane.c | 19 ++++----- drivers/gpu/drm/kmb/kmb_plane.c | 2 +- drivers/gpu/drm/logicvc/logicvc_layer.c | 2 +- drivers/gpu/drm/loongson/lsdc_plane.c | 2 +- drivers/gpu/drm/mediatek/mtk_plane.c | 22 ++++------ drivers/gpu/drm/mxsfb/lcdif_kms.c | 2 +- drivers/gpu/drm/mxsfb/mxsfb_kms.c | 2 +- drivers/gpu/drm/nouveau/dispnv50/wndw.c | 15 ++++--- drivers/gpu/drm/omapdrm/omap_plane.c | 13 +++--- drivers/gpu/drm/qxl/qxl_display.c | 4 +- drivers/gpu/drm/renesas/rcar-du/rcar_du_plane.c | 15 +++---- drivers/gpu/drm/renesas/rcar-du/rcar_du_vsp.c | 15 +++---- drivers/gpu/drm/renesas/rz-du/rzg2l_du_vsp.c | 15 +++---- drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c | 15 +++---- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +- drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 2 +- drivers/gpu/drm/sprd/sprd_dpu.c | 2 +- drivers/gpu/drm/sti/sti_cursor.c | 2 +- drivers/gpu/drm/sti/sti_gdp.c | 2 +- drivers/gpu/drm/sti/sti_hqvdp.c | 2 +- drivers/gpu/drm/stm/ltdc.c | 2 +- drivers/gpu/drm/sun4i/sun4i_layer.c | 21 ++++------ drivers/gpu/drm/tests/drm_kunit_helpers.c | 2 +- drivers/gpu/drm/tilcdc/tilcdc_plane.c | 2 +- drivers/gpu/drm/vboxvideo/vbox_mode.c | 2 +- drivers/gpu/drm/verisilicon/vs_cursor_plane.c | 2 +- drivers/gpu/drm/verisilicon/vs_plane.c | 14 +++---- drivers/gpu/drm/verisilicon/vs_plane.h | 2 +- drivers/gpu/drm/verisilicon/vs_primary_plane.c | 2 +- drivers/gpu/drm/virtio/virtgpu_plane.c | 2 +- drivers/gpu/drm/vkms/vkms_composer.c | 30 +++++++------- drivers/gpu/drm/vkms/vkms_drv.h | 2 +- drivers/gpu/drm/vkms/vkms_formats.c | 48 +++++++++++----------- drivers/gpu/drm/vkms/vkms_plane.c | 36 +++++----------- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 17 ++++---- drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c | 4 +- drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 4 +- drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 4 +- drivers/gpu/drm/xlnx/zynqmp_kms.c | 2 +- include/drm/drm_atomic_state_helper.h | 3 -- include/drm/drm_gem_atomic_helper.h | 2 - include/drm/drm_plane.h | 12 ------ include/drm/drm_simple_kms_helper.h | 1 - 59 files changed, 236 insertions(+), 381 deletions(-) --- base-commit: 17c6b88e85ffe5de5720004ae8c2176d52944aca change-id: 20260629-drm-no-more-plane-reset-04950f42e07f Best regards,