From patchwork Sun Sep 13 04:04:51 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Hilliard X-Patchwork-Id: 379 Return-Path: X-Original-To: noreply@patchwork.local Delivered-To: noreply@patchwork.local Received: from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10]) by mxe881.netcup.net (Postfix) with ESMTPS id 09C051C1EF8 for ; Sun, 13 Sep 2026 06:05:13 +0200 (CEST) Authentication-Results: mxe881; dkim=pass header.d=gmail.com; spf=pass (sender IP is 172.234.253.10) smtp.mailfrom=linux-sunxi+bounces-25839-noreply=patchwork.local@lists.linux.dev smtp.helo=sea.lore.kernel.org Received-SPF: pass (mxe881: domain of lists.linux.dev designates 172.234.253.10 as permitted sender) client-ip=172.234.253.10; envelope-from=linux-sunxi+bounces-25839-noreply=patchwork.local@lists.linux.dev; helo=sea.lore.kernel.org; Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id B2A772A665 for ; Sun, 13 Sep 2026 04:05:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 52DCF383981; Sun, 13 Sep 2026 04:05:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PD3wPD7B" X-Original-To: linux-sunxi@lists.linux.dev Received: from mail-oi2-f13.google.com (mail-oi2-f13.google.com [74.125.231.205]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 482B01D5CC9 for ; Sun, 13 Sep 2026 04:05:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.231.205 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789272310; cv=none; b=JTS+dwfOndj22ZEevslnbLzFxEGuTo/XHFsVO/5GjKwBNpfpx7F7SribIhi1u5ff1exkWPyjI+CC5r8mPYWSnUTSERI52hdXlhiZEro1Hp/EGRI217J2Pi2aBu93rXvKtJ5OaJMx2KuNkfkiNJ+4z12kD6TIzSqcShfu7fZQTnA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789272310; c=relaxed/simple; bh=y0VCkdd6MdNfgfkdo72YtGDzxt8P1PR4Yg0G/UOw0XY=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=RqBHgA2xl+xnzOREWrrkpMKQ/bj/TpXZ1D4CS/Xjd5O4waWMo+7e5lIFLhndYrNbXKoM01fNUsu5AMOjZ1INyy+FtMD2UGL1UhSyMysq1ySerjVs3mQk1/KlvcPvaKy2veZZx0qMB/Im/XrWRT5P6HcaLtpZGyMWmt/DhsB793c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PD3wPD7B; arc=none smtp.client-ip=74.125.231.205 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oi2-f13.google.com with SMTP id 5614622812f47-4bf948737e1so846745b6e.2 for ; Sat, 12 Sep 2026 21:05:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789272307; x=1789877107; darn=lists.linux.dev; h=cc:to:content-transfer-encoding:content-type:mime-version :message-id:date:subject:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=5Oa+YOncmCkkVL2k0GTFisduj2Byb339ftd8reg9zeE=; b=PD3wPD7BSyCTCon0kpZENx45JOTl5K30fjvcDmDpIhs52AJZdfWwbtRgZFth5Aen4S 3Z2Gu37obd7LOOHyT18qAFJJ1cd0qpzo5fL7cYgTJ/DESzoqJx5jEAKgqavV+ndLWA91 oCaDBrrTqaEgXz+6KgQ39E4IJQupiRrRBeoimdMmSrC4kAKqD8uvz5GQgiR/yuZIc0wz 3KVzG3ByZm42EhAtXJKt+RCRE35inwi8apCkatevQIepDtmXtNNCWlASxadW7u5WQojb qVQClHTxRCmjRpURtsf0R2bmzjXk0+svg/9G5hjvo3+19ufJqOj6W6noKAyW04nD6rHb o8Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789272307; x=1789877107; h=cc:to:content-transfer-encoding:content-type:mime-version :message-id:date:subject:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=5Oa+YOncmCkkVL2k0GTFisduj2Byb339ftd8reg9zeE=; b=fkOB6Wxhj/F6Vx4mwtl/PWRd2AMsLHI/aN4wtHLo7wF0qLPCvbfcJSk/ESTlw6eh5p 6jQfT+WHfrjaRyNRK72GqK5rVZ7qZDa9uUWbFJuNacXBA7QsFTFcWZWrhErBkXSIUgSv P3WogEXBF/yx39VTzpKqNdgFXJQ3bfVbC6QsAZJmzbL4BTtZYwIi4jaKzi2IUgm/UEg8 pENY7qobYn1RXhbRzDxUFiCOrbx2BOnEX+Yf12zvXu+oEUFDNNlaVSMyZDL6dGoHpvIW FxN4CjiZ2p0khCkzUmmWUGP6lnIVgSqKn/s530cwhYNpjnZI2XXatUNM+zm+j5cPfO7s Vagw== X-Forwarded-Encrypted: i=1; AKwUvByNXvluWv2X4VKVpI1NbHgDSXhNZGcuEeUNGeqZaVHCZE99GxSTg+Rw/z1uWArq9d2A5KEKJ2uQk9NMCA==@lists.linux.dev X-Gm-Message-State: AFuF++l0Psi17rDolOyGnRVuBoa9r2bK57nQpYOd0IU8k/bNFpRQ4b5K qS4cwsovXD/HGBbnlAfQ8hNoWRRqotjuzqfzeMrO+2Ldn6g84mIHfXoZ X-Gm-Gg: AYBFou25tlCq04RRvKdsXM9Yixi3kWslnsDue53hyXhj8BdUy9zt596F7U16LWiYoWC phm39BLu5Uplxr1uOkteS3/d2qGL+FFwNoiRiSoAVzC39YTH8mDdM0FsE6rSMVM16YNyuMo8J6U 7Pre/EYtlAVa+H/jEkY82PfgjWxZjpHTUXR7L64QEth/hTnObiLxxdDbgsY1zpcIkGYvZeuALFK QX70jKDeUWPvAIEKlzsAAChntFCfloFc9Q0xkYlxCBS2fnK8bgNQcV8nRolhL4Tx6Swl6+6QAlI NffBSoKeXcVilXe3cuPJBMfEtzq/CE+hOKKEpsT6jTjmLx0Ja8PThXb8SUCM5i09pG1ZzRDZuWm Jq1I6mfRtmyeKTcDM95yhs4dKW+Af7bUynpkUR2XAbx36o3F2UNhzp0ub3NhPVC9/dJZKWIfeYX qoKlfYny6SLDK+m+6nGKoSgSva9rlwQnYjIW422MernAW0bCcfwxjQdR1x9ZhJby9W/Ej1kHPQL zCDnAsWQg7yhDlnDj7ffvONJuMvOgIhyqCAqFNl8PNVIz0vmqQ1hO+7bX5Jvv3/NeHfSU5GXIZh 7hk73sbCMUOU4oo6gjZl9TxOplcd2v8EeuI2O4JSOsiVH/B6yBYPu+nrQJugjVtKhfX4INJ7BqY 4/mGiBs78/DT6D99MjCKBNEoaPAisHDQag3PotjKW X-Received: by 2002:a05:6808:6807:b0:4c2:2fb4:3676 with SMTP id 5614622812f47-4c31bdfc3ccmr17088364b6e.16.1789272307014; Sat, 12 Sep 2026 21:05:07 -0700 (PDT) Received: from [127.0.1.1] (184-96-157-145.hlrn.qwest.net. [184.96.157.145]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-47df8699647sm6011535fac.5.2026.09.12.21.05.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Sep 2026 21:05:06 -0700 (PDT) From: James Hilliard Subject: [PATCH v4 00/17] mtd: rawnand: sunxi: support the Allwinner randomized OOB format Date: Sat, 12 Sep 2026 22:04:51 -0600 Message-Id: <20260912-submit-sunxi-nand-vendor-oob-layout-v1-v4-0-4a64bed94229@gmail.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAAAAAAAC/5XOz2oCMRAG8FeRnDslk0Td9eR7lB4mf9QpbiLJG hTZd29WD7Y9WRgYPhh+39xECZlDEZvFTeRQuXCKLZi3hXAHivsA7FsWSqqV7FBCOduBx7bihSF S9FBD9ClDShaOdE3nESpC0IjGo3Sud6Jhpxx2fLkXfXw+cpO+ghtnfb44cBlTvt4/qTjf/bu0j QSz0t1SExry/XY/EB/fXRrEXFrVk+2leZlVjbWo5NrsDDla/2X1T7Z/mdWN7XTnrLSES/OLnab pG+X8tRicAQAA X-Change-ID: 20260810-submit-sunxi-nand-vendor-oob-layout-v1-e3114d10cc9c To: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Maxime Ripard , Richard Genoud , Masahiro Yamada , Boris Brezillon , Brian Norris Cc: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, James Hilliard , stable@vger.kernel.org X-Mailer: b4 0.15.2 X-Rspamd-Server: rspamd-worker-8404 X-Spamd-Result: default: False [-1.16 / 15.00]; BAYES_HAM(-5.50)[100.00%]; RBL_SENDERSCORE(2.00)[172.234.253.10:from]; SUSPICIOUS_RECIPS(1.50)[]; DMARC_POLICY_SOFTFAIL(1.00)[gmail.com : SPF not aligned (relaxed), No valid DKIM,none]; MAILLIST(-0.15)[generic]; MIME_GOOD(-0.10)[text/plain]; BAD_REP_POLICIES(0.10)[]; HAS_LIST_UNSUB(-0.01)[]; RCPT_COUNT_TWELVE(0.00)[21]; FROM_HAS_DN(0.00)[]; FORGED_SENDER_MAILLIST(0.00)[]; ARC_ALLOW(0.00)[subspace.kernel.org:s=arc-20240116:i=1]; FREEMAIL_CC(0.00)[lists.infradead.org,vger.kernel.org,lists.linux.dev,gmail.com]; PRECEDENCE_BULK(0.00)[]; TAGGED_RCPT(0.00)[dt]; RCVD_COUNT_FIVE(0.00)[6]; ASN(0.00)[asn:63949, ipnet:172.234.224.0/19, country:SG]; FREEMAIL_FROM(0.00)[gmail.com]; FREEMAIL_TO(0.00)[bootlin.com,nod.at,ti.com,kernel.org,gmail.com,sholland.org,socionext.com]; R_SPF_ALLOW(0.00)[+ip4:172.234.253.10:c]; TO_DN_SOME(0.00)[]; FROM_NEQ_ENVFROM(0.00)[jameshilliard1@gmail.com,linux-sunxi@lists.linux.dev]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; TAGGED_FROM(0.00)[bounces-25839-noreply=patchwork.local]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[] X-Rspamd-Queue-Id: 09C051C1EF8 X-MORS-Enabled: yes X-MORS-DOMAIN: patchwork.local X-MORS-HOSTING: hosting172546 X-MORS-USER: hosting172546 X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= Allwinner NAND firmware leaves the bad-block marker in the randomizer data stream. On H6/H616 it also places all protected user data before the first ECC step. These choices differ from the mainline format, which keeps the physical marker plain and maximizes the H6/H616 user-data area. Add allwinner,randomized-oob to select the firmware format for the configured hardware-ECC geometry. Older controllers keep their fixed four-byte-per-step user-data layout; H6/H616 use four bytes per 1 KiB step, capped at 16 bytes, packed before the first ECC step. Without the property, retain the existing marker handling and OOB layout. Normal hardware-ECC accesses use the controller randomizer. MTD_OPS_RAW continues to bypass both ECC and randomization and expose physical data and OOB, including randomized markers stored by firmware. Address the ECC-error paths as well. In randomized-OOB mode, use the controller-specific vendor spare-byte erased-page heuristic on the protected user data from the original hardware read. Older controllers use exact erased-spare checks, including their first-page and page-127 signatures; H616 requires byte zero and at least nine of ten spare bytes to be 0xff. Accepted erased pages return all-0xff data and OOB without a raw reread. An all-zero physical page instead returns a bad marker and an ECC failure. Other ECC failures retain the original decoded data and protected OOB for bad-block and flash-BBT pattern scans. PIO and DMA share this page-wide classification, including randomized-format subpage reads. Plain-marker mode keeps its existing physical erased-chunk check. Prepend independent fixes for interrupt/completion ordering, PIO OOB lengths, per-step pattern IDs, read/write error handling and duplicate OOB program confirms, followed by OOB-helper cleanups. These fixes also apply when randomized-OOB mode is disabled. Also combine contiguous unprotected OOB reads and reduce repeated chip setup and register accesses without changing the page format. Finally, bound H6/H616 DMA batches by the 128-byte user-data register bank. Keep the existing default OOB allocation and ECC offsets, reusing hardware slots across batches instead of changing the format or falling back to PIO. Preserve page-wide ECC accounting and a single final program confirm. Assisted-by: Codex:gpt-6-astra Signed-off-by: James Hilliard --- Changes in v4: - prepend an independent fix for completion reuse and IRQ timeout races: initialize the completion once, finish IRQ register updates before signalling success, and drain timed-out handlers before clearing their interrupt state - add a separate fix for aggregate protected-user-data register overflow by splitting DMA transfers into bounded batches, retaining the existing OOB layout, ECC offsets and DMA support - distinguish logical page steps from batch-local hardware slots, retain page-wide ECC accounting and avoid retrying partially transferred writes - Link to v3: https://patch.msgid.link/20260909-submit-sunxi-nand-vendor-oob-layout-v1-v3-0-838cb0ba1547@gmail.com Changes in v3: - add a prerequisite fix for the logical OOB length used by PIO transfers - clarify logical ECC steps versus hardware slots and share protected-OOB register indexing - select the controller-specific vendor spare-byte erased-page check from the SoC capabilities, only in randomized-OOB mode and without rereading the main data - retain hardware-decoded data and protected OOB on other ECC failures for bad-block and BBT pattern scans (reported by Miquel Raynal) - retain a bad marker and ECC failure for all-zero physical pages, and disable the ECC exception for the vendor format - share page classification between PIO and DMA, reading complete pages for randomized-format subpage requests - propagate OOB read errors and defer randomized-format ECC accounting until those reads have succeeded - propagate read/program setup, column-change and buffer-transfer errors, including extra OOB; stop failed writes and disable ECC and randomization - discard partial DMA ECC statistics before retrying in PIO, and keep correction counts separate from successful OOB-transfer status - select the current hardware step's pattern ID instead of slot zero - avoid a second program confirm after an OOB-only write - avoid redundant column changes before writing extra OOB bytes - reject oversized ECC steps in randomized-OOB mode before the core can fall back to software ECC - combine adjacent parity and trailing OOB reads in randomized-OOB mode - remove duplicate chip setup immediately before core page commands - program each packed DMA user-data length register once per operation, and write PIO slot zero directly without read-modify-write - reuse pattern IDs and packed error counters within a DMA read, while refreshing the snapshot after every PIO ECC operation - Link to v2: https://patch.msgid.link/20260904-submit-sunxi-nand-vendor-oob-layout-v1-v2-0-b12074f4aca7@gmail.com Changes in v2: - rebase on the current MTD nand/next branch - retain the merged protected-OOB allocation, BBM reservation and stack-buffer fixes - clarify that randomization is part of the normal hardware-ECC page format while MTD_OPS_RAW continues to expose physical bytes - explain why a BSP-compatible BBM remains randomized in physical raw data - document the decoded bad-block and flash-BBT access paths - reject the firmware OOB format with software or disabled ECC - document the BSP page-format compatibility contract and the older-controller format audit - Link to v1: https://patch.msgid.link/20260810-submit-sunxi-nand-vendor-oob-layout-v1-v1-0-463853a14ad9@gmail.com To: Miquel Raynal To: Richard Weinberger To: Vignesh Raghavendra To: Chen-Yu Tsai To: Jernej Skrabec To: Samuel Holland To: Richard Genoud To: Rob Herring To: Krzysztof Kozlowski To: Conor Dooley To: Maxime Ripard To: Masahiro Yamada To: Boris Brezillon To: Brian Norris Cc: linux-mtd@lists.infradead.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-sunxi@lists.linux.dev Cc: linux-kernel@vger.kernel.org Cc: devicetree@vger.kernel.org --- James Hilliard (17): mtd: rawnand: sunxi: drain interrupts before reusing the completion mtd: rawnand: sunxi: use the logical step's OOB length in PIO mtd: rawnand: sunxi: propagate page-setup and erased-check errors mtd: rawnand: sunxi: stop failed program operations and disable ECC mtd: rawnand: sunxi: select the pattern ID for the current ECC step mtd: rawnand: sunxi: propagate buffer and column transfer errors mtd: rawnand: sunxi: avoid a second program confirm for OOB writes mtd: rawnand: sunxi: avoid redundant column changes for extra OOB mtd: rawnand: sunxi: clarify OOB register and step handling dt-bindings: mtd: sunxi: Add randomized OOB flag mtd: rawnand: sunxi: support randomized OOB formats mtd: rawnand: sunxi: select the packed H6/H616 OOB layout mtd: rawnand: sunxi: combine contiguous unprotected OOB reads mtd: rawnand: sunxi: avoid duplicate chip setup before page commands mtd: rawnand: sunxi: reduce user-data length register accesses mtd: rawnand: sunxi: reuse ECC status within each DMA read mtd: rawnand: sunxi: bound DMA batches by the user-data register bank .../bindings/mtd/allwinner,sun4i-a10-nand.yaml | 10 + drivers/mtd/nand/raw/sunxi_nand.c | 1158 ++++++++++++++------ 2 files changed, 827 insertions(+), 341 deletions(-) --- base-commit: 7e874b1750a40f3dc9a629aeb72eba09c77f77e9 change-id: 20260810-submit-sunxi-nand-vendor-oob-layout-v1-e3114d10cc9c Best regards, -- James Hilliard