From patchwork Thu Nov 6 20:34:57 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Gunthorpe X-Patchwork-Id: 1873 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11010065.outbound.protection.outlook.com [52.101.56.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FC853314CD; Thu, 6 Nov 2025 20:35:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.56.65 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762461309; cv=fail; b=hffg/ANI/gAub4nPYDwi1Ehnwz9193N193pxzdvzxjRJNwM7CeaquDw0u+NklCoW0enMRW6fxnu6/HJ4m+9fcq9cPDTvzXRwotWoVeYLj31V1iY1sUDrcoX04S+DC2KB25dquantRlN4vCL643D1Q9lZpqAFwa1Oms/ja89mWLY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762461309; c=relaxed/simple; bh=zyvUJEdGi6r8zUYQaSD3OXiXB16dr0Y4dtvSkbgXwZY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=kYZAY51QFuCumSB/mdDTEXuxscQggSjRPbIlh5t+9oWlKyQWseWmKS9s/dksIGNNtT1s3n+XgoeuAQlrtme/ItgHiNoyt+MUNwVFOtGL6MfPd5z+FofCH95xR17EXUdaknUOHXCZnxKCBdU0iRrfrqEPFMz3WJn1enLkAcyk2Zs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=ISkdjELM; arc=fail smtp.client-ip=52.101.56.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="ISkdjELM" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jXFgJIF3/hcq7NVlgQJ/9ctWMZXjJ5IWKh7Y9xxKyXUNULh8wzm0+zdX2+ALQnRVZkZiCSuMFNWcAtsWBmsYLuoxCoLFTvb0w6YyhPG9FGW8xQu0fjvXeeatAuBrFXWOz8GJV92IH34qTpIpgR7cHIObSy8QprWSpLT2l00X+LfVXYKJytxZcvhwyzB/w2VsQFosVc49LpMRSu/X5X4NHkc1mN9TGWmv3MzS7saOOfbjvuiXUTHxYf2rU2NrZ6KqtsVRSVTPzgTFsRmF0CwhOkaJjGJo2dQes24Nljl6RfPUibO64wBZ28HEBB48raVizAJkbvOg6A075viz1MFpgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=My24LlDJyOsjOyX8HI6wIQkfNsPWTSeEWuzPouIkp08=; b=bo6G+8mPiS84Q/xe93yPYWgfFp2CJIS0Qwa9Dup4Pxpba5Y6BZN/ECvd9SkmGQiJvWejHcpl6a77/KfO4JOTOx2Z+qB9ZP+tqRyrMW/2i5RBAXbIaPCK+gj/szRmiLilxaY2xNQaqnKVAFoHkEprRfTNLoZFJangDWjgB4uaNgYMBs5Dv6SYFpW42RFGdS5M+SHRWa663F7J2PWrW0QitqIKZUIBxClNHDfGfWh4eklmJgslE9A20U/+NX2MiyyUmZxGTFNHMqwjtwHzyOJj0M+dWmIKDSD38LQsJ2JMHRkPRUuaOO2Vlb8I3Uc26t5zh0/cZgvXHs/9GNwjDoyN2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=My24LlDJyOsjOyX8HI6wIQkfNsPWTSeEWuzPouIkp08=; b=ISkdjELMiKyC9tG1kaztAzlRNTz7BFKeT2JIEO0f433L4SDd1buprlhdkpoIJzkByS/i+KU9BQW5s96h/LvMZe6xMBJmZmZmNtfL6xhuGRn6GPUGbMGkaZhdEAek/YZcyEyCOlRw66JUNYcZzO1/HO3JV1bhyoV5UZCYMfVfBeTttd3fKKHqk7GgBxIVW1g9+rfnezOKT0r+Zk6qgi+sj5BM9uF+WOaten0/xSzpu8uRYI5iXPeS40dIaVEO9cItkWYPBXjY51tK0Sxy06OSbyJKNUrt/w9keGyWVwjY7GLntNv64b68kvLWUjIwYt+2iULTUGPTEk2NAmQZwX6akQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from MN2PR12MB3613.namprd12.prod.outlook.com (2603:10b6:208:c1::17) by SN7PR12MB7108.namprd12.prod.outlook.com (2603:10b6:806:2a3::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9275.13; Thu, 6 Nov 2025 20:35:01 +0000 Received: from MN2PR12MB3613.namprd12.prod.outlook.com ([fe80::1b3b:64f5:9211:608b]) by MN2PR12MB3613.namprd12.prod.outlook.com ([fe80::1b3b:64f5:9211:608b%4]) with mapi id 15.20.9298.006; Thu, 6 Nov 2025 20:35:01 +0000 From: Jason Gunthorpe To: AngeloGioacchino Del Regno , Christian Benvenuti , Heiko Stuebner , iommu@lists.linux.dev, Jernej Skrabec , Joerg Roedel , Leon Romanovsky , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rdma@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-sunxi@lists.linux.dev, Matthias Brugger , Nelson Escobar , Rob Clark , Robin Murphy , Samuel Holland , Suravee Suthikulpanit , Chen-Yu Tsai , Will Deacon , Yong Wu Cc: Lu Baolu , patches@lists.linux.dev Subject: [PATCH v2 1/3] RDMA/usnic: Remove iommu_set_fault_handler() Date: Thu, 6 Nov 2025 16:34:57 -0400 Message-ID: <1-v2-25fc75484cab+ab-iommu_set_fault_jgg@nvidia.com> In-Reply-To: <0-v2-25fc75484cab+ab-iommu_set_fault_jgg@nvidia.com> References: X-ClientProxiedBy: MN2PR05CA0059.namprd05.prod.outlook.com (2603:10b6:208:236::28) To MN2PR12MB3613.namprd12.prod.outlook.com (2603:10b6:208:c1::17) Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR12MB3613:EE_|SN7PR12MB7108:EE_ X-MS-Office365-Filtering-Correlation-Id: 350bd9b5-babe-4d75-603b-08de1d73f584 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|7416014|1800799024|921020; X-Microsoft-Antispam-Message-Info: /hNNiGNxQVSb1k+oxM3VGNepS8TVQUQyQWfK5qQcnCnAxC46Q8ER5JTDc0SoZ1m+WiwboVmoz+Q6CihwJxZVKOAs9XThRVk6tEOwjaC9KMYzKsG9gCyXRrG4eLNHtz5wpAYex4gDEtdbRVjuLtjgBix4/TnGrxWR+tQi0p7DwQlIZqv8pleM8M8MKOEXS9PCLzl1/NmohrWrJyh16VlgKn885rUFYSApbumhc98qeKaVS50TRwVdqamy8IrxSPg3+lNELZWr6L1yDqxl11JVSeVx5JhnuIA5da0Sr2fApy7ZwGy/U47hSdkO7WB4dBwqsi/VBjr72avLjK/T3NAiIdj6Cmo1ppeDalCG1DvuJu8qV2zkAhfHdL0ssT42WOwlOBfz3TmRr3pIOJ9Fh/9co5/TBew/klBNJiHdpeZ6e9HtAtoNAyN3IRE4bGUhNTWTh9hH1NE7XI7wr63vnpsPD96g6syw/Do2X9hHNWPKTkffYgEFvIlMy5lPGVxJgdGk2SZF8Kkb3fesnVNsPpf63yynGcE7bIJQfa/ozDHIadBUi2BGH1rzMuGPD1Q4VRL2N71e6yzNqLDLt4qyDhzfnr3fa+c4IDzAjU9lPRJyK9QHYHMmfjes3XBPURCX9+ii0wLe95dqzmEgkVkqDEXysB5mFPWlHtVxYdXBevEwqJXFEEncTEzWAJVdCbMJIzovL4iHnnFQJmmYnisu4LHBZUIEu6tyxvwIOl4dRVXESwCerE4vrqRrYApHEQz9ZkVuJ3vZyScN7y1NUuycv+tCpqHDsIHgUZbhYVVovSlgxDkqwgBilzofIukpo0ykk1K+eGIqtzfxMnS2HmGk25DnmmrcGxR9/9pQnpV2H/JuuHkc6eSkGIFBXvL4aVQDZ9JlgPA9TQfFRmg1/mdDUqqpiLZS4Q5AmVYl2NS0AsUnD/axhZoKMOUG9eDRi7lKuNhRq1UhlyYfToyIHrMH90Opy5aIPoAsHfeuymAjafuZPGd6IXpbAtH4MpMIgYtIGppNGv5xJEjnwYU9N82URuyCN83XTXwjpRJdYMoTyYXFxT0snXe+Nv1KQNGhIJNr/uMiD5Nu0kaeqopWVIDv8L+1n4f6pPtk/ynkoyX02rlv+SH0s/6uQpjNDrt62MenA4oO3g1dJ9eZAg8ruWnrakmgt2gVYGmpVXB6FNCkfo9dxo3VHsRx0cnmPkNJA7nFJyZJDcw1tbAyVI1EdREW6GR92gBP5G/g3QkDggo91kpfeqnkYHm5zE0MzkWvEZhmks3BIh4mnZuH5dKx37Z6sWBPq4Asru9qMo/HLi5IkVsnp0OwvK71Nh3J+rpks7uzljgNAm6Q1P1eBpWW7qqR/PXi1iEpfCnL2XdlcuQDXCHkY8ceASSA/PGgKRVw+TElSYFF9E4QuMmI5E+ELOGl6YSi1oclDvVuRckbgZMy2aJx+uFVcf2XV07EUC2XA+1v4cOEMMh/0hDZ4Qz+OZi4IXJGozOKfnfi+VPuizSLZ9ZLPnU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3613.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(7416014)(1800799024)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: NJNZpA6r43uGTdgadsolTzcWYr/wDpET0RpZlNUlehGPvTCZG6UUHPdKEi0p21eSNZDWtQtFjDZS3+5GOfmgMH7WTyBzmGeyu/2A0hhIkO8XfVje7FOe2twMFQ3n9ZMRxQsymyT+UUDMEVXca93qdGM6yb1XGl6TdD8sadcOkeJUMySbiBK4BXwm4jHAtIUzK2aGLxid1LZzz5kVWvd6tVVSn5Ws5FuSU3TQQ2T9tGiTyT8oAoUJRsIhcG0wEmNU+wwog7wH2rqaC/4AqEAUeW+PnJU24m4YZh9S3XzKJQO/ZESlQRYvYFrHPRYgHgBMCZnY7egyeDqTh6SOMH8bRiEauNEvKIhxp9wMAwSpitLcFuOJAUZrkdzQNk7XRqs4UnkL/n6G2Ab8e9N2wVusvrpaovaEbRDUzw7Y3L3Rjtbg0q0XF3s/In/fP3zk2ylZFcgpcBj3zQkH/DSyBu/0mQY3gnG8TiG4KiLK2ewZr4YNgeRcyMuUwg4hgbcMfOj00jxvuKTiaocRm1sweuqjBHWJe1cQID0T+0YgXNAizzo4Od2xSRQTApICcuk/8R53XuBV32WhIdUvETZOZytP08UG7myVA18XC4v6R1Ba/Lcz7gHsDgEWooXtgfcCRX1Qv43tj6iRXKkbXPbUXiMfONyLUXC6XCqdVn2vcSLp7Dd7WTkH3i9uw2HcZnw2vEwg6E8hdq3SVGXXwXrpwenMVH9lQHlbK+2dys7Gb92ndOnSIlqh+vbO0Sv+XFB+73EPFI0LWsdqpPSq+xhg+dY0TBNfKNlhF9l4/XQNgaTT8GhynDGO7RogQoRkGXkb1AX5YXvQE+OxrydvF8EGHA3SWc46EYsgmxcX3c4aNZHvz9Jin6Xj08zuZRR9u83ydd0zTM29PuFwX/nnYIEjFBJSV4z97dT73aMbon+SaU8tAvGqBDZgNS/W2msJzia1VEAA9BJXhhEoclv0NvU7FqhevPX2pm4YzZzeQkxNEhWWJOgoi4CT5naUxD49/ZZZMVAW9Dy/Vrp9IJlvVpJhG6L3k4USgWqvIV1EJ7nt0CavH84PgE12kU1HDZCkbLna2NDjMMS5AROMIC/xssvGucrVYDOVZ5SF03jKXiV8NQIkGXZTqWpgTqevV2o6D5DzDyBf2ynYWDIhP/93qECjPCZAF7Ble2xXtyFQLwfwXCXwyj1dtmUd/e4vEYm/YxdHJkIk7N+3w6DQoX3R7h+rwoR/uG8xeoLtYwbCzdfoFzzWdTazH+gFKQOXVXCpViId3kdyeUgZYqUEEcSChLq52kyMoB+ZTn3punRlwbLALUVmsA/EpuNlzG3pJVua+d+WVMz6HYwHzlvIfde/zH1dMeauzhhQV0Brt8K06ky93DS3oGwCe7RBY6Qhwu8sUlSwiKeFE8BCbOF9EPvIMUBbD4lIfOy+V0WhmtHc/EPG9khTAbqy0PF0gzuQ6pl3eLZhSLVp0pDGZXg+UWXOsN1bAvefhbO3J5JSdsFlPL6GPbYgGPq25J0fXXTvuQfDw/venyQCUjRLqEDTAfLRsCa/Siy3JNvAA9h1um90PPhkpoFAdUs= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 350bd9b5-babe-4d75-603b-08de1d73f584 X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3613.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2025 20:35:01.1506 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: syDgtu60NZt3FhIKphPz9VczI8/s093USABYwRQaN2GkRv1i6vr/yK0UhysmGCSf X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7108 Status: O The handler in usnic just prints a fault report message, the iommu drivers all do a better job of that these days. Just remove the use of this old API. Acked-by: Jason Gunthorpe Reviewed-by: Lu Baolu Signed-off-by: Jason Gunthorpe --- drivers/infiniband/hw/usnic/usnic_uiom.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/drivers/infiniband/hw/usnic/usnic_uiom.c b/drivers/infiniband/hw/usnic/usnic_uiom.c index 3fbf99757b1148..f7fb6246c83aba 100644 --- a/drivers/infiniband/hw/usnic/usnic_uiom.c +++ b/drivers/infiniband/hw/usnic/usnic_uiom.c @@ -51,17 +51,6 @@ ((void *) &((struct usnic_uiom_chunk *) 0)->page_list[1] - \ (void *) &((struct usnic_uiom_chunk *) 0)->page_list[0])) -static int usnic_uiom_dma_fault(struct iommu_domain *domain, - struct device *dev, - unsigned long iova, int flags, - void *token) -{ - usnic_err("Device %s iommu fault domain 0x%p va 0x%lx flags 0x%x\n", - dev_name(dev), - domain, iova, flags); - return -ENOSYS; -} - static void usnic_uiom_put_pages(struct list_head *chunk_list, int dirty) { struct usnic_uiom_chunk *chunk, *tmp; @@ -450,8 +439,6 @@ struct usnic_uiom_pd *usnic_uiom_alloc_pd(struct device *dev) return ERR_CAST(domain); } - iommu_set_fault_handler(pd->domain, usnic_uiom_dma_fault, NULL); - spin_lock_init(&pd->lock); INIT_LIST_HEAD(&pd->devs);