From patchwork Thu Nov 20 19:46:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Gunthorpe X-Patchwork-Id: 1871 Received: from CO1PR03CU002.outbound.protection.outlook.com (mail-westus2azon11010041.outbound.protection.outlook.com [52.101.46.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF8BB22579E; Thu, 20 Nov 2025 19:46:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.46.41 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763667992; cv=fail; b=qORYQc6AeCeKdDpFvvweUopoq+95M45kjRCwQvq6f/85ySilOt3EETgRNMficLw6wOYTTJYsPHipKMB2jPJQJLIUwqE+KpaTnPUISiM3H+aOpwYKkrX/yncN1h6VEORtgMxbgji3u+/sqtuSWVVciXSlno0jEUHTQv18tEfhHeY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763667992; c=relaxed/simple; bh=a7Ax+Yppx4sR06ZdgpuBgpBzZ1KcHfH9MK5sICBANxI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=tWf52f0XVquSLDzhLPpH3NOPVOpne66dwsYZ6bmeItZx3OhXYIXKwwsZD7HdPJoE/LBVTKRUDflh+GQRoEam1NKekOUVM5i4BgT9Qk7PrXvyMAVBKY/mtNRFIa4gnIQUMPL1aI9HdWKYh8kOFKDM16UyRx0uEEVo6whq9y4/btI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=ARbU2HsT; arc=fail smtp.client-ip=52.101.46.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="ARbU2HsT" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OiXL5d7IIjp6rAoSo+ZwGCqxL8JYUv6OjuCiQTqtSjfPa0XejTIJvQvxwWiuN6L3lh9h6AD8aIGGLva+NGm2E6Pbvq9IhWICrFxd44n36C7DYHVAd2Pcn61iNg80zgHIIUKAMXubdfTNACqzXKjtXYCeMZOvK8btH7J1sYiv2QSxtowV58qr3RszqoRp4vh9VqAuw40G4Jcd0NrMTiR5Sqx2UIY6iYoM5rYQBZi50KOGPUoYUrbsXRf7OCKUvwUGGyqxJ/qXMjzRSNgV/zk39aNy2hQl5yZByI8y/s1w6F7fucPbm6VfSrdxzjcgalo8vFrldUDPc7Zwnfd0PrOSfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jrKyptjz6cNmuGFVbRBpKvvpe//IznQPvngnXo/D0zE=; b=h30aTjONQoHTs2q6MLS04+WiaY0i6a0Y85IQ8/AXxUUBvtMbHg9iyLQIXa4p30JeaT4qiD3z+yBBg49feBm8WOsxT7m89k5NaOSMCLvD/9+qYj96jraAQ/KPFm2uyFD2vpkIlVcEzVUil7vGw63l+E2WHAoK2MuZKYrAtZopq8A8YpdwsNe2cfXkB6Vky+SZ3UI67sy7Y7NEWl+oTlxpsOpE9NENAr90dIZI/qjXgccE1bC6nzJmibtu1gyiYE79UwlqvesFmnLZE0ukRtd5LmDEWqXmaa3rEHBvc4356JBzeE9nG7W+lRs+BaolQ9Oaj4f09lu7K6pW5e7lrXZU4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jrKyptjz6cNmuGFVbRBpKvvpe//IznQPvngnXo/D0zE=; b=ARbU2HsTVurivnuXOyo8RKIlusvCiQIbO8h8sfbNlhuITvH0L+RnZt6IPhw33q+aDgH5tMIK9K/n8xSqQPlE+L15xcS+11uZxpNTX3isvqtpc75a/B4XXuWW5HBn8VlGgCq6k1q8JUgWOQJfsEgEqgKfKpm+zJn6VjIqZO/7gP1RmH1St+ICc7axpPdJmDWPuJ2X0m1QC8n3cimCs94DB9ng5320dwcXfIHYi7tGtLRm1u2T+ZQu8jSIbj2tRdXgHKUv3pohpGK31Xc0EjSzzXJ+nhqTdhWQxC8QFmhuVbmA1xHXg4phNAc91clXgTGZwap1mLX1Qs1yF0PZljY/fQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from MN2PR12MB3613.namprd12.prod.outlook.com (2603:10b6:208:c1::17) by CH3PR12MB7716.namprd12.prod.outlook.com (2603:10b6:610:145::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.11; Thu, 20 Nov 2025 19:46:27 +0000 Received: from MN2PR12MB3613.namprd12.prod.outlook.com ([fe80::1b3b:64f5:9211:608b]) by MN2PR12MB3613.namprd12.prod.outlook.com ([fe80::1b3b:64f5:9211:608b%4]) with mapi id 15.20.9343.009; Thu, 20 Nov 2025 19:46:27 +0000 From: Jason Gunthorpe To: AngeloGioacchino Del Regno , Christian Benvenuti , Heiko Stuebner , iommu@lists.linux.dev, Jernej Skrabec , Joerg Roedel , Leon Romanovsky , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rdma@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-sunxi@lists.linux.dev, Matthias Brugger , Nelson Escobar , Rob Clark , Robin Murphy , Samuel Holland , Suravee Suthikulpanit , Chen-Yu Tsai , Will Deacon , Yong Wu Cc: Lu Baolu , Kevin Tian , patches@lists.linux.dev, Vasant Hegde Subject: [PATCH v3 1/3] RDMA/usnic: Remove iommu_set_fault_handler() Date: Thu, 20 Nov 2025 15:46:22 -0400 Message-ID: <1-v3-e5d08e2d551e+109-iommu_set_fault_jgg@nvidia.com> In-Reply-To: <0-v3-e5d08e2d551e+109-iommu_set_fault_jgg@nvidia.com> References: X-ClientProxiedBy: MN2PR08CA0007.namprd08.prod.outlook.com (2603:10b6:208:239::12) To MN2PR12MB3613.namprd12.prod.outlook.com (2603:10b6:208:c1::17) Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR12MB3613:EE_|CH3PR12MB7716:EE_ X-MS-Office365-Filtering-Correlation-Id: a96c500f-b0a2-4705-6e61-08de286d7d2e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|7416014|1800799024|921020; X-Microsoft-Antispam-Message-Info: dF1PHsy6GRLGjB1eVe1VV8uhvjdAtzgSlW789nTQp5pbD1EKYVhUIEf2dLUaLV+xp3bILrz6F3w7hz2BMEcdOKUDBXh5dUK3YNTQUpml92jsX80PkeMW9aECKSy1zC7syhcb4VPm+0fnvH3AY5P6yzBzHH8kan/MmVdakgF+XWcuqVx4HdxLazguLLDTTP0HxjmV+fBi/PV7noERvw5//x56NV2UfKwJ0BpU/s0J5QLIXoq3mhbdxdd/YsM548NkBrAb0gYzRLhIhF0V8TqzswQ2WtUfVYVEEiD3ZnZP8YOCJmOrBMsJCl2X0AI3PdSgiXNBM9W1aJrd11uQIpOkfoDEQmXlbUyNu6+GrIaSdJmYBKvwFSKBPtMFrE2Y4j0avkkcxs5VZN8Cav7+YKNl1VLqDHMfcOf5P2sdiSjmgQNoANKDGDi5DLMmBIJdoUwcdqiNjPB94A321LSrgYTrCIlJyEm/re+cdi1Bo7Yc8l1OscirRCwhqm+2aLQyDV89N7qY/SnvI1aiAqoFggCnsN6gUE16I0KjEkFjTAoQYnanDsCmWPkMswghsWzL51oSRkDH/CMoQ4zz6RxpvIDUnvNE2cvr21ahZi2lJ22Nl84AfZBAqFBtytYnIJ+D94RrVGjUNv54E9AX6Ah9ZtgH/oZBhWF8JYqAsmZT4nhoc71yEPy0IeFQQDckNBXcZxIuAe2TfggSWpRycmQA5DFLLspHWodypwMt43S7s00Of5uK+8Xbdea0EiW6Iy5KXXbkvBAGfTARFafCqk9H1vde7Y3acU3JWpYkdJTVXiWrBowsIHw5HPS5CLrVDoku2EuXROGTT7VZvOJwVch6cmWis0SOxzuUf1LaCyICcedya363WTjSfowmEmPN+YTRcHBpiaRRhag3vddPYMDOLuaqYjgOHuKoKsygIawcXyHEBdqK/CYRlIV4pOoYLgDprH7ZQNnPqANcfgt8s0PorZN8rp4PX9kYWEvBF9svTQ8WrtqcbcQLWbNaHjKHfdP7f6I/DdnwiTjFqyWgiOfVQVaBxWZ/qKHRxqugDXUj75URyCtohZ4w5ffxzKXqESl4tIYs2vk5Qvqa/3+ZtKuSKwjIwt9pmk+epOsQVM7CJwosTes7/aqdpBGfVOzvJ2vFyaW6AhcSp92xO+ouL74wIILZ8BywEzKYeDmXfiOHmYBvQiEJxJ9PwUtpgSM7ypIhFxh4DwesmXdEzOeMP2h3epd57U9UpLv4oLqGfcxgAJgepQdIxs5h/JGqnV01HSJF5MexkLT5vYvjaPZdqYv6LASaD9QmjcASR1RdC9s8aN0Pzo5kr1lIhFM/FF60hr757sPPoLIYAI4JeuFCM5gx7cGSEcQ8WT63CGZRXwO2++RfUq70jajQ3NSEv93UK0l5M4z1E1cwSztDsTsGLkF3LtGkcCLK5g1o0I/1VjfJsIviu6e+J9wGqyPyJzBQHJ5DbcfmOiaWr8IrgvtAUlEThkDGx1QU4fdUvQjSwFjX5omGqRw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3613.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(7416014)(1800799024)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: RGlPHjDFbrBxcG+C9N/LHjqlls1Uy2YcwC9ThDri72VUUVTGaXMVcnHDfAK+FN88b2b8UP8ACdkaWz+EHrWxAiu1q4KY38XovINlroAGTDVCZI4dGY3BccWim6iwzjliTKSZHECvQFJ5fD7Pv/v2wgvS73TXncToPB9rJVYr7Dawkw4WeSPKzxiaDX0PKXMLWLFkLRJP5irpZhG1NH+vF0wU8sGWdD2WqW1fEjSqMm/MlKZRdUBpx539d8seF3dhHC8Tpv1Sk6gMj9y5HEElljTDydIUf0rjLbJnjYE5eeytHsdNaHr3vFpwwgKNIjdaVCQL6eUYrplxEeBkrwknri2wi35VL5S3+i8cgpUOTeDuX53Rc+yNxi/tJGPGASqrxHaxnZPw5nr/8Se+oYTRStjn7tQG5D0rh2wVtqD00HWq/AkA4JB4eg5oqyLarJwyfmtpHS3cyRaCR9wwKEhTqcvA1Fa2Ju1MfKpUSNJwaGEKcYQpC9MmDTp6DqWdjelH5iXRSEGwsGWcpYlAV40wlhTwv4gke1lptvj7EJtjUnayhZn5rRRDQ5fZXwPHY0zugnkh9zlzvw49UBIeNvZiHMJaN7Mlo91KKSrJ3BeGPDx33n4LIZAKl4nl98xscNnhf8rs5f3Uu/UtnnjtK4zb/LEcmawIxt7hZhCJdt7VU8Aw3XjxMSwRoqOHqyY8FkOcCraZ1n2HzJ9/Lioft1cKs56zK+ABsfVsT2Wur1lyWZsT3TPP0Dk/NaD13SfG0CD7LJXN/GM/fQGOPgUeFL4ZmeqKGxIe7lQQwignSE6mQ/jcmGsDKQPYHCvXMqyTZi1Ut1huZTmGuop1EdpO8vr9bgBfN10HPcxc97qarubiv65n++T+blsQgfKC+X8ipAAKrQ8don6ybyyonsI/OBLbdBKUhS1Nh+lgr7Fmn6s4xj54UkvkWKDmC/ktqki50c08zCOjWPnLMgOxfh+AA+EVadfqLBAQvgOwKUQ5V8uTV1Esxw0Oen1paNUWf29WCfdq0M9p4eMNRlnLrM19TrMIL4a2AiazeLlVyW48ocX1jjwjqbS+aP2L8PUWjJFg6efy6h1wu/cfYk3ZWlyNSxNdY89gpbKVqc1JpeoAM6olBOWuHf8w2PKE/Hbd7krkZcWthc4TrU1G0hQRYhkANsVXV5ILqOW+IzBaLDezDNfMpgqWSp93xne3F+IxSLHBJb619PzSQPWuTZ1NyWZhQNrGzwRkgFQcEM/eorQb5SY7IIkV1QcLkzFdDpoyg/pgmruQM9KlMdGEwvXbiS+yW8oGWYtFZXA/w8EdayPqOnz3Gbzagg6+z0G6es8PMeKt1Bk7wrPteIDT4hK8GmZHe9xDUPfHLjFsSUIzKkFRdt3yFt+BP41ccrRI1HmDfjBKJ7zKgoNzWasww+QVs7W691gDtrkwxA4qwV8SehgvZgQmH/PLUL6yzy2aZx/rUfx0BlzaUCxlJHqmVW91PwiUSVJxQw+fPFx6KpupMLbNoK80u8yAextQpSn/gh28aK13qGf3xSK9UIjue1ZtPatodlVF1xawVIJBjdu2IioreGrZRtA= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: a96c500f-b0a2-4705-6e61-08de286d7d2e X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3613.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2025 19:46:27.4184 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2wbRwO94rnDJ36fZ+w4citcVj0xSOwKpXwrR0gxvh1N9Kf1dOGnlYHjq20+n+8iK X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7716 Status: O The handler in usnic just prints a fault report message, the iommu drivers all do a better job of that these days. Just remove the use of this old API. Reviewed-by: Lu Baolu Reviewed-by: Kevin Tian Acked-by: Jason Gunthorpe Signed-off-by: Jason Gunthorpe --- drivers/infiniband/hw/usnic/usnic_uiom.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/drivers/infiniband/hw/usnic/usnic_uiom.c b/drivers/infiniband/hw/usnic/usnic_uiom.c index 3fbf99757b1148..f7fb6246c83aba 100644 --- a/drivers/infiniband/hw/usnic/usnic_uiom.c +++ b/drivers/infiniband/hw/usnic/usnic_uiom.c @@ -51,17 +51,6 @@ ((void *) &((struct usnic_uiom_chunk *) 0)->page_list[1] - \ (void *) &((struct usnic_uiom_chunk *) 0)->page_list[0])) -static int usnic_uiom_dma_fault(struct iommu_domain *domain, - struct device *dev, - unsigned long iova, int flags, - void *token) -{ - usnic_err("Device %s iommu fault domain 0x%p va 0x%lx flags 0x%x\n", - dev_name(dev), - domain, iova, flags); - return -ENOSYS; -} - static void usnic_uiom_put_pages(struct list_head *chunk_list, int dirty) { struct usnic_uiom_chunk *chunk, *tmp; @@ -450,8 +439,6 @@ struct usnic_uiom_pd *usnic_uiom_alloc_pd(struct device *dev) return ERR_CAST(domain); } - iommu_set_fault_handler(pd->domain, usnic_uiom_dma_fault, NULL); - spin_lock_init(&pd->lock); INIT_LIST_HEAD(&pd->devs);