From patchwork Thu Nov 6 20:34:58 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Gunthorpe X-Patchwork-Id: 1874 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11010065.outbound.protection.outlook.com [52.101.56.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90679322749; Thu, 6 Nov 2025 20:35:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.56.65 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762461308; cv=fail; b=ldUB4MtwCCmt5hM96AX48xg3yOyK2Nhy/kmjyU/dwIvIlhpFrn6FrM5UQkjeVO2Eiu0mF4QuAq5xYV4s2rSgKFeUsAYaAO7yWjhIS515C7heDBCB7ctiucdAYstQn4hTk5y5udaPLM30Jux2GpCkyiF2dNFEyh1x2Nv0fiK3IxE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762461308; c=relaxed/simple; bh=saViRBSYGQD/H9+MPVKU7BcIMTkHFwK8T+W+wsoDLLE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=NHn72g9J9Tp0qPGynAhX9ibab2RYWLmqbuIfX1pk2OzgNyTbi0/S8DGLXZmv9OUPZ5HSfTp1UQRnQ+PPQMTNSntNqQrX2bddK1QdB60+ga3k1vi3QGkkDMtFtYhgNlNiYnXbj+QjJRS3EL7dSsqTKnms/oz7g5aysl+2EK1d4u4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=pRdHebZT; arc=fail smtp.client-ip=52.101.56.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="pRdHebZT" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=siscO6r0nSEmJC+6CtQGVU+UOz5T5b6ZeTLNY2EmVhBgv2PIoOASLXZK8AYC4kxkL/UnJxTT8Y49anHPfmGsRyXmVF4DqPP33eFwic4aIcxYGPKXClXhgUfkTXfuetzonRnLwHHgxgLOs/FIKzoxWttMBZs3YQ7GV3YQLIl/rphrTjcjB3hydF68ClknEbmxrQot0Ib6RCljyycz+19jCogMN6UOnjp2sxmCSw8uqlVB7azrtpSOeb67SrDMDwOGAy74vdajUcgG2mjiPrvEnxMVvYqmjQGl3q449KzxH85UGDj8Vb7zIOGBTI6fTm2nDXjiyQa45bWNOnPeiyRzzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zhb7BPdH70xcuNod0R5kyK2egKSNweuQW35kisBqYpo=; b=E4/onS6ZN7QqiV6rKylBgR2NIC1+NWQvgGdQrATnTVDKc2Npd/fgwQJlYrrgv9lxG54wssrFVcDs4KIPRhGbA9l7rdhXCdrXu5nQz5+JzNyNRt1w55IAQAMMHz1RyRUAzEDPQtrA18givA3Q4uF++8a9A9mLvv2R5vznVE8Z8vbfT+p8fcqnnufIn445HtGz3JtiIFUq/Qkoou73lHcmVI/LDIeUO5VjjLxswUCPdB3522glzdhfPtvAaUc7GgwZwdh7AiIRmzxHMGfA84WBmD/FWxZDUyY6ojxY+RXihCP21ckn1kVj0cLEvciaLHmE2a137+mGaCoAQ7DtIY3Djg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zhb7BPdH70xcuNod0R5kyK2egKSNweuQW35kisBqYpo=; b=pRdHebZTGv11T7nrM0ZpxhD/b9ojM3x1vLO4bVQCOx+bJi6oNQQqQCYEfdGwsIxgkd/2Mujlkq+fJGlCsSjZtYDgnCcNuxzRfwyEDxC2PBGBXzj5n/ozt2oVND8e+JcDpHGnlNRz0d/KH7Ut3KlSZBR391wilE1eCbFZM7bQv8pJ1soKLKxoTtykUzMK3YVLry3LGE+99CXnsBAAsiXh0402Ve6IjgGmtUtztTCbuValBJ83u2iLjHAjmddOdT+SfCH+xFhCwBJkCXjEkl3Xh9c4dFvE2xpCAJ3I/jPnTsC+qY0kyaHyHlD2ggxsBBB0KVaZUJH2lVFRjLyoW9LvKg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from MN2PR12MB3613.namprd12.prod.outlook.com (2603:10b6:208:c1::17) by SN7PR12MB7108.namprd12.prod.outlook.com (2603:10b6:806:2a3::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9275.13; Thu, 6 Nov 2025 20:35:01 +0000 Received: from MN2PR12MB3613.namprd12.prod.outlook.com ([fe80::1b3b:64f5:9211:608b]) by MN2PR12MB3613.namprd12.prod.outlook.com ([fe80::1b3b:64f5:9211:608b%4]) with mapi id 15.20.9298.006; Thu, 6 Nov 2025 20:35:01 +0000 From: Jason Gunthorpe To: AngeloGioacchino Del Regno , Christian Benvenuti , Heiko Stuebner , iommu@lists.linux.dev, Jernej Skrabec , Joerg Roedel , Leon Romanovsky , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rdma@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-sunxi@lists.linux.dev, Matthias Brugger , Nelson Escobar , Rob Clark , Robin Murphy , Samuel Holland , Suravee Suthikulpanit , Chen-Yu Tsai , Will Deacon , Yong Wu Cc: Lu Baolu , patches@lists.linux.dev Subject: [PATCH v2 2/3] iommu/amd: Don't call report_iommu_fault() Date: Thu, 6 Nov 2025 16:34:58 -0400 Message-ID: <2-v2-25fc75484cab+ab-iommu_set_fault_jgg@nvidia.com> In-Reply-To: <0-v2-25fc75484cab+ab-iommu_set_fault_jgg@nvidia.com> References: X-ClientProxiedBy: BN9PR03CA0741.namprd03.prod.outlook.com (2603:10b6:408:110::26) To MN2PR12MB3613.namprd12.prod.outlook.com (2603:10b6:208:c1::17) Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR12MB3613:EE_|SN7PR12MB7108:EE_ X-MS-Office365-Filtering-Correlation-Id: dd24b312-92a5-4bb1-2ba7-08de1d73f567 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|7416014|1800799024|921020; X-Microsoft-Antispam-Message-Info: lHtfvcZ+BjirXdYATX/pX8iZuZWMUdtgRodlMtGG9ELFOROlRF27ZjJIKZvnA11xVVALtaKAEl6G2Kr9XlAqtL5W9yFCLdlsEP/ig2uNKprmCCttsbL95lBfjL0dxEh2kuLRIqzAtYFB6cqTyl903NbhXVSAx/JQNkCACDV5Neim5yTyNxhJ2cC5bP7imAd7OpVdHhahJgVwJ+YIsoD+jEbiDZo52WMQxkpJhJwDVxbs4DOaLXFmBkwh47GwDLKXjdrOBm5NbSUfrFr78RQzNR3SRoZKfnmIXSPA2c+6HtB+Z9Xqe5ZNaqEKt+8RaKuJUaqkCdfHBIB3QAtbcUQbd+s+oOVSUfWh2SVQpLIt9bdqfyyL/3+sdBIXtH1bXki8x6tIVVBgM4VcUP/A08V5Kj3viq3bUbJn1ahBi/WwzQ0e3/pqydyuIQ0XEyCJTZDI+nlSSe6MPm5IgVc2GiwltMRDCd23CsEY9UPzGFccHZLTsCWZiCiwKT4dndWwcvkXp9z7Fm9Mn/m5ml1XNmQtzFK3f3MOyNuRC/Cr5bzRuvo/+FYiIzOV5ZQ4FfoNJ02tPyX1oFSv2SPMciCVbRSRGajSvoi9fAfOV/BLENCJmYyg6QqxCFdFTqjKst1M+FNakRnQJtJyS1Zknb75MvHscIkIrevWP61oF3uIozz+FXkLwirYK6nEig7Vv59i7l/7fRuCU3ws0oGJ3XasqcIPHChJKSZfwluMaaOCKyzo4JvM8Fm7bfoF1dflUTZNUMcqQNQfXfrAaZ4UcYQ7UXwcyhMVGsCdb7VZAy7bv2jvugqTwWcH0CVzTZHIncnYu1I3ZWCsUDNt3l7w/259DSTsV9KwOEw3tssEWdwxWLYzFdH3Rsa4IMrORL4CPTLbnEkuzq17uheHHaMupNWW8DAR44+xhEXG6sJVQEGlSGvLZV/ULGgC6yHp6jUtm8L4QYkNjCQHf10l0i0DLR64vEjBVwORPFh1UdRegnKkJIwPcIDEI65f+LxNPQk6s+mundvqhVMRFj1U67mQy9MlHxo8Cxp9ecte7ayPccEMIAXygrvu1jhWVszsj7DWcceDv0VEu3LdD7IulH45L3d/IhPlnUe412n+WejQOkvtou3DjmjvZe+edUHiOFRdU5vrXwuxBr5oxb9/VqUThG4z/WtXtciXUsZcekcPKW78eCg9C6vZO7T9dEN+UGUoO72DJDTP8wbXiptbZ3yizOCCRqbITVzWDJwaAS0/aqh7yCzsTuSpmazJGPqDZWnIylSTm9vTcYCUadrg5s7hZes6YiD8ZFatcKJB6BqGPZTgySGrQEsrdWcuzhPh1S+l8ZHDeQ0Xld4+75LmumP6qkIs+6gLgODQvIGY9PzjJrjcs9N54tVcu475U3zIhN0+KM5JNRd0hptywy+OFsMDSdFnJuXvvYR3+7E+z1T+polzqB/nksifkWYIanUUZVZspipQAfcn27NDWG+qlqkWnBH1OHU2fzyxuDgba2kV4EFK69UuFyw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3613.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(7416014)(1800799024)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: /ljrhLXu8VROTxdtfdnGjfphwC7SwksaJIh7sSbXqCQechX88mt+jl8g6jy6htYW4we6rRWhaSIOqf7b3BFc9TFWVKsEj3T7YGadh6AFzkUmOOP6IlfjPbO0T7f3CgE9P3eaqSnfQosnOp6GWe72Yx3ajpRMixcUQeyyFrb+qWRSMCWcsMW398p8MyL7tAmqn3dOn+dEfgz7atzJ/wwNWhMKx3H0J+lcVsqEUrCRl13xjl5PToRZn/FGjISxEx0i8tolXSg2xj4KpB+LDTeL1O5Y8Fi9sf1jF1Kp9IbQwq3i5+cBRL2epRcja8l/yLwVlvYPwpsHnfzRpQ/pS8e6bpmJPkX/cYCiLVYvJsvKNuyfUAcTO79c3RsvKI+YWZxtX/P2sZHcD9/49jFY6QSPVaj+X38nnTLyN538ns8QnL7DhOhr+bZCPG7GDmQJ6tj5FN1JgulkoSbstkCjQ2o8eJm1L2zCMiFHVBiAODYaGy4M22a17KOv4ipdAZbjdfBMLdvJNI86g1rqdrVFKSTQ/Di11ZootBQIKKiGxdPC34Xq4y/tw7GGX20/pnjroPV/45LbPp9OspB42s9ZaXiuhmoFcPQILElJb787gHU9N8Ai6N+sgNnCUbMYd6xy7mlRjbUNGSbiGA0Xr2gKaOkluBlGN/YimNUKkXP76pc8p288r575l/OMonLDlZMIe2Pb28qzp5d+zoSuTWKmCbck7cDArR8OqF14A8vVl0JbM9zEjuMZ/E+VtyJIdEkfzjerc3uICvGMpiqD1MoIqY6Ges+zXzQ0SrA6O/B6f6LtHwIbpHZ9z4dUzXDysCasnjbFCCNZPgD7p+k7LU6ra3i5ZH2vm0EhRQVXTVCIpu5EMOtpzUqZwdDg/jf2C00YxtyN+Ah/BYVbjAecmUR/LUXgTr0LDyHCjBr31IrxhB0KS728cCpdmKnDFU3FhE5oJsxWILeI6DvfbrU2fXtdkivia07Wkkxp+JYTzz2GXIjemRh5Ldgf/A8e07zU9U+iTfJ7nK8ps/3qJYKXcUR26NlhJZHrGh0xhIggK0gHQTwMAhSp8Ja92s34PYn6DvgmhnmyX6ng9Ul1fc/+7neOfbmpDvOAkI4DE7/7fDkMHqeYmvn0kIntAXeVj7jyRDPm9HpuJz7EgWcJ09uAc1+lMTmfnnIsSm979ojnGqDu/IEMS27+liYbaHk9B6dVLLSo16j86Lb8jdAYcAd0VpL322PqJBEecro0H2RZnI7xWqyNb9EDFMpYdGo3dprnuJmQgVPzbzqL5hrEU5O4k1TOWsvSKE0iUUnrUU+yggpMnaoqAIBVU4vWnnKTlCPe87MBg1XzLDS3wqOhRA50kmdjcVSiY/xc3IFlZ9WGrKXSliGI3eFVZpqAKzcSK6rRXCb0eHHywV8Lg+q0gk03EjJNdcIvVs0k2+Jcm3tmj7Srqe+9fQWUty6vbq/EgXl79MGtcUJNr3U/EFJ4AMqowV2BU2uURQBgZxTKoprRPPP5T04NSbeW24x5WuH5CD56gvvV/CZip2fK2zH5dP2UhnS1P6sKzepe5YWHdrYdt2XEUCbMKn4= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: dd24b312-92a5-4bb1-2ba7-08de1d73f567 X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3613.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2025 20:35:01.0463 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8tNmEd5UcuK1m7o2sA2RKD7UtFEqSHGRKqZscu7iMkiZbF9U1wuxvR6cWhjfFQYV X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7108 Status: O This old style API is only used by drivers/gpu/drm/msm, drivers/remoteproc/omap_remoteproc.c, and drivers/remoteproc/qcom_q6v5_adsp.c none are used on x86 HW. Remove the dead code to discourage new users. Signed-off-by: Jason Gunthorpe --- drivers/iommu/amd/iommu.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c index 2e1865daa1cee8..d4d9a5dbfa6333 100644 --- a/drivers/iommu/amd/iommu.c +++ b/drivers/iommu/amd/iommu.c @@ -854,13 +854,6 @@ static void amd_iommu_report_page_fault(struct amd_iommu *iommu, PCI_FUNC(devid), domain_id); goto out; } - - if (!report_iommu_fault(&dev_data->domain->domain, - &pdev->dev, address, - IS_WRITE_REQUEST(flags) ? - IOMMU_FAULT_WRITE : - IOMMU_FAULT_READ)) - goto out; } if (__ratelimit(&dev_data->rs)) {