From patchwork Mon May 19 15:13:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ovidiu Panait X-Patchwork-Id: 1665 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6672A284B33 for ; Mon, 19 May 2025 15:14:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747667674; cv=none; b=PunkiEjk+wHwkK+kHa6w1aF7aeJBGfqjtd0bRjVldunBYwtB7zDii9/T89uqib5wrOPlnQ9+bJ/2jXEKmkPnmQo56gBBme6gCmNhQc33DstHXWhtug+vTCv3GfhmF0n5JexW4gwsoIQ+nmLbr/HKSs42KO/DgvEYhDRqcxb9ric= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747667674; c=relaxed/simple; bh=uQMEZH2UY5Jm2u+FOuxDZp8bnbU3aSj7eRys9xEdlOw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pwWapSjHHYaGa5Mms4bCVCqsSsRf5gYYocwsf1/LiOoudR46vqS4zjjmMqhrv60rG+O+umw9tWDl687xdcFhNt7ZkcS3RKFgHt4/Dm3dRDJj10nlD2DhnaFGR8ROHdJGUA8OD5/Veo4Ge0MjUWU8GZ8PDmaem6Eqc9kiRjXbLKQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XTvJoaDI; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XTvJoaDI" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-acb39c45b4eso645949966b.1 for ; Mon, 19 May 2025 08:14:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747667670; x=1748272470; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iYtYa5Hmz7e97gZT2Sf2chY466RHYEoEJJ/npJRNZKw=; b=XTvJoaDIcueXTi+IOfs/pA/Tc7F9vCanHrYJ9yv4Mu5tYrk8sLTOS2+FpUzBZK5bzF E5gBGgtOm4Rcs1aROgpCVtDRJbMd1zG0Tw8gdGFiSZAf/fExPOvlzreOi8UiUODRSqw5 trDaPorlIFjiZg07QTZhjuzqkVA7RF+t6Yo3HCsErXmf3X6KTIrZDnL5q/yLiol2DFIb IiIKrDmOlm3SHRqBMg5iO8eyBElgM3yRNuc++aZl8zeX7eszp1AiYRgCT0DGCENhT3cp JfJfy3IuVq5x+s5e35NkgoI5DWcRDxD1FtXjNH8JaDZXSV86pZj1oZNCY+XQ3BLSHsd2 P0EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747667670; x=1748272470; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iYtYa5Hmz7e97gZT2Sf2chY466RHYEoEJJ/npJRNZKw=; b=wwz20kY7qvsNvJtUUuly+h14XlBxq7/XDvkHkLciUFtjCOcR2h1x3a7lLHrLSTYZmD 34H2YA1/ksDCs8et2O+tFudzrqAW5HMYIxPIGAqoeTV1tryaKw3CvO3+18Za69dNZeGB uULOLLvA/BHRN0vreTzvxQbOfxmWccj2PMRz9QHwFtUYDmdM/o6aYMidcvGccbzQLDFw cqSckDXG8g40G4mORDf0EITcvXmMqKrOGMJnGwPKAbpWe+kHBiV51gVC8cju+blLi+Et Sqt3Mt+yAy1L5dc9kh+YZQEmwqyy06EKciU//lMIW49rN4QGAIR6wMPK5TOa7kU++VFa YAVg== X-Forwarded-Encrypted: i=1; AJvYcCVcFh7bfRifpkgkauIBDsRGJ2ZclnqNxBpKOOgXO2HDW0yjmIt81YY6LeGv1ZIhXa/Xl7etjRosRLmJtw==@lists.linux.dev X-Gm-Message-State: AOJu0Yzyr+USl+mo4m8cjqqH7dh2bBEUsPGSKZiNWWAPM1OCjrUs2BcJ wNCgeL8+xYjaMFrHRRDDGPym+kyf50OKIHmhIrtprEA8DS2SGTvuE01A X-Gm-Gg: ASbGnct/rprK6LffDjPh/hrd3onCNPf9+AKurwX0hH/mEz+6O3sOPzsVmAbU23za3Fi EifP8u6GQ6ua8PJSFuPhZs2tBe5fP+Ds6jW8BsGPgE4LA/INnwSW+mRVZV1JW56v1KXosZwaIKX +E0cCRQU2OiDByevjV06o1dSlFyIpk0uPS9kPyhla3xBKKWTnbYHl+OEdEv/BYv8bujyoF4GOUY LIymM5kyWHs6ibQ7aMo1qBUD6ywn6vdBkjkN0qMRDEYE7xBAvT/VLBSW1MbhntJUMp1J0c6p2kT TeRQY1wE+XBShJRlL5ZCTXhdHDJboV8Wi/0r4CQt52OQykqg9BDWpjGMhpyz5BNSuQ/FR0V1Z6D ztTc= X-Google-Smtp-Source: AGHT+IEdFDlMvFo4JwLpnmG07B9+mYT8Lr9dmRx+b+IvnhMbKrdoukQEvMfyH7MVsguioYjxxvQVMQ== X-Received: by 2002:a17:907:1c91:b0:ad5:5857:ece2 with SMTP id a640c23a62f3a-ad55857f064mr687560966b.37.1747667670306; Mon, 19 May 2025 08:14:30 -0700 (PDT) Received: from localhost.localdomain ([2a02:2f07:610b:a400:6472:d2f9:d536:4c30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ad52d04b08bsm608522566b.13.2025.05.19.08.14.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 May 2025 08:14:29 -0700 (PDT) From: Ovidiu Panait To: clabbe.montjoie@gmail.com, herbert@gondor.apana.org.au, davem@davemloft.net, linux-crypto@vger.kernel.org Cc: wens@csie.org, jernej.skrabec@gmail.com, samuel@sholland.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Ovidiu Panait Subject: [PATCH 2/3] crypto: sun8i-ce - remove ivlen field of sun8i_cipher_req_ctx Date: Mon, 19 May 2025 18:13:49 +0300 Message-ID: <20250519151350.3442981-2-ovidiu.panait.oss@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250519151350.3442981-1-ovidiu.panait.oss@gmail.com> References: <20250519151350.3442981-1-ovidiu.panait.oss@gmail.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Status: O Remove `ivlen` field of `sun8i_cipher_req_ctx`, as it is not really useful. The iv length returned by crypto_skcipher_ivsize() is already available everywhere and can be used instead. Signed-off-by: Ovidiu Panait --- drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c | 11 ++++++----- drivers/crypto/allwinner/sun8i-ce/sun8i-ce.h | 2 -- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c index 7cd3b13f3bdc..5663df49dd81 100644 --- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c +++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c @@ -206,15 +206,14 @@ static int sun8i_ce_cipher_prepare(struct crypto_engine *engine, void *async_req cet->t_key = desc_addr_val_le32(ce, rctx->addr_key); ivsize = crypto_skcipher_ivsize(tfm); - if (areq->iv && crypto_skcipher_ivsize(tfm) > 0) { - rctx->ivlen = ivsize; + if (areq->iv && ivsize > 0) { if (rctx->op_dir & CE_DECRYPTION) { offset = areq->cryptlen - ivsize; scatterwalk_map_and_copy(chan->backup_iv, areq->src, offset, ivsize, 0); } memcpy(chan->bounce_iv, areq->iv, ivsize); - rctx->addr_iv = dma_map_single(ce->dev, chan->bounce_iv, rctx->ivlen, + rctx->addr_iv = dma_map_single(ce->dev, chan->bounce_iv, ivsize, DMA_TO_DEVICE); if (dma_mapping_error(ce->dev, rctx->addr_iv)) { dev_err(ce->dev, "Cannot DMA MAP IV\n"); @@ -296,7 +295,8 @@ static int sun8i_ce_cipher_prepare(struct crypto_engine *engine, void *async_req theend_iv: if (areq->iv && ivsize > 0) { if (!dma_mapping_error(ce->dev, rctx->addr_iv)) - dma_unmap_single(ce->dev, rctx->addr_iv, rctx->ivlen, DMA_TO_DEVICE); + dma_unmap_single(ce->dev, rctx->addr_iv, ivsize, + DMA_TO_DEVICE); offset = areq->cryptlen - ivsize; if (rctx->op_dir & CE_DECRYPTION) { @@ -345,7 +345,8 @@ static void sun8i_ce_cipher_unprepare(struct crypto_engine *engine, if (areq->iv && ivsize > 0) { if (cet->t_iv) - dma_unmap_single(ce->dev, rctx->addr_iv, rctx->ivlen, DMA_TO_DEVICE); + dma_unmap_single(ce->dev, rctx->addr_iv, ivsize, + DMA_TO_DEVICE); offset = areq->cryptlen - ivsize; if (rctx->op_dir & CE_DECRYPTION) { memcpy(areq->iv, chan->backup_iv, ivsize); diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce.h b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce.h index 83df4d719053..0f9a89067016 100644 --- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce.h +++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce.h @@ -260,7 +260,6 @@ static inline __le32 desc_addr_val_le32(struct sun8i_ce_dev *dev, * struct sun8i_cipher_req_ctx - context for a skcipher request * @op_dir: direction (encrypt vs decrypt) for this request * @flow: the flow to use for this request - * @ivlen: size of bounce_iv * @nr_sgs: The number of source SG (as given by dma_map_sg()) * @nr_sgd: The number of destination SG (as given by dma_map_sg()) * @addr_iv: The IV addr returned by dma_map_single, need to unmap later @@ -270,7 +269,6 @@ static inline __le32 desc_addr_val_le32(struct sun8i_ce_dev *dev, struct sun8i_cipher_req_ctx { u32 op_dir; int flow; - unsigned int ivlen; int nr_sgs; int nr_sgd; dma_addr_t addr_iv;