From patchwork Thu Jun 12 13:15:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 1930 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3997E258CF9 for ; Thu, 12 Jun 2025 13:15:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749734140; cv=none; b=hwl63+YMrMJFcEz5uyptD7YKcdjce4wZrb7CaZaxiRQzkm+87dpfWs00U9OHL409/IAbjHsi9AP/swfM3RXNopa7C48RTD3qUaL/WLztVNda/CQzR7pA32tsYAft8lvGCW9cYgyWVFWuk4aiV0pjC8d+wETIoME8cZRGAmRnDrQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749734140; c=relaxed/simple; bh=pcmGu317gTZwAy3/dan+A6JGqZDrA3MuzLVFRN4QaD0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Y10jFmSOQ8PFx/vHxzLXZub+nvOIK61idAWKL8DgULfl0Rq7sIKy3bFpEkqUrLu9L+ijCsxDbZflRiia1YThHGAF4U50qyv8Fj76HxD2MRut+n2GUEunVWP8nVKq+EJXQ7ImIDkp8lEtRvSZgcY/oXlVnNqQQULuyI7B/PLUH2o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=hoJoCor0; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="hoJoCor0" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-3a4fd1ba177so620521f8f.0 for ; Thu, 12 Jun 2025 06:15:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1749734137; x=1750338937; darn=lists.linux.dev; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=i5mo28r4bSLhtRxKleEgwjFwDjbfBKbh8TaaOWlq67M=; b=hoJoCor0PetCbj9agMZZUR666FYjV7hoZef4NHNTEFo7wkvBLGYPi5LrdcGaYrmI7g Is2IQdgfQCwhE1JzxIOZqTVIAlE+keCBF46GOjp/TctDDU2Jkua0mbptEWHGiB4xeJP5 sdkURpzdwDf1UZQg6PyJYPLVKZUq3JvXd+b7k62eSZOnuIdcKhBOUmAKpgyc5biQm0WN n07am0QvNzheAigesZZhC718xFyZXQb+lxLmI4q+KGpjZXUJmbieXbrxaX/Zf3Z4R6D+ No+SERb9Fvb7HSVXPaQbA3N6g8jdfI9Q97dWW8ZeGZko1yacoala5s38McKSOgd2m1PQ Zffg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749734137; x=1750338937; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i5mo28r4bSLhtRxKleEgwjFwDjbfBKbh8TaaOWlq67M=; b=Xcs6vmedFlpPzY3yFsiMvfLy0FU6f6Ayy/JL7vP3G03thA92kMqnKFAIBgNPDNcYlV gLPljApni1nVztP+6pBP7/wvW1ieODHo/xKRk/gjgnZdxfM4Gm7sKuwnu6/vURoGtvyT Elm8SP4WBVIL5WswV8jm4z9W9soZfOqmJuijAmnN/6XN0y8DoKyhPhMyvqNUEDL3hcda y4hFSy2oaI/coOwB9yNR4hKnpC4bu4a6w9tRszXwmS3amvmhO+CJSowojbPpL58+7eQY 4y9eJgS1GBB2jD2NuttTv/fGf09YXUHIVO3tteEwEnayRNlK+LZ0qBV+UIKIsYMfRHyz JU5A== X-Forwarded-Encrypted: i=1; AJvYcCVicqblDUc6M94Hy0vs/HxmS50nM/SU7U/Hex7iOeD5UEMhZCwxrwXLhMG3iqv/pG8tfgdwkg==@lists.linux.dev X-Gm-Message-State: AOJu0YxdFJQllSX+aZ79rnxa7Kt/q60BuVWadld7e98vxW+XlRnZMsMG dsthjWyNSib44z0FbR809Kn/oP1KzxYvhUl/7rNv94rBXzSW/Vx09r4MLJ2/Tawt+2g= X-Gm-Gg: ASbGncsYrM2upOWK00JQwF5hgOckqHUqyOQ60oCs7itv29bwUZS4km8PB3+NU9jN3+F zq9srEIoZC6/bwGIj+k22EUcBg+pb0erBnVQEDQmmvQt+iJHvCwzZwsO4y1X3lBx/QiG7QzE10G pMTfcoOrzbPlQruAanATMj3c1u2lMXel+F0Acy8tvNiWezPVsopdX4PsCap7PAR1CkpSIs54AuC 8p4OrgPu1NnGdlL57SAPcFBiKZEpvxiOvvh059833scPtYircX7JUao9Z9ectCBZEL1FslO0tKc iwaIw9ski6sEuI4VtXbAiVzSkJd+SKpy9FHhZypQyJhzRRHk6IgqVQw= X-Google-Smtp-Source: AGHT+IGBzR2mvuzoTZVHlKLwIjCRQmPWg1494+jjoGTBRb95NjkbBovSMnn1G3/kvKyntrJFTjslYw== X-Received: by 2002:a05:6000:1acc:b0:3a4:eb7a:2ccb with SMTP id ffacd0b85a97d-3a5607fa6a9mr2706309f8f.16.1749734131666; Thu, 12 Jun 2025 06:15:31 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8b99:9926:3892:5310]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532dea17d7sm20619795e9.10.2025.06.12.06.15.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jun 2025 06:15:31 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 12 Jun 2025 15:15:18 +0200 Subject: [PATCH 09/16] pinctrl: digicolor: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-9-556b0a530cd4@linaro.org> References: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-0-556b0a530cd4@linaro.org> In-Reply-To: <20250612-gpiochip-set-rv-pinctrl-remaining-v1-0-556b0a530cd4@linaro.org> To: Dvorkin Dmitry , Wells Lu , Linus Walleij , Bartosz Golaszewski , Patrice Chotard , Support Opensource , Baruch Siach , Sven Peter , Janne Grunau , Alyssa Rosenzweig , Neal Gompa , Viresh Kumar , Lakshmi Sowjanya D , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev, soc@lists.linux.dev, linux-sunxi@lists.linux.dev, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2000; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=OQugchdrkWqDPvdem4KQYa6SyzhpAo4iCK+GSkQ42zM=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoStLm65xc3XhSAXLjOYJrRx8iTF6Z3NPsxp5s+ otU7k+QhaWJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaErS5gAKCRARpy6gFHHX cpxgD/4qN100OY/e/Uz3KaPovCgsqpm2wpUtbSiYEFHBmHRBGLuf3ySBpaIk66jUCp2HK6IC/Cu 2rqLmWG+B1iFpS4BnVMqobo6XmQjO/ARjPAV5Mt5CaDoOoTOhpLoNchztmEN9Q2JKULHtTgCqhX lQHrPhbY/9i/5W0RbV5etGdJItUlMoySsE119JLcLNM/on+dOLWMt+O3R6OFQVbA2Ax1wh27sWY 400r6LQeOyu7NOnJX3zbqfwN/N+J2L065B6bTivK6wSYzswkHHRl1mWBdJI08KlqfsH6XPgQFQw JX9YVFecSDqkoVn+ypM6aD02FboP/q3cvaaUBgxUNeZX30SJzwt52lsSpg1n+Tx4J77UuEZyss+ GFY852aRZcZxAim54v/DC23tAfXW37EDYmRMBWXAr+q34Gz7l0YcsBZVHY59CfR/16FxKPEggg/ 3iQYJRkgoOkddEdzxoZ8j7F7myunohSmcOCpD5Tu7Ycpzt2nb9gQzdsAwZZixXN2jBJxs11uOSl KaDj1iHD+UyHxRyF4uxpTztdkNsHGKodkqbgajWh9wCY7oxvodduH64VwV96QA8h2NgxXxorrg6 X3fbAgBNYIXJF2fF+V2DAOgvtIyTF7nNrlcaKu7z3fq0cycKeH7OGmyuh2ikwHlpBgY8Zj4s2kM q0e5Q8QmLCBxxSg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 Status: O From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/pinctrl-digicolor.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/pinctrl-digicolor.c b/drivers/pinctrl/pinctrl-digicolor.c index a0423172bdd6d8600fcb56a542ef498e14308968..1676cb3cc4c98755d287d3d87ba682ffc61192a1 100644 --- a/drivers/pinctrl/pinctrl-digicolor.c +++ b/drivers/pinctrl/pinctrl-digicolor.c @@ -182,7 +182,7 @@ static int dc_gpio_direction_input(struct gpio_chip *chip, unsigned gpio) return 0; } -static void dc_gpio_set(struct gpio_chip *chip, unsigned gpio, int value); +static int dc_gpio_set(struct gpio_chip *chip, unsigned int gpio, int value); static int dc_gpio_direction_output(struct gpio_chip *chip, unsigned gpio, int value) @@ -216,7 +216,7 @@ static int dc_gpio_get(struct gpio_chip *chip, unsigned gpio) return !!(input & BIT(bit_off)); } -static void dc_gpio_set(struct gpio_chip *chip, unsigned gpio, int value) +static int dc_gpio_set(struct gpio_chip *chip, unsigned int gpio, int value) { struct dc_pinmap *pmap = gpiochip_get_data(chip); int reg_off = GP_OUTPUT0(gpio/PINS_PER_COLLECTION); @@ -232,6 +232,8 @@ static void dc_gpio_set(struct gpio_chip *chip, unsigned gpio, int value) output &= ~BIT(bit_off); writeb_relaxed(output, pmap->regs + reg_off); spin_unlock_irqrestore(&pmap->lock, flags); + + return 0; } static int dc_gpiochip_add(struct dc_pinmap *pmap) @@ -246,7 +248,7 @@ static int dc_gpiochip_add(struct dc_pinmap *pmap) chip->direction_input = dc_gpio_direction_input; chip->direction_output = dc_gpio_direction_output; chip->get = dc_gpio_get; - chip->set = dc_gpio_set; + chip->set_rv = dc_gpio_set; chip->base = -1; chip->ngpio = PINS_COUNT;