From patchwork Wed Nov 5 15:20:23 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marco Crivellari X-Patchwork-Id: 653 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1F043191CF for ; Wed, 5 Nov 2025 15:20:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762356036; cv=none; b=Lsv3HkUveOjwWam8JIgEMqmL1cEuglPG6CQ9TR4PIoH5UucGiKoaYDxRqjNfKC1fA6sI1jCVfeif5GoggWtrAYIOpBjgSHxiEoyKyZKWGjEnDsCVXge13bzF1BCU8f0cEBrpZWTKuUgCB9wJmGnuvSqdEHhDqtnPzwbdITYeeCg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762356036; c=relaxed/simple; bh=8dIdbSkcxpAle4ECYuajmQXxUWr4HYu0z+pt1GG9lcQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=mdGfQxnCW2+8R2eAehwqk1UiLxDaSZlh8xB7VkKN/KEeZn6DgYe5F1j/gtl2Epv4rBGpqUSzhGA61O2huYOANsVSFZzkvLjhChH/T0gNdhTRLSJ4IHohBClFe1mmK3WCOAzXVeZFqEsNVA5yTUiJ7Bxv+YVAOsjuxJoUdGrkggs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=BgmTyjc7; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="BgmTyjc7" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-3ee15b5435bso4940951f8f.0 for ; Wed, 05 Nov 2025 07:20:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1762356033; x=1762960833; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ranMJA7nhTTLeDvlm0qxHCF2jeri90ZrthFQur/cI2M=; b=BgmTyjc7L8sCWFcaxqxMZzU3B/pC+z/NjT2e/IET85WrOn5RlD6PzZcdOK1ptNl+Bq Eb/GbJFdjFcRQjpQHKWHl2oJrV45VxHgKafKyG6VwVy0T2tSe9mXXBANZ1GVf5v8/HFf XkLENGmeMNhMfPMPxzbCwAszuhQtaaDc7sWKcRbIqRJeKLEtj49j94lp2zQmyK+iW9Ns bLytYFUYddEPPk+Vg8zwovTHlwI7Hmvtbr6fuwlqjZba0EfTzNchigRlUUpfA+Qe45j3 4au9Y9tcoi+c/KwGr/xfk2bJrwgY6djI6gQLo9H0J1Cj+kSbk6FZ5WWvQshbtDsWOeMO 9bsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762356033; x=1762960833; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ranMJA7nhTTLeDvlm0qxHCF2jeri90ZrthFQur/cI2M=; b=wA63Y00yuX8rYfm8O60NlZ1vtynkoHRQzld4EfVS0eQMLOC4SAs+ekXoPll3xxG28P qIJW+jyvdcNfBLUmxwA02TDXKlHs/wWf4exmKDjGfn9FbCQqkfJW8wdmJRE2Gkaeex9N IYpyHBJqErex5jw+oc4yg5ddUkBw5dRtK1AMTk+dril9ZNgPwROm+FGoLnaW8sXZiaCt vlOH99KFJ2pco4v5Y2gYWn4AVMJpNvmIZi0oaATjCmRtTqbRnj6qmfbEoamDcvHOcEEI B3P2LuKzH2fJ8Mmdu7nI+/w5LDUMKvezVtZXwGPJoy/3bMYMY60J2WNfn6fGCkG/lI3Q CQPg== X-Forwarded-Encrypted: i=1; AJvYcCXYOVu4PvmmlhhgDd+7GAU0IZxwIwlYHCiMTyeUqmu9pTlEdGi5nCxMsw3UYqaIHNRguraL0v22Q80JwQ==@lists.linux.dev X-Gm-Message-State: AOJu0YxJ0VcFSb8Z8NbDKarO4P+AwHWf5IM+ZenH2CvgUJA+o674Dun/ Kv4YFKh5CXhupUgEW0fWCWPahXzKa6HOzYKNexTzOfalQfmbhudr7dFN0vzbUNw02uw= X-Gm-Gg: ASbGncshY6su7y2p41wA27KAhfF3G4IW+v0nC3Y3wXN5VrVBXI5v6AaAWCy6c0J2YjD 8CdUKCXaZjNLTRCa3ZKqksYPrx898SEz/W53SCmOtNyXtZL/q6xQvN7ms/I56VByMslnPz9R1gQ zrWmXd0+wkzQq8LHA/tkSVRPjAAglP2PQwpxPy7gXWTNHfztuHI2OzGDjhgFM6ogyu7CCF1emf5 i8Qb+r9K4ricOhJORqt7Kb7gXXeHfuHdHYxm44kGQomcu7O5YhF1C6TM1eLQYcTlIOOdDZseNhQ bML58QNvDyfnNdHSEeIMCNbIe4TW165A/+xtf3+UY2PRwTFMAiO54lD34gqLJojj0H6m80G/Ak8 WijFaoeqCgoq96lkqkRJw5vl0UebYPovLj49pSj6x3PCwRZroJt+BBgcXMR9zNZNm0/NVUfZUvz oknRNKeEloRjqtJj/qoygnS3s= X-Google-Smtp-Source: AGHT+IHUa1UagvSj8MVB8CHfM78Fkv+vbGeo68mTbHX615SxRGVOlXbaT5kn8JdN3BRCGmBUMVJgvw== X-Received: by 2002:a05:6000:22ca:b0:429:c774:dbfc with SMTP id ffacd0b85a97d-429e32c8168mr3259102f8f.12.1762356032871; Wed, 05 Nov 2025 07:20:32 -0800 (PST) Received: from localhost.localdomain ([2a00:6d43:105:c401:e307:1a37:2e76:ce91]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429dc200878sm11018117f8f.45.2025.11.05.07.20.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Nov 2025 07:20:32 -0800 (PST) From: Marco Crivellari To: linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Cc: Tejun Heo , Lai Jiangshan , Frederic Weisbecker , Sebastian Andrzej Siewior , Marco Crivellari , Michal Hocko , Vinod Koul , Kishon Vijay Abraham I , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Subject: [PATCH] phy: sun4i-usb: replace use of system_wq with system_percpu_wq Date: Wed, 5 Nov 2025 16:20:23 +0100 Message-ID: <20251105152023.259813-1-marco.crivellari@suse.com> X-Mailer: git-send-email 2.51.1 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Status: O Currently if a user enqueues a work item using schedule_delayed_work() the used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to schedule_work() that is using system_wq and queue_work(), that makes use again of WORK_CPU_UNBOUND. This lack of consistency cannot be addressed without refactoring the API. This patch continues the effort to refactor worqueue APIs, which has begun with the change introducing new workqueues and a new alloc_workqueue flag: commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq") commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag") Replace system_wq with system_percpu_wq, keeping the same behavior. The old wq (system_wq) will be kept for a few release cycles. Suggested-by: Tejun Heo Signed-off-by: Marco Crivellari --- drivers/phy/allwinner/phy-sun4i-usb.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/phy/allwinner/phy-sun4i-usb.c b/drivers/phy/allwinner/phy-sun4i-usb.c index 59d38d88efb0..e2fbf8ccf99e 100644 --- a/drivers/phy/allwinner/phy-sun4i-usb.c +++ b/drivers/phy/allwinner/phy-sun4i-usb.c @@ -359,7 +359,7 @@ static int sun4i_usb_phy_init(struct phy *_phy) /* Force ISCR and cable state updates */ data->id_det = -1; data->vbus_det = -1; - queue_delayed_work(system_wq, &data->detect, 0); + queue_delayed_work(system_percpu_wq, &data->detect, 0); } return 0; @@ -482,7 +482,7 @@ static int sun4i_usb_phy_power_on(struct phy *_phy) /* We must report Vbus high within OTG_TIME_A_WAIT_VRISE msec. */ if (phy->index == 0 && sun4i_usb_phy0_poll(data)) - mod_delayed_work(system_wq, &data->detect, DEBOUNCE_TIME); + mod_delayed_work(system_percpu_wq, &data->detect, DEBOUNCE_TIME); return 0; } @@ -503,7 +503,7 @@ static int sun4i_usb_phy_power_off(struct phy *_phy) * Vbus gpio to not trigger an edge irq on Vbus off, so force a rescan. */ if (phy->index == 0 && !sun4i_usb_phy0_poll(data)) - mod_delayed_work(system_wq, &data->detect, POLL_TIME); + mod_delayed_work(system_percpu_wq, &data->detect, POLL_TIME); return 0; } @@ -542,7 +542,7 @@ static int sun4i_usb_phy_set_mode(struct phy *_phy, data->id_det = -1; /* Force reprocessing of id */ data->force_session_end = true; - queue_delayed_work(system_wq, &data->detect, 0); + queue_delayed_work(system_percpu_wq, &data->detect, 0); return 0; } @@ -654,7 +654,7 @@ static void sun4i_usb_phy0_id_vbus_det_scan(struct work_struct *work) extcon_set_state_sync(data->extcon, EXTCON_USB, vbus_det); if (sun4i_usb_phy0_poll(data)) - queue_delayed_work(system_wq, &data->detect, POLL_TIME); + queue_delayed_work(system_percpu_wq, &data->detect, POLL_TIME); } static irqreturn_t sun4i_usb_phy0_id_vbus_det_irq(int irq, void *dev_id) @@ -662,7 +662,7 @@ static irqreturn_t sun4i_usb_phy0_id_vbus_det_irq(int irq, void *dev_id) struct sun4i_usb_phy_data *data = dev_id; /* vbus or id changed, let the pins settle and then scan them */ - mod_delayed_work(system_wq, &data->detect, DEBOUNCE_TIME); + mod_delayed_work(system_percpu_wq, &data->detect, DEBOUNCE_TIME); return IRQ_HANDLED; } @@ -676,7 +676,7 @@ static int sun4i_usb_phy0_vbus_notify(struct notifier_block *nb, /* Properties on the vbus_power_supply changed, scan vbus_det */ if (val == PSY_EVENT_PROP_CHANGED && psy == data->vbus_power_supply) - mod_delayed_work(system_wq, &data->detect, DEBOUNCE_TIME); + mod_delayed_work(system_percpu_wq, &data->detect, DEBOUNCE_TIME); return NOTIFY_OK; }