From patchwork Fri Dec 19 11:42:21 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 561 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D70C3320CCD for ; Fri, 19 Dec 2025 11:43:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766144586; cv=none; b=SVT1annOM/vvlWDH9upx63GHlIMZ+aduDUGdQFaM+qGaYBkQKwvhhZfyvMkk4aZuJXfdjal7C7Odg2hlgy7O1213dkqCfiT6xF902CXACyu3xhYGTezx2Z2uCgG++jMFDCExrwVj4hjRboR2yazI1bddoKtNYifkSPCT1KXpk64= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766144586; c=relaxed/simple; bh=0xsYNaey6JAOZlOGT4ZeTLf/86/izfxYeYtsk5mB/FY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=i0FNtBIICgvADfCT1Tjjs6P8dxdt+Ka++xxBLBqmaN/0b8gK/dwGYmsY76QoWnw9+xRGE9VoWeA9xNN67QTIxmXBnAFnmGfPOZFLaOJ02Px1JvzK05Vl8oCS6dy73nfDLl4tP2/vDsJYiBIqL6In1StYiq0UkjtNRnhRAUZwhHA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=B3F+9YN+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=R616n0WJ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="B3F+9YN+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="R616n0WJ" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BJ4d7Kb1772623 for ; Fri, 19 Dec 2025 11:43:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= toP+4hHDSoxB8780ojreFhm/a4J1ZHDTB+HRCD79Zhc=; b=B3F+9YN+jWefr77j h+kL+X0o5z72id6q20kST95IstYJSgUswHV+udx4ZeilOqbX5rZpNWghQJK0DNei Nl/qpIX9KMz2CG5ue4C8W/Vk/bks1+lK56bNIp3kgcwXu8K88gXDorG80Eu38B/8 OHlhdAV5Fqauq1nm1Y4y81nxFim9rsnXpIKJifkwe3Nj/RWYV6OXuDmGNPCDwx/Y 5WLejG9/EF8di+1ix+rl2VsdwXH1EBeGMqzuOdrmmYpQ4cp+DUkkfpNgDMKg01XG leRxEKGtZpaKvvrX3ZfqELd5bX84kSsIsEv/991WlY0HXMWnapOMPSSTX/P0Kyf7 sUU8GQ== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b4r2bjh1g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 19 Dec 2025 11:43:02 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4f35dcb9d4fso54058121cf.3 for ; Fri, 19 Dec 2025 03:43:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766144581; x=1766749381; darn=lists.linux.dev; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=toP+4hHDSoxB8780ojreFhm/a4J1ZHDTB+HRCD79Zhc=; b=R616n0WJvNlBwiG0rtS7HCY+2NJn4CM3OAksUrnFVZZHhgNBZlu+d8PZYtF+lUcvpv lw30ymeOV2qpdunTmaAPs5gqjigNLp/PQDHuXe4TEQLo6NhcZKhaFYe1vtou2bt4icuF Mpj0JLD0cFfdvmITEAdvkzwWE6Jbx5lmZyAJVdad256z+S6UbdO5pEZ9QmkTNSyi3nQW ilIYORAkIkXAfOV78xv7kIcs2WUX/8BIypxQwQ817f6Q/ky4Eo9GgmPdZpDe8oMhZx7F 4GeWzK7vfoqxmu/IsUvsZLJMNtZM0MZGvlYVUfgfKaZk2E5pR7FnV122hVJcZjgguovw /KNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766144581; x=1766749381; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=toP+4hHDSoxB8780ojreFhm/a4J1ZHDTB+HRCD79Zhc=; b=i+S0yTSpK82T7nYazxSYSKDvmm0nPbWOl6DxaAFtvEG9iV+D44FoOy1W5AJL3Lk/9X DrHCSBmPNEiYaiJskfukpV6KAEEojykEjyTZxwvqSsP1Cwh1REOxePHxvxOYP6SgEUPv ljeYbBhnT2Q2KcUk1BBT8+X3LWgUA6zCRAQyVuxchctSjaBlPWpIiyVJfKp+bKz8RW7f zMYrpQb3O19wMpF9fjNLIzGMTGE2r1NCSDkS6Ee6uyl8OHzSQpuJFoFTqLm3haHiC9Fx QTFndTka3qbfD3UrDS13Ln44w+ky7NlqXJwwnr8rOFx7LCRDgu2OWFJOnMQwWykvIJ3r HEIg== X-Forwarded-Encrypted: i=1; AJvYcCUws90l/kOC63SitvjKbnkaJbeZQVTj4CXtmwIJ30aivyuB1mXbPKPb+6R2rWwJa7gcx3U=@lists.linux.dev X-Gm-Message-State: AOJu0YzoJylwzgojbdJGtyRMQ0Xubiz0lIg788tt9FhVXhF8pP6Ne+qF /htZe8UADx6zaNHAp0SgW11xGeBvHe9JT8g1rS8amWsQYgFvyF0xkjKECGhAYg8xhFGGYct3Z0l iZYIrrfjV6tshPidOONwKeUhtRXWko5cNXGqsBFWRFIVQCLm+wa1589Y= X-Gm-Gg: AY/fxX61C5qVdN+xYEc+Npz6HZvFxP8rvEkrnb/qTp2TPTzLDUlkUvrzK4XXjQkcNVQ K8aZLJMv6Sh+FkStU7o9gLmOwTLKlvfmQpiGAlLgxvyK/F7m5Ot2CvsKV/zSkZJaV2Pwc/uVJCU DuA7aSiNnk1XWzl21yB6uLc77V1jau9Q+YxG7N+xChsS6FlT5UcrNRZr9dGR37RWS1e9jfwcwD/ +hubqi8DYHvs/PztFxPd7t9Se8B36JwBHuIwYAn27DwaI8IYq/6SxOXhGz3IA6YtG6XLGM16E6l AodI3FaACR9kRzqnnKhyhIk1FpcT0PrpOnK8KmTNgZ/Ngnk3MC+rhIBLCEzi9qxxm0nuxvmsogD LdLVz7d3FOsclqGFVxVzznKKpDmUnyON8m+leCC0= X-Received: by 2002:a05:622a:2cb:b0:4ec:f31a:1496 with SMTP id d75a77b69052e-4f4abd8e7f8mr33969071cf.56.1766144581144; Fri, 19 Dec 2025 03:43:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IF5jbLqM0SggQoZoqxYXl/yWMOKAuP4NS3/zbdcovR8zaHbvZkAv+xrhVScVhbR/IDMWeLfLA== X-Received: by 2002:a05:622a:2cb:b0:4ec:f31a:1496 with SMTP id d75a77b69052e-4f4abd8e7f8mr33968661cf.56.1766144580591; Fri, 19 Dec 2025 03:43:00 -0800 (PST) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:d857:5c4e:6d25:707c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d193d4f09sm41134425e9.12.2025.12.19.03.42.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Dec 2025 03:43:00 -0800 (PST) From: Bartosz Golaszewski Date: Fri, 19 Dec 2025 12:42:21 +0100 Subject: [PATCH v6 6/7] net: stmmac: qcom-ethqos: define a callback for setting the serdes speed Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20251219-qcom-sa8255p-emac-v6-6-487f1082461e@oss.qualcomm.com> References: <20251219-qcom-sa8255p-emac-v6-0-487f1082461e@oss.qualcomm.com> In-Reply-To: <20251219-qcom-sa8255p-emac-v6-0-487f1082461e@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Vinod Koul , Giuseppe Cavallaro , Jose Abreu , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Matthew Gerlach , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Keguang Zhang , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jan Petrous , s32@nxp.com, Romain Gantois , Lad Prabhakar , Heiko Stuebner , Chen Wang , Inochi Amaoto , Emil Renner Berthing , Minda Chen , Drew Fustini , Guo Ren , Fu Wei , Nobuhiro Iwamatsu , Geert Uytterhoeven , Magnus Damm , Maxime Ripard , Shuang Liang , Zhi Li , Shangjuan Wei , "G. Jaya Kumaran" , Clark Wang , Linux Team , Frank Li , David Wu , Samin Guo , Christophe Roullier , Swathi K S Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Drew Fustini , linux-sunxi@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, sophgo@lists.linux.dev, linux-riscv@lists.infradead.org, Bartosz Golaszewski , Bartosz Golaszewski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1933; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=/9AVH+OLPVBYkTZnu8Dy/MAFFgxoNMd7J+eOs2UC7Uk=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBpRTovz4KhkkaA0q1/bxvZ0VVJsd0md/pcMO4QP 6kalt0ntniJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCaUU6LwAKCRAFnS7L/zaE w3Y7EACiTaf/AxXHvCBwgf5ZWLPoK5VqY6uMwyZrsrZsZ0H/zZOzbpz39hwncnMmgUTNBortv61 rMYaV+GDCW0TLkw9TQxq4PUztMvCVNSWom3cT0srO/GBBaVIPCSS4IhTXusjmAh/XWoGs3h726Z 2zqrpzLp+onwSvqpm175NpEcjzNBAbCIsb6YzwYRBF8AbY4y4uxhUIjTL4TpAURdV23fpTsCYzY TZ6jYK4S8BsJZc+1LhTqVWxyzkjz36VFUMzRhx9Qpu7DQaniKas6+NmVKgLY+ayc58FKnlyuOJr uGLNis71NNRkltPgJdx3HZm+yq9V3w4DdgAZurF9+498tKvBKGDmgoo26mqtdZStrHJJ0WnXJz+ wmrcYMRFFBrIh9UNWqH2atCmsJpTmHzskAWR1hBdO/0jgw6fiIMsYX8kvbXSBzkKVIXOk8WoFtg UldB9/qaWJ7Nwkn3zPy8DTaFuMCNwb+WQA8IgGRVxO6Mh6YLnR4tP2H0hktD1UpcGYOYDyYFUJX 40LfNVv5YUh7zMhcXlX/1k7r3PuC4KYTfLDDviob4nKo3xWfl87Rlv8U39PGwEr7qxFXv74g4jH x6XsiMfIoF/Vux1BLfET/tuwxNXCrTHEOnlJGQSb5vqEcNm8iMHrpwMi4kGouyL8U738LKYcOHY 2L9+//6O4WaTsFg== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Proofpoint-GUID: c4EAzBrahUemN63MH-2J1OJatD-GR2uI X-Proofpoint-ORIG-GUID: c4EAzBrahUemN63MH-2J1OJatD-GR2uI X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE5MDA5NiBTYWx0ZWRfX8DYpFA5fmWQV YT8/OLIiKEkE4dGCPIG8YZ/5o1sf2uE8rHC/Jq1XAiLO13sWvO6ojUzGo6v0rPr9qMOtuJu1MCQ SPHnaZnx97zplWp+TFyXObJl2YCNBNjJt8TVdDmvlDByqoyFcaTNcHIOsIOTlSN0I+Gv287n6hh Bd9d6+ZtBCxiUTI/Y0Ma+5Ga6ubdY7WUww9xN2on9DURq6yrIiX8zEWqrItsLR/npElNSbGd+qz ewG9LLKB2oBrwiYkrHAd9n4ThfpPGMUskncyeJK5IGK+9o/K1FJM4oyWACOgFVsJJvJ+1nbC9cZ ECDwAEdFBdhQsjRCKsXGsCAsLvhGcljE9vQZk3vwMoHad6nqKqqHzaa+mWBDLqKSnUqRuiuCqqz /8ODR43i6pnLdAzVbSfaC9eWGR85wnMLhJx9a6VdouaZ76n801H5fzjZpddM0429RTmKn1sOoPj NOS9A42DI1wuPq4RJNw== X-Authority-Analysis: v=2.4 cv=WYwBqkhX c=1 sm=1 tr=0 ts=69453a46 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=0aI5G4bYpHrJQa0XwroA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-19_03,2025-12-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 priorityscore=1501 clxscore=1015 phishscore=0 adultscore=0 suspectscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512190096 Status: O From: Bartosz Golaszewski Ahead of adding support for firmware driven power management, let's allow different ways of setting the PHY speed. To that end create a callback with a single implementation for now, that will be extended later. Signed-off-by: Bartosz Golaszewski Signed-off-by: Bartosz Golaszewski --- drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c index 856fa2c7c896..8ba57bba3f2e 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c @@ -120,6 +120,7 @@ struct qcom_ethqos { struct ethqos_emac_pm_ctx pm; phy_interface_t phy_mode; int serdes_speed; + int (*set_serdes_speed)(struct qcom_ethqos *ethqos); const struct ethqos_emac_por *por; unsigned int num_por; @@ -617,11 +618,16 @@ static int ethqos_configure_rgmii(struct qcom_ethqos *ethqos, int speed) return 0; } +static int ethqos_set_serdes_speed_phy(struct qcom_ethqos *ethqos) +{ + return phy_set_speed(ethqos->pm.serdes_phy, ethqos->serdes_speed); +} + static void ethqos_set_serdes_speed(struct qcom_ethqos *ethqos, int speed) { if (ethqos->serdes_speed != speed) { - phy_set_speed(ethqos->pm.serdes_phy, speed); ethqos->serdes_speed = speed; + ethqos->set_serdes_speed(ethqos); } } @@ -838,6 +844,7 @@ static int qcom_ethqos_probe(struct platform_device *pdev) return dev_err_probe(dev, PTR_ERR(ethqos->pm.serdes_phy), "Failed to get serdes phy\n"); + ethqos->set_serdes_speed = ethqos_set_serdes_speed_phy; ethqos->serdes_speed = SPEED_1000; ethqos_update_link_clk(ethqos, SPEED_1000); ethqos_set_func_clk_en(ethqos);