From patchwork Tue Dec 23 10:02:33 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 541 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A86F933B6E5 for ; Tue, 23 Dec 2025 10:03:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766484187; cv=none; b=FLtqVQUggraJE+yyzZ4bjZnBFZROPH/uRRaj3M1MeykZiLGJ8JYwlMP9wZfEDEKUcVn07uamobFTkyJceRaXd6T/sp0K8j8be8ons59ANErnjf835uZM5q8/DfxxRoQVyNBl+ahkwLjalWeJafT1uWThgfbW2j46G1KNrkvXwy0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766484187; c=relaxed/simple; bh=dI851BmOduiioly8u4iYfe+Rr//GzNIkYCteXmln3Ng=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bwHZIKRBLhY7r/1C0cBSmS0tmdPRYE/Y5sdeFdqJ9RABJemdnVGW2ChZaXNQKO4wlWMYaH5SPZovzv2zqH8gRiRR5xZZLYtwXEWlBJ65t9M3fczjup7IrAQQ7XzRnGACTmCVqq6m1vBjA9XmURQ6OLnHS7sBpg8epUHaxLG02Jo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=F2GLm8R2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OJq9bLbm; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="F2GLm8R2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OJq9bLbm" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BN93HM52792582 for ; Tue, 23 Dec 2025 10:03:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= or9DvhQwaxtsrAqBQKF2R4HMkZA0UWyOfpa2BBt7/z4=; b=F2GLm8R2dREg5sck zgwCv6IffFw5EQxdkz6nZX9+TnNyy8LZcekauJxst7CNm8WdkKpH/ZVHkj+qS/px GDbP6yrTQNayaiBAkb/FwCXjoYPP4IeJ8jjaPBc2jMUIXkL/lj7vMWlD/Axn4D0l rCjL/MvYhL3NNd9iF8EdRvRVZwxSfaUUqhuOFLiDDWRKnPWgf2q9DzEnYJJmF03b zH9+8N8WFL6TFMqn7tqwZIo/0lxAR0ZA8mh77yxxGs1g2ItJ1k99KAFxIAjftPcN XKqKe/l9ArxoAmdi6nrgzWDkW/iV6O7Gldkg6pYtMi4shkzKgT5f0vUZaj8iT+bE ZOwRmg== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b758y3g85-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Dec 2025 10:03:03 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4f35f31000cso67818651cf.2 for ; Tue, 23 Dec 2025 02:03:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766484182; x=1767088982; darn=lists.linux.dev; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=or9DvhQwaxtsrAqBQKF2R4HMkZA0UWyOfpa2BBt7/z4=; b=OJq9bLbmyjy4sgby7BZpCBqoWuZoBK/ADUWjfQ5wFAwUtN0lE+VDXskoCAvxIFJ0hd UkU8OytgpgmwYiQH7Is4VZW1T3EoNXEb+XoiJRzAqtmWB1NUOH39h+HvCLaDfPegZTmp sq+VLcnws4lsdUX3cJxUSxyMlsDAPutl+sAvMvLhXZ/ambIaJVDX6p2A5o3sBUh8suKG K6jI3gyPORjdZcYHSM3UATKUIK6G2Fk9pY+T3gPdEOwAtMAiSRhfZ9oTjiXemwhYR0XX GGuyMCjukX61u6oKjjaxnorzUx70xY+aKsM//jZfAOQjwRxfEkfP39GNIDTheRhco6yG VzPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766484182; x=1767088982; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=or9DvhQwaxtsrAqBQKF2R4HMkZA0UWyOfpa2BBt7/z4=; b=lkToT6TFQEqYYHV4KPUazYFF99UmmQacrxyrJwMxUITVaal8FpCVNr+XOsEc/gLCop QTdJaC4YvLgtGGmvgy124vxQ9QmU1eHXxi99CN93xUr+mZCnM8RsmlGi5efM04HPCOT2 LPWa4rOJBaUGXM22omI9jl69NowyhqTFt79DllKJ+8EMvlVZBHR0930VI/r18nt3EIvT aSJh8AS/O9bgzk7VC9ZBaLhJjo5WLaG59ISwjJL7lkcfHCIEihK/KtIZ/h1+DlPUf8Mj hBfgG88RbqJdgZug6oudmH6Qx1MKx8JJ3CrpH/LKVcZAPvmEuIyvWXvADD2j3cyiqrOn upPg== X-Forwarded-Encrypted: i=1; AJvYcCXmrhzaXZMf7HCaNMHkCEas4mqCj5cSDxkZoZPNSMKGN+u2ggzc4y2xcJ8CzAvbQa2YH+UMchTg9n7BmA==@lists.linux.dev X-Gm-Message-State: AOJu0YxFd/ZGM3UBaVnTdGMn+LEy8flUfhX56QPaZs65RNpn+WW9h/hQ z59H1LiHU9uDcw7BCdafFohLA9GcMw0RqMoi43bI+yezUvzFGW77wdI8ZKKvM1HSv+0EGZ7FUvv Mphx8iPLhdBEHc8RvXJPscfur0UJrG6owngndh6qfyWTQStUvpj8zm4lbBdnKPlN3jg== X-Gm-Gg: AY/fxX76I+zdRaypNcViQeXq/QuybBPMGZCADhA0cj3rNcayK9me6+lhbaEMGTAu6co or6N/Lk7i3JKVDllgn5yLaUZ5oj6hE8CGCYewzsy3MxMkbvDteVgnyHDNJ0MqMoU7QqAVxmZJJ5 8lNmRh9MaM9QTI5j9f4KqgyocPmahQzteQu1WWfgcNZVKK5/rZNavLZLQjd8QzdbTHEqo4bO7Ed dGJRo6UD075iitlWHp6JJQLLf+4NcoGMGBcdFLs45Jv3cAgcwZr6pM2fu5e4dURnJIRAUkri2nM sTdifHEhqwlm2ni6Ogg8Aj9bUQ7QTxJY+z/fevLyFM/bRF2ngq7iTwDKE154xiEvphEwn/bDeOl zgvOCXJ6Tw1NYhzJW2GJYLjcuuoHQSHpb7LfJlg== X-Received: by 2002:a05:622a:2609:b0:4f1:e46b:9dcf with SMTP id d75a77b69052e-4f4abcdf56emr174601961cf.26.1766484182021; Tue, 23 Dec 2025 02:03:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IFYmKh9q3TVpBvPGG04xNQnPAJXRKn+MV5cm9azWZmmq9WoPxX1CHwGyf0VG3WWqkcEF5gNgg== X-Received: by 2002:a05:622a:2609:b0:4f1:e46b:9dcf with SMTP id d75a77b69052e-4f4abcdf56emr174601651cf.26.1766484181594; Tue, 23 Dec 2025 02:03:01 -0800 (PST) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:190a:1976:65e2:c61]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea1b36fsm26794625f8f.5.2025.12.23.02.03.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Dec 2025 02:03:01 -0800 (PST) From: Bartosz Golaszewski Date: Tue, 23 Dec 2025 11:02:33 +0100 Subject: [PATCH 11/12] i2c: amd756: use i2c_adapter-specific printk helpers Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20251223-i2c-printk-helpers-v1-11-46a08306afdb@oss.qualcomm.com> References: <20251223-i2c-printk-helpers-v1-0-46a08306afdb@oss.qualcomm.com> In-Reply-To: <20251223-i2c-printk-helpers-v1-0-46a08306afdb@oss.qualcomm.com> To: Wolfram Sang , Andi Shyti , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Khalil Blaiech , Asmaa Mnebhi , Jean Delvare , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , =?utf-8?q?Andreas_F?= =?utf-8?q?=C3=A4rber?= , Manivannan Sadhasivam Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-actions@lists.infradead.org, Bartosz Golaszewski , Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3679; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=dI851BmOduiioly8u4iYfe+Rr//GzNIkYCteXmln3Ng=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBpSmjB5UVNcmc611VKtySZweLgh03lH4CqLyep8 HN5EDTCCTaJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCaUpowQAKCRAFnS7L/zaE w7K7D/4+c+Fz0nx+enSy+0T4yYkJZdn0nkZfXEFvgWl9SaytNp+VrFeIZFFCXXMRHJLHzQ9F6yE 6grb+AXEzou95fx6/DnPZnO4gmcgKK1vIR5ea8WocpwnbE0BV8n5SCeDwJtTMqb/i7ESl/L6Uw9 7YdYJWNS2IXMX7FN7fE/Nc+ibmyHtIv5QHZQbD4L4NEDUBDXt3L/u1EKGsqMyUp5C/3qAtSkXH1 ix1sU8F1hiF4ppon9nlTAxe6MOmla3QRgWCA0i6WoPuIYU+LtfFBSz9PlLMFSQi3/Tb9pTJojmv sZyt0uBuvEPgfDyh9D4q5y8scZeFgW6/roKmrAmktmOPfu69d600IhvNzHX1/53yk2+ruS4HAWe jr2xoMOReoaIb6zkzEE0K90I4fJNM8eFCx08mnXqg1typ4jMHuTRK26+T2kLlreUWiNAHYXbg8W NintnTN9h/k5RLXA8M0Imm1bBI1yXyxIp7EejP6p+7y4WMjVDx+KmJsnYtWI5qwSIgG0EGvrG8n HzEAMhq4EHGZ21GoCeWNKI0uXpcwJSls/9lQfmgT29CNmnigZgBM8/PW8iEsLmgHAFwlt1BpTZn VIO7KE9o3UipYVObALa592Fk9Ye+4KVwPvy4fepnLyrsTInjb15j8hoaKeYzfo7Zei9+IYYPHAR cv/14KJKs7ruXCA== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Authority-Analysis: v=2.4 cv=TOdIilla c=1 sm=1 tr=0 ts=694a68d7 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=IUzV_G_aAFXi5cZUTYgA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-ORIG-GUID: d8KV7Q0FYi6BQTUPfb4q8vngdt_7czht X-Proofpoint-GUID: d8KV7Q0FYi6BQTUPfb4q8vngdt_7czht X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjIzMDA4MCBTYWx0ZWRfX49iEdOI8Mw9w a9RzYiYJJmjLwUS+PEwnsXKclIvOI3uhUyY46U91ZKt+zqObqxpoARYeo6rsml2bg4DEhGrjeTS xje3gxufxlj+IEtTJEYU89mwivgsZ2/6snuu38fDmu0B+skw81DvZghcyW+MNL3dMvcaJwsZTPI zFGcBfrmLfkHf6phPlss7sdtW3B5WbDPh596Yys+Pn6Aylc30jptTHr4eDeYjznN3xMUwUweJ8Y NzJ38QbqVbMKYiwDSVDxjC5LySyshoo2zBkIALXvVqWeVw5PO23k/LPATYFZuy0AAe3ItOaTMjc ArEkZoBXScf97KRUlg1NbjJKL4JWhLDprA1g6NAmC4Xz7G4O77vTa+4LG6u5KK+Om/7YvKACbLd /ZwFeZFmPzrWIiWKNLrfOkzBqFC9mhvakJvH7X8N688hH50hSq3K/ZmG+5uPvoEM8/Qva+UaQ2+ OfRIxq11eZcGolYNiog== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-23_02,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 clxscore=1015 impostorscore=0 bulkscore=0 suspectscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512230080 Status: O Convert all instances of using device printk helpers with struct device embedded in struct i2c_adapter to the new i2c-specific macros that hide that dereference. Signed-off-by: Bartosz Golaszewski --- drivers/i2c/busses/i2c-amd756.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/i2c/busses/i2c-amd756.c b/drivers/i2c/busses/i2c-amd756.c index 3621c02f1cbabd8c5e9d8a4ae1494ada78726b15..629da0b8024b88cc4d51ea5e785147b462a1281c 100644 --- a/drivers/i2c/busses/i2c-amd756.c +++ b/drivers/i2c/busses/i2c-amd756.c @@ -99,14 +99,14 @@ static int amd756_transaction(struct i2c_adapter *adap) int result = 0; int timeout = 0; - dev_dbg(&adap->dev, "Transaction (pre): GS=%04x, GE=%04x, ADD=%04x, " + i2c_dbg(adap, "Transaction (pre): GS=%04x, GE=%04x, ADD=%04x, " "DAT=%04x\n", inw_p(SMB_GLOBAL_STATUS), inw_p(SMB_GLOBAL_ENABLE), inw_p(SMB_HOST_ADDRESS), inb_p(SMB_HOST_DATA)); /* Make sure the SMBus host is ready to start transmitting */ if ((temp = inw_p(SMB_GLOBAL_STATUS)) & (GS_HST_STS | GS_SMB_STS)) { - dev_dbg(&adap->dev, "SMBus busy (%04x). Waiting...\n", temp); + i2c_dbg(adap, "SMBus busy (%04x). Waiting...\n", temp); do { msleep(1); temp = inw_p(SMB_GLOBAL_STATUS); @@ -114,7 +114,7 @@ static int amd756_transaction(struct i2c_adapter *adap) (timeout++ < MAX_TIMEOUT)); /* If the SMBus is still busy, we give up */ if (timeout > MAX_TIMEOUT) { - dev_dbg(&adap->dev, "Busy wait timeout (%04x)\n", temp); + i2c_dbg(adap, "Busy wait timeout (%04x)\n", temp); goto abort; } timeout = 0; @@ -131,38 +131,38 @@ static int amd756_transaction(struct i2c_adapter *adap) /* If the SMBus is still busy, we give up */ if (timeout > MAX_TIMEOUT) { - dev_dbg(&adap->dev, "Completion timeout!\n"); + i2c_dbg(adap, "Completion timeout!\n"); goto abort; } if (temp & GS_PRERR_STS) { result = -ENXIO; - dev_dbg(&adap->dev, "SMBus Protocol error (no response)!\n"); + i2c_dbg(adap, "SMBus Protocol error (no response)!\n"); } if (temp & GS_COL_STS) { result = -EIO; - dev_warn(&adap->dev, "SMBus collision!\n"); + i2c_warn(adap, "SMBus collision!\n"); } if (temp & GS_TO_STS) { result = -ETIMEDOUT; - dev_dbg(&adap->dev, "SMBus protocol timeout!\n"); + i2c_dbg(adap, "SMBus protocol timeout!\n"); } if (temp & GS_HCYC_STS) - dev_dbg(&adap->dev, "SMBus protocol success!\n"); + i2c_dbg(adap, "SMBus protocol success!\n"); outw_p(GS_CLEAR_STS, SMB_GLOBAL_STATUS); #ifdef DEBUG if (((temp = inw_p(SMB_GLOBAL_STATUS)) & GS_CLEAR_STS) != 0x00) { - dev_dbg(&adap->dev, + i2c_dbg(adap, "Failed reset at end of transaction (%04x)\n", temp); } #endif - dev_dbg(&adap->dev, + i2c_dbg(adap, "Transaction (post): GS=%04x, GE=%04x, ADD=%04x, DAT=%04x\n", inw_p(SMB_GLOBAL_STATUS), inw_p(SMB_GLOBAL_ENABLE), inw_p(SMB_HOST_ADDRESS), inb_p(SMB_HOST_DATA)); @@ -170,7 +170,7 @@ static int amd756_transaction(struct i2c_adapter *adap) return result; abort: - dev_warn(&adap->dev, "Sending abort\n"); + i2c_warn(adap, "Sending abort\n"); outw_p(inw(SMB_GLOBAL_ENABLE) | GE_ABORT, SMB_GLOBAL_ENABLE); msleep(100); outw_p(GS_CLEAR_STS, SMB_GLOBAL_STATUS); @@ -233,7 +233,7 @@ static s32 amd756_access(struct i2c_adapter * adap, u16 addr, size = AMD756_BLOCK_DATA; break; default: - dev_warn(&adap->dev, "Unsupported transaction %d\n", size); + i2c_warn(adap, "Unsupported transaction %d\n", size); return -EOPNOTSUPP; }