From patchwork Mon Apr 6 22:14:40 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Skvortsov X-Patchwork-Id: 1994 Return-Path: X-Original-To: noreply@patchwork.local Delivered-To: noreply@patchwork.local Received: from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114]) by mxe881.netcup.net (Postfix) with ESMTPS id 19F2D1C002F for ; Tue, 7 Apr 2026 00:14:54 +0200 (CEST) Authentication-Results: mxe881; dkim=pass header.d=gmail.com; spf=pass (sender IP is 172.105.105.114) smtp.mailfrom=linux-sunxi+bounces-22792-noreply=patchwork.local@lists.linux.dev smtp.helo=tor.lore.kernel.org Received-SPF: pass (mxe881: domain of lists.linux.dev designates 172.105.105.114 as permitted sender) client-ip=172.105.105.114; envelope-from=linux-sunxi+bounces-22792-noreply=patchwork.local@lists.linux.dev; helo=tor.lore.kernel.org; Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by tor.lore.kernel.org (Postfix) with ESMTP id 80C9F3034300 for ; Mon, 6 Apr 2026 22:14:52 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BD96E39D6DA; Mon, 6 Apr 2026 22:14:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UtLzsGVx" X-Original-To: linux-sunxi@lists.linux.dev Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48DF533260D for ; Mon, 6 Apr 2026 22:14:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775513691; cv=none; b=hvM0NXET2aqn5atLQEbd1O6wHyQdVZdMX139COrXJyaNLGNg+CYA7eB2UeXpa9Txh0T8Y9ZwXQlZ+3d/g9jPPlU+ue4uIYb5vJTkqh4TG1+VjPXSzOjaBoggLhi7pG8sp7GCWs3St1igJ3xjYl3kf2wKEnVhfOpiP6Biey0r8ok= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775513691; c=relaxed/simple; bh=lmqzuOQqgNOAyPi5swfvuKRWX8HE/D1ZIzOxJVc5ihw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ptpKkIzpq9EaOusIvHnP5mg+YK70SnGA3AAfRy5pGnHj67Z6PaevllVieUfNM3ugn75gZ3KMl3emlLYdacXb2p1fqGu+t2FQq7z+R/SA/mw2j4ZG/b1oD8MVPI65lVtrXnWLTp6pZDa2IX56t/IQSCwMEIsaj31rwv7sVMS/YVQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UtLzsGVx; arc=none smtp.client-ip=209.85.208.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-38e09b14102so8371111fa.0 for ; Mon, 06 Apr 2026 15:14:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775513688; x=1776118488; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=tpN+/b8lu9/yvEaNtHU/WVfOxILX+ZQUzWAcfY4lXzo=; b=UtLzsGVx6zhEMEwwVUEKnyZNPXzNGfvWx0bPPbR3+VIj/kHLEGUqA7kVGwVegoddUg m7+CUI3+Pc9vAS8i4o+WOcv6SQv94a7n8nLT8nXgp7QkWW6xe0pVOcW+A/c/K0k7c+Mh 81pX3GUnP+U5Opg5eSyR6x1NgC7n5zho1uY5zDyF8D4O2zh4B1pmr145o0SmmK3VNjFA z4mwKRtn1HoAAVd9rwZ9Fha6mYGPprS/1U8x0uzdsbuKZT+F4KO15aYLiDFliYSO1V04 wJ4/TiIFzaTeoUD+vQHplHumgcf0jJvWqVjtyFgu7MnYOhroSthlbahIMmFiN9Mpjm4N 9gqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775513688; x=1776118488; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tpN+/b8lu9/yvEaNtHU/WVfOxILX+ZQUzWAcfY4lXzo=; b=bf+YMgci2Di1kfmbJErAHf5tPZzMZuzLqaItNZD3PfHbhcxAyQAmh4sYRTXTHBm4fU u2DlUtWBGhhqvcttmyGD0dulHfCIVUPO6iGSfuODlJPR+5EXIoDFEw+PFYz3R8BI5gFb HjPrK23eYBKAy5SFGTHwscmPQCRCwWTOy3Ec8RzPnaFJdntyHanTOQVlZ3fB9pwliPG5 Py7O45ySjv93IDJJvqpoyxtCeW//einLqN4y4s57m69bncs5Ro+mTGkZ4jOXOu0hSCy0 zHFJd6cWxOv2s8KGOrFlaHdRlnHDqRcG5fqQZXwLfxm5GvmYBkG4o2yKnfQ4V7+TObcU po5A== X-Forwarded-Encrypted: i=1; AJvYcCUARR4m+R81oylhrdyVrQ58Aic/UHkAaqTiq++jrZKHNGhgTZkeuZHiKuBKrbEE3x3+IZbbTzGKR9MHPw==@lists.linux.dev X-Gm-Message-State: AOJu0YxbglVkmFq1jO1t7yJxtyd/wpP/HtWzTdM67JNw4ZJUhgfZIqdw 8OV0GVwYGroxY0Vpxy5R1/aHnYTeTQ+eg9jvVsT4Oztrl/Ijhh+aGr7x X-Gm-Gg: AeBDiesFnP/uZQPhIdjd4DFjtGeJFwCUNzp851Espmn0QNxiUx64q4HafjeQftY4xf4 wHugOCQtMh59g1Bz925bWJy8Ac/kw9Gp2goq/ogMYpFHZHXUxEvRu12EkTRBT3dhYPbHuXOVlUm J18WxGnIJjorKInrvp8fsmqU8qOQwOIDZH1Zc/JcKkcyqTr8eINSHoVjq3jeJW0bZ/lJewfjMAV Arar499eGAslcWbJUmYGXKdcluHhuyONTmpTMcnTOWdjI8kqR+Mnkh/gKrfUgdQ5DjJx4IkqONn 7q1wMDhiwYTy78Oinqdug9QzDtPNHMj2UPgOuygXjWbgIGozW0BHniCO+mLf2uo+4AGCZ2FufqK d5DLDsk/D9/VuOb9yZfZ0yt5LZ9potpxBB4Vdjm8nwv6LV93ggKJjSq+suyzYEwCel6rlXrp4/8 BTWokcZHAYbQz1b1MDN9Puk+hOIQ== X-Received: by 2002:a05:651c:1b13:b0:38b:f0f0:e38f with SMTP id 38308e7fff4ca-38d91d78c88mr39211001fa.2.1775513688308; Mon, 06 Apr 2026 15:14:48 -0700 (PDT) Received: from new-nest ([94.19.228.143]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38cd2108c9dsm31924801fa.21.2026.04.06.15.14.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 15:14:47 -0700 (PDT) From: Andrey Skvortsov To: Dan Carpenter , Maxime Ripard , Paul Kocialkowski , Mauro Carvalho Chehab , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Hans Verkuil , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Andrey Skvortsov Subject: [PATCH v2] media: cedrus: Fix failure to clean up hardware on probe failure Date: Tue, 7 Apr 2026 01:14:40 +0300 Message-ID: <20260406221440.3721863-1-andrej.skvortzov@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Rspamd-Server: rspamd-worker-8404 X-Spamd-Result: default: False [-3.96 / 15.00]; BAYES_HAM(-5.50)[100.00%]; SUSPICIOUS_RECIPS(1.50)[]; ARC_ALLOW(-1.00)[subspace.kernel.org:s=arc-20240116:i=1]; DMARC_POLICY_SOFTFAIL(1.00)[gmail.com : SPF not aligned (relaxed), No valid DKIM,none]; R_MISSING_CHARSET(0.50)[]; R_SPF_ALLOW(-0.20)[+ip4:172.105.105.114:c]; MAILLIST(-0.15)[generic]; MIME_GOOD(-0.10)[text/plain]; HAS_LIST_UNSUB(-0.01)[]; TAGGED_RCPT(0.00)[]; RCPT_COUNT_TWELVE(0.00)[15]; DBL_BLOCKED_OPENRESOLVER(0.00)[sholland.org:email,tor.lore.kernel.org:rdns,tor.lore.kernel.org:helo]; FORGED_SENDER_MAILLIST(0.00)[]; PRECEDENCE_BULK(0.00)[]; FREEMAIL_CC(0.00)[gmail.com]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_HAS_DN(0.00)[]; RCVD_COUNT_FIVE(0.00)[6]; FROM_NEQ_ENVFROM(0.00)[andrejskvortzov@gmail.com,linux-sunxi@lists.linux.dev]; FREEMAIL_TO(0.00)[gmail.com,kernel.org,sys-base.io,linuxfoundation.org,sholland.org,vger.kernel.org,lists.linux.dev,lists.infradead.org]; FREEMAIL_FROM(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; TAGGED_FROM(0.00)[bounces-22792-noreply=patchwork.local]; ASN(0.00)[asn:63949, ipnet:172.105.96.0/20, country:SG]; RCVD_VIA_SMTP_AUTH(0.00)[] X-Rspamd-Queue-Id: 19F2D1C002F X-MORS-Enabled: yes X-MORS-DOMAIN: patchwork.local X-MORS-HOSTING: hosting172546 X-MORS-USER: hosting172546 X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= From: Samuel Holland If V4L2 device fails to register, then SRAM still be claimed and as a result driver will not be able to probe again. cedrus 1c0e000.video-codec: Failed to claim SRAM cedrus 1c0e000.video-codec: Failed to probe hardware cedrus 1c0e000.video-codec: probe with driver cedrus failed with error -16 cedrus_hw_remove undoes everything that was previously done by cedrus_hw_probe, such as disabling runtime power management and releasing the claimed SRAM and reserved memory region. Signed-off-by: Samuel Holland Signed-off-by: Andrey Skvortsov Fixes: 50e761516f2b ("media: platform: Add Cedrus VPU decoder driver") Acked-by: Paul Kocialkowski --- Changes in v2: - remove duplicate 'in-body' From: record - add more technical details to commit message drivers/staging/media/sunxi/cedrus/cedrus.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/sunxi/cedrus/cedrus.c b/drivers/staging/media/sunxi/cedrus/cedrus.c index 1d2130f35fffc..ee0e286add67d 100644 --- a/drivers/staging/media/sunxi/cedrus/cedrus.c +++ b/drivers/staging/media/sunxi/cedrus/cedrus.c @@ -477,7 +477,7 @@ static int cedrus_probe(struct platform_device *pdev) ret = v4l2_device_register(&pdev->dev, &dev->v4l2_dev); if (ret) { dev_err(&pdev->dev, "Failed to register V4L2 device\n"); - return ret; + goto err_hw; } vfd = &dev->vfd; @@ -538,6 +538,8 @@ static int cedrus_probe(struct platform_device *pdev) v4l2_m2m_release(dev->m2m_dev); err_v4l2: v4l2_device_unregister(&dev->v4l2_dev); +err_hw: + cedrus_hw_remove(dev); return ret; }