From patchwork Fri Jul 3 19:38:27 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mukesh Ojha X-Patchwork-Id: 2534 Return-Path: X-Original-To: noreply@patchwork.local Delivered-To: noreply@patchwork.local Received: from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10]) by mxe881.netcup.net (Postfix) with ESMTPS id 4ED711C0929 for ; Fri, 3 Jul 2026 21:48:06 +0200 (CEST) Authentication-Results: mxe881; dkim=pass header.d=qualcomm.com; dkim=pass header.d=oss.qualcomm.com; spf=pass (sender IP is 172.234.253.10) smtp.mailfrom=linux-sunxi+bounces-24131-noreply=patchwork.local@lists.linux.dev smtp.helo=sea.lore.kernel.org Received-SPF: pass (mxe881: domain of lists.linux.dev designates 172.234.253.10 as permitted sender) client-ip=172.234.253.10; envelope-from=linux-sunxi+bounces-24131-noreply=patchwork.local@lists.linux.dev; helo=sea.lore.kernel.org; Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id 5E01D302F393 for ; Fri, 3 Jul 2026 19:45:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5BFA633C536; Fri, 3 Jul 2026 19:45:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="I4lGk2E5"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="e9cyb3pp" X-Original-To: linux-sunxi@lists.linux.dev Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8499330B14 for ; Fri, 3 Jul 2026 19:45:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783107908; cv=none; b=nwTQBtyd0VFlUFk+jDEBJEH87DJ95icI5/8Jz1Xpzvx7siG0NKKE+oxrOWxgdB+qJyeK1FeMi+O9GqxITtYe2oPcq0BIlQOibEDn2ywy2V0wiqT+RJIvoNdcCBwBkdK5TfuraY6NGg/c2HrGqiBtAHWqxcjkm6wvI6Yi0O+oc3Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783107908; c=relaxed/simple; bh=YCS3/Dpz0Fo4USHwvmuADURVgak+6qLUsiuuXpl8TrA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PDc8NLGrcto956vYp50gfTcmjpQ/acmUkBSoqki1fu5ajYA0c7aLY1ENDfDSMGKzTE4BhGF9JW9IPkxL7oZnLqaIzJPQiu1lr+4s2EB51290/ADzXlq4GPJQUoE7h/9iySu2hsS+2Z0HtoWe8WHkrqxCJH1xuXi0COxcFIjR6AU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=I4lGk2E5; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=e9cyb3pp; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 663HiV0q631512 for ; Fri, 3 Jul 2026 19:45:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=wV2jvG58Lj5 Bs1ZlVjSXOSGXHXpRQv1KBOONp4Qs7fI=; b=I4lGk2E5mZ7Li8Ro5GPM2C07N9d b+pOUkiWJ+kt9dhiSiaU2EHDkbsvQyYnnmoK13NsOVmKzOUfpseFpxEEZMgop1sf V4Us6vaVFq4s2wpZA40NshGb0oPMAvVKkWnl+29Iw4tnYF6iVledRkC4P6hYTIWJ aIU87KPTR3fAYuK3eRfa+Jysa7aefGL/V7kSoHfrq7ZA5YmkgmN3YgJtDbXU04e5 XDiArJTWpNNC4h/1ik6zSYXTca60q5JuJiycl0z2+a6YO2+ERe+AcUdLChE29gz3 UssOdQ8699J8ukEPuMOk83jonBFYC42ozd39SRdIY6OCsowsNfKJ65bCjNw== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6b039y9m-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 19:45:04 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-37d4f23eb37so1710255a91.0 for ; Fri, 03 Jul 2026 12:45:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783107904; x=1783712704; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wV2jvG58Lj5Bs1ZlVjSXOSGXHXpRQv1KBOONp4Qs7fI=; b=e9cyb3pp36GN6dv29v6rV0lyAJQ8DW7DNVjbehk3uvN3S5Ac2TfbTXUOdJ+0bFwJ5a 5K3/WnaU3LC0yqQimu512sZm8Ltfl/SB6FSoneCWzo6yYZwS9y8TQBE9x/Tr1D+BuJAs BTnTeCIRJMDfBOdZmhjcJVSikToWKgg7hyQCpQAmAu6T8BFOfwXYqJrO1tWlqncHvOVZ je4FS2o5EoAN1Jd9hsL9qfExwbpRjmRzNt0dxMumEPVRSFESqA+eTc8VaZbwe6ldGWTv 6y2O6mE6Hn79tHDo8qTRvcb2QxVJ6o/6VlCMqWCq15xFmO0PTzqiZPC/wIIcIxpRvxly PG2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783107904; x=1783712704; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wV2jvG58Lj5Bs1ZlVjSXOSGXHXpRQv1KBOONp4Qs7fI=; b=NIFkw97rk7vRBgnh4LWFBwwkKaIY9xQDKMZVW775/HZYQLkE37df+Vs1JLSFpxEsgX IL/PHEAiluRO0UD+8kjwTIpesYButtQ51mQAGpPmfjLkfkU3/cxK90UgpIGFi9dx2TwW gdSJtEeZ9oom0+qGKezIJcKMtj8hhfNO9HoU9r7garnixRW62FxcbGQ3daapnkBZj4EC VcJB1JN9T3THM4rWuYhyg4LwuegN5URBJOVoWbA+f8l8XSC7YDmHlMpJlwzojneTsuzq hd/2uABfnpXqGLpyRDWefda0HEfP4+dgemeGZd+tP6XAc4DrT5S0BiDQwKptrG2Ei1ZY XeGQ== X-Forwarded-Encrypted: i=1; AHgh+RrYj/zUJhZEM0wPxP/hAg98lEW7b6oYopfT7DWjailduz90VtY8A8ZIeK3N5ybSvaBtDOBjuBDhqv+zgg==@lists.linux.dev X-Gm-Message-State: AOJu0Yylrk/9/dGUxxRf6+5MKEkmTlRq9tdPDpwRMZHzAIAY66W32TWd DYagw4kmD0CtJcoFtfB+9xu9gPAXZ6adAfAxdq8RUDKQ28BX1f7Bv4bP+ZaQNXZNT9E1FKuesmL hC/PqCPYDj7v+tKqpC735yKQA9JO78jwgWHxTHS8aHBhEQY/udaBpIkrFA/OQzqrl7g== X-Gm-Gg: AfdE7cl/19O4mzsviI5vjBb1L6MznjNefeuyR7GdhtMlv8wYuRfdxASFLNqINLPiPDJ bQHR16VzOVi2TgFX91fzcoZ2MGOu+vLfUsZ6IK3RCX2pxWNudiMsaWlkuTjsraGK9BenwAyZ4Dh /sSTpCNgHErlpw1Gtn5Kf9iW1wJ0UtCH0k1IgoY0p40MKijgk33XEPxIqlTQaAS6ezEQs7WLXgM bejiFUUU6Y0vK+i4Hz43Dl3cLjQGp7xhAYMYOFWxeZ5GRmlWGG7w6FDhfFd0POrQmPY3RCnpGug wtt2z2+HymVV5SK645cC67XpdNACTaCEfWqajHEZRlCtaJNEjLLaMsDDoXHRgUcRF1uLn2nXECS zDhfwa7aBAgmKWYvwO63t++eGTRo3cy9HLDgcWg== X-Received: by 2002:a17:90b:1d51:b0:383:5a16:bd70 with SMTP id 98e67ed59e1d1-3835a16be4bmr383636a91.16.1783107903484; Fri, 03 Jul 2026 12:45:03 -0700 (PDT) X-Received: by 2002:a17:90b:1d51:b0:383:5a16:bd70 with SMTP id 98e67ed59e1d1-3835a16be4bmr383511a91.16.1783107902725; Fri, 03 Jul 2026 12:45:02 -0700 (PDT) Received: from hu-mojha-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30f290b6bc2sm10065845eec.27.2026.07.03.12.44.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2026 12:45:02 -0700 (PDT) From: Mukesh Ojha To: Bjorn Andersson , Konrad Dybcio , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Joel Stanley , Andrew Jeffery , Paul Cercueil , Anitha Chrisanthus , Paul Kocialkowski , Linus Walleij , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Alexey Brodkin , Laurent Pinchart , Tomi Valkeinen , Michal Simek , Daniel Scally , Jacopo Mondi , Mauro Carvalho Chehab , Eddie James , Tiffany Lin , Andrew-CT Chen , Yunfei Dong , Minghsiu Tsai , Houlong Wei , Matthias Brugger , AngeloGioacchino Del Regno , Joseph Liu , Marvin Lin , Dmitry Osipenko , Krzysztof Kozlowski , Thierry Reding , Jonathan Hunter , Srinivas Kandagatla , Arnd Bergmann , Greg Kroah-Hartman , Ge Gordon , Adrian Hunter , Ulf Hansson , Rob Herring , Saravana Kannan , Mathieu Poirier , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Liam Girdwood , Mark Brown , Frank Li , Sascha Hauer , Peter Ujfalusi , Bard Liao , Daniel Baluta , Orson Zhai , Baolin Wang , Peter Chen , Fugang Duan Cc: Ekansh Gupta , BST Linux Kernel Upstream Group , Fabio Estevam , Nicolin Chen , Pengutronix Kernel Team , Kai Vehmanen , Pierre-Louis Bossart , Vijendar Mukunda , Chunyan Zhang , CIX Linux Kernel Upstream Group , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-media@vger.kernel.org, openbmc@lists.ozlabs.org, linux-mediatek@lists.infradead.org, kernel@collabora.com, linux-tegra@vger.kernel.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-staging@lists.linux.dev, linux-sound@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, sound-open-firmware@alsa-project.org, Mukesh Ojha Subject: [PATCH 14/42] memory: tegra210-emc: Use devm_of_reserved_mem_device_init_by_name() Date: Sat, 4 Jul 2026 01:08:27 +0530 Message-ID: <20260703193855.110619-15-mukesh.ojha@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260703193855.110619-1-mukesh.ojha@oss.qualcomm.com> References: <20260703193855.110619-1-mukesh.ojha@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDE5OSBTYWx0ZWRfXx+omwQJIppAp GqpUYjwvecT+jyZz0RaOlahSzxuJ79D/6cIVnnn4h4MZ6YHuTbgjMUVPc/oSweUCh3hTKfAgBp1 cPXGZPQNGGb8tSZf6KYhHfxLk7ztPzY= X-Proofpoint-GUID: v-fk6LxwKIzArI8t4swhuVC1KXMQH_RI X-Authority-Analysis: v=2.4 cv=FoY1OWrq c=1 sm=1 tr=0 ts=6a481140 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=0pCqoRa_c3HA8O-7yLQA:9 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDE5OSBTYWx0ZWRfX2TjwTKmMaFOZ N0fZw2vVDOAO5WUirUWkCH7Im6gWGMkFxiHj6KEmYK7ZZINkkpEfrQY1tyfR5USWkpwkiCvIkBW qmfMGu+babHA4tzKXITiDzv5NGDxXNMdGs/odUCYNE3bTmZpInCdTCgl/kq3dEWLotchEttrXVB +6v3dMf8raO7Kt80N8x+cH0SNXzuN6yNc852yyVNvOr5ufK8ejSBJGzmJ8qQLK0iRMIrDes0ugN jlgGNW9qQbb0taqyMSx3a99ArdavUDV5XthwcYkohcQ5dxyS+K3M+GEJjIrAPh+WCCKI7Y5MCv9 jjyHtWvDZOpJwUQ6BgJY1j4YEO/6cWR4RcSmK4aPIMS+AT8ePvRUJSpvXkIUzLx+d/d59hudaTf /1TF7GwKQQV9ufT0AJl5uKB0Bj24Kwdbms+juBnT1m9S8gkR6wh3sAHT2GSUiNztabFj1XQBrLd yblgiEnSXCActf8sZFA== X-Proofpoint-ORIG-GUID: v-fk6LxwKIzArI8t4swhuVC1KXMQH_RI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_03,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 clxscore=1015 malwarescore=0 adultscore=0 suspectscore=0 spamscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030199 X-MORS-Enabled: yes X-MORS-DOMAIN: patchwork.local X-MORS-HOSTING: hosting172546 X-MORS-USER: hosting172546 X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= Switch to the new devm_of_reserved_mem_device_init_by_name() for both the nominal and derated reserved memory regions so they are released automatically on probe failure or device removal. All six goto release paths in the probe function precede clock attach and debugfs initialization, so they become plain return statements. The release: label and its explicit of_reserved_mem_device_release() calls in both the probe error path and tegra210_emc_remove() are removed. Signed-off-by: Mukesh Ojha --- drivers/memory/tegra/tegra210-emc-core.c | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/drivers/memory/tegra/tegra210-emc-core.c b/drivers/memory/tegra/tegra210-emc-core.c index e8d4cd8fdec2..07c7654dac63 100644 --- a/drivers/memory/tegra/tegra210-emc-core.c +++ b/drivers/memory/tegra/tegra210-emc-core.c @@ -1847,16 +1847,16 @@ static int tegra210_emc_probe(struct platform_device *pdev) np = pdev->dev.of_node; /* attach to the nominal and (optional) derated tables */ - err = of_reserved_mem_device_init_by_name(emc->dev, np, "nominal"); + err = devm_of_reserved_mem_device_init_by_name(emc->dev, np, "nominal"); if (err < 0) { dev_err(emc->dev, "failed to get nominal EMC table: %d\n", err); return err; } - err = of_reserved_mem_device_init_by_name(emc->dev, np, "derated"); + err = devm_of_reserved_mem_device_init_by_name(emc->dev, np, "derated"); if (err < 0 && err != -ENODEV) { dev_err(emc->dev, "failed to get derated EMC table: %d\n", err); - goto release; + return err; } /* validate the tables */ @@ -1864,14 +1864,14 @@ static int tegra210_emc_probe(struct platform_device *pdev) err = tegra210_emc_validate_timings(emc, emc->nominal, emc->num_timings); if (err < 0) - goto release; + return err; } if (emc->derated) { err = tegra210_emc_validate_timings(emc, emc->derated, emc->num_timings); if (err < 0) - goto release; + return err; } /* default to the nominal table */ @@ -1891,7 +1891,7 @@ static int tegra210_emc_probe(struct platform_device *pdev) dev_err(emc->dev, "no EMC table entry found for %lu kHz\n", current_rate); err = -ENOENT; - goto release; + return err; } /* pick a compatible clock change sequence for the EMC table */ @@ -1909,7 +1909,7 @@ static int tegra210_emc_probe(struct platform_device *pdev) dev_err(&pdev->dev, "sequence %u not supported\n", emc->timings[0].revision); err = -ENOTSUPP; - goto release; + return err; } emc->offsets = &tegra210_emc_table_register_offsets; @@ -1924,7 +1924,7 @@ static int tegra210_emc_probe(struct platform_device *pdev) GFP_KERNEL); if (!emc->provider.configs) { err = -ENOMEM; - goto release; + return err; } emc->provider.num_configs = emc->num_timings; @@ -1949,7 +1949,7 @@ static int tegra210_emc_probe(struct platform_device *pdev) err = tegra210_clk_emc_attach(emc->clk, &emc->provider); if (err < 0) { dev_err(&pdev->dev, "failed to attach to EMC clock: %d\n", err); - goto release; + return err; } emc->clkchange_delay = 100; @@ -1979,8 +1979,6 @@ static int tegra210_emc_probe(struct platform_device *pdev) detach: debugfs_remove_recursive(emc->debugfs.root); tegra210_clk_emc_detach(emc->clk); -release: - of_reserved_mem_device_release(emc->dev); return err; } @@ -1991,7 +1989,6 @@ static void tegra210_emc_remove(struct platform_device *pdev) debugfs_remove_recursive(emc->debugfs.root); tegra210_clk_emc_detach(emc->clk); - of_reserved_mem_device_release(emc->dev); } static int __maybe_unused tegra210_emc_suspend(struct device *dev)