From patchwork Wed Jul 15 09:55:23 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bui Duc Phuc X-Patchwork-Id: 2655 Return-Path: X-Original-To: noreply@patchwork.local Delivered-To: noreply@patchwork.local Received: from sto.lore.kernel.org (sto.lore.kernel.org [172.232.135.74]) by mxe881.netcup.net (Postfix) with ESMTPS id 593A91C2C76 for ; Wed, 15 Jul 2026 11:56:16 +0200 (CEST) Authentication-Results: mxe881; dkim=pass header.d=gmail.com; spf=pass (sender IP is 172.232.135.74) smtp.mailfrom=linux-sunxi+bounces-24431-noreply=patchwork.local@lists.linux.dev smtp.helo=sto.lore.kernel.org Received-SPF: pass (mxe881: domain of lists.linux.dev designates 172.232.135.74 as permitted sender) client-ip=172.232.135.74; envelope-from=linux-sunxi+bounces-24431-noreply=patchwork.local@lists.linux.dev; helo=sto.lore.kernel.org; Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sto.lore.kernel.org (Postfix) with ESMTP id EE8453008993 for ; Wed, 15 Jul 2026 09:56:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0CDFD3C3450; Wed, 15 Jul 2026 09:56:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Fd+AkR8k" X-Original-To: linux-sunxi@lists.linux.dev Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD5773CEBA6 for ; Wed, 15 Jul 2026 09:56:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784109373; cv=none; b=bkz5T1biAW/qwKzU9KuIgYMXCxaqakL/0DfZe0rwb9MF64inSkCqzhkK4p7KGVtGxCp/QhPTd2cRLUaKJGwDJttiJ3u6B4Z++CQOLudsua2SnajxTgeBOPG17HTU0lb7CdQmqvjBdrufQ43cntUp70E2uvztZxXtn9b2WxHexyQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784109373; c=relaxed/simple; bh=jXeHXz0sgTqbPCpgE0Ek4FYcDSoYTpRTfMU644+qSc8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=liyyBVnoJpMjFv2U9LMQkAgKZOj5ZAyCU1L6Za/MbL6wJhJp4Yj7LThWmXrzjdz60s1iZG3WLqtWGKbGnFOs3qWQi6/WPj3Rdbm6Ut6ohHoG8TKmdQnNgT464SyK5hUI9lrasFtkTMoxjE73oVOOj1RwFeyj0lftW0/NdEvF0GY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Fd+AkR8k; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-84a4d8fd6ecso1873047b3a.1 for ; Wed, 15 Jul 2026 02:56:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784109372; x=1784714172; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=IG9ROgmPkgpOSWt5kVvQ2eBpCUOMrMqYLeguMnD/GAI=; b=Fd+AkR8kDFOYqv2LRsO5/ln7NYO4XhZIrx1EW3lu5nsKoAZJyc/R5MpFbWM+GvBwkw GEhrCd0jAJ79g9pKKQPPnO02OeVWXEk1roIWD8fkWWqU/TT43/2aznaEmt6+HgIuvjVK fmaNikhiR6rS/AiUu7J166nz2LuSGnbJH5YXy84e0gIsEH/GWRmrHuQo/ezxRfmxUGDK iUwwtR+Ok8eLUrB39fXHa1Hp2sX55gPT0UC2BKRoLaT57/rd5UdZUIAH/I6CiXfGv+lu 9thz6dm02UwEVU4BBUyfvjtirqVHcRX3pCOTkXreYMJAdxR2DVup5Su8GeGqm+vnojyY 6Lig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784109372; x=1784714172; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=IG9ROgmPkgpOSWt5kVvQ2eBpCUOMrMqYLeguMnD/GAI=; b=Slbw4hrxeVfcXBaw9P2A3n5mj1UFqlWw++/rh13QIcXF8RlOxVgvDmE6iHXrQK+D5J mKCbhM0ZR/ObG74z4qNK7VRj36PyFUKO7FEd6sbcWWTVr5We/H9TTLPzKt4fAynYO2vK 7S1WRqRfTDWXuRSN+4ARg8LwDTm4ivMbsZgwmFGraBBtZZ3O+z7FJkXjQHUZb7JwwC+w aKKstS7luO1cqtLxx08/nlDM/shaY9vdJNuoNgtJs9Z4Utgglpa13/NGxC4ZX+iH1/1U 0H0siTvmvFo0Hih92MuZ0A+0YIwissxqfLpqP7uylJTM2HJwMno57BRaOYMJUQU/X2z8 TnYA== X-Forwarded-Encrypted: i=1; AHgh+RqA4gSPfR5W8fMzKGTD/i7nG31dGV3XNRVlz7chOykV7i4c+HsnHOFoztcOSeJm/btRG+tWfd7nPj326Q==@lists.linux.dev X-Gm-Message-State: AOJu0Yx4bsKy/s0vd1kIiWjlXuv6uhC+gACQalEgI5tUOVgJxWPApo7X shvRWVIyCK8fk7OemfNhKMvUTvQNubaqa17YQWWnHmdNcz8Lby+yWg7q X-Gm-Gg: AfdE7cnzSMOfM+xxjB2R4zkaXJBwjpE+cckI/GAJJv8SX7p34JHKGVTrJAGFSEjybmc xNNC0yfwBlCWCVmfvP1CgzPZHx2PYmeBXGtcbyoZc9HnKJgHSSPvQ5lZdDKHkRmSPW83oe+CQaN Z2swv9X1kbruV7ElgXSIdWS69D5UxZM5c37EkuHc4kP4w3yk1GPqpPQAQOMjV+f57JQ3D+MMyRZ o9gIQpUXzdvxUG4fc/EgmiWOTtCqluKa2Y4j8Lgb6AyeQO0nDqMrTaOL/30gNcDoeS3ZUBQLyyv bzVzNVrfvCuzrSD46hY2zLKBndH92UMjGkgWu6Z8Y0coZ1Rda0WOszOTzeNAONwTVKhCFUBY6ox CJ7gLEaMRZE7a28/ZB3rSiduHyBZG3vq5UR9bXEBKyUM7t2LRMQehsARdPO7Zr7eHoHR6lpSm2y 7Cv1OM5yFZFm1tvmc7Elp5WnhyoELGGoXxMWsJJ1VQWWmwkg8= X-Received: by 2002:a05:6a00:10c9:b0:847:86b0:888c with SMTP id d2e1a72fcca58-84a6733bf25mr1897232b3a.48.1784109372039; Wed, 15 Jul 2026 02:56:12 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ca5b3643399sm11628908a12.22.2026.07.15.02.56.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 02:56:11 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai Cc: Jernej Skrabec , Samuel Holland , Charles Keepax , Kuninori Morimoto , Chen Ni , Marcus Cooper , Bjorn Helgaas , Danilo Krummrich , u.kleine-koenig@baylibre.com, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sound@vger.kernel.org, bui duc phuc Subject: [PATCH 4/6] ASoC: sunxi: sun4i-spdif: Use dev_err_probe() for probe error handling Date: Wed, 15 Jul 2026 16:55:23 +0700 Message-ID: <20260715095525.40668-5-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260715095525.40668-1-phucduc.bui@gmail.com> References: <20260715095525.40668-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Rspamd-Server: rspamd-worker-8404 X-Spamd-Result: default: False [-0.66 / 15.00]; BAYES_HAM(-5.50)[100.00%]; RBL_SENDERSCORE(2.00)[172.232.135.74:from]; SUSPICIOUS_RECIPS(1.50)[]; DMARC_POLICY_SOFTFAIL(1.00)[gmail.com : SPF not aligned (relaxed), No valid DKIM,none]; R_MISSING_CHARSET(0.50)[]; MAILLIST(-0.15)[generic]; MIME_GOOD(-0.10)[text/plain]; BAD_REP_POLICIES(0.10)[]; HAS_LIST_UNSUB(-0.01)[]; PRECEDENCE_BULK(0.00)[]; TAGGED_RCPT(0.00)[]; FREEMAIL_CC(0.00)[gmail.com,sholland.org,opensource.cirrus.com,renesas.com,iscas.ac.cn,google.com,kernel.org,baylibre.com,lists.linux.dev,vger.kernel.org,lists.infradead.org]; FORGED_SENDER_MAILLIST(0.00)[]; FROM_NO_DN(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; DBL_BLOCKED_OPENRESOLVER(0.00)[sto.lore.kernel.org:rdns,sto.lore.kernel.org:helo]; RCPT_COUNT_TWELVE(0.00)[19]; RCVD_COUNT_FIVE(0.00)[6]; ASN(0.00)[asn:63949, ipnet:172.232.128.0/19, country:SG]; R_SPF_ALLOW(0.00)[+ip4:172.232.135.74]; FREEMAIL_TO(0.00)[kernel.org,gmail.com,perex.cz,suse.com]; FREEMAIL_FROM(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; FROM_NEQ_ENVFROM(0.00)[phucducbui@gmail.com,linux-sunxi@lists.linux.dev]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; RCVD_TLS_LAST(0.00)[]; TAGGED_FROM(0.00)[bounces-24431-noreply=patchwork.local]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; ARC_ALLOW(0.00)[subspace.kernel.org:s=arc-20240116:i=1]; RCVD_VIA_SMTP_AUTH(0.00)[] X-Rspamd-Queue-Id: 593A91C2C76 X-MORS-Enabled: yes X-MORS-DOMAIN: patchwork.local X-MORS-HOSTING: hosting172546 X-MORS-USER: hosting172546 X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= From: bui duc phuc Use dev_err_probe() for probe error handling to simplify the error paths and handle -EPROBE_DEFER correctly. Signed-off-by: bui duc phuc Reviewed-by: Chen-Yu Tsai --- sound/soc/sunxi/sun4i-spdif.c | 23 ++++++++++------------- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/sound/soc/sunxi/sun4i-spdif.c b/sound/soc/sunxi/sun4i-spdif.c index c2ec19437cd7..d979bb00312f 100644 --- a/sound/soc/sunxi/sun4i-spdif.c +++ b/sound/soc/sunxi/sun4i-spdif.c @@ -684,26 +684,23 @@ static int sun4i_spdif_probe(struct platform_device *pdev) host->regmap = devm_regmap_init_mmio(&pdev->dev, base, &sun4i_spdif_regmap_config); - if (IS_ERR(host->regmap)) { - dev_err(&pdev->dev, "failed to initialise regmap.\n"); - return PTR_ERR(host->regmap); - } + if (IS_ERR(host->regmap)) + return dev_err_probe(&pdev->dev, PTR_ERR(host->regmap), + "failed to initialise regmap.\n"); /* Clocks */ host->apb_clk = devm_clk_get(&pdev->dev, "apb"); - if (IS_ERR(host->apb_clk)) { - dev_err(&pdev->dev, "failed to get a apb clock.\n"); - return PTR_ERR(host->apb_clk); - } + if (IS_ERR(host->apb_clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(host->apb_clk), + "failed to get a apb clock.\n"); if (quirks->tx_clk_name) tx_clk_name = quirks->tx_clk_name; host->spdif_clk = devm_clk_get(&pdev->dev, tx_clk_name); - if (IS_ERR(host->spdif_clk)) { - dev_err(&pdev->dev, "failed to get the \"%s\" clock.\n", - tx_clk_name); - return PTR_ERR(host->spdif_clk); - } + if (IS_ERR(host->spdif_clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(host->spdif_clk), + "failed to get the \"%s\" clock.\n", + tx_clk_name); host->dma_params_tx.addr = res->start + quirks->reg_dac_txdata; host->dma_params_tx.maxburst = 8;