From patchwork Tue Sep 22 03:19:54 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bui Duc Phuc X-Patchwork-Id: 3415 Return-Path: X-Original-To: noreply@patchwork.local Delivered-To: noreply@patchwork.local Received: from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10]) by mxe881.netcup.net (Postfix) with ESMTPS id 63B2F1C2D7D for ; Tue, 22 Sep 2026 05:24:49 +0200 (CEST) Authentication-Results: mxe881; dkim=pass header.d=gmail.com; spf=pass (sender IP is 172.234.253.10) smtp.mailfrom=linux-sunxi+bounces-26120-noreply=patchwork.local@lists.linux.dev smtp.helo=sea.lore.kernel.org Received-SPF: pass (mxe881: domain of lists.linux.dev designates 172.234.253.10 as permitted sender) client-ip=172.234.253.10; envelope-from=linux-sunxi+bounces-26120-noreply=patchwork.local@lists.linux.dev; helo=sea.lore.kernel.org; Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id 5451266798 for ; Tue, 22 Sep 2026 03:20:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A331919D8BC; Tue, 22 Sep 2026 03:20:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jwglAlVA" X-Original-To: linux-sunxi@lists.linux.dev Received: from mail-pj2-f42.google.com (mail-pj2-f42.google.com [74.125.227.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95A793B7B93 for ; Tue, 22 Sep 2026 03:20:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790047253; cv=none; b=sP5egc/oIbFnTubEj44GiJ94K3juhO5SlDTmAgmiCgo6poIAum+FLnlffac2xm+FlVNKbc8ZR8RvrKKg8TzKUjqMAn8tJQG/shmOzr0cn6aFexGdtbUg7K0X+wcoo7EGmzA2oKb4iAlPXMJH+IWEGsKxNTzBLjNIOa1H6pGTHhQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790047253; c=relaxed/simple; bh=8A5lbFX7jPgNjHXFUP9sZMZQ7/uPse/Wza7yZTZRNrc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dPJH3+I9K5raVTFgdsKm8CAcqxuZAq6BAj2SbxmLWyOjMjIl0E7ZKOKsKfLo3wEMStFBdesG3BflDBAWbONEon9feWe++oIJniFpZXIXPV4Ac8KEJy3JBa0HpqzOjWaghYCQbMeRpK56m5FyVg1pe+tBdPmASG00tebbf72NLb4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jwglAlVA; arc=none smtp.client-ip=74.125.227.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj2-f42.google.com with SMTP id d9443c01a7336-2df4aa80a73so14901245ad.3 for ; Mon, 21 Sep 2026 20:20:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790047251; x=1790652051; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Z7TxIVacK4CiPP85Zm/zWINHMIm3Lw/0BaBVswTN6EM=; b=jwglAlVAR93Hj871Rl6Rhe5Plx4FW9R256uhjYrxJljyggdZOfU39RXZ2HBQkm++V9 nERexMAqbv81Jl0OUUiNpxXt7UEZky9yXL4TczeZeIWkLy6qKe9TGrCFB6VtRa13zS26 lHn+Pu+fBuGct8Joi/zCpBOsP5eBWByBNVAnG7lZ1bSf3n9FkcFcJgYPA1929oRiJZX2 +TLwUu3JvOM4TgEEvWStc9QqyVDgUwdLwMO9DCOoGObyg2z3Azf+NlXEFYfWtJ7gh9+z vS4SY1sxHOjYBG5bF6YH2i7xBFUB7Bfr4219d2rmcPtJNJV8oZEZfCLbCyKlWjIUO7AP E64A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790047251; x=1790652051; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Z7TxIVacK4CiPP85Zm/zWINHMIm3Lw/0BaBVswTN6EM=; b=OQgF2nwyxBBrWRgEac2nBuHxtg3ZKWX1C7tJ3+m0rsl+xm0/OxN9YSkUAOMqI7QLbl LV/lyr4PCMO5VzN6BdmWe2/zuKS6b+/Qzro376TkShSGrlgVulpvnQy3udKnuKSgDfiO OtUv3RfbgD5Iy8QBMlrH9XHXL1/3VxO/Jt75ccv279ja6cFoj1ABOBwa0FDlAHcV+JUa oMes8SNbnP3pwqf7ATNFbX8XbGso+ZiFVMDEoTO4z33E8myTT9X1DgDTkNk4D39XhEAj gfyv52VXrKaxwLvw2JEUf0Z5g0WANEP9DH6e5Pcf85OqxZvtJLTdOjaxLDag5xwhqR3e qG6Q== X-Gm-Message-State: AFuF++ld0ilZtDOwmjuvTxyaFa1//f/uyvObiRt3nHLXBWa+5wL9m2x+ 8FLM/Ubpozcjn43nSGP7oACitN1lRoNmesV/Lr/oo0rVut9ONDQRJM2G X-Gm-Gg: AYBFou2YL85M4s/7nA4gnYQO/6HUKL36ThE+i+d1TmB3i+I6bI8kCsmO0sX2tPpE69+ yvh3TP2WLWuobTrGNntcIdtjDNazKzLQVBz3dwbadVX2bPIaWNecK+/vfV9aD0wvkIK0PepYKBX Qmz0tCnaO8VDxC/A4tCJ+OElFUr+5hCfaDkeW+zT1GtaY0CneklCwfv4h/Z5++Q5bGEpiSWL9R4 QUDuUJ0pgIjiROUtoG8NQ5qDi6F5EO6hoxdiVAceF0G1ywy1gOYDX9TJNs/BfUMzwBaB/VEtZ2W FbUjPrkWEA64ARg6Qi6RLiy1ZidP6msX7nDc/cWBh7DnFPqHBlqNDK0Zb8T5A6eSEB8TYm8z8C0 osPMK8KDfnd4FAw6Zkqw/gD5AD4rf6b8OLYu1QIzys89BuOsFKFvrG36vvU7c5chQ2zbsErMAyR IzOp0EIXVarAQ21D20ugWDxxSyMacjRwNjfn591NSrYTv20mzNDF6dzCoIERhKR+3fjHYqgU8VP FnN+sH3hhIyEs4Y88GSU23PsMXt3Y5v9+RBmUWYcegSMdCoPWHimJ0MXw5mDH/gAZzwNr4rk/cy f8fo2BH2A38AvedDPK69Rcly X-Received: by 2002:a17:903:b84:b0:2dd:c053:82fa with SMTP id d9443c01a7336-2ddc053843cmr122847195ad.49.1790047250783; Mon, 21 Sep 2026 20:20:50 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2df5cf83512sm1940355ad.5.2026.09.21.20.20.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Sep 2026 20:20:50 -0700 (PDT) From: phucduc.bui@gmail.com To: Corentin Labbe , Herbert Xu , davem@davemloft.net, Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Gilad Ben-Yossef , Hans Ulli Kroll , Linus Walleij , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 3/3] crypto: sl3516 - Use pm_runtime_resume_and_get() Date: Tue, 22 Sep 2026 10:19:54 +0700 Message-ID: <20260922031954.320895-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260922031954.320895-1-phucduc.bui@gmail.com> References: <20260922031954.320895-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Rspamd-Server: rspamd-worker-8404 X-Spamd-Result: default: False [-0.66 / 15.00]; BAYES_HAM(-5.50)[100.00%]; RBL_SENDERSCORE(2.00)[172.234.253.10:from]; SUSPICIOUS_RECIPS(1.50)[]; DMARC_POLICY_SOFTFAIL(1.00)[gmail.com : SPF not aligned (relaxed), No valid DKIM,none]; R_MISSING_CHARSET(0.50)[]; MAILLIST(-0.15)[generic]; MIME_GOOD(-0.10)[text/plain]; BAD_REP_POLICIES(0.10)[]; HAS_LIST_UNSUB(-0.01)[]; TAGGED_RCPT(0.00)[]; PRECEDENCE_BULK(0.00)[]; FROM_NO_DN(0.00)[]; RCPT_COUNT_TWELVE(0.00)[14]; FORGED_SENDER_MAILLIST(0.00)[]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; FREEMAIL_CC(0.00)[lists.linux.dev,vger.kernel.org,gmail.com]; DBL_BLOCKED_OPENRESOLVER(0.00)[sea.lore.kernel.org:rdns,sea.lore.kernel.org:helo]; RCVD_COUNT_FIVE(0.00)[6]; FROM_NEQ_ENVFROM(0.00)[phucducbui@gmail.com,linux-sunxi@lists.linux.dev]; TAGGED_FROM(0.00)[bounces-26120-noreply=patchwork.local]; FREEMAIL_FROM(0.00)[gmail.com]; R_SPF_ALLOW(0.00)[+ip4:172.234.253.10]; TO_DN_SOME(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[172.234.253.10:from]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[74.125.227.170:received,100.90.174.1:received]; ASN(0.00)[asn:63949, ipnet:172.234.224.0/19, country:SG]; FREEMAIL_TO(0.00)[gmail.com,gondor.apana.org.au,davemloft.net,kernel.org,sholland.org,benyossef.com,googlemail.com,vger.kernel.org,lists.infradead.org]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[183.91.15.56:received]; ARC_ALLOW(0.00)[subspace.kernel.org:s=arc-20240116:i=1]; RCVD_TLS_LAST(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[] X-Rspamd-Queue-Id: 63B2F1C2D7D X-MORS-Enabled: yes X-MORS-DOMAIN: patchwork.local X-MORS-HOSTING: hosting172546 X-MORS-USER: hosting172546 X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= From: bui duc phuc Replace the open-coded pm_runtime_get_sync() + pm_runtime_put_noidle() error handling pattern with pm_runtime_resume_and_get(), which already does this internally. No functional change. Found by manual code inspection. Signed-off-by: bui duc phuc --- drivers/crypto/gemini/sl3516-ce-cipher.c | 3 +-- drivers/crypto/gemini/sl3516-ce-rng.c | 6 ++---- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/gemini/sl3516-ce-cipher.c b/drivers/crypto/gemini/sl3516-ce-cipher.c index 02ec4282333b..eba46aebf176 100644 --- a/drivers/crypto/gemini/sl3516-ce-cipher.c +++ b/drivers/crypto/gemini/sl3516-ce-cipher.c @@ -331,13 +331,12 @@ int sl3516_ce_cipher_init(struct crypto_tfm *tfm) crypto_tfm_alg_driver_name(&sktfm->base), crypto_tfm_alg_driver_name(crypto_skcipher_tfm(op->fallback_tfm))); - err = pm_runtime_get_sync(op->ce->dev); + err = pm_runtime_resume_and_get(op->ce->dev); if (err < 0) goto error_pm; return 0; error_pm: - pm_runtime_put_noidle(op->ce->dev); crypto_free_skcipher(op->fallback_tfm); return err; } diff --git a/drivers/crypto/gemini/sl3516-ce-rng.c b/drivers/crypto/gemini/sl3516-ce-rng.c index 76931ec1cec5..19af03b03e42 100644 --- a/drivers/crypto/gemini/sl3516-ce-rng.c +++ b/drivers/crypto/gemini/sl3516-ce-rng.c @@ -24,11 +24,9 @@ static int sl3516_ce_rng_read(struct hwrng *rng, void *buf, size_t max, bool wai ce->hwrng_stat_bytes += max; #endif - err = pm_runtime_get_sync(ce->dev); - if (err < 0) { - pm_runtime_put_noidle(ce->dev); + err = pm_runtime_resume_and_get(ce->dev); + if (err < 0) return err; - } while (read < max) { *data = readl(ce->base + IPSEC_RAND_NUM_REG);