From patchwork Wed Oct 14 17:27:23 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 3611 Return-Path: X-Original-To: noreply@patchwork.local Delivered-To: noreply@patchwork.local Received: from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10]) by mxe881.netcup.net (Postfix) with ESMTPS id 069EF1C6340 for ; Wed, 14 Oct 2026 19:36:11 +0200 (CEST) Authentication-Results: mxe881; dkim=pass header.d=kernel.org; spf=pass (sender IP is 172.234.253.10) smtp.mailfrom=linux-sunxi+bounces-26642-noreply=patchwork.local@lists.linux.dev smtp.helo=sea.lore.kernel.org Received-SPF: pass (mxe881: domain of lists.linux.dev designates 172.234.253.10 as permitted sender) client-ip=172.234.253.10; envelope-from=linux-sunxi+bounces-26642-noreply=patchwork.local@lists.linux.dev; helo=sea.lore.kernel.org; Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id DF32B3124D for ; Wed, 14 Oct 2026 17:30:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 18BDC271A94; Wed, 14 Oct 2026 17:30:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ls/wC7FH" X-Original-To: linux-sunxi@lists.linux.dev Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7EC0563FA2 for ; Wed, 14 Oct 2026 17:30:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791999055; cv=none; b=CJV4TX08VF5k4VettvHXxR4rd17tFY5pkp2Ygd3MmaeRpX9Cq31Fou8OUQ60HkgNZI/bx1o8FO0y2GgdPX1qJs1XL6gE0uC0195PgBSVKU5cQoxuqjY/ADM6AyjM56KVlVKD+v43jbfJDS74fhUCAd5IIjWo3IIN81IAx7dELks= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791999055; c=relaxed/simple; bh=i8MYkIjGLYh93ZYp+TwUqmFpGoWQ2CROBOjcXchRZbM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=p99D4CKbRFZi8Y5U7N3+hyok2lUEWuBW+7ewWRYJi2INPvul1hGygYIvOJX02cgxgqc7QYl8N5RKrw2iqPpkok67d0+TbZO34+LNRT/E0Da2XBCeJRP4u9sdTDbdxVpiofWZcVx1ZeU0TzW1QqOCiUvM1Lth9xr8+CiHVpVSAAU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Ls/wC7FH; arc=none smtp.client-ip=100.103.45.18 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 153F01F000C4; Wed, 14 Oct 2026 17:30:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791999050; bh=DbSuhGcU5F2AudOqjawBMeENfozP8H5WOsGmSV1ZOEI=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=Ls/wC7FHf0dFNpmbTLsuMoQOA1oDVdEF1yaadRDiLZCGwB2L6WC9b3AmxBy3Ozogp ou+GPvgdPiIWERdrGFjq65sOgwO16oC8dkxZKIGOJqx7Pzz7jWxwRTzrsriAVu3pGY b2BMmVNVtYFshe0Y3o3XdGG7ANEohwawvI9ALW3hRoxUqYKIR3drQuVztO4Kgg1J4/ vxlZOZVYGXgoCzh1qErRfe4fkTWizHvWmcIK4JQWQ5+avt5CpYFN9+36Js2K3DL7qN MiY377V2ZhoNaXdYQtE/UiduFLkKvLMmCxaIIFJkI3BgzeHN/WqAPR/IFwWGvKSBz2 oMathAKpOf7Ag== From: Maxime Ripard Date: Wed, 14 Oct 2026 19:27:23 +0200 Subject: [PATCH 60/75] drm/sun4i: hdmi: Convert to atomic_create_state Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20261014-drm-no-more-connector-reset-v1-60-586c9c026823@kernel.org> References: <20261014-drm-no-more-connector-reset-v1-0-586c9c026823@kernel.org> In-Reply-To: <20261014-drm-no-more-connector-reset-v1-0-586c9c026823@kernel.org> To: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, Maxime Ripard , Chen-Yu Tsai , Samuel Holland , linux-sunxi@lists.linux.dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2138; i=mripard@kernel.org; h=from:subject:message-id; bh=i8MYkIjGLYh93ZYp+TwUqmFpGoWQ2CROBOjcXchRZbM=; b=owGbwMvMwCmsHn9OcpHtvjLG02pJDFnnd6eYpKx6p3VXbf/n0h/uNYYlh8XTrHyS766etlkpf ZXR1qWbO6ayMAhzMsiKKbI8kQk7vbx9cZWD/cofMHNYmUCGMHBxCsBEKhMY66wT/qgydzzZeqY6 VDbx5mz9LYVlB8IaHk7ZW+R91X5KNFv5rttiu69qvBXvdmzqlg3PZWxYVqyctOPyude1N9SEXVg 8/D/nvDjJHSM095/zMouT2UHbXvh4N8vsOuO32t3yccykU2wA X-Developer-Key: i=mripard@kernel.org; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-Rspamd-Server: rspamd-worker-8404 X-Spamd-Result: default: False [-3.66 / 15.00]; BAYES_HAM(-5.50)[100.00%]; RBL_SENDERSCORE(2.00)[172.234.253.10:from]; MAILLIST(-0.15)[generic]; MIME_GOOD(-0.10)[text/plain]; BAD_REP_POLICIES(0.10)[]; HAS_LIST_UNSUB(-0.01)[]; RCVD_COUNT_FIVE(0.00)[5]; R_DKIM_ALLOW(0.00)[kernel.org:s=k20260515]; FROM_HAS_DN(0.00)[]; PRECEDENCE_BULK(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[mripard@kernel.org,linux-sunxi@lists.linux.dev]; DBL_BLOCKED_OPENRESOLVER(0.00)[sholland.org:email,sea.lore.kernel.org:rdns,sea.lore.kernel.org:helo,linux.dev:email]; FORGED_SENDER_MAILLIST(0.00)[]; ARC_ALLOW(0.00)[subspace.kernel.org:s=arc-20240116:i=1]; ASN(0.00)[asn:63949, ipnet:172.234.224.0/19, country:SG]; R_SPF_ALLOW(0.00)[+ip4:172.234.253.10:c]; DKIM_TRACE(0.00)[kernel.org:+]; TO_DN_SOME(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[100.90.174.1:received,100.103.45.18:received]; TAGGED_FROM(0.00)[bounces-26642-noreply=patchwork.local]; DMARC_POLICY_ALLOW(0.00)[kernel.org,quarantine]; FREEMAIL_TO(0.00)[linux.intel.com,suse.de,gmail.com,ffwll.ch]; RCVD_TLS_LAST(0.00)[]; RCPT_COUNT_SEVEN(0.00)[9]; MIME_TRACE(0.00)[0:+]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[172.234.253.10:from] X-Rspamd-Queue-Id: 069EF1C6340 X-MORS-Enabled: yes X-MORS-DOMAIN: patchwork.local X-MORS-HOSTING: hosting172546 X-MORS-USER: hosting172546 X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= The sun4i HDMI connector reset implementation creates a pristine state and initializes the HDMI state. It does not perform any hardware reset. Since this is equivalent to what atomic_create_state expects, convert the reset function to an atomic_create_state hook that returns the initialized state. Signed-off-by: Maxime Ripard --- Cc: Chen-Yu Tsai Cc: Samuel Holland Cc: linux-sunxi@lists.linux.dev --- drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c index d98b6f12a7bc..1226228c2ab3 100644 --- a/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c +++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c @@ -283,21 +283,30 @@ sun4i_hdmi_connector_detect(struct drm_connector *connector, bool force) } return connector_status_connected; } -static void sun4i_hdmi_connector_reset(struct drm_connector *connector) +static struct drm_connector_state * +sun4i_hdmi_connector_create_state(struct drm_connector *connector) { - drm_atomic_helper_connector_reset(connector); - __drm_atomic_helper_connector_hdmi_state_init(connector, connector->state); + struct drm_connector_state *connector_state; + + connector_state = drm_atomic_helper_connector_create_state(connector); + if (IS_ERR(connector_state)) + return connector_state; + + __drm_atomic_helper_connector_hdmi_state_init(connector, + connector_state); + + return connector_state; } static const struct drm_connector_funcs sun4i_hdmi_connector_funcs = { .debugfs_init = drm_hdmi_connector_debugfs_init, .detect = sun4i_hdmi_connector_detect, .fill_modes = drm_helper_probe_single_connector_modes, - .reset = sun4i_hdmi_connector_reset, + .atomic_create_state = sun4i_hdmi_connector_create_state, .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state, .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, }; #ifdef CONFIG_DRM_SUN4I_HDMI_CEC