From patchwork Fri Oct 23 07:33:50 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Hilliard X-Patchwork-Id: 3702 Return-Path: X-Original-To: noreply@patchwork.local Delivered-To: noreply@patchwork.local Received: from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114]) by mxe881.netcup.net (Postfix) with ESMTPS id 7FF481C0982 for ; Fri, 23 Oct 2026 09:36:26 +0200 (CEST) Authentication-Results: mxe881; dkim=pass header.d=gmail.com; spf=pass (sender IP is 172.105.105.114) smtp.mailfrom=linux-sunxi+bounces-26816-noreply=patchwork.local@lists.linux.dev smtp.helo=tor.lore.kernel.org Received-SPF: pass (mxe881: domain of lists.linux.dev designates 172.105.105.114 as permitted sender) client-ip=172.105.105.114; envelope-from=linux-sunxi+bounces-26816-noreply=patchwork.local@lists.linux.dev; helo=tor.lore.kernel.org; Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.77.114.92]) by tor.lore.kernel.org (Postfix) with ESMTP id 28AFC2D0A0 for ; Fri, 23 Oct 2026 07:34:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass header.oldest-pass=0 smtp.remote-ip=127.0.0.1 ARC-Seal: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=pass; t=1792740842; b=fwYEUmTn6QkWk2DelLFuXXB/DpcVkUqx8U7LDD5P/eVAeYaTzYxRp18hA10VvjYIMzUs 7fQMSXfapt+P7rDgpRYu3APVfZI4mJ8xkBtjvmo0yg6WOqTm3btLyJL1KIyOVqLnR9BO6 hCGiGmSJn/xRhHKWIOpIQZYq1/Q6OqqGDohjee41KIph3Y4y7oLVrU8qOqkWuhsWuZDGI +5MbMNeW9OE5FNZ+rP/flD5a4H9zw1SfE2RkJ6/S9rdFZRdRGCWdLBpj6us62lUGM5FMp a9vEC22bjS3y72O6YOfn/r91+XxowGGLnqTluHhm+MTEYjCWrD3IKSNMXkuqKiWGPTw== ARC-Message-Signature: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792740842; h=X-Original-To:Received:DMARC-Filter:Received:DKIM-Signature: X-Google-DKIM-Signature:X-Forwarded-Encrypted:X-Gm-Message-State: X-Gm-Gg:X-Received:Received:From:Date:Subject:X-Mailing-List:List-Id: List-Post:List-Help:List-Subscribe:List-Unsubscribe:List-Owner: Precedence:MIME-Version:Content-Type:Content-Transfer-Encoding: Message-Id:References:In-Reply-To:To:Cc:X-Mailer; bh=TUS+mnADfjPLb/Tu910BRKa7Osyhu7sawMFZwcFgbOg=; b=XvvvbEgYcv2wscVn6BIO/SYcRbqaGKBU3aBe7B7BngMxtcL4GkNLNHbGHoJJ5EqvIr8q jz9R9tUCwZucNh4YofE7V4RTLsDZ8eqf0oRddSb2ha8HFDooYr5pEDrVF4OFnPENevdyH qcyRkgE4El4uiW3Et2LcGRh9XywhFFIYooKMCdoRdkqswlS/PCPKqwf1NjNHYQXB6NPtm Ik4rToXXNN0DKXp0GJ8zUCCDg+C5XqbvA8DYmyx3lECBALZ2UpMWGM1ABdgQ0bC9+NGjF AC5dVYeGu0rI82+uOi04WXGMwf6oXTXAgSJ3/CJ4ccQ4jlEvMYslZ3jnK+beX+Er3pg== ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=KZ1Ex9Uu; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; arc=pass header.oldest-pass=0 smtp.remote-ip=127.0.0.1 Received: from localhost.localdomain (localhost [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 48C8A606A32A; Fri, 23 Oct 2026 07:34:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=KZ1Ex9Uu X-Original-To: linux-sunxi@lists.linux.dev Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.167.177 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792740842; b=5cZqxXQBiISNmt8xy9MdoO7bDlZb+b8pFUYpswQ8qmwynKEaw+xjVlf7uslB2Hy7rm0Z IR0VOZcjpcENF+fe+5ITZc9EnGPbObFREjVRhlVIVLrMNZsGemWupXOd/yqAQRFnspyuW BbzIy1utRf3Sk/zD5cFRQD5222P2zKlxsP3Wb8ql0YeHwzcYBYRERiGcBcLeFnKRY79d6 mU604qVlC3oCket02iAPGRalxfeAl4R4WDPBlgvOeEoT3Af1pltxMABuuRsvMtiLne/VP 16GvwgE3NClTJUdGBibCxnSRf3yUWPFySCA6EWIA5ZralBO7c6wSv0rXrVyZ6peir9w== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792740842; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:Date:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding: Message-Id:References:In-Reply-To:To:Cc:X-Mailer; bh=TUS+mnADfjPLb/Tu910BRKa7Osyhu7sawMFZwcFgbOg=; b=t9geLkcyMAzWME1w+yPXKHkO+tszNlvOD4kYhuf6C8huDXjn8OLvRE0a0rhASO4p509I 0eEHCpxHMR6ASMJkCXmOnhGSOEDsQCCzp7B82MpJWb6wZWsYJVxtNOo1mxg+uTVQi2LHp /UDXiGMIikp75u4gAPgpqlkIvuOxAbhPaxRzTCzW/39jbU91QA2tzvSPAL7M/Er7hM+4O RfhL0z+5mNhtFUWWEhZRy1eU+W97KtFi5wwYxDEfWIEJLZC7ou2ik4QLtoR7NokL343e5 ycrr5vcug2UOCFCVk+mzVVK2EBJ35ddd8N3EQ/Lbv+9Q3jCwdjLfASCC0xlVEkOAYrw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=KZ1Ex9Uu; arc=none smtp.remote-ip=209.85.167.177 Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4910606A320 for ; Fri, 23 Oct 2026 07:34:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org D4910606A320 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oi1-f177.google.com with SMTP id 5614622812f47-539a57a0b1fso254166b6e.2 for ; Fri, 23 Oct 2026 00:34:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792740841; x=1793345641; darn=lists.linux.dev; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=TUS+mnADfjPLb/Tu910BRKa7Osyhu7sawMFZwcFgbOg=; b=KZ1Ex9UuATZl2GXwRPPig5KM6VCHSL5xGBJFQM0jQ2meOh3W8xvy0NIpl/Eb2eMiE6 QTOOU2JeTZO68X1APDVfpfr1+FZsCk/cSC+Czr0rsRGlf2hi/fCabHvrpEZImq+kVMGs LOpPEbfT+uzUJ2SkNEqv00ItLwRB0fJ9+QTMAZlisqwUMgBN8PXVuC3c5ZfCW+H2Iwmq NNiGgFBaz4vQqCS6Rzhi+vMUzfnd1GhzM3FPPE395UqzfXfJ2xarl3QT4IwZZkcgZj0s qsGCQ6ahaN/i943bE6clF0WarSGxE6sU4KML4o+p7SF/YN/FCZKaHzr3iR5aOCHNej/i NCnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792740841; x=1793345641; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=TUS+mnADfjPLb/Tu910BRKa7Osyhu7sawMFZwcFgbOg=; b=0Ohl5Fd4STNGMx02wa5HAjyGiyv/+ngUVj2TvxNWIvNnti1Sxc7NRXozbVBqcGZS54 d2A7UDTqsRmX79kFJZycqXMRkpXPAE/RX/WvlNtktirs91Tnxaz6f9VKOdRdbx5aTa1M BYVl83aAaaYYT5FTk4oTHn+u+DugszLhgiybjHHn3lfoVVNJgJ5Kuf13ESN7/xiITn51 IcpWwtxo+FdPY3qksZkal0mUpAs9esp+xsYDGwbOomeOoT29cZrTBXmR6rA9t8YdQOhJ AzbCOf1uJSj+UkMTNugoAbBAYIXS2F3CFhRlKsltOl5ztGsdr6IrZkq4WdKQ7iCtWQOk unoA== X-Forwarded-Encrypted: i=1; AKwUvByJXHDrml/DBqsB2aoi1I7EcOZ2n8BcSvSPQDgqwSfPXRbEQsFfxwLC8CkJzNBJ54/z3ypahSwbtrw61g==@lists.linux.dev X-Gm-Message-State: AFq9FYKPcC3yuXOwPd2SjbHCpeRJ5jXpQU2baJpcPuGh94zPTqbn66g6 cezm/fgoRsffogKQSBwFiUGPYeBOx2yVv4/yENS7/R740f1V+dEN0Iax X-Gm-Gg: AYBFou3045aNHQ1o3U8auJRcL+ZKeltWuitFzbnaQONZSsYg5TYea5k1WjPAwTc1t1e DNIKwnmuxmJe08NHZweSsLN+Cj4gZVbQZhsKrbS7ts7GhB1ETHfKvtZq70z7sZtUu148U63O4qb d5uxz3FmAz7MnGbjOiA66VCp0SJg9H5clWRImCyYGZUZYKpgNpNklZHSneomR5B7NCsmzIKJuNk hnj/nHMgc96DPY/aaaGq1NzGuNM+XfmIX3gEbbSn8yQOIDBGbsVJWHWPjcmY/rIEddVANI5eoiv SB1suapOgfsYP23ZjcrNst6yVyl/hUbB9DZG2jTLMCB4xpMlZazv2sKgBofhSJux/aSSLtkigXU lg7P268m/wqP6uSFzk+y7KAB87g9u1td48F3eQT/Ol446oGiulgFikXOyWrArl9240QSzHTj055 b1UxaMJwZXP/baJKbHk1ZdcznZhuJhSMUTIYOYibx/Sahq9iti2WrQ93jTAVzhmSkptVkuFjSa7 zQIws4DJMEiQAz8Szhj5QgihUNO9xjF8dKsI57z29e/hgpNttZtiYIuFi7wVWM1WR80xE4xJpag Opo+cAw6+YShl0LwceMMkL8X7qJpHhCaP0wgvmugG0AUiftCy3CQTcTey1P2t7gK/SNlq2nIoU5 yn3swqYwCAePLGtjdKJgXcSP+j97UzeBGfyxgh4rMBxcZ14R970TKT0iSnoelF6EgMy5QM6Ylkp CpnLM= X-Received: by 2002:a05:6808:6d93:b0:4d6:90f3:74ad with SMTP id 5614622812f47-55be82da8c2mr808701b6e.45.1792740840785; Fri, 23 Oct 2026 00:34:00 -0700 (PDT) Received: from [127.0.1.1] (174-29-1-49.hlrn.qwest.net. [174.29.1.49]) by smtp.gmail.com with ESMTPSA id 5614622812f47-55be9880a99sm909562b6e.14.2026.10.23.00.33.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Oct 2026 00:34:00 -0700 (PDT) From: James Hilliard Date: Fri, 23 Oct 2026 01:33:50 -0600 Subject: [PATCH 2/3] serial: 8250_dw: configure the Allwinner H616 UART X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Message-Id: <20261023-submit-h616-uart-fifo-v1-v1-2-e4a3bae2eba8@gmail.com> References: <20261023-submit-h616-uart-fifo-v1-v1-0-e4a3bae2eba8@gmail.com> In-Reply-To: <20261023-submit-h616-uart-fifo-v1-v1-0-e4a3bae2eba8@gmail.com> To: Greg Kroah-Hartman , Jiri Slaby , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Shevchenko , =?utf-8?q?Ilpo_J=C3=A4?= =?utf-8?q?rvinen?= , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, James Hilliard X-Mailer: b4 0.15.2 X-MORS-Enabled: yes X-MORS-DOMAIN: patchwork.local X-MORS-HOSTING: hosting172546 X-MORS-USER: hosting172546 X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= H616 has 256-byte transmit and receive FIFOs, but its optional DesignWare component parameter register reads as zero. Generic 16550 probing leaves the port using the 16-byte FIFO configuration and its trigger-level table. DMA attachment also depends on a FIFO size being available during probe, so these ports do not reach the existing 8250 DMA path. Use a fixed port configuration for the H616 compatible, with a 256-byte transmit load and the documented receive thresholds of 1, 64, 128 and 254 bytes. Select the quarter-full receive trigger by default. Skip optional-register probing for this fixed configuration. H616 has debug-divisor and RS485 control registers at the offsets used to detect DesignWare hardware RS485 and fractional-divisor support. Probing these offsets writes unrelated registers and can select incompatible callbacks. Keep the BUSY-safe integer divisor hook and software RS485 handling. Use the existing SKIP_SET_RATE quirk to keep the UART clock enabled during termios changes. Its clock is a gate on the shared APB2 source, rather than an independent baud-rate generator. Attach DMA from the fixed configuration before registering the port. The 8250 core installs its FIFO defaults during registration, after the probe's FIFO-size test. Configure single-byte RX and TX bursts because the peripheral request can correspond to just one character. The existing startup path requests the firmware-described channels and falls back to PIO when they are unavailable or the port is a kernel console. Signed-off-by: James Hilliard --- drivers/tty/serial/8250/8250.h | 1 + drivers/tty/serial/8250/8250_dw.c | 45 +++++++++++++++++++++++++++++++------ drivers/tty/serial/8250/8250_port.c | 8 +++++++ 3 files changed, 47 insertions(+), 7 deletions(-) diff --git a/drivers/tty/serial/8250/8250.h b/drivers/tty/serial/8250/8250.h index 21ed9c41b751..0f8c1b0b4a71 100644 --- a/drivers/tty/serial/8250/8250.h +++ b/drivers/tty/serial/8250/8250.h @@ -77,6 +77,7 @@ enum uart_port_type { /* Internal 8250 only */ UART_PORT_AIROHA = 124, UART_PORT_AIROHA_HS = 125, + UART_PORT_DW_APB_256 = 126, }; #define UART_CAP_FIFO BIT(8) /* UART has FIFO */ diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c index eca02e8bd6d1..f03051740be0 100644 --- a/drivers/tty/serial/8250/8250_dw.c +++ b/drivers/tty/serial/8250/8250_dw.c @@ -63,6 +63,9 @@ struct dw8250_platform_data { u8 usr_reg; u32 cpr_value; + /* Use a fixed configuration instead of probing optional registers. */ + unsigned int type; + unsigned int dma_maxburst; unsigned int quirks; }; @@ -630,6 +633,18 @@ static void dw8250_shutdown(struct uart_port *port) d->no_int_count = 0; } +static void dw8250_setup_port_fixed(struct uart_8250_port *up, unsigned int type) +{ + struct uart_port *p = &up->port; + + p->type = type; + p->flags |= UPF_FIXED_TYPE; + p->rs485_config = serial8250_em485_config; + p->rs485_supported = serial8250_em485_supported; + up->rs485_start_tx = serial8250_em485_start_tx; + up->rs485_stop_tx = serial8250_em485_stop_tx; +} + static int dw8250_probe(struct platform_device *pdev) { struct uart_8250_port uart = {}, *up = &uart; @@ -765,14 +780,21 @@ static int dw8250_probe(struct platform_device *pdev) dw8250_setup_dma_filter(p, data); - if (!data->skip_autocfg) - dw8250_setup_port(p); - - /* If we have a valid fifosize, try hooking up DMA */ - if (p->fifosize) { - data->data.dma.rxconf.src_maxburst = p->fifosize / 4; - data->data.dma.txconf.dst_maxburst = p->fifosize / 4; + if (data->pdata && data->pdata->type) { + dw8250_setup_port_fixed(up, data->pdata->type); + data->data.dma.rxconf.src_maxburst = data->pdata->dma_maxburst; + data->data.dma.txconf.dst_maxburst = data->pdata->dma_maxburst; up->dma = &data->data.dma; + } else { + if (!data->skip_autocfg) + dw8250_setup_port(p); + + /* If we have a valid fifosize, try hooking up DMA */ + if (p->fifosize) { + data->data.dma.rxconf.src_maxburst = p->fifosize / 4; + data->data.dma.txconf.dst_maxburst = p->fifosize / 4; + up->dma = &data->data.dma; + } } data->data.uport = serial8250_register_8250_port(up); @@ -854,6 +876,14 @@ static const struct dw8250_platform_data dw8250_dw_apb = { .usr_reg = DW_UART_USR, }; +static const struct dw8250_platform_data dw8250_h616_data = { + .usr_reg = DW_UART_USR, + .type = UART_PORT_DW_APB_256, + /* A peripheral request can correspond to just one character. */ + .dma_maxburst = 1, + .quirks = DW_UART_QUIRK_SKIP_SET_RATE, +}; + static const struct dw8250_platform_data dw8250_octeon_3860_data = { .usr_reg = OCTEON_UART_USR, .quirks = DW_UART_QUIRK_OCTEON, @@ -904,6 +934,7 @@ static const struct dw8250_platform_data dw8250_tda54 = { static const struct of_device_id dw8250_of_match[] = { { .compatible = "snps,dw-apb-uart", .data = &dw8250_dw_apb }, + { .compatible = "allwinner,sun50i-h616-uart", .data = &dw8250_h616_data }, { .compatible = "cavium,octeon-3860-uart", .data = &dw8250_octeon_3860_data }, { .compatible = "marvell,armada-38x-uart", .data = &dw8250_armada_38x_data }, { .compatible = "renesas,rzn1-uart", .data = &dw8250_renesas_rzn1_data }, diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c index db066a42f61d..e99d35880a68 100644 --- a/drivers/tty/serial/8250/8250_port.c +++ b/drivers/tty/serial/8250/8250_port.c @@ -335,6 +335,14 @@ static const struct serial8250_config uart_config[] = { .rxtrig_bytes = {1, 4}, .flags = UART_CAP_FIFO, }, + [UART_PORT_DW_APB_256] = { + .name = "DW APB UART 256", + .fifo_size = 256, + .tx_loadsz = 256, + .fcr = UART_FCR_ENABLE_FIFO | UART_FCR_R_TRIG_01, + .rxtrig_bytes = {1, 64, 128, 254}, + .flags = UART_CAP_FIFO | UART_CAP_NOTEMT, + }, }; /* Uart divisor latch read */