From patchwork Mon Aug 11 10:56:05 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Masney X-Patchwork-Id: 1259 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DACA25CC7A for ; Mon, 11 Aug 2025 10:56:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754909793; cv=none; b=MwOdRj0A2Tk6zohr4yxhaCrJLvOdIsjdhIqcI6QhntT6HbqiABrYB17pWLFcfg+tFaGQoJg/HQz6G4i48pLeZOA+9fIGucYed3CbdcAhMODdN1+BIb6MwaxoAq3J0plct/B8I9peohmGbqXdVjqRCxGuKh5RwKv+PIPjYYg0DzQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754909793; c=relaxed/simple; bh=cxbqZ4pGz5eouMzBVW3NyN413s0i735X+YyBDIP1KBA=; h=From:Date:Subject:MIME-Version:Message-Id:References:In-Reply-To: To:Cc:Content-Type; b=kDHzqYJFtvyIwMbnTjP5AYbOaZHM4qDu767nNoIrgTwr1lOfB1RZHTIgIsH4MBTRG7fC43zKB+9xZtHuwUuhcgBSEI3R/SontYue7hsMnUVLdY9FhIFc0noBkrLAlNmh3njsgYWaB80RFp/NFSx13QxKyb4TomNlEhCQB/Y2SMM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=XUvkGGxE; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XUvkGGxE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754909790; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oItVFGO2Yky7AW4ur1CICLCJs15wxQxwvYfZhdFHqm0=; b=XUvkGGxEe+h1WmIbg/eyl2fCDWGsH82NDvxo0Pd+C72IHlKf56j9dvQz/tlJs1YK+Vn5N6 77LGXvnSvCT46SKgtftFqcYRB0rx7gnbKGCHkD8qb7R/BQ6YLSHF+Z29uoDT1WucT2ESoK TCIF087SsfZw9+R3BIB3tSGGeoJUZqo= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-418-m-6h0b4_P6ClFjPSZI4riA-1; Mon, 11 Aug 2025 06:56:29 -0400 X-MC-Unique: m-6h0b4_P6ClFjPSZI4riA-1 X-Mimecast-MFC-AGG-ID: m-6h0b4_P6ClFjPSZI4riA_1754909789 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7e8072f828cso419676685a.0 for ; Mon, 11 Aug 2025 03:56:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754909789; x=1755514589; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oItVFGO2Yky7AW4ur1CICLCJs15wxQxwvYfZhdFHqm0=; b=B5RECB8uOuOfID+ImNWIOvU4EVQOAYla+buxoUb6aqDIxYlj4xQFWqa6b2YjhJKYRs aeS7gnYCYNb15DCREkZCt5YpO91otcqWT8PnjfCAFX1aq/luuObMLiH6EbtmfWDDsQgw gp93EuqaUm81ivm8K+7lurofdTAuSwlQdG6+K/y/CPTUMtuBLDz5T7s2omYou8/OntPX ByIbV2n3jsw0wmdAAPqUO/TomvCge4JyX2cmJhsEfgbyAkhqMDtpkilHck9TSZp3PS/+ xVKO1jzxXEzMnWgFehvmkCOx5Fb31ZWq9YlvnTVgQrTZv9G7FFcMd0EFlMDfk0Wgju2o 2fpA== X-Forwarded-Encrypted: i=1; AJvYcCVPrVTDWi4vRNclOdhs5bVCYYQqEtJvQgCqDS8rwJHSbR+9vJ1Hkb+TsSUajkjQLtoYxf1IBoxNQBduSA==@lists.linux.dev X-Gm-Message-State: AOJu0YwGPP02FId/w/xb3dW1R06Otqb8XrBgnM9c0c5pgqTDuqYulWED FbqFb18BorUBkBOXDHdo3WYjeA2mHrj23sf/gNGd6pzEdp1koRntQ4HzOS9KtNI99SAZHPBxDTh aEyu/ctUP+v4NTT+1vi36cEeWjho+SNscXQJbCM542KQOrz4MV+WXI+V/4DEk8Ctc X-Gm-Gg: ASbGncs8Z5aeOOBIxZ7uQp2eHMBQ8zdVS9Kb3iQZHBZYKV3MjJJXk+jK/8d6FZY81uH 8cw7AcJ5DUpTCiTpRdbqKYL2kZpHo2rgcsdLjoMLHT4TXYH3fHkk3WPdCz6FgX1yKE7orwzJr0t 7g/e+oLI80y+ClmCy8dIrKm5o7IwopT7gCWZNmFA7JWnFpZFXpYh4NmtWpsAYBRV8Mi5wAIvY/Y bRi/7pKjcNA+q2vYHIrcarDHJGl5foF9WTtJ/kLRyf1g1c/NvkVLSXc4oUkfGKzNIYGkG+3q9KQ TDEBbwl5JMYI4ro87+XopOALv272meiVXQ7ABqYQWq1TCoeAVp/AiULqYkYLKB1izq37WwzzyMH a/Hk= X-Received: by 2002:a05:620a:4482:b0:7e8:4fef:bfdf with SMTP id af79cd13be357-7e84fefc2camr275378085a.45.1754909788904; Mon, 11 Aug 2025 03:56:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGc+TLWI2xokcRtB+yecJngyy21noRPTcC3sO0sgVUYXnKnFuXDagMBjiVXOuloOtpZxIcGpQ== X-Received: by 2002:a05:620a:4482:b0:7e8:4fef:bfdf with SMTP id af79cd13be357-7e84fefc2camr275371485a.45.1754909788147; Mon, 11 Aug 2025 03:56:28 -0700 (PDT) Received: from [192.168.1.15] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e698de2df7sm1273446485a.80.2025.08.11.03.56.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Aug 2025 03:56:27 -0700 (PDT) From: Brian Masney Date: Mon, 11 Aug 2025 06:56:05 -0400 Subject: [PATCH v2 1/9] drm/imx/ipuv3/imx-tve: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250811-drm-clk-round-rate-v2-1-4a91ccf239cf@redhat.com> References: <20250811-drm-clk-round-rate-v2-0-4a91ccf239cf@redhat.com> In-Reply-To: <20250811-drm-clk-round-rate-v2-0-4a91ccf239cf@redhat.com> To: Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Linus Walleij , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Yannick Fertre , Raphael Gallais-Pou , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Stephen Boyd Cc: linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1754909781; l=1689; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=cxbqZ4pGz5eouMzBVW3NyN413s0i735X+YyBDIP1KBA=; b=6DBm6LwfY0nfMA421HhZNkFETdBD0OvYJlukZJUarU0DQPM5TzD76GN5AVvolZqrFAvmrp1nP jvbNFGe7dHWC4XgQV+dlyA/bvSpVN7ZZvyR5/1pWXfn+rHkgHaXmtum X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 4pr-lD4fE1xkpo6aQXk39UcfsZKIGegxjgSHjhbZC10_1754909789 X-Mimecast-Originator: redhat.com Status: O The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/gpu/drm/imx/ipuv3/imx-tve.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/imx/ipuv3/imx-tve.c b/drivers/gpu/drm/imx/ipuv3/imx-tve.c index c5629e155d25aef5b43445bc18c6c90039c99974..63f23b821b0be66a8e8a379e1375ffd98552e72f 100644 --- a/drivers/gpu/drm/imx/ipuv3/imx-tve.c +++ b/drivers/gpu/drm/imx/ipuv3/imx-tve.c @@ -368,17 +368,20 @@ static unsigned long clk_tve_di_recalc_rate(struct clk_hw *hw, return 0; } -static long clk_tve_di_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *prate) +static int clk_tve_di_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { unsigned long div; - div = *prate / rate; + div = req->best_parent_rate / req->rate; if (div >= 4) - return *prate / 4; + req->rate = req->best_parent_rate / 4; else if (div >= 2) - return *prate / 2; - return *prate; + req->rate = req->best_parent_rate / 2; + else + req->rate = req->best_parent_rate; + + return 0; } static int clk_tve_di_set_rate(struct clk_hw *hw, unsigned long rate, @@ -409,7 +412,7 @@ static int clk_tve_di_set_rate(struct clk_hw *hw, unsigned long rate, } static const struct clk_ops clk_tve_di_ops = { - .round_rate = clk_tve_di_round_rate, + .determine_rate = clk_tve_di_determine_rate, .set_rate = clk_tve_di_set_rate, .recalc_rate = clk_tve_di_recalc_rate, }; From patchwork Mon Aug 11 10:56:06 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Masney X-Patchwork-Id: 1258 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC49F27934A for ; Mon, 11 Aug 2025 10:56:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754909796; cv=none; b=UOdMnpMlXGbNzVcaXE223FF1QbSylAjyEF9G++lZP9H3oi6SHYykHAI7OaCcWgCzpSkYGuq/B1Ar9FvzEKrhlvLObspFSCMGCM7VofkCCIKy0gej3XYVUdZ5W+IG4GiT66Nb+WpjrC8qf7PXogBsR9o+tf/ZW7z7Kkb7A86KPJQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754909796; c=relaxed/simple; bh=9BXAN9WaQXGACsWVgeakYqAdywyzgmh/IMziqVvQDEg=; h=From:Date:Subject:MIME-Version:Message-Id:References:In-Reply-To: To:Cc:Content-Type; b=ERnzT47JQk2Lmz4Azr1PH1OXgcKesgLKmEBFSLbN/b4RC+DdHo8g7ioHiMi/IYv3T2mgAsmfZQCI8H0xaRh8bD8/una4UpuQMXoMvi2sMMKjEQZKtsj3pJhvP6eVqWCcluj+p6IwijKkA062ZqzSQ28Ehi+VfNnFBIhXWfiRkDA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Vlbpd4d1; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Vlbpd4d1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754909794; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tWkAq+ld75LwDG/hGRVHHPxuHrsiy/sV3D7XIB1FZRs=; b=Vlbpd4d1GWLigeSUtZRUv6DKjNBdXibb4g9JbYbVitRrPiFoji9hYKRStDLadmK5tBebGE O8pfANZy2JB4mvj9zgRNWtcrWGCIF4PAp5CDs9jbUW2m0xzVyPlEO/n0D/CWyW+5FVEsWZ +c3yXwS/mQYrfBi/vxjzhSLMtzshwp4= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-104-dFcUrqnYNS6_qKf23mf4xA-1; Mon, 11 Aug 2025 06:56:33 -0400 X-MC-Unique: dFcUrqnYNS6_qKf23mf4xA-1 X-Mimecast-MFC-AGG-ID: dFcUrqnYNS6_qKf23mf4xA_1754909792 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7e69a0a8bcbso983558685a.0 for ; Mon, 11 Aug 2025 03:56:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754909792; x=1755514592; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tWkAq+ld75LwDG/hGRVHHPxuHrsiy/sV3D7XIB1FZRs=; b=itZW1MWxcTl45PUwSVcFnak2665nKLjLtwxV2CAxPnw4A9hd+y6icXaCykQnzvSh1j cyR82jtxf4+2UNJilNt4GmqktKTzzqEsqaE1bDbFDxxrrcurQVLjhGCC7L+jbY03COqN VEbRk72L/fqDPHdGblmVf3ZI3puGsifw/0uNwm4NT2AQbJdbgDK2ctksu56VQrzshngd xr0T9TIFp03W+9RXlgEnSaLRu/Ujl65UKaeRj75qEaLxZf9AaPAvM+A7BlYgHrTKgqWI SuhjN+A3uStZPE0qkHG45UEKjDgwBQOA7IFadFLGtmyBtcmyQk4f3yztHRSnt3dGLXxt gMcA== X-Forwarded-Encrypted: i=1; AJvYcCV+R1AmSXTC9NC1LBrsVhLTc4j5c03KXLLIEXzu9lxkmsAS+Zzp6Fj/9si8j2w7KmtdkCmdheRmhZ74xQ==@lists.linux.dev X-Gm-Message-State: AOJu0YzLCFS3Ag4Ehv9pNwsokhjD9jgM5fgnlctnKsesGBL/pw9u5F1F 6xTcAKaniEpTlw82DonTvX0kMe3fwfwJpf5ra4LnvrF/jWNKPaclWdQS61Ai5DH79+CEk/PoZRF sej8Anmf/6j79X2AnjK7984JLTeNa5bPlnu0q1+5MPv2aCrVmYYlbf57n8Zt8k2lL X-Gm-Gg: ASbGnctB5ctUp2e/MGfiJ3b/3FXlMtiyj/V69lY5Ol0xby32aUduINPv1l7gg01Oom/ P9Z9wbLSleuqiTzaWfJUQIJFbrUqF943eVITwQnhQAnzLKMnfR4FbYy/OK0nUPmTX6nkFQncZAS fyiZRuc98jIa3Px3eHOWXOhmbvz4JuYrHxDqYdQg/CXCXoNa0AWbhdwyJXVp93IN9/YlTbeyuBe 7UWP9rwPa5lIo6y7JUSTmT1wyAsi1mlIL6U3HJugI78JpbiRd8eheFlM9c88yBorcA1QOJfMEW4 BrLhrOk7yohnBEELUONthj0rJ/gofpOdYtDj5Kgkk86QWZDpeJ3XtczMk8Xkb+ZRDlyq0CSrkGX w5/I= X-Received: by 2002:a05:620a:45a3:b0:7e6:9a4f:a299 with SMTP id af79cd13be357-7e82c646f33mr1843254885a.16.1754909792428; Mon, 11 Aug 2025 03:56:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHgW8gZJYQbVSn9A8dMelBcES9raZpoqJep5i7D+EdYN7YXUJOpmuR1qZ1AM51jM57roxoq8Q== X-Received: by 2002:a05:620a:45a3:b0:7e6:9a4f:a299 with SMTP id af79cd13be357-7e82c646f33mr1843249285a.16.1754909791988; Mon, 11 Aug 2025 03:56:31 -0700 (PDT) Received: from [192.168.1.15] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e698de2df7sm1273446485a.80.2025.08.11.03.56.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Aug 2025 03:56:31 -0700 (PDT) From: Brian Masney Date: Mon, 11 Aug 2025 06:56:06 -0400 Subject: [PATCH v2 2/9] drm/mcde/mcde_clk_div: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250811-drm-clk-round-rate-v2-2-4a91ccf239cf@redhat.com> References: <20250811-drm-clk-round-rate-v2-0-4a91ccf239cf@redhat.com> In-Reply-To: <20250811-drm-clk-round-rate-v2-0-4a91ccf239cf@redhat.com> To: Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Linus Walleij , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Yannick Fertre , Raphael Gallais-Pou , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Stephen Boyd Cc: linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1754909781; l=1730; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=9BXAN9WaQXGACsWVgeakYqAdywyzgmh/IMziqVvQDEg=; b=ylupjg1fmCNBXXxO3X3BdCWItZxz3hbcUzYzU1GUNiNNWUiYrAb17RJCYD00k/EMPQMfWhWKC RXc0CDE9VnwCgzocNA8sHN+o4QXxCM6UpLGynPKDC6JbO0dbhiFFntj X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Geus6hpJoG8oDOPDUfC44NuJSSxE6suTDEIAHcdBIdk_1754909792 X-Mimecast-Originator: redhat.com Status: O The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Reviewed-by: Linus Walleij Signed-off-by: Brian Masney --- drivers/gpu/drm/mcde/mcde_clk_div.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/mcde/mcde_clk_div.c b/drivers/gpu/drm/mcde/mcde_clk_div.c index 3056ac566473487817b40f8b9b3146dbba2ae81c..8c5af2677357fcd6587279d58077d38ff836f0c0 100644 --- a/drivers/gpu/drm/mcde/mcde_clk_div.c +++ b/drivers/gpu/drm/mcde/mcde_clk_div.c @@ -71,12 +71,15 @@ static int mcde_clk_div_choose_div(struct clk_hw *hw, unsigned long rate, return best_div; } -static long mcde_clk_div_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *prate) +static int mcde_clk_div_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { - int div = mcde_clk_div_choose_div(hw, rate, prate, true); + int div = mcde_clk_div_choose_div(hw, req->rate, + &req->best_parent_rate, true); - return DIV_ROUND_UP_ULL(*prate, div); + req->rate = DIV_ROUND_UP_ULL(req->best_parent_rate, div); + + return 0; } static unsigned long mcde_clk_div_recalc_rate(struct clk_hw *hw, @@ -132,7 +135,7 @@ static int mcde_clk_div_set_rate(struct clk_hw *hw, unsigned long rate, static const struct clk_ops mcde_clk_div_ops = { .enable = mcde_clk_div_enable, .recalc_rate = mcde_clk_div_recalc_rate, - .round_rate = mcde_clk_div_round_rate, + .determine_rate = mcde_clk_div_determine_rate, .set_rate = mcde_clk_div_set_rate, }; From patchwork Mon Aug 11 10:56:07 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Masney X-Patchwork-Id: 1257 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A48627C864 for ; Mon, 11 Aug 2025 10:56:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754909799; cv=none; b=n3a9GXHV/t5xZESgZ8Zt8LnNcsRB0WnurMJRlqCHiQ2EKrsALR3x5zH/dfWN72tJpkMKvPXAxfBwrfZy/RcwvWe3eOvacodIrVU66WTzeRB1QuHctmLL7hi7Y4AhLq05/B8LqDLY/wwsq2Sm+4/j9EbVN/0Sx8YJ7TtYOC+CtiQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754909799; c=relaxed/simple; bh=QhsR7m95oQQJWiR4k5sEM+znPy8RVqMfVFdEDgPgP5I=; h=From:Date:Subject:MIME-Version:Message-Id:References:In-Reply-To: To:Cc:Content-Type; b=W3SyJ/tRiQdcOvrM/1jp2nitA2BVmM3d19yEk3mjaUgteJ3Q0tZzGYz57htC4xGketAmo54rpjxV0dXSrAPo6LCRZh+jtcRFS5f+geLYKhTRhT8MOdy4bUCbnwJ6QpacLh80nuAChrEn3C1BR1/GFwJLl6Tx2td1FQe7hW8z2XA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=UbuQMlYm; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UbuQMlYm" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754909797; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SmZ5OhIFbDNhhdemRjccJWJIhJ+GPeWDy3CnIwZY5Y0=; b=UbuQMlYmTwYPV2/asD2FSXjSz1l0hyZlxDj2qQ+MZN9i9uXIzuH4cwD8p1WTaZXQrD1cbW p6l5aa/d4m/oPGXE7eiMB3K/o6jlzQrVNLBTOFQ/PHg8zHzRDloN0Qc8GvVAFEfPNY16Jq kKu4/c4JlIqdnfTzIuLnYz2yLMghqkY= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-473-CGoCXpXRPbOtwBpVS27F_g-1; Mon, 11 Aug 2025 06:56:36 -0400 X-MC-Unique: CGoCXpXRPbOtwBpVS27F_g-1 X-Mimecast-MFC-AGG-ID: CGoCXpXRPbOtwBpVS27F_g_1754909796 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7e69e201c51so996665885a.1 for ; Mon, 11 Aug 2025 03:56:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754909796; x=1755514596; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SmZ5OhIFbDNhhdemRjccJWJIhJ+GPeWDy3CnIwZY5Y0=; b=HwcoaNvLdY3Rfp62D0iexq9z8SmbtkH3pcr7/X62yiy2ezEHBtB81WA1uxLugxU1EU pLMVnhcJkkam+9ZSreIw/aMNRWjVJ/EcSbIXKS7xQO0PVOSu3YNLRXc+FciVzTDK/U0w sf6A+gJwci4nhmgl94b/caVh+OMan0UhJLOWVRxGtaUXp5ijkolWJJcR0cApbQ+xQuFw DSf9pPMFM/0/5MEHikc7cMBu9jXgnfK1qt060CcuA7PFOEHiDVgpv5R4adD12LBzRSf+ IQ2xEDDVX3+h9c/t4XYeoXgFa1Wckfs1dyco1bDt0GIGglb0UXO+gyq2K8z/2RS2cuae dADg== X-Forwarded-Encrypted: i=1; AJvYcCWGBM0QbRV3rG6G7uoUCvVdsW1MtCeKSZBz6RSEVeEdFDmjCRqYok4vPGCoHte1sx32kP+j4aeiOi7jww==@lists.linux.dev X-Gm-Message-State: AOJu0Yx9PpR/p1XI0wk62Kh+benooPtc51dQBh9RG9UA2q6vLEVbTNpZ c+kKrwgjavMW6K+vAePGTwrydC6D/nQSWsgHsiiVlFRlUcBaKQJZ60Hoa7kYJegPbKtg4CXfp9x 4trilNnK7GKqyE6Z37Pkbep5RQuGQSmtCU8rw7ucNd6kDHcqMuyPhqyP84kfkZ3As X-Gm-Gg: ASbGncvWyPccneJSyfrScLXwPiXlHC+6m5AyjVLVA5umZKw5oZs+8n7DbDIxzL9lVwu 8WabxLmc2ChPtVAw24GXfxZuuW02QOg87P3gMD+ZRrB4mZ7nqRxCof+lBqZwXuutg2UHiTldXbs e81rlUPMiCINx/XQQoGE9mFxwyOZzkfmFOH6lxb+3JdVW0BhhOkruFJ0REcwEraAEEFBzrW40DF lIZ+QPTyzTxfmnPAFnnwAi/P3gOh+Z7IQgjzjPoJcRHbdybjwT7N7e4L5V0yXdvTguG7RAixtI+ ZZ28YUPySGjsfFLhedVKMgLhEUrkkD9kBKdc8f2YhFjM8rIiki3zwDo2DvWX2bsATTS3gjjibwW n9fE= X-Received: by 2002:a05:620a:2ae2:b0:7e8:23c1:f472 with SMTP id af79cd13be357-7e82c64cc0dmr1348333085a.3.1754909795928; Mon, 11 Aug 2025 03:56:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH9n70Dnsh0oekI6lYBsj+g6fiHD2aJUNrf5ZRMtmoVkJvAZxcIb6V9PGnNEHDigLw+MQojEQ== X-Received: by 2002:a05:620a:2ae2:b0:7e8:23c1:f472 with SMTP id af79cd13be357-7e82c64cc0dmr1348326285a.3.1754909795068; Mon, 11 Aug 2025 03:56:35 -0700 (PDT) Received: from [192.168.1.15] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e698de2df7sm1273446485a.80.2025.08.11.03.56.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Aug 2025 03:56:34 -0700 (PDT) From: Brian Masney Date: Mon, 11 Aug 2025 06:56:07 -0400 Subject: [PATCH v2 3/9] drm/msm/disp/mdp4/mdp4_lvds_pll: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250811-drm-clk-round-rate-v2-3-4a91ccf239cf@redhat.com> References: <20250811-drm-clk-round-rate-v2-0-4a91ccf239cf@redhat.com> In-Reply-To: <20250811-drm-clk-round-rate-v2-0-4a91ccf239cf@redhat.com> To: Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Linus Walleij , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Yannick Fertre , Raphael Gallais-Pou , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Stephen Boyd Cc: linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, Brian Masney , Dmitry Baryshkov , Konrad Dybcio X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1754909781; l=1737; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=QhsR7m95oQQJWiR4k5sEM+znPy8RVqMfVFdEDgPgP5I=; b=Yf+/AEJVSVpYyfmQu4W8WyuhOAot3PpTJ66fonHG6NgwPWqhvr62JRFBH9lf6jrYZTbKGBwD4 RLchj5Jj8AWD0/ZZRq0fRTK+W2ARhNi43oK0yq2QvGqqPc6Fg70Vyhk X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Yowz1Vy3mrFl5ve7bJ69_UpuDSrhHR_qryyC8sxHFDg_1754909796 X-Mimecast-Originator: redhat.com Status: O The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Acked-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio Signed-off-by: Brian Masney --- drivers/gpu/drm/msm/disp/mdp4/mdp4_lvds_pll.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_lvds_pll.c b/drivers/gpu/drm/msm/disp/mdp4/mdp4_lvds_pll.c index fa2c294705105f5facbf7087a9d646f710c4a7fe..82e6225c8d491d44e30631cd5a442fb7c2de3f75 100644 --- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_lvds_pll.c +++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_lvds_pll.c @@ -98,11 +98,14 @@ static unsigned long mpd4_lvds_pll_recalc_rate(struct clk_hw *hw, return lvds_pll->pixclk; } -static long mpd4_lvds_pll_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *parent_rate) +static int mpd4_lvds_pll_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { - const struct pll_rate *pll_rate = find_rate(rate); - return pll_rate->rate; + const struct pll_rate *pll_rate = find_rate(req->rate); + + req->rate = pll_rate->rate; + + return 0; } static int mpd4_lvds_pll_set_rate(struct clk_hw *hw, unsigned long rate, @@ -118,7 +121,7 @@ static const struct clk_ops mpd4_lvds_pll_ops = { .enable = mpd4_lvds_pll_enable, .disable = mpd4_lvds_pll_disable, .recalc_rate = mpd4_lvds_pll_recalc_rate, - .round_rate = mpd4_lvds_pll_round_rate, + .determine_rate = mpd4_lvds_pll_determine_rate, .set_rate = mpd4_lvds_pll_set_rate, }; From patchwork Mon Aug 11 10:56:08 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Masney X-Patchwork-Id: 1256 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63439288C22 for ; Mon, 11 Aug 2025 10:56:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754909803; cv=none; b=UwIGKMkCQizWfYpB9fg0nM+ftqVDlNhv+uV1QL0Q7YgIC3as+u1F7Z/K32jGAFPanhN730NBLu7yHUOvWQTxP51jEw8WTRWDEjUz96zylzj1dhafq7yPlzMu0KgC2j4yGmGhqD6BFpVRaZKNfFWHArFCo9O44+UzbiVCsaVpb30= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754909803; c=relaxed/simple; bh=W4oHtDUPRGuCLmVSKKz7teYp4yrHno03QAMcLtqmgJ4=; h=From:Date:Subject:MIME-Version:Message-Id:References:In-Reply-To: To:Cc:Content-Type; b=Sf7ANakA4FYhef/NbStMg6ElVhiBJUgA7h1/INF5rrZU0c5ZpkHpd6SEbmXgwDtgxumKwyOFwxzJw0s3A02kd28eKC8bavnbeAE0OQxYDUnJcTQkub4tMVt8XOQcRYopguFJFNrDkozH4XIvQ7djE3bV+NNsgd+RLV17VIrxRtE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=RE9dbemV; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RE9dbemV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754909800; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2v4P79PdNIaS18Wb0ZUemgbjQrcADYOCCdsS00/Mio0=; b=RE9dbemVTecLIMxvYbG/9k6zYHAa5I3iPvs36YZpyr4pppl8fBfgX5GV1yJ2JDka9GBPS2 kGWXnxvSuVLyYCySsoGCP0OHz6EfafRiyuOxsRpyRpi42/23DjElav6djwyeleVzxD7zq8 5vnHFi8OV4AEBbwmt5Q7i44gPE2md8M= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-263-IYko4pslNtCHZN2rQ2oNiA-1; Mon, 11 Aug 2025 06:56:39 -0400 X-MC-Unique: IYko4pslNtCHZN2rQ2oNiA-1 X-Mimecast-MFC-AGG-ID: IYko4pslNtCHZN2rQ2oNiA_1754909799 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4b06a73b580so62531351cf.1 for ; Mon, 11 Aug 2025 03:56:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754909799; x=1755514599; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2v4P79PdNIaS18Wb0ZUemgbjQrcADYOCCdsS00/Mio0=; b=Sulb1wOw+ZrXnPe9d+WcXua3PLtCNN4q2ZEbccZRRMnZNlcSr1S/V8JDlrp1BZmqdv BLv1i8+gLKCNXD9Xe/+OTOsskh/k7XxBAEuJNWnAh9EuWV5+//rhzgE4LCGPC2sIFj4r p8SN7eOdyyq/W0zoPFLiYvdch5Don0QsOxAQn21Jy9DQr37tfsfrE5lBgtg5kPN/MY7K TYJFRqaydl0zAe19yqKPxcXu7JEosdVCgZg0b4ZpzlMoNMomHsE+8K95mJaRvb5mBr2A Soh8/dkSkm2XlBt8fmRITjEW/xMTBK7sbA6upgXqQ7NjkqNSZIAkb7JZ9MM1HpNN/UFk er9g== X-Forwarded-Encrypted: i=1; AJvYcCWKTlXbfOWld92SeHqZocjQyX/MnQ6Q3tX1DU3qrlsBJiex7Zvo9wgGMIyl/isVCymMVsl2Gy3+7xMk9g==@lists.linux.dev X-Gm-Message-State: AOJu0YylnC5kLeu/gT6ML2E2anuKkDzZCpV9CTRv7VO3ANVr61xo5pwD cyx2p26lGzv2gnpBEje9Ow2NqVdJr36tfUx+Oec2K1UmDl4+2j2V4zZsm/DbpSlFw8hHzt+n3H0 w+ho45G8zfBotqj1asfL5uIsZtCrw3bsGBsYggUO3GYNL+I37ZCBJHQcgl8/KL0tR X-Gm-Gg: ASbGncs9zVcKLA6eCFH7wtcNjsNW98ee+yoCue6GRRoQghTiVFuwZs6Ok9HE+p+FZb4 Uh/cd91z6cL2+F+W4N9uuNrZ92Jh9/fi2eJ/aeBpJrIJkHRZSJHsQRR7p5Izz7oGid1RI9zRSfB Y6lcKQ8KB0jaVjTtZ4ZB9p8b/CkyVxC3fORmIZcVONfIL1c/FzH6JEvCta5AM2Hkw1HkFOySarG inesphHBA6ivNkPwVI6K5MZRYYKWw66/Imr3C9EQWz9DEqezBuW2fcLBxwyVQ1hA7GBDf1GQM7I I+1v299AZLY1Qkkn1wkWHfhK6wy/EFPDFYQ7kURwHVX4dn/89YR2Yyo/czF/cln84dG1dNcJpze uEyE= X-Received: by 2002:a05:622a:1aa0:b0:4ab:640d:414e with SMTP id d75a77b69052e-4b0a06eedfdmr247966561cf.3.1754909798770; Mon, 11 Aug 2025 03:56:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IETXQEWlFC7Wcyu/io2faEikISODgBHD0p2mDq0e7vALuwZuamzM4hp/NBzXMpTjJQ+LZFp/g== X-Received: by 2002:a05:622a:1aa0:b0:4ab:640d:414e with SMTP id d75a77b69052e-4b0a06eedfdmr247966191cf.3.1754909798373; Mon, 11 Aug 2025 03:56:38 -0700 (PDT) Received: from [192.168.1.15] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e698de2df7sm1273446485a.80.2025.08.11.03.56.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Aug 2025 03:56:37 -0700 (PDT) From: Brian Masney Date: Mon, 11 Aug 2025 06:56:08 -0400 Subject: [PATCH v2 4/9] drm/msm/hdmi_pll_8960: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250811-drm-clk-round-rate-v2-4-4a91ccf239cf@redhat.com> References: <20250811-drm-clk-round-rate-v2-0-4a91ccf239cf@redhat.com> In-Reply-To: <20250811-drm-clk-round-rate-v2-0-4a91ccf239cf@redhat.com> To: Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Linus Walleij , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Yannick Fertre , Raphael Gallais-Pou , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Stephen Boyd Cc: linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, Brian Masney , Dmitry Baryshkov , Konrad Dybcio X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1754909781; l=1657; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=W4oHtDUPRGuCLmVSKKz7teYp4yrHno03QAMcLtqmgJ4=; b=zHi78rLvdAYaZdTIMhwgqH/js0hiXWDnYr4X0BvUbuN6hprJjEDc2ZwgX+szZViPz4W8X1kk2 ngDBdMEkWVsAVo6sQ7hWvsQkjGQtaqeiQEeV2wywPAakq8QLF6bboSJ X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: a67MC2g3vZmStoRBfP5qHPOjXsVmdKZTNu7UB95oRlM_1754909799 X-Mimecast-Originator: redhat.com Status: O The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Acked-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio Signed-off-by: Brian Masney --- drivers/gpu/drm/msm/hdmi/hdmi_pll_8960.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_pll_8960.c b/drivers/gpu/drm/msm/hdmi/hdmi_pll_8960.c index 83c8781fcc3f6e1db99cfec64055ee5f359e49e5..6ba6bbdb7e05304f0a4be269384b7b9a5d6c668a 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi_pll_8960.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi_pll_8960.c @@ -373,12 +373,14 @@ static unsigned long hdmi_pll_recalc_rate(struct clk_hw *hw, return pll->pixclk; } -static long hdmi_pll_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *parent_rate) +static int hdmi_pll_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { - const struct pll_rate *pll_rate = find_rate(rate); + const struct pll_rate *pll_rate = find_rate(req->rate); + + req->rate = pll_rate->rate; - return pll_rate->rate; + return 0; } static int hdmi_pll_set_rate(struct clk_hw *hw, unsigned long rate, @@ -402,7 +404,7 @@ static const struct clk_ops hdmi_pll_ops = { .enable = hdmi_pll_enable, .disable = hdmi_pll_disable, .recalc_rate = hdmi_pll_recalc_rate, - .round_rate = hdmi_pll_round_rate, + .determine_rate = hdmi_pll_determine_rate, .set_rate = hdmi_pll_set_rate, }; From patchwork Mon Aug 11 10:56:09 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Masney X-Patchwork-Id: 1255 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9025E28A1ED for ; Mon, 11 Aug 2025 10:56:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754909808; cv=none; b=Xfjis4+DeqL26FVYAiuBQrCppWr01apuLEH8V5aZo4Fva9XEkR5WXsf685nhAAQkiroBvSWrc18CiA1V2t67KRwszU6nhXkII6UwNcHoQ4BP5+tnjh1CUoQ5le38R2yRDo57CIQuwCfNRWlmaKJwx9GDa88L3SAOoprFfyb+dDk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754909808; c=relaxed/simple; bh=zjPZ3dnO6gZ6FQi2ZfbbqSAvbJwyf4CBg6JGhX8DcxM=; h=From:Date:Subject:MIME-Version:Message-Id:References:In-Reply-To: To:Cc:Content-Type; b=R/GVi0bntVGwwdj3akPyAxi3RJ2WNcO/XGy6salF6G1uioNPOuS7mw5bjKDGdxkpFzexQiHrLxwHZYxlk40oGVMt+5s0+aM8V1jCkYKwHUNBffTGXs22pxgB73rMMtb8SB+6TmJnr0EOkEGprIwrG7UgK9ASCq9wISBHrm36tdM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=cs3w6PCZ; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cs3w6PCZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754909805; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wT9Dbxfb4kVAT42wH+rZD3vwBa5NQ+w/1wzXJJwlqX0=; b=cs3w6PCZ19/9CqK+yc/iS2DaNJWzdf/xSvNUl74zHSeSKA4Z07tepTYQi6czbJ/8hBX611 A78sgW3eccQ6XO7CrHzWesaQK4638Sr4/72uTtNWyGvDBEU3VQ6nQwT+YMfkWD+Iu6l9ZU TpxAOu3JyYDnsagHHTq9y4x1yv2sWXU= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-10-mPqx2y-3PrCbpdJxY5ti9A-1; Mon, 11 Aug 2025 06:56:42 -0400 X-MC-Unique: mPqx2y-3PrCbpdJxY5ti9A-1 X-Mimecast-MFC-AGG-ID: mPqx2y-3PrCbpdJxY5ti9A_1754909802 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7e82b4ed799so705390285a.0 for ; Mon, 11 Aug 2025 03:56:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754909802; x=1755514602; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wT9Dbxfb4kVAT42wH+rZD3vwBa5NQ+w/1wzXJJwlqX0=; b=lUnweNc5VAsqm0ln+bSzNDwYf8d3GqlKllGPv7tQlD8jchhQnujaB/p+IQuMopTipe VgU3KdHdQ9zu1BcNdiOmhgEGILEelJ9vk5QxQKQX44gTLYIiOq/hXFpGH41hMdbioNT4 TRKrtFidtI7LD4MGPU+Bp6jiXLZGz5d80K921x3S6AiIjba3Gf+2HFjFlLc4QR9epd2q NGiryGrkBUhpl40FX55mkleOsnKOH7KCo7oQyeuaYwC4o7atqFHqMQ/Ims+aKkveMzdQ a6U7x5STouos1VgUR8hf85kqpmnLcFGyfEF5W1xpTdSdBBwxYUj8VKe3tf9rRlMEOx6T /AuQ== X-Forwarded-Encrypted: i=1; AJvYcCVTDb+5Twlfx0A20fad2UlwCGjWcNo9jUMnmxw+R3P/ij4E16Ra103+8DFIKyxgObHSKHcgXbEhUbOznA==@lists.linux.dev X-Gm-Message-State: AOJu0YzuAX1FkyBZqmcFj7U6DTeqc8G8MZJpg0IJyU5FOgZMfID53Zjp wjqIQYu8nFVBtCc2a9hVCYE+oX1qOJvfnUFbVtEzeH+sIWoHg0kUsFbJTzi5g69T0zB/Dlc5xuc ZLrYtQlnlNdIqLwmKUwTVA88LZ64DmSVRrGC4zNJ8POOoIr1ablvEoy9Va3METJlv X-Gm-Gg: ASbGncv0FIjFWOrok0+Xcd5JiLcuATt1oaF7HKDM9Y0DTVEFr5lGIr5hyhBgJ7Yici/ jMDI8uLpRbO8hAdzAWpSvCW6YQe7SGm8Ew+AF0t1zs0hgAxLMX7BSGDbKDfaNT69nlO5BdhrDRp TBlV0rKlZDwlcw/hffgSddxPpKzD8mry2VmbSf1UeYkFq76zvE6VAbv6klnX3S75MSz6lUB7Rjf pV6ay4UByZRsSDVFNGL4DlQzyuR/07BqyT1cgl04ppZZnjb59L0Dzn2An9YYGcFSR2d07+qR2ys HMJVYGRpmFY0sJPRAWu3luYb7kNvzARkiPW2PR2Nchz36WGJT4vn9Qy46xeoduq4/7f+qRiUYqx y+Ao= X-Received: by 2002:a05:620a:45aa:b0:7e8:2151:9bbd with SMTP id af79cd13be357-7e82c6834edmr1680334085a.25.1754909801988; Mon, 11 Aug 2025 03:56:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHn4J1YPALYk3sfXKt4CIgszP9xA12/nZjPecmiJUzpdOL3Mq3At3CKB2rvFttPLfHNTO7lJg== X-Received: by 2002:a05:620a:45aa:b0:7e8:2151:9bbd with SMTP id af79cd13be357-7e82c6834edmr1680329285a.25.1754909801517; Mon, 11 Aug 2025 03:56:41 -0700 (PDT) Received: from [192.168.1.15] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e698de2df7sm1273446485a.80.2025.08.11.03.56.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Aug 2025 03:56:40 -0700 (PDT) From: Brian Masney Date: Mon, 11 Aug 2025 06:56:09 -0400 Subject: [PATCH v2 5/9] drm/pl111: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250811-drm-clk-round-rate-v2-5-4a91ccf239cf@redhat.com> References: <20250811-drm-clk-round-rate-v2-0-4a91ccf239cf@redhat.com> In-Reply-To: <20250811-drm-clk-round-rate-v2-0-4a91ccf239cf@redhat.com> To: Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Linus Walleij , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Yannick Fertre , Raphael Gallais-Pou , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Stephen Boyd Cc: linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1754909781; l=1718; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=zjPZ3dnO6gZ6FQi2ZfbbqSAvbJwyf4CBg6JGhX8DcxM=; b=NJqHQ2ssaD4y0rqVbCbujpIrqzdN3VuMWj9ghDV3lWlNDbiI/oggFqGjuVCZHps19PnD896Q0 9FdZ8qhj9mUBZ/GerZTn1O4AjtYG03lLvn79VW/TKhLY3AumrqAiB+P X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: P7VZEl7IwY-7SFd4BqvlpzLxWtLyWcvl0a4Oszrtcm8_1754909802 X-Mimecast-Originator: redhat.com Status: O The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Reviewed-by: Linus Walleij Signed-off-by: Brian Masney --- drivers/gpu/drm/pl111/pl111_display.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/pl111/pl111_display.c b/drivers/gpu/drm/pl111/pl111_display.c index b9fe926a49e8bb42116ac382010829e333edbf8f..6d567e5c7c6fd559ba369a2761d3c402a14c6fe4 100644 --- a/drivers/gpu/drm/pl111/pl111_display.c +++ b/drivers/gpu/drm/pl111/pl111_display.c @@ -473,12 +473,15 @@ static int pl111_clk_div_choose_div(struct clk_hw *hw, unsigned long rate, return best_div; } -static long pl111_clk_div_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *prate) +static int pl111_clk_div_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { - int div = pl111_clk_div_choose_div(hw, rate, prate, true); + int div = pl111_clk_div_choose_div(hw, req->rate, + &req->best_parent_rate, true); - return DIV_ROUND_UP_ULL(*prate, div); + req->rate = DIV_ROUND_UP_ULL(req->best_parent_rate, div); + + return 0; } static unsigned long pl111_clk_div_recalc_rate(struct clk_hw *hw, @@ -528,7 +531,7 @@ static int pl111_clk_div_set_rate(struct clk_hw *hw, unsigned long rate, static const struct clk_ops pl111_clk_div_ops = { .recalc_rate = pl111_clk_div_recalc_rate, - .round_rate = pl111_clk_div_round_rate, + .determine_rate = pl111_clk_div_determine_rate, .set_rate = pl111_clk_div_set_rate, }; From patchwork Mon Aug 11 10:56:10 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Masney X-Patchwork-Id: 1254 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E665A28C024 for ; Mon, 11 Aug 2025 10:56:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754909811; cv=none; b=d5vFD8027ZF+L16hFcWAaKkL/isn0rWhDBcH8kK3TM+3nS9JT+DguRS0k0lPmvENrXtupeMxZS0L4UmPnSUwD4BP5nfpWwPQfUxJ0u3ePezseNp3wGIJwp9qWYQz0HCXvXFs1CkAmUOe08F7rTwUVFYWLdWfmqsinL9QkAzoemY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754909811; c=relaxed/simple; bh=TQX7y0WLJPoT2FXW3ljOONLbYB3hMMDCH4wBpr8HvE4=; h=From:Date:Subject:MIME-Version:Message-Id:References:In-Reply-To: To:Cc:Content-Type; b=Kl/vADmFwfLmnEXESDiH9A68fXDpQZCIcnEB3xegwJJawNqSX2ywDmMS/gj2jp9X8C1jBzlMNEmCfUkwvk2Q653Ef9hL/nwOEsjSjgerYvbu32Frx92/AWn89tySoEko6XRFTKnxol2amdai5vfdfzdL0uChrS70ajM3aex6oOM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=JxyH2NLM; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JxyH2NLM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754909808; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fe1/zFdrNglpQdcc7DcZ0ub2lnvduP/lEo2aekbxLh4=; b=JxyH2NLM6rCFUYRYUd0H/na4W/KeEI81Z9a/ypUPJ4oM9nR8OOx5FanmE8tsbDgy6K8rPD b/ExwlOjIo5xFGVvIOv6O8DJ7J2wScHaIPio42FF0sySFdqJn8z+pxcs0rd/wJ8RFkpI3e QRI+XyXJvHWUaKjGACfgnqSi2hwbV2s= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-214-HjKUHbPePFqwXE8MIf6KFQ-1; Mon, 11 Aug 2025 06:56:45 -0400 X-MC-Unique: HjKUHbPePFqwXE8MIf6KFQ-1 X-Mimecast-MFC-AGG-ID: HjKUHbPePFqwXE8MIf6KFQ_1754909805 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4b0de38c71fso7806571cf.3 for ; Mon, 11 Aug 2025 03:56:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754909805; x=1755514605; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fe1/zFdrNglpQdcc7DcZ0ub2lnvduP/lEo2aekbxLh4=; b=nEL8AL9r7yA4j2mgVuoF1KMOiIKVy9GTzzCrDWQ+e4M3xHf0hRc6mZWvK7S8ARGhSQ 0aj3tIS3r5abwceLLMCc+0vW131Se5aH1HHD9GcDwKVZXNLyxKXh6C8cobXrPtJl1yr1 /gCU5NU4r7H2LvOcXy2cDBrKXvSw6JIEEoz5pmVPLZHFZIftQVYynd29fE8YfcXmak5V EbCM4Q13srBpY/Z+/vfc3cI02net5ExYbz9YEw9/2AzulpbXSdExBweBWrWaIYiu3Ubo AjpDXJzXkQKZN6lHdPka/gkPFknnY3xMBWQXyKhAZO3CW1b+pySliNrUOVjtoMXleXcb iBEA== X-Forwarded-Encrypted: i=1; AJvYcCUg9FUTRpk4iOI9k18sqFv4o2XYWnisR0/O4VRDAjHAb0QG4sivM09UX7pLjQOlMwxOAbwPiYXSrIHPQQ==@lists.linux.dev X-Gm-Message-State: AOJu0YwvgUxgoYa6aNE1Zxr5f5ole2MGaRBKk0CdyjAzkR+v/3g81A25 mxrx5Z9oL2snwVk0EhFmBHU9W7OAMm+3pL9twuk0I//+9EPnLkpnf5S/qqr2wgeUhZR7m5FlIQ6 AjuqYwrqgdWkpA1IhDgYgAB6PudpDM662pqclE7vlBZ3MPtzrM6oilPYTGXk/botM X-Gm-Gg: ASbGnctCvOCVAlOs8d+v7eySaqfRn5Ih5ra4uDxQV4CarfrZCFkzzflhTY0gerhHJMB MtzBeDF8t/73pc0AE8HolEJgz3boTuFhWQ27ycVGOkxQvncO/1OyIYXfcA1123Q6kJalvsDu2+c QDfAPnYgbgJimeDZbyE9gi55T2HNyu4F7clJlQUHmUjcjR+zzbrq+X9vhltKa/I4bkR4B2iVdDV FaeAPjfghC9kRVvFn1scWajJ60DF82ao6zOi8Jl26w96NOdXQmUPmtj8dqSUiFLYMUHBnmLopQx F4c2uIuZfq7LH82TX4z5Dt62RtteTBEdp1R9pdD9Yom7SHgk5As+GAHtUyS64oPuQ6amTatoLCY MNYA= X-Received: by 2002:a05:622a:164b:b0:4ab:81c7:b992 with SMTP id d75a77b69052e-4b0aee0416fmr177626441cf.41.1754909805221; Mon, 11 Aug 2025 03:56:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH84pkBd6GJf8XCR9+s0wYsjRXbW3CjMG1+xiMebELRnnC0y+m6C0KXWBUqdNOSAQDFJQ+q/g== X-Received: by 2002:a05:622a:164b:b0:4ab:81c7:b992 with SMTP id d75a77b69052e-4b0aee0416fmr177626021cf.41.1754909804709; Mon, 11 Aug 2025 03:56:44 -0700 (PDT) Received: from [192.168.1.15] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e698de2df7sm1273446485a.80.2025.08.11.03.56.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Aug 2025 03:56:44 -0700 (PDT) From: Brian Masney Date: Mon, 11 Aug 2025 06:56:10 -0400 Subject: [PATCH v2 6/9] drm/stm/dw_mipi_dsi-stm: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250811-drm-clk-round-rate-v2-6-4a91ccf239cf@redhat.com> References: <20250811-drm-clk-round-rate-v2-0-4a91ccf239cf@redhat.com> In-Reply-To: <20250811-drm-clk-round-rate-v2-0-4a91ccf239cf@redhat.com> To: Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Linus Walleij , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Yannick Fertre , Raphael Gallais-Pou , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Stephen Boyd Cc: linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1754909781; l=2470; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=TQX7y0WLJPoT2FXW3ljOONLbYB3hMMDCH4wBpr8HvE4=; b=lgrz8b1APu4kFbIpIygfaPAMyZa9PSq0qCqlA9d2JnXNchMfPplzKOoa7IYJs93TVO9unUYBZ Y9qrAO5hmIoCqBBrlG0p/QgoeneH78eck1EdJ9ad2HPr3tup0+0Nd5I X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: opfjkC4EMVczsVoe_AAJwiQBLqOMBhVTcqz1ncn8AG8_1754909805 X-Mimecast-Originator: redhat.com Status: O The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Acked-by: Raphael Gallais-Pou Signed-off-by: Brian Masney --- drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c index 2c7bc064bc66c6a58903a207cbe8091a14231c2b..58eae6804cc82d174323744206be7046568b905c 100644 --- a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c +++ b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c @@ -274,8 +274,8 @@ static unsigned long dw_mipi_dsi_clk_recalc_rate(struct clk_hw *hw, return (unsigned long)pll_out_khz * 1000; } -static long dw_mipi_dsi_clk_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *parent_rate) +static int dw_mipi_dsi_clk_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct dw_mipi_dsi_stm *dsi = clk_to_dw_mipi_dsi_stm(hw); unsigned int idf, ndiv, odf, pll_in_khz, pll_out_khz; @@ -283,14 +283,14 @@ static long dw_mipi_dsi_clk_round_rate(struct clk_hw *hw, unsigned long rate, DRM_DEBUG_DRIVER("\n"); - pll_in_khz = (unsigned int)(*parent_rate / 1000); + pll_in_khz = (unsigned int)(req->best_parent_rate / 1000); /* Compute best pll parameters */ idf = 0; ndiv = 0; odf = 0; - ret = dsi_pll_get_params(dsi, pll_in_khz, rate / 1000, + ret = dsi_pll_get_params(dsi, pll_in_khz, req->rate / 1000, &idf, &ndiv, &odf); if (ret) DRM_WARN("Warning dsi_pll_get_params(): bad params\n"); @@ -298,7 +298,9 @@ static long dw_mipi_dsi_clk_round_rate(struct clk_hw *hw, unsigned long rate, /* Get the adjusted pll out value */ pll_out_khz = dsi_pll_get_clkout_khz(pll_in_khz, idf, ndiv, odf); - return pll_out_khz * 1000; + req->rate = pll_out_khz * 1000; + + return 0; } static int dw_mipi_dsi_clk_set_rate(struct clk_hw *hw, unsigned long rate, @@ -351,7 +353,7 @@ static const struct clk_ops dw_mipi_dsi_stm_clk_ops = { .disable = dw_mipi_dsi_clk_disable, .is_enabled = dw_mipi_dsi_clk_is_enabled, .recalc_rate = dw_mipi_dsi_clk_recalc_rate, - .round_rate = dw_mipi_dsi_clk_round_rate, + .determine_rate = dw_mipi_dsi_clk_determine_rate, .set_rate = dw_mipi_dsi_clk_set_rate, }; From patchwork Mon Aug 11 10:56:11 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Masney X-Patchwork-Id: 1253 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF39528C870 for ; Mon, 11 Aug 2025 10:56:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754909814; cv=none; b=MivdAZkKW5Cpsd12+VJWikL2AHlPJTgOJXppLtJNf0gIRD1lMBu4sK/GBPJ7H42W4CfHGyIVVdKecD1GYjNgt3nRRLmQpm3+yko+8RgNTdgThPA4XY1RqI3+Uj/MbrffavjXcK/ZGxWc5BiMga3Sm2i9yvk7GiHrYRKtiWO92lI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754909814; c=relaxed/simple; bh=juKzshMtQ4DF/h+L6Akp+woYewfsK6BXt/oa5cMlZgg=; h=From:Date:Subject:MIME-Version:Message-Id:References:In-Reply-To: To:Cc:Content-Type; b=GxnAZSRjOmkpt7nPsuxB5idtYKkdBkeDN2R86gf0lQ2GefKSYFPDXPv/SBHTjTJCGst4dk9/q3Xm6nF3ZyU2Nhd144UORIvfIHX/WShIfeH08M0GsnrA0fURBZCdq7OORUJ4qaWw0WRW2oFEvu0Jnfce8tgLqW52sw9PVI3XZ0c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=bsRobUNi; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bsRobUNi" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754909812; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JStqtZIS8blwztj2LAAjIqKUEnudWLKj0xcXYk/QJ50=; b=bsRobUNi+O3o2H/ZL0/A6U4KesyyYlY5L+fwjihfCgRJ14lU1BmvK1libdUQLbP2mYLSK7 +9wrxAxXo/KxkmgzfCYPe2V214MV23HrSu/Xi+KbVSzPocekiVm3E3tccRewwL1MMHIuSt aGH6fG3izkLrRpw0ixbMU5XMwnynwSs= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-166-Qk9n2gIbMsmKqqMI7No9Tw-1; Mon, 11 Aug 2025 06:56:49 -0400 X-MC-Unique: Qk9n2gIbMsmKqqMI7No9Tw-1 X-Mimecast-MFC-AGG-ID: Qk9n2gIbMsmKqqMI7No9Tw_1754909808 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7c5cd0f8961so971948985a.1 for ; Mon, 11 Aug 2025 03:56:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754909808; x=1755514608; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JStqtZIS8blwztj2LAAjIqKUEnudWLKj0xcXYk/QJ50=; b=WHWHCdj4Mj1VaKC19E1L5m2+AAOJFIDDAIVcy99aGa9818QssbcSL5CBrS7LKzNUsL OX9oksvLgew+eN2MMa2dcS53Bl9J2qJWuINvBro+SZX60yMdwgZ/MLT+Z+DkOW/9QNtj 4Nz4IDBJhqs3AlEJigfgyRoxAQhbz3t98M0mQZKTIwHMGHKSaYcUmF+MvJZ6x2autaga W7Wr0fbaetTaWH+Cvd2u1H+8/+FrsjGRHsCVM49brK1M84bFS4edk8HmmoAp9yt3YJtk +WoCfz4cz0OYe0Ml1rGJi2pjdevrSr1PLbIsXNHQE7O9oKso+OmtRd4MlUwC6wwGXQIx l+qw== X-Forwarded-Encrypted: i=1; AJvYcCW2nkC7ejXgEwWU95G6P6dZceYmMkEhhPnxLfvV68Vel4pENcMpE7OkcfdD7Y6FHJwD5d4L3muQl7KFgA==@lists.linux.dev X-Gm-Message-State: AOJu0YxTtCkRio6M8tMwjta/cPRjemFaswJq1onBrnKv6xQ6Xap4Z1mp 8555WBot1jzACK+jF+u6mmsmLJrcnAkKUrbklE9qds48KpXCJ6AyQBAwCt3lt9q7YWcaA60IxSm yzpxTIJmswHYeUR2W6ug5dNbb21fD1h2vrejTFBcRm0VQ82sTOnMvUkuEmDQ5l98n X-Gm-Gg: ASbGncsJRFKGVIbDMa8CNDWELI0RLgMzVTQ03wZYyD3NaZCvmSL3KT8AIPDdpWTIUWL 6KR3UqlkNASvr/2ET91WCy6MefwBWeenbKrzG5T7BwVjC2oAnQS+OBMWKfzLokoxo49ZOMnaX6O 6tl+xbkGbG3fiLsHuaV52xC/w4wCd1/8mYtSoPExxXoX1Jk4f+e/XvBAwi4GMfs1Fm9oJZBy27E Ta8o23LiYB1a3/HsRohicTbK4DwTPx1Mz9t4xFFo+8j+Iivbk9PhV0z3gx3x5Ygmt2eqFWqt3zK YVcHasKPKbueTUBdtsY/3Qc1UgLt+F4OYyPEidjH9LzuTrOt6sfTUbH6zUuSs31tHUPlqMB+H4Y at+I= X-Received: by 2002:a05:620a:a00e:b0:7e3:60cf:c037 with SMTP id af79cd13be357-7e82c75b89cmr1125687285a.34.1754909808558; Mon, 11 Aug 2025 03:56:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEhnLELhezGJADLmdApayEoevKdtEKOKSDSvgPhqkzq4hJSUIbUnZL0k2iE8nto9nf3DAncrQ== X-Received: by 2002:a05:620a:a00e:b0:7e3:60cf:c037 with SMTP id af79cd13be357-7e82c75b89cmr1125683685a.34.1754909808062; Mon, 11 Aug 2025 03:56:48 -0700 (PDT) Received: from [192.168.1.15] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e698de2df7sm1273446485a.80.2025.08.11.03.56.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Aug 2025 03:56:47 -0700 (PDT) From: Brian Masney Date: Mon, 11 Aug 2025 06:56:11 -0400 Subject: [PATCH v2 7/9] drm/stm/lvds: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250811-drm-clk-round-rate-v2-7-4a91ccf239cf@redhat.com> References: <20250811-drm-clk-round-rate-v2-0-4a91ccf239cf@redhat.com> In-Reply-To: <20250811-drm-clk-round-rate-v2-0-4a91ccf239cf@redhat.com> To: Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Linus Walleij , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Yannick Fertre , Raphael Gallais-Pou , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Stephen Boyd Cc: linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1754909781; l=2162; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=juKzshMtQ4DF/h+L6Akp+woYewfsK6BXt/oa5cMlZgg=; b=srQL2Syf3qoqHVxtrhYtzT2hxKDJiG2H0/4WtgjDA8OLuly+icCFFE04ANS8bywbgRo5Semzj RZvKazBg3coDcnWyiIki4FOxz5OPAdab1K8jRW40iEHpLbopisMgRC3 X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: I3nfK69P6pNWwBYd0OBxodJgDxlNdqFzY9m_hSCWh9k_1754909808 X-Mimecast-Originator: redhat.com Status: O The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Acked-by: Raphael Gallais-Pou Signed-off-by: Brian Masney --- drivers/gpu/drm/stm/lvds.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/stm/lvds.c b/drivers/gpu/drm/stm/lvds.c index 07788e8d3d8302a3951e97d64736b721033998d3..fe38c0984b2b552e1ccaef4d1e589b9d86a40ee3 100644 --- a/drivers/gpu/drm/stm/lvds.c +++ b/drivers/gpu/drm/stm/lvds.c @@ -682,8 +682,8 @@ static unsigned long lvds_pixel_clk_recalc_rate(struct clk_hw *hw, return (unsigned long)lvds->pixel_clock_rate; } -static long lvds_pixel_clk_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *parent_rate) +static int lvds_pixel_clk_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct stm_lvds *lvds = container_of(hw, struct stm_lvds, lvds_ck_px); unsigned int pll_in_khz, bdiv = 0, mdiv = 0, ndiv = 0; @@ -703,7 +703,7 @@ static long lvds_pixel_clk_round_rate(struct clk_hw *hw, unsigned long rate, mode = list_first_entry(&connector->modes, struct drm_display_mode, head); - pll_in_khz = (unsigned int)(*parent_rate / 1000); + pll_in_khz = (unsigned int)(req->best_parent_rate / 1000); if (lvds_is_dual_link(lvds->link_type)) multiplier = 2; @@ -719,14 +719,16 @@ static long lvds_pixel_clk_round_rate(struct clk_hw *hw, unsigned long rate, lvds->pixel_clock_rate = (unsigned long)pll_get_clkout_khz(pll_in_khz, bdiv, mdiv, ndiv) * 1000 * multiplier / 7; - return lvds->pixel_clock_rate; + req->rate = lvds->pixel_clock_rate; + + return 0; } static const struct clk_ops lvds_pixel_clk_ops = { .enable = lvds_pixel_clk_enable, .disable = lvds_pixel_clk_disable, .recalc_rate = lvds_pixel_clk_recalc_rate, - .round_rate = lvds_pixel_clk_round_rate, + .determine_rate = lvds_pixel_clk_determine_rate, }; static const struct clk_init_data clk_data = { From patchwork Mon Aug 11 10:56:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Masney X-Patchwork-Id: 1252 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18E5328C87C for ; Mon, 11 Aug 2025 10:56:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754909815; cv=none; b=Q92EL7+h54JnNeHgy7eyCHnCQ8UvrOU+ql0odoGvML+ck8joJJBv42G0rPrsYIY/4k3blcJpwVyMXebUZ/rUlLNB7wlic3jCJOajdpFm0Jva/a9zcRWESs1e1H8LBP64BUqriq0gAPSCmAsGqQxUOcfPowDX9N3LGdI6I1KC78o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754909815; c=relaxed/simple; bh=4SmOn45QQwwyMezbBb5tx+ffOCKNsfDDe6H8Sa9QRwg=; h=From:Date:Subject:MIME-Version:Message-Id:References:In-Reply-To: To:Cc:Content-Type; b=gZ0wfkW54Eqb9ODV1Pdp5FsEhq65gKMEzyostBRrIpAElnl7+lXoZJVB4UvpbsoUgc6G6pa7dcg/TzFBYJ12la8DnxpN6i2CILEk/jopiA/XttiEqmDGRGYz/+KckGF0+/FoW6Lsc6aRB1s92A6xJt3fGbzTZnjGrZJVV+qfnYM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=DdgK5j86; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DdgK5j86" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754909813; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t+Rztee25JuVOb3qnfGrbYzil++DqREMLNxo1mFDVeU=; b=DdgK5j86P6d00GitbptmK7sdrzwJWhHk495pOfAXuttPUG/Uu0Fe9b3Al5GIhEoaCoxEIM EHmK91B6O8ufFJtJY7zqfIAAGhiNDeV/LGhzU9srcNY0PrdG5iV/fioHD2f0nAHDWRqq4M wJVjksnkloQJx4MXmn/i6tj4crIyWDk= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-411-3WE2p_x5OnaBiynzCAbKHQ-1; Mon, 11 Aug 2025 06:56:52 -0400 X-MC-Unique: 3WE2p_x5OnaBiynzCAbKHQ-1 X-Mimecast-MFC-AGG-ID: 3WE2p_x5OnaBiynzCAbKHQ_1754909812 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7e69e201c51so996731585a.1 for ; Mon, 11 Aug 2025 03:56:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754909812; x=1755514612; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t+Rztee25JuVOb3qnfGrbYzil++DqREMLNxo1mFDVeU=; b=ptt8OR7/n89YNCBhgZEJT5mw7wj6FLI+Bdb3JtQb4QehxHJ8uw2T9IEKRyec/tw0VH EomtQeeky8kvTEg0V+93jMWc6cOzB9RuYFFXfFmpLXXSlNu126LiKDSXnmGsphFjjct9 /7qgvYk8PnWozd/CfMRFXIe2S1bAtpykpHik2LQJEELD0WklUH9TLHoT7gD0Y7wjBLH4 XLztAPFinqkWf48EgdSvQsLnHtQgwBCo95ckNTiKwCRZX/nA0tGyZjrXLAXPjz1eEszZ MEH0GHEdK5y87W/elI/Z7qL0OWRBY3peXIpZ49zkTb0qot0MhwmWit6x47XZLNy6D2KO 3PLw== X-Forwarded-Encrypted: i=1; AJvYcCV/jjg/np0b8Uc185Vkz6IN+FtRyMtjKnYVPwoIGERKj0/f5++YDrY/V028SJqk3V8agDEuSEE4yA80tQ==@lists.linux.dev X-Gm-Message-State: AOJu0YzUxIKitYNLc13zxU5IsqbtHC+OWbLeaGAAjNKGHxy4BuPrRiZk 2UH817Yy55rUDZHGcjfpwlOjLFX/S7AdDvZs4LdUbWnuUM6X4smLYrt+qCCALvEAhhP/kp2tw14 Db8zo5Gh/+GpLPN0GM6jv0M1mhSF6iMyIDEYRFUwGRGEXYovGE1wMK4il/VGqGJWZ X-Gm-Gg: ASbGnct22ALDoTBFOpGbTf5IEPva6cErnULZQgUeEzM9Fdu2UIoSgt6BKiE20607OXZ TXZOMQ6JPss2kFXyJNb8TdY91JkXWyAV++gwk5G5/W5CZz46DQSvp2zc4hwRbKqzPQBUaiY5q0G jmxy5VmOaGtGiY2liUROpPVJa5meaD5U9Ep+2+0XqrjMnqxz0fV1sAmrqXcHbnEGFC5BhSNC+cH lI7TCYlj5a0uX1yHl0xw7ymj6Hz65I95htW9Kzwg9Cp88h+GYL1Pa8umsDHc9S6YjJHRFH4c9Ne m5EQGlb4lrPnqPa+xbC86CZQT0ZcQyuluSrtKypxzPZ7EG6vPKb9c+N5+tAN5eFmtK45kBYlyg7 CW6s= X-Received: by 2002:a05:620a:c50:b0:7e8:1b64:2187 with SMTP id af79cd13be357-7e82c75f958mr1792739485a.33.1754909811724; Mon, 11 Aug 2025 03:56:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEK2Etk94d7jqWBuBTsPUBpC0ORVIn7oE21Xh8O9EOQgSk7vq5RIMLYWuxIl1Nwz+nt1Y38MA== X-Received: by 2002:a05:620a:c50:b0:7e8:1b64:2187 with SMTP id af79cd13be357-7e82c75f958mr1792735585a.33.1754909811152; Mon, 11 Aug 2025 03:56:51 -0700 (PDT) Received: from [192.168.1.15] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e698de2df7sm1273446485a.80.2025.08.11.03.56.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Aug 2025 03:56:50 -0700 (PDT) From: Brian Masney Date: Mon, 11 Aug 2025 06:56:12 -0400 Subject: [PATCH v2 8/9] drm/sun4i/sun4i_hdmi_ddc_clk: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250811-drm-clk-round-rate-v2-8-4a91ccf239cf@redhat.com> References: <20250811-drm-clk-round-rate-v2-0-4a91ccf239cf@redhat.com> In-Reply-To: <20250811-drm-clk-round-rate-v2-0-4a91ccf239cf@redhat.com> To: Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Linus Walleij , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Yannick Fertre , Raphael Gallais-Pou , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Stephen Boyd Cc: linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1754909781; l=1693; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=4SmOn45QQwwyMezbBb5tx+ffOCKNsfDDe6H8Sa9QRwg=; b=D6lQv4uU9BbCtmlsDXvXPLa8dR0h0DlOWWckbVaEkFndxlEt+IyMNkfDuSVR8NgDYOThGx2MA 72BwKh/6cLNDsrNiAlNie395a35C4+/kjwVpt/wftlDiaqzAFDkxkOV X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: fesX29mr88lvcQHb-SmCxAxfXsbthpax2GqGSt2vuBo_1754909812 X-Mimecast-Originator: redhat.com Status: O The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Acked-by: Maxime Ripard Signed-off-by: Brian Masney --- drivers/gpu/drm/sun4i/sun4i_hdmi_ddc_clk.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_ddc_clk.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_ddc_clk.c index 12430b9d4e930f7e7b0536a5cabdf788ba182176..b1beadb9bb59f8fffd23fd5f1a175d7385cd5e06 100644 --- a/drivers/gpu/drm/sun4i/sun4i_hdmi_ddc_clk.c +++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_ddc_clk.c @@ -59,13 +59,15 @@ static unsigned long sun4i_ddc_calc_divider(unsigned long rate, return best_rate; } -static long sun4i_ddc_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *prate) +static int sun4i_ddc_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct sun4i_ddc *ddc = hw_to_ddc(hw); - return sun4i_ddc_calc_divider(rate, *prate, ddc->pre_div, - ddc->m_offset, NULL, NULL); + req->rate = sun4i_ddc_calc_divider(req->rate, req->best_parent_rate, + ddc->pre_div, ddc->m_offset, NULL, NULL); + + return 0; } static unsigned long sun4i_ddc_recalc_rate(struct clk_hw *hw, @@ -101,7 +103,7 @@ static int sun4i_ddc_set_rate(struct clk_hw *hw, unsigned long rate, static const struct clk_ops sun4i_ddc_ops = { .recalc_rate = sun4i_ddc_recalc_rate, - .round_rate = sun4i_ddc_round_rate, + .determine_rate = sun4i_ddc_determine_rate, .set_rate = sun4i_ddc_set_rate, }; From patchwork Mon Aug 11 10:56:13 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Masney X-Patchwork-Id: 1251 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B04B428D83B for ; Mon, 11 Aug 2025 10:56:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754909819; cv=none; b=Dr1/gL/RY18RaRkBHC69sbHQbVM2NH7SHjQtSD2bkvajjoBOXAskw1XXFw4D4Tt0BUBRxBdOQ9CTsKrZjYDPNsTGHEmeOjQB1P/Awve8CESwrjGI4qRNZCH40PZvDl2Nw5RHSGBNds1dwM00aCK5sIghl4vO9IOeO1JaNhKuFtM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754909819; c=relaxed/simple; bh=y0KLkFzoWiBCsjyKHVyFf5yBXdH+nrgv9bMtrhIbLXo=; h=From:Date:Subject:MIME-Version:Message-Id:References:In-Reply-To: To:Cc:Content-Type; b=Ubdu3Q2BJ1eDH7USijbPc7nTi5uz+/zB7rjtiHu9875pTE9fHDf1gByoOigkcaF3/gJpHA8ZYbdrV3BjnJpivo63BZvkAKC8/2vBJf4Wf3VeTpROkg3o/Y/WMb8jMJ6zg+NtYU6B8PfBJUZg16vne9W/OrgA4OA4VS6u5iXlY7k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=GilScB5k; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GilScB5k" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754909816; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CR+LHOxQNJH4mrdkRrblEPU2A6Ou6dlR4qZMmeyZ4e8=; b=GilScB5kXJKCD3HRWPAFfxxZb2ToHJHsuAOrphK+se0nkjEHigrTrK9zKzxXNyxcnwdHuR P03CAHuacJV4jjvYsyRRtd41Ca/uUvyHtcB9zUD8inFPyRlPrUK4VZyPkgQJ7XaK2JzT5N q1k+TBpIZsOpjNpIFJfsdhxG7QSuPn4= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-639-t0zqOxMBMgWQmqpDDH5dYQ-1; Mon, 11 Aug 2025 06:56:55 -0400 X-MC-Unique: t0zqOxMBMgWQmqpDDH5dYQ-1 X-Mimecast-MFC-AGG-ID: t0zqOxMBMgWQmqpDDH5dYQ_1754909815 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7e69c14e992so834372385a.3 for ; Mon, 11 Aug 2025 03:56:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754909815; x=1755514615; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CR+LHOxQNJH4mrdkRrblEPU2A6Ou6dlR4qZMmeyZ4e8=; b=iGqI2ZGl0CMQ6E16nLB/zm99rVqEj3h6c1/TjH25itvWJZthmtoNgI5rp4geRfhaYX RydR0s2MdOiIvTA2OmS/eyh8DXo3CiTReBMpVtm6FQNyZJ+Id8Fsv+xURAVw+slqS3NV TVhf9eXhmSO0eWC4+bsFM2Kowe52rhOVhLPkNKSATSn1lmw3CE76kl5OnYdu4pajPgOe wtYVsk2NdeVFJq8JRQJICvJAlJYpKcwwEqxzaXwGPOLoexeYlRSh7b4MhxxZkIDw6JxP NoxURGNAVLxlqqJ9cmoWTDcmXSluxDlD0GYENVFhKeSgr2lcSOploHx28d1/RdX9br4C 5NPg== X-Forwarded-Encrypted: i=1; AJvYcCVsy/uCSdGcThBp3KKW9sjOp3EsnCE9jm/TsKEj4BnUTP3qR+3fnpqVxPdSrJ+9KmOQgjnMnMQhgIg4xA==@lists.linux.dev X-Gm-Message-State: AOJu0YyB4CGAfHGAYe3KzmKWVi7LnAa7zXWx6SF3ZnQlvWTgsEkIlM95 QtPEPnbEXX7eGEI+Das+12dJVL+0qy5e2Bqc8/LS+d0DW456RLIVQuXqunU3iDxy/k5x9rvNobE hJoJqQtrzi5ElNvc3Ssh15e8KtxLkJqnpqbbNZ9qfxY408EheWtBHnBR9XTwsPC0l X-Gm-Gg: ASbGncugO7Y9JFLHlTb1lW5Absah2N2iJ3L+P06VySMSCVuTROvJorKt/mBL7x/bD9b mmiOBa65zTOjO+Hvd0++SyHQ6XSqIRL7xy73I3HpiTmanKhqoiN8wPqFo9E6727oory85rU0Abv DxObdp//mDK8wHoAUQEFNGkjI5XB5B94q8YOs3pEcdwqPPhl3KarMiBTnNiotH2xo+6/fpcIEeQ IikuqIP64leauC8YLxQ5x0OAoKYeJU0rTeUXXTsj6RHeY3BG6YDi2xbYfwwoOZY1W9JZn7pHFnr RkxQyJlJbqGpQnC5ZJ0KqOs9Hg4Ef+AyZ7EsKNJSIf+i+2m3h2CHBlUnmkTpob4v+R3f0tgPz7l 7vr0= X-Received: by 2002:a05:620a:1996:b0:7e8:54f7:67cd with SMTP id af79cd13be357-7e854f76862mr91488685a.50.1754909815378; Mon, 11 Aug 2025 03:56:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFSii5P15b+af3L4E7F/cQGCM1Xz8KwmyfhCdGkZGKODW+eFh6Bky1dDzTK+GfwnJZiiMZJQQ== X-Received: by 2002:a05:620a:1996:b0:7e8:54f7:67cd with SMTP id af79cd13be357-7e854f76862mr91484185a.50.1754909814934; Mon, 11 Aug 2025 03:56:54 -0700 (PDT) Received: from [192.168.1.15] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e698de2df7sm1273446485a.80.2025.08.11.03.56.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Aug 2025 03:56:53 -0700 (PDT) From: Brian Masney Date: Mon, 11 Aug 2025 06:56:13 -0400 Subject: [PATCH v2 9/9] drm/sun4i/sun4i_tcon_dclk: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250811-drm-clk-round-rate-v2-9-4a91ccf239cf@redhat.com> References: <20250811-drm-clk-round-rate-v2-0-4a91ccf239cf@redhat.com> In-Reply-To: <20250811-drm-clk-round-rate-v2-0-4a91ccf239cf@redhat.com> To: Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Linus Walleij , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Yannick Fertre , Raphael Gallais-Pou , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Stephen Boyd Cc: linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1754909781; l=2307; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=y0KLkFzoWiBCsjyKHVyFf5yBXdH+nrgv9bMtrhIbLXo=; b=j1ZnE8gcsk3YjO3zCEvUNiC5B3rrw/rsR6rCeLo5Q9BxZp8jvK69xEFMszvH1iDCwux2pSDHd eRkR0peMpaDCxDNa8Bi3chrL3Nda3ZZTmewCk0Eb5cefUz9pD7/Qw2Q X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 6mW-V8UG9hFwFt7-D8ad5eGaQgACiETM0AM15DbsPqU_1754909815 X-Mimecast-Originator: redhat.com Status: O The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Acked-by: Maxime Ripard Signed-off-by: Brian Masney --- drivers/gpu/drm/sun4i/sun4i_tcon_dclk.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon_dclk.c b/drivers/gpu/drm/sun4i/sun4i_tcon_dclk.c index 03d7de1911cd654f395ea85ad914588c4351f391..4afb12bd5281f0d1720cfe2c8f79b80d97244ef2 100644 --- a/drivers/gpu/drm/sun4i/sun4i_tcon_dclk.c +++ b/drivers/gpu/drm/sun4i/sun4i_tcon_dclk.c @@ -67,8 +67,8 @@ static unsigned long sun4i_dclk_recalc_rate(struct clk_hw *hw, return parent_rate / val; } -static long sun4i_dclk_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *parent_rate) +static int sun4i_dclk_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct sun4i_dclk *dclk = hw_to_dclk(hw); struct sun4i_tcon *tcon = dclk->tcon; @@ -77,7 +77,7 @@ static long sun4i_dclk_round_rate(struct clk_hw *hw, unsigned long rate, int i; for (i = tcon->dclk_min_div; i <= tcon->dclk_max_div; i++) { - u64 ideal = (u64)rate * i; + u64 ideal = (u64)req->rate * i; unsigned long rounded; /* @@ -99,17 +99,19 @@ static long sun4i_dclk_round_rate(struct clk_hw *hw, unsigned long rate, goto out; } - if (abs(rate - rounded / i) < - abs(rate - best_parent / best_div)) { + if (abs(req->rate - rounded / i) < + abs(req->rate - best_parent / best_div)) { best_parent = rounded; best_div = i; } } out: - *parent_rate = best_parent; + req->best_parent_rate = best_parent; - return best_parent / best_div; + req->rate = best_parent / best_div; + + return 0; } static int sun4i_dclk_set_rate(struct clk_hw *hw, unsigned long rate, @@ -155,7 +157,7 @@ static const struct clk_ops sun4i_dclk_ops = { .is_enabled = sun4i_dclk_is_enabled, .recalc_rate = sun4i_dclk_recalc_rate, - .round_rate = sun4i_dclk_round_rate, + .determine_rate = sun4i_dclk_determine_rate, .set_rate = sun4i_dclk_set_rate, .get_phase = sun4i_dclk_get_phase,