From patchwork Thu Jul 10 17:43:02 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Masney X-Patchwork-Id: 1422 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B777D2F0E28 for ; Thu, 10 Jul 2025 17:43:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752169406; cv=none; b=Mdc1klNSeC38TcnSAmjT+aNQFlhWeVgc7DCctZ7zAE7L5aJoHWt/FIC9NvAasSel2Nj59ruMgoPqN7NrFy/CqOfuBUMYRD6G5WrqD/ZACwp+JI/p3pyo5LnF9dQgqCbWvU994jLTtIGI3Tc7vF3wlRmvaPr5jWcb82KLaz6j6KU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752169406; c=relaxed/simple; bh=JMQuzI07hiKrV1ATnFggAmht1J6rMxSCqpxpi2ExgQM=; h=From:Date:Subject:MIME-Version:Message-Id:References:In-Reply-To: To:Cc:Content-Type; b=tq/nudtiHwv/nxtEFIaf8vjrpCqFllSGNA76ChF8op65a8vn+S+/sfdZIb58Yf/p2Lcr7Yht57uGvZjTiwX4RrtFaDd17qwJeJ8f9KbTE+/lBHKNAnOvueVWO4ahakzxQ+WQaoqIGY6ToqWoWp8pYsmRYzHfBU7eNRtW37jDQBc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=IdeP9z59; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IdeP9z59" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752169403; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uSQAcfejxg7NhusLP2Sc0sAULtF+i3/IlJefnecYrRg=; b=IdeP9z59Mn3OgGRoZbhieLj2FnqngFyTrM/WD/a4I8HRtu84LX2CmBkFsYeVwMp2aJZRmI +luLJMSBS7/4fC+29zTjGNBd7Km4ITjd8Nxu+ZII+98TOVtxCv1D+VcPNdvX3DCY9IUfkR Hqz6LfYcE2KJbsW+DgrHmRxoqHE1qhM= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-447-8lVXd2kQPIOSmJnMwQIiPA-1; Thu, 10 Jul 2025 13:43:22 -0400 X-MC-Unique: 8lVXd2kQPIOSmJnMwQIiPA-1 X-Mimecast-MFC-AGG-ID: 8lVXd2kQPIOSmJnMwQIiPA_1752169402 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7d446ce0548so196523785a.3 for ; Thu, 10 Jul 2025 10:43:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752169401; x=1752774201; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uSQAcfejxg7NhusLP2Sc0sAULtF+i3/IlJefnecYrRg=; b=i4gF8vj/QzNWDVsjp1JyjO8nbrGysVJVCaoMH62p5Nx7ZPqd+RzEt4g6zMTnx4brBE RhJY4gJmbODkBfwMUf60gJMyfoF/SVOQKs1VArQH/TYHTsad8OExTXXMmM40JsJmbUOV GUyKCdqMHpIqRAWhEz9dZGIB4PONl0zSA3ikTCPllPu1LFQClcDFPkrBJpdiC7qU1Ofd D+1wZwkvb5gXRri+NdZ1fYVYYOBiYlHQx6no/qq7KQcSGoELQFMyHd2nYXPcgx/vPx7u syTiv1zD/G3g9EO3QYQaxriwk3hkMdTh72e8CUTYGriDzArDcwGU0Ksl2E/zrO30lviz /ezQ== X-Forwarded-Encrypted: i=1; AJvYcCWaDS6YRDFjbtWDjPkqQKbL8q5GCpAxo2ATV0Q8aMUDvxzjBMRISfIzRRrBIIvAnatUmeAYyiJ83cCVgg==@lists.linux.dev X-Gm-Message-State: AOJu0Yy4ll35n6WvNnRUKgpArBOhh+OCo5EEO2NAnZrTNcVNJkXnemuz w+MKo/ZvZqNImTrqGajmSZC9FoxhDckGO2N6KqyHRy4MS86sUO8Lgdrt40v2ZIvjI9T++pR37ES +o3k59rOaZ00oaL/6fnBcZnOPDYwfHXjkN0LGThhSgRtgkhnVJDKNSZY4T9+5ywIP9aEWWiBpI9 G2IMxAwv3DL80KHQB8QjoCIvwG7S7z5jDt8bp3eERQXQArU/upfA== X-Gm-Gg: ASbGnct+zhqGT2gSFCo1IFAB8QRmi29WNbF9szBLMvGg7iln4+mxfTXWilhP6lizdr6 QKPiomT34IckW9Ip5QPD23THfdcP5PuMHnVrIcyriYEuCGmqi95vA9DWgzA2V7r6KkccBcexqV3 rW4pBWGkuhqaPL/4PdsrjZwncIISWCH4RX+gdJmeJqU5NcmVm1JQ8xRj2JeiQW0ikNJuGYnNng1 rMdBtPT2KEzPnBCYcPHR9D/29lUt14hvhnXA2tz4m0xpGO/MDMTc4xKQPI4p00o4SmrFRm2Tw1g qTlWcB1WCJK6ty9OW040rQZjWuPvpoVWdpSItLua8B2ShwM6RsuODRqe/Ch8 X-Received: by 2002:ad4:576f:0:b0:702:ca9e:dba6 with SMTP id 6a1803df08f44-704a40f3f86mr2464966d6.16.1752169400981; Thu, 10 Jul 2025 10:43:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGneFeZHD+R2IlA/RJ8povEc4F9IjcKH8Fgp0p4dCYgtfr/rKSizrHDLTlvLp9E8FfSRTeZdQ== X-Received: by 2002:ad4:576f:0:b0:702:ca9e:dba6 with SMTP id 6a1803df08f44-704a40f3f86mr2464046d6.16.1752169400264; Thu, 10 Jul 2025 10:43:20 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-70497d71419sm10652876d6.86.2025.07.10.10.43.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 10:43:19 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 13:43:02 -0400 Subject: [PATCH 1/9] drm/imx/ipuv3/imx-tve: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250710-drm-clk-round-rate-v1-1-601b9ea384c3@redhat.com> References: <20250710-drm-clk-round-rate-v1-0-601b9ea384c3@redhat.com> In-Reply-To: <20250710-drm-clk-round-rate-v1-0-601b9ea384c3@redhat.com> To: Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Linus Walleij , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Yannick Fertre , Raphael Gallais-Pou , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Stephen Boyd Cc: dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752169393; l=1689; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=JMQuzI07hiKrV1ATnFggAmht1J6rMxSCqpxpi2ExgQM=; b=2cWi9RxWr4DG/uT+Adfe1rLsJLWqf/HsK4V1CHvsD1HqS0tzYLionTpIhnP/uRurPd7gfFmll 2lm+LwJba1xA78TVoaKVn+hJWZX7dEn9fhckaPz4uGeZs+gsOpWRugK X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: _tuPFJKB0HTh56ab1arCMYhnLlK_4tp5XSztDpc_9cE_1752169402 X-Mimecast-Originator: redhat.com Status: O The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/gpu/drm/imx/ipuv3/imx-tve.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/imx/ipuv3/imx-tve.c b/drivers/gpu/drm/imx/ipuv3/imx-tve.c index c5629e155d25aef5b43445bc18c6c90039c99974..63f23b821b0be66a8e8a379e1375ffd98552e72f 100644 --- a/drivers/gpu/drm/imx/ipuv3/imx-tve.c +++ b/drivers/gpu/drm/imx/ipuv3/imx-tve.c @@ -368,17 +368,20 @@ static unsigned long clk_tve_di_recalc_rate(struct clk_hw *hw, return 0; } -static long clk_tve_di_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *prate) +static int clk_tve_di_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { unsigned long div; - div = *prate / rate; + div = req->best_parent_rate / req->rate; if (div >= 4) - return *prate / 4; + req->rate = req->best_parent_rate / 4; else if (div >= 2) - return *prate / 2; - return *prate; + req->rate = req->best_parent_rate / 2; + else + req->rate = req->best_parent_rate; + + return 0; } static int clk_tve_di_set_rate(struct clk_hw *hw, unsigned long rate, @@ -409,7 +412,7 @@ static int clk_tve_di_set_rate(struct clk_hw *hw, unsigned long rate, } static const struct clk_ops clk_tve_di_ops = { - .round_rate = clk_tve_di_round_rate, + .determine_rate = clk_tve_di_determine_rate, .set_rate = clk_tve_di_set_rate, .recalc_rate = clk_tve_di_recalc_rate, }; From patchwork Thu Jul 10 17:43:03 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Masney X-Patchwork-Id: 1421 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1C282F1989 for ; Thu, 10 Jul 2025 17:43:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752169408; cv=none; b=TbU3ILeatyuaPXyHluSw3e8xy4ClZgnb5KOt7SQ4FefrCKo4QLWy5INKA0yfqwQoUlbYT/hhGwn3qT24iAL2R7XOVPw83Nxk+G/Ah6F9Wv3KBGdcY/RR1HHLUy7KgfYlC+9AqO3b+kQO7EECa64r6wEXAWjNndsla3LD48QW9RQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752169408; c=relaxed/simple; bh=kl2qeTWYwIcCK1THSOcO56NA9jbysmHw5mNgghcr0SU=; h=From:Date:Subject:MIME-Version:Message-Id:References:In-Reply-To: To:Cc:Content-Type; b=VYGc1K45SF5HWThDsS8y9rQ/yFubM/jJXdZgOoXLWK2CSIc04OBtNwp3wFJNlH+k76KM2zVjmFCEwnpJUFfdKO5u0DIqDovktvW5wp0dfXXi+PSDBQKMdjUuRoMKa7AaAbP/CzbZvJmJ5+fGiD8S3TIKBoTX1CfxpKGM3lXYWF4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=UKQObq0C; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UKQObq0C" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752169405; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZPzxLLqVb+btp2J7RVCrJ2ENgQ7+4k/pXM6bF/LohTw=; b=UKQObq0C2HDGxQSGASh/VSqQ5FSWIIgK7bU+/Kt2t32vdJoRHB/JOj1v8nNTlMWIbhJWRI f3ExChTznVGtIlqlH2ZBHBKNPeS69h9psk1TFWuvNCOv/foJZt9NhbnHc5bPhRvnmYZjxp XGoxWDd7E3gj1PzutYpG2q1DZEhvs2s= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-92-3nwKDLv5NsqgIdIPmTs4wQ-1; Thu, 10 Jul 2025 13:43:24 -0400 X-MC-Unique: 3nwKDLv5NsqgIdIPmTs4wQ-1 X-Mimecast-MFC-AGG-ID: 3nwKDLv5NsqgIdIPmTs4wQ_1752169404 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-702b5e87d98so25243686d6.0 for ; Thu, 10 Jul 2025 10:43:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752169404; x=1752774204; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZPzxLLqVb+btp2J7RVCrJ2ENgQ7+4k/pXM6bF/LohTw=; b=wZ3UOzBbEXtuqKZuH0Se6wbtlgF5DpKAgaahHvAhDhRJJR5/aFXYzVe2Hsd7Lsmiw+ TrwDCFKKMDaK0zdF+v3rIBEgoJOTL0exHQlxj3pGVEF6IONTUhtnV5GAcVGDA049MhKo edUVfl/DaZHyVmby13eLxbU+muBSfOrA1u4qTId6s5Q9UfyKG2K2m887YW8Olx5b/bhV zwZmsFu3DNikljlSD0VgkRb7yoCOVu2LXLK5SPCc5PsuEnqvf0H/YZxhi2XQgs34jwl/ D9WV49rpR5Qv2ZIDWCsIpO9FyBfJNyoVE119l80jhnK5dDgpyJu8XZ4uz/AOA4cUysYw oMQg== X-Forwarded-Encrypted: i=1; AJvYcCVep27ZXDtC46wpSmVPzbizH+TDXLXV5a5V+PMAYeWJPLTe8QOhLABAzPubctcJnjo4e/xudE0YvfXN4g==@lists.linux.dev X-Gm-Message-State: AOJu0Yygxweyf3AgJEGUH+4ZA9hpCYFWsQlntG2kqmFur61n8aikgB24 iZrduudUjKAeCeP1ftFM92k3R8SP7spUXASeoHihXUEOvEGtlueEg62VdFW1hBWJc2sWnuKwenY kSnTC5JmJa4ZiJahkb9E8Ic8r+KeyG1CbOQrZlVw9CvrPskaYLua3Seo7+rulJqwy5A/shTX7TC PL4P4NVnagfUTE68XqksNO87qQkbeVCiFTQ+UlW8Qu5geo5YECeQ== X-Gm-Gg: ASbGncvUFwYGx3pw5b+R0Qx00nkl+obMhssFrm9JN+GpXkAuG+MLs5c/WxOsSHwqZg1 LqeydvITnY68rUr2KYtJoBV0uEIlXk2Sp+QMAjmniwr9sVVHopMZb0nEzsPXbTGw8HeSupvGBvp rHDVH3EHvqci59Q85duFBD84wIsVTtI0MquuUz3PX51Bn+BWhiZEjUTw8HtI9WbH4vkAI/OitFA nLeiO7+kHz2OIZ5kCx89IIWAEr8MKVd4VUZoAIhCnEYz7bGNzuE2q06f6YQSSIu3+GwWGqrEX7a uT8090luMIS7Koa8DBDhPRRoVzijLQc5LaW7dpmYozZmDRxAAdEy0hgGrDjx X-Received: by 2002:a05:6214:4521:b0:6fb:66cb:5112 with SMTP id 6a1803df08f44-704a3b03a02mr2644876d6.43.1752169403871; Thu, 10 Jul 2025 10:43:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFibFyJAqH2Tkc8cSfyuj43nonhKwPGrbHTb1n3BZYj/b4JFbj4juY9nmJvfEsNrJfVGljjaQ== X-Received: by 2002:a05:6214:4521:b0:6fb:66cb:5112 with SMTP id 6a1803df08f44-704a3b03a02mr2644146d6.43.1752169403246; Thu, 10 Jul 2025 10:43:23 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-70497d71419sm10652876d6.86.2025.07.10.10.43.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 10:43:22 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 13:43:03 -0400 Subject: [PATCH 2/9] drm/mcde/mcde_clk_div: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250710-drm-clk-round-rate-v1-2-601b9ea384c3@redhat.com> References: <20250710-drm-clk-round-rate-v1-0-601b9ea384c3@redhat.com> In-Reply-To: <20250710-drm-clk-round-rate-v1-0-601b9ea384c3@redhat.com> To: Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Linus Walleij , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Yannick Fertre , Raphael Gallais-Pou , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Stephen Boyd Cc: dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752169393; l=1675; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=kl2qeTWYwIcCK1THSOcO56NA9jbysmHw5mNgghcr0SU=; b=dJ/qA0hGF/+fQfe0crsCUgeeRXp3uEEF5tBBbhlI5F6XFBRbvTidAvVYatP+DdWjLDW+J4Np0 hf2I1m8Rc9fCuxnysHNHHy4FFC3Lx0PLz51pJGMCy+rQ/pwYO2VWCbI X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Pqyvld_DDrIc4e50m9qfj8qoH8-HbpEQQuwaX14hGHs_1752169404 X-Mimecast-Originator: redhat.com Status: O The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/gpu/drm/mcde/mcde_clk_div.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/mcde/mcde_clk_div.c b/drivers/gpu/drm/mcde/mcde_clk_div.c index 3056ac566473487817b40f8b9b3146dbba2ae81c..8c5af2677357fcd6587279d58077d38ff836f0c0 100644 --- a/drivers/gpu/drm/mcde/mcde_clk_div.c +++ b/drivers/gpu/drm/mcde/mcde_clk_div.c @@ -71,12 +71,15 @@ static int mcde_clk_div_choose_div(struct clk_hw *hw, unsigned long rate, return best_div; } -static long mcde_clk_div_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *prate) +static int mcde_clk_div_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { - int div = mcde_clk_div_choose_div(hw, rate, prate, true); + int div = mcde_clk_div_choose_div(hw, req->rate, + &req->best_parent_rate, true); - return DIV_ROUND_UP_ULL(*prate, div); + req->rate = DIV_ROUND_UP_ULL(req->best_parent_rate, div); + + return 0; } static unsigned long mcde_clk_div_recalc_rate(struct clk_hw *hw, @@ -132,7 +135,7 @@ static int mcde_clk_div_set_rate(struct clk_hw *hw, unsigned long rate, static const struct clk_ops mcde_clk_div_ops = { .enable = mcde_clk_div_enable, .recalc_rate = mcde_clk_div_recalc_rate, - .round_rate = mcde_clk_div_round_rate, + .determine_rate = mcde_clk_div_determine_rate, .set_rate = mcde_clk_div_set_rate, }; From patchwork Thu Jul 10 17:43:04 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Masney X-Patchwork-Id: 1420 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F7502F0C72 for ; Thu, 10 Jul 2025 17:43:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752169411; cv=none; b=UDEJPgDCVedXGjTxLSx98txgJhErvNVf2hY/aQhcsDm9E5sHaCQ40E1VZGdYxM32D1Ca7qoDfqePO95TjKaZvjmT/A2fTswHdFxy2m1F1OEll4+XC9dTJTad4jAUZf+qWJH/rJiPexXOcTR4I8+6bABaJRyCTAG6vYLvSW3swGM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752169411; c=relaxed/simple; bh=0XNjSSy+sJ0lfEyL4cE3BgJoCrdQCRO7x73pTQQcP6I=; h=From:Date:Subject:MIME-Version:Message-Id:References:In-Reply-To: To:Cc:Content-Type; b=Nij1iV9warMjYfLlcOv0cghQkGlFJySTzUYOpPsL+p+lAbUxTcpZtTrNLRKeh1ILCbp4sIkT7ywEuNTgKqcw/Y0QCu32EEIpSvUaoIymU7qdoFtGcH5CrcgU9dw/iU6MUrc2fioSI9LwIPVM20GGeqsgcmk6TlI1MJbICGwUvlA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Z6C6+DUg; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Z6C6+DUg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752169408; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KBPGyYPlG02EWMpLoXBzNUmSiSLVytWyHaO2lqHRcZA=; b=Z6C6+DUg4w1ugVrWNW9WD7XPladdxlXW0J91egWhoYSpM9Q4ezFhvOUX6fcnXk00TKHtDd 6as/n6Q2VPb8Qk+eMAqJnuc+p1QNa1nZfytaHXEqQBCQ2SfOY00LSvzY0hFPAldqbNWGzC URwibWZiy3br+cSDhFQbudAzUvI23pQ= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-16-X4f8cEkoM3aaRFURpHhTZg-1; Thu, 10 Jul 2025 13:43:27 -0400 X-MC-Unique: X4f8cEkoM3aaRFURpHhTZg-1 X-Mimecast-MFC-AGG-ID: X4f8cEkoM3aaRFURpHhTZg_1752169407 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6fb3466271fso23954056d6.0 for ; Thu, 10 Jul 2025 10:43:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752169406; x=1752774206; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KBPGyYPlG02EWMpLoXBzNUmSiSLVytWyHaO2lqHRcZA=; b=A0MNMYe80qwiRrJBb/Q8YBxsjvsc86VSIQqvgZpljTcbUdZVxvzOqEIK+kEBaijuk5 qps4dFNNXb1zruVzQWl/7frGXGe7goMFVG4rtLT7adnczvUOLwksRmEmBNXcJCyVfc9K Lip9wMa2opkxXtRKKYxCoOFf9zQdMMbFHQPEI1c4T9A7hYUHxryFH07RC5mxGsgaAlb7 2lTQ9Yqo0GAceYj1OgoGFmMtgcKLqviERUdpWGZXsMi0Ranuo4ABVhaKGR89E6Oms1Gn nIDxA08vr1vGsAZby2cZ+nkEbBYDO8cdnWUh8TFCSzRX/GadhFdD41Etvk0Bid5XZgk7 g2sQ== X-Forwarded-Encrypted: i=1; AJvYcCVcIIWx3X+WBh9KoED6juqtwDq/E4skW0yWDFUxshGta7lM/dUQIYRfbDisUtAPKPU0voDd5iznKxN0wg==@lists.linux.dev X-Gm-Message-State: AOJu0YwgzTV6loq3dEsYxOxbtsIv8Iy3AUSpqBFc2vXW9WWcKJigyFs5 fPndUbi6vgGbr/A+UctiqRwAoUMpwRvAJ/eRMWDKdsZfaJdIIyJ8RszEaXE7M1o39/JppWKb3NC WpAZOVF1M4lSsdfaLRMnjqUQhqKfj78vDgEeANvcR6dysY8udYCsCN4WnpZovMEtP60bEOOToXQ mkWwhNt/7UODYwmrWjdnsFUPbdp1fiwwReE6GkHMDsGD2QLM2haQ== X-Gm-Gg: ASbGnctmPi2v9ecN6QjJQ7EWBrtD9yKi3PUpaFdbGLz6aMJELuK5WB/xbpV0LLc+46G LXWPBVk5Us2Z3LKksowYhC0X9B4PS0GhI0oQkP/+JUUBnTKh/5O3hrg/+pWbnVq3up7SaH1ammN Ej03TFhwGP87OPto4UgC4KHMIcBcx/GDdeaBxfvV2fPmhsRTEBckKE09ZUtiURpsuRwwev16FQN jHxA8sogxcchcWeijZ5TSeRUBFJxbJnWIn4LRCzIVY/be25dtYqlkwkIW3rVH5KKzfpTwZses9H YS8Ixq8Q8/h/EhEd2ODJUzfGq3DIBS2WjQCJIPATrY1IPx0nw97KXuPA1YUv X-Received: by 2002:a05:6214:3f85:b0:6fa:c22c:f78e with SMTP id 6a1803df08f44-704a3f6fd62mr2496086d6.14.1752169406620; Thu, 10 Jul 2025 10:43:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEttkcpvpmW8n4QYixl0+KFt8qbGPFK3Af/cnV1daIlslvCn8CNttD2d7VeOQXKfYZa2Tsq5w== X-Received: by 2002:a05:6214:3f85:b0:6fa:c22c:f78e with SMTP id 6a1803df08f44-704a3f6fd62mr2495446d6.14.1752169406197; Thu, 10 Jul 2025 10:43:26 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-70497d71419sm10652876d6.86.2025.07.10.10.43.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 10:43:25 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 13:43:04 -0400 Subject: [PATCH 3/9] drm/msm/disp/mdp4/mdp4_lvds_pll: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250710-drm-clk-round-rate-v1-3-601b9ea384c3@redhat.com> References: <20250710-drm-clk-round-rate-v1-0-601b9ea384c3@redhat.com> In-Reply-To: <20250710-drm-clk-round-rate-v1-0-601b9ea384c3@redhat.com> To: Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Linus Walleij , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Yannick Fertre , Raphael Gallais-Pou , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Stephen Boyd Cc: dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752169393; l=1612; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=0XNjSSy+sJ0lfEyL4cE3BgJoCrdQCRO7x73pTQQcP6I=; b=96LRUEONivujwIpqQbr8tblgDkupptPSSepp1EfUIk95IM619emUTpzW+J+hude/MQ3kCg+HA 3yXQuBUEDwkAc7M+xiKSzQ6eV9m9VE+WhiAmImR5xyYrk63QkNrzyzs X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 5X-GkF396v36SMTc5SXLv89zVfBi6vw_j6nIrNhqoOY_1752169407 X-Mimecast-Originator: redhat.com Status: O The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/gpu/drm/msm/disp/mdp4/mdp4_lvds_pll.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_lvds_pll.c b/drivers/gpu/drm/msm/disp/mdp4/mdp4_lvds_pll.c index fa2c294705105f5facbf7087a9d646f710c4a7fe..82e6225c8d491d44e30631cd5a442fb7c2de3f75 100644 --- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_lvds_pll.c +++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_lvds_pll.c @@ -98,11 +98,14 @@ static unsigned long mpd4_lvds_pll_recalc_rate(struct clk_hw *hw, return lvds_pll->pixclk; } -static long mpd4_lvds_pll_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *parent_rate) +static int mpd4_lvds_pll_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { - const struct pll_rate *pll_rate = find_rate(rate); - return pll_rate->rate; + const struct pll_rate *pll_rate = find_rate(req->rate); + + req->rate = pll_rate->rate; + + return 0; } static int mpd4_lvds_pll_set_rate(struct clk_hw *hw, unsigned long rate, @@ -118,7 +121,7 @@ static const struct clk_ops mpd4_lvds_pll_ops = { .enable = mpd4_lvds_pll_enable, .disable = mpd4_lvds_pll_disable, .recalc_rate = mpd4_lvds_pll_recalc_rate, - .round_rate = mpd4_lvds_pll_round_rate, + .determine_rate = mpd4_lvds_pll_determine_rate, .set_rate = mpd4_lvds_pll_set_rate, }; From patchwork Thu Jul 10 17:43:05 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Masney X-Patchwork-Id: 1419 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37FE42F1FDC for ; Thu, 10 Jul 2025 17:43:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752169414; cv=none; b=DM5jSwv1ZOZzdBHdGt8slu9puCNH9k9DFj8n6Kmrcjx11Zz51kuzuLt2gztITA511MEJeYAoDqaAUCzT0BXX/7rxo5OqL5YRKfifPqjjZLgwjMFA2bzvOBbQ88ATjuP5Pinig8m715tcj8uYxaWWCEOzFBWst6ukfnSYXH0tDL4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752169414; c=relaxed/simple; bh=MIrYQUA+EZpetvGrGMmQ8oMPGqbTBnNzDewrKD2iOsk=; h=From:Date:Subject:MIME-Version:Message-Id:References:In-Reply-To: To:Cc:Content-Type; b=L0OMg54NauxOYU1eRBbToFGWqX/1IRw6IDsL1/1iz3YhOxWHGzLWhuTMyX7CzJkgWNsBkmG8mmZvRCANzXCiejzdaQ0xVSCKWg1SLrq3xSlGh4wYI5dwaRXaynxlv6vK4ZzjEAeMr+HHgb2oL7jwm1kZ7vF6mniRNa+pBpWwMN4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=YWP1Zygs; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YWP1Zygs" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752169412; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ppN1Zg1KkN3TDh8kOcLfldTesCc7Q4yAOrM4kF9OYZg=; b=YWP1Zygsr1Fz/qle3MaiV4aMICxpKKd6o4Qowk1RQ1OB/gNdC63wxuoZPGexi4MI8qiI+K a1HCzcocVlpFd/u6KzHVLl8OwN53bYl9OydSLoHOLKfu11Y5DyGiz3m0EoqAguS5sp0b+n DNLj9awUktO8ve+nLvSRlGqKqLnrTIc= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-369-VIEFX-bcOVS9tWu-Z7kpsA-1; Thu, 10 Jul 2025 13:43:31 -0400 X-MC-Unique: VIEFX-bcOVS9tWu-Z7kpsA-1 X-Mimecast-MFC-AGG-ID: VIEFX-bcOVS9tWu-Z7kpsA_1752169411 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7d460764849so405839985a.1 for ; Thu, 10 Jul 2025 10:43:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752169410; x=1752774210; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ppN1Zg1KkN3TDh8kOcLfldTesCc7Q4yAOrM4kF9OYZg=; b=LFmod1aa07tUJTvBScs6NpsIhzuR6jInYOWvd2OmL+AyIAXIvhucxTYdFR9min4A84 E9c3sA+eS+PDnq0DOcGQpnRak8BGDLW+j/24UsKUXGlZWKlvfOAWdefRHIYPSbG4fjKF ie8MwhMwBLKAVoXfLX4TCcojL0VWH1HC6QzU1U01oIEOsyW6u2usgJb0WuQWmNq38Mch qA5LGURgTHLp71vu4SKWNrXOfLVYllFyB+71SPoUO7VswG0dSBCj74r0PNVLjOtm9Mbn FEru43beHgorDATz81sQmz2sFEbLq9R8mLip6Ua6ueQbr3PtNEBB+DPkTcdy0OOGuj5Z /qpA== X-Forwarded-Encrypted: i=1; AJvYcCUmBqRpmfiADeRZ9dFSx4ctmmDgWtGoXbxCYRqeP2E/dDOvf19P5gR1+4NthvsJ5W3k9/+xZbxNe9/aog==@lists.linux.dev X-Gm-Message-State: AOJu0YzLFrHSoqE7ihxTEn3m3V0GVK9VBepWB+Vn0ZXKXv+3z9jmokNV tEdr/rgCUlQbpJCBQ0y0s9Hs8x0Zs2q63XMK6wW4W5xbhULTeua9c8/J8NzgoCSeI8jY1yBQHA2 3Uqm7eTEIXex86ZU2MqwJam4z9KVYPqPjweYno+fAXbFf/UJmHJlv3ZG0SHIzVtD/k8tFWVILPV YE3Ba8ymnnMLO1FRfrdEmlcSuQCXBBzcsm/NwJQhYH/rC0EKeImQ== X-Gm-Gg: ASbGnctV2BAsYFq3ABTUu7ZRC5cncIHaYHc2yi3AIDx5a+Bban6Kh/bPJXxOz2+KiXt I28/DBD9S7TDKpkyS0KsUh1nNZqSbnWb9EYZrElzidCbQ3uSpGnX6wvbUKQL/VlBeveMZn8cO6B Y/315wR0utG3AhIx12SznNWfTvDaZHqL8fpk/XlunbhDWJE7otaJnMPbZgkoRS/ukoqZb1tb0oO yJhYkHWS0MjXLAMQzfzWRCq6jgJxXr3pE3V94k9iZy/hqahSUdo/2luhtoRPdo7vawlEnmxLnpX eDCKyyrRiwuY6K3eXh99W8grYniuQ/1V6GwcCqL0rmQYU7/+CAlqGQLMD2zJ X-Received: by 2002:a05:620a:269a:b0:7d3:ed4d:812e with SMTP id af79cd13be357-7dc97da02f2mr646714485a.9.1752169410011; Thu, 10 Jul 2025 10:43:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGtGRA59X5211+zA6+bTuLexmbhranU9s00ouhgxHCHsr1K/Q7uZzJEn/YRVuxvQ5eKEuxqlg== X-Received: by 2002:a05:620a:269a:b0:7d3:ed4d:812e with SMTP id af79cd13be357-7dc97da02f2mr646704785a.9.1752169409169; Thu, 10 Jul 2025 10:43:29 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-70497d71419sm10652876d6.86.2025.07.10.10.43.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 10:43:28 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 13:43:05 -0400 Subject: [PATCH 4/9] drm/msm/hdmi_pll_8960: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250710-drm-clk-round-rate-v1-4-601b9ea384c3@redhat.com> References: <20250710-drm-clk-round-rate-v1-0-601b9ea384c3@redhat.com> In-Reply-To: <20250710-drm-clk-round-rate-v1-0-601b9ea384c3@redhat.com> To: Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Linus Walleij , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Yannick Fertre , Raphael Gallais-Pou , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Stephen Boyd Cc: dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752169393; l=1532; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=MIrYQUA+EZpetvGrGMmQ8oMPGqbTBnNzDewrKD2iOsk=; b=xNXPieWXOwE6YijWTJ3taaQPCPf8/+I1K7+s2EiMedGqecECqqLSQTFSwjhrnG/onGaKSV32p isG7Au5aNEyCqmbZJtcC9vC7jvxXBrzxoAluzBC1poKDa0ziZwvE41x X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: q-LWaw3W1muB0aPUGzi0yAa_h72ZCRIMRb3C_uOCmtI_1752169411 X-Mimecast-Originator: redhat.com Status: O The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/gpu/drm/msm/hdmi/hdmi_pll_8960.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_pll_8960.c b/drivers/gpu/drm/msm/hdmi/hdmi_pll_8960.c index 83c8781fcc3f6e1db99cfec64055ee5f359e49e5..6ba6bbdb7e05304f0a4be269384b7b9a5d6c668a 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi_pll_8960.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi_pll_8960.c @@ -373,12 +373,14 @@ static unsigned long hdmi_pll_recalc_rate(struct clk_hw *hw, return pll->pixclk; } -static long hdmi_pll_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *parent_rate) +static int hdmi_pll_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { - const struct pll_rate *pll_rate = find_rate(rate); + const struct pll_rate *pll_rate = find_rate(req->rate); + + req->rate = pll_rate->rate; - return pll_rate->rate; + return 0; } static int hdmi_pll_set_rate(struct clk_hw *hw, unsigned long rate, @@ -402,7 +404,7 @@ static const struct clk_ops hdmi_pll_ops = { .enable = hdmi_pll_enable, .disable = hdmi_pll_disable, .recalc_rate = hdmi_pll_recalc_rate, - .round_rate = hdmi_pll_round_rate, + .determine_rate = hdmi_pll_determine_rate, .set_rate = hdmi_pll_set_rate, }; From patchwork Thu Jul 10 17:43:06 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Masney X-Patchwork-Id: 1418 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F6622F1FFA for ; Thu, 10 Jul 2025 17:43:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752169417; cv=none; b=X0VDQtaTS7qMWy6r7jsdwo34tG++7OcxNQk+LZoxgwOGa2DpS7BQU7iXsYzSp1e33oMRl+0tkD806+B6JuKlltJs6gWAKwn6WrH7r/5Q8UhYCWWirCJBXMnjqWjSWVIDrH56avy6GnPbWZ52zbS+IBmXhJe5F1epx4l/JYjfo/o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752169417; c=relaxed/simple; bh=Uzde4F/sfQBVHQNcjDIBT9HB34JjyGuqbe7jNdblqLw=; h=From:Date:Subject:MIME-Version:Message-Id:References:In-Reply-To: To:Cc:Content-Type; b=eITC6CPfH3a34sEomtTeyc6NIPYbPenCfpm0BPiTxWP8TKSghD+6UlSHh54cAIv7FHdMaqLSXEDST7OYxim5xnCw4/f6MQg8g2sjy7HLhjZT9NJG4MpKNdCiPrMbf7q+92F2yApOLjXtyX8I+QDUeId9S9aiXBC7TGontArhUQI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gguxFjy5; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gguxFjy5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752169415; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e37lSQKt1hx5PQsR5CacpUsq2th6rpfG9r3kIy+fF3Y=; b=gguxFjy5fioZkoU951CLuv0lQOU4l/gmydCN3jauKlnIPA3L7I6c24nh6OEtUN4FqPw9UQ gj189j5KjkEhfPpgUX12Ufql1/QlG4uwYQo+WJuGshtlWn38RbBAU5rhGRbqjJq8uX3zbU OZ3CNKoY2qCsIcBIkNrtD8C02bwdU8o= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-130-cU8k89OLPeS9Ae9JH2A33Q-1; Thu, 10 Jul 2025 13:43:34 -0400 X-MC-Unique: cU8k89OLPeS9Ae9JH2A33Q-1 X-Mimecast-MFC-AGG-ID: cU8k89OLPeS9Ae9JH2A33Q_1752169413 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6fab979413fso20157076d6.2 for ; Thu, 10 Jul 2025 10:43:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752169413; x=1752774213; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e37lSQKt1hx5PQsR5CacpUsq2th6rpfG9r3kIy+fF3Y=; b=RfOI3nNLjjz4wMSH+BvryG/0ZG0tHUGms/fROqw21na4TPOsEttjoXx9L28BrqCH8v I6vxtQ8iReOgjvyijDSMmP4DR8yUkAhKV4eSh5SOKSLUg2svv5TCrqLLIkSC3fqz/B/V qHJ3gl8iTmmwiYL+tVMuwbWBcr5NM+65UT+NP4iKyq5KcwXK6TFxJrbUgsoSxheYaA6l gtN0tDcitnrpSHAZL7YimbmkqESeWVtiB+YJFu6AJ2Fq+GlNwb6czQEszJK7x8E+z8DW kXUoxV5/5FBTFDMn0leVa01w1uFg48LDST6/4prQDelxiL1smS4ih/nu/wwB9LLsDrQ0 SScA== X-Forwarded-Encrypted: i=1; AJvYcCXZhHec0Z+bR5RDSRce1asHld/OA+o+DG5izOChg1sC9ncuquQ/+Cc49YROOaVrV6ZpRXveTtRGPeEEyw==@lists.linux.dev X-Gm-Message-State: AOJu0YzyCOvSEnhx3IRfc5AuawhrZ12UTOYbdC9lQqcXGkly/WR1GbhH hVvG5CefPeWOgTc7xujJpTSKj8myQH8qZNlY4/ftyXo14iqOtGck4aj6IIy2dpUZLozllSxRjRh klnJBj1+Glh/DFNU9N3BCgTiglnYIRJwgRF15splrkBXOrv215FltaiGBpoGaqMG/735EqmcSZM sL7kKNb6319UCGvN1Me+a2gjwdIuqIff/aDjtnmRRER8LcoIsA+g== X-Gm-Gg: ASbGncuaK24srqZH2/BPuDwknWemG6r1hK2C1uptUDO2cEl34+PZSziGCrGgJ1CBIo4 IP4QZoFFHOt9kG2otPRjpqAYtrUaLrf1TaRox0EknJ+Ow/zW6LQpVUBeDVDb60/U4xNdY8MvHm6 imYuuYP3R6LG+tQ4lbSEiynAZliDZWjLGlCaI5S49Lj7ixxAVLqCp7SLreaIARKKtdAf6YxSICt PPi45fhbQ9xHzIqwDRGqRG3Je19HCdh0e5MWC5hKeqds8V0pSz8SFxFEvUZz92sOc5olMQyiKF4 cRMia16izyM8yU+moFMbTMwN9MDL7PSA7e9rdrgbJk/LEhwXcHme/wcrrBaj X-Received: by 2002:a05:6214:5d89:b0:701:775:70b8 with SMTP id 6a1803df08f44-704a3a4449cmr3581076d6.38.1752169412881; Thu, 10 Jul 2025 10:43:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHpu8L3YGRW12uiQDpOxMNgeR30Y84ZsZlrx/wXIc8LbcnhH9LwZm0nYnuoy1dfBl7P78vOQw== X-Received: by 2002:a05:6214:5d89:b0:701:775:70b8 with SMTP id 6a1803df08f44-704a3a4449cmr3580236d6.38.1752169412340; Thu, 10 Jul 2025 10:43:32 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-70497d71419sm10652876d6.86.2025.07.10.10.43.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 10:43:31 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 13:43:06 -0400 Subject: [PATCH 5/9] drm/pl111: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250710-drm-clk-round-rate-v1-5-601b9ea384c3@redhat.com> References: <20250710-drm-clk-round-rate-v1-0-601b9ea384c3@redhat.com> In-Reply-To: <20250710-drm-clk-round-rate-v1-0-601b9ea384c3@redhat.com> To: Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Linus Walleij , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Yannick Fertre , Raphael Gallais-Pou , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Stephen Boyd Cc: dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752169393; l=1663; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=Uzde4F/sfQBVHQNcjDIBT9HB34JjyGuqbe7jNdblqLw=; b=0pYUMWvjxgx4WfuoWRCVGEVL5ZYYPMN0neD5N8OcfZKIHag1vghAK3SLtnfFRHjfYafmDTVi+ fTHFTPespiOCXPSLsOLNifbUMGk0HbP0Ww4Oh/+lSRoq6wnUOICkRwy X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: -IgHZc0g72alogwKqBkvbLZoAmxyfVQSmuWos7r3IQY_1752169413 X-Mimecast-Originator: redhat.com Status: O The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/gpu/drm/pl111/pl111_display.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/pl111/pl111_display.c b/drivers/gpu/drm/pl111/pl111_display.c index b9fe926a49e8bb42116ac382010829e333edbf8f..6d567e5c7c6fd559ba369a2761d3c402a14c6fe4 100644 --- a/drivers/gpu/drm/pl111/pl111_display.c +++ b/drivers/gpu/drm/pl111/pl111_display.c @@ -473,12 +473,15 @@ static int pl111_clk_div_choose_div(struct clk_hw *hw, unsigned long rate, return best_div; } -static long pl111_clk_div_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *prate) +static int pl111_clk_div_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { - int div = pl111_clk_div_choose_div(hw, rate, prate, true); + int div = pl111_clk_div_choose_div(hw, req->rate, + &req->best_parent_rate, true); - return DIV_ROUND_UP_ULL(*prate, div); + req->rate = DIV_ROUND_UP_ULL(req->best_parent_rate, div); + + return 0; } static unsigned long pl111_clk_div_recalc_rate(struct clk_hw *hw, @@ -528,7 +531,7 @@ static int pl111_clk_div_set_rate(struct clk_hw *hw, unsigned long rate, static const struct clk_ops pl111_clk_div_ops = { .recalc_rate = pl111_clk_div_recalc_rate, - .round_rate = pl111_clk_div_round_rate, + .determine_rate = pl111_clk_div_determine_rate, .set_rate = pl111_clk_div_set_rate, }; From patchwork Thu Jul 10 17:43:07 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Masney X-Patchwork-Id: 1417 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AECEE2F271A for ; Thu, 10 Jul 2025 17:43:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752169421; cv=none; b=ZmMAPfYrlHsnBAkf4MdzvwH8gVg0h8Oygm+oECgtCJFkEgoa6o73MomnKYBraqkDeDUbOJoqmz/7rq8TlP28DTr7XSc/H90P3hBftNW8o/tO8U0pj1MgSKlxDx5Fkvr6NVNtzG4Gy+dfG/Khkws7Z35MCj9yBzQ4LYawBGCCSU4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752169421; c=relaxed/simple; bh=zHcO3z3+e99osmKzMokPyvWC6/DSceppfY/05RlRXYo=; h=From:Date:Subject:MIME-Version:Message-Id:References:In-Reply-To: To:Cc:Content-Type; b=VX22cVTM6Uzpa8hTHN9DCXnexb+QUG3RgVn6eaVU6vETLAGI3pr8qL7+HN1J54iRRw4Ug09bklNfzJtX5A37AUj4hzPmiSN82CSFO/5Xc+bx4AIA/XyT/ydEK5CbBei0LBzeVuWBbeVpavwB1SWMBNaeJqty5YsZrpJQRCUUUss= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gIxkbYzh; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gIxkbYzh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752169418; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kaCFEBEkzEIEZX6+yQZzsmVx8NsnWbygGYV4RPX8K+w=; b=gIxkbYzhzJu9VXAhX0wu0qWinqNz/xR4w9iiOZTxiv+FyLatwWf3B6i73Rwg9HJFIsU6Fq XgljN4s7m+HJu5Kow/8aEnc2/vbjHtl+19UvZLc8tQCiPaobidwJYcfwVNuNY9M1W1CTq7 NWrJnlIh52wp7Z0cEjnEhOI8kby0kq0= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-651-MLZ-jWPcNpCRjcBE818iWQ-1; Thu, 10 Jul 2025 13:43:37 -0400 X-MC-Unique: MLZ-jWPcNpCRjcBE818iWQ-1 X-Mimecast-MFC-AGG-ID: MLZ-jWPcNpCRjcBE818iWQ_1752169417 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-6fb2910dd04so20320676d6.0 for ; Thu, 10 Jul 2025 10:43:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752169416; x=1752774216; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kaCFEBEkzEIEZX6+yQZzsmVx8NsnWbygGYV4RPX8K+w=; b=vex1xP8H1zLl85leepP3XNKaXjrT+GcCRgfRMzM+AEaTU1q0NBZq9MUfEpwi6eyZnZ +JGZP4o0jCDPPauhX8bDy6HwXAMIcSrmSsNCblcD46EDVt3LfiNJTuCOybWEKg7dSfqA X3s58EvWXD8re+TYUxZ3IXKEa2UP0pocZXfs2s7yT+XzVwcGS6pAe6eoUS3ZFS7/CGMa kgPXAqolIsPQQxKQaf3CsJbSmdXw0z1Wzri+dDyL6K7OMzYv44CU5Dui8h8IevfpV1y/ GgTA7ubKPF9W+w1KTgbM8YFNDCIFw6nwZhd+N1oeYS/0KXrbFkHn2ZU/9qtZ0dtxBdkw gRXw== X-Forwarded-Encrypted: i=1; AJvYcCWyMf/I6n64ogNqI67zQFW4ihZ/SqQeKRa/6vEi9ARZeiHryIZDsWlCxjvMR/0RzjUDSVQGK/Qdqw3Hmg==@lists.linux.dev X-Gm-Message-State: AOJu0Ywsb9M6r55GNULbrJI8D+i1LGl3qBJsNj3WrdHgQ1d0FB/Nt/kT K9nVlCuO9YAunP+5UoRUtCW8/A3qlMaX9Gk7IEyKdWzHHeVyzHyggLc3q0OyM11kmWn6irSHWwX Qkb84genOTSh+Bz9q5QvmX64j0yuePe6iMkvz32nTOJ5svT4OZK9hn3JtQ38EEmN7Dir1JyQ/KQ dOvYJLPI7c5j/xzk9Nro6IE9B8gVTT7lE7ArsJwl+AiP+fmJAAeg== X-Gm-Gg: ASbGncuLX2A+dfwbS6l6G6rzipkGERNGdN2rN5qyK0buXiGcBoueRvK+Y8bj6VBGCvw Qi1LEsSeBqovQQ3Ife3JT5tP1KyJulvnLoO6dMy7PjwG/XV507zIgREFykjgvzE/pzUnHtFm0Ao 14ZhfeNjmH0uxp9lXG8qS77YlUziafg0MMFb+ePa6sgJWIPdW1gPCnZ86NF8ep9XUV2pyznOswS ln6tnXz4pMmS/M2jUy9o/onXem5Z5RB+NCGyBJ1c8+EfTOIeCODualEs/ZCPCsIGWcodi0Sk+m/ W1naxx5LTWPhIo8fjkwDX/Q+xaku+sX3lepGoN5v5e+AmMIPa/QX//CC3lME X-Received: by 2002:ad4:5f89:0:b0:704:7f0e:ca9d with SMTP id 6a1803df08f44-704a3885c2emr3440426d6.24.1752169416422; Thu, 10 Jul 2025 10:43:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHSS2Rzm0JfKmIyrTldYCoa+GfaWxjePB16xygyyHje51M4cEE7holVyPZ8C5FzqtnGtvcUbQ== X-Received: by 2002:ad4:5f89:0:b0:704:7f0e:ca9d with SMTP id 6a1803df08f44-704a3885c2emr3439666d6.24.1752169415753; Thu, 10 Jul 2025 10:43:35 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-70497d71419sm10652876d6.86.2025.07.10.10.43.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 10:43:34 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 13:43:07 -0400 Subject: [PATCH 6/9] drm/stm/dw_mipi_dsi-stm: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250710-drm-clk-round-rate-v1-6-601b9ea384c3@redhat.com> References: <20250710-drm-clk-round-rate-v1-0-601b9ea384c3@redhat.com> In-Reply-To: <20250710-drm-clk-round-rate-v1-0-601b9ea384c3@redhat.com> To: Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Linus Walleij , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Yannick Fertre , Raphael Gallais-Pou , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Stephen Boyd Cc: dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752169393; l=2405; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=zHcO3z3+e99osmKzMokPyvWC6/DSceppfY/05RlRXYo=; b=QXQyVz/ESQN/1lpuOY+kiAZj2ii+/13EpYKJAuvi9VgjSVMZZp3cWkyo089YF/6/d4LrccG+3 IcOoOTC43L3AvbwBhN/wVyDOB1m1IcbEamuqRU2PQsvtkEzD5/kz2nO X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: HsqU5hXyA5yLUsgMM8JdcOWcKLWoL-acMaZKkzDNu0M_1752169417 X-Mimecast-Originator: redhat.com Status: O The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c index 2c7bc064bc66c6a58903a207cbe8091a14231c2b..58eae6804cc82d174323744206be7046568b905c 100644 --- a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c +++ b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c @@ -274,8 +274,8 @@ static unsigned long dw_mipi_dsi_clk_recalc_rate(struct clk_hw *hw, return (unsigned long)pll_out_khz * 1000; } -static long dw_mipi_dsi_clk_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *parent_rate) +static int dw_mipi_dsi_clk_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct dw_mipi_dsi_stm *dsi = clk_to_dw_mipi_dsi_stm(hw); unsigned int idf, ndiv, odf, pll_in_khz, pll_out_khz; @@ -283,14 +283,14 @@ static long dw_mipi_dsi_clk_round_rate(struct clk_hw *hw, unsigned long rate, DRM_DEBUG_DRIVER("\n"); - pll_in_khz = (unsigned int)(*parent_rate / 1000); + pll_in_khz = (unsigned int)(req->best_parent_rate / 1000); /* Compute best pll parameters */ idf = 0; ndiv = 0; odf = 0; - ret = dsi_pll_get_params(dsi, pll_in_khz, rate / 1000, + ret = dsi_pll_get_params(dsi, pll_in_khz, req->rate / 1000, &idf, &ndiv, &odf); if (ret) DRM_WARN("Warning dsi_pll_get_params(): bad params\n"); @@ -298,7 +298,9 @@ static long dw_mipi_dsi_clk_round_rate(struct clk_hw *hw, unsigned long rate, /* Get the adjusted pll out value */ pll_out_khz = dsi_pll_get_clkout_khz(pll_in_khz, idf, ndiv, odf); - return pll_out_khz * 1000; + req->rate = pll_out_khz * 1000; + + return 0; } static int dw_mipi_dsi_clk_set_rate(struct clk_hw *hw, unsigned long rate, @@ -351,7 +353,7 @@ static const struct clk_ops dw_mipi_dsi_stm_clk_ops = { .disable = dw_mipi_dsi_clk_disable, .is_enabled = dw_mipi_dsi_clk_is_enabled, .recalc_rate = dw_mipi_dsi_clk_recalc_rate, - .round_rate = dw_mipi_dsi_clk_round_rate, + .determine_rate = dw_mipi_dsi_clk_determine_rate, .set_rate = dw_mipi_dsi_clk_set_rate, }; From patchwork Thu Jul 10 17:43:08 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Masney X-Patchwork-Id: 1416 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A55D2F2C4A for ; Thu, 10 Jul 2025 17:43:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752169424; cv=none; b=sRggldySpLfcUb69irQ65nZCUduGiLiMsed0R8ArBe/tnpsAK1hxaWwhc+hF7GEO/l6VoOOr03wMZJWpZ6wcqAEwG4425cNLbmwd8boHkX8fJABqvfbF3m+II4kE2nCzalS7+vrIb7Wwf8zpcd3DQHnV1wvdPXUWRFskeNwAg/A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752169424; c=relaxed/simple; bh=QsQxnV5P1fb5ziwiaykq6XlQnnjBowQ0Qm5g74Jm8ZQ=; h=From:Date:Subject:MIME-Version:Message-Id:References:In-Reply-To: To:Cc:Content-Type; b=PPuuxU+kOqLiYIl2jIWg9YaRz9ziy6zEurrvpm4Ra0R9bTFqXoJmr48twDsf9dZNdlfzbOqtOxfBiMNyymrzSzZisZ3ugy4Os/rn8OLbclXc3a9Vbs/fwKaJUYKurN/pPCx1f/ccyT4I/5xQJVMwqYhGUStdiHOL4l1M6b8yuiY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=KrbD/Gu2; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KrbD/Gu2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752169421; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YCUkHqw4OIJFHYNlmvSZg7Gb7N9mp6WEkDCfyaw9PXU=; b=KrbD/Gu2fvGtJgy2zR1l438LVyMU4wyCcF6aL7v3Np7P2LaWs1vVicnNvnJ5TfWS0punHj GT2pQ7poa1WZVXCL6aR9pK2zaLO6SPCo3fzk5uyitlTZQ+1pGJWl9FnyxNTWCLJvIdfMSr f8yW8SswwyqdIxmrM0tyw1VezZVUIwg= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-641-BFVkrZEPOyWL_7sHcgw3kg-1; Thu, 10 Jul 2025 13:43:40 -0400 X-MC-Unique: BFVkrZEPOyWL_7sHcgw3kg-1 X-Mimecast-MFC-AGG-ID: BFVkrZEPOyWL_7sHcgw3kg_1752169420 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6fafc9f3e1bso20590846d6.0 for ; Thu, 10 Jul 2025 10:43:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752169419; x=1752774219; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YCUkHqw4OIJFHYNlmvSZg7Gb7N9mp6WEkDCfyaw9PXU=; b=wXCoOMsuZmwKHkoZvKS9oSTnoK4EQknPfGL7ND1HD68jFQeJdnhEhcgaH+3XYx0VF4 tRZr5k8PKjH1cIq+djDghfXcsdEp5rab8pLCB0DfXPBzyA0UrH7crUNV8MyEQplBbS/h J0qCbNEYDDIfN3Xwq9Hxba6wyEiV+AlUKoqMC9+KtXnMFHSwATT5HpUM2S6GaN36uXF4 NGKDNC5ospeS0fGAT5ZNAur1cYi0kGyIQLp2QOck6Ko9wEaHhaL+YahBhsDTM2WF3uao kcXxDobqDw7Y7DKR+vG8JOWXPEyXEfF1pIGq6tytma3JMjpwFtRuEnSma/hpBU7if2oX OCHw== X-Forwarded-Encrypted: i=1; AJvYcCX2h99hXJrgu0hhgT3OP6dm/MM5HIe/WdPr+ktGcMc5JYY5UtbwlDx3dblvNIJ0iM8ByTptBP06HR1XfA==@lists.linux.dev X-Gm-Message-State: AOJu0Yxhkj6j7+owTiYYL2Jscm5iRzfRjfWDyLzq8g2rKU9kAv502aBW 5lgcpG3HyiQnHYQIw2Nc4EvLqrmsgyfb5l3q+jMsFkPckjMVHnrH9e4nVDeOlDehkgMla+sSwL7 AcxIUmd3GxfeCs2yjkptLx4ahajGHsToUooBGJwSsQlhT3ptzIO9+lQtkZ+nLZSa1EhGE3G+F/i gtv1riiZqD1aGUO4YI5OvR7udhyc0PQT/1XhLbrYtcrnj6f/6ydw== X-Gm-Gg: ASbGncvYiuenYUn2LEMlBYcd9FhgkAJF1fHTHQBBU+5xeJ37hXZjsGnIlYoApvQEcK0 P65iLyuelFXn1ofNWfuByKNw95m5L4U/8epqskeZxHJTdaTb0MHc1sqkxkIJGxm+hyDXQHHmWEo oP8yHf905nSZlhcUXKL/j+WE8BEP/Mar54pa/clNXVHdWsB3qO+m4tjgFDOrVb/x9EhaCKmw8XP U7mFu6ZEPrVNMGCcmVFsgrwwNvPthC/Z2y5i5SAWAd7n9K+tFgHeMsdZdVjQlGh/jsj8upRbyuU RSzM2Xa3e93UQ7bdHBOBOo+2KegL306HtWDSVkOW/kHFebSk8OMwtwu+5Dl0 X-Received: by 2002:a05:6214:5883:b0:6f2:c88a:50b2 with SMTP id 6a1803df08f44-704a354cf6bmr4070286d6.3.1752169419358; Thu, 10 Jul 2025 10:43:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEHT9fVCmhXOEcnhqu3VFHhqJP8lRdJ7DzuHPSbjh7k32ODCAsPCUcL2Z7QyeRoPgckrF6a+A== X-Received: by 2002:a05:6214:5883:b0:6f2:c88a:50b2 with SMTP id 6a1803df08f44-704a354cf6bmr4069566d6.3.1752169418934; Thu, 10 Jul 2025 10:43:38 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-70497d71419sm10652876d6.86.2025.07.10.10.43.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 10:43:38 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 13:43:08 -0400 Subject: [PATCH 7/9] drm/stm/lvds: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250710-drm-clk-round-rate-v1-7-601b9ea384c3@redhat.com> References: <20250710-drm-clk-round-rate-v1-0-601b9ea384c3@redhat.com> In-Reply-To: <20250710-drm-clk-round-rate-v1-0-601b9ea384c3@redhat.com> To: Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Linus Walleij , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Yannick Fertre , Raphael Gallais-Pou , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Stephen Boyd Cc: dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752169393; l=2097; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=QsQxnV5P1fb5ziwiaykq6XlQnnjBowQ0Qm5g74Jm8ZQ=; b=Ksw8mIL+2RRN/KI5dE4mx3sGUsPAEzJtg6FBiWBslMJaF5i+drzv8/2cRkcR9a0IBfQcYS2SG tVJ/WPvWyYACv81xH4ZsEZ5zwtnc4MB29saRvfEdAfzM+LmC3xps5M8 X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 8ibnqCsturQ-w8pZgkRVlm9dGgD4JDSqTUc37C1L3ww_1752169420 X-Mimecast-Originator: redhat.com Status: O The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/gpu/drm/stm/lvds.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/stm/lvds.c b/drivers/gpu/drm/stm/lvds.c index 07788e8d3d8302a3951e97d64736b721033998d3..fe38c0984b2b552e1ccaef4d1e589b9d86a40ee3 100644 --- a/drivers/gpu/drm/stm/lvds.c +++ b/drivers/gpu/drm/stm/lvds.c @@ -682,8 +682,8 @@ static unsigned long lvds_pixel_clk_recalc_rate(struct clk_hw *hw, return (unsigned long)lvds->pixel_clock_rate; } -static long lvds_pixel_clk_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *parent_rate) +static int lvds_pixel_clk_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct stm_lvds *lvds = container_of(hw, struct stm_lvds, lvds_ck_px); unsigned int pll_in_khz, bdiv = 0, mdiv = 0, ndiv = 0; @@ -703,7 +703,7 @@ static long lvds_pixel_clk_round_rate(struct clk_hw *hw, unsigned long rate, mode = list_first_entry(&connector->modes, struct drm_display_mode, head); - pll_in_khz = (unsigned int)(*parent_rate / 1000); + pll_in_khz = (unsigned int)(req->best_parent_rate / 1000); if (lvds_is_dual_link(lvds->link_type)) multiplier = 2; @@ -719,14 +719,16 @@ static long lvds_pixel_clk_round_rate(struct clk_hw *hw, unsigned long rate, lvds->pixel_clock_rate = (unsigned long)pll_get_clkout_khz(pll_in_khz, bdiv, mdiv, ndiv) * 1000 * multiplier / 7; - return lvds->pixel_clock_rate; + req->rate = lvds->pixel_clock_rate; + + return 0; } static const struct clk_ops lvds_pixel_clk_ops = { .enable = lvds_pixel_clk_enable, .disable = lvds_pixel_clk_disable, .recalc_rate = lvds_pixel_clk_recalc_rate, - .round_rate = lvds_pixel_clk_round_rate, + .determine_rate = lvds_pixel_clk_determine_rate, }; static const struct clk_init_data clk_data = { From patchwork Thu Jul 10 17:43:09 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Masney X-Patchwork-Id: 1415 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F049E2F198F for ; Thu, 10 Jul 2025 17:43:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752169428; cv=none; b=vDZcFnoO2IUfqbxyFBZp0DDNRBtK+xsw6gVTuW2LpwNfKsC91VF5D8gvB4cJeIu/h55+y2Esei9TOpjy3kb7JP6kUMu8863HF+Yi2wfSmG3OcAlZd5rBetC4Cfndu0JLHn1bYLdKifd8Ex2TNbUOH1vFM1IaOdodlbCOJXRAmbI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752169428; c=relaxed/simple; bh=OHsRnwsdtf93oenlkpM8OGpjPNCqkqTYz1ncE/Hukgk=; h=From:Date:Subject:MIME-Version:Message-Id:References:In-Reply-To: To:Cc:Content-Type; b=LJA9c+D4RZK0PXMcdcvJ3vG0l5YaQVqNBkDdQtZ2rbJCFMx32RTtb/AWEHN1u+en8vvz5aVG7bRK3EnpUg4nxNdbKk6VKn2qdPkeWMAs9TFnDbiVI4bVjiz41suunS7nihkKXDzYITFno2USXkdTIJIjHLsbEMbc4fa9X0a6LfY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=FNh7qlXD; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="FNh7qlXD" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752169424; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=exSjMafszsHf+hPI+jA3EKbDPNjmXxeN/VchItvqKMU=; b=FNh7qlXD6m2QLcZ3QRT4K5kIxg92JTM+rUjeJk25DvzaNoB/evf4izVsHdYE8cqlmUJqOq yiRnOq67x67x4T2EwgevrqcJJHL56py6c0HPE9dmZBN21DAgRpOBHaW2qTO/4ta4i+gN4K dlNe6TpPpmEbjjMS2z/n9CJsbSfV2lU= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-578-kKLHKTI5Pae-F_3aAAKEyQ-1; Thu, 10 Jul 2025 13:43:44 -0400 X-MC-Unique: kKLHKTI5Pae-F_3aAAKEyQ-1 X-Mimecast-MFC-AGG-ID: kKLHKTI5Pae-F_3aAAKEyQ_1752169423 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6fb5f71b363so20704516d6.2 for ; Thu, 10 Jul 2025 10:43:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752169423; x=1752774223; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=exSjMafszsHf+hPI+jA3EKbDPNjmXxeN/VchItvqKMU=; b=ByWKI+xXfvYoRmYW/oa0eGIr9WQ1yIHP1AaWpfcXLrpL1OH2M7DyfFqxRCHBDJrDHK 1L4I6awC+RjdnAztdBVW68f4TTKULZClTr/r13NUlX4nr3xwk+1lwOnANsvpDs/SAdcl XHkl/hsp+ojBS8tOp742ifntvBGrti+dMb700d/+4qo6SbSBPeHinF1H2G9yAnfEqjmI nVhOsrifMcSnU903C310Lm2A0lCWzf4s/KjdQDpu7UmfzQ9d4kpsoS/CDo7K6Pywdz3K +0kCYOixB4kSu8jwuzs0ciSYmGrLz2ePY68x6Iw3U4ChCmDgBXG2guJyQWiwLa5BvWD/ eb8w== X-Forwarded-Encrypted: i=1; AJvYcCVUcz95Oqg3qDfQlUtb+G1bqeTZgmi6zy9ozd6rhczG0Gl+B+s5vmVpsqzsyK+qoVED74DJ3X+2ax7akw==@lists.linux.dev X-Gm-Message-State: AOJu0Yx5KpGAh/bqFDShzkVbREG9QhHY4q4dLduKeG3dLaHi0KypdMj1 HpQ4ytl/STNRHW4Uog3+0DAIVbDm8SDDaBXV8EdxkwRwp8uLhutXkCqx27uWsa7xFGmf/rYj0iE GpTiQPxJeeOjm8jLhDoh9lSiMMrVQtGCzePmTLymt979HZr9MuAdhiIhNW9cWRy4h2ZP6CHGkVn qOnUbQ4HBKNdtVr/jMTRPqTTpmynWSyxQdDHQvkhAYQ1vHj711YQ== X-Gm-Gg: ASbGncu9Msjtb9ItTZhG2auZciAiTMC1a3zn8j0I2R+s+Bo6et6UJarwQeVu1GK1NJd u2YytZSsjrm0ijbXp2VYz/FmlAyo35180Eb5IOdQojonAy8h9s0VH1XEJn05doxRsWK/Cj3Gkg/ O2cPWoBuEFcZsX7GSnTBXnsy0SPn8NeplkYYW818qs+I8YhHNKOBud8bthhg+Lb+2irFf72nVUg U79ETgvWkto8XljpZOuQ1SeEafns6/RHxC5/rDU/NGv96CcWb+SlvOmAm+6KE/5TMmM7WaAKmhJ U6Fb0ez47hUeeniG58sDt+ylsAeMIXMUd3O7CPA9GwPhP7ZDikCFBS/omF2q X-Received: by 2002:ad4:4eab:0:b0:702:d7e1:9a61 with SMTP id 6a1803df08f44-704a4325359mr1692976d6.32.1752169422916; Thu, 10 Jul 2025 10:43:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE946PzHD0RXk4GY5dDiYIFHgj5udxSitTpswAFFe0EalaGRnpP5sdgmvG0/oOdFa+px1bfeQ== X-Received: by 2002:ad4:4eab:0:b0:702:d7e1:9a61 with SMTP id 6a1803df08f44-704a4325359mr1692226d6.32.1752169422349; Thu, 10 Jul 2025 10:43:42 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-70497d71419sm10652876d6.86.2025.07.10.10.43.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 10:43:41 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 13:43:09 -0400 Subject: [PATCH 8/9] drm/sun4i/sun4i_hdmi_ddc_clk: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250710-drm-clk-round-rate-v1-8-601b9ea384c3@redhat.com> References: <20250710-drm-clk-round-rate-v1-0-601b9ea384c3@redhat.com> In-Reply-To: <20250710-drm-clk-round-rate-v1-0-601b9ea384c3@redhat.com> To: Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Linus Walleij , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Yannick Fertre , Raphael Gallais-Pou , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Stephen Boyd Cc: dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752169393; l=1647; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=OHsRnwsdtf93oenlkpM8OGpjPNCqkqTYz1ncE/Hukgk=; b=ho7GtAWEeFJp5Ux6aTEtHmHkJKzsUOAKpGEfNDI+F7l5XbF1qK2v1eRvTIse1y82RTcxYpTS9 vSPNZAJFAqpDDKhg/zIW7SbizIxqSMy8J+QnCYzoa0xmplhJw/HPvrO X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: gEIyn8v58qjvcmfPSjbFcP8tgEtMhYibfyjAHwQc_DQ_1752169423 X-Mimecast-Originator: redhat.com Status: O The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/gpu/drm/sun4i/sun4i_hdmi_ddc_clk.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_ddc_clk.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_ddc_clk.c index 12430b9d4e930f7e7b0536a5cabdf788ba182176..b1beadb9bb59f8fffd23fd5f1a175d7385cd5e06 100644 --- a/drivers/gpu/drm/sun4i/sun4i_hdmi_ddc_clk.c +++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_ddc_clk.c @@ -59,13 +59,15 @@ static unsigned long sun4i_ddc_calc_divider(unsigned long rate, return best_rate; } -static long sun4i_ddc_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *prate) +static int sun4i_ddc_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct sun4i_ddc *ddc = hw_to_ddc(hw); - return sun4i_ddc_calc_divider(rate, *prate, ddc->pre_div, - ddc->m_offset, NULL, NULL); + req->rate = sun4i_ddc_calc_divider(req->rate, req->best_parent_rate, + ddc->pre_div, ddc->m_offset, NULL, NULL); + + return 0; } static unsigned long sun4i_ddc_recalc_rate(struct clk_hw *hw, @@ -101,7 +103,7 @@ static int sun4i_ddc_set_rate(struct clk_hw *hw, unsigned long rate, static const struct clk_ops sun4i_ddc_ops = { .recalc_rate = sun4i_ddc_recalc_rate, - .round_rate = sun4i_ddc_round_rate, + .determine_rate = sun4i_ddc_determine_rate, .set_rate = sun4i_ddc_set_rate, }; From patchwork Thu Jul 10 17:43:10 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Masney X-Patchwork-Id: 1414 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E29722F3650 for ; Thu, 10 Jul 2025 17:43:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752169430; cv=none; b=RG8v8Dk7jHt2Ctd6yKmeOGUpEbaf3+8jgBVAi8aJQRQqNSY+E/jthuChG7GzGxcw7Psrt9hG9JqDqCOriz7vI/JeG+ZclteBN+/GR4wctyrVUIzf+bwR7W9WPGyqUvC0Q9sAW1KO7HuxIZ5z3imwkE56qu0AOaRDfRUNXG5oCQw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752169430; c=relaxed/simple; bh=xPkagiW22ryYRgcFeUxKsYb4R3sx64zzzkaF7TIS6rk=; h=From:Date:Subject:MIME-Version:Message-Id:References:In-Reply-To: To:Cc:Content-Type; b=bjAh+fK3dkC+Ke2MlEdhLewfibYy/E8LnHxLtB003car3/7mvHZANC/Cs78J/bvDz9nrbkpvcBCEc5k8G2n0d/wYtGSQoUt4m6cLo8xRcTJsu3LmAuIb5WbYNQw2LbkmtcvJR7FXgAq7bBngizHnPqOJsKrOjkiLfKH+HlErkWg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CVkJlQG7; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CVkJlQG7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752169428; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/OrtVi+H4smani+Wxuj7rrrlvdLEKHZeWuJz/QAEtZ0=; b=CVkJlQG714UADmX6KjfDY3onJpl6Bvagnas2qAzUUQyLyfUzq0f1ABJS4kppAa714703Bg GV0HEcVO77oL2f/8Q7yN5/cnB+PKIli7EA4KNZCNJCMkSqqpW42/5Y4fMlZ/iZ6vJnwj0N X/Uq3Q/YGqbLkeQOujMcMbT0RMl5Oy0= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-644-vLKS5iPQOweVxHYBjGRNCQ-1; Thu, 10 Jul 2025 13:43:47 -0400 X-MC-Unique: vLKS5iPQOweVxHYBjGRNCQ-1 X-Mimecast-MFC-AGG-ID: vLKS5iPQOweVxHYBjGRNCQ_1752169426 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6face45b58dso19844486d6.3 for ; Thu, 10 Jul 2025 10:43:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752169426; x=1752774226; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/OrtVi+H4smani+Wxuj7rrrlvdLEKHZeWuJz/QAEtZ0=; b=GHm/iiFR4/R2jxbmh7lDVfV7qt/wRTiKVH4HRYob1E1GvdehOwvsHnH/w5RCEe5U1w JohUp0FzmDP+V00E82BuJEl5LqPg/Xis0VbuQgIr6Uj9CxWtKyFCJHL5akZLkQ9sQQIR pGJ9+PtU4idpNcOwBKNhya3mOA+DpB6RB5NVVNrffTZHjdtu5oaq4Pb6Bjcb5JzCMPQg qiULPLSShK6eJISMJDa4L6ib2Wg/i76+CKhhsvUC9N98lsT57o+AX4i0aB7wW+XrAJh3 f/M5asT03DFhW/nK3vYG4P+0nwrY1hAVw1ulPlon8MTLrAn1NKQC9o8kC/o8mg70YkZI Y0nw== X-Forwarded-Encrypted: i=1; AJvYcCVa1OhadK42B3gzcPWsOxPZqzskBIwmkN9V4fkRtMQVjWgVfUQFyxXtC2/p7rs+gvD83KpeE01xMzTUbQ==@lists.linux.dev X-Gm-Message-State: AOJu0YzaEq/D7HSg8KmJ9/0xqMIjyhe6BLIf5ek8AbaK7Hqr4/KK4oXe KoKgL6J4KRhMoVgVsN1QTsYElazoz4SaGu1E6mnX8kjyy2/ECq0bYpfpdNLkJ4BqLIHBbsJf0+j GLGx0DvorF2zqIz+CGHsSEgTqtfuW7ZYM/brR225QG03JzCaUUMIAvHTodLoKQTG6V3mik40iJ5 aFk/qQqYK3AlsKGK8HlA0z3g++0ONQpQmqQgcY7fnYTu2JrTOHeA== X-Gm-Gg: ASbGncv11JI/CMu9F8r9Fjer19saGspnhWh4Tu0mWYJuR2ZEzbKUAmKt4mHRoMG2Sjq F0lPlXQsmtbTD4bXQzMpRCt6Aot0vup/+eVg5ytUnG6g1ZadjzLc4SGflUg6DI7QixqhN0WmpiY 4r6BGLAI3rFyrN7x43uOe9q8DKHzIWNm8SFzcRsG2IZfMxCJ9MfrJMoXChO8Muyipo6ideacnKg KlwIRl2bRQ6nSO12jlsexU7iKflMQ4QH7KG0hlcaLuHIAkYz2LUFhgREESIS6krMD9DO2X7nUcC yHhEiHUzt/uJLEPjVk3wKptf/R5kwmMtxjk+EDyMCEUwLrIWqJ+ttC6Dkz+8 X-Received: by 2002:a05:6214:5d0a:b0:704:9bc2:be36 with SMTP id 6a1803df08f44-704a4083bcemr2613926d6.7.1752169425857; Thu, 10 Jul 2025 10:43:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGxO+/+2HUAUPTiUYztt/lC4Yi0Q22OZoIfFBMZk64H2H2sqirYgZh1L3qOGgIkQVmmCaX6kA== X-Received: by 2002:a05:6214:5d0a:b0:704:9bc2:be36 with SMTP id 6a1803df08f44-704a4083bcemr2613296d6.7.1752169425386; Thu, 10 Jul 2025 10:43:45 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-70497d71419sm10652876d6.86.2025.07.10.10.43.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 10:43:44 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 13:43:10 -0400 Subject: [PATCH 9/9] drm/sun4i/sun4i_tcon_dclk: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250710-drm-clk-round-rate-v1-9-601b9ea384c3@redhat.com> References: <20250710-drm-clk-round-rate-v1-0-601b9ea384c3@redhat.com> In-Reply-To: <20250710-drm-clk-round-rate-v1-0-601b9ea384c3@redhat.com> To: Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Linus Walleij , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Yannick Fertre , Raphael Gallais-Pou , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Stephen Boyd Cc: dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752169393; l=2262; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=xPkagiW22ryYRgcFeUxKsYb4R3sx64zzzkaF7TIS6rk=; b=l1P9iwEOFZ7iseMUGqrDwyTv1j/GS/74kLm+7ZgYbXOn1R2j8JwTxirCensojfrRCiquhbnNY RQW74FdbQM8B7MkeQZA7rAthmyuLBvNMin91wee7+2bXtn9fga4VsSS X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ne6KGi_EexP9TZTfkS8Ns0Zc0QsVX_9ZRuLNAKLpbWw_1752169426 X-Mimecast-Originator: redhat.com Status: O The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/gpu/drm/sun4i/sun4i_tcon_dclk.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon_dclk.c b/drivers/gpu/drm/sun4i/sun4i_tcon_dclk.c index 03d7de1911cd654f395ea85ad914588c4351f391..9b85bf512d4c81d0a12e8cf726d5d5440343519c 100644 --- a/drivers/gpu/drm/sun4i/sun4i_tcon_dclk.c +++ b/drivers/gpu/drm/sun4i/sun4i_tcon_dclk.c @@ -67,8 +67,8 @@ static unsigned long sun4i_dclk_recalc_rate(struct clk_hw *hw, return parent_rate / val; } -static long sun4i_dclk_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *parent_rate) +static int sun4i_dclk_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct sun4i_dclk *dclk = hw_to_dclk(hw); struct sun4i_tcon *tcon = dclk->tcon; @@ -77,7 +77,7 @@ static long sun4i_dclk_round_rate(struct clk_hw *hw, unsigned long rate, int i; for (i = tcon->dclk_min_div; i <= tcon->dclk_max_div; i++) { - u64 ideal = (u64)rate * i; + u64 ideal = (u64) req->rate * i; unsigned long rounded; /* @@ -99,17 +99,19 @@ static long sun4i_dclk_round_rate(struct clk_hw *hw, unsigned long rate, goto out; } - if (abs(rate - rounded / i) < - abs(rate - best_parent / best_div)) { + if (abs(req->rate - rounded / i) < + abs(req->rate - best_parent / best_div)) { best_parent = rounded; best_div = i; } } out: - *parent_rate = best_parent; + req->best_parent_rate = best_parent; - return best_parent / best_div; + req->rate = best_parent / best_div; + + return 0; } static int sun4i_dclk_set_rate(struct clk_hw *hw, unsigned long rate, @@ -155,7 +157,7 @@ static const struct clk_ops sun4i_dclk_ops = { .is_enabled = sun4i_dclk_is_enabled, .recalc_rate = sun4i_dclk_recalc_rate, - .round_rate = sun4i_dclk_round_rate, + .determine_rate = sun4i_dclk_determine_rate, .set_rate = sun4i_dclk_set_rate, .get_phase = sun4i_dclk_get_phase,