From patchwork Sun Jul 6 09:58:05 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 1448 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE0121FBE9B for ; Sun, 6 Jul 2025 09:58:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751795898; cv=none; b=CfZ9JVPTl3HHSqvsQtQCpqhUCjnYkWlq2u8O988dALectkXReUhY84d+C7bJKvczbNuCpGR4LeWYUR56AT/INCxab2lG3kXyrAcwH1CItEJ2SfWYymES+zpxYVeCmVPfzTWP1FsDJi6lSxuDyBiL/HBg8u5vgKp7+Hk1tt3/Bvc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751795898; c=relaxed/simple; bh=xEkFef12nFlLIernh+CF1AUuIuQaso5KF89j0Sbippw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=mTBuHphdBeyCyAXYXSfguQ2RmQOdMD2QUSwU1G0c6BE94EG2vS9oF4xYnQBQPnzklZy9Eg5pXTRnQS61Qas/jH+HkW22JjsqFN4VdrefzylA2zPR0cH9lmPGnzTyi/ElL4s+J1grBwvaRSZh/HMb01tzMrfl6aG0tGws7Jn237g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=YlGPExNU; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YlGPExNU" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-3a4eb4dfd8eso357760f8f.2 for ; Sun, 06 Jul 2025 02:58:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751795895; x=1752400695; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=rLJzcUMiXBad4V8OJNPvhYHlVWs0EasjPm7tIFAml9w=; b=YlGPExNUSU3ofaONBH24PbQK23c7ns+K0mbcUPVwHfyWzHHpMgDQ1DRj/MerprDY8Q dB05dX0E+7Qf0s8m97qNGCQFC8sR2oasVRVFE6sNOP/QB85aciGAocM9Y7q2/ECZU8sT SSMXJ37hr4BU7ysWSnatFNRGKepjEnwKWF3Peefk5Cu5TOKRVOmvSTIcoj1LxePo1pWV 6qisJAvZjtatVxh28CHqI400k65FYYudHNI+Reete0m3NN4lVcqyOBr2dHQNhc+6SH6n E29xoHg6ICJJAJ9ZjY1FSmzRpYWP6wdm9/XV/799SMVxs9RDoc/BqvKSGoxNvVFSABYS nBTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751795895; x=1752400695; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rLJzcUMiXBad4V8OJNPvhYHlVWs0EasjPm7tIFAml9w=; b=tjGr9LLG2HzTLZ/mF1ibK/BYzAd4XAge1lBDZCR2N8vGhhGoQNFMZrX9vzzEl+uyFO 3h5zWsJliqTXw/tHZKLnkuezaLau2Ro6bQKLkwJ4wRG+9XNwonIQV8nY2zS2z/tecEJ5 xFfxnf58ZFtsVkgvpk5Cxt9KBw4K86NG6yYRf5Jq7Ocdm85yIZ32FQtRCjflzl3GZYyv xiAShh8Re2hZXZriJjPK8Q04CE8vWXxmFtb/d68FuFGRywznjxX5/jmpMSN2vgD7y19E kRneHpLA7UTMTqV4EkOGGekA9Haso6kw69u5DIc9+bWUJ6ggI8KA8PC0S2vPNSBXq/uk c2qQ== X-Forwarded-Encrypted: i=1; AJvYcCUOMyotVYFuagvRwt71AEFHbIkBszPiQcfq2vo2WINPaUp/Yn2CZnmVyWPRnJ1PaTJ26TZKXe2IH0lBog==@lists.linux.dev X-Gm-Message-State: AOJu0Yw/JfawrWChaVJxgtJ8qhb4nm2Qq/53Do8FtnqlrrdRk2iqdCp/ gFAxxriL/ldzIPNrmXcWoVZ7Vp2jqMSZ37JqWQz6gEzi4XDTgu94eLrWw/WZOW0rZhs= X-Gm-Gg: ASbGncsUPcXZqF2eAEmhxvap9ZLYVgVFSOSjblREld3YSPRfDeX2VIJMfzRst3m9ilo ZH3DHW78JtFWlxE6uyoQXVq1MgoV1Gehwdo5idD//d71QbAPeWDVNLMd7h7blyW/l28+8d0SIn4 QJQieLt9WcR39apLGMeregAtzoabh3YwpRHTLLLmkKvyiHjUn6F00jZ2L/xyiUb2mQPknl6J3YI cqhJ21DNZC19sLiH/qpBj60c2hRZghpjZZ6pN39Igm3uz8Y2CcpAG8U89poqtkIgytBlxBdYkDw JX8BrV0z6TX9fsNl2bNH/t43fNK+NqGSTmXXFmykgvzlzyUB9CLVDD05gRxKxUPWj/WbkvKXNYo = X-Google-Smtp-Source: AGHT+IF4Ul/n9fVhzwVBg+BkNmoc/enxNYd0kHRns4nCK3XCzT0Bu7DVEcYAKqiVo/IOvxaJHXGIXg== X-Received: by 2002:a05:600c:1d1d:b0:453:7011:fcdb with SMTP id 5b1f17b1804b1-454b35ee163mr29792145e9.1.1751795894893; Sun, 06 Jul 2025 02:58:14 -0700 (PDT) Received: from krzk-bin.. ([178.197.222.89]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b47225a642sm6999179f8f.80.2025.07.06.02.58.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Jul 2025 02:58:14 -0700 (PDT) From: Krzysztof Kozlowski To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Maxime Ripard , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , lukas.schmid@netcube.li Subject: [PATCH] dt-bindings: arm: sunxi: Combine board variants into enums Date: Sun, 6 Jul 2025 11:58:05 +0200 Message-ID: <20250706095804.50475-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2657; i=krzysztof.kozlowski@linaro.org; h=from:subject; bh=xEkFef12nFlLIernh+CF1AUuIuQaso5KF89j0Sbippw=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBoakisY7M+9sD/W82rRJY9pnJ5W32Esc4uTl7gm diY585f+f+JAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaGpIrAAKCRDBN2bmhouD 13dcEACUhoM6D4bSGQjt2Ey7hYNh3NNu0aL3b1bop290qElz/yIWyx/Ed7e0ir4nWCGwfsSep/M q2UTunPLsBVwyCrIMDKY2gbsSwXz4i1KRfYeyRvBgMnsju7yaMGTJ2mjuNYexZ8XshvNg2DruMC ku1hpslsC3Sl1kfBnUWNWh6qyp0ujEltp7l0nV1usgwgDJU/FmgIgdQN586f7kQz07gc52epvKJ sOJqc7NYwntKKe2x9K18tPjcbX91tm4tpymuj756Fmw0waFuj5kfWxcvYUXTsOdXJHQ2Tgef+9u BqDLdnRYNnYXKjZ7RXernj+KGF3tWbDRk1+y+gTc0omR0gN6EFNL/9LzMn1imJj8umAs3ckxsMg nPFM+rHKIJ69dhINz47oVGYY3U7wG92WOVeNbDHHqDofmE2d0r4H6JhTpyL6xWuFyUX19Uk9YQa D/lhMQDim1MckV+sJ6durjiVvlKZAfqyanVh1mQJ6vK3j0NtqPaaEJTRRAgmVLin0Z0vrnVPVzb eyXdwKOEG7mv98I6Mt4t0g9ygbLmFUGb4bxjyfc9CVAyDIshCvT+JhEpL94RrP5HZ/3fwt6Riub pXjVbsVl+tGtDeeGemxDwWQ9y/QUwA1GqYpgnRo0QG5bgczyBU/3uy46LYEncGTnv1vjlxzuzKS 0O1UQ0NuNdsN6KQ== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Status: O The common style in all bindings for enumerating similar variants is to use 'enum', not 'oneOf', so all boards of same variant or using same SoM should be grouped under enum. It is more readable, more compact and makes easier to find actual devices from the same family/type. Also there is completely no point to repeat the compatible in the description (incircuit,icnova-a20-adb4006 implies this is "ICnova A20 ADB4006" and pine64,pinephone-1.2 implies "Pine64 PinePhone (1.2)"). Combine two easily visible cases: ICnova A20 and Pine64 PinePhone. Signed-off-by: Krzysztof Kozlowski --- Cc: lukas.schmid@netcube.li --- .../devicetree/bindings/arm/sunxi.yaml | 31 ++++++------------- 1 file changed, 9 insertions(+), 22 deletions(-) diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml index 7807ea613258..f10c6ee6a0aa 100644 --- a/Documentation/devicetree/bindings/arm/sunxi.yaml +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml @@ -341,15 +341,11 @@ properties: - const: allwinner,i12-tvbox - const: allwinner,sun7i-a20 - - description: ICnova A20 ADB4006 + - description: ICnova A20 items: - - const: incircuit,icnova-a20-adb4006 - - const: incircuit,icnova-a20 - - const: allwinner,sun7i-a20 - - - description: ICNova A20 SWAC - items: - - const: incircuit,icnova-a20-swac + - enum: + - incircuit,icnova-a20-adb4006 + - incircuit,icnova-a20-swac - const: incircuit,icnova-a20 - const: allwinner,sun7i-a20 @@ -760,21 +756,12 @@ properties: - const: pine64,pinebook - const: allwinner,sun50i-a64 - - description: Pine64 PinePhone Developer Batch (1.0) + - description: Pine64 PinePhone items: - - const: pine64,pinephone-1.0 - - const: pine64,pinephone - - const: allwinner,sun50i-a64 - - - description: Pine64 PinePhone Braveheart (1.1) - items: - - const: pine64,pinephone-1.1 - - const: pine64,pinephone - - const: allwinner,sun50i-a64 - - - description: Pine64 PinePhone (1.2) - items: - - const: pine64,pinephone-1.2 + - enum: + - pine64,pinephone-1.0 # Developer Batch (1.0) + - pine64,pinephone-1.1 # Braveheart (1.1) + - pine64,pinephone-1.2 - const: pine64,pinephone - const: allwinner,sun50i-a64