From patchwork Thu Jul 3 23:22:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Masney X-Patchwork-Id: 1481 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 490742DBF45 for ; Thu, 3 Jul 2025 23:23:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751584989; cv=none; b=g15nMhMYkaYEy2+9hc8SUXWb8DHznfTA2G66gPl6UATdmt5eJy4ROXE5nHjK3IugeEuP/gCYZIAcVykoaNP4Egv8wbi6CUebD8NPDFVLbEB0TUO2nWqZ8yOyNVO5ru8qysGGHPUpKllcOeBesFg0joligTJauDphaXDnNftgsPY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751584989; c=relaxed/simple; bh=bUDrRrVU7cuzvOkq/BXSXRrTOJz73kF5fGj8HK4w53E=; h=From:Date:Subject:MIME-Version:Message-Id:References:In-Reply-To: To:Cc:Content-Type; b=VBIEc0qkC8qmiAVfAdFSi6nKn0cPpLZtxzj6NP3iWbqavXgvi1eA5YvkHCU+bS+fUIpQbANaNjnJndzG/ACU5/hWvwsrG+WPFHUQ1PdGatffIBCgTUfQB9fcroFc9Obr0s+PEWhYkHOBpK0yv9yeJSUOqF44tya6IBPuL6e+9nQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Gk1cZV0G; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Gk1cZV0G" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751584987; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Zb0t+bPuMy487CsPpINgg8YqC+3JQLKvQYW9mEqLvWM=; b=Gk1cZV0GikT/ki7nTyJCDn9BMAugT5HYGd6YZ9XWPaeUmAAC6i6CiS+qMe1PWhTJlVg4bW uNidOneClAPnq0Nzdtu346Iz6j5fbIvRMAz7+BeJAuBQpiy7VCkI6pV13lpRVmKZcaammc rWHv2C7x2N2JA/cMU460Ph/OH0tH7GQ= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-382-_Ev4-irIPqa2OotRsf2iRA-1; Thu, 03 Jul 2025 19:23:04 -0400 X-MC-Unique: _Ev4-irIPqa2OotRsf2iRA-1 X-Mimecast-MFC-AGG-ID: _Ev4-irIPqa2OotRsf2iRA_1751584983 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-702b5e87d98so6208866d6.0 for ; Thu, 03 Jul 2025 16:23:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751584983; x=1752189783; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Zb0t+bPuMy487CsPpINgg8YqC+3JQLKvQYW9mEqLvWM=; b=VwWb3Nn5ykfvWA3NdbBD8jehfn21i/uxEpb1+2koHpLeBFMJo/cwW2LVzBV3mfQ377 dP9FXMqmjzIWYtdBx//FiUvZQvi7oktKRO0Xed1Xwdc9noA+eqC9J0g8vdHRMw2kn51+ 2SGSvOyNndqXUNlXXZEKSlYfqEVheyU4GcQKYYimyTigK2Ay4hp8JBB3sxZ06f3sMfm3 rpMavgtZRbGdf54pEw/oXruDSCe0tp9TTi4A4OQOjnT4XWuENuRF5yKRMqaviu7SStO5 WxPJv6IKpF4H3xzj3+6qCR3etgunbcsgb6UmD3p+fngoGT0/5aXx7T5HSDHSnf5+hIgI 3MrQ== X-Forwarded-Encrypted: i=1; AJvYcCX/S9cQXPeQKW8IsCK4qBRDQwgk5YVigqTCLj+McerQwEA7obSCklzqsso9T8HSgEZBEGr4QywQAvu05Q==@lists.linux.dev X-Gm-Message-State: AOJu0Yw+QgW4BofpuBCBBedoBOp5BcvN7LO5VVedupZoVPPzS+HmWdOm iq1gxGfW1EjPU9gyf4Zg5N5vzWsIPDZzQdWHAzjcFIFC2Ns+E0Nuucvre0eyHXaA3YzLYZXv0ju +rXRAstCn766LztCVoGlY9bIVmNwPY4n2FTld/pCpq2bCZ0/bKN2lFV1Q/C+WAbk3 X-Gm-Gg: ASbGncv5Q6isNJOp5iErEw784QkYrduEJ1qafxGqpCCobGbPy8UO+D8a9fAcYnrO8tP 9SvJPKhUSFRc9ezZyTAABS6i2+0oWutRCHGXBOuOP+77zIZeDDU1RDiJOd53123VJYPCuxFJHg2 z3RU1ji+J5pHw3+SLG/gry46SGqyD6iXQ81R3+Qw1iCEBR3xeM3aX4CR/Wnzn6NXlDggrxJVMbC zoloV+lLOr7tkWVvsE6Pk3JcC3J8bsWSVrT/9SuludldeOChoPByMZWltoJvwUX8/EW/u2lXIxs nYk5z2GOjqyuzjYDKDo3CnB3wnl6z2s+e1trzFbsKdEMKL73X9JpkW0/U0w5uQ== X-Received: by 2002:a05:6214:4109:b0:6fb:66cb:5112 with SMTP id 6a1803df08f44-702c6dbd1d7mr2610046d6.43.1751584983558; Thu, 03 Jul 2025 16:23:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGyxhZnZ049hC67seKLZMmTesEshAPctloMTDGwamaQuOlXGGQBJwFhr4CP+VGmOImhVXHj5g== X-Received: by 2002:a05:6214:4109:b0:6fb:66cb:5112 with SMTP id 6a1803df08f44-702c6dbd1d7mr2609726d6.43.1751584983157; Thu, 03 Jul 2025 16:23:03 -0700 (PDT) Received: from [192.168.1.15] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-702c4d5a958sm4469956d6.84.2025.07.03.16.22.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jul 2025 16:23:01 -0700 (PDT) From: Brian Masney Date: Thu, 03 Jul 2025 19:22:25 -0400 Subject: [PATCH 01/10] clk: bcm: bcm2835: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250703-clk-cocci-drop-round-rate-v1-1-3a8da898367e@redhat.com> References: <20250703-clk-cocci-drop-round-rate-v1-0-3a8da898367e@redhat.com> In-Reply-To: <20250703-clk-cocci-drop-round-rate-v1-0-3a8da898367e@redhat.com> To: Michael Turquette , Stephen Boyd , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Bjorn Andersson , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Maxime Ripard Cc: linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-sunxi@lists.linux.dev, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1751584976; l=1979; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=bUDrRrVU7cuzvOkq/BXSXRrTOJz73kF5fGj8HK4w53E=; b=xUB+8pQNqSYfMSMKtJ+gOj0YuRr7Wv56SqgY0gPYScWgdV1HkGtTwLwdx9iGFlUExmLZuwyku mHoKvxPW2vyDCFHfBUgtY5dZ7pH4PFh8nPq0RUUJZ7MoCOhvyogjc9p X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: CMWiaQZ-LKWXDIkvvft6F639sM6xmBl9_w2ghiVbp3Q_1751584983 X-Mimecast-Originator: redhat.com Status: O The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/clk/bcm/clk-bcm2835.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c index fb04734afc806286b6a68996f36bd8a49b542cc8..5e7788406de39c94884cbc3aa162c378443322c0 100644 --- a/drivers/clk/bcm/clk-bcm2835.c +++ b/drivers/clk/bcm/clk-bcm2835.c @@ -570,18 +570,23 @@ static long bcm2835_pll_rate_from_divisors(unsigned long parent_rate, return rate >> A2W_PLL_FRAC_BITS; } -static long bcm2835_pll_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *parent_rate) +static int bcm2835_pll_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct bcm2835_pll *pll = container_of(hw, struct bcm2835_pll, hw); const struct bcm2835_pll_data *data = pll->data; u32 ndiv, fdiv; - rate = clamp(rate, data->min_rate, data->max_rate); + req->rate = clamp(req->rate, data->min_rate, data->max_rate); - bcm2835_pll_choose_ndiv_and_fdiv(rate, *parent_rate, &ndiv, &fdiv); + bcm2835_pll_choose_ndiv_and_fdiv(req->rate, req->best_parent_rate, + &ndiv, &fdiv); - return bcm2835_pll_rate_from_divisors(*parent_rate, ndiv, fdiv, 1); + req->rate = bcm2835_pll_rate_from_divisors(req->best_parent_rate, + ndiv, fdiv, + 1); + + return 0; } static unsigned long bcm2835_pll_get_rate(struct clk_hw *hw, @@ -783,7 +788,7 @@ static const struct clk_ops bcm2835_pll_clk_ops = { .unprepare = bcm2835_pll_off, .recalc_rate = bcm2835_pll_get_rate, .set_rate = bcm2835_pll_set_rate, - .round_rate = bcm2835_pll_round_rate, + .determine_rate = bcm2835_pll_determine_rate, .debug_init = bcm2835_pll_debug_init, }; From patchwork Thu Jul 3 23:22:26 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Masney X-Patchwork-Id: 1480 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52A922D94B7 for ; Thu, 3 Jul 2025 23:23:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751584993; cv=none; b=Ovbaouv4DkhM6oiCiJN0HxuXvpeYFboibKRuAGoCXzHzHIjQhfLczba+X0BJGor0PX8Jvd9uXVshKk8qF06MskaWQ1trT0dmCQjjn8nQQaOtLP0x9t9f7tMl7WUTX9kUKX+yscxos2jitwVo4c5/vFTzdQJNnMGUG09/+gb7sTU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751584993; c=relaxed/simple; bh=1SBXkivgAIQT/xpKmW16GCKl6DQTPvDdkzKcxCMxAeE=; h=From:Date:Subject:MIME-Version:Message-Id:References:In-Reply-To: To:Cc:Content-Type; b=IWWSH7WkNG+VxUqeDhJzbZnKjt7amM0e4jPKe6r+LQ8rzbrGDr6IuzWFnv60Id2DsyNJUcUtt67zjr+Udu9irwdbWETVhC3VuXAVcGGxcWCS1r6o00a6NAWw4f/rUPiukP636xRvEyGk9i6TmvSIizu7o4JX80gBqEoW2bSiarc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=V25hirfC; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="V25hirfC" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751584989; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=glmhRhvorqftCM1PQW39H91YcYQ1dirxkl9GgHITt1M=; b=V25hirfCgliR+65dJdUqaIGbrg3TIcCU6qYlL1l2GpfLaYHtOYbtWCHfMEJHi+Gp8JXFCs R6pSqTepyNadWoatWBSD40XSoyejrSHVoHCQpNV6prFnUhMmxjGatnTWL2Ust6rr8PqhKv Be7/2fGkVno7+NgaPCEjuLY717wZ+Yk= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-443-3bUF5J3KO8OtwTb5SbiXFg-1; Thu, 03 Jul 2025 19:23:06 -0400 X-MC-Unique: 3bUF5J3KO8OtwTb5SbiXFg-1 X-Mimecast-MFC-AGG-ID: 3bUF5J3KO8OtwTb5SbiXFg_1751584986 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-6fb5664c771so9139656d6.0 for ; Thu, 03 Jul 2025 16:23:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751584986; x=1752189786; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=glmhRhvorqftCM1PQW39H91YcYQ1dirxkl9GgHITt1M=; b=FkhACeB2Q8vPbF0awEF/lIQlb+L7WeuslN2SH6phNYVk4RU1DpozdKFswxodUt4RSF IqjWX9aQxJyxjPEZwzRUgkMdbwkrKvBse53r3EMk0cJrpIrW8tJEyYbEE0vAupQQdMkU LoSUq5QEI+9+vXd6cSC5d5fHyrN1tjd0n7EyRfnwlVGmI2iXsiLqj5xqqwWkrVwj8dhe SGMiMGRLhjOskUeslYm1VlOs27XgR53ScTuW4Qem1Y7BGmDPPLuhSlCA0clwhGIJHlKI OErRLhSc/3APFLi0wLWcnHh/YZ87K7bco0jrLOJGlw+gedKCnE3pq0KQesSQjs0ucgc/ vJGQ== X-Forwarded-Encrypted: i=1; AJvYcCVXiasXcUlUU1MqRV56dYg07yaB4dayEOCbGJOxgN8MyBlKyyOfhbhYHGP094xPxZtE2w/5XVFUpAguGA==@lists.linux.dev X-Gm-Message-State: AOJu0YyElc+WRRKigS45XMIAm5oc7r4wOUwav3FE2KQFsCwU6NxIiHsL +71M4rkLf+5i/cSY6zDo7dy5/afF7hgIr6rPGsbQ9gysj+RRqYrLFjJVSVCrBlM9wPMu2J0wnxN 26msMeScnWOIJWVBiFZWfAcemA/koJw1qoHXIUrhCqI1Iizj8beEZdgDedDiIivWx X-Gm-Gg: ASbGncsyMvyM5ecYYgUpR/C0PTswy2NvEhN/9cFsgxuTMbLEgWHOmkXE0rK/0gFTzwy pJ59uvS8Uf0SxYLMhOd0CG6MbCBZOqDHLQQVA7yu2nXBdZ7/EKpaPfjKzga+RZ4mLftoK5ZSoHN FOCJ9JJ5D8CEDDUj1CZTBy8q/ThXkqF1LwBxpjzNo+bMMGDWMyH4gJN867KzcR/9cFHE7t2UiUH 6ZkxontfnPCOMjSSW3/HiZ2IYz3RE9tqvcSlcegv8qYp2U/vuGHltnkZXxGA7PaRi8fcQmURCWz cOk2fqDY6kMta2z8LXapTPe1Hn1A+d+mfBeHpMcX2xZy0hGlWx82DeWhCUZ/Rg== X-Received: by 2002:a05:6214:2dca:b0:6fb:5f1d:bf8c with SMTP id 6a1803df08f44-702c6d01136mr4001146d6.11.1751584986102; Thu, 03 Jul 2025 16:23:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGXulxd6EhHQEWqdLCkq6bowgpk9H5xc/2E0qAWrXV2cw9IMvYCQaGyeK1vlKk4+HCoD7JcAA== X-Received: by 2002:a05:6214:2dca:b0:6fb:5f1d:bf8c with SMTP id 6a1803df08f44-702c6d01136mr4000676d6.11.1751584985738; Thu, 03 Jul 2025 16:23:05 -0700 (PDT) Received: from [192.168.1.15] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-702c4d5a958sm4469956d6.84.2025.07.03.16.23.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jul 2025 16:23:04 -0700 (PDT) From: Brian Masney Date: Thu, 03 Jul 2025 19:22:26 -0400 Subject: [PATCH 02/10] clk: qcom: gcc-ipq4019: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250703-clk-cocci-drop-round-rate-v1-2-3a8da898367e@redhat.com> References: <20250703-clk-cocci-drop-round-rate-v1-0-3a8da898367e@redhat.com> In-Reply-To: <20250703-clk-cocci-drop-round-rate-v1-0-3a8da898367e@redhat.com> To: Michael Turquette , Stephen Boyd , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Bjorn Andersson , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Maxime Ripard Cc: linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-sunxi@lists.linux.dev, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1751584976; l=1744; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=1SBXkivgAIQT/xpKmW16GCKl6DQTPvDdkzKcxCMxAeE=; b=F0GhFYifg67W61nanNKHwHfKd+yXvRKHNLyjxttEwNvS+4WIggMD8oWPnfPgFZE6hEmZ1fiIO n/Dix9ZjUe/BuSWXFyFuVK1zEaIQUGKOyn0QrOGVaTFUnEWIHOKyt1n X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 2mGMkls1DacPM40qO7BFBfhp-IGf27gWObDqedxrubA_1751584986 X-Mimecast-Originator: redhat.com Status: O The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/clk/qcom/gcc-ipq4019.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/clk/qcom/gcc-ipq4019.c b/drivers/clk/qcom/gcc-ipq4019.c index d38628b5226898b6a556a1fe16806cb79c4735da..5ac44cfb53ce023c0668afdcb67de636f3319197 100644 --- a/drivers/clk/qcom/gcc-ipq4019.c +++ b/drivers/clk/qcom/gcc-ipq4019.c @@ -125,21 +125,23 @@ static const struct clk_fepll_vco gcc_fepll_vco = { * It looks up the frequency table and returns the next higher frequency * supported in hardware. */ -static long clk_cpu_div_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *p_rate) +static int clk_cpu_div_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct clk_fepll *pll = to_clk_fepll(hw); struct clk_hw *p_hw; const struct freq_tbl *f; - f = qcom_find_freq(pll->freq_tbl, rate); + f = qcom_find_freq(pll->freq_tbl, req->rate); if (!f) return -EINVAL; p_hw = clk_hw_get_parent_by_index(hw, f->src); - *p_rate = clk_hw_get_rate(p_hw); + req->best_parent_rate = clk_hw_get_rate(p_hw); + + req->rate = f->freq; - return f->freq; + return 0; }; /* @@ -205,7 +207,7 @@ clk_cpu_div_recalc_rate(struct clk_hw *hw, }; static const struct clk_ops clk_regmap_cpu_div_ops = { - .round_rate = clk_cpu_div_round_rate, + .determine_rate = clk_cpu_div_determine_rate, .set_rate = clk_cpu_div_set_rate, .recalc_rate = clk_cpu_div_recalc_rate, }; From patchwork Thu Jul 3 23:22:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Masney X-Patchwork-Id: 1479 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24AAE2DCF6B for ; Thu, 3 Jul 2025 23:23:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751584994; cv=none; b=M8M1M5/rcPZ0depABZJYN09+KEczSOu/pEExetWEBolZKVD5hL3aKr2TgI8lMKBIDth3Q211aQmMEI73nLTA6HJwd0rBvxTIyK4jDnpqqW/jkwHn15VkZU09z/TLJHege0RnkG1/bqaWupSI9NnhfmCbwxcAZNcMJddXs3ZYvMA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751584994; c=relaxed/simple; bh=xV38q5FTl0giHcO6B1fUUKKklwS+ypfUiAE8QJ9ufs0=; h=From:Date:Subject:MIME-Version:Message-Id:References:In-Reply-To: To:Cc:Content-Type; b=d6XzqpGD4QuFhDOE7IQMZsQW2hJ1GsqqolSj+9z1HnB0+d7Jdd6wIAT65RXTseMsKtqjdT3oqP/x/BknXJVcASqWYoRzSMjydhCG7ajwKRSxuBX1/FycN03uWKriK9Bd8zoNKnbryarTx1xpLik1BgYoNgWsbxBPfJ19H9T5ACg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gUby+oWj; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gUby+oWj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751584992; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1AzaXolkpwLeUXX6Tltm5nUeMgctbaGRt9VbQb3Als4=; b=gUby+oWjPqW/5/Nq30l4jEALNJ2TX90Xy4/7IsN470d3ATBztVaBTPLkq9xagsYEO5aoqL 0wTdk10kr+mi+aY0+LD8y5EsP4Z5cA8uBfbl0cENe22kjQAycVc6on2kVycPbpBhukI/7n +tGr9Li9RCOBa2Gy0IL7Uw2a3MwvFOg= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-359-GwZDHq_7NzeUqes0cxlAfQ-1; Thu, 03 Jul 2025 19:23:09 -0400 X-MC-Unique: GwZDHq_7NzeUqes0cxlAfQ-1 X-Mimecast-MFC-AGG-ID: GwZDHq_7NzeUqes0cxlAfQ_1751584988 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6face45b58dso3734096d6.3 for ; Thu, 03 Jul 2025 16:23:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751584988; x=1752189788; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1AzaXolkpwLeUXX6Tltm5nUeMgctbaGRt9VbQb3Als4=; b=OLTDeahtStjhmNTxIUc80Sw/TvvHSQLR2BWxvqgYC0X9oXyRzC8sTpZxtWIg0v+YUF jHzgCebPJp9Jz+dHctpIe6DhxnXcHorLUohJR32El54DDfe9gfP2PS5azy2wtLQtrOLw TIxUwUdhDwzStJF/Ktxxt8XCAi4wjBTGL9jvfW1cUCr4/w3F3nHVzmgyuCK37R470LSN qHVmUzsuE2X68Qa6k4giG4ZtwFRXBlvBS0MSRQjjxTTERWh+xn7DArgJcSFuQigEt7Uf UFqQBiqZXfIi2E+jPSIdxWajNC/DCmul0Q/ot3V1hhcgByHivQw773WM3awRADzDzwhs DkVg== X-Forwarded-Encrypted: i=1; AJvYcCX9o+1+NUP4PdHXkSB2PvYsPS48a2EkhcNB6IPYIlkuL/9uFQFYmB6TJYCCgWT8E/KvfC18ag0nhJRA1A==@lists.linux.dev X-Gm-Message-State: AOJu0Yy9JsGy0mnBDmNXAQmhzBDxieK9Rb/8FjiITc4pgTJqwakhGzEc 4zT9Jbk4bKEGuwL/GzU6h0S9voVbdykEujlRBupKn51vBhD/IP0kjxHUOMUfKyZxaAGDYLs+7fG nNxwNqj4vsp1C7igpndTJgX11+MoPkbDoDyYH0RasrNMrTWRGdTqOdJg/8B+8wzAK X-Gm-Gg: ASbGncts4b0/yR4u+nkVXHoWgLNyk7y/dllU9dYy5UT/X/VrYNcAPcikd5qs9KUfOO0 kIHuLnTbdHSE7kT/Min/CVNHHH9uEDOkTyzuxEKjHStJtgIdzvFhLNhu5pMgR/UC5gPSAbKV+L2 S/UKO+934xHMt6y0recDj46C0E0zFR75fYSTv7KoCJzmoMHEYayaLA7Knv3Yw7OQ0CZCim/miQ0 JCXwbjEQOTQBkTf8UT+uOEBusulUhAnONNtF6RHNIlpr21YAUVNMPQ2B5HgZWFexiNvEj1gafJA +0zVVcxHG1jAD6gucbiPt6+tlXJivVWiJrxQkVRlpfL7yae6RX1M7y/RbNgOxQ== X-Received: by 2002:a0c:f40e:0:b0:6e8:fbb7:675b with SMTP id 6a1803df08f44-702c6d89379mr3029066d6.32.1751584988545; Thu, 03 Jul 2025 16:23:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IENUtIQTiH949ayUO0n64DI+W13Cd0LYVyie5G9b3GrNFyICIYDd0Xx0nCu+hVBZqsPuJ4DLw== X-Received: by 2002:a0c:f40e:0:b0:6e8:fbb7:675b with SMTP id 6a1803df08f44-702c6d89379mr3028786d6.32.1751584988220; Thu, 03 Jul 2025 16:23:08 -0700 (PDT) Received: from [192.168.1.15] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-702c4d5a958sm4469956d6.84.2025.07.03.16.23.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jul 2025 16:23:07 -0700 (PDT) From: Brian Masney Date: Thu, 03 Jul 2025 19:22:27 -0400 Subject: [PATCH 03/10] clk: qcom: rpm: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250703-clk-cocci-drop-round-rate-v1-3-3a8da898367e@redhat.com> References: <20250703-clk-cocci-drop-round-rate-v1-0-3a8da898367e@redhat.com> In-Reply-To: <20250703-clk-cocci-drop-round-rate-v1-0-3a8da898367e@redhat.com> To: Michael Turquette , Stephen Boyd , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Bjorn Andersson , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Maxime Ripard Cc: linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-sunxi@lists.linux.dev, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1751584976; l=1752; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=xV38q5FTl0giHcO6B1fUUKKklwS+ypfUiAE8QJ9ufs0=; b=svr9/D7uxrC1Dyo7FmzxHVdb3SQ3e3f4HK+SsFrtv7eZKxGDXZOMRTNco/2iQ/OKe5mC+FRhE 8ilIx65qxJ/DEVqiPHJ60/E+M1hDDeodgGsGMkUI7YBfZ4ZMx7XNLc8 X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: yu6G5v4TEwgMSR_-uVCaIUBFFSuEAD7D-GLOB06MguE_1751584988 X-Mimecast-Originator: redhat.com Status: O The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/clk/qcom/clk-rpm.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/clk/qcom/clk-rpm.c b/drivers/clk/qcom/clk-rpm.c index ccc112c21667ebf8522b06b37234f46c69b07698..be0145631197bea65438f3bed10344f18d6de802 100644 --- a/drivers/clk/qcom/clk-rpm.c +++ b/drivers/clk/qcom/clk-rpm.c @@ -351,15 +351,15 @@ static int clk_rpm_set_rate(struct clk_hw *hw, return 0; } -static long clk_rpm_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *parent_rate) +static int clk_rpm_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { /* * RPM handles rate rounding and we don't have a way to * know what the rate will be, so just return whatever * rate is requested. */ - return rate; + return 0; } static unsigned long clk_rpm_recalc_rate(struct clk_hw *hw, @@ -383,7 +383,7 @@ static const struct clk_ops clk_rpm_xo_ops = { static const struct clk_ops clk_rpm_fixed_ops = { .prepare = clk_rpm_fixed_prepare, .unprepare = clk_rpm_fixed_unprepare, - .round_rate = clk_rpm_round_rate, + .determine_rate = clk_rpm_determine_rate, .recalc_rate = clk_rpm_recalc_rate, }; @@ -391,7 +391,7 @@ static const struct clk_ops clk_rpm_ops = { .prepare = clk_rpm_prepare, .unprepare = clk_rpm_unprepare, .set_rate = clk_rpm_set_rate, - .round_rate = clk_rpm_round_rate, + .determine_rate = clk_rpm_determine_rate, .recalc_rate = clk_rpm_recalc_rate, }; From patchwork Thu Jul 3 23:22:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Masney X-Patchwork-Id: 1478 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81F7B2DECBF for ; Thu, 3 Jul 2025 23:23:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751584999; cv=none; b=PFowXrmao7KIcE9MhRqa1KPkzEzJrFrecdTyGrZNFrypktYGNP49OsRyrDikR0g+XIbNprMrFyov0+YcUjh69uOkQrk1J0ticxNNCbBA+yuvGCICW6xxPKtdI38a04OWYfmrFvC0QEhip8nH/T6Y4z1nEVh2COkKYUZjPyPIIrg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751584999; c=relaxed/simple; bh=JjW2YpRPz+0lPSN1r9ZPq4mBQxxVW0XXtxuqTB96kpo=; h=From:Date:Subject:MIME-Version:Message-Id:References:In-Reply-To: To:Cc:Content-Type; b=nDxMPZOf2H5IdyktDPbRSAW+u7WVqw6kiWyZ0jIxIDV6ybrLaaMGKdMmSzpyIAhhO+yZQG7za6TSxc55TFhXkSo/IjHX6385TGwSxI+7YtStTqmXPlTZbMZDCkBOTN4AKmxCcqAUuHgrstFZEI6j4WS0vUPwCBMouEmDIF+oHHw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=OplFvO4Z; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OplFvO4Z" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751584995; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V9SM1r4kZ+sX81Mdumv2hWNVumjYJEFhq1ifXw5ch4g=; b=OplFvO4ZSj2UzNogJRGa5TU5WAEbqwA5v37fUMuADvcXNJOQermEJplm2z1afrTEh/smOH raIeAWCnAS6WuXtkT+du2LbGhGqQwn0+vHCmMtncXS81dqgftHT525qKLAiJIWuR9siUzc w8jyArnOZt7gmMIkE83bWYR2ETs0W5g= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-602-kH-crHlLP7iEa969jm5uLw-1; Thu, 03 Jul 2025 19:23:13 -0400 X-MC-Unique: kH-crHlLP7iEa969jm5uLw-1 X-Mimecast-MFC-AGG-ID: kH-crHlLP7iEa969jm5uLw_1751584993 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-6fb01bb5d9aso5073436d6.3 for ; Thu, 03 Jul 2025 16:23:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751584993; x=1752189793; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V9SM1r4kZ+sX81Mdumv2hWNVumjYJEFhq1ifXw5ch4g=; b=W3R2TGy2ptb1KOFv8843+5Vs4fkH1w/njSsrMWEK79ASKY35nHncD+kj9iygOdVjdy 2b0EBjxkoNSlSQsC+tGF1CbHl7jhEpTqA99jtPL6lp9u27m+oejru/1ezO+t0fMFiwfm B4qlst/OUSv5bolK3WUqCnkP+EFs7mafIVg5RLwDkhCiAqp3K1gGjvoUC175UBgIG3Mj cVgVlKX2J3dNG6BnW96Ea34baY1+epQSzqREdW4/j4E51I4qQ7GFl6yXg9Od7g4qF0It 6CK/oXWnbPRJ9dN56NonUB8NH6NJweelPlUqjpQ1K4dASsq2+qty5h3/NxgJwys2M2Ic G0Ww== X-Forwarded-Encrypted: i=1; AJvYcCWAeGUISNGcp6oPtFRhBx2BddrpijlmNt3encF51mHYOTS1jqRB7RB4j1XctkHsLZIJHVFSQFQtRs8gMA==@lists.linux.dev X-Gm-Message-State: AOJu0YxAl57jIJYto7bE4qbz8jdPls00g79V3KcBVVqk9l+4l+EJtc3D aeXY/7GzSWXd2g7AkTAIgOuSNtcIX1Ax84SEjEaIQ2+zz7+LjboI+cU/nlLX0GpvqZ1O1gmAxNT oT1DVKQWKzlnJ8bXk7epihaWquDk9EMblhBCl4L42zg7jSbsLPnb9EvA0meQYGahG X-Gm-Gg: ASbGncu6w6fGqr3hphP6LpyaqVNb9Fnjsfq65FzAQ6sTW698l7w0y3s1ivFE8ZuGwuD JeelJCof9VbBgk/MANR7Z+AsJTIEa3VwozR/fm3vp2YGtbfSePhNSObUgB3qjbyskO1EcilEFhV 7NbVEaKFigDIez1mtp4TgWhbgxSzQXHEdNDgMxKwWFlSeB0ugO7bNDoW0mGytVJQBlv88ybSjFG itEY5bIYFCcm1be3Z0HmkIKk8ciNOzbFXcW6pFRlb+9yaKAdnul8JE46X3HEIG+odEPsFiKP3Zj KuWb9iruOIszh60G5UORb/sLlavYORv++d0A340RUbPJe7TZdiPgFzxzlx9dAg== X-Received: by 2002:ad4:5def:0:b0:6fa:a4ed:cce5 with SMTP id 6a1803df08f44-702c6dd6d2cmr2496436d6.44.1751584992861; Thu, 03 Jul 2025 16:23:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGI3ipPg2Jg+5GD7hTnCiXfrGoYgoIQ3H/qFVOQMX3H3uHxeS2iTGlz+BWau3PM9f3haP1PQA== X-Received: by 2002:ad4:5def:0:b0:6fa:a4ed:cce5 with SMTP id 6a1803df08f44-702c6dd6d2cmr2496116d6.44.1751584992485; Thu, 03 Jul 2025 16:23:12 -0700 (PDT) Received: from [192.168.1.15] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-702c4d5a958sm4469956d6.84.2025.07.03.16.23.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jul 2025 16:23:09 -0700 (PDT) From: Brian Masney Date: Thu, 03 Jul 2025 19:22:28 -0400 Subject: [PATCH 04/10] clk: qcom: rpmh: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250703-clk-cocci-drop-round-rate-v1-4-3a8da898367e@redhat.com> References: <20250703-clk-cocci-drop-round-rate-v1-0-3a8da898367e@redhat.com> In-Reply-To: <20250703-clk-cocci-drop-round-rate-v1-0-3a8da898367e@redhat.com> To: Michael Turquette , Stephen Boyd , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Bjorn Andersson , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Maxime Ripard Cc: linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-sunxi@lists.linux.dev, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1751584976; l=1326; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=JjW2YpRPz+0lPSN1r9ZPq4mBQxxVW0XXtxuqTB96kpo=; b=zf4/vhBsMxt+TAFqD7aUPTk19Bt+lcfBLX/WML5Wb9wvluceirqF+3xXA/SRJdeeVovfmzXVw wjKAv88CuWoAzAa7aZ5FVjlB+6EYYOYea3w9xYISlQIYpuJFVJ7J6Lu X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: J7piwRieQvF1ad90sBR-5nLiL1X9E5wsAKiB0AoqJko_1751584993 X-Mimecast-Originator: redhat.com Status: O The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/clk/qcom/clk-rpmh.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c index 00fb3e53a388ed24ed76622983eb5bd81a6b7002..74b052ac1ee10bdeeb59880019fb06ad58db3f74 100644 --- a/drivers/clk/qcom/clk-rpmh.c +++ b/drivers/clk/qcom/clk-rpmh.c @@ -321,10 +321,10 @@ static int clk_rpmh_bcm_set_rate(struct clk_hw *hw, unsigned long rate, return 0; } -static long clk_rpmh_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *parent_rate) +static int clk_rpmh_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { - return rate; + return 0; } static unsigned long clk_rpmh_bcm_recalc_rate(struct clk_hw *hw, @@ -339,7 +339,7 @@ static const struct clk_ops clk_rpmh_bcm_ops = { .prepare = clk_rpmh_bcm_prepare, .unprepare = clk_rpmh_bcm_unprepare, .set_rate = clk_rpmh_bcm_set_rate, - .round_rate = clk_rpmh_round_rate, + .determine_rate = clk_rpmh_determine_rate, .recalc_rate = clk_rpmh_bcm_recalc_rate, }; From patchwork Thu Jul 3 23:22:29 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Masney X-Patchwork-Id: 1477 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 386062DFA5A for ; Thu, 3 Jul 2025 23:23:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751585001; cv=none; b=a56DKfXygtQI466wP1AnDlORw4YPKmRuoFnMXK4z+rk/4Q6GQpT21qBmFz/gepk7/PlEiW/ntLKFBhIe0NOsFJf0lV8O+EkRXxLCKFmIFdo4LAqENW5RHbZXDx2n51DWX0rnHzLOTBhexdkfPqJehyCn/JiNbOakDqpcYQxF0sM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751585001; c=relaxed/simple; bh=jJkTWWJF3/5RXKxSt11n2asRYUE42Jhyt7x72H7Kcqg=; h=From:Date:Subject:MIME-Version:Message-Id:References:In-Reply-To: To:Cc:Content-Type; b=UgCfU4gsBkv4+XctufuhifeW9B4cVRRa3mjfgN7XAzkpYp+ydH2EMKonTSIflISTeYqjffl3jiyOSQoJ4xoE091VW0e1SRTP8L3BUmc+CdH//gTnGZStCt12V6Ub7lDFU7zv/lT9eymFLjglSMk4nIevETbL0tcndPp9oCZrXmE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=A3ZnMapY; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="A3ZnMapY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751584997; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kG8RA2RMN+WwY2ubKngIBCBT47zo9cYuBqM+5cnEdCI=; b=A3ZnMapYgGhv9SkS1q8QAuUAtbL5OqJSzwOHl2iC7D5+dE5UKon8bvNvV0Gbbbe2vd1a4c mW4jIg/J63cAnQxtlHpJR0atHytJWDedWwNQh8ABcWdhNU6FCW0J66+X/ndPr5WEmOebi7 G31+Z4wkIjMEz7ok6cFSpaKEpX3Eebk= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-613-rW7Tujh5NzCJtpdWI6hqqQ-1; Thu, 03 Jul 2025 19:23:16 -0400 X-MC-Unique: rW7Tujh5NzCJtpdWI6hqqQ-1 X-Mimecast-MFC-AGG-ID: rW7Tujh5NzCJtpdWI6hqqQ_1751584996 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6fabb9286f9so6594496d6.1 for ; Thu, 03 Jul 2025 16:23:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751584996; x=1752189796; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kG8RA2RMN+WwY2ubKngIBCBT47zo9cYuBqM+5cnEdCI=; b=QWCxiJs7HRe3ZUpq+tKbJ8Hcxq8s8xtZmf6J63x1rAqGJDDgle5knX6kPIPLu03zeQ OSa3hDKhMXrjOCADpIP5dHE23NJxwk7jcsz66n/G5Q1x4M1RVBH5ZqwTykEMZxSXKMt2 mbk0uFDPRpa1rD6jkdRU0tggch2njv+XpNJMTvZdnImEPMnRtaC3Tl7LwwdwbEhvjNwy h5H7GETNttfwSu7YMSWciDUaM2rOS0t9WmCCNBrvxxfdxnhRZlKE37CdYQwZMHyvafX/ 0gx3YfO19A4dhxqa7TiYTksXJPH940on//x7u1v12KuPGS9lJZYm9kIJLf0TgpQE59PV Zkew== X-Forwarded-Encrypted: i=1; AJvYcCVWpGEXNUlKudrW4P8eocPrizfDiFE/qqDdB2UOmhUK1ACKJQiv2I/4vA798mUzQ884JdNXwHBYmBGkjw==@lists.linux.dev X-Gm-Message-State: AOJu0YwF4Yay9Pq2itEkoHBTi3nWWsnivmlelUgzGpBzP/O2UVGhG8Au 7Lr9Txku+HzUPrgYaXufKMznLLvQlbfm3SvLLQqalnxmbcLFvhYMUmIJGkguYEiVTvPcUc/liN3 rmnCZPn9sHQjRZttuEKr8y+sqQ5hUz4CTS1PYZcNbUJkZWqfP8ThNHvEmHsrQgUWr X-Gm-Gg: ASbGnctzmbSsJvFL6zTRczIjGBGxK3ZN3Zsk/i1P3kmZmQ9ufcEfldH7FzOo27Eadou ek+myqpDPYTXsTfu9PpJ3LvoAq5JysfZ/bZBcGfIrplbwRJ4a82nuZCjdubj+NmEMRFlkZg/dfD zdjyMRADiJD2hjFP5hHg0/Dwqmdq2fJB3zdq4JBcw00fH62gtyj/mEVxtW/2xTseA/6vaOPUdkU +POIYy63ULQ2ZaTZ1CH/WKZ6fZkjosO23LzvWalSEECJnryyTSlIcNwfhyd7l+qW6c+ADVHVgHd o68SCKM6U+QFLL2kFrGz7Vv/GKMNOp6PxerZx+5WfiSge5Gngp+6D2KSYAb0zQ== X-Received: by 2002:ad4:5ba5:0:b0:702:c123:da1c with SMTP id 6a1803df08f44-702c6d5a1bfmr3133316d6.18.1751584995740; Thu, 03 Jul 2025 16:23:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGYU49F29nXLLJhUF6aQEdxZXPH42Yhu1DTnmyZaul5HXNd1rIQI+KPYemKNRW8NflwAqOr4g== X-Received: by 2002:ad4:5ba5:0:b0:702:c123:da1c with SMTP id 6a1803df08f44-702c6d5a1bfmr3132936d6.18.1751584995402; Thu, 03 Jul 2025 16:23:15 -0700 (PDT) Received: from [192.168.1.15] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-702c4d5a958sm4469956d6.84.2025.07.03.16.23.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jul 2025 16:23:14 -0700 (PDT) From: Brian Masney Date: Thu, 03 Jul 2025 19:22:29 -0400 Subject: [PATCH 05/10] clk: qcom: smd-rpm: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250703-clk-cocci-drop-round-rate-v1-5-3a8da898367e@redhat.com> References: <20250703-clk-cocci-drop-round-rate-v1-0-3a8da898367e@redhat.com> In-Reply-To: <20250703-clk-cocci-drop-round-rate-v1-0-3a8da898367e@redhat.com> To: Michael Turquette , Stephen Boyd , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Bjorn Andersson , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Maxime Ripard Cc: linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-sunxi@lists.linux.dev, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1751584976; l=1507; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=jJkTWWJF3/5RXKxSt11n2asRYUE42Jhyt7x72H7Kcqg=; b=WVf99xpXURqHDMOlRG1isIsZmcxQ2hVzruPLXEZLBIO4b3rIoDFPUB+65Us88g7XSb6xd555r vRtnzyNPfgpB/pkwsRXhEbFCMwp6sgfC61aI01PDavIaz23Jb23DZ8c X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: fXFLF5CFJebYibr-3YfDecy0vUcewREOO4KwNB3kI7s_1751584996 X-Mimecast-Originator: redhat.com Status: O The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/clk/qcom/clk-smd-rpm.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/clk/qcom/clk-smd-rpm.c b/drivers/clk/qcom/clk-smd-rpm.c index 3fbaa646286f284da12b902873b079863a2c0d77..3bf6df3884a542e7be572f2319990c2bfa7bc642 100644 --- a/drivers/clk/qcom/clk-smd-rpm.c +++ b/drivers/clk/qcom/clk-smd-rpm.c @@ -370,15 +370,15 @@ static int clk_smd_rpm_set_rate(struct clk_hw *hw, unsigned long rate, return 0; } -static long clk_smd_rpm_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *parent_rate) +static int clk_smd_rpm_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { /* * RPM handles rate rounding and we don't have a way to * know what the rate will be, so just return whatever * rate is requested. */ - return rate; + return 0; } static unsigned long clk_smd_rpm_recalc_rate(struct clk_hw *hw, @@ -427,7 +427,7 @@ static const struct clk_ops clk_smd_rpm_ops = { .prepare = clk_smd_rpm_prepare, .unprepare = clk_smd_rpm_unprepare, .set_rate = clk_smd_rpm_set_rate, - .round_rate = clk_smd_rpm_round_rate, + .determine_rate = clk_smd_rpm_determine_rate, .recalc_rate = clk_smd_rpm_recalc_rate, }; From patchwork Thu Jul 3 23:22:30 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Masney X-Patchwork-Id: 1476 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62B062E0405 for ; Thu, 3 Jul 2025 23:23:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751585004; cv=none; b=dOpY8V0j0ZhrFsLrN78Q6J4k5H1o4MoIwhS1JL/loaC3nPo1GHtrOR+vs0qa8/XNqzTI4kJ+lqG7e3+owaAJ3YjR6xf8roFkVXq08o8gqca9A2hAxi1MkXAYBq/TZ0ZnOnxQxgod6F5YchYCL6Rilqs74POA4o51eGm0yw3saOs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751585004; c=relaxed/simple; bh=df3heNetVnGAakoOY8ifFlNFJTyILwhXaXx3zST6UYs=; h=From:Date:Subject:MIME-Version:Message-Id:References:In-Reply-To: To:Cc:Content-Type; b=Hz3AJt/lhIymzEiqJLQRNBWhgJ53cbaOYIP4tJiXuU1+sixY//JQCqVjfAi95DH6Y4eRRajspqM4eTQkjbPvJpg4O7fPg5eO1ahyZcPX0kcmz90hXoY9h4SL0yR7uCOSy+SuyUkYNtR7zpnzpQAcjhE+ZQewXzLg2YYdSfAEFuE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=BVFprSSg; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BVFprSSg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751585002; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QS4yMTSBWIACzdBsSvd1ueSXzxvii7AwO2574uYorUo=; b=BVFprSSgPvldXU6Nz1NYJOTPIbcvLXlcLH/gahJKzhvUsSveAwnPNNLgSegN3DyHDIx9Z4 pVrzIW/+dllsDUnzZYfKem7LpreD0Z8CNdT1VFPW53iwAVnUlrQYo4kTxlAv4qj1gVh6gb 4Qo2wwZh9LYAJx9gKrn2bMgC8QD0NKA= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-311-I881JXCiNhapQMy3sGA3XA-1; Thu, 03 Jul 2025 19:23:19 -0400 X-MC-Unique: I881JXCiNhapQMy3sGA3XA-1 X-Mimecast-MFC-AGG-ID: I881JXCiNhapQMy3sGA3XA_1751584999 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-6fad9167e4cso8215266d6.1 for ; Thu, 03 Jul 2025 16:23:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751584999; x=1752189799; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QS4yMTSBWIACzdBsSvd1ueSXzxvii7AwO2574uYorUo=; b=SET0AOEYIY+qz1rk2Zg5cmZowzYlMnl2ou0bkAtuM5Y7nXt3eoXvLbxXBsuGYqnRBL OSIvxJy5lHf4Tz+gu1Q3z8Rk4iuHKwNdNO4LUJ4NgToVQQHZB8pu9BnB9AFCakc+OQAb IEnDuAzn8+JplnRAu0N7IO+owdm/Aql+l7cEDGtzElfKsSzngLGwm6FTSmoe2+19hBrb ojO1SaxElIl8eNet2axu9RNL99hwT99IvZt2PRtfXXzP+O9soG4RdgMmOzstii+UULEK 8b4VnsrLgQ+xsCO5wmZXl2HEDXX9Z4lQnNYGKUG1Iw7PBhK8+O2zs8ZeAV11FhIDAxYH YosQ== X-Forwarded-Encrypted: i=1; AJvYcCUM+r6iUeOogj/rAvN2O38MNPS9Y/zelOpYqnyJxJxOU0FwJGKiShV6UcwKcm0Cib1sHzphUFwTnluPPQ==@lists.linux.dev X-Gm-Message-State: AOJu0YzhOxtBhLAaZw8NpKeNx3tnsx3an6MyNYVeMnicUQDQkXEPsHcV DAeM6cQvFLg+FCtwFp6Eb0J243gIt8+/peCFqpoS8ahUfo2ClpgEFTQhd6sI7FsQ1yEKkJIZQFg VLe/gLWXejDwjsfyzPQuCCxi9KGADkgYjQiGeFJJmk5lDXYSUNZg6Avox0UWhOyEI X-Gm-Gg: ASbGncsg84hYoa8KtEMETerlx9Gm5fAsy4nrPRz73iFnHLFs/eaBE6sEfdzcQWk0a+x 5Uqpbt/DeVziBO18/3px4k0pyRkFjUElRGlFCM4i5r6gqYuMB8c+mcsMXSNIUrsV80Pv9XvismL Jlu0FtaqK5Op/9pNC6IYW65BT8evvoht0VSxCBdBB+uP5sa7444vL/VNhCt8/3En6iPf8h33lsS 2S8S905GGp0M9WLJIM2RjDta0wcAWGQNM07nxLJE+VCIceomMeB/GnPxDolrxa8vAzBuxgKfNR7 R0g1twI1ik5iy8G4iOTXLdXoCivDd55tGK1h0fxxw6/Hu0w2nWcgPb7dOxgH+w== X-Received: by 2002:a05:6214:3c8b:b0:6fa:c81a:6234 with SMTP id 6a1803df08f44-702c6d01143mr4642606d6.10.1751584999100; Thu, 03 Jul 2025 16:23:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHnyRBtsxkt1pYtkVxxPc81mM4Wpf/ySmYd6WAtzuN8xInUs5YM90SqZ5QPpGic7Y9Pfr/12A== X-Received: by 2002:a05:6214:3c8b:b0:6fa:c81a:6234 with SMTP id 6a1803df08f44-702c6d01143mr4642196d6.10.1751584998794; Thu, 03 Jul 2025 16:23:18 -0700 (PDT) Received: from [192.168.1.15] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-702c4d5a958sm4469956d6.84.2025.07.03.16.23.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jul 2025 16:23:16 -0700 (PDT) From: Brian Masney Date: Thu, 03 Jul 2025 19:22:30 -0400 Subject: [PATCH 06/10] clk: qcom: spmi-pmic-div: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250703-clk-cocci-drop-round-rate-v1-6-3a8da898367e@redhat.com> References: <20250703-clk-cocci-drop-round-rate-v1-0-3a8da898367e@redhat.com> In-Reply-To: <20250703-clk-cocci-drop-round-rate-v1-0-3a8da898367e@redhat.com> To: Michael Turquette , Stephen Boyd , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Bjorn Andersson , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Maxime Ripard Cc: linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-sunxi@lists.linux.dev, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1751584976; l=1685; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=df3heNetVnGAakoOY8ifFlNFJTyILwhXaXx3zST6UYs=; b=OFYVeMjBJG2jV2b1stxmQ5G0DPbn/iCRgth0RbTQpfPDnrwu1D4KE8bJib4qFP4WVG1I+0SfP A2XeBkjrP1YDSfU9lpFAunaG90ILx4mHMpjg4d3zzXSpuGBMZWLMybv X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: rkz6qgg9HYKi26xskmUnqexsH4V211spu4FDZ_fdkVw_1751584999 X-Mimecast-Originator: redhat.com Status: O The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/clk/qcom/clk-spmi-pmic-div.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/clk/qcom/clk-spmi-pmic-div.c b/drivers/clk/qcom/clk-spmi-pmic-div.c index 41a0a4f3b4fb316827365a522079dcd99630c49f..3e2ac6745325a1e0a30a4587d27f14d93011a225 100644 --- a/drivers/clk/qcom/clk-spmi-pmic-div.c +++ b/drivers/clk/qcom/clk-spmi-pmic-div.c @@ -112,16 +112,18 @@ static void clk_spmi_pmic_div_disable(struct clk_hw *hw) spin_unlock_irqrestore(&clkdiv->lock, flags); } -static long clk_spmi_pmic_div_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *parent_rate) +static int clk_spmi_pmic_div_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { unsigned int div, div_factor; - div = DIV_ROUND_UP(*parent_rate, rate); + div = DIV_ROUND_UP(req->best_parent_rate, req->rate); div_factor = div_to_div_factor(div); div = div_factor_to_div(div_factor); - return *parent_rate / div; + req->rate = req->best_parent_rate / div; + + return 0; } static unsigned long @@ -169,7 +171,7 @@ static const struct clk_ops clk_spmi_pmic_div_ops = { .disable = clk_spmi_pmic_div_disable, .set_rate = clk_spmi_pmic_div_set_rate, .recalc_rate = clk_spmi_pmic_div_recalc_rate, - .round_rate = clk_spmi_pmic_div_round_rate, + .determine_rate = clk_spmi_pmic_div_determine_rate, }; struct spmi_pmic_div_clk_cc { From patchwork Thu Jul 3 23:22:31 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Masney X-Patchwork-Id: 1475 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AA962DCC11 for ; Thu, 3 Jul 2025 23:23:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751585008; cv=none; b=Dwac513G3/MX2DrjpkQhhKapME3K/pOodvhzN2gkPzWqaPvzf+hwZ7BrOg6tX5XWPOKeaTcM55Ik19vk1XZNXs3xfbpA0s9GnutEgK8y+a4BKRzJotVkUI3iEITttZ3xLo1/3eLvw0IkzKOc2pfqdINK+TpP13ciIPD8yVVLl/Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751585008; c=relaxed/simple; bh=yI2SIQSpfv11yROCqsNTigI0LZL/+DeyReURO7gHFTk=; h=From:Date:Subject:MIME-Version:Message-Id:References:In-Reply-To: To:Cc:Content-Type; b=D5kFSNOhsSUtrA9uVs0ErBxlu0RfOKfEA40WFgqZUAUg7o09FDrh7dZShHExyzquZaMRzy+hoOtoCacpc0uRpLB4hyySmiLP7NYoT4L+CWYGj5TYdHU7U1RW1pFV2E3yBLHbBlhcnE+bv6x4/jBdYIit+vYwOct93TkWegJXA6o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=DbXU/eT4; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DbXU/eT4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751585005; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JhDtC2utRaPlDpGhYs17r5vvsrnmu45x3ymT5BDVHJI=; b=DbXU/eT4HG3xE8S7TW6n/7EiwP2+rXLAu95+aOQp4SSvkfq7VWKipeX0RXwgvTszcx9xqG xIDXtemDO8Hyn7VI2w6SRSrQ8zn4s/kJBNRtQIvzQ4VFPqm92urnuht1HAlX0hfbdG8IMI uqvDUZl85JPeEsw7av/cTfH0pu9NjB8= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-134-hgydkveZPHGu9d14xYKBpQ-1; Thu, 03 Jul 2025 19:23:22 -0400 X-MC-Unique: hgydkveZPHGu9d14xYKBpQ-1 X-Mimecast-MFC-AGG-ID: hgydkveZPHGu9d14xYKBpQ_1751585002 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6fad2a25b65so5064096d6.3 for ; Thu, 03 Jul 2025 16:23:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751585002; x=1752189802; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JhDtC2utRaPlDpGhYs17r5vvsrnmu45x3ymT5BDVHJI=; b=OiidnWPW2KodkEcWwH514/H0ikHecej58vIXoFFpeCSkWfgz9ogqSQRKRAiemZ8SAP 0lzExNGoPS7lX5ysXqrVewyCL5yHQWrGJO1g3mCdoh2w0jhNRkWMUz2vYnsQxdBkzMXW 6Fj9Od7xvyhyAK04N55+UcTIPx6aMfwv8ggeL46T4r2bKeaGA5hAQ/fgTC30nGQZDdar VzU665uue5ozsjHD62EoCRWuEWArXK2qa0sh7cqwONIfKg2GUPvL0TeZdQ9Y/PxkdXw5 behnPFS6I8ggY6YVhgwiVrifQBIHuCzRRYNz51CY2TeWc3gACrCZAuCFziqcbGu6NdB8 JX1g== X-Forwarded-Encrypted: i=1; AJvYcCVCYUh+r/KpnTAUl7GGDZ5q9A0sfleS1F5UX/vp0tZp+2MhY3nzmG0fIZbtSTq03bQ5sYTPyF7t4v5KWw==@lists.linux.dev X-Gm-Message-State: AOJu0Yx7o3446Vh6lEoA8TjvMeJw8mvhxMsvIPXJJ3HJOkkMX8IHXmH/ TVa9saiodqlLyVw2wZuX+liUrDirfEyYoNHeTiU4fvlqTmNqKbE2poCRsL/NCrbqsOyBRia0fn6 i8lCQ9n2v/NhujPQlbowM0kncZMt66fy32MlF0eolpEBusYRKn8Jpp2jvGZ/aCDyN X-Gm-Gg: ASbGncueGL7Gvq0yDJ+eYxRFPBkrljJxgWDYDAhuXXaPY4MyCXYVzZ/+eCum0QO3ZSC ElcGlDsNW1OMo/W58HiBc0huaCJHiyE2/70MsJAhTRW2VAVVU7/o7o2KH7/b7DtVbMdkWltVczg o0CJTx5jKp3G/jSIsbBMbdUUfLuvFCuYEXOFQ4zOSa4nSEnZNaUrduJoAPhPQKUaTw5bzUylXpI r09I8OkqDPopcQ2jzZFcLQdz0rxUYWNw6iDUd8LsWl+uLKqQxz3TpocmOTaZey2I5gLrTYY7Ho/ 6tv4wte5h4As34sYK8JL52gDJgaaLXbUnm5fFyTGr0eRWikDqAuFNINiJ+8C7w== X-Received: by 2002:a05:6214:5191:b0:6fb:59de:f8ab with SMTP id 6a1803df08f44-702c6d46e71mr3912736d6.10.1751585002084; Thu, 03 Jul 2025 16:23:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGz3rcs3pEbfi+i10yC2fv924P24DnAprgiwcA1Xos8lcGEnsQWq4OIG7/Hd2meAunlCE03sA== X-Received: by 2002:a05:6214:5191:b0:6fb:59de:f8ab with SMTP id 6a1803df08f44-702c6d46e71mr3912326d6.10.1751585001708; Thu, 03 Jul 2025 16:23:21 -0700 (PDT) Received: from [192.168.1.15] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-702c4d5a958sm4469956d6.84.2025.07.03.16.23.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jul 2025 16:23:20 -0700 (PDT) From: Brian Masney Date: Thu, 03 Jul 2025 19:22:31 -0400 Subject: [PATCH 07/10] clk: sunxi-ng: ccu_gate: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250703-clk-cocci-drop-round-rate-v1-7-3a8da898367e@redhat.com> References: <20250703-clk-cocci-drop-round-rate-v1-0-3a8da898367e@redhat.com> In-Reply-To: <20250703-clk-cocci-drop-round-rate-v1-0-3a8da898367e@redhat.com> To: Michael Turquette , Stephen Boyd , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Bjorn Andersson , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Maxime Ripard Cc: linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-sunxi@lists.linux.dev, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1751584976; l=1958; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=yI2SIQSpfv11yROCqsNTigI0LZL/+DeyReURO7gHFTk=; b=FBh/28zlwskIaAbPO2b+tu7E0IGz0egaTdlYzpasdj3/eWmqI5c+jiwwjhb0UWS08yNR6Uiei jR4ac0pocwYBwf2SDC9OhHItWpS1RcSUFKjbL5CgqDeWzQZ8d1jP7ws X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ZxNlUd3SheGQQxfrVPiRviq5hRo3ao6mOeuZWcLOP9I_1751585002 X-Mimecast-Originator: redhat.com Status: O The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/clk/sunxi-ng/ccu_gate.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/clk/sunxi-ng/ccu_gate.c b/drivers/clk/sunxi-ng/ccu_gate.c index 474a9e8831f87ffcec7712c14ecb55b8523f05a6..30673fe4e3c2cd2c86f94a21929b144ba4cf01fe 100644 --- a/drivers/clk/sunxi-ng/ccu_gate.c +++ b/drivers/clk/sunxi-ng/ccu_gate.c @@ -91,8 +91,8 @@ static unsigned long ccu_gate_recalc_rate(struct clk_hw *hw, return rate; } -static long ccu_gate_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *prate) +static int ccu_gate_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct ccu_gate *cg = hw_to_ccu_gate(hw); int div = 1; @@ -101,14 +101,16 @@ static long ccu_gate_round_rate(struct clk_hw *hw, unsigned long rate, div = cg->common.prediv; if (clk_hw_get_flags(hw) & CLK_SET_RATE_PARENT) { - unsigned long best_parent = rate; + unsigned long best_parent = req->rate; if (cg->common.features & CCU_FEATURE_ALL_PREDIV) best_parent *= div; - *prate = clk_hw_round_rate(clk_hw_get_parent(hw), best_parent); + req->best_parent_rate = clk_hw_round_rate(clk_hw_get_parent(hw), best_parent); } - return *prate / div; + req->rate = req->best_parent_rate / div; + + return 0; } static int ccu_gate_set_rate(struct clk_hw *hw, unsigned long rate, @@ -127,7 +129,7 @@ const struct clk_ops ccu_gate_ops = { .disable = ccu_gate_disable, .enable = ccu_gate_enable, .is_enabled = ccu_gate_is_enabled, - .round_rate = ccu_gate_round_rate, + .determine_rate = ccu_gate_determine_rate, .set_rate = ccu_gate_set_rate, .recalc_rate = ccu_gate_recalc_rate, }; From patchwork Thu Jul 3 23:22:32 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Masney X-Patchwork-Id: 1474 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11EF42E11A6 for ; Thu, 3 Jul 2025 23:23:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751585008; cv=none; b=LVZ0Lxcpv5AMJLqzYrUgchetVfTxkfaGQlhgY7Nt19EUztvLeEICN8M662FDsxp86ezzQW6l0DLhE0r4Ip7pvewO3AIqzoRcUZkokLclOX7IK3jzi31CPvaLIzMAvsbr5F3d2Sajc/UNh5ley7yHjmxrPkltBLSiJ5zZbzYen/Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751585008; c=relaxed/simple; bh=btToz2S3ADP3ZxZpciNSy/MUe5vuMQa0nAdFifjfxYg=; h=From:Date:Subject:MIME-Version:Message-Id:References:In-Reply-To: To:Cc:Content-Type; b=K6nEhegHvCq5E5zVbH/THbmaOdBLNt4w1suuU21J0qt31Sk/xjTOjaDcoR0a0QszUNa7ANDF1ZRPxVhi7Hc9gf22xIje94CqUxvtgYCrhle0svd9IpQfFex3oRRDUU+DqXR160R4ArElo3HeaPL0Zu8//WcjDiwQGpyxZsdZzUc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=HgRWBlL9; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HgRWBlL9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751585006; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PLJPkvu+exBJdImF9hJf2W6Rmq4JjRca1LT16iZ+xSg=; b=HgRWBlL9BhglwFuxNhGyQLnYwojLJWAC5CtX4FTQDXWZHtcBJKHT6Cet8Yw95mdWrpeVfs oAgKXrBSIbCvTefY/iDxD6IRJKzO0moqkQrONMk4MZx3rOkNmt/w134UVgUWrCS5cSob4q xHGuXOH3LH0S04rsGKXzvufpxCVqBsQ= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-490-LQLRs4ZIOemeEt9MSU82Gw-1; Thu, 03 Jul 2025 19:23:25 -0400 X-MC-Unique: LQLRs4ZIOemeEt9MSU82Gw-1 X-Mimecast-MFC-AGG-ID: LQLRs4ZIOemeEt9MSU82Gw_1751585005 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-6fd3aeb2825so11881646d6.3 for ; Thu, 03 Jul 2025 16:23:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751585005; x=1752189805; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PLJPkvu+exBJdImF9hJf2W6Rmq4JjRca1LT16iZ+xSg=; b=kljkkoF8kdbrew9AB0Bi/kcFI/MNNYFg9s8s7pXTrLhlezwk1Qnc8ViSJsO0iR52E6 /12ZsEYz/VTYMDCaZRs8qZ/bGI0KqL2wK/eeQDRew3meR3jG2/7CjYBfHln4P4Pf+du9 KnZojRcdmexGx8sNQ+FMLzpRpc8xME0RrGvVVPAJA3MLaXavGMD+jgMlRLetgZDlwfOH L4KNXD8OVKlNv//utrM6HYACqFADqTxQ/xRdgAC6XJT739gJpKodb758BCXYRPuaLRq2 UytLNZr8lVVAN9k8ybXdWLD09Dx0WxiT7EGxwy0hKAMiul8gopmRNLYvUhQWt5SNsyaC Wxzg== X-Forwarded-Encrypted: i=1; AJvYcCXOMNQ6+MQmnhbaOSkpUOEZjoIzzP35q2e/aMPRCoiFWg3tSTMje5L8VBOwEy8agFot9KvTOH41IkEkYQ==@lists.linux.dev X-Gm-Message-State: AOJu0YySOdr8awUark1u4v0Jhac3H0cCZ+1QtnxOtewB8dqXqzeCmlyb itdkHgmFLCJd04BLuG1JTNwOuXeHHMB81VCSCktAO4DCGMd0Nbp2ovSU9IJC9bSrbi01Zc5CGfK 7FNsRHbptDUEBi5moJJT+BVFfonkDU4iLzcfe2JCWn2kpzxxK0rwAulZ22K7SwZ5P X-Gm-Gg: ASbGncvEAYRKgWHAGZ8q8c9sILYQ/X9cA1a+R6av4pWTMWA5jyLpkriSUUt77B2569g aRAPNMXpz591AJ8ymHV+c0AyMtv+UBGy0hwKwUaNnF9L9sVaVM4O1SO+qM9iO/MdUxQhmsa+jyk cYIILK6ZMhK1W3t0v7fbBK+ooz8lA+/BqWw4hW+Qn0kssm4APL+d+vRlKAVzkVzwrpjNNPRqlo0 +sxH66NZUHn4sNYuo1/C8JCyHxIuWs+HOuLiA57mTPO8EmodWna6OES/iRMJkkSUC/tvy/105MI grGYoX/1M+gftKQ07qTXvFm57yCHe20Wnl9hSLXWhKFe647HIoa7U+pk8TpZ+g== X-Received: by 2002:a05:6214:5016:b0:6fa:bd17:313 with SMTP id 6a1803df08f44-702c6dd28f5mr2312826d6.30.1751585004836; Thu, 03 Jul 2025 16:23:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEZUTcv/RXxDRv5oOXWGYLGuMzoJgJUUqtfCFBZdCd61PSDSlgd+Ecfdnm9HkmgohROAdoaIQ== X-Received: by 2002:a05:6214:5016:b0:6fa:bd17:313 with SMTP id 6a1803df08f44-702c6dd28f5mr2312506d6.30.1751585004446; Thu, 03 Jul 2025 16:23:24 -0700 (PDT) Received: from [192.168.1.15] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-702c4d5a958sm4469956d6.84.2025.07.03.16.23.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jul 2025 16:23:23 -0700 (PDT) From: Brian Masney Date: Thu, 03 Jul 2025 19:22:32 -0400 Subject: [PATCH 08/10] clk: sunxi-ng: ccu_nk: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250703-clk-cocci-drop-round-rate-v1-8-3a8da898367e@redhat.com> References: <20250703-clk-cocci-drop-round-rate-v1-0-3a8da898367e@redhat.com> In-Reply-To: <20250703-clk-cocci-drop-round-rate-v1-0-3a8da898367e@redhat.com> To: Michael Turquette , Stephen Boyd , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Bjorn Andersson , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Maxime Ripard Cc: linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-sunxi@lists.linux.dev, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1751584976; l=1938; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=btToz2S3ADP3ZxZpciNSy/MUe5vuMQa0nAdFifjfxYg=; b=d2ZMlN6C58BBAH6QeN6ACobOCoE2MjYgmAG9txbKa5xDhf1dkWNsPCaDoFCNoKlsbitIMf4tY rlssfLZk/Y8AJ4/97xBA/IKkdc92QGnzsPYwRqblNmN4ZVeb/pGltBT X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Rte7mKrDFvAHQbAQ3pc1vk0LlU7HYXfFUtfrifruEb8_1751585005 X-Mimecast-Originator: redhat.com Status: O The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/clk/sunxi-ng/ccu_nk.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/clk/sunxi-ng/ccu_nk.c b/drivers/clk/sunxi-ng/ccu_nk.c index 555e99de2cc6ee0c84ccaaac9ee83be2d88741a0..5db748fbb5bd9399a2d551c8821a4bb17ded005a 100644 --- a/drivers/clk/sunxi-ng/ccu_nk.c +++ b/drivers/clk/sunxi-ng/ccu_nk.c @@ -92,26 +92,26 @@ static unsigned long ccu_nk_recalc_rate(struct clk_hw *hw, return rate; } -static long ccu_nk_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *parent_rate) +static int ccu_nk_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct ccu_nk *nk = hw_to_ccu_nk(hw); struct _ccu_nk _nk; if (nk->common.features & CCU_FEATURE_FIXED_POSTDIV) - rate *= nk->fixed_post_div; + req->rate *= nk->fixed_post_div; _nk.min_n = nk->n.min ?: 1; _nk.max_n = nk->n.max ?: 1 << nk->n.width; _nk.min_k = nk->k.min ?: 1; _nk.max_k = nk->k.max ?: 1 << nk->k.width; - rate = ccu_nk_find_best(*parent_rate, rate, &_nk); + req->rate = ccu_nk_find_best(req->best_parent_rate, req->rate, &_nk); if (nk->common.features & CCU_FEATURE_FIXED_POSTDIV) - rate = rate / nk->fixed_post_div; + req->rate = req->rate / nk->fixed_post_div; - return rate; + return 0; } static int ccu_nk_set_rate(struct clk_hw *hw, unsigned long rate, @@ -155,7 +155,7 @@ const struct clk_ops ccu_nk_ops = { .is_enabled = ccu_nk_is_enabled, .recalc_rate = ccu_nk_recalc_rate, - .round_rate = ccu_nk_round_rate, + .determine_rate = ccu_nk_determine_rate, .set_rate = ccu_nk_set_rate, }; EXPORT_SYMBOL_NS_GPL(ccu_nk_ops, "SUNXI_CCU"); From patchwork Thu Jul 3 23:22:33 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Masney X-Patchwork-Id: 1473 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59CCB2E2EEC for ; Thu, 3 Jul 2025 23:23:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751585012; cv=none; b=LglNNsy9WQqxLRKWbJBytv2YWCXC0JFPqcS1crXMb1Bn+kxmMhy0pB/ObUcG7ptGIdmGMdUxtijTX9Ypcn/KW4Acb9vEAaqqfKGT6kr9sKfOGlsAm1smpOV3Zl9NYpiQRCqjyTjNYguTFyz9dCgwx2o0rae5lKfurkDxDpTr+P0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751585012; c=relaxed/simple; bh=MG6R6xLI8D2rCtfPyeozFwBeKwPJHUOoxhsT2UMyvnU=; h=From:Date:Subject:MIME-Version:Message-Id:References:In-Reply-To: To:Cc:Content-Type; b=hdRfIAJtctshtL5Bo/M8A4y+EGkZ5bsxm3gR1acXIvEQpC7hEKqDNzFdKsHaIvob+kjc6U+QLQZG46PhYhqYAKtMvQ1ebtQ7riQfJWknNhqeyY5oS1vSCkWx5ieOJd+fOncHuo3hw0i+Sl6qA4nAJ7Dbdf89A8YcM3WpxrGmiR8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=i2B5hA6f; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="i2B5hA6f" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751585010; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Zl8tqJGsXRRT241pfz1ME5G6IziLWcd0tIVkpvs50QQ=; b=i2B5hA6fKMHDbJ3APtXNAKBeY8pxRJY5KJrz2DAUM2NqeKSVmNKsCV5tSzokJaKuS3DldQ LrpqINv12IKPWBT7cizkH9kHmvFT2pyL/623Z3Y0t+rQlsJuUm02PMJn5+WZ7ACFQOAIvO ZmBUobc6u69ClZ1neVXxTlX3rl2SDKc= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-399-s0FA0xZTPBCbbcrfqvKplA-1; Thu, 03 Jul 2025 19:23:29 -0400 X-MC-Unique: s0FA0xZTPBCbbcrfqvKplA-1 X-Mimecast-MFC-AGG-ID: s0FA0xZTPBCbbcrfqvKplA_1751585009 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-6fb1be925fbso4682806d6.1 for ; Thu, 03 Jul 2025 16:23:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751585008; x=1752189808; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Zl8tqJGsXRRT241pfz1ME5G6IziLWcd0tIVkpvs50QQ=; b=scUT1iNfUrkLkkoefe3FmstMJRP86Hu1Po7EEvS7VbGOwXoFxAYcI+tzVwbCRDi4pF ryImqmvLLPlVprdyYp5K4be2xfof1GnWY2HDChBID2oqBZnAv42dFAiEj5ZGuqKCl5pC Ec3tyQWGy2FhFWHRDc/rcU6mh+62wkghlio6cMXq9Wv9vT5iT6dYk8+dnSTurAKgNg3G ecqidoLO4jaQ+1EpkQNfuBTWJEa7YUtr2Y8DM9RH42nI9Z9mvgCF2YKkqfFgGDp4iHK3 EVxUyKdwYfUfHwVwI/jf8bQgMNsbjfIOGIN/xYpWxvhO+9AogjPomc6AED3bj0yJAvza mqdA== X-Forwarded-Encrypted: i=1; AJvYcCUNRPqV9xT7SYZbfVwUhyy8ZCrM7bhFloGYIgqpfBbmGBdBOSdWCQ1wbaIrDhFW/pdE/xT64m88tUYO8Q==@lists.linux.dev X-Gm-Message-State: AOJu0YyqYfW/EtWaCe5WsEgx5NdQbScP4EXB9gbq8NdeKtS6ecm2i4Jt VtxTCecDEfGEmhyWA57ZTt7Xwry4grzXDQ66IMcs0LFJ/izMHYUxrdZA+sNfTSKKD101Q6/CmDh cdL/RE75yJjBAYqRZsnhX0tNqFgi9kWuWV/34ZJVPnLl6aRK7kXqDEhRemfZMspKh X-Gm-Gg: ASbGncuqPtRIVs2NXo7AmrWdxZHPsy82l5jqELY2i/bXLLcDI7mEhXWk++5iNWHrXfL JnyBisjoNyb8hp8IMoLRNUdnLqXT55riIT7CSfzvnXxzPq0+s8RbEOLfK1koaSHDwVHK/QdWit3 /iQsFiW1GLZfzotjICH3h6oYO2ByvahXkfle0y4y4j2D3e9CTm54E5cXlzRWziWQin4cgWnwZaw Ta+emGvNEbvcA/FV9WrCPk8GUyXOveFKmX9HLzYFpOIejTbfe5DYzmyPRVuiomD4mWivt4WB7wp V7rixZPkDfMXOqPHVJD8aDmE3OWG9hj2F2GB609xP9xV+aYVWcgHktrsLr710Q== X-Received: by 2002:a05:6214:202d:b0:6fd:74df:896 with SMTP id 6a1803df08f44-702c6d0108fmr3206376d6.3.1751585008537; Thu, 03 Jul 2025 16:23:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEtEKstDD58UA9ynnp87TZzDRG0nHv8TZdipy2JJJ0KGfqawoV2yWwrMW4WiJnElhNazWCQfg== X-Received: by 2002:a05:6214:202d:b0:6fd:74df:896 with SMTP id 6a1803df08f44-702c6d0108fmr3206086d6.3.1751585008137; Thu, 03 Jul 2025 16:23:28 -0700 (PDT) Received: from [192.168.1.15] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-702c4d5a958sm4469956d6.84.2025.07.03.16.23.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jul 2025 16:23:26 -0700 (PDT) From: Brian Masney Date: Thu, 03 Jul 2025 19:22:33 -0400 Subject: [PATCH 09/10] clk: sunxi-ng: ccu_nkmp: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250703-clk-cocci-drop-round-rate-v1-9-3a8da898367e@redhat.com> References: <20250703-clk-cocci-drop-round-rate-v1-0-3a8da898367e@redhat.com> In-Reply-To: <20250703-clk-cocci-drop-round-rate-v1-0-3a8da898367e@redhat.com> To: Michael Turquette , Stephen Boyd , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Bjorn Andersson , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Maxime Ripard Cc: linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-sunxi@lists.linux.dev, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1751584976; l=2425; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=MG6R6xLI8D2rCtfPyeozFwBeKwPJHUOoxhsT2UMyvnU=; b=gtIoYUrg7pKik5I/T79/xPlRf6FIf6RrEY9VaGQ5cG9HAHNGprjV14FnyjTOfqDKEtgskKdxi LMUL+S4rLZMAOnlypm4OupDw0dn6pZZJxEd6jy2V8Nc2541mBH3ukUS X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: e-ngy7Wk9DDDZFoNrIkn-CD1ZzIjsiqIB0VeRsBbpHw_1751585009 X-Mimecast-Originator: redhat.com Status: O The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/clk/sunxi-ng/ccu_nkmp.c | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/clk/sunxi-ng/ccu_nkmp.c b/drivers/clk/sunxi-ng/ccu_nkmp.c index 6e03b69d402848b237154319d2296ffb4133a213..25efb5b3760759f2943737856246ce93000ebf05 100644 --- a/drivers/clk/sunxi-ng/ccu_nkmp.c +++ b/drivers/clk/sunxi-ng/ccu_nkmp.c @@ -127,20 +127,20 @@ static unsigned long ccu_nkmp_recalc_rate(struct clk_hw *hw, return rate; } -static long ccu_nkmp_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *parent_rate) +static int ccu_nkmp_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct ccu_nkmp *nkmp = hw_to_ccu_nkmp(hw); struct _ccu_nkmp _nkmp; if (nkmp->common.features & CCU_FEATURE_FIXED_POSTDIV) - rate *= nkmp->fixed_post_div; + req->rate *= nkmp->fixed_post_div; - if (nkmp->max_rate && rate > nkmp->max_rate) { - rate = nkmp->max_rate; + if (nkmp->max_rate && req->rate > nkmp->max_rate) { + req->rate = nkmp->max_rate; if (nkmp->common.features & CCU_FEATURE_FIXED_POSTDIV) - rate /= nkmp->fixed_post_div; - return rate; + req->rate /= nkmp->fixed_post_div; + return 0; } _nkmp.min_n = nkmp->n.min ?: 1; @@ -152,12 +152,13 @@ static long ccu_nkmp_round_rate(struct clk_hw *hw, unsigned long rate, _nkmp.min_p = 1; _nkmp.max_p = nkmp->p.max ?: 1 << ((1 << nkmp->p.width) - 1); - rate = ccu_nkmp_find_best(*parent_rate, rate, &_nkmp); + req->rate = ccu_nkmp_find_best(req->best_parent_rate, req->rate, + &_nkmp); if (nkmp->common.features & CCU_FEATURE_FIXED_POSTDIV) - rate = rate / nkmp->fixed_post_div; + req->rate = req->rate / nkmp->fixed_post_div; - return rate; + return 0; } static int ccu_nkmp_set_rate(struct clk_hw *hw, unsigned long rate, @@ -227,7 +228,7 @@ const struct clk_ops ccu_nkmp_ops = { .is_enabled = ccu_nkmp_is_enabled, .recalc_rate = ccu_nkmp_recalc_rate, - .round_rate = ccu_nkmp_round_rate, + .determine_rate = ccu_nkmp_determine_rate, .set_rate = ccu_nkmp_set_rate, }; EXPORT_SYMBOL_NS_GPL(ccu_nkmp_ops, "SUNXI_CCU"); From patchwork Thu Jul 3 23:22:34 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Masney X-Patchwork-Id: 1472 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B28A2F2730 for ; Thu, 3 Jul 2025 23:23:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751585019; cv=none; b=U3BFMr0byrQ2uyBD3sJ2BwvX283C3F3cLMe86Ud0EMK1WTPoPrCi94AkwOA+yK0+DqYq5zeK7FiZOdLHMmIkqSzK8t4fwvsCj+GfWOs0fFBFKxMPhHCXogyrwfiigGkCkhaJpOgV1LgAKKsYKEzwdpM6iCiTLMYJxGxgqVH6Bu4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751585019; c=relaxed/simple; bh=4fRm/4wvZQWe/TuI4l5eob8PB/NYw5v9nV4VOmFwTUI=; h=From:Date:Subject:MIME-Version:Message-Id:References:In-Reply-To: To:Cc:Content-Type; b=YyXD410Wfztbf3+FyNGB773p6aXFSM8eOydNOUkv9LEbe6YnGSJa2AR1sfG1NqIOtMibgZ/JIm7jFroQiCX5R6X3KO24S/nrk8yoWL0pSFC9ubIaDhgj9yoyOfn0vkVRgkxxNkbHdCZkv9BVU/vl+BcMLrIHpM5XUpZenFEK1d8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=dDXwpA15; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dDXwpA15" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751585016; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vIUTPB0Xa7IujQxGdU5BbuzZFcJXYmPAbUo0ojDRNf8=; b=dDXwpA15y2I93i0v8KfFVnloMDZg2k8t9As4vgZ44xQAIjcOYGhZvKnbf6m+1UokM+Y87y AJ9x6W19eea5+wQSZWSTK4gxrmma8OrBVasjJPKV5FhM12WFUKltKYtPxkewcwa2P/W1/h V7Ur1312mewcbNkx0/5A1IqPQiJQ6y4= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-213-39DhAYGOM16TkEkAWBXRiA-1; Thu, 03 Jul 2025 19:23:33 -0400 X-MC-Unique: 39DhAYGOM16TkEkAWBXRiA-1 X-Mimecast-MFC-AGG-ID: 39DhAYGOM16TkEkAWBXRiA_1751585013 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-6fd0a3f15daso11255086d6.2 for ; Thu, 03 Jul 2025 16:23:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751585013; x=1752189813; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vIUTPB0Xa7IujQxGdU5BbuzZFcJXYmPAbUo0ojDRNf8=; b=dFm/oU03gAF2WdB9tXvDfnRErbXKqOzC83eIf9uEHZ7b8L3U4Rid2M+kXbl2baBoQa w3BGdk5SO2QUJ6QHcXWxYoj/QH3d3uCFoTKIuk0LTdJnh1eiGT7PByCW18YAg9UhxV4q q6Y0cAPKU0W6Th6lARVoTw2W+kjsUc+6b/LY0hg/VmNQzIIN6Z+LIFqkohWXXdMKZIJR +CwfvTVAZohf0hV8+J68crE662nWz4Bh2wfj/LRiKOast6NOPsZQjZk+m52vXbOmmuIY 3pcLuleN9glX/gLVpo1A2awUkiKR44kvRCqaAAvFwptyHBmvev628+TZDcV3khoy+8Tx 8NPQ== X-Forwarded-Encrypted: i=1; AJvYcCWJuYVpXYt5EtioCU9qdnKTj/IeUO+D2gH0zFB0aQixS3QNxJT7T4JFx5iyjCcZiGkx9ZsPwOq2ZnMnmA==@lists.linux.dev X-Gm-Message-State: AOJu0Yx0o8sWQLTSbB6Cg7anok5N8iBdJTs5uP/fkUfDlhwNexfpy6E0 Vc4d/ApUhYOpUKrEEmStAWbTQdpkq9cpj8ZWqoS18leExxjF8Me0omuzMOqxqPolg8bChS2Xq5y ky5mQVwUHYqUH2eWJASQ+jZCXjnEwTTj2VvYYxbw+MuSWP1NM6Mt2BGXVO8NzMXHQ X-Gm-Gg: ASbGncsOlcgMGGMyeK+KXQo0Q426vXNGeiSwj21R0LpPDzbyepF0n/msDsjpuzBGAG+ OnsNhTWxsEUgx6877c7ZhYTJNUSVd/YI8YZWW4gCTNa6xjFRQeXfAlIClmINWerFRfFZYEj8Eya Tb7f8xktwJybsdBQ1ZLc84XEgG36mLpN1N0y+cnEwlf8feAwMp6HECQK8G4Z7DeF2esliI99tQY 48ZNVs8hdnJB3NX0klfOgc14Co6sL8yZB8yU9qJRs2yQ+ZECVMuJAIjbQkI/+X+t21lJZAQmMqA Y7DpTM4DNy1KJ9msz2ee2iGR3+2VpHoPH9kuood04bIUZ82qk1Tw1nVXdUuQeA== X-Received: by 2002:a05:6214:400f:b0:701:945:68a0 with SMTP id 6a1803df08f44-702c6db6d72mr2550876d6.26.1751585012814; Thu, 03 Jul 2025 16:23:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGsLP+EtTPJqTbUAM3azCv14keKHQHBVX2XiZhb2AArhva5ftrpXUEhswiQr1GgZeMTOKJdIA== X-Received: by 2002:a05:6214:400f:b0:701:945:68a0 with SMTP id 6a1803df08f44-702c6db6d72mr2550676d6.26.1751585012507; Thu, 03 Jul 2025 16:23:32 -0700 (PDT) Received: from [192.168.1.15] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-702c4d5a958sm4469956d6.84.2025.07.03.16.23.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jul 2025 16:23:29 -0700 (PDT) From: Brian Masney Date: Thu, 03 Jul 2025 19:22:34 -0400 Subject: [PATCH 10/10] clk: sunxi-ng: ccu_nm: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250703-clk-cocci-drop-round-rate-v1-10-3a8da898367e@redhat.com> References: <20250703-clk-cocci-drop-round-rate-v1-0-3a8da898367e@redhat.com> In-Reply-To: <20250703-clk-cocci-drop-round-rate-v1-0-3a8da898367e@redhat.com> To: Michael Turquette , Stephen Boyd , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Bjorn Andersson , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Maxime Ripard Cc: linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-sunxi@lists.linux.dev, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1751584976; l=3661; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=4fRm/4wvZQWe/TuI4l5eob8PB/NYw5v9nV4VOmFwTUI=; b=fvx7qhP1aLoIOPU3sjNvBCth81x2jcOY/I9wnn1tKMT2BbPA4cFWn1Ytapjub1E1HqAvCp+zr RDPpPrT6r0wCY9IQ3u30PGRfoAmv/kGQTGOqlafbNKX0lErw2qUupAD X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: vFF3E5yDxfeGE46EeGVofvSvh86cOHMvemIwCWLJmIo_1751585013 X-Mimecast-Originator: redhat.com Status: O The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. I manually fixed up one minor formatting issue that occurred after applying the semantic patch: req->rate = ccu_nm_find_best(&nm->common, req->best_parent_rate, req->rate, &_nm); I manually changed it to: req->rate = ccu_nm_find_best(&nm->common, req->best_parent_rate, req->rate, &_nm); Signed-off-by: Brian Masney --- drivers/clk/sunxi-ng/ccu_nm.c | 43 ++++++++++++++++++++++--------------------- 1 file changed, 22 insertions(+), 21 deletions(-) diff --git a/drivers/clk/sunxi-ng/ccu_nm.c b/drivers/clk/sunxi-ng/ccu_nm.c index a4e2243b8d6b4a8fdd9ea1ff2ca06e2f1a009632..df01ed3b37a6b56e93e18cc4c1ad5909e2ba0c5b 100644 --- a/drivers/clk/sunxi-ng/ccu_nm.c +++ b/drivers/clk/sunxi-ng/ccu_nm.c @@ -116,39 +116,39 @@ static unsigned long ccu_nm_recalc_rate(struct clk_hw *hw, return rate; } -static long ccu_nm_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *parent_rate) +static int ccu_nm_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct ccu_nm *nm = hw_to_ccu_nm(hw); struct _ccu_nm _nm; if (nm->common.features & CCU_FEATURE_FIXED_POSTDIV) - rate *= nm->fixed_post_div; + req->rate *= nm->fixed_post_div; - if (rate < nm->min_rate) { - rate = nm->min_rate; + if (req->rate < nm->min_rate) { + req->rate = nm->min_rate; if (nm->common.features & CCU_FEATURE_FIXED_POSTDIV) - rate /= nm->fixed_post_div; - return rate; + req->rate /= nm->fixed_post_div; + return 0; } - if (nm->max_rate && rate > nm->max_rate) { - rate = nm->max_rate; + if (nm->max_rate && req->rate > nm->max_rate) { + req->rate = nm->max_rate; if (nm->common.features & CCU_FEATURE_FIXED_POSTDIV) - rate /= nm->fixed_post_div; - return rate; + req->rate /= nm->fixed_post_div; + return 0; } - if (ccu_frac_helper_has_rate(&nm->common, &nm->frac, rate)) { + if (ccu_frac_helper_has_rate(&nm->common, &nm->frac, req->rate)) { if (nm->common.features & CCU_FEATURE_FIXED_POSTDIV) - rate /= nm->fixed_post_div; - return rate; + req->rate /= nm->fixed_post_div; + return 0; } - if (ccu_sdm_helper_has_rate(&nm->common, &nm->sdm, rate)) { + if (ccu_sdm_helper_has_rate(&nm->common, &nm->sdm, req->rate)) { if (nm->common.features & CCU_FEATURE_FIXED_POSTDIV) - rate /= nm->fixed_post_div; - return rate; + req->rate /= nm->fixed_post_div; + return 0; } _nm.min_n = nm->n.min ?: 1; @@ -156,12 +156,13 @@ static long ccu_nm_round_rate(struct clk_hw *hw, unsigned long rate, _nm.min_m = 1; _nm.max_m = nm->m.max ?: 1 << nm->m.width; - rate = ccu_nm_find_best(&nm->common, *parent_rate, rate, &_nm); + req->rate = ccu_nm_find_best(&nm->common, req->best_parent_rate, + req->rate, &_nm); if (nm->common.features & CCU_FEATURE_FIXED_POSTDIV) - rate /= nm->fixed_post_div; + req->rate /= nm->fixed_post_div; - return rate; + return 0; } static int ccu_nm_set_rate(struct clk_hw *hw, unsigned long rate, @@ -233,7 +234,7 @@ const struct clk_ops ccu_nm_ops = { .is_enabled = ccu_nm_is_enabled, .recalc_rate = ccu_nm_recalc_rate, - .round_rate = ccu_nm_round_rate, + .determine_rate = ccu_nm_determine_rate, .set_rate = ccu_nm_set_rate, }; EXPORT_SYMBOL_NS_GPL(ccu_nm_ops, "SUNXI_CCU");