From patchwork Thu May 1 19:06:50 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ovidiu Panait X-Patchwork-Id: 1734 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F7332236FA for ; Thu, 1 May 2025 19:07:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746126461; cv=none; b=oqKdlYGYNDERJvLh1yYh+3iKsUiNHgI+8h5tJCl+niquRS3PY6O4FOkEFymmH7lNNFIQEnsUY/AysHgcdnWoBSKBLBXH6zpYNQmqjzLyfevZdFU4ihHk/qvz4ahXqbEBy02DbWehzdGXdtee8ss6HasZpI0GOpccHsE3yH43HCQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746126461; c=relaxed/simple; bh=2PjYxqC2TvoFNeTYXNE58FNx+yDrrBK7F/NyaMPn/rE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=uZx9cVFScaAjxzrABM5RbTxg5USJmMQC4mPQJShsfpvMFoJNCU2Ihi5NQ89VfiWTsVu9s2NEthap6bmgjzyy0ToFos2asX+E7mMXaw/c0jXKmmE8QRp6jHwuKDnbEg0rbKNGmCqLBDnRQY7rWcJD+tkGWx8O5AgbKlHrzob9WoI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fY3SnDVI; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fY3SnDVI" Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-ac3fcf5ab0dso194506566b.3 for ; Thu, 01 May 2025 12:07:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746126458; x=1746731258; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=xYcnJfHyu9Qya9nm0+iaohPyzIhpcE4qtAIXaJuOv9M=; b=fY3SnDVISiC6ZSi4DyZBGo4Czy1ljacOp8WVrUNtUHPq2xyExsi8s0P6JBDiqolOGd 3EaewdsfkBubdzX9cku6qFQIJpneAtoD/xA862H+eDiwJfIxyiJwT3Yo4GGFKWzz2maF QVjLou4AaUO32jD3cq3FsELHFfG5pzfXrhD+VANDXpLjkUnq6PLP4cFAjsd5ekwfSgiA RLQyEPl0DyxGtKVXXuGla226MHdv7AQlaCR/V4oxDNWRDTMgalwB6Eb40MyHUvNTA1x7 vn2nq423Kcr7pp89Dta8C1cD6zGrSA+T4kQ8zdYm0Cxq+UPmZIskOBdNTZnwU5XMpzXj zWlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746126458; x=1746731258; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xYcnJfHyu9Qya9nm0+iaohPyzIhpcE4qtAIXaJuOv9M=; b=EKnq86I5RCmevkjlH3fABXJ7sb9e3JGE9DN13oQmTn2NIG2ucgUu24IdThB4vX09Wg CjimEjaINoea6kx4f+aQ8q+kI7fg10TOYha71WBh6f+tB0tkl5E7HLW3RoG4Tgl9UYt5 DeHk7S2+sxqLexTgZ80LqhGIi85zCk6ad+UdC/fUNj2pwZlvA3Nlx0crPkMuKqM8Ne+o 0p1TNNx7DDGVUlbJwHgaeBJyKseuAE9Ln+s7ElRDKFeaXIBvel3+0iU9C11E328Vck4o bHlo0YN0SObbH1ia4/hjZ6YgSkk8mD0Fbe4AwyEg+5CwPhV5ErVbPMQwm7OV4UIocLc0 I2Hw== X-Forwarded-Encrypted: i=1; AJvYcCVscO2Lx6bw9lDbK6aDUPG/5QSYcHMrYybweeVN3RrRg2VY0jvEPdAhCruD4uWGW54vSOmtpG7Ebh4w6g==@lists.linux.dev X-Gm-Message-State: AOJu0YxVhdU2Ta0aqVGRzsK+m7l7bpwnJF4mv6/MDJCY+ghGm8VpLqEw iP2jlNdS7dcVg28HINNG2D5tK8Ao67sec6+x2omBU1gLJhJPfzrd X-Gm-Gg: ASbGnctL3idpv2ts5nC26ZgvTN97n2PkvIX63JgKuCuf+5/PXEQFL9AP4lIUh5yCG6x /FQcFUdOf3rz5qkfQVxb42MXM+hS2xFe5iRR8BPMR2h/ov10VFQ/utEwL71b7XNwP8QiyovRrqu vi27lsS1bc4dPXuaA67qe+OoolDxjJ/Ul90d+mNuC0mslTaHyUnBerh+43Y+dTdxdLVvJr0id5g Dkw1uydt4vH11G2IJy+u6llfnxxAICG4Qpk3SvRcMegMZSECWR7RL4YEGCx8h5WCZ/fiHW5lyHX LuqglXaI5so2eI3frD41C0C8m3ynVwgVuks9MeYQumDxPU7TGO1us3kxsPQJ5HS0Csay X-Google-Smtp-Source: AGHT+IHfDMVIQ26ycHG3NCY+1odFkBcAwHTLJ2hCKHMBoEhxiuT8ZDLFmo0kkKjR+EXlLecp/8T5kw== X-Received: by 2002:a17:907:1b17:b0:ace:37d6:a5ce with SMTP id a640c23a62f3a-ad17ad819e2mr39669966b.19.1746126458067; Thu, 01 May 2025 12:07:38 -0700 (PDT) Received: from localhost.localdomain ([2a02:2f0e:c50a:8800:cf9e:ee0b:4a01:37f6]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ad0c70c6917sm80349266b.4.2025.05.01.12.07.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 May 2025 12:07:37 -0700 (PDT) From: Ovidiu Panait To: clabbe.montjoie@gmail.com, herbert@gondor.apana.org.au, davem@davemloft.net, linux-crypto@vger.kernel.org Cc: wens@csie.org, jernej.skrabec@gmail.com, samuel@sholland.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Ovidiu Panait Subject: [PATCH 1/2] crypto: sun8i-ce: undo runtime PM changes during driver removal Date: Thu, 1 May 2025 22:06:50 +0300 Message-ID: <20250501190651.3863582-1-ovidiu.panait.oss@gmail.com> X-Mailer: git-send-email 2.48.1 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Status: O The pm_runtime_use_autosuspend() call must be undone with pm_runtime_dont_use_autosuspend() at driver exit, but this is not currently handled in the driver. To fix this issue and at the same time simplify error handling, switch to devm_pm_runtime_enable(). It will call both pm_runtime_disable() and pm_runtime_dont_use_autosuspend() during driver removal. Fixes: 06f751b61329 ("crypto: allwinner - Add sun8i-ce Crypto Engine") Signed-off-by: Ovidiu Panait --- .../crypto/allwinner/sun8i-ce/sun8i-ce-core.c | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c index ec1ffda9ea32..658f520cee0c 100644 --- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c +++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c @@ -832,13 +832,12 @@ static int sun8i_ce_pm_init(struct sun8i_ce_dev *ce) err = pm_runtime_set_suspended(ce->dev); if (err) return err; - pm_runtime_enable(ce->dev); - return err; -} -static void sun8i_ce_pm_exit(struct sun8i_ce_dev *ce) -{ - pm_runtime_disable(ce->dev); + err = devm_pm_runtime_enable(ce->dev); + if (err) + return err; + + return 0; } static int sun8i_ce_get_clks(struct sun8i_ce_dev *ce) @@ -1041,7 +1040,7 @@ static int sun8i_ce_probe(struct platform_device *pdev) "sun8i-ce-ns", ce); if (err) { dev_err(ce->dev, "Cannot request CryptoEngine Non-secure IRQ (err=%d)\n", err); - goto error_irq; + goto error_pm; } err = sun8i_ce_register_algs(ce); @@ -1082,8 +1081,6 @@ static int sun8i_ce_probe(struct platform_device *pdev) return 0; error_alg: sun8i_ce_unregister_algs(ce); -error_irq: - sun8i_ce_pm_exit(ce); error_pm: sun8i_ce_free_chanlist(ce, MAXFLOW - 1); return err; @@ -1104,8 +1101,6 @@ static void sun8i_ce_remove(struct platform_device *pdev) #endif sun8i_ce_free_chanlist(ce, MAXFLOW - 1); - - sun8i_ce_pm_exit(ce); } static const struct of_device_id sun8i_ce_crypto_of_match_table[] = { From patchwork Thu May 1 19:06:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ovidiu Panait X-Patchwork-Id: 1733 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CE58224B15 for ; Thu, 1 May 2025 19:07:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746126463; cv=none; b=MXn6POw9G5kpJ0gE555vmtpkbnQj0QO5TqSjrI6DtTFyZyKYF+EBh/scf80Y+TuFNl+qof/tZhvtnzOEv7loU1v1byZhffvmqluNrkaqPtuZW1gADWD3vNyz6sbMNV/LBNjTrCHMh0mvgPnx69DKmoBWcilf0WTSM1tVTI2jhaE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746126463; c=relaxed/simple; bh=YXKPVxRR7Upwwq5LKZvZEYOzYl8UfelO+cPhSJKCGp4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lMARKkSt2OoZqvagynNR3dxzczovDw6amFX/gO1/0OHvIT8qd8k0yXTfcsia0xP3xsmNdA86kWmdWQUCcpQyy+Ppwzd0Kojb+9wt9KyyhNsInnEswjBCyZSkW1w5Jj9zfl0EnSZYDnCLZzw6vNcH65WCPeyDWK6EzIDaSXcHeJA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fk+tyrOo; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fk+tyrOo" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-ac2aeada833so246971766b.0 for ; Thu, 01 May 2025 12:07:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746126459; x=1746731259; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Qsp9CaqkI2nnPLo+C7isQc9cYVKQaKUwpPDF4hWhLBE=; b=fk+tyrOorac6vNphInLGlfGzSOjmh6DR301Ey29mHT1Bo7Nm4uWx7bVYVfm0brhqtL 2Uklxp/vk4vT+JC1qP+oAX6jZbcUp+o/itA9tcjFRa/Zq3muPYSQPtyzFafvwrW4OGN0 vq5jyoERHcJZ3PP5xwHvd8QKtfBK9Ddrwq315kLVORL7GLL5FfGudB3yvQyYipEUJ6oP sS2TKGh+p27zxGiuDiTeNE8rvfFzJ/rAq53rrDBwLRx/uAOB1JfadwT+4qXv2U2WlIJx fr6mrd8oBQRAivChodfvHU5k1LUQ+p+SMdH6rEU1TXNOg1NXCDF1EzPtOkezaGppfP0U KEjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746126459; x=1746731259; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Qsp9CaqkI2nnPLo+C7isQc9cYVKQaKUwpPDF4hWhLBE=; b=oq+77aGyjyaaBiHB6MhsGgXXhG63sRQi+tqLF2OoydvliP05wGGF+DR6WbasDTMLOC /serLonCSzBoLZCtX0OYrZ92ohfz23ncNqs+nupZGN+CbbStIU8az2QAzJp9AJc8v5oh TzlC3KJdQjTdluXfEwWb8Uv2/G75kvd/nG0fdXHgNMVYv3Dg6zuABiWR+GtXd8k7NlrK qKsoH+3kcg6KcdD5A2C+gANyU9iBcqJ/Wl78WGr+BJ5Ms7DZIil5cc7TyrkLIURXu7A2 b3UffHTOvVvkGvn++VFRAUjGazMwabu5dlmftG/HpLwMlx4R+KkT1GTvW3clWro1bZcT c0Pw== X-Forwarded-Encrypted: i=1; AJvYcCWkzhCGaGLUwUjHPgjAqp+I3tx1xY6nVZd7sbyoLPumFUt8f+nJZYzJFcO07foPEioPfPj52NeTyXcFRw==@lists.linux.dev X-Gm-Message-State: AOJu0YzGZ4tO+RTWpBgYXy23Tbwq2rDOpC9cMQW9v2/tGY4Kz8JjHbg9 +TUwb2h4qeERq+/CqdWqxROfEDzq7sCO+5yrZvp1TftJPlVn/ztK X-Gm-Gg: ASbGncssrR1MB+BSWrcmzeiD+dhcDs9Lk4lPkChGkW8ZEe3gl8+TeYZCpOHHobtJGDJ ZYdHmsZW8XRLfV/IDYQfkKFdZ9MlF9WK49cxDP5FA/D9c5ECNLLlQ/d+JkmmwVAlIXxJG4OeipE SL+F8KO+Ebj2lwy7pl5CgBjFekVWXBKh1NB/Cime4n0EnmUaNPBJD7STc/FIXf3bqeT97+uUBlA vCtnP5O+kwius7eh9Aepeoolx2A7+Q4jiyQ9LcYoCCRgX5pb/cHQCjn9pc3c5/6wIIkM3OJ5lv3 8TvVuEtF5gEyUCnO+I5GD/CUEPfkCLoooE6QVsBDgnb18iucQe2JA8wkYhTxOJahoavX X-Google-Smtp-Source: AGHT+IFPbjdkqPWUcDwWn3gcKgKCDuCT59+nrEo/GOkvbNTeX+sbsXL7iBibXH8JV2ff9RTUgMaADg== X-Received: by 2002:a17:906:4fc5:b0:aca:c67d:eac0 with SMTP id a640c23a62f3a-acefe63defemr318866466b.0.1746126459184; Thu, 01 May 2025 12:07:39 -0700 (PDT) Received: from localhost.localdomain ([2a02:2f0e:c50a:8800:cf9e:ee0b:4a01:37f6]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ad0c70c6917sm80349266b.4.2025.05.01.12.07.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 May 2025 12:07:38 -0700 (PDT) From: Ovidiu Panait To: clabbe.montjoie@gmail.com, herbert@gondor.apana.org.au, davem@davemloft.net, linux-crypto@vger.kernel.org Cc: wens@csie.org, jernej.skrabec@gmail.com, samuel@sholland.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Ovidiu Panait Subject: [PATCH 2/2] crypto: sun8i-ce-hash - use pm_runtime_resume_and_get() Date: Thu, 1 May 2025 22:06:51 +0300 Message-ID: <20250501190651.3863582-2-ovidiu.panait.oss@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250501190651.3863582-1-ovidiu.panait.oss@gmail.com> References: <20250501190651.3863582-1-ovidiu.panait.oss@gmail.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Status: O Replace pm_runtime_get_sync() usage with pm_runtime_resume_and_get() to simplify error handling. This is recommended in the documentation of pm_runtime_get_sync(). Signed-off-by: Ovidiu Panait --- drivers/crypto/allwinner/sun8i-ce/sun8i-ce-hash.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-hash.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-hash.c index ba13fb75c05d..bef44f350167 100644 --- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-hash.c +++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-hash.c @@ -65,12 +65,11 @@ int sun8i_ce_hash_init_tfm(struct crypto_ahash *tfm) crypto_ahash_driver_name(op->fallback_tfm), CRYPTO_MAX_ALG_NAME); - err = pm_runtime_get_sync(op->ce->dev); + err = pm_runtime_resume_and_get(op->ce->dev); if (err < 0) goto error_pm; return 0; error_pm: - pm_runtime_put_noidle(op->ce->dev); crypto_free_ahash(op->fallback_tfm); return err; }