From patchwork Wed Apr 1 19:14:40 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Skvortsov X-Patchwork-Id: 1983 Return-Path: X-Original-To: noreply@patchwork.local Delivered-To: noreply@patchwork.local Received: from sto.lore.kernel.org (sto.lore.kernel.org [172.232.135.74]) by mxe881.netcup.net (Postfix) with ESMTPS id DB8C01C003B for ; Wed, 1 Apr 2026 21:15:07 +0200 (CEST) Authentication-Results: mxe881; dkim=pass header.d=gmail.com; spf=pass (sender IP is 172.232.135.74) smtp.mailfrom=linux-sunxi+bounces-22769-noreply=patchwork.local@lists.linux.dev smtp.helo=sto.lore.kernel.org Received-SPF: pass (mxe881: domain of lists.linux.dev designates 172.232.135.74 as permitted sender) client-ip=172.232.135.74; envelope-from=linux-sunxi+bounces-22769-noreply=patchwork.local@lists.linux.dev; helo=sto.lore.kernel.org; Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sto.lore.kernel.org (Postfix) with ESMTP id 0A17E30185FC for ; Wed, 1 Apr 2026 19:15:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1EEF52AD0C; Wed, 1 Apr 2026 19:15:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nNAyNPF5" X-Original-To: linux-sunxi@lists.linux.dev Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92B7B2DCF4C for ; Wed, 1 Apr 2026 19:15:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775070902; cv=none; b=GxAuI/Wb/nKhazNVJAqZr+CleD/vyPRRGuVDcp+vMVcgoWllq6OJX1g/Ul4c/6KkrT9yHs/X6l03dHGsViG5cKcjwxTttfpUO8Ik2NDhUIJ5E68j5KU1AjdAziftDVezCMLfHKCR6I8zc4+iF8V62BCBd//ULGAlc8ZnLhrXfCI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775070902; c=relaxed/simple; bh=aOQvwFmNxOkcH3hY6TC/0qXbXfPYEsiczqDbdm09a6I=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=cVAaXhrW7c1cmfDG31PjD4WKkaW0D0PGFxGeX6B1cNhncgBQ7MXwWykEinqJzyVnPJIJbwD8GyCg05clgoTKKeNu0nrVauQr88F2AttDvtr/Qpcv9FX+kKcNX6Kt9lCT6kq1ZU9DqQumEmioA2E9b1U0dphyVflljymcVK7Z8zQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nNAyNPF5; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-5a2967e5de4so154189e87.3 for ; Wed, 01 Apr 2026 12:15:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775070899; x=1775675699; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=a53m1M0yPC+0hsBR8rulFA+iVXVX4Qv0HU8oZpgQDvA=; b=nNAyNPF5f8/4NWkS0aay42PkYX0B6b9yZrZR8xVv7Hd67Fos45oPHgRNW+0zZLI3P4 PxAiLnVo/SnJq1HYqVNtpDK/UUBho56dfz/+Z0Sut8/fonVQfNqA8fXrpzB/r8CyXsqm /0r+qMFcpA4IhYuH0VSNEQl6yFotlKJxCQVsh2iRTRY07+01vZubQ9bo4GF42NY9v9qP DDrtewfBcHvt2ZvzWJuI4CEC2fBhLhO/iUnQXXtmhKnlreOhoZ15Qi5UDKWOOTpOdrM0 lWWenVyD3b6pD+3Tp6TlXCl2/q1c0W25dI6II2VnW/OI6PnjQMBq9DQtPnUYGv9PC736 zNDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775070899; x=1775675699; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=a53m1M0yPC+0hsBR8rulFA+iVXVX4Qv0HU8oZpgQDvA=; b=RldJr0mPDIXMBywAG1YRRYfPRfvRs6OifMnl3rVD6KRPf3I7kZ8xXu6NUggCGn/ZLK +eJo6TL8oOsaEDYHL+jUGNB3CQ/j3ldpcNDKs80OwgSStq1Idr6dHvf2W2lP71TciXEC Hyrn/wcQS8onz0R2+w6FrkXmgckScIs3bSPmOvPxhtug4p4ej0deI9qxwCCK/cNpagcO /l3C+XKqm+ED3M3WJX5m03So2pmBvHNDJea9Kz4fYNawDgWfzWbtbBVfGx+Gqqk6uvvx EDaOK3ExjAX7g+B5H/JSEq8nJZu+QKfAI9pk2E+usLqFFcHmTBgd2Ha2T1vBDqN2xNEP g/wA== X-Forwarded-Encrypted: i=1; AJvYcCVffDcBy0tViqKrWZgmCww26UwYmRV3l0uCw01sGu0C8Q9edf46KY30MzBebY7dO7q7csG9iVF/J4tSBw==@lists.linux.dev X-Gm-Message-State: AOJu0YwmsNn4JcfNOrg6F28Zrv4/vULVoHQHNl2+d3skvR+TYA3aqFEj TRGevz+RidKX0l3KkcJEEOoEtlDbstg2rqeUEm/scobAZuYLDXaLKASL X-Gm-Gg: ATEYQzw0lhwD70BguEtsH8u7tY5HCtClNAF4eZmMNvn7ArYTL6UVOBqmoiLTa70qkw1 mhlqVoQ8ZGppo8IYmAt6J2v79CI5ja7oKGbiATxJwDog7R1FpT9zdJjqYMg5AFwsG0+XC8Yi0tW NAdVMtjy45hwNvA1J4AeczHz+Jkrd8epPDxJk/OTRX979mvFH65xltcBDmNeUW/q7dFdY0Lejts LOGvqR9c8mbSEjqMt5lYVuVUWwumK7O++6YBdrUOnNP3URso8IU/2Ngsoc1v6KdoLZBnmXn9DMn VeiROJs6AYvDG1UByXM4LfqFXBSwy+eXpZxB/dC5CqR5cOhg/ey4WhYmK//V2A9kmvc24CyLTAF W59luY653gHKpRMkj38AfBLILekJvg/hy2YbuNTrkcWAkxFPd/x44lcmNNESgxHPNYirT5hn/ex juGVBBzAIDu5HblvrCmgw1xwAm+A== X-Received: by 2002:a05:6512:3b87:b0:5a2:78fa:2700 with SMTP id 2adb3069b0e04-5a2c1f3c4d5mr1943599e87.23.1775070898394; Wed, 01 Apr 2026 12:14:58 -0700 (PDT) Received: from new-nest ([94.19.228.143]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a2c6ccca2dsm141855e87.60.2026.04.01.12.14.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 12:14:57 -0700 (PDT) From: Andrey Skvortsov To: Maxime Ripard , Paul Kocialkowski , Mauro Carvalho Chehab , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Hans Verkuil , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Andrey Skvortsov Subject: [PATCH 1/2] media: cedrus: Fix missing cleanup in error path Date: Wed, 1 Apr 2026 22:14:40 +0300 Message-ID: <20260401191441.1217646-1-andrej.skvortzov@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MORS-Enabled: yes X-MORS-DOMAIN: patchwork.local X-MORS-HOSTING: hosting172546 X-MORS-USER: hosting172546 X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= From: Samuel Holland From: Samuel Holland According to the documentation struct v4l2_fh has to be cleaned up with v4l2_fh_exit() before being freed. [1] 1. https://docs.kernel.org/driver-api/media/v4l2-fh.html Signed-off-by: Samuel Holland Signed-off-by: Andrey Skvortsov Fixes: 50e761516f2b ("media: platform: Add Cedrus VPU decoder driver") --- drivers/staging/media/sunxi/cedrus/cedrus.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/sunxi/cedrus/cedrus.c b/drivers/staging/media/sunxi/cedrus/cedrus.c index 6600245dff0e2..1d2130f35fffc 100644 --- a/drivers/staging/media/sunxi/cedrus/cedrus.c +++ b/drivers/staging/media/sunxi/cedrus/cedrus.c @@ -391,6 +391,7 @@ static int cedrus_open(struct file *file) err_m2m_release: v4l2_m2m_ctx_release(ctx->fh.m2m_ctx); err_free: + v4l2_fh_exit(&ctx->fh); kfree(ctx); mutex_unlock(&dev->dev_mutex); From patchwork Wed Apr 1 19:14:41 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Skvortsov X-Patchwork-Id: 1984 Return-Path: X-Original-To: noreply@patchwork.local Delivered-To: noreply@patchwork.local Received: from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114]) by mxe881.netcup.net (Postfix) with ESMTPS id 1C1931C003B for ; Wed, 1 Apr 2026 21:18:14 +0200 (CEST) Authentication-Results: mxe881; dkim=pass header.d=gmail.com; spf=pass (sender IP is 172.105.105.114) smtp.mailfrom=linux-sunxi+bounces-22770-noreply=patchwork.local@lists.linux.dev smtp.helo=tor.lore.kernel.org Received-SPF: pass (mxe881: domain of lists.linux.dev designates 172.105.105.114 as permitted sender) client-ip=172.105.105.114; envelope-from=linux-sunxi+bounces-22770-noreply=patchwork.local@lists.linux.dev; helo=tor.lore.kernel.org; Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by tor.lore.kernel.org (Postfix) with ESMTP id 69AD83044667 for ; Wed, 1 Apr 2026 19:15:16 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 984E133C536; Wed, 1 Apr 2026 19:15:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lFadfKeM" X-Original-To: linux-sunxi@lists.linux.dev Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 356CC23A984 for ; Wed, 1 Apr 2026 19:15:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775070915; cv=none; b=F7Ab0e0RyvmuSNg6Wv2HGlw+mwE0zzTwWvS/hOiJFDBPnW2pC6qdAFDdt6X+MEM1JZzoScnyZ5HHrGwQyGxDS2ZhRbXz74w9aPhMFM8dQcGNNrTh9tuhVlOgxwDljZ8b4qGlvOBjzXn9GRs5Tk0fnKyi9Ik65OEAdcAsNUVA2AA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775070915; c=relaxed/simple; bh=OJ8d86r1cv2Dz9K0VOKzDX9IeSSniN4yMPUR9rzI5RM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=B9wI7DTmSd9J5Hlfn21AzwQEl4ESp/6oqK4OZ7e4p83wBHdJSPxcAh0sq2gLz1Do7zHiAz61EsgYdy/aMXPtC1+J87Q5IetdBMfV4FbQ0fdGKUC1SFuh1oaP4jJYloaPvS9WpNURM0e/YdRnjlfKG1xCR+u1+hvJxZ6qqfv5UoU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lFadfKeM; arc=none smtp.client-ip=209.85.167.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-5a0ff30b240so192950e87.0 for ; Wed, 01 Apr 2026 12:15:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775070912; x=1775675712; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=r8KcYzflmFoH6kQuwH+mgkFuRmADtPPTvOe6lcVTKSM=; b=lFadfKeM8LfUepjK8L+7IPkc8R9HMlRmB6zTa9NSMS0cwYl9EXZZKVC5KJRhnkcNg+ RejIqVj3NpLyFmVysdVz9/Y1WJ5YMtSkc/4z7iJgZADziyEZBJL+B7JUUqZnZYRW/B/p 0OYWjBIy5vg14N31i1nuhS7+FSxvQEqpXZf9HHSeSKzQOfdmozvA+qVlYW4gB5KIeQHn /P3cxPntC7sTKQnjVddz3Qw8+RqIeQ4/HivgByfVsuv36RfFi5HiS0FHXgyNHEvvK8Q9 rpscdMpbpq/1kdlQSqDJJDW1G/Wnzuvl70NX4wo/KkAhs/ED2tR3LLPbuGiSRlpKbIaC tx/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775070912; x=1775675712; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=r8KcYzflmFoH6kQuwH+mgkFuRmADtPPTvOe6lcVTKSM=; b=EHm+R1P/wdz8DgNpa+pklwKwI8Mxv6oHfnDIWB1KX+i+qYE2hFI5GmrV6HjBdcgjgp 88vD0mTO1pRxreCv6jg02jCm0lwiqxTMAna3qxNGPuPg0Iulo0EDfLcSL0Of4Ih+bu6c 6FVG8a76s+w5W74w7twiwyKH836eUc67PQrX2MHomKkXgRaG1ujNz9U81MHemaHBymL1 tDT54uelCATyetsNI4s/lB9kll7dqmix8TUsIsqPh/hY7/SoqklqD+TAkKOG3W7iXZ2B QIhhDmaz30omyvSoGBbkHaOVm7NutcGM4T8VJChYnjl7SEkmGjek5ekATQU6QePDlzB2 I6ng== X-Forwarded-Encrypted: i=1; AJvYcCVIY+t1dgvVgRxByq6MKsxY0mHUoGweV5IpLi2kOfU8NPWrmJqXTVMa0sNbYUAANnxNgB8fLmh7coUobQ==@lists.linux.dev X-Gm-Message-State: AOJu0YwQGLhI/S2buKJTccTozuwOcLmxXZGQzOCr+DBNzLWu64x7Iz4y rfyGKVG4dqFsl1NJfeJvutLF463CucBnKwJwOhZpZJCbKyv5ASJ+VuUs X-Gm-Gg: ATEYQzwR/e6jQ0TQ9xVQ59V0GFL1ZR9mFt4spbfSfKlGsa93+uVyO3ymrrYIZ2Wd6dq 2EYINLgmswwVKIgV7Bp0PW/Z3RFNg+46jMO1xhZt4SLxqrjT3gL6lgcgMYjX2VsIIt5H+eaiurd 3Iejhmh8m3R9W9RVekDEq0AahdXCQJnhDV/YiLT7ltxEwuknJRRrMnMENDV2Lf/uI1gIUwMV7lS GS4akfYtDcNZyiyBhVpb5cQDiwkmmtGATN20J/zCjuTsRLQjNUSxlcf8rCm2Nk8i2+a9+L3wM37 5eeBvlMpIdYaM3ps8bfuy2ry9xu930jPEFDdUgGvQ1ReI3FwKUqaA6JEZ+tHrUC5GzI5eDe1d+g 6uykEe7bCf/G9OQjT448hmunjazfNMuX237kv5kVleX+1qnVuMLVhBMrL7TlK9uUlsQSRVjdLwM Emj6pRhrwjF1YPei2rLRXHJ01oQwsQrt5arBLm X-Received: by 2002:a05:6512:318e:b0:5a2:961a:f7c7 with SMTP id 2adb3069b0e04-5a2c7676402mr92043e87.21.1775070912245; Wed, 01 Apr 2026 12:15:12 -0700 (PDT) Received: from new-nest ([94.19.228.143]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a2c6ccca2dsm141855e87.60.2026.04.01.12.15.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 12:15:11 -0700 (PDT) From: Andrey Skvortsov To: Maxime Ripard , Paul Kocialkowski , Mauro Carvalho Chehab , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Hans Verkuil , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Andrey Skvortsov Subject: [PATCH 2/2] media: cedrus: Fix failure to clean up hardware on probe failure Date: Wed, 1 Apr 2026 22:14:41 +0300 Message-ID: <20260401191441.1217646-2-andrej.skvortzov@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260401191441.1217646-1-andrej.skvortzov@gmail.com> References: <20260401191441.1217646-1-andrej.skvortzov@gmail.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MORS-Enabled: yes X-MORS-DOMAIN: patchwork.local X-MORS-HOSTING: hosting172546 X-MORS-USER: hosting172546 X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= From: Samuel Holland From: Samuel Holland cedrus_hw_remove undoes, that was done by cedrus_hw_probe previously, like disabling runtime power management, releasing claimed sram. Signed-off-by: Samuel Holland Signed-off-by: Andrey Skvortsov Fixes: 50e761516f2b ("media: platform: Add Cedrus VPU decoder driver") --- drivers/staging/media/sunxi/cedrus/cedrus.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/sunxi/cedrus/cedrus.c b/drivers/staging/media/sunxi/cedrus/cedrus.c index 1d2130f35fffc..ee0e286add67d 100644 --- a/drivers/staging/media/sunxi/cedrus/cedrus.c +++ b/drivers/staging/media/sunxi/cedrus/cedrus.c @@ -477,7 +477,7 @@ static int cedrus_probe(struct platform_device *pdev) ret = v4l2_device_register(&pdev->dev, &dev->v4l2_dev); if (ret) { dev_err(&pdev->dev, "Failed to register V4L2 device\n"); - return ret; + goto err_hw; } vfd = &dev->vfd; @@ -538,6 +538,8 @@ static int cedrus_probe(struct platform_device *pdev) v4l2_m2m_release(dev->m2m_dev); err_v4l2: v4l2_device_unregister(&dev->v4l2_dev); +err_hw: + cedrus_hw_remove(dev); return ret; }