From patchwork Thu Mar 5 03:34:07 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yuanshen Cao X-Patchwork-Id: 312 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76495221F26 for ; Thu, 5 Mar 2026 03:34:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772681655; cv=none; b=EHKXnaYlPR6sLrEgtvVL2DfI8Ua4YcDbo20yiNvB+9gKmH+dKCqSlcWt+yZToTsvH6ptpNFhPTUByK8B4vydNZi06i8Enhx0E6mWQn4O5rqae72yanWaF7V4QkrXbLByAVkic4JtxETBPvAkj2ElDlzcFYBCCF4Qy4wabJNBNhA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772681655; c=relaxed/simple; bh=G93cII+3A1u7CvKJrZXIJlpca2wo8XCXaCLCELHybVQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kJlik7lxo03ko+JMYRDHFycc009Qm+lbP0kxC/i69VXVemgvWNdYEYx5Bss9Rfsq7lW3cQbqYQ6MJDRbXURec1KZKcu2jPj0z3zGCy68TfaoX8091DEoQeeeNHFyRNy2N8f00kQRQ43FbC1w0FLz5SBRi4jR4/6ouuj3mGvIz/Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VU6U1PvY; arc=none smtp.client-ip=209.85.160.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VU6U1PvY" Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-506251815a3so67642931cf.0 for ; Wed, 04 Mar 2026 19:34:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772681652; x=1773286452; darn=lists.linux.dev; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=GoyJS43DjogCNIlYUyLOl9RH46vOQLUOd3a+06hfz+Q=; b=VU6U1PvYVoDuFZg3hwqfT3zAhKwT5AaNZnF96/hMIN3AiHjRe5vYV77k3jBT0eMoe5 I9nbK0LOyc/vyzq0zW4MsHFdM3QTJ4VjYliKuKpERKGHm08Wzyja7TyGIvYyiTRYdcnm m3R7qJgZeRWmROfI7V0IxF5SyW0pClfkFLCbrYJxcZbTXb/98jznd1yE7RiDb+47YH9Z hPqsfTDXHC/eSUq7bkWy1KBKiwLASRLdJOQMpO1K8QxGAFsykLMn+YxAZzBfX/kb7AV1 cTXP/+6yNRAm65+w1/FpFUf5OsbTQ4Mjapudg6PP9hNZNFS8AkI4JuvlRTh6dNWi8YU+ 1NZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772681652; x=1773286452; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=GoyJS43DjogCNIlYUyLOl9RH46vOQLUOd3a+06hfz+Q=; b=AXXytbIlk3GyArtoR3qcn4F6n1czzCXu3HtLXqvAoL7SidWD/ew83m7C5IH1sozyf1 QqLBJxstO2JdrNO2yYoNZCNXVu3IAjXyQ56byvUuGEiurlQuPI/ezTnY8pSzrprwlXk9 xpRgHYjEPQ+olNJK0fSXgZQtksPp8lU5Fy9ZulDPvAOC6ZmZ4yqMub1h6HKpWCrqzfkx KkFuaR85PAKsz2YvhOi/X5/V6aK1aTW+g00hOo/d/5tWXsWB0F0j7NfrO2qVm34mw/8i ULK5f7CwWEkgI1oxMJO2Vms+BU/JCdAIYempdNUKItbvtpG4zA3ivqunpuuoStLHvsHJ gs9Q== X-Forwarded-Encrypted: i=1; AJvYcCU0Fg0cOdY0G3WZ8YuGsrkQwIGuosrEfT/EEEXaMMXKlC46KMx7C7ANuoCYrQMvuB0gOcnhMvSzcumCEQ==@lists.linux.dev X-Gm-Message-State: AOJu0YzLUCI+ZzvXelwS20JIxw68Sqoi3qGHx9R0KlML2K1R9GezxGU5 QBKXfjqbHZUxcyaQPbcDkhtUEJgZilO/kQNXwn791pueBAqU36y8bYgZ X-Gm-Gg: ATEYQzzL5JGUgYpMIKqq2+0eRN4qdWljCIJEAxQaqeTfL8GzMLdmRnKWBN3HGjouoZN oukH8WlAHNw0zO1qdfAb4n/ZvNtV7bV6UlsX19W6h/IceuxSQ7TlfkCJ138Z5IRH3ccBnLy7thh dqP/YMmBD7sEwCkro20RllUQGfuhJYyRsn8vhQlRLEhp66gif6vVjtK+D3RcEBwgqSClmuu2WVL FZ3CoOcfo3pN13lPNo/xAmLsKk1rKRmwmBgLOQCEbO/U6TiygWjiDzEhsYxEtzXU/SPUxNeSNP6 9loVT5mx9mP5X3vNqjWLK6lhUai2pRP0AFf83VXx56CMCsYJb/kk1zPMLYJUT/TQVN0vuK83mQt 5fOeJ74gG1C18Dg3yKjPoCg+OwhRWTM7N3N0YyFF8+uJBdkNH1JNsUFx8OME994kup5e8IG8sF+ 8Y/G2YsV79ydroo/s4bGRjtbanxYQ= X-Received: by 2002:ac8:5a82:0:b0:502:9e93:617d with SMTP id d75a77b69052e-508db36395dmr51002631cf.46.1772681652477; Wed, 04 Mar 2026 19:34:12 -0800 (PST) Received: from [172.17.0.2] ([134.128.219.200]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-507449630b6sm190667601cf.7.2026.03.04.19.34.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 19:34:12 -0800 (PST) From: Yuanshen Cao Date: Thu, 05 Mar 2026 03:34:07 +0000 Subject: [PATCH v2 1/2] dt-bindings: power: Add Support for Allwinner A733 PCK600 Power Domain Controller Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20260305-b4-pck600-a733-v2-1-ba6bbed7d253@gmail.com> References: <20260305-b4-pck600-a733-v2-0-ba6bbed7d253@gmail.com> In-Reply-To: <20260305-b4-pck600-a733-v2-0-ba6bbed7d253@gmail.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Ulf Hansson Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Yuanshen Cao , Krzysztof Kozlowski X-Mailer: b4 0.14.3 Status: O The A733 PCK600, similar to A523 PCK600, is likely a customized version of ARM PCK-600 power controller. They share the same BSP drivers in the package provided by Radxa, with the only difference being the lack of resets. Therefore, document A733 compatible and make resets required only for the other models, as well as prepare the PD definitions for future device trees. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Yuanshen Cao --- .../bindings/power/allwinner,sun20i-d1-ppu.yaml | 17 ++++++++++++++++- .../dt-bindings/power/allwinner,sun60i-a733-pck-600.h | 18 ++++++++++++++++++ 2 files changed, 34 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/power/allwinner,sun20i-d1-ppu.yaml b/Documentation/devicetree/bindings/power/allwinner,sun20i-d1-ppu.yaml index a28e75a9cb6a..b97361ce2a00 100644 --- a/Documentation/devicetree/bindings/power/allwinner,sun20i-d1-ppu.yaml +++ b/Documentation/devicetree/bindings/power/allwinner,sun20i-d1-ppu.yaml @@ -20,6 +20,7 @@ properties: - allwinner,sun20i-d1-ppu - allwinner,sun55i-a523-pck-600 - allwinner,sun55i-a523-ppu + - allwinner,sun60i-a733-pck-600 reg: maxItems: 1 @@ -38,9 +39,23 @@ required: - compatible - reg - clocks - - resets - '#power-domain-cells' +allOf: + - if: + properties: + compatible: + contains: + enum: + - allwinner,sun8i-v853-ppu + - allwinner,sun20i-d1-ppu + - allwinner,sun55i-a523-pck-600 + - allwinner,sun55i-a523-ppu + + then: + required: + - resets + additionalProperties: false examples: diff --git a/include/dt-bindings/power/allwinner,sun60i-a733-pck-600.h b/include/dt-bindings/power/allwinner,sun60i-a733-pck-600.h new file mode 100644 index 000000000000..cf476a005b55 --- /dev/null +++ b/include/dt-bindings/power/allwinner,sun60i-a733-pck-600.h @@ -0,0 +1,18 @@ +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ + +#ifndef _DT_BINDINGS_POWER_SUN60I_A733_PCK600_H_ +#define _DT_BINDINGS_POWER_SUN60I_A733_PCK600_H_ + +#define PD_VI 0 +#define PD_DE_SYS 1 +#define PD_VE_DEC 2 +#define PD_VE_ENC 3 +#define PD_NPU 4 +#define PD_GPU_TOP 5 +#define PD_GPU_CORE 6 +#define PD_PCIE 7 +#define PD_USB2 8 +#define PD_VO 9 +#define PD_VO1 10 + +#endif /* _DT_BINDINGS_POWER_SUN60I_A733_PCK600_H_ */ From patchwork Thu Mar 5 03:34:08 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yuanshen Cao X-Patchwork-Id: 311 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FA831EDA2C for ; Thu, 5 Mar 2026 03:34:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772681655; cv=none; b=JCf5MwTP9kC1lgt0oH1CflYxZl0/inmdGDKLxtgC7hU3AU3TdNArTdyH2KxnQeeAS5H8NcCSemnvAzcrk485emGReF1p7j5k0t98MQ8bnyzdKpraGs9fJl6RXW78nn3v7MTOhGwfa6fIhM5NkQtiyHCFRHJknzPwL1akvEiKF7Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772681655; c=relaxed/simple; bh=3cQd24z258zjc20dy6ohb0HVeZL+LfFrMaR3/kR1p5Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Vx3Ku19dW+Tfn1WNrzpkMqKkwq1wbd+usIV2OS7MN6TUKm/RtEobdEBjCDxKfZCBXO70gPGEVxii9+V9m2mi5WoiPbrNCSzkRiBpzFTeGZIjmBYzLoSKzls+++AlWfGTr2CZQTbT+60zliedIhv3eGkqV7YBYseu88ODkDgwowg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QOEYErAC; arc=none smtp.client-ip=209.85.160.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QOEYErAC" Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-50335b926c2so70373431cf.2 for ; Wed, 04 Mar 2026 19:34:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772681653; x=1773286453; darn=lists.linux.dev; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=2d5yl02iJv/wkdm4hWnCdO+qs5aDrcJeSjvUW0fTJuE=; b=QOEYErACrBZ3r20qkTrrJXxvrjA11b8J57HtjnznaF5Cvr9VN/vm5WnQDZeqS852yi wWAALj0lrAQyeTItOLqhHevRM45w62QT8xGXSJx+2xULkGyEeTnCgoe6T05tdKj3oVJX rZKCOpmu96NGkPiTQfam2DJoItL1PeplZ7+fSyaO9duSUmV5UJ0GyWSa7GF3nj9PPZWw iplFxUKoJf0CK5BPl7bMjevUbd1loVlqVB6UhUUtQ64Cj0/4o15dkKBnZdmSEAiCr1jb ij9vKxyRUKFRFKNpVlDACI/X4KWNFwhbzMsIDIgqFvWZQ4vbKyUuBZHBtPX9Ur/1TX+g ltew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772681653; x=1773286453; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=2d5yl02iJv/wkdm4hWnCdO+qs5aDrcJeSjvUW0fTJuE=; b=Cvhnqn8DFABUQeOkNqkZKeMdgI6MJCJSysWV9laq+okbHTtQkivGpKkWpml6nlbQt7 DW8x+7AEMMquucHQr5sE3PTZkWB2vaz4ZM4fCGdKdYjKFhvLQ7ZnJGqO0ma0H9+ajjn8 p2rWtIdruIM6wMHM0omepEJuI7Rys7unvbVDcx7ij5Q7EyvFpbKGHav+ciBnss0W6ceI lx6iX02NT7ULltCIupXtDOlJPNLMcYeVI3vC+3y6tetl3v4gaH474VfowWpgUy8NYapN sMPTeE6jhKd3KgHNySW6JpmDZ64vjWUeeaa9QiwoBV0VNjPeP721dl9wwU18dzYdW3P7 DpKg== X-Forwarded-Encrypted: i=1; AJvYcCWf911ECItdbyCIYKaef+3K+M7O4UirFNX8HgD7zbzC9CWPLeUibmsj1QpcxwWRggv0ogUHdgd3WWOR/g==@lists.linux.dev X-Gm-Message-State: AOJu0YxYfDodSPSGIF9zszogcFnMBQ9Okz2lORdLNIHkMDlD1nVGaznw pdWdiwGcUJylOY/l/yIZJ8oG6jbss4aNs0hMCO31yZJmqNtMBYeJSK8u X-Gm-Gg: ATEYQzxSDwnTDlxXoQhiYhqNwkr2x6l8JtvUkGTAcn8fKb6hYbpy2CC4qPNHgaZdPUG n66WejCCA52FX1u3CI680wvbytFLR3ofOb3m+u2k27CCal6b9Wx48jGJS7LjcF03trit/znpfUR wLzgq69Y3lDyXto/mFYF6oXzKj2H3dMrTgDA0bniJTVfATjoiu7GfYjwixoHsgONEFFKYiACS1K 8r1mjA4IDrPBQ7lYBqMntFWAg4dXuvVWfZQmUrU1U9MGylCsBsZBeo4j2pfEaWnGXkzqsBVvDxB xpjif0WZZg6lJ3qQp2uV6CSZKineiVhqkYQx2g6ACbX2l1WEmn7nA/MTkh4insMzqNb0RXVIcSn faYFonLx/tqa5XPMZgsR/MvmSvQlzaR3xT5h81YbOk7cdgynXGHLlqrx8+76/Wc3kBg4/x5MrDK f2msFtjm0lx8mlJL11zxZ3iU/I98s= X-Received: by 2002:ac8:5a0c:0:b0:501:4b10:aa9e with SMTP id d75a77b69052e-508db2a632bmr59254511cf.13.1772681653433; Wed, 04 Mar 2026 19:34:13 -0800 (PST) Received: from [172.17.0.2] ([134.128.219.200]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-507449630b6sm190667601cf.7.2026.03.04.19.34.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 19:34:13 -0800 (PST) From: Yuanshen Cao Date: Thu, 05 Mar 2026 03:34:08 +0000 Subject: [PATCH v2 2/2] pmdomain: sunxi: Add support for A733 to Allwinner PCK600 driver Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20260305-b4-pck600-a733-v2-2-ba6bbed7d253@gmail.com> References: <20260305-b4-pck600-a733-v2-0-ba6bbed7d253@gmail.com> In-Reply-To: <20260305-b4-pck600-a733-v2-0-ba6bbed7d253@gmail.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Ulf Hansson Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Yuanshen Cao X-Mailer: b4 0.14.3 Status: O The Allwinner A733 PCK600, similar to A523 PCK600, is likely a customized version of ARM PCK-600 power controller. It shares the same BSP driver with A523. According to the BSP provided by Radxa, unlike A523, it doesn't require reset, as well as a different pair of delay values. Make reset optional in the sunxi pck600 driver and add support for A733. Signed-off-by: Yuanshen Cao Acked-by: Jernej Skrabec Reviewed-by: Chen-Yu Tsai # matched against BSP driver --- drivers/pmdomain/sunxi/sun55i-pck600.c | 35 ++++++++++++++++++++++++++++++---- 1 file changed, 31 insertions(+), 4 deletions(-) diff --git a/drivers/pmdomain/sunxi/sun55i-pck600.c b/drivers/pmdomain/sunxi/sun55i-pck600.c index c7ab51514531..1d47bbd35ced 100644 --- a/drivers/pmdomain/sunxi/sun55i-pck600.c +++ b/drivers/pmdomain/sunxi/sun55i-pck600.c @@ -52,6 +52,7 @@ struct sunxi_pck600_desc { u32 logic_power_switch0_delay; u32 logic_power_switch1_delay; u32 off2on_delay; + bool has_rst_clk; }; struct sunxi_pck600_pd { @@ -151,9 +152,11 @@ static int sunxi_pck600_probe(struct platform_device *pdev) if (IS_ERR(base)) return PTR_ERR(base); - rst = devm_reset_control_get_exclusive_released(dev, NULL); - if (IS_ERR(rst)) - return dev_err_probe(dev, PTR_ERR(rst), "failed to get reset control\n"); + if (desc->has_rst_clk) { + rst = devm_reset_control_get_exclusive_released(dev, NULL); + if (IS_ERR(rst)) + return dev_err_probe(dev, PTR_ERR(rst), "failed to get reset control\n"); + } clk = devm_clk_get_enabled(dev, NULL); if (IS_ERR(clk)) @@ -206,7 +209,27 @@ static const struct sunxi_pck600_desc sun55i_a523_pck600_desc = { .device_ctrl1_delay = 0xffff, .logic_power_switch0_delay = 0x8080808, .logic_power_switch1_delay = 0x808, - .off2on_delay = 0x8 + .off2on_delay = 0x8, + .has_rst_clk = true, +}; + +static const char * const sun60i_a733_pck600_pd_names[] = { + "VI", "DE_SYS", "VE_DEC", "VE_ENC", "NPU", + "GPU_TOP", "GPU_CORE", "PCIE", "USB2", "VO", "VO1" +}; + +static const struct sunxi_pck600_desc sun60i_a733_pck600_desc = { + .pd_names = sun60i_a733_pck600_pd_names, + .num_domains = ARRAY_SIZE(sun60i_a733_pck600_pd_names), + .logic_power_switch0_delay_offset = 0xc00, + .logic_power_switch1_delay_offset = 0xc04, + .off2on_delay_offset = 0xc10, + .device_ctrl0_delay = 0x1f1f1f, + .device_ctrl1_delay = 0x1f1f, + .logic_power_switch0_delay = 0x8080808, + .logic_power_switch1_delay = 0x808, + .off2on_delay = 0x8, + .has_rst_clk = false, }; static const struct of_device_id sunxi_pck600_of_match[] = { @@ -214,6 +237,10 @@ static const struct of_device_id sunxi_pck600_of_match[] = { .compatible = "allwinner,sun55i-a523-pck-600", .data = &sun55i_a523_pck600_desc, }, + { + .compatible = "allwinner,sun60i-a733-pck-600", + .data = &sun60i_a733_pck600_desc, + }, {} }; MODULE_DEVICE_TABLE(of, sunxi_pck600_of_match);