From patchwork Fri May 22 09:53:59 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bui Duc Phuc X-Patchwork-Id: 2363 Return-Path: X-Original-To: noreply@patchwork.local Delivered-To: noreply@patchwork.local Received: from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10]) by mxe881.netcup.net (Postfix) with ESMTPS id B46C91C07FE for ; Fri, 22 May 2026 11:55:27 +0200 (CEST) Authentication-Results: mxe881; dkim=pass header.d=gmail.com; spf=pass (sender IP is 172.234.253.10) smtp.mailfrom=linux-sunxi+bounces-23604-noreply=patchwork.local@lists.linux.dev smtp.helo=sea.lore.kernel.org Received-SPF: pass (mxe881: domain of lists.linux.dev designates 172.234.253.10 as permitted sender) client-ip=172.234.253.10; envelope-from=linux-sunxi+bounces-23604-noreply=patchwork.local@lists.linux.dev; helo=sea.lore.kernel.org; Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id E0A683038149 for ; Fri, 22 May 2026 09:54:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A839B3BAD95; Fri, 22 May 2026 09:54:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OufZPf+6" X-Original-To: linux-sunxi@lists.linux.dev Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B41A3BB665 for ; Fri, 22 May 2026 09:54:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779443667; cv=none; b=Y2Hgz5jJceo8S6pvKMRdNAo+7ArZllqphOOu0tSkwl3gwV9cw0AriC/goAeV/5o9uuKukaIb7rkAetI2R574DYnqI20L69IlPMju+Q3ZSnwoqLPbhhRRjVqpJOKBRK9j64wtNW38+x8uN78afSbytCX5k2REN27kXsgL31p9qyo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779443667; c=relaxed/simple; bh=hk+pW36En4Wy1AZ68b3gwc2MovHJXPl64J4AmrYmsEc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qGGCo2fzczuwsSaDxhCWjruHiP8O10ph4XSxVrkwZMdwTqr/0x9vMYe47c1gd3JAG2pHnJwLrLPZlBRcX2nodzPspZrN8+tVKjRu49CUvj0FM5BgFrmJ54GyhEoPTxtfkUaQ0WkJjE97/iqk2mVTHxBIKwctRMCBbjlJ1Kzma+M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OufZPf+6; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-83ea84df1d0so2372008b3a.2 for ; Fri, 22 May 2026 02:54:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779443665; x=1780048465; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nfxD9+jDbayH+o4mAO389jhPYWsWPPQA6d87WX8ntHs=; b=OufZPf+6IycKb2iNg+OdRzu8z1kYmJzIirCNaSpb9By79XN09eBOERUf2j7oYsVRzG EWfiX8t8byBBduAtbOj7ynGlh1LLSOsriBbMhE3PRbh7ArzjiGp5DA5X9t5vgm9fFbX7 SC/tKc1qY7jC4Zx28MXaUC2N8GRCpdtu4386AjusC16IZRMCR5nodBtml0Yax5sVLAcO FpbQn0GWQyVXucXYG/SZinE7pcIIpAxTJakztDp5OZ6BzAmc45W8wio0zGLkOmce8NVc XrHrNYe7LSd7/dmNL37UXuuhWB2fs9o+LoPQ6187DBENsRB5NZuIvv8UWzFlaT1W85Mj YjnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779443665; x=1780048465; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=nfxD9+jDbayH+o4mAO389jhPYWsWPPQA6d87WX8ntHs=; b=j5/lxmRxG0OJCZZAckXUmVa1CGR/TWREMgRu7k5uMb94Ri0SMxtl2xmKYx2guFOE1D njUIZoLeMzQ/OfqAA+W/9gXASogZqpW1GPTv2cmOZBhsaqenZLDIg5xtnfUNRkB9lO7q rBEukBhZ62BA7hmpDaz37Ik+SxbgZAYIhyDJHSnQpSqc1GNjN5D4AeWPWNx1TydzZ0FM LKlVxkL2IKNb+eA7FIT8oKxoCiQwJD2kxJXpsU1QnhD1KGnvBQxAiIL6yo5M9d+CBoW/ C/06QW9qE6LLJ4615cvht3CzAHKgmP8nqjhg9zavDtp51DHoW4cj0aqyaoPjdXCs8uW9 Yn0A== X-Forwarded-Encrypted: i=1; AFNElJ+AdQBkHGe4i6gn0TKvZAwfDZvcdTcZoaaHcSkPXuiJL/LzkE7N6E3ia0Uxs+SBd3YdVbXkjhpva0CrIw==@lists.linux.dev X-Gm-Message-State: AOJu0YyJeB+bahO8pKDQr5eB5/Sw66Jj0YxcXs2/iD1d8aLEvx1IABA2 z0Kv83A/FuIanMpG0F0AF8OVr1HLx7LWOpyRCtuvIrjRLQ1YaIXeKDwu X-Gm-Gg: Acq92OHjcYzMMr1ocNwqOtS8XzUEjjLAX9ElqfkPBbGUGgYRgKqrvr3a2kJlpJq6jTU me9B3IX62U0rmpFshl22rafchZkxzH2rZEZ0SuVK9fLjenGlv6wdOsR+G/tooZiYc11UIobbFTP xde7V/y+z4jyj87kMlgFJBnQEA1DGVyUYXcKVrZAFVE48VfTzNp46/A9trhYW+DALJE3KeOXs4R wiuhr33eYqfBi89etd+QXmnH1qFgD+xDzG5kCzZrdbHVTxPn1QQuIwgM7EtfZzJOt7lS+/hB0qD neZrSGiYX0UJxWSuwUsX2859Z4DRbttNohHfhK6W1RVehKlH8ehV3vbRPgGtzVUsZw+fThkiuOa rOduVrIHrqZ7qavKMP48SvmffLJ0jrVQ9JWhXnF126qezJXu760ThFJxynuWuygFXK5t3Uf8RsM OVqgXn0ZYZ81SJjfhy2M5vLkzu0nApjZn7dR78lLVU/EwcYD/dQOOCUSmzTw== X-Received: by 2002:a05:6a00:4b45:b0:827:3b1b:43e6 with SMTP id d2e1a72fcca58-8415f5ea4bbmr3190006b3a.21.1779443665338; Fri, 22 May 2026 02:54:25 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84164aed7c9sm1757366b3a.13.2026.05.22.02.54.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2026 02:54:24 -0700 (PDT) From: phucduc.bui@gmail.com To: broonie@kernel.org Cc: codekipper@gmail.com, jernej.skrabec@gmail.com, lgirdwood@gmail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-sunxi@lists.linux.dev, nichen@iscas.ac.cn, perex@perex.cz, samuel@sholland.org, tiwai@suse.com, wens@kernel.org, bui duc phuc Subject: [PATCH v2 1/3] ASoC: sunxi: sun4i-spdif: Use guard() for spin locks Date: Fri, 22 May 2026 16:53:59 +0700 Message-ID: <20260522095401.72915-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260522095401.72915-1-phucduc.bui@gmail.com> References: <20260522095401.72915-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MORS-Enabled: yes X-MORS-DOMAIN: patchwork.local X-MORS-HOSTING: hosting172546 X-MORS-USER: hosting172546 X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= From: bui duc phuc Clean up the code using guard() for spin locks. Merely code refactoring, and no behavior change. Signed-off-by: bui duc phuc --- Change in v2: - Switched from using guard() to scoped_guard() sound/soc/sunxi/sun4i-spdif.c | 62 ++++++++++++++++------------------- 1 file changed, 28 insertions(+), 34 deletions(-) diff --git a/sound/soc/sunxi/sun4i-spdif.c b/sound/soc/sunxi/sun4i-spdif.c index c2ec19437cd7..89eccc83a130 100644 --- a/sound/soc/sunxi/sun4i-spdif.c +++ b/sound/soc/sunxi/sun4i-spdif.c @@ -427,24 +427,21 @@ static int sun4i_spdif_get_status(struct snd_kcontrol *kcontrol, struct snd_soc_dai *cpu_dai = snd_kcontrol_chip(kcontrol); struct sun4i_spdif_dev *host = snd_soc_dai_get_drvdata(cpu_dai); u8 *status = ucontrol->value.iec958.status; - unsigned long flags; unsigned int reg; - spin_lock_irqsave(&host->lock, flags); + scoped_guard(spinlock_irqsave, &host->lock) { + regmap_read(host->regmap, SUN4I_SPDIF_TXCHSTA0, ®); - regmap_read(host->regmap, SUN4I_SPDIF_TXCHSTA0, ®); + status[0] = reg & 0xff; + status[1] = (reg >> 8) & 0xff; + status[2] = (reg >> 16) & 0xff; + status[3] = (reg >> 24) & 0xff; - status[0] = reg & 0xff; - status[1] = (reg >> 8) & 0xff; - status[2] = (reg >> 16) & 0xff; - status[3] = (reg >> 24) & 0xff; + regmap_read(host->regmap, SUN4I_SPDIF_TXCHSTA1, ®); - regmap_read(host->regmap, SUN4I_SPDIF_TXCHSTA1, ®); - - status[4] = reg & 0xff; - status[5] = (reg >> 8) & 0x3; - - spin_unlock_irqrestore(&host->lock, flags); + status[4] = reg & 0xff; + status[5] = (reg >> 8) & 0x3; + } return 0; } @@ -455,35 +452,32 @@ static int sun4i_spdif_set_status(struct snd_kcontrol *kcontrol, struct snd_soc_dai *cpu_dai = snd_kcontrol_chip(kcontrol); struct sun4i_spdif_dev *host = snd_soc_dai_get_drvdata(cpu_dai); u8 *status = ucontrol->value.iec958.status; - unsigned long flags; unsigned int reg; bool chg0, chg1; - spin_lock_irqsave(&host->lock, flags); - - reg = (u32)status[3] << 24; - reg |= (u32)status[2] << 16; - reg |= (u32)status[1] << 8; - reg |= (u32)status[0]; + scoped_guard(spinlock_irqsave, &host->lock) { + reg = (u32)status[3] << 24; + reg |= (u32)status[2] << 16; + reg |= (u32)status[1] << 8; + reg |= (u32)status[0]; - regmap_update_bits_check(host->regmap, SUN4I_SPDIF_TXCHSTA0, - GENMASK(31,0), reg, &chg0); + regmap_update_bits_check(host->regmap, SUN4I_SPDIF_TXCHSTA0, + GENMASK(31, 0), reg, &chg0); - reg = (u32)status[5] << 8; - reg |= (u32)status[4]; + reg = (u32)status[5] << 8; + reg |= (u32)status[4]; - regmap_update_bits_check(host->regmap, SUN4I_SPDIF_TXCHSTA1, - GENMASK(9,0), reg, &chg1); + regmap_update_bits_check(host->regmap, SUN4I_SPDIF_TXCHSTA1, + GENMASK(9, 0), reg, &chg1); - reg = SUN4I_SPDIF_TXCFG_CHSTMODE; - if (status[0] & IEC958_AES0_NONAUDIO) - reg |= SUN4I_SPDIF_TXCFG_NONAUDIO; + reg = SUN4I_SPDIF_TXCFG_CHSTMODE; + if (status[0] & IEC958_AES0_NONAUDIO) + reg |= SUN4I_SPDIF_TXCFG_NONAUDIO; - regmap_update_bits(host->regmap, SUN4I_SPDIF_TXCFG, - SUN4I_SPDIF_TXCFG_CHSTMODE | - SUN4I_SPDIF_TXCFG_NONAUDIO, reg); - - spin_unlock_irqrestore(&host->lock, flags); + regmap_update_bits(host->regmap, SUN4I_SPDIF_TXCFG, + SUN4I_SPDIF_TXCFG_CHSTMODE | + SUN4I_SPDIF_TXCFG_NONAUDIO, reg); + } return chg0 || chg1; } From patchwork Fri May 22 09:54:00 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bui Duc Phuc X-Patchwork-Id: 2364 Return-Path: X-Original-To: noreply@patchwork.local Delivered-To: noreply@patchwork.local Received: from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10]) by mxe881.netcup.net (Postfix) with ESMTPS id 287871C07FA for ; Fri, 22 May 2026 11:56:08 +0200 (CEST) Authentication-Results: mxe881; dkim=pass header.d=gmail.com; spf=pass (sender IP is 172.234.253.10) smtp.mailfrom=linux-sunxi+bounces-23605-noreply=patchwork.local@lists.linux.dev smtp.helo=sea.lore.kernel.org Received-SPF: pass (mxe881: domain of lists.linux.dev designates 172.234.253.10 as permitted sender) client-ip=172.234.253.10; envelope-from=linux-sunxi+bounces-23605-noreply=patchwork.local@lists.linux.dev; helo=sea.lore.kernel.org; Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id 65572300F5D5 for ; Fri, 22 May 2026 09:54:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 225FD3905E4; Fri, 22 May 2026 09:54:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H9Jawl0d" X-Original-To: linux-sunxi@lists.linux.dev Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD0A83C3C01 for ; Fri, 22 May 2026 09:54:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779443672; cv=none; b=SGhmkxiY3Cp5/NH71NDsPncCBw9xWxHbSFKpP/7pOTIqmsZqPqfyUq8U+B9lUpUuC2c7RLQ3eW5xf1z/cdiZWi2OGJN6nkZ3xeys1CKp9L3zAwjtw3bOFLkcwvARplG0XZV37Q10dRkd3Mf4gqVWEJpTFmeUIi+KXY4jTVNewG8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779443672; c=relaxed/simple; bh=FES/LPsuYUEIfYpCxaSWRQknC3l1jlyEQS86EeloiaE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lL/aXpZxUYiNWlVVpvXb6oXhVGh8mmqB/ipx5mxtPrMi8t8izGAVhpWXcqC5y5gmKnD3FmBZOPQr5RVniYHiBwKrCWNR7TC8pAYwgPi6/TdN/lzUxzXu3gCKJYHrDULzkPSQ35q9pJLXxRwgDyXdna35ZzJXCUxR5tJ2Khl37Ew= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=H9Jawl0d; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-837b39eb078so4832644b3a.2 for ; Fri, 22 May 2026 02:54:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779443670; x=1780048470; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WsLsnv7a/QcqqVOvsqB3nlisoqKckWLxKBBgfnHU3Rw=; b=H9Jawl0dPpJO+eyESNKlJCFsRED/P78nzrgZ9dC8Rx/9wEIz6ke1LtFWaO0gQ/ceui BgdM5aEGSzyb1kHcyfJo2ta34GJ3ZsQDXxmGnP0422VB2oQcO2uROL8t0im5sr8fxX50 VCXg4iI9jUb+NuvHmsJWfKl35w9fGALUMGxxjKvqwkAJGArU97t6VexcejfdsDMal0fJ hIU3ByImmbaQ2onKXOHfLNSflHVpdMzZ5hsUx/X1PysrPVQ//0sbCwsEVbJFdkKchVax tQkwO99xRm9LBvyk80wPcm/6MW4h8mpFChfN+rGRh0ZcnjdsZ+SK71pYH621c5QK8ao1 qbRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779443670; x=1780048470; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WsLsnv7a/QcqqVOvsqB3nlisoqKckWLxKBBgfnHU3Rw=; b=TDkbaOj+8sOI9gA9SaS6xVAr4UIU3UPT2y/3YLFkTETZmI3UkW1tGZhpBz0nyJjQo9 s2BXF226K0H4BSdLBFHFiMnObNMn5lU8HqEXejbdpdbl3A1I5r3T/+LdbyCm2glL0HMK Zk/UQ6I2lEPs5/StemPqM60e96o757fEqTq2xAYbA78vrQJyMZUyah5d1m8X2mGVRmYU eRZhtLOOyLQzU2Se7Nyse/y8NTV9eJBTKLGeGcvf2RC1+yVfrQo8rCDyKgA0YaK8neyR wKg7SI7QNkqBdTNqDHgP5NwNmxjnmJiEUzlh553E7VbNGjR9npdVSlmsSim/QiEwCGy5 Dlow== X-Forwarded-Encrypted: i=1; AFNElJ/CgU4s9Pi1wNwdMd9N8RUc/nY7VUFCoSVV/afRidguyW7WG+vC6ggrYdvtjfTKd1Ns6ET40QnwUfHYHg==@lists.linux.dev X-Gm-Message-State: AOJu0YzQjxpXOyd1bbGkIGD3BlwHWjDvxaxaynyMtzr3rzjcDvl/syFK MWtoHlrj1TKL5+V8WVu+N84Wbo//pnrk0maSu/pay6GF5dpoJgCohxGE X-Gm-Gg: Acq92OFz+PUnjg9B+azZLuN1iPTr1KXWoPG75OeYX1zAPHh4ZFVA0Ir4h0GsYRtsOhX bhF1jr3daidUCU3WQAJzjGe5gSnyVVNlWFXK68WdkA9eElXUcv7J5veXqN9t5eyncRo37H+3YG5 rzqHV36mQIyJVJzlufvS2LZGK3LUt28Ep0fjAunfTWI6trY/qynNL74fHZEQPtpYNBi77nKl/o6 AN8h7FCG7/v+zUpzmpawZOHyYqmJ4jjW+kyepKhtKAFLr30VMDUO4V1Ap513wu8x2Um0f6FCGDp EUInpV6NQhREakGv3M8EqRU4Pi/N9Ku1YwY16HN048tbsmsMPRYX/ql+JYOonID0CHcTFVTrBtt l6qz0E2bQb2PwYZ3Sq+Ekfpo33ShCRC6GyP5Jrze74FPqoH7SB8jOB4rkR3QeogF/ThQ1RtS1in xdl4dEpyfJd+ZvLtKvXRccwibpp8FWAI2apIF+OPu36u54JecUlNcsrCiMl39aFUKMcQ6A X-Received: by 2002:a05:6a00:2447:b0:835:4776:7d7b with SMTP id d2e1a72fcca58-8415f65c44bmr3236104b3a.42.1779443669845; Fri, 22 May 2026 02:54:29 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84164aed7c9sm1757366b3a.13.2026.05.22.02.54.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2026 02:54:29 -0700 (PDT) From: phucduc.bui@gmail.com To: broonie@kernel.org Cc: codekipper@gmail.com, jernej.skrabec@gmail.com, lgirdwood@gmail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-sunxi@lists.linux.dev, nichen@iscas.ac.cn, perex@perex.cz, samuel@sholland.org, tiwai@suse.com, wens@kernel.org, bui duc phuc Subject: [PATCH v2 2/3] ASoC: sunxi: sun4i-spdif: Resume device before kcontrol register access Date: Fri, 22 May 2026 16:54:00 +0700 Message-ID: <20260522095401.72915-3-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260522095401.72915-1-phucduc.bui@gmail.com> References: <20260522095401.72915-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Rspamd-Server: rspamd-worker-8404 X-Spamd-Result: default: False [-0.66 / 15.00]; BAYES_HAM(-5.50)[99.99%]; RBL_SENDERSCORE(2.00)[172.234.253.10:from]; SUSPICIOUS_RECIPS(1.50)[]; DMARC_POLICY_SOFTFAIL(1.00)[gmail.com : SPF not aligned (relaxed), No valid DKIM,none]; R_MISSING_CHARSET(0.50)[]; MAILLIST(-0.15)[generic]; BAD_REP_POLICIES(0.10)[]; MIME_GOOD(-0.10)[text/plain]; HAS_LIST_UNSUB(-0.01)[]; FROM_NO_DN(0.00)[]; R_SPF_ALLOW(0.00)[+ip4:172.234.253.10]; RCPT_COUNT_TWELVE(0.00)[14]; DBL_BLOCKED_OPENRESOLVER(0.00)[sea.lore.kernel.org:rdns,sea.lore.kernel.org:helo]; TO_DN_SOME(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; FORGED_SENDER_MAILLIST(0.00)[]; FREEMAIL_CC(0.00)[gmail.com,lists.infradead.org,vger.kernel.org,lists.linux.dev,iscas.ac.cn,perex.cz,sholland.org,suse.com,kernel.org]; TAGGED_RCPT(0.00)[]; PRECEDENCE_BULK(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; ARC_ALLOW(0.00)[subspace.kernel.org:s=arc-20240116:i=1]; MID_RHS_MATCH_FROM(0.00)[]; ASN(0.00)[asn:63949, ipnet:172.234.224.0/19, country:SG]; TAGGED_FROM(0.00)[bounces-23605-noreply=patchwork.local]; RCVD_COUNT_FIVE(0.00)[6]; FROM_NEQ_ENVFROM(0.00)[phucducbui@gmail.com,linux-sunxi@lists.linux.dev]; RCVD_VIA_SMTP_AUTH(0.00)[] X-Rspamd-Queue-Id: 287871C07FA X-MORS-Enabled: yes X-MORS-DOMAIN: patchwork.local X-MORS-HOSTING: hosting172546 X-MORS-USER: hosting172546 X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= From: bui duc phuc Accessing registers while the device is runtime-suspended may lead to invalid hardware accesses on systems where the APB bus clock is gated during runtime suspend. Ensure the device is resumed before accessing registers. Signed-off-by: bui duc phuc --- sound/soc/sunxi/sun4i-spdif.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/sound/soc/sunxi/sun4i-spdif.c b/sound/soc/sunxi/sun4i-spdif.c index 89eccc83a130..f54eb14c9ed8 100644 --- a/sound/soc/sunxi/sun4i-spdif.c +++ b/sound/soc/sunxi/sun4i-spdif.c @@ -428,6 +428,11 @@ static int sun4i_spdif_get_status(struct snd_kcontrol *kcontrol, struct sun4i_spdif_dev *host = snd_soc_dai_get_drvdata(cpu_dai); u8 *status = ucontrol->value.iec958.status; unsigned int reg; + int ret; + + ret = pm_runtime_resume_and_get(cpu_dai->dev); + if (ret) + return ret; scoped_guard(spinlock_irqsave, &host->lock) { regmap_read(host->regmap, SUN4I_SPDIF_TXCHSTA0, ®); @@ -443,6 +448,8 @@ static int sun4i_spdif_get_status(struct snd_kcontrol *kcontrol, status[5] = (reg >> 8) & 0x3; } + pm_runtime_put(cpu_dai->dev); + return 0; } @@ -453,8 +460,13 @@ static int sun4i_spdif_set_status(struct snd_kcontrol *kcontrol, struct sun4i_spdif_dev *host = snd_soc_dai_get_drvdata(cpu_dai); u8 *status = ucontrol->value.iec958.status; unsigned int reg; + int ret; bool chg0, chg1; + ret = pm_runtime_resume_and_get(cpu_dai->dev); + if (ret) + return ret; + scoped_guard(spinlock_irqsave, &host->lock) { reg = (u32)status[3] << 24; reg |= (u32)status[2] << 16; @@ -479,6 +491,8 @@ static int sun4i_spdif_set_status(struct snd_kcontrol *kcontrol, SUN4I_SPDIF_TXCFG_NONAUDIO, reg); } + pm_runtime_put(cpu_dai->dev); + return chg0 || chg1; } From patchwork Fri May 22 09:54:01 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bui Duc Phuc X-Patchwork-Id: 2365 Return-Path: X-Original-To: noreply@patchwork.local Delivered-To: noreply@patchwork.local Received: from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10]) by mxe881.netcup.net (Postfix) with ESMTPS id 614291C07FA for ; Fri, 22 May 2026 11:56:54 +0200 (CEST) Authentication-Results: mxe881; dkim=pass header.d=gmail.com; spf=pass (sender IP is 172.234.253.10) smtp.mailfrom=linux-sunxi+bounces-23606-noreply=patchwork.local@lists.linux.dev smtp.helo=sea.lore.kernel.org Received-SPF: pass (mxe881: domain of lists.linux.dev designates 172.234.253.10 as permitted sender) client-ip=172.234.253.10; envelope-from=linux-sunxi+bounces-23606-noreply=patchwork.local@lists.linux.dev; helo=sea.lore.kernel.org; Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id D31A63051D2D for ; Fri, 22 May 2026 09:54:37 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B18FE3B52E1; Fri, 22 May 2026 09:54:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m3vz9O+K" X-Original-To: linux-sunxi@lists.linux.dev Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17F7E3C4572 for ; Fri, 22 May 2026 09:54:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779443677; cv=none; b=DniAwfps1BQ6d0MjTywsQIY4PLq1335cFRmyirC+JDs9Zq7+AoKAeW4ZCrPpB+j3i7IiV82p6CIS4Zzx0zBSTzo2EBaK3neCi7ZbmUHvfyk+qVU9YI4MSkb15AJBsZaw4YwMBCfqY4Ku1EW2TwI4V1JPPEpFTlaVY3X+EiezBoo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779443677; c=relaxed/simple; bh=qbDGhHNnk9OCLZQ1PGxrrKjrGTP1fFlGw+ruMcn44HU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Fqw/6theIKMVR/+TiA9J4/BLhnYFeXlt6Z2xaIL3OsgC5B9x0YmzBBQR1k9MK5dWXleblzUY7QPpOWVMnYCTPdutOpVkLT3mSxE/q0CqKYry7zUSyszsDTCbKilOH0Yh1av6Cd8nfn9HuA45uN3ymLTWfLtxxs1JShjNB1mgzAU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m3vz9O+K; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-82f9fdfc965so3327705b3a.1 for ; Fri, 22 May 2026 02:54:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779443674; x=1780048474; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OZzUxIkdaJ6gBxa9mowChRFjkNJFrAHd972GUGZ8zKk=; b=m3vz9O+KzpIGoC8nrzwg0BrIBZBJou5Ys66qkHFPM7/5gxoXDEW5+wf3sCtctTfajL eG4hQhGgroGnMy8p+KpLRkhY5ab188lMm1mtoPQinRFn3HRZKmWvxQUOzCIND2oAfMzP /HvHJrNNWEjHgg+Bv7NSkRvw7ksVYdjkve3sDRXiov+QBMvatpTypskbckVD5sUzf9L/ Vz+X24TQl4pDCk2+L4rw5/rKb7KoSK5J3OCuitjBcMp6qtP/HxtfA/2AaSWikBHWubAX MojYnqHrBBvqGvlx+f/+UpXU6EMGg428+H6iYfrJxLtVXJ7Z9OEGEyUJpwvAeGhIdCle Qcwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779443674; x=1780048474; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=OZzUxIkdaJ6gBxa9mowChRFjkNJFrAHd972GUGZ8zKk=; b=NNk5YgZ0tvkkUJME8bTzCbfjN8loi3XLKo/jl3uSDpi8zGid1lV0PwARnAknT0PUzs fToNbI2Bk+Dxv5kVdLh4A0/dG0PAYJURzlLuwUBSMfq8g7Egf+WJEipRxnr27hezPrJF IjKOUllfxp90JSkb2qYXI0o+tT155M1s4U2fcTvST92GZJTAYAHTj2POuWZ5FGBLT7IL bjXOkyvsRTswlPj97l5bwqHnN5Hp8dJk6gUzLrtwjUAUVgdbXosS0qH7vQPmbQNdf/u0 Tc2Q1Me2pOMJCOmpJtbpNQrShcKUCxA/HFqXlxHx39km2QyLXMWIfzsT5MbNfErdHveK pvgg== X-Forwarded-Encrypted: i=1; AFNElJ/G430Bdr+MQORM5sln2IGCwZlUODEwkzebuLundo5xUvIO3V/vFq2cD6m7pCbinEfl7lEOf2N2aK+Q1A==@lists.linux.dev X-Gm-Message-State: AOJu0YxATvmvBvlH3iIkiP73MEUUzNxItWhzD7EAyjrwJmWk1v4HPnM6 NEy+sbWHFT1E6R4nnbLGQlNVQVE2T6/Dht/mhG0zsqnXvllEd563ATkW X-Gm-Gg: Acq92OG8uU5JDs8NKD+hwkZ9aYrtx+CyXNETGGULmEK+eqx0OWhJekgbhM8Sq1OaBPq +J5MBhS5mFEUZrwuruq/F2GBDcPwofoHtbP6Yge9MhPjObI3X0rzg+o9qeLWHjbgqg8b6iu2K0Q YU3EURcTtr7rw3/7g6RxPzt8be/cPp8FF7jtkAEKz3VbPINnG516/XE+qKo7L7SRAzRLSdm/OOw EmtlAdff/lQhM1cC4Zxu6RIQv4lLro2mdLo503bDqc+CXrLFb+pywPG7jaNo7Sh8jsW2pGMGNLh I1Ne5pJ70L563qsYNKIQNiFclJ4Gxhk6e7osLacTRx0rm3s7KVIeIsGeKXxUDOfY6RGoy4cdSET MPhIqdbwUc5Kj2SwCWJOphDDFklySPoVDJtvCfh74QlNxT6ykRN0tsMc877qUWe/tnjAgp3zr0f sPC5My0vG2MXehmXAOaDY//Xh+UxH+J/3XYNvYcpgbAg/UO15M5B2KW8I4ZQ== X-Received: by 2002:a05:6a00:17a4:b0:82f:5726:be23 with SMTP id d2e1a72fcca58-8415f3f68ccmr3185755b3a.49.1779443674325; Fri, 22 May 2026 02:54:34 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84164aed7c9sm1757366b3a.13.2026.05.22.02.54.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2026 02:54:33 -0700 (PDT) From: phucduc.bui@gmail.com To: broonie@kernel.org Cc: codekipper@gmail.com, jernej.skrabec@gmail.com, lgirdwood@gmail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-sunxi@lists.linux.dev, nichen@iscas.ac.cn, perex@perex.cz, samuel@sholland.org, tiwai@suse.com, wens@kernel.org, bui duc phuc Subject: [PATCH v2 3/3] ASoC: sunxi: sun4i-spdif: Reorder clock enable sequence Date: Fri, 22 May 2026 16:54:01 +0700 Message-ID: <20260522095401.72915-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260522095401.72915-1-phucduc.bui@gmail.com> References: <20260522095401.72915-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Rspamd-Server: rspamd-worker-8404 X-Spamd-Result: default: False [-0.66 / 15.00]; BAYES_HAM(-5.50)[99.99%]; RBL_SENDERSCORE(2.00)[172.234.253.10:from]; SUSPICIOUS_RECIPS(1.50)[]; DMARC_POLICY_SOFTFAIL(1.00)[gmail.com : SPF not aligned (relaxed), No valid DKIM,none]; R_MISSING_CHARSET(0.50)[]; MAILLIST(-0.15)[generic]; BAD_REP_POLICIES(0.10)[]; MIME_GOOD(-0.10)[text/plain]; HAS_LIST_UNSUB(-0.01)[]; FROM_NO_DN(0.00)[]; R_SPF_ALLOW(0.00)[+ip4:172.234.253.10]; RCPT_COUNT_TWELVE(0.00)[14]; DBL_BLOCKED_OPENRESOLVER(0.00)[sea.lore.kernel.org:rdns,sea.lore.kernel.org:helo]; TO_DN_SOME(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; FORGED_SENDER_MAILLIST(0.00)[]; FREEMAIL_CC(0.00)[gmail.com,lists.infradead.org,vger.kernel.org,lists.linux.dev,iscas.ac.cn,perex.cz,sholland.org,suse.com,kernel.org]; TAGGED_RCPT(0.00)[]; PRECEDENCE_BULK(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; ARC_ALLOW(0.00)[subspace.kernel.org:s=arc-20240116:i=1]; MID_RHS_MATCH_FROM(0.00)[]; ASN(0.00)[asn:63949, ipnet:172.234.224.0/19, country:SG]; TAGGED_FROM(0.00)[bounces-23606-noreply=patchwork.local]; RCVD_COUNT_FIVE(0.00)[6]; FROM_NEQ_ENVFROM(0.00)[phucducbui@gmail.com,linux-sunxi@lists.linux.dev]; RCVD_VIA_SMTP_AUTH(0.00)[] X-Rspamd-Queue-Id: 614291C07FA X-MORS-Enabled: yes X-MORS-DOMAIN: patchwork.local X-MORS-HOSTING: hosting172546 X-MORS-USER: hosting172546 X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= From: bui duc phuc Enable the APB bus clock before the SPDIF module clock during runtime resume, as register accesses depend on the bus clock being enabled first. Signed-off-by: bui duc phuc --- sound/soc/sunxi/sun4i-spdif.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/sunxi/sun4i-spdif.c b/sound/soc/sunxi/sun4i-spdif.c index f54eb14c9ed8..102db1a2afbb 100644 --- a/sound/soc/sunxi/sun4i-spdif.c +++ b/sound/soc/sunxi/sun4i-spdif.c @@ -643,15 +643,15 @@ static int sun4i_spdif_runtime_suspend(struct device *dev) static int sun4i_spdif_runtime_resume(struct device *dev) { - struct sun4i_spdif_dev *host = dev_get_drvdata(dev); + struct sun4i_spdif_dev *host = dev_get_drvdata(dev); int ret; - ret = clk_prepare_enable(host->spdif_clk); + ret = clk_prepare_enable(host->apb_clk); if (ret) return ret; - ret = clk_prepare_enable(host->apb_clk); + ret = clk_prepare_enable(host->spdif_clk); if (ret) - clk_disable_unprepare(host->spdif_clk); + clk_disable_unprepare(host->apb_clk); return ret; }