From patchwork Mon Jul 13 13:07:39 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pan Chuang X-Patchwork-Id: 2639 Return-Path: X-Original-To: noreply@patchwork.local Delivered-To: noreply@patchwork.local Received: from sto.lore.kernel.org (sto.lore.kernel.org [172.232.135.74]) by mxe881.netcup.net (Postfix) with ESMTPS id 95EA31C2B86 for ; Mon, 13 Jul 2026 15:15:06 +0200 (CEST) Authentication-Results: mxe881; dkim=pass header.d=vivo.com; spf=pass (sender IP is 172.232.135.74) smtp.mailfrom=linux-sunxi+bounces-24397-noreply=patchwork.local@lists.linux.dev smtp.helo=sto.lore.kernel.org Received-SPF: pass (mxe881: domain of lists.linux.dev designates 172.232.135.74 as permitted sender) client-ip=172.232.135.74; envelope-from=linux-sunxi+bounces-24397-noreply=patchwork.local@lists.linux.dev; helo=sto.lore.kernel.org; Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sto.lore.kernel.org (Postfix) with ESMTP id 5C71F3098850 for ; Mon, 13 Jul 2026 13:08:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D419E41735A; Mon, 13 Jul 2026 13:08:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="ZxdDPtYI" X-Original-To: linux-sunxi@lists.linux.dev Received: from SEYPR02CU001.outbound.protection.outlook.com (mail-koreacentralazon11013011.outbound.protection.outlook.com [40.107.44.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2FC7416132 for ; Mon, 13 Jul 2026 13:08:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.44.11 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783948115; cv=fail; b=SOEQlmG6DUG4hBqjK2qe/NnQTvHnMaeAqsX7QkoYMFWsEIx2gExBVeRK3xJ2+H3Z1P2RSFzuIV08KrJe2M36x+c9eMy0Y3RSTysvN8zU1ijzI8pg/yzalkyXyYYa7muvTkEB2Kn3AxU0RpTXYZucikjjbjbJukvhGn8H4zRi54Q= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783948115; c=relaxed/simple; bh=PxkGdSaSk0eF7eVV6gIiMxfbtWt0riBLpIS3iWCNXC0=; h=From:To:Cc:Subject:Date:Message-Id:Content-Type:MIME-Version; b=lUEUXl6gM+Qwl7WNjestnw+qTzNslPghZvj5yNcJP/9ttgdcn/7AdbUa/czIFXCQm51LQHApp0I97QPw9+qd/mfrNQgWRZdb4qtR+ShOG6X28NVikbvJXlc2VeXnE/JA3IWvA/KEr8/XQUpbS72mLLjnIexox4+oxR7tdKJduko= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=ZxdDPtYI; arc=fail smtp.client-ip=40.107.44.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uxyH++akPmFLmz1mS1BNgLQtcy7d+BgXYSHM3VNjJxrk7zQBWgSU99Psb+cth7UIvNaHtC8I9MTW49UvCG4Uv1Dvz1iTtg/L8i3+pLBB/LRR/PxU2YhzAG+oNeTpZgSy3aPZaP06FzyF9gOVzo4+Nlili5khqnZjHBLfehZev/SbiZQBFbDG4suiE7HTmxajUY1j+AzFkQ/gZDoZGuIGsllMMIWfsxInNW481mZaXQGq8He/fNZO992YpglvwilercuPfv0llp1noG4Y70O/NP0vRcEkzJ1xxV7caqxHZfNtfcatakdUTiZ3LYk3+bEz7xPZoLUdgLbdjh84GECMyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cIJfD2AbPVHYUPeyZkYQ2XpDRNSrxa9S4jmZWvLB9rQ=; b=lH/FpUl0o5SkGk64MuIABAnmI1VlJ5ppeT+U/T2oXeeNEkia1u5cqiKpwMsmYKp2Y0PaDHM/ftQDZIFprfzTvucgFU6AyY0sqR3G4sR2Y6e9KfaY4ttY5CwMV6ChZokwk+hf/Zzgu63KOEIgXzvlgqqXjf/SKYn8kjoXSIsjG9wl3nyPPlYHNPmZuoU7fM8ROu1g850pfGXFsrHkssWGIWE77XUIJw45mn0xxefBIzXMyWW9JgTNEJ+i/H4U/TzO+jys/AK/YT5g0Jf2u3mTIgKg0kmk5IG7dHkuCEo8usFKo9nTfyRnfUhPtt82xYXXNu4+Hs01tNa96MEppbCOPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cIJfD2AbPVHYUPeyZkYQ2XpDRNSrxa9S4jmZWvLB9rQ=; b=ZxdDPtYI4mP8EnqVUUy8Rdw2zZgG/hOd4tNsL+OnZvDtueJYFFiIC8brm/xp+h0f1WHj5PsCorpd/XK3vlHnx/ljL6kfE7gi4jsUZRxrrGMnZRFIfmvDmtNmAdBkKcfCIOmMnvF1qNXtx/O2OJOKgXiyaBeY88BTe7MRj6FlfsQkx3f8sPI/IH+aN7KnPc6wfccNj5nbJW4TWeTJUcC2GV6xdH0dYCh4CCExtFGXXYIKNub+LFv0RFspJDhDdX7rScgn1ShvqjdepHEKaivXTcJYvLAfElGCgensVrbswmwWyj7w5wVYSbOSbeYvICGv6BGJTgTfW7TtJCjFs4ZC5A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by SE1PPF50B2D80A0.apcprd06.prod.outlook.com (2603:1096:108:1::415) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.14; Mon, 13 Jul 2026 13:08:24 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0202.014; Mon, 13 Jul 2026 13:08:24 +0000 From: Pan Chuang To: Mark Rutland , Marc Zyngier , Daniel Lezcano , Thomas Gleixner , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Thierry Reding , Jonathan Hunter , linux-arm-kernel@lists.infradead.org (moderated list:ARM ARCHITECTED TIMER DRIVER), linux-kernel@vger.kernel.org (open list:CLOCKSOURCE, CLOCKEVENT DRIVERS), linux-stm32@st-md-mailman.stormreply.com (moderated list:ARM/STM32 ARCHITECTURE), linux-sunxi@lists.linux.dev (open list:ARM/Allwinner sunXi SoC support), linux-tegra@vger.kernel.org (open list:TEGRA ARCHITECTURE SUPPORT) Cc: Pan Chuang Subject: [PATCH] clocksource: Remove redundant dev_err()/dev_err_probe() Date: Mon, 13 Jul 2026 21:07:39 +0800 Message-Id: <20260713130740.293502-1-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: SI1PR02CA0058.apcprd02.prod.outlook.com (2603:1096:4:1f5::9) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|SE1PPF50B2D80A0:EE_ X-MS-Office365-Filtering-Correlation-Id: 3abc10ae-ae71-442f-e004-08dee0dfd20d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|366016|1800799024|52116014|7416014|376014|18002099003|56012099006|11063799006|6133799003|921020|38350700014; X-Microsoft-Antispam-Message-Info: js8svtIINX1ETYEpeKJCBgN5MJfgWGuP3Z6nnMRsudxw/V3QXUwJ0UwNv2o17OZv4m//MjsE0ZS7UAFAcQuCmCPEfxlhUf0NX5sJJulAcfAZHq/N6Jf1MgjIPal0IexutmruemKr1ejCkYdzAW8HpqcKiz+xVlORV8wrtLm6Q6ZQoG0iwewdQKzWvbBykIXcGRYNOrx0aBIbMEqe22uHgDk6U+HVunkHr357vejvcLSYnqXxH1n+ti+FpimbGDfP3cVSKt4Eti3w3GbJ8C3KQpoojvB9svur/SfcidFSeWbuGTZPpIjBOO1qi7ZZTvorRUf+TeQUXzPGT9XagVH2z4W0UMQEqjC6W/at+9ChVbnI+t01s0gjM6r1jEUZ/ypYpGmNhQwObxpSFSiato9FC1VrZ48bb+5UcSzlVWMgdPU+Vmzrqeri9GpXu4VcWHwZU6wzI1volIYnKqN17isZDlDUUOZKGFz9rA9B3TIOpgXudPvyREoWBiYQtk3sqU7Cf+yozEQ0VNd+P7lEDNuoaHs80Gu+yynchczX2dgWccL0EvpOLtvca6/kmw4Maq3cICicZ0r5FYRkQZC2R/6JKALYWhBk6Ke7S6MnV6VRcCwNGSrUCeryAB1QEsHhUdSqlhbVWyzlcurLB30tZItFKuLPzmLyzlCs96r1AsXF65kiaUozA7JpfplVAcSveIol0rtuHsaqNjaxrux1+mL7e3yPrpesRSe2lE7xj1M+g516YW0pci1BPrT7rvlPEfjg X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(366016)(1800799024)(52116014)(7416014)(376014)(18002099003)(56012099006)(11063799006)(6133799003)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Gm1qA+hNhGduEAZL/di9FbpsxGIQxRRbdkiTQFI5Yt+nCy3yYoWu+lHGvPrF0EpcdJWqtGcmQ9ZwltJgNv0I0U/D9xnvUagH2PUE60VUQ3TRSDsp7jyFMq22fQay+CYFXqzuEcqCdwPDvvFJlVsu0WDwwTEWfRnxH5lHV6ruiw8OP9FeaRH/NNyd0pxtDJytWjVYPsYfHAgFKIBLbGCHMtE47T3UAUljSW0V3XahrcI25Cw3mj5cSE+bxkiRVDXBNNPU0vFaCvwe1F17B2oR+Ka6cgYZSte7pNWC+dMyepqg+hwPjD8ZO5YrT1G0JUb/95o8nuuuXJNoNpO1G5QqQKISUtJkDok7Tfnmu/P5Y9p6ApL1yPBwJIDGLJj3eSJqH3yiAXpUiHdkTocy5+Xp9mz9sPkpBcbORbvpLVWQK6Li1LK0omR4Owm1omt0A2dC2wCa3P/y8Vxjq7qWW2aeQ3ayrdmjBihude7oIb35jpKLEy/0ZKn+Pet5/gqDsH61PHoQSgQ0ta1pq3CJ67iTFQE4pAFX0wGTcCzlD/kGdYVsf3ufLYQ7wUEwKVQwmzcWr90b8+oVMbjqN9xoLNS3SmIJZC6bb5sm/6cFKEQIzD9kyOBmGRqqGi8tg44mUXyZhCbhQVUaVKH8ezGwxaHqm+ynCvVLeMXVfuiaSmby+CQ/Zwz8dNFkeEJbauhqW4iVLUt3V+SWzU4RNUhjaZPaJUJjy2qVveN6HiZutMiX9WDCaZk/+fd2AQvpwSBoxGFLD3Ju3fSCuK7WJNFz9wKDK7ATnHrEgZwRgACja1dEknFvym3YsDUwKHU8Fw4jIv01Nb/QJdM3D+ImQ0E7P8h46Bmwx3AZERZJ/nBjH+WbzNvvb6ywcbxjAFHWHyXq0VHcfkpe5W6W3gyyfGPPl/kMQKhC4tAgPd59EHkZzmqOMZv1NWrIltxG3aOesqsdlMdJ4foqHKv05GXpkXolTf2AR1IQ9Lxgyu78cwIzkLUX3mguhztmX2TCkjrKXeGpQ05HDwT3dUJG/7m+4uIRGf42ssdpemxw/e+AXH+LdGDnbu9Ld9puZLENygkudxyoKuNDxQJ7fx666JCvr5zD4Yk31QZhXM+JM4ufQS162E+lxRgE5fbJ7P4lSDJ+y3kczMsD7hXxEOPHXq5OYGDxPwnA2ne9Gj0/OVQ1iFLaL/uXAcAIWTwe2bjgQtHoipOJeewSDm7t0WYc7VUAsM3EPGGtXSUrKRwDibwTTa/lvcCs27NXRZnWZYF5M7h/L1XV1SeHghScxQn1zu3P5s5td60uafgzJdR9fLrXtjql9rGVLgGBFEZLHK0yLC8DLuD3+O6UnfPaw2kP/l2U+KQHYrKL8l0n0T4fhrRdnga4Cir/4FonX50zMkG7rnM9IlRimh9uwygE1VUsmujpUsN0Z3B6+lvUzWRbk/QuZ9Cbpds3XuWRbCS0W6fcZwFLaQ6dBXFOAkHqw2cEWndmd35RKFwyaL9xPor56ZwHzc2U447tMrGXD1pCoW+76auWiEjtm4Llm19GfTEeK/Z3kW2Iaakg2wvIpLRcP/XPtraus+rIks8HTzyvSAbqzWxBeA+yWqOqMnUp3F4D+io2iWQLW0QmwfWaFPefeYpcXLkM1MnqQ/XwQ8Wa4kV1z9Me5gftuqxZzMBqIYRh1lDQWLQcOwwPqpxRjUMvukYqYfRcPHGyn8QyM5DUba9XzLvM32q1wWZmAuyYVblI3wCIwuh4cdDCcQ== X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3abc10ae-ae71-442f-e004-08dee0dfd20d X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 13:08:24.3204 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: X4MvBVw+BY8pjuAhWJriisPdUvsevuSVvJagKIyU6cKOK502kgk+BkPCUrsy3TrdDi6IONBnNgDdV8qOpnb44g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SE1PPF50B2D80A0 X-Rspamd-Server: rspamd-worker-8404 X-Spamd-Result: default: False [0.34 / 15.00]; BAYES_HAM(-5.50)[100.00%]; RBL_SENDERSCORE(2.00)[172.232.135.74:from]; SUSPICIOUS_RECIPS(1.50)[]; MID_CONTAINS_FROM(1.00)[]; ARC_REJECT(1.00)[cv is fail on i=2]; R_MISSING_CHARSET(0.50)[]; MAILLIST(-0.15)[generic]; MIME_GOOD(-0.10)[text/plain]; BAD_REP_POLICIES(0.10)[]; HAS_LIST_UNSUB(-0.01)[]; TAGGED_RCPT(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[100.90.174.1:received,2603:1096:101:c8::12:received]; DBL_BLOCKED_OPENRESOLVER(0.00)[vivo.com:email,vivo.com:dkim,sto.lore.kernel.org:rdns,sto.lore.kernel.org:helo]; PRECEDENCE_BULK(0.00)[]; RCPT_COUNT_TWELVE(0.00)[17]; FORGED_SENDER_MAILLIST(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_HAS_DN(0.00)[]; RCVD_COUNT_FIVE(0.00)[6]; FROM_NEQ_ENVFROM(0.00)[panchuang@vivo.com,linux-sunxi@lists.linux.dev]; DKIM_TRACE(0.00)[vivo.com:+]; DMARC_POLICY_ALLOW(0.00)[vivo.com,quarantine]; R_SPF_ALLOW(0.00)[+ip4:172.232.135.74]; TO_DN_SOME(0.00)[]; R_DKIM_ALLOW(0.00)[vivo.com:s=selector2]; FREEMAIL_TO(0.00)[arm.com,kernel.org,gmail.com,foss.st.com,sholland.org,nvidia.com,lists.infradead.org,vger.kernel.org,st-md-mailman.stormreply.com,lists.linux.dev]; MIME_TRACE(0.00)[0:+]; TAGGED_FROM(0.00)[bounces-24397-noreply=patchwork.local]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; ASN(0.00)[asn:63949, ipnet:172.232.128.0/19, country:SG]; RCVD_TLS_LAST(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[172.232.135.74:from] X-Rspamd-Queue-Id: 95EA31C2B86 X-MORS-Enabled: yes X-MORS-DOMAIN: patchwork.local X-MORS-HOSTING: hosting172546 X-MORS-USER: hosting172546 X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() and dev_err_probe() calls. Signed-off-by: Pan Chuang --- drivers/clocksource/arm_arch_timer_mmio.c | 4 +--- drivers/clocksource/em_sti.c | 4 +--- drivers/clocksource/timer-nxp-stm.c | 2 +- drivers/clocksource/timer-sun5i.c | 4 +--- drivers/clocksource/timer-tegra186.c | 4 +--- drivers/clocksource/timer-ti-dm.c | 4 +--- 6 files changed, 6 insertions(+), 16 deletions(-) diff --git a/drivers/clocksource/arm_arch_timer_mmio.c b/drivers/clocksource/arm_arch_timer_mmio.c index d10362692fdd..d678f764d3bb 100644 --- a/drivers/clocksource/arm_arch_timer_mmio.c +++ b/drivers/clocksource/arm_arch_timer_mmio.c @@ -313,10 +313,8 @@ static int arch_timer_mmio_frame_register(struct platform_device *pdev, ret = devm_request_irq(&pdev->dev, irq, arch_timer_mmio_handler, IRQF_TIMER | IRQF_NO_AUTOEN, "arch_mem_timer", &at->evt); - if (ret) { - dev_err(&pdev->dev, "Failed to request mem timer irq\n"); + if (ret) return ret; - } /* Afer this point, we're not allowed to fail anymore */ arch_timer_mmio_setup(at, irq); diff --git a/drivers/clocksource/em_sti.c b/drivers/clocksource/em_sti.c index ca8d29ab70da..73a3357d173d 100644 --- a/drivers/clocksource/em_sti.c +++ b/drivers/clocksource/em_sti.c @@ -300,10 +300,8 @@ static int em_sti_probe(struct platform_device *pdev) ret = devm_request_irq(&pdev->dev, irq, em_sti_interrupt, IRQF_TIMER | IRQF_IRQPOLL | IRQF_NOBALANCING, dev_name(&pdev->dev), p); - if (ret) { - dev_err(&pdev->dev, "failed to request low IRQ\n"); + if (ret) return ret; - } /* get hold of clock */ p->clk = devm_clk_get(&pdev->dev, "sclk"); diff --git a/drivers/clocksource/timer-nxp-stm.c b/drivers/clocksource/timer-nxp-stm.c index 1ab907233f48..6fe098a4a33f 100644 --- a/drivers/clocksource/timer-nxp-stm.c +++ b/drivers/clocksource/timer-nxp-stm.c @@ -441,7 +441,7 @@ static int nxp_stm_timer_probe(struct platform_device *pdev) ret = devm_request_irq(dev, irq, nxp_stm_module_interrupt, IRQF_TIMER | IRQF_NOBALANCING, name, stm_timer); if (ret) - return dev_err_probe(dev, ret, "Unable to allocate interrupt line\n"); + return ret; ret = nxp_stm_clocksource_init(dev, stm_timer, name, base, clk); if (ret) diff --git a/drivers/clocksource/timer-sun5i.c b/drivers/clocksource/timer-sun5i.c index 6ab300d22621..bcf155fb9cac 100644 --- a/drivers/clocksource/timer-sun5i.c +++ b/drivers/clocksource/timer-sun5i.c @@ -247,10 +247,8 @@ static int sun5i_setup_clockevent(struct platform_device *pdev, ret = devm_request_irq(dev, irq, sun5i_timer_interrupt, IRQF_TIMER | IRQF_IRQPOLL, "sun5i_timer0", ce); - if (ret) { - dev_err(dev, "Unable to register interrupt\n"); + if (ret) return ret; - } return 0; } diff --git a/drivers/clocksource/timer-tegra186.c b/drivers/clocksource/timer-tegra186.c index 78600ddeb1c6..0f626ecf61b0 100644 --- a/drivers/clocksource/timer-tegra186.c +++ b/drivers/clocksource/timer-tegra186.c @@ -532,10 +532,8 @@ static int tegra186_timer_probe(struct platform_device *pdev) if (kernel_wdt) { err = devm_request_irq(dev, irq, tegra186_wdt_irq, 0, dev_name(dev), kernel_wdt); - if (err < 0) { - dev_err(dev, "failed to request kernel WDT IRQ: %d\n", err); + if (err < 0) goto unregister_usec; - } tegra186_wdt_set_timeout(&kernel_wdt->base, TEGRA186_KERNEL_WDT_TIMEOUT); tegra186_wdt_enable(kernel_wdt); diff --git a/drivers/clocksource/timer-ti-dm.c b/drivers/clocksource/timer-ti-dm.c index bd06afb7d522..6787acac9a43 100644 --- a/drivers/clocksource/timer-ti-dm.c +++ b/drivers/clocksource/timer-ti-dm.c @@ -1375,10 +1375,8 @@ static int omap_dm_timer_setup_clockevent(struct dmtimer *timer) ret = devm_request_irq(dev, timer->irq, omap_dm_timer_evt_interrupt, IRQF_TIMER, "omap_dm_timer_clockevent", clkevt); - if (ret) { - dev_err(dev, "Failed to request interrupt: %d\n", ret); + if (ret) return ret; - } __omap_dm_timer_int_enable(timer, OMAP_TIMER_INT_OVERFLOW);