From patchwork Wed Jul 15 09:55:20 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bui Duc Phuc X-Patchwork-Id: 2657 Return-Path: X-Original-To: noreply@patchwork.local Delivered-To: noreply@patchwork.local Received: from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10]) by mxe881.netcup.net (Postfix) with ESMTPS id 2AA601C33A6 for ; Wed, 15 Jul 2026 11:57:11 +0200 (CEST) Authentication-Results: mxe881; dkim=pass header.d=gmail.com; spf=pass (sender IP is 172.234.253.10) smtp.mailfrom=linux-sunxi+bounces-24428-noreply=patchwork.local@lists.linux.dev smtp.helo=sea.lore.kernel.org Received-SPF: pass (mxe881: domain of lists.linux.dev designates 172.234.253.10 as permitted sender) client-ip=172.234.253.10; envelope-from=linux-sunxi+bounces-24428-noreply=patchwork.local@lists.linux.dev; helo=sea.lore.kernel.org; Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id ED8513054F71 for ; Wed, 15 Jul 2026 09:55:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AA0192931C8; Wed, 15 Jul 2026 09:55:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bHsrdTsB" X-Original-To: linux-sunxi@lists.linux.dev Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46503387361 for ; Wed, 15 Jul 2026 09:55:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784109356; cv=none; b=O06dG9bFICnXk/h5w+9PLEaQDc5Di9wfE+AaGZIm9Uo6LQpctAADUlr7Y51GC1ei19x7/UbQuHUdvvKJ1WkTLVfhzGCiSZcnBoKo5U0Hwdu5eeQB3wuODXiT/Vd6gTEKQgEeKOXOYwntVp1iaT3XVzarKM0yxERXK4PRO8AYWX8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784109356; c=relaxed/simple; bh=k83hZbTKuOl//PgUx5fOIdMW+RR7uZ50uJTt+Avj9Nw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EsmV/S6pxLD9gW5cQyev6c0B5e6VGCUQpMV8lBiosEhu2qLAzwff1ktZQB6RD4gCEc5U2hDHWgdz5mA3VHr4PUkwkJ7dVSoAhVFFdrAy2uJprgVA1/IZkceYuf1Y9U5q/reAWjCVTOuYONil8gvST+fM3Bv6D3Kh9X+schSMjOA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bHsrdTsB; arc=none smtp.client-ip=209.85.215.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-ca913a601fbso3684642a12.3 for ; Wed, 15 Jul 2026 02:55:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784109355; x=1784714155; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7BpJzZu2JI6YrdHbblIuBNywzFxSYtVh1mg+KZtTDf0=; b=bHsrdTsBB71boIUssjlApZsWRRFgXrWVAaaguvRcpSIAm9NYjGq7PeScLu9Ndtg2Aw zfwma90KSvCJsc+w4rFMPsZmLNyBbYKWUkeP0ADePTR95z1LK21ODQpxM6/jemNhkpDB fDrETbqHb2CLLF3cSKMHmql6ntaOjniB9uQrx4CPLK3L6O1E8MH5nXApodjDV5/th502 uNcA4fMlau5alEvBlkgU8xnRBPycEZ7bTREKFwYhCUR8DcfqOCfyYSFmhsjzFk0IAKjM zpkN6/f9vVBSuMs+QFm3CHUMkar7Nlvb9+t2IjYX5rGi6su4LyLQhacsDCcXiu/alLUH /trg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784109355; x=1784714155; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=7BpJzZu2JI6YrdHbblIuBNywzFxSYtVh1mg+KZtTDf0=; b=dV9HG30b+4uDIW54yFLX2ncQ2cbCnhgTDSnZrHgs0GiFa9R7QIP4NR70VF1wN/fnxs r4UKkq5uswI60UwViLoRwIt8yP5cQVaTqDhwYxLr//4DIs9m79MXCiJFp9mRcAqwoPxi r74TLJ6khoJOXGX4gdm1jHAdIzaSFUJnEPOVz8ZHO8tOLDAcsHs/6ciDKxr3uvzcaovE rsIknOtFJks8kQ1Kqoh/k0qRmfnjgcCcAEoyuYoTSnJev+bsZx8EOnVL6i5wcSHJg9E4 uqadYWHSTJ+6sZlB4ZwyAJLzJMDEVksaZheYU2X6wRN3bBIF0fCw+/gDNNP/GGHyx2Ma EHRw== X-Forwarded-Encrypted: i=1; AHgh+Rp6NxdjsYpKVXq4SvV+XhPKq0+SEFsMQP1tVjRTKoyitkw6hJDlYBm/DVYO8IQwcBBRohLlRDxxPhBlyA==@lists.linux.dev X-Gm-Message-State: AOJu0Ywadr4me0WRYLGAJo/+OtOTgtaWO/Mg499sTve87y9A/5489wp8 mo7WgSUfhsc4fU0dTve0IO+tUJb3bQrKUvnT0+pwZYUhEAlZnwv3A9f2 X-Gm-Gg: AfdE7ckW80QdOmsFKnzA3+PZPfUy5/+388ksTDt9P0TRE7KQkhLvSRNizIHE1F7LrcK Ne9m2fWsmp4L9HJpEnbWDpGq7O5IhepmRuI8AzppOHfOBVH2Wl14YTvz6GUQc+YfF6jjrwxY74d q8/PeuAUCZF+sXLrhYmt/fpkKCnIARHsvlybg3lOKN7CfDonZwy09dfCpzH1akCPUO67CJd0ssB e5IZScG7LRcV5c/xgcgW1r0UabzO9Z89AgGhekI4KcfMmibwX+9kixfCkvl+6cMMvHWAyR+GLw9 e+kz86HuEADO8Pu8gSWkMGyPyZjxDOoo9VRGl1qu1VgU+bG1dqrTLU3KnWRKcuj49l0GbWeluk/ 61TYsxH5rzUsIWnYmmiSq4KS05U7vI6GfO637hK/sc161PLLgxD3FdBC7slANRjrNyL2zu8mgpx WiKYhQIP15dzdBx11QCK7APAslnYW+bPl1K8aBEa7Q8co09ww= X-Received: by 2002:a05:6a20:3d8b:b0:3b4:931c:3c7c with SMTP id adf61e73a8af0-3c357553dfcmr7448713637.44.1784109354620; Wed, 15 Jul 2026 02:55:54 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ca5b3643399sm11628908a12.22.2026.07.15.02.55.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 02:55:54 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai Cc: Jernej Skrabec , Samuel Holland , Charles Keepax , Kuninori Morimoto , Chen Ni , Marcus Cooper , Bjorn Helgaas , Danilo Krummrich , u.kleine-koenig@baylibre.com, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sound@vger.kernel.org, bui duc phuc Subject: [PATCH 1/6] ASoC: sunxi: sun4i-codec: Use dev_err_probe() for probe error handling Date: Wed, 15 Jul 2026 16:55:20 +0700 Message-ID: <20260715095525.40668-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260715095525.40668-1-phucduc.bui@gmail.com> References: <20260715095525.40668-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MORS-Enabled: yes X-MORS-DOMAIN: patchwork.local X-MORS-HOSTING: hosting172546 X-MORS-USER: hosting172546 X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= From: bui duc phuc Use dev_err_probe() for probe error handling to simplify the error paths and handle -EPROBE_DEFER correctly. Signed-off-by: bui duc phuc Reviewed-by: Chen-Yu Tsai --- sound/soc/sunxi/sun4i-codec.c | 70 ++++++++++++++--------------------- 1 file changed, 28 insertions(+), 42 deletions(-) diff --git a/sound/soc/sunxi/sun4i-codec.c b/sound/soc/sunxi/sun4i-codec.c index f4e22af594fa..05308df3ae5b 100644 --- a/sound/soc/sunxi/sun4i-codec.c +++ b/sound/soc/sunxi/sun4i-codec.c @@ -2316,67 +2316,54 @@ static int sun4i_codec_probe(struct platform_device *pdev) scodec->regmap = devm_regmap_init_mmio(&pdev->dev, base, quirks->regmap_config); - if (IS_ERR(scodec->regmap)) { - dev_err(&pdev->dev, "Failed to create our regmap\n"); - return PTR_ERR(scodec->regmap); - } + if (IS_ERR(scodec->regmap)) + return dev_err_probe(&pdev->dev, PTR_ERR(scodec->regmap), + "Failed to create our regmap\n"); /* Get the clocks from the DT */ scodec->clk_apb = devm_clk_get_enabled(&pdev->dev, "apb"); - if (IS_ERR(scodec->clk_apb)) { - dev_err(&pdev->dev, "Failed to get the APB clock\n"); - return PTR_ERR(scodec->clk_apb); - } + if (IS_ERR(scodec->clk_apb)) + return dev_err_probe(&pdev->dev, PTR_ERR(scodec->clk_apb), + "Failed to get the APB clock\n"); scodec->clk_module = devm_clk_get(&pdev->dev, "codec"); - if (IS_ERR(scodec->clk_module)) { - dev_err(&pdev->dev, "Failed to get the module clock\n"); - return PTR_ERR(scodec->clk_module); - } + if (IS_ERR(scodec->clk_module)) + return dev_err_probe(&pdev->dev, PTR_ERR(scodec->clk_module), + "Failed to get the module clock\n"); if (quirks->has_reset) { scodec->rst = devm_reset_control_get_exclusive_deasserted(&pdev->dev, NULL); - if (IS_ERR(scodec->rst)) { - dev_err(&pdev->dev, "Failed to get reset control\n"); - return PTR_ERR(scodec->rst); - } + if (IS_ERR(scodec->rst)) + return dev_err_probe(&pdev->dev, PTR_ERR(scodec->rst), + "Failed to get reset control\n"); } scodec->gpio_pa = devm_gpiod_get_optional(&pdev->dev, "allwinner,pa", GPIOD_OUT_LOW); - if (IS_ERR(scodec->gpio_pa)) { - ret = PTR_ERR(scodec->gpio_pa); - dev_err_probe(&pdev->dev, ret, "Failed to get pa gpio\n"); - return ret; - } + if (IS_ERR(scodec->gpio_pa)) + return dev_err_probe(&pdev->dev, PTR_ERR(scodec->gpio_pa), + "Failed to get pa gpio\n"); + scodec->gpio_hp = devm_gpiod_get_optional(&pdev->dev, "hp-det", GPIOD_IN); - if (IS_ERR(scodec->gpio_hp)) { - ret = PTR_ERR(scodec->gpio_hp); - dev_err_probe(&pdev->dev, ret, "Failed to get hp-det gpio\n"); - return ret; - } + if (IS_ERR(scodec->gpio_hp)) + return dev_err_probe(&pdev->dev, PTR_ERR(scodec->gpio_hp), + "Failed to get hp-det gpio\n"); /* reg_field setup */ scodec->reg_adc_fifoc = devm_regmap_field_alloc(&pdev->dev, scodec->regmap, quirks->reg_adc_fifoc); - if (IS_ERR(scodec->reg_adc_fifoc)) { - ret = PTR_ERR(scodec->reg_adc_fifoc); - dev_err(&pdev->dev, "Failed to create regmap fields: %d\n", - ret); - return ret; - } + if (IS_ERR(scodec->reg_adc_fifoc)) + return dev_err_probe(&pdev->dev, PTR_ERR(scodec->reg_adc_fifoc), + "Failed to create regmap fields\n"); scodec->reg_dac_fifoc = devm_regmap_field_alloc(&pdev->dev, scodec->regmap, quirks->reg_dac_fifoc); - if (IS_ERR(scodec->reg_dac_fifoc)) { - ret = PTR_ERR(scodec->reg_dac_fifoc); - dev_err(&pdev->dev, "Failed to create regmap fields: %d\n", - ret); - return ret; - } + if (IS_ERR(scodec->reg_dac_fifoc)) + return dev_err_probe(&pdev->dev, PTR_ERR(scodec->reg_dac_fifoc), + "Failed to create regmap fields\n"); /* DMA configuration for TX FIFO */ scodec->playback_dma_data.addr = res->start + quirks->reg_dac_txdata; @@ -2422,10 +2409,9 @@ static int sun4i_codec_probe(struct platform_device *pdev) snd_soc_card_set_drvdata(card, scodec); ret = snd_soc_register_card(card); - if (ret) { - dev_err_probe(&pdev->dev, ret, "Failed to register our card\n"); - return ret; - } + if (ret) + return dev_err_probe(&pdev->dev, ret, + "Failed to register our card\n"); return 0; } From patchwork Wed Jul 15 09:55:21 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bui Duc Phuc X-Patchwork-Id: 2658 Return-Path: X-Original-To: noreply@patchwork.local Delivered-To: noreply@patchwork.local Received: from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10]) by mxe881.netcup.net (Postfix) with ESMTPS id 8D6B71C2C76 for ; Wed, 15 Jul 2026 11:57:42 +0200 (CEST) Authentication-Results: mxe881; dkim=pass header.d=gmail.com; spf=pass (sender IP is 172.234.253.10) smtp.mailfrom=linux-sunxi+bounces-24429-noreply=patchwork.local@lists.linux.dev smtp.helo=sea.lore.kernel.org Received-SPF: pass (mxe881: domain of lists.linux.dev designates 172.234.253.10 as permitted sender) client-ip=172.234.253.10; envelope-from=linux-sunxi+bounces-24429-noreply=patchwork.local@lists.linux.dev; helo=sea.lore.kernel.org; Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id 02205309558B for ; Wed, 15 Jul 2026 09:56:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A80B142BE9D; Wed, 15 Jul 2026 09:56:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GV1VmPgP" X-Original-To: linux-sunxi@lists.linux.dev Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 640013C945A for ; Wed, 15 Jul 2026 09:56:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784109362; cv=none; b=X3TKw0E465TqNjJiH/RLgULasnw/MQZgSps7Ps3B7Lahf92bM+sZxCBpXZukQsDhgenDpWvUjdrXg8gJZJZ+TSLPRwHLvBrdPAgQQQlmUhKP7oXaXD51o402bsVYUc6CXf9ulSEgQo1vB0KxVhY1aeVEnswrrlglQr7KEutNQsM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784109362; c=relaxed/simple; bh=JYpMe5xJN7tUQUFpfvpPUyELSznoJMPf/vIdMkvzM/k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Stlrr2g2/EaGpnvtZTbj6mve5fggVLxSg6rwwZ0B6T7soz47/wLw79yLz7L39idqwB0mS0r5XAsi0z36d5x1NGjrrBCEeWjgy3+V5V46L53qDOBc6BYFWhcEkmhe1t2+neYjeFs5cQNaLklKKK4RBbGl1v0b/u2GewUVKx2p1Oc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GV1VmPgP; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-c9e607d81fcso1231251a12.2 for ; Wed, 15 Jul 2026 02:56:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784109361; x=1784714161; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=PZY26nfH61F/ozoLH7Gi9fNecnPmd2NgxbQtVT0E040=; b=GV1VmPgPJf4TsZyp+LnVkTpeFt9eIYpTXSLDyjy/KpJkoBqL4pJLMcLUMiKjIOOa1M j9E+mnyZQ4Pzyee+e8Dx001JLIOy3LkyPmSzYn5FvQKB7UkqS6408yEslXAZxWRWra9W aN6up/lL3qDMoPM+rtqvjjVUQGJxDnwPbkWdZZzBwoL/LyfDozTez6CTXmqvlfeAXTTz qBD2N7Cmm3dk3eWSiSF+X0Il0z/ca3x9wOHIKi/5LVjZB+BAQ4v4bC+c5czdOG7m2YsN 80OYNEEmEaIXpEHqQn6cfoNV42CJrE2QzfSfGVlux8PoDGkmcwhPuUsOZNCOvUZGPsbs Oy2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784109361; x=1784714161; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=PZY26nfH61F/ozoLH7Gi9fNecnPmd2NgxbQtVT0E040=; b=cZw/MXsn2XSl8l+6WHjqB7Qse5L4h77TPpBG1HysSFBnocnLCN9SsNYVQyIctgW45H 8t4t7ap6cND3POCe7s26/h7EO7idMHzux6vgdX8ayFMymj0TRYCzmK2a2oPv9G0Dc3HN 3nBesD8Zr5vl4oyilrFpbX137v+tVW1UNAswFHoIZR7W4zkh5al3brhl6nHM36ymlW/L nogwe3DCie0K3zC1Z+jBGNfesj58ZqkWeAXNeZXb2q2zuVAJ9EtGqi5iJVLgG3UnYyWU dZIA0VXa71EwGmTW4cZucXslv3ftkVOv5n4M/O0Dbw1H2fmI3IQNFK2edaFInbKx/E6L 7LEg== X-Forwarded-Encrypted: i=1; AHgh+Rq398kWtmjtZS7+ggoxWyypQuKiZyelH4ZYZwzYIVVVtO4PZMfWCKdEWZ0NdtcY/YjYQj48UQG7ZuKp7Q==@lists.linux.dev X-Gm-Message-State: AOJu0YzjkCPVV//X/UZQKEiRp1a20gSAlYxhMnjXaKis//jyUfWpUSij 8edfoLQre8PhUIKgjg/Q6b/0Aos10oMVegm7vjk4wvuI6q+kD6U3Hhik X-Gm-Gg: AfdE7cnrO013fOFTbZsQtC1Y4xTxyjlgmu54No9QyswrCCu1QLBnN+zJ8hi/zONSVuB H5Ft6XtcUt5GEKLBgHmi2cfRkLtlXJdzLwioDg4tAK8AdP6wGa1lKQwLqcpp97PN/7O1IwnxITX CA3oAgEF9t+i37NQRJqMYrH+gHTb+KW42hbnwiKUH0mmTrsUotqZsO7sVXx+SifYyuIk5ux9H2C SsIscj5CmwkbENhGCwgG+MKRS2y5k8HV22Xj2bkwvvC6Ukk8HXv83rGAzeJEg0kqHi+m8Ilavw0 qKug6u7ecySCaVQedeafbkxzP7E3ov035jLJHJwxoRz06ejpC4FkQDpYOH/N3YiYx04UjiQQoJc 7FrFNTdS4E9H7EUJyKfNpiQgjasCR3l5B8qFIFHyRz56FnRzmxORSE+iR9NtF1nUbsFpp+sDF6k n5qdp6mMlXZriU13FAedUMNxIw2+5kX27/FXKDYiRP9s8aF0g= X-Received: by 2002:a05:6a21:510:b0:3bf:6c08:2b2b with SMTP id adf61e73a8af0-3c110b6e0a7mr18474760637.51.1784109360730; Wed, 15 Jul 2026 02:56:00 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ca5b3643399sm11628908a12.22.2026.07.15.02.55.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 02:56:00 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai Cc: Jernej Skrabec , Samuel Holland , Charles Keepax , Kuninori Morimoto , Chen Ni , Marcus Cooper , Bjorn Helgaas , Danilo Krummrich , u.kleine-koenig@baylibre.com, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sound@vger.kernel.org, bui duc phuc Subject: [PATCH 2/6] ASoC: sunxi: sun4i-codec: Drop redundant error messages Date: Wed, 15 Jul 2026 16:55:21 +0700 Message-ID: <20260715095525.40668-3-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260715095525.40668-1-phucduc.bui@gmail.com> References: <20260715095525.40668-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MORS-Enabled: yes X-MORS-DOMAIN: patchwork.local X-MORS-HOSTING: hosting172546 X-MORS-USER: hosting172546 X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= From: bui duc phuc The called functions already log failures where appropriate. Return the original error directly and avoid duplicate error messages. Signed-off-by: bui duc phuc --- sound/soc/sunxi/sun4i-codec.c | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/sound/soc/sunxi/sun4i-codec.c b/sound/soc/sunxi/sun4i-codec.c index 05308df3ae5b..71f7a1fedd88 100644 --- a/sound/soc/sunxi/sun4i-codec.c +++ b/sound/soc/sunxi/sun4i-codec.c @@ -2380,31 +2380,22 @@ static int sun4i_codec_probe(struct platform_device *pdev) ret = devm_snd_soc_register_component(&pdev->dev, quirks->codec, &sun4i_codec_dai, 1); - if (ret) { - dev_err(&pdev->dev, "Failed to register our codec\n"); + if (ret) return ret; - } ret = devm_snd_soc_register_component(&pdev->dev, &sun4i_codec_component, &dummy_cpu_dai, 1); - if (ret) { - dev_err(&pdev->dev, "Failed to register our DAI\n"); + if (ret) return ret; - } ret = devm_snd_dmaengine_pcm_register(&pdev->dev, NULL, 0); - if (ret) { - dev_err(&pdev->dev, "Failed to register against DMAEngine\n"); + if (ret) return ret; - } card = quirks->create_card(&pdev->dev); - if (IS_ERR(card)) { - ret = PTR_ERR(card); - dev_err(&pdev->dev, "Failed to create our card\n"); - return ret; - } + if (IS_ERR(card)) + return PTR_ERR(card); snd_soc_card_set_drvdata(card, scodec); From patchwork Wed Jul 15 09:55:22 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bui Duc Phuc X-Patchwork-Id: 2659 Return-Path: X-Original-To: noreply@patchwork.local Delivered-To: noreply@patchwork.local Received: from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10]) by mxe881.netcup.net (Postfix) with ESMTPS id DB51E1C2C76 for ; Wed, 15 Jul 2026 11:58:28 +0200 (CEST) Authentication-Results: mxe881; dkim=pass header.d=gmail.com; spf=pass (sender IP is 172.234.253.10) smtp.mailfrom=linux-sunxi+bounces-24430-noreply=patchwork.local@lists.linux.dev smtp.helo=sea.lore.kernel.org Received-SPF: pass (mxe881: domain of lists.linux.dev designates 172.234.253.10 as permitted sender) client-ip=172.234.253.10; envelope-from=linux-sunxi+bounces-24430-noreply=patchwork.local@lists.linux.dev; helo=sea.lore.kernel.org; Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id 3481430D0371 for ; Wed, 15 Jul 2026 09:56:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9DA8D3C945A; Wed, 15 Jul 2026 09:56:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="I3DzyV/Q" X-Original-To: linux-sunxi@lists.linux.dev Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E09D23909B9 for ; Wed, 15 Jul 2026 09:56:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784109369; cv=none; b=R2/NUANqzcIy6MDujEVYU0vmLeW8K4uNHszojnTEnKK4PE741ktLwyxYk4ooofLCnxK+UOWO/ZOQdcTWiJw468Fxac3RKbOqP0rDL9fHb38v6jFEoAJIsKzMndPzAbf7QOUHCESG8YjYGo44eDdTOmnWgt70Vu5VSB7wh2hyPJs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784109369; c=relaxed/simple; bh=vXMUV2NHdzO2bVhOLxgO//r4EwHkTLLI06VBSO1JtTM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IQ2K1Y8BsAhdDwOn8vRf197kav3a2R0OEcPDh+LsJR69L4Q66AyoKLA4Fw27tM054DulL3wmO5TSYh9gbW9l/wL+Bg5KmWHd18tPw0oBQ6kFBIWtbcuO44ILKxAS0PvEJKzl+HUXOy3ZTvd7wgSb7XNmHZemJEqp2EdHHHB33zs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=I3DzyV/Q; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-ca88130e09aso3505118a12.3 for ; Wed, 15 Jul 2026 02:56:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784109366; x=1784714166; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=AbwPz53OQjxnJig2YQsbZ1pk7oPIkLRBw9/Vd+k0PqQ=; b=I3DzyV/QeTpQ0sus1VW/CkqHhDAb73GJlZBtFShpDTZ28tHvZtQ8euFYZOu3qxQL8p 6RNuzU4wHUZNNeTkPeIMN6BIdC0+tUJ6YDB4RLvRoWS5WCNajlnhARINJR/2t6T4/feC wWOrm1zt5KqWlqTdcUtZiUYUEBeXu2KFOauAQEImMSKvNWWBxkSelrZMPic6VhmCe0cb sUQ82doulJQE4dXKxJMTrfllokNk/pvb+kICn90Bm4zZxkP3wVq0t/H4FmcnfXqB4Y5r V/GHEaayTFfpPvZ29/Z/3VQgdiO6cxJqBIVn4cVdzSs5eeDMHKOo+oRJHzZ4xOLRPDXn b30Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784109366; x=1784714166; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=AbwPz53OQjxnJig2YQsbZ1pk7oPIkLRBw9/Vd+k0PqQ=; b=CYrBg/CaaSdEg5eYMvJx1lD3UDNA4yipNN+l1545BjMTV5C4gTlS9vmNZY+c4QUU/q Oo7PqcZOoHDVr2VFZZ2mlZkfse2ejyMKZJ8tL6w03w4kzUHBr7FyDzR6BvW15Z4t46ug okeH8D9FuR14jjkpQcpnUAHltPdXYfKwd9JTF35xCe2s2BYWyxuGz2iDya1wjSOBwJX+ G17pNGXIQ4R4ehdfiXvYzui8SkeJ/CcmM4/Gg0PSuzH2oyO/x6s31chV8TdHHtGmLeQ9 +CKZhMUYB4/yyxS34EYBfj/RLJ2OiAC4NgGLRCN1jqZBcAGUaeu3xVKL0aU4vMEYC0VU f77w== X-Forwarded-Encrypted: i=1; AHgh+RoQPny/8FPmpEcw6mZ/TGFvjZyKNVdImM5ayLvsl1ks/LaYy0iNtw00XoSqGhemKIahJ9uWbIq7QcQYCA==@lists.linux.dev X-Gm-Message-State: AOJu0Yx5V+ufQN3wm/XhA/HkFl9117aJ2GDDH+x/5IXfObm8YHsu7OBU cZ683uwTMIBN648YoiqSUuWaw5vHSjso43+00dNOtB4nHnheNN686paV X-Gm-Gg: AfdE7cnAyA6u4IIjTLMJYKpLztP75z/GRXdp/67rVQ/AhtKFD0NQnt2SCJGJjVKWriB KCAEcQg0ZyT90TiH/Rv94McmWWkYXN8mhK5VKpFtVPYJ/CHVR7MOrIwgxOI3O7hhwbCamYUxOe8 Q2SaI4pxxAQSKGbV9L9QBwLGRNsiHktz7F4g1XHu7H0C2EkdxvnVEYL5vzgCLgbzmD0tka1TaS5 M+/7jsPtsOA99Kx/IQ9Dyxu/8wi72agn/IMaDCO0GAlie1BwNepwUW12xG+hRREAXoo/Zm6EdTG lWj4cGjWl2QhPkCtTksBzkxS9QpKs48j7JwI3tx8GHFlVQXfNLo0R0Z3RnhhUR8kk0IaeNf6748 j7cV7nFlbhgXSJjBA0AX12ShsuB1g33iF3CyGBM8F2vxVRiiZ5a7qXmeVjpWSiL19KrVE7q42zC OdrsOyAeS4GZssirUAnCAQy9+fMmvTjbMQ6Li4rGUjQSC90rM= X-Received: by 2002:a05:6300:2787:20b0:3c3:7019:64ad with SMTP id adf61e73a8af0-3c370196776mr1215140637.66.1784109366301; Wed, 15 Jul 2026 02:56:06 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ca5b3643399sm11628908a12.22.2026.07.15.02.56.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 02:56:06 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai Cc: Jernej Skrabec , Samuel Holland , Charles Keepax , Kuninori Morimoto , Chen Ni , Marcus Cooper , Bjorn Helgaas , Danilo Krummrich , u.kleine-koenig@baylibre.com, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sound@vger.kernel.org, bui duc phuc Subject: [PATCH 3/6] ASoC: sunxi: sun4i-i2s: Use dev_err_probe() for probe error handling Date: Wed, 15 Jul 2026 16:55:22 +0700 Message-ID: <20260715095525.40668-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260715095525.40668-1-phucduc.bui@gmail.com> References: <20260715095525.40668-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MORS-Enabled: yes X-MORS-DOMAIN: patchwork.local X-MORS-HOSTING: hosting172546 X-MORS-USER: hosting172546 X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= From: bui duc phuc Use dev_err_probe() for probe error handling to simplify the error paths and handle -EPROBE_DEFER correctly. Signed-off-by: bui duc phuc Reviewed-by: Chen-Yu Tsai --- sound/soc/sunxi/sun4i-i2s.c | 28 ++++++++++++---------------- 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c index 40de99a34bc3..716fa4d872ff 100644 --- a/sound/soc/sunxi/sun4i-i2s.c +++ b/sound/soc/sunxi/sun4i-i2s.c @@ -1550,30 +1550,26 @@ static int sun4i_i2s_probe(struct platform_device *pdev) } i2s->bus_clk = devm_clk_get(&pdev->dev, "apb"); - if (IS_ERR(i2s->bus_clk)) { - dev_err(&pdev->dev, "Can't get our bus clock\n"); - return PTR_ERR(i2s->bus_clk); - } + if (IS_ERR(i2s->bus_clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(i2s->bus_clk), + "Can't get our bus clock\n"); i2s->regmap = devm_regmap_init_mmio(&pdev->dev, regs, i2s->variant->sun4i_i2s_regmap); - if (IS_ERR(i2s->regmap)) { - dev_err(&pdev->dev, "Regmap initialisation failed\n"); - return PTR_ERR(i2s->regmap); - } + if (IS_ERR(i2s->regmap)) + return dev_err_probe(&pdev->dev, PTR_ERR(i2s->regmap), + "Regmap initialisation failed\n"); i2s->mod_clk = devm_clk_get(&pdev->dev, "mod"); - if (IS_ERR(i2s->mod_clk)) { - dev_err(&pdev->dev, "Can't get our mod clock\n"); - return PTR_ERR(i2s->mod_clk); - } + if (IS_ERR(i2s->mod_clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(i2s->mod_clk), + "Can't get our mod clock\n"); if (i2s->variant->has_reset) { i2s->rst = devm_reset_control_get_exclusive(&pdev->dev, NULL); - if (IS_ERR(i2s->rst)) { - dev_err(&pdev->dev, "Failed to get reset control\n"); - return PTR_ERR(i2s->rst); - } + if (IS_ERR(i2s->rst)) + return dev_err_probe(&pdev->dev, PTR_ERR(i2s->rst), + "Failed to get reset control\n"); } if (!IS_ERR(i2s->rst)) { From patchwork Wed Jul 15 09:55:23 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bui Duc Phuc X-Patchwork-Id: 2655 Return-Path: X-Original-To: noreply@patchwork.local Delivered-To: noreply@patchwork.local Received: from sto.lore.kernel.org (sto.lore.kernel.org [172.232.135.74]) by mxe881.netcup.net (Postfix) with ESMTPS id 593A91C2C76 for ; Wed, 15 Jul 2026 11:56:16 +0200 (CEST) Authentication-Results: mxe881; dkim=pass header.d=gmail.com; spf=pass (sender IP is 172.232.135.74) smtp.mailfrom=linux-sunxi+bounces-24431-noreply=patchwork.local@lists.linux.dev smtp.helo=sto.lore.kernel.org Received-SPF: pass (mxe881: domain of lists.linux.dev designates 172.232.135.74 as permitted sender) client-ip=172.232.135.74; envelope-from=linux-sunxi+bounces-24431-noreply=patchwork.local@lists.linux.dev; helo=sto.lore.kernel.org; Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sto.lore.kernel.org (Postfix) with ESMTP id EE8453008993 for ; Wed, 15 Jul 2026 09:56:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0CDFD3C3450; Wed, 15 Jul 2026 09:56:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Fd+AkR8k" X-Original-To: linux-sunxi@lists.linux.dev Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD5773CEBA6 for ; Wed, 15 Jul 2026 09:56:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784109373; cv=none; b=bkz5T1biAW/qwKzU9KuIgYMXCxaqakL/0DfZe0rwb9MF64inSkCqzhkK4p7KGVtGxCp/QhPTd2cRLUaKJGwDJttiJ3u6B4Z++CQOLudsua2SnajxTgeBOPG17HTU0lb7CdQmqvjBdrufQ43cntUp70E2uvztZxXtn9b2WxHexyQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784109373; c=relaxed/simple; bh=jXeHXz0sgTqbPCpgE0Ek4FYcDSoYTpRTfMU644+qSc8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=liyyBVnoJpMjFv2U9LMQkAgKZOj5ZAyCU1L6Za/MbL6wJhJp4Yj7LThWmXrzjdz60s1iZG3WLqtWGKbGnFOs3qWQi6/WPj3Rdbm6Ut6ohHoG8TKmdQnNgT464SyK5hUI9lrasFtkTMoxjE73oVOOj1RwFeyj0lftW0/NdEvF0GY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Fd+AkR8k; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-84a4d8fd6ecso1873047b3a.1 for ; Wed, 15 Jul 2026 02:56:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784109372; x=1784714172; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=IG9ROgmPkgpOSWt5kVvQ2eBpCUOMrMqYLeguMnD/GAI=; b=Fd+AkR8kDFOYqv2LRsO5/ln7NYO4XhZIrx1EW3lu5nsKoAZJyc/R5MpFbWM+GvBwkw GEhrCd0jAJ79g9pKKQPPnO02OeVWXEk1roIWD8fkWWqU/TT43/2aznaEmt6+HgIuvjVK fmaNikhiR6rS/AiUu7J166nz2LuSGnbJH5YXy84e0gIsEH/GWRmrHuQo/ezxRfmxUGDK iUwwtR+Ok8eLUrB39fXHa1Hp2sX55gPT0UC2BKRoLaT57/rd5UdZUIAH/I6CiXfGv+lu 9thz6dm02UwEVU4BBUyfvjtirqVHcRX3pCOTkXreYMJAdxR2DVup5Su8GeGqm+vnojyY 6Lig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784109372; x=1784714172; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=IG9ROgmPkgpOSWt5kVvQ2eBpCUOMrMqYLeguMnD/GAI=; b=Slbw4hrxeVfcXBaw9P2A3n5mj1UFqlWw++/rh13QIcXF8RlOxVgvDmE6iHXrQK+D5J mKCbhM0ZR/ObG74z4qNK7VRj36PyFUKO7FEd6sbcWWTVr5We/H9TTLPzKt4fAynYO2vK 7S1WRqRfTDWXuRSN+4ARg8LwDTm4ivMbsZgwmFGraBBtZZ3O+z7FJkXjQHUZb7JwwC+w aKKstS7luO1cqtLxx08/nlDM/shaY9vdJNuoNgtJs9Z4Utgglpa13/NGxC4ZX+iH1/1U 0H0siTvmvFo0Hih92MuZ0A+0YIwissxqfLpqP7uylJTM2HJwMno57BRaOYMJUQU/X2z8 TnYA== X-Forwarded-Encrypted: i=1; AHgh+RqA4gSPfR5W8fMzKGTD/i7nG31dGV3XNRVlz7chOykV7i4c+HsnHOFoztcOSeJm/btRG+tWfd7nPj326Q==@lists.linux.dev X-Gm-Message-State: AOJu0Yx4bsKy/s0vd1kIiWjlXuv6uhC+gACQalEgI5tUOVgJxWPApo7X shvRWVIyCK8fk7OemfNhKMvUTvQNubaqa17YQWWnHmdNcz8Lby+yWg7q X-Gm-Gg: AfdE7cnzSMOfM+xxjB2R4zkaXJBwjpE+cckI/GAJJv8SX7p34JHKGVTrJAGFSEjybmc xNNC0yfwBlCWCVmfvP1CgzPZHx2PYmeBXGtcbyoZc9HnKJgHSSPvQ5lZdDKHkRmSPW83oe+CQaN Z2swv9X1kbruV7ElgXSIdWS69D5UxZM5c37EkuHc4kP4w3yk1GPqpPQAQOMjV+f57JQ3D+MMyRZ o9gIQpUXzdvxUG4fc/EgmiWOTtCqluKa2Y4j8Lgb6AyeQO0nDqMrTaOL/30gNcDoeS3ZUBQLyyv bzVzNVrfvCuzrSD46hY2zLKBndH92UMjGkgWu6Z8Y0coZ1Rda0WOszOTzeNAONwTVKhCFUBY6ox CJ7gLEaMRZE7a28/ZB3rSiduHyBZG3vq5UR9bXEBKyUM7t2LRMQehsARdPO7Zr7eHoHR6lpSm2y 7Cv1OM5yFZFm1tvmc7Elp5WnhyoELGGoXxMWsJJ1VQWWmwkg8= X-Received: by 2002:a05:6a00:10c9:b0:847:86b0:888c with SMTP id d2e1a72fcca58-84a6733bf25mr1897232b3a.48.1784109372039; Wed, 15 Jul 2026 02:56:12 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ca5b3643399sm11628908a12.22.2026.07.15.02.56.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 02:56:11 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai Cc: Jernej Skrabec , Samuel Holland , Charles Keepax , Kuninori Morimoto , Chen Ni , Marcus Cooper , Bjorn Helgaas , Danilo Krummrich , u.kleine-koenig@baylibre.com, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sound@vger.kernel.org, bui duc phuc Subject: [PATCH 4/6] ASoC: sunxi: sun4i-spdif: Use dev_err_probe() for probe error handling Date: Wed, 15 Jul 2026 16:55:23 +0700 Message-ID: <20260715095525.40668-5-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260715095525.40668-1-phucduc.bui@gmail.com> References: <20260715095525.40668-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Rspamd-Server: rspamd-worker-8404 X-Spamd-Result: default: False [-0.66 / 15.00]; BAYES_HAM(-5.50)[100.00%]; RBL_SENDERSCORE(2.00)[172.232.135.74:from]; SUSPICIOUS_RECIPS(1.50)[]; DMARC_POLICY_SOFTFAIL(1.00)[gmail.com : SPF not aligned (relaxed), No valid DKIM,none]; R_MISSING_CHARSET(0.50)[]; MAILLIST(-0.15)[generic]; MIME_GOOD(-0.10)[text/plain]; BAD_REP_POLICIES(0.10)[]; HAS_LIST_UNSUB(-0.01)[]; PRECEDENCE_BULK(0.00)[]; TAGGED_RCPT(0.00)[]; FREEMAIL_CC(0.00)[gmail.com,sholland.org,opensource.cirrus.com,renesas.com,iscas.ac.cn,google.com,kernel.org,baylibre.com,lists.linux.dev,vger.kernel.org,lists.infradead.org]; FORGED_SENDER_MAILLIST(0.00)[]; FROM_NO_DN(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; DBL_BLOCKED_OPENRESOLVER(0.00)[sto.lore.kernel.org:rdns,sto.lore.kernel.org:helo]; RCPT_COUNT_TWELVE(0.00)[19]; RCVD_COUNT_FIVE(0.00)[6]; ASN(0.00)[asn:63949, ipnet:172.232.128.0/19, country:SG]; R_SPF_ALLOW(0.00)[+ip4:172.232.135.74]; FREEMAIL_TO(0.00)[kernel.org,gmail.com,perex.cz,suse.com]; FREEMAIL_FROM(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; FROM_NEQ_ENVFROM(0.00)[phucducbui@gmail.com,linux-sunxi@lists.linux.dev]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; RCVD_TLS_LAST(0.00)[]; TAGGED_FROM(0.00)[bounces-24431-noreply=patchwork.local]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; ARC_ALLOW(0.00)[subspace.kernel.org:s=arc-20240116:i=1]; RCVD_VIA_SMTP_AUTH(0.00)[] X-Rspamd-Queue-Id: 593A91C2C76 X-MORS-Enabled: yes X-MORS-DOMAIN: patchwork.local X-MORS-HOSTING: hosting172546 X-MORS-USER: hosting172546 X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= From: bui duc phuc Use dev_err_probe() for probe error handling to simplify the error paths and handle -EPROBE_DEFER correctly. Signed-off-by: bui duc phuc Reviewed-by: Chen-Yu Tsai --- sound/soc/sunxi/sun4i-spdif.c | 23 ++++++++++------------- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/sound/soc/sunxi/sun4i-spdif.c b/sound/soc/sunxi/sun4i-spdif.c index c2ec19437cd7..d979bb00312f 100644 --- a/sound/soc/sunxi/sun4i-spdif.c +++ b/sound/soc/sunxi/sun4i-spdif.c @@ -684,26 +684,23 @@ static int sun4i_spdif_probe(struct platform_device *pdev) host->regmap = devm_regmap_init_mmio(&pdev->dev, base, &sun4i_spdif_regmap_config); - if (IS_ERR(host->regmap)) { - dev_err(&pdev->dev, "failed to initialise regmap.\n"); - return PTR_ERR(host->regmap); - } + if (IS_ERR(host->regmap)) + return dev_err_probe(&pdev->dev, PTR_ERR(host->regmap), + "failed to initialise regmap.\n"); /* Clocks */ host->apb_clk = devm_clk_get(&pdev->dev, "apb"); - if (IS_ERR(host->apb_clk)) { - dev_err(&pdev->dev, "failed to get a apb clock.\n"); - return PTR_ERR(host->apb_clk); - } + if (IS_ERR(host->apb_clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(host->apb_clk), + "failed to get a apb clock.\n"); if (quirks->tx_clk_name) tx_clk_name = quirks->tx_clk_name; host->spdif_clk = devm_clk_get(&pdev->dev, tx_clk_name); - if (IS_ERR(host->spdif_clk)) { - dev_err(&pdev->dev, "failed to get the \"%s\" clock.\n", - tx_clk_name); - return PTR_ERR(host->spdif_clk); - } + if (IS_ERR(host->spdif_clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(host->spdif_clk), + "failed to get the \"%s\" clock.\n", + tx_clk_name); host->dma_params_tx.addr = res->start + quirks->reg_dac_txdata; host->dma_params_tx.maxburst = 8; From patchwork Wed Jul 15 09:55:24 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bui Duc Phuc X-Patchwork-Id: 2660 Return-Path: X-Original-To: noreply@patchwork.local Delivered-To: noreply@patchwork.local Received: from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10]) by mxe881.netcup.net (Postfix) with ESMTPS id E2A4E1C2C76 for ; Wed, 15 Jul 2026 11:59:00 +0200 (CEST) Authentication-Results: mxe881; dkim=pass header.d=gmail.com; spf=pass (sender IP is 172.234.253.10) smtp.mailfrom=linux-sunxi+bounces-24432-noreply=patchwork.local@lists.linux.dev smtp.helo=sea.lore.kernel.org Received-SPF: pass (mxe881: domain of lists.linux.dev designates 172.234.253.10 as permitted sender) client-ip=172.234.253.10; envelope-from=linux-sunxi+bounces-24432-noreply=patchwork.local@lists.linux.dev; helo=sea.lore.kernel.org; Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id 2AE6B3017C05 for ; Wed, 15 Jul 2026 09:56:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BA60A387361; Wed, 15 Jul 2026 09:56:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nKWpBnR1" X-Original-To: linux-sunxi@lists.linux.dev Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71B8437E5F5 for ; Wed, 15 Jul 2026 09:56:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784109379; cv=none; b=YHrvHt62iDIG11tDxSOTKED0VhMY4bascrWzRCCGa6Dg7UTiIhlqYgIQ5qUm5QppfWqiPTdsacqp2SoR7+hj3ThkhL1n54sV8AkcC4FDGIsTpHBYXVvPgnFpdatkB4uJ6iR6OlDKsbIxSjuKfa53M+w+lHKCCbtQufKhXBMr5Vw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784109379; c=relaxed/simple; bh=rWAveW84L3R2k6Dr0kk7jzU9NyiQbaV6M5iGKNhBiKE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=beun6vS7cqLckoP0dkMF5tEziSmSW7tza/sRzTHbhhuGXDrjCcTSYHMn6JxTFEvmeGc6sOnUsbbe2eG88ppmxcoOEfIQ78wh/sMiPR4/0wuyFo+KE77mNxTpbDcJH6hwlYnOzkXfBCK1flDGvg1awW1lYAeS5/vMdK+E/lejkE8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nKWpBnR1; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-8487b7b4066so5239851b3a.1 for ; Wed, 15 Jul 2026 02:56:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784109378; x=1784714178; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=oH3dvIiif6Ezut/x+NGlXGEkxyluaoU8qD8m7W6CWsI=; b=nKWpBnR1y/Bi8pt0KPRyvqI9rekN+R94+sZ4numij7TZVez9RAutqrjVjMwntb9dkV FXuEOIhvR1qUk5UHTunz07gFjgzF+Py+QKaMpx/76X5z6/yWdrWIPHjFTxJvYixYIjgX ju4dr9CH7iEWbROQd4VVU78hM2gxsUssvAnMlor04ObYn8wxyjbk/PO9Sl7ZQhKxNBvJ YRXkINX+//cD5GfRedNkNCTHSDTVu6Hy0rmI0Nx26cwXZ1SbNnGFMrSTEBT/bf2ofxhd 7yELgJg6xoUJiO5FNpfmY8RRI7tEhRmF/ONk7eZ5h0d4ArRqg9KkS3Wc8u29y9Pww+Ue gqfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784109378; x=1784714178; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=oH3dvIiif6Ezut/x+NGlXGEkxyluaoU8qD8m7W6CWsI=; b=SEWVN4C/yr721hx8efqco/wVmTpQH2nOowd2iMGAxj0ij0oR1nccN9GU5TmiUV3PMI I7heHHbzLqoOrTxuM7lGFD4acEZnCyj+8vYyO4UimnZ+ZRYIc/Uv+jg/83xgsWIue6vD GHFM06bedSA+EHUfsdJMLZgj/O0HY2hhDuZ7KX5edeC1u1H4iKjtLDhe90L3cn7I7ANp AKXN3ZQpbuTZ4v0jA3hFoNQXlQMlYY8rzwmUWT/xPk88z5f63Y1WxYWiQ28W4bzn7ikW yjnju82KUQIRbCy7x2lcMWjNxUbKZiaXCRGoaPm+SG/u2+D5ZJ2JLjvUnpDSB76wF4qX Bs8A== X-Forwarded-Encrypted: i=1; AHgh+RpsZzNoCcy618CW3OLhsN4TVRA3dhV7FPQq3NpcwnJfjWKor9W9Tzkkvg0wCb9TWW6t03Wqt756m7biGA==@lists.linux.dev X-Gm-Message-State: AOJu0YxlXsy2bkxAsAidgqQQHQKki0ZSnZnQibIrj6B+C13Ds7CkEROv 401yK1bRVTBj1usp6Ch8nvsAvxqActPdnnhje6CHVpjKf3BrtMpLolEp X-Gm-Gg: AfdE7clhrOtTfIk4M7J2YjOM1yk0AYFB7RzDlC9r8oOlIh59+h4ztd0aJ1ntCTSPVWL 6Ondka7n8mqlFqAct8NSGrg0BxLXjby1NzE1ympedvfr/U0UfrC+Xp73+T1P5nI7qiz5DBnc+Sr oCu0TWhqTJliyo7XLO2Mb2DTrGE1x+/lW7uFO9J48Gr0cbT+2awmEuD4hb7ehtq+8tTp5oLU54+ G7v3Uif/qyot4pfEKVQj3ZvpNUBCzazBACRS8jAMV6j+Esi1iwUG/Cjrm3PgGWbPvIhyxtTkZ10 otzL60lVP9mZZHWiWVshA2/R07tReAGjW5AnOtQIhytdr8R1w4suhEDUXZ5UhbwTNydV6Zoac8m 94DqxGEBCYwsAZxzZMaJbZcDEwqN3nsvWDjBZ0AqkrfNUaGzEi3XutbDZAq7XGfHhasdqh28Z0a KNQkWm4F/gQStgMnYZDARNLxVzbOSiRdINgO5i1VDbTTgGIjY= X-Received: by 2002:aa7:8891:0:b0:847:b2e4:9f68 with SMTP id d2e1a72fcca58-84a671da3aamr1648721b3a.9.1784109377872; Wed, 15 Jul 2026 02:56:17 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ca5b3643399sm11628908a12.22.2026.07.15.02.56.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 02:56:17 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai Cc: Jernej Skrabec , Samuel Holland , Charles Keepax , Kuninori Morimoto , Chen Ni , Marcus Cooper , Bjorn Helgaas , Danilo Krummrich , u.kleine-koenig@baylibre.com, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sound@vger.kernel.org, bui duc phuc Subject: [PATCH 5/6] ASoC: sunxi: sun50i-codec-analog: Improve probe error handling Date: Wed, 15 Jul 2026 16:55:24 +0700 Message-ID: <20260715095525.40668-6-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260715095525.40668-1-phucduc.bui@gmail.com> References: <20260715095525.40668-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MORS-Enabled: yes X-MORS-DOMAIN: patchwork.local X-MORS-HOSTING: hosting172546 X-MORS-USER: hosting172546 X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= From: bui duc phuc Drop the redundant error message after devm_platform_ioremap_resource(), which already reports failures, and use dev_err_probe() for regmap initialization errors. Signed-off-by: bui duc phuc Reviewed-by: Chen-Yu Tsai --- sound/soc/sunxi/sun50i-codec-analog.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/sound/soc/sunxi/sun50i-codec-analog.c b/sound/soc/sunxi/sun50i-codec-analog.c index 9f5b067a8ccc..50c0dee8c433 100644 --- a/sound/soc/sunxi/sun50i-codec-analog.c +++ b/sound/soc/sunxi/sun50i-codec-analog.c @@ -551,16 +551,13 @@ static int sun50i_codec_analog_probe(struct platform_device *pdev) bool enable; base = devm_platform_ioremap_resource(pdev, 0); - if (IS_ERR(base)) { - dev_err(&pdev->dev, "Failed to map the registers\n"); + if (IS_ERR(base)) return PTR_ERR(base); - } regmap = sun8i_adda_pr_regmap_init(&pdev->dev, base); - if (IS_ERR(regmap)) { - dev_err(&pdev->dev, "Failed to create regmap\n"); - return PTR_ERR(regmap); - } + if (IS_ERR(regmap)) + return dev_err_probe(&pdev->dev, PTR_ERR(regmap), + "Failed to create regmap\n"); enable = device_property_read_bool(&pdev->dev, "allwinner,internal-bias-resistor"); From patchwork Wed Jul 15 09:55:25 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bui Duc Phuc X-Patchwork-Id: 2656 Return-Path: X-Original-To: noreply@patchwork.local Delivered-To: noreply@patchwork.local Received: from sin.lore.kernel.org (sin.lore.kernel.org [104.64.211.4]) by mxe881.netcup.net (Postfix) with ESMTPS id A17241C2C76 for ; Wed, 15 Jul 2026 11:56:32 +0200 (CEST) Authentication-Results: mxe881; dkim=pass header.d=gmail.com; spf=pass (sender IP is 104.64.211.4) smtp.mailfrom=linux-sunxi+bounces-24433-noreply=patchwork.local@lists.linux.dev smtp.helo=sin.lore.kernel.org Received-SPF: pass (mxe881: domain of lists.linux.dev designates 104.64.211.4 as permitted sender) client-ip=104.64.211.4; envelope-from=linux-sunxi+bounces-24433-noreply=patchwork.local@lists.linux.dev; helo=sin.lore.kernel.org; Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sin.lore.kernel.org (Postfix) with ESMTP id 3C9F830011BF for ; Wed, 15 Jul 2026 09:56:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9265E37E5F5; Wed, 15 Jul 2026 09:56:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aL/1HYg9" X-Original-To: linux-sunxi@lists.linux.dev Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55E643C3450 for ; Wed, 15 Jul 2026 09:56:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784109385; cv=none; b=qeb8bso4LDWWsQ/zbEgF9kGPZlx791uZ+N5Cq/vkBn8xeYBi1XtiBm3glHOrPI6QCk8YnhnuH4jM2yJJcl3YiIg42d6NorEKpRKWJ7Moh5xvDzfSwZfpBY1DfyLPCSSC59GYLL0C3RAkC3quS/S+gKYE58NkzUEwcPo8HXYhg5I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784109385; c=relaxed/simple; bh=RVMpE/2zJngbP2l7dUgGImsnDYyJOJke9NWacK4SwV8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bBxhNtaBU6mNT5Z6j1RT9el/oQ1VtvUiWLNWDo/gIjoPpu99ZsZAP3yHrEGoV5pr5ss5BHPNyjOuNVd7C61wegW1DqxkgBW9cXPljaIbjG6dpQUL+CkVP+RzpAQysAcy8lx0UIZjW8xlNynmSTvTNFXsO0bbcGnEgJuj6u2mt14= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aL/1HYg9; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-c88a4d79ba5so3412506a12.2 for ; Wed, 15 Jul 2026 02:56:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784109384; x=1784714184; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=hMaB8cZfcOw4iICxwreQT8955W297Mz8pA/NoRorvZg=; b=aL/1HYg9QHiIEErPXG/6Do9k8k+xwjq6L6NPZELt/RbziJnhr24g7syfLr0IDGnA7z bbb04Uwd7E9kznF06IigO0niznXIgP9ZXw8fODSEHPbg4+1qvlyOfIavyKe2Mvs3kjoX K2/LzXhYf5Dq8irGhrgipk/evDwGopUDrh2o6Q+YLNuIW7Z34JUnN/zNA7aKNJ/l7LxE l0cWtXA20R23ugmyZNArNafyGiVbthDg4grabYCYwV1No4tTcJBD+GyJsFS6c6PHfk3D 4quJ3wgncbg7quAkNZ13VuW/iU1eoGaE4aayWD0UoAksXlAPrhFEH0zWxdzQST7HHcwk 64iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784109384; x=1784714184; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=hMaB8cZfcOw4iICxwreQT8955W297Mz8pA/NoRorvZg=; b=bKUxDwRVie24Z/sMfI6bqCEhKaYclFhYuimFQXagiS+F+g72f9BNuwUG+h+qCOtVpe IYpo1XZ5zsxaz33mUApKFhfSA9B4XiSTahMMVD9BFS8kQb8y8y3oDjEfeRd3Pi8sxLgx 9Uylx+vkL/oiHR4njNzF26h8xtueP78s8mjEI/qghXR97ysBkaGo712Ta86eXIv9aE8n vSkfUXn1qsVHVqmMNQV9nUmKZxVEU+rZNbc+PbhmPvv21MpEbc6LiyGZEyzt1vj9fLtT FvDEM2qt3ZHCQb0L+nu9DYnW7KrSvnSGvzmfIGST5I87IBgKl9sN6RadxDm1xLQvWo4t xp9g== X-Forwarded-Encrypted: i=1; AHgh+Rqow7JZQaW4plELNMFFdJBLNEqy5HGCgU1GnNiMmDDy9LHLQZh8rXfXn4JOkXAyYDeqlZ/UcCbx3IMSaQ==@lists.linux.dev X-Gm-Message-State: AOJu0Yxkglx7ctNgoAHnOBHNn8r3FnXK7a2n9BTgFkVdBC0j2yUfiMVe TRgajqP6Cytclk/sA8bqbKQugfSgIGY6d4geBngyY9+fO5hkTh1zTyZX X-Gm-Gg: AfdE7ck41AebPNrkYL46olt/ASCpQgmoJ3j/kzypYsZKGiF8jVL+wZEAVmQKAmcoBoT yje0gwBwq5Vb25rR8l3FoJRN13Ewz9urYurAQZBTATly7ExF9SI6gFYLzbo7yaTlUb4NPTbBhAF Bj95xakKhKrj9DSho3PVQoxYsy0XzUvWGJAXyJ0+W6PcaivFsR/hpiN5A84WC47JL8nMp9P7OyZ 1yfUQJrIcNsmaNttsmcyN7SwI6VtIhkpSiMefmilCegsHuIjCCMoSIXjFGtSBSAqzvnyHPG/zYq GCAQJ5DDak+Ezeo7IPocioxv4lmwWatbjVuKluWLotEingZFihrWLhpX4zxVNHhP+gjsBRjLLvk mjCOmuSE+3nAfdW5aX7rFbK8uTY6ZoqW5amm3RHRbvYeR3l9IP34+D1cn/5BnCP3H49j5/+rHKD +ydC+/0RtLaBJEQ7AgmaP1yQYcbEh9NKxr39JJC0RW8bUrjtA= X-Received: by 2002:a05:6a20:2584:b0:3c3:2e2b:29ef with SMTP id adf61e73a8af0-3c3575df9dfmr6494504637.51.1784109383732; Wed, 15 Jul 2026 02:56:23 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ca5b3643399sm11628908a12.22.2026.07.15.02.56.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 02:56:23 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai Cc: Jernej Skrabec , Samuel Holland , Charles Keepax , Kuninori Morimoto , Chen Ni , Marcus Cooper , Bjorn Helgaas , Danilo Krummrich , u.kleine-koenig@baylibre.com, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sound@vger.kernel.org, bui duc phuc Subject: [PATCH 6/6] ASoC: sunxi: sun8i-codec-analog: Improve probe error handling Date: Wed, 15 Jul 2026 16:55:25 +0700 Message-ID: <20260715095525.40668-7-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260715095525.40668-1-phucduc.bui@gmail.com> References: <20260715095525.40668-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Rspamd-Server: rspamd-worker-8404 X-Spamd-Result: default: False [-0.66 / 15.00]; BAYES_HAM(-5.50)[100.00%]; RBL_SENDERSCORE(2.00)[104.64.211.4:from]; SUSPICIOUS_RECIPS(1.50)[]; DMARC_POLICY_SOFTFAIL(1.00)[gmail.com : SPF not aligned (relaxed), No valid DKIM,none]; R_MISSING_CHARSET(0.50)[]; MAILLIST(-0.15)[generic]; MIME_GOOD(-0.10)[text/plain]; BAD_REP_POLICIES(0.10)[]; HAS_LIST_UNSUB(-0.01)[]; PRECEDENCE_BULK(0.00)[]; TAGGED_RCPT(0.00)[]; FREEMAIL_CC(0.00)[gmail.com,sholland.org,opensource.cirrus.com,renesas.com,iscas.ac.cn,google.com,kernel.org,baylibre.com,lists.linux.dev,vger.kernel.org,lists.infradead.org]; FORGED_SENDER_MAILLIST(0.00)[]; FROM_NO_DN(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCPT_COUNT_TWELVE(0.00)[19]; FROM_NEQ_ENVFROM(0.00)[phucducbui@gmail.com,linux-sunxi@lists.linux.dev]; ASN(0.00)[asn:63949, ipnet:104.64.192.0/19, country:SG]; R_SPF_ALLOW(0.00)[+ip4:104.64.211.4]; FREEMAIL_TO(0.00)[kernel.org,gmail.com,perex.cz,suse.com]; FREEMAIL_FROM(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; RCVD_COUNT_FIVE(0.00)[6]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; RCVD_TLS_LAST(0.00)[]; TAGGED_FROM(0.00)[bounces-24433-noreply=patchwork.local]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; ARC_ALLOW(0.00)[subspace.kernel.org:s=arc-20240116:i=1]; RCVD_VIA_SMTP_AUTH(0.00)[] X-Rspamd-Queue-Id: A17241C2C76 X-MORS-Enabled: yes X-MORS-DOMAIN: patchwork.local X-MORS-HOSTING: hosting172546 X-MORS-USER: hosting172546 X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= From: bui duc phuc Drop the redundant error message after devm_platform_ioremap_resource(), which already reports failures, and use dev_err_probe() for regmap initialization errors. Signed-off-by: bui duc phuc Reviewed-by: Chen-Yu Tsai --- sound/soc/sunxi/sun8i-codec-analog.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/sound/soc/sunxi/sun8i-codec-analog.c b/sound/soc/sunxi/sun8i-codec-analog.c index 2024e2b2553e..3335855c6311 100644 --- a/sound/soc/sunxi/sun8i-codec-analog.c +++ b/sound/soc/sunxi/sun8i-codec-analog.c @@ -822,16 +822,13 @@ static int sun8i_codec_analog_probe(struct platform_device *pdev) void __iomem *base; base = devm_platform_ioremap_resource(pdev, 0); - if (IS_ERR(base)) { - dev_err(&pdev->dev, "Failed to map the registers\n"); + if (IS_ERR(base)) return PTR_ERR(base); - } regmap = sun8i_adda_pr_regmap_init(&pdev->dev, base); - if (IS_ERR(regmap)) { - dev_err(&pdev->dev, "Failed to create regmap\n"); - return PTR_ERR(regmap); - } + if (IS_ERR(regmap)) + return dev_err_probe(&pdev->dev, PTR_ERR(regmap), + "Failed to create regmap\n"); return devm_snd_soc_register_component(&pdev->dev, &sun8i_codec_analog_cmpnt_drv,