From patchwork Tue Mar 24 18:26:49 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Atharv Dubey X-Patchwork-Id: 45 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 303413A16B0 for ; Tue, 24 Mar 2026 18:27:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376843; cv=none; b=MQxIaWpFbEPs+UebabCyg7b61qIBImFxKSMlIxeXuoHOzZZ3S+oz61Hb80XDKFubbpFW3y2TbZufYAf9EjxgLLB1pd3s/wRoL1lXbbcEm9oyEFC1nySZBjsyBC0RqEifNJOVmaG/L4sPnLwX37iTFsVC9AV/dvtoLdfqZh2SDas= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376843; c=relaxed/simple; bh=WceX/6ppqZ5DUDCGfEWL1pZY9tLdtFM/DeuPHESZPQg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=J3R47qlohky9aCmNtHEEm6QOH4nqe56v/KFRHiqroNXXHtrnhuFLkjBJBGOtrEfpyU1gRES01U69c6P4G6K82Cv8tfS+LEE73M4PMKozbgSBcRPCBZokMJTC0vzbNDoDICt3ELtVCOO3M3+GXmpP7k1NblvEarsM3ZF4a+OAgmM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NqShDOqR; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NqShDOqR" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-3585ec417f6so67967a91.1 for ; Tue, 24 Mar 2026 11:27:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774376841; x=1774981641; darn=lists.linux.dev; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=JU53ztXeIg9rAt/w2RhxQEA1HrNV+jGEvjmkGqWYdZA=; b=NqShDOqRvtrlvsWd3H2TIAdcm5nt8weh9rXl1S8D1RXRJtfQNPjD7ziuNUB8xFxjCz mX/XGWhUFmvko4k2AAAVzllTwbFMAsnoy++yBevFFXahyzolQLlEsNvFS5fnjIOf9qJk S6R1r0TUScXNvaMOpFf3ohG7OLTGOfxs4DwTRqYt0vaWhncYabikkyUpNOfT7Hk7NWOJ Kke/tKQmsrKRKUOWZXTsOoSmTbvTJxQIKaRAVLJNGB4TKmRT/1iECYGX5bqYTzBHa7x/ RwFMBwOnT1BntPd137N8tgGlwLNuy+HlhHp1FAdoL6+mQZGvZPjosM5S5YXDm43nfjq2 yPEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774376841; x=1774981641; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=JU53ztXeIg9rAt/w2RhxQEA1HrNV+jGEvjmkGqWYdZA=; b=KuSgwYAPQ0875ztoYXPy96yW1bKTZciCklmb4Yo5LQUQVlPAo6idrmGo0JKDHa02Wf 51DdU9q6pACnIMylHKP2KxRR2ExUmNm1l/bTC1bzxq8kUejXqlbSLrTrWuW0rZzpPdM4 Zb2JmxspI5cvRFkLIyDmDPk+td4lo7oFwuETrHP63Rw9gd52SjwM3FsjoT3LIEEl3zKe dcbIkhnH0lQNYvj0yTCtjsTxH1W/n00M3NvnaJw/8rTN5n/cFnnq7ASptBqThX1Lc1C5 FNWpsLXl723It07ngFFMEi9Eq3I5MqhPsbcKCU4gaZMhrjavDfu+QWISRQeTDaMWvEX2 j9gw== X-Forwarded-Encrypted: i=1; AJvYcCXVJb3lDNATK071ogRyfwVHIxjllHqnPKdi/mj+WJMHZyLqxYttIf5+RM8r9IHT8RDwW0/1hlVkxSNTzw==@lists.linux.dev X-Gm-Message-State: AOJu0YwyaQFR1Ut5j0bbc5c8uIgn1p7U3kJia9gOO18pc3tS0aT7D5hR s8BfRLG3r1YKRu7Tf2piZqlnr5AO65xxTrgvH/bONXDX4lQFWWdVdgNU X-Gm-Gg: ATEYQzwLpShHu277J52nVFHTP04FMMThCfyQb3bqkHUQW9WxNmcUV62zoUeINg+DaaC IDZaXqnatJ8jm4xgyaZ9RFDZCEn7eBdy4gQ4FirCFSU2goR26U0I4SY4VPi0QELJpvJ2VUkIe5s t/t+4f+A1UYi7i7Xxvr3Ouv4AF+XT0+MJh1b4nD+j5D9vdCIrgQCwUno1YQSYaxoxbgSmbAz/HD 6l9ssB25in5otHNNlNVww1nmD+GB4kdj3/hTa7d+7TLLKnzctNS5hBGsDorfABBN53ZwyFw6lOO 8i0Z4WTMkbO5v6RWU2ce0z6Q7kyHkNJIQPgLy5thP2TH4rzZyAWIVFYYKq260pTNKyqQUwp3z89 MfBsG+W6P0FE5zajiE4nvqxm1uAmL8gTQvZojtH67htEEXJiPU/8Dk6FmYNAwbpxiVG3o7Ork2Z qiCoTKy1+9GOF9b/aeGu7g/lVpLg== X-Received: by 2002:a17:90b:57e3:b0:34a:be93:72ee with SMTP id 98e67ed59e1d1-35c0d1451d7mr559615a91.8.1774376841343; Tue, 24 Mar 2026 11:27:21 -0700 (PDT) Received: from [127.0.1.1] ([103.216.213.160]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c0d6060b5sm350576a91.17.2026.03.24.11.27.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 11:27:20 -0700 (PDT) From: Atharv Dubey Date: Tue, 24 Mar 2026 23:56:49 +0530 Subject: [PATCH 01/10] i2c: tiny-usb: Replace dev_err() with dev_err_probe() in probe function Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20260324-deverr-v1-1-7e591cce33a3@gmail.com> References: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> In-Reply-To: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> To: Till Harbaum , Andi Shyti , Laxman Dewangan , Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Pierre-Yves MORDRET , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Patrice Chotard , Orson Zhai , Baolin Wang , Chunyan Zhang , Jean Delvare Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, Enrico Zanda , Atharv Dubey X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774376818; l=922; i=atharvd440@gmail.com; s=20260314; h=from:subject:message-id; bh=/rm2EO54Io9Vb7rL8ZSyeOBixCamQEqxJe9F/gCdBcU=; b=ndfdbjfGLfy7wqu+RVI89cU1BdFSOOxdC43vbHuPhEqbITAhbeTXofEpCDO4hCGofdSsBz5rg /eaMZdocnKzBw4U70BqYrFGGqU2cbJzMF6jNMLwPSl+hIPTFUD50Y/N X-Developer-Key: i=atharvd440@gmail.com; a=ed25519; pk=T6i1xWOKT/RUSDYATSgyVG/4X7ac8jPjRSG1mMAcqVk= Status: O From: Enrico Zanda This simplifies the code while improving log. Signed-off-by: Enrico Zanda Signed-off-by: Atharv Dubey --- drivers/i2c/busses/i2c-tiny-usb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-tiny-usb.c b/drivers/i2c/busses/i2c-tiny-usb.c index 9ef495f88ef2..0637c71126f9 100644 --- a/drivers/i2c/busses/i2c-tiny-usb.c +++ b/drivers/i2c/busses/i2c-tiny-usb.c @@ -260,9 +260,8 @@ static int i2c_tiny_usb_probe(struct usb_interface *interface, dev->usb_dev->bus->busnum, dev->usb_dev->devnum); if (usb_write(&dev->adapter, CMD_SET_DELAY, delay, 0, NULL, 0) != 0) { - dev_err(&dev->adapter.dev, - "failure setting delay to %dus\n", delay); - retval = -EIO; + retval = dev_err_probe(&dev->adapter.dev, -EIO, + "failure setting delay to %dus\n", delay); goto error; } From patchwork Tue Mar 24 18:26:50 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Atharv Dubey X-Patchwork-Id: 44 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86B883A16B0 for ; Tue, 24 Mar 2026 18:27:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376853; cv=none; b=HkEsaLiJAhvtmCFnj93K8s8FEAJESoJvO9V/vtUtxNkNhPM6P7lwVKt3fZx1c4hfzyhVQE9xypZsQej4f29zczGrC/9Yg9X9/XaaknsGHGiaoL7AELOFA6S9aQdGmqHHmUagkBDqLlwsSxotBjmBeYpxqc3xUU9nVBV5aKGFAlE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376853; c=relaxed/simple; bh=+c/3pLSCjN8W96sioUUAyB3Q4h2iU9EyKqZsQlwSrmM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uIaRuCDmICXS8P1G5WmkAOmEjdozIeQHVX5tZXe/XUsgzkEO3om1aNrMoCT3yL30sz84gRcCf92pYtFlYSDsPjl0N7aPpUpsMzBGTBjm/beCE8+RyHr5LisVl9XXB5c/XJGUH4d1vArUXi19aZLtQpwj8Nwv6mA6pJtFxouYZoU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lural8ap; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lural8ap" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-35b9fb3f57eso781267a91.2 for ; Tue, 24 Mar 2026 11:27:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774376852; x=1774981652; darn=lists.linux.dev; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=9Gsg2Xtdfdl+8IY6r0o/RyYDfTlBlRsSZJpA/oULFGs=; b=lural8ap04wP5P4y+S8kzlLGpC4m1dae8I02w1/1zIuhfJ9JPFsLVcN8ABTkrzDmhK Qp7WMFpoqag6BKI2gR47ZtcE+DQlpzgwppz5wo+WXtYW6Q8MsCv0sym6QfGtsxWFFxzH eXnpa+fxjKbJa9bwZO2HRHnskbwuMjSKN0hnBkxZHw6QvVxn9hmddONyebN9y8y3xb8y d167QymVHb1uIAB6m/qjYTaZxjLHnEPgCx7VXkYzm0DwvrpLT/1BqM+3DnWSCtqDYo5+ Sd2TrsaWKq3dX5nyF887YqFjPISy04DrkrrnG827XdOzR6xO+i6bZ06MHUXjrOSjr2ld 04VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774376852; x=1774981652; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=9Gsg2Xtdfdl+8IY6r0o/RyYDfTlBlRsSZJpA/oULFGs=; b=apsy+SH5SQ3NjSLhx+wHwOwHaDzfK1eOXJkKNYYfDnhErSAIcLF8k5XC4Iz67I0mye JqUcqie07IGeoY4jxnmODPbEsG/kgi3H/WSLzMZo/ss9XEDnMHBmjYzfaXJn1L4Fh34/ bqCY8GpRo+76VcxYi/WGdVwHoCHwwrX1LcCwolgdPsFYIOrCuJQbxdrxJKtlYYCPrmXz bIQTsOM6xRv7MnSWG1T2LSqcqSewIZzmk3qpRyngVLnlPGA4ErJRRcPobU4MbL56FS+D 6c0wn8akc0lVxB2djHBLHGLWnC5546dccbqMJpRDXNuT2zHWMFYTr39ZNWndEKTsOgyH Fo/A== X-Forwarded-Encrypted: i=1; AJvYcCWKmIfElhdTLjfa3Ojmexn5ARiu3qDZ0o0mruODtsBfEiZhvAMe/W1tN9+rQobfNDC9vPeQHhCf3lzCEA==@lists.linux.dev X-Gm-Message-State: AOJu0Yxr8/t+NUFvgseTRTkGv6aYwfr783leUPM+rQj8B0FfxRN5Y23l SClPBYDj5pBTSuJ64WPqAKHdljCCxy9dbZQDMcq9tQLR13kx2k0p+sx5 X-Gm-Gg: ATEYQzxMKs/q+hKlVWn+aI9CLAj5tTWyr9nDYnC2kFqQtT+xPEuUb2lwy6YfsTwDipF u7pQJW/KPpfKIt0OcR8F9O97ytGTvI+fjexq2yN3vCmZ95EXtE6mXA/F9OLvs2Z8povabLBMEao m7ehIo3HmMv89tOvekWySbIay1rOtUGRY7FbulcP6c3l5w0zCjxJxTNAgLR4eSJRBcT5HBD1awk WArxLXfI/ZHKHq5VnCLDlnO6FRYP9jgybQeP+nedMqh1RvO9v282yK07PctJW0LPUGPHl5Ydybh sQW24FK/TKvkq6+p0T/KXv/5gxuL8hzQJmDizzsAjqZBRP9UQVi8QXhxXeUwv9QacPP+WbvIgox yPc5uNjbCG+XrJcs3JA8V71ybu2NLb1+pAmURcFEZ70Q0xedqe+IcLV7wUvB+H5rUfyllXeAOwD 6oJTg8jjLr0yd87X77z82bWLtifSnJ51oLuuXr X-Received: by 2002:a17:90b:17c8:b0:35b:e591:99d1 with SMTP id 98e67ed59e1d1-35c0ddc4118mr351953a91.29.1774376851910; Tue, 24 Mar 2026 11:27:31 -0700 (PDT) Received: from [127.0.1.1] ([103.216.213.160]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c0d6060b5sm350576a91.17.2026.03.24.11.27.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 11:27:31 -0700 (PDT) From: Atharv Dubey Date: Tue, 24 Mar 2026 23:56:50 +0530 Subject: [PATCH 02/10] i2c: tegra: Replace dev_err() with dev_err_probe() in probe function Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20260324-deverr-v1-2-7e591cce33a3@gmail.com> References: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> In-Reply-To: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> To: Till Harbaum , Andi Shyti , Laxman Dewangan , Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Pierre-Yves MORDRET , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Patrice Chotard , Orson Zhai , Baolin Wang , Chunyan Zhang , Jean Delvare Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, Enrico Zanda , Atharv Dubey X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774376818; l=1910; i=atharvd440@gmail.com; s=20260314; h=from:subject:message-id; bh=T//TFybKN0iS3J929ONSQMLq+NVtMUv+4U4PajSEtpE=; b=fr2E/ILXide+l6/sGLPzjFEjto2BGT6qqnz9x0FPbuW7SDMBkCcBooGAF0nF3tgg5wQpoDzh0 nAnDJBBoQYcAomrkw15oBfCFd8unXKN1lYuv+oiXhwJuhidayGEmEVJ X-Developer-Key: i=atharvd440@gmail.com; a=ed25519; pk=T6i1xWOKT/RUSDYATSgyVG/4X7ac8jPjRSG1mMAcqVk= Status: O From: Enrico Zanda This simplifies the code while improving log. Signed-off-by: Enrico Zanda Signed-off-by: Atharv Dubey --- drivers/i2c/busses/i2c-tegra.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index bec619b9af4e..51d15fca82fc 100644 --- a/drivers/i2c/busses/i2c-tegra.c +++ b/drivers/i2c/busses/i2c-tegra.c @@ -575,8 +575,8 @@ static int tegra_i2c_init_dma(struct tegra_i2c_dev *i2c_dev) dma_buf = dma_alloc_coherent(i2c_dev->dma_dev, i2c_dev->dma_buf_size, &dma_phys, GFP_KERNEL | __GFP_NOWARN); if (!dma_buf) { - dev_err(i2c_dev->dev, "failed to allocate DMA buffer\n"); - err = -ENOMEM; + err = dev_err_probe(i2c_dev->dev, -ENOMEM, + "failed to allocate DMA buffer\n"); goto err_out; } @@ -588,8 +588,8 @@ static int tegra_i2c_init_dma(struct tegra_i2c_dev *i2c_dev) err_out: tegra_i2c_release_dma(i2c_dev); if (err != -EPROBE_DEFER) { - dev_err(i2c_dev->dev, "cannot use DMA: %d\n", err); - dev_err(i2c_dev->dev, "falling back to PIO\n"); + dev_err_probe(i2c_dev->dev, err, + "cannot use DMA, falling back to PIO\n"); return 0; } @@ -1953,7 +1953,7 @@ static int tegra_i2c_init_clocks(struct tegra_i2c_dev *i2c_dev) err = clk_enable(i2c_dev->div_clk); if (err) { - dev_err(i2c_dev->dev, "failed to enable div-clk: %d\n", err); + dev_err_probe(i2c_dev->dev, err, "failed to enable div-clk\n"); goto unprepare_clocks; } @@ -1979,7 +1979,7 @@ static int tegra_i2c_init_hardware(struct tegra_i2c_dev *i2c_dev) ret = pm_runtime_get_sync(i2c_dev->dev); if (ret < 0) - dev_err(i2c_dev->dev, "runtime resume failed: %d\n", ret); + dev_err_probe(i2c_dev->dev, ret, "runtime resume failed\n"); else ret = tegra_i2c_init(i2c_dev); From patchwork Tue Mar 24 18:26:51 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Atharv Dubey X-Patchwork-Id: 43 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A83AE3A381C for ; Tue, 24 Mar 2026 18:27:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376864; cv=none; b=JV0F1K162QsFUSBjs5952erzupzZjJFL+TCd2ARqzIFaFCg7vWdU9sUHn+csbR00VWPksJeZWLw0OdrfaHnf+9+t0v8eUQJ3eIcS5VQqqW2ikM3TQEZeH1eA22SrgpnRuebIXiriAqNG2gU14iOFxFu7WUHTa9u+JN1ChxhASfA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376864; c=relaxed/simple; bh=Gi4d0M5a+5Q4+n74Mmna9wNg+TAzJTOOC5zaGKNgvh0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bx5oLbupNY1OOVz0w6OLh9NO/WQTwsm2hLNkI48hZzH7hDRo+sYyUiRIGZVxvAARcMZzkGWH3O3UREWsoKEozsxdc+bwMXBTrpc7PRDy7jbejcHf6ZjnLn6eNZRhQUNtBaUxYpUWIIPBrNrX4g2sUUkbFYUGEoHa5FzVSElD9IY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IJqcb0Gc; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IJqcb0Gc" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-35b95e21ccaso84321a91.0 for ; Tue, 24 Mar 2026 11:27:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774376861; x=1774981661; darn=lists.linux.dev; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=alJwQhTp7nkw0Ib79edmwantLXplbDvUqq4BVXNADKE=; b=IJqcb0Gcp3tHbwFUT52oLR9c1l7kJL076j7j3M4wYgtqF0TlpHA/pwNkUioO/UAhlx byRgEe73Zo0evykvMUoCkTF9yBJT3GZc3Ju7xm/+bHZEawRr/w41oXHsGxvqc6o77Ocp qS1uWcdmTQ/wiTJTKr+XCRXQdhbOVqRJWUDDJQ9+p+Wp/6+PxUwtHtCLd+CkasHDxcyk +q794D8C2AkRMtojT2d2WhSEF16GPkissWjobCN8Gn78/jkrtogq3q2kuJ/iwWsQ3RAU U08rj2CBqBjfFXpRqXN6BMBwkO8JTa7jklfAr+Q/lR2xiFrtvcE7tnxqZmM+ds8g3If2 juTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774376861; x=1774981661; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=alJwQhTp7nkw0Ib79edmwantLXplbDvUqq4BVXNADKE=; b=gAX/kVIt5BqKnUmweR/8fRiwT1+xUfGG+pI+iEAB/iluaTchLjUcbVYE+vVCb64li7 IwSR25vtixVY7B1UWR969l+Mmo8p6bQx3lezBQt67evIuTP7V20hiWJBIktAi1MObvf7 youX3u6T4n8aTaqborV7Ok0VLrVaAaui66p3oPbpy52ymT1MpVQ3q3c/D7vnn2PWQoYo HVsyHZ2gbbaZyV169wS7KlsoDdDlOdsZYft/Wd9SfzV8FQ2AT8+orUw+QkCmFFKCfbrX s87U+Z4uPZvAKSbB5IGFOeQAdF8UlrDEkAjYjl6QJ8hA17Z5w1/OKaSoxFU4UeitqBk2 P4DA== X-Forwarded-Encrypted: i=1; AJvYcCXG3uyN49Juf4cEJCtnpSNqATqv/tJPe4YHZLsR6kEgem7Pb7uM8XC2i+VahtribHmbJONVdFmm/ZA2uQ==@lists.linux.dev X-Gm-Message-State: AOJu0Yx0uoukMIFKnygnF+rOtJf0FzGQy6ZtxbwI5DBsYjdWReoMmVKF oYn2I+snNOkyGx7wWz7JHny43HySXonlluUhcOS3nkPDH6TnxvA/QXIL X-Gm-Gg: ATEYQzwHI9wqYR5g6P26++mqEJjS54SzNAwpKK5JhvHnJQWeT0hFdfSNcz7bss9b87m vbAr/pJ6DCrYjofjvdZ47zOJGqcCtrd25jvjdW3uTnMZ8vqKxwQe1OnUVWWwH51j09x4FR+psfo /9nSWc/VLOn7IdoMyCMNZWpNVo+Oi0QSaV/JdZt7Fx7IieKjPrAYythL/w1OpPufsjpoy2ZE2oI bO6dHrHMIEPG9dA6VHrZX4Oa01TDFBI4SOaITrGOf21JvisXOMNuhc75LXD6sOp+YuFdJaUP22F f8L1hYrIWx5GXNo/axGK424afbggRTJWFucO/4LIqxcSSv0WYgIKUG8mip/vLfsqU3qkzG948JW yhHLFSWdfmLLOOUUE37x/pSH3Zs/PXPqbmTroTpmxd/vF9jtmcwCnB2Ue+NFcO72UtbnS5Jqg9F QWbZR7GVboIY0FDkkj4FDfcnkQqw== X-Received: by 2002:a17:90b:57c4:b0:35b:9703:7664 with SMTP id 98e67ed59e1d1-35c008d38f1mr4197956a91.10.1774376860812; Tue, 24 Mar 2026 11:27:40 -0700 (PDT) Received: from [127.0.1.1] ([103.216.213.160]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c0d6060b5sm350576a91.17.2026.03.24.11.27.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 11:27:40 -0700 (PDT) From: Atharv Dubey Date: Tue, 24 Mar 2026 23:56:51 +0530 Subject: [PATCH 03/10] i2c: sun6i-p2wi: Replace dev_err() with dev_err_probe() in probe function Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20260324-deverr-v1-3-7e591cce33a3@gmail.com> References: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> In-Reply-To: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> To: Till Harbaum , Andi Shyti , Laxman Dewangan , Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Pierre-Yves MORDRET , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Patrice Chotard , Orson Zhai , Baolin Wang , Chunyan Zhang , Jean Delvare Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, Enrico Zanda , Atharv Dubey X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774376818; l=3450; i=atharvd440@gmail.com; s=20260314; h=from:subject:message-id; bh=mGoeA4RoMr6oMafJS8Wz9uEiYGmdoZGvaadkVl07Ac4=; b=mqDXFTn7P7YKfYZq5yfTqBReywbYSNkXTrDiQ10Gxn0U4N3AcD22e4px2/bKmxQtkFRLFhMV5 D6Rwa2VObbECiZHEiSRVGIVnkT5nDLR0wDkwvKuXdMmJb12BQQQ/qlI X-Developer-Key: i=atharvd440@gmail.com; a=ed25519; pk=T6i1xWOKT/RUSDYATSgyVG/4X7ac8jPjRSG1mMAcqVk= Status: O From: Enrico Zanda This simplifies the code while improving log. Signed-off-by: Enrico Zanda Signed-off-by: Atharv Dubey Reviewed-by: Chen-Yu Tsai --- drivers/i2c/busses/i2c-sun6i-p2wi.c | 55 ++++++++++++++----------------------- 1 file changed, 20 insertions(+), 35 deletions(-) diff --git a/drivers/i2c/busses/i2c-sun6i-p2wi.c b/drivers/i2c/busses/i2c-sun6i-p2wi.c index fb5280b8cf7f..dffbe776a195 100644 --- a/drivers/i2c/busses/i2c-sun6i-p2wi.c +++ b/drivers/i2c/busses/i2c-sun6i-p2wi.c @@ -194,22 +194,16 @@ static int p2wi_probe(struct platform_device *pdev) int ret; of_property_read_u32(np, "clock-frequency", &clk_freq); - if (clk_freq > P2WI_MAX_FREQ) { - dev_err(dev, - "required clock-frequency (%u Hz) is too high (max = 6MHz)", - clk_freq); - return -EINVAL; - } + if (clk_freq > P2WI_MAX_FREQ) + return dev_err_probe(dev, -EINVAL, + "required clock-frequency (%u Hz) is too high (max = 6MHz)", + clk_freq); - if (clk_freq == 0) { - dev_err(dev, "clock-frequency is set to 0 in DT\n"); - return -EINVAL; - } + if (clk_freq == 0) + return dev_err_probe(dev, -EINVAL, "clock-frequency is set to 0 in DT\n"); - if (of_get_child_count(np) > 1) { - dev_err(dev, "P2WI only supports one target device\n"); - return -EINVAL; - } + if (of_get_child_count(np) > 1) + return dev_err_probe(dev, -EINVAL, "P2WI only supports one target device\n"); p2wi = devm_kzalloc(dev, sizeof(struct p2wi), GFP_KERNEL); if (!p2wi) @@ -226,11 +220,9 @@ static int p2wi_probe(struct platform_device *pdev) childnp = of_get_next_available_child(np, NULL); if (childnp) { ret = of_property_read_u32(childnp, "reg", &target_addr); - if (ret) { - dev_err(dev, "invalid target address on node %pOF\n", - childnp); - return -EINVAL; - } + if (ret) + return dev_err_probe(dev, -EINVAL, + "invalid target address on node %pOF\n", childnp); p2wi->target_addr = target_addr; } @@ -245,26 +237,20 @@ static int p2wi_probe(struct platform_device *pdev) return irq; p2wi->clk = devm_clk_get_enabled(dev, NULL); - if (IS_ERR(p2wi->clk)) { - ret = PTR_ERR(p2wi->clk); - dev_err(dev, "failed to enable clk: %d\n", ret); - return ret; - } + if (IS_ERR(p2wi->clk)) + return dev_err_probe(dev, PTR_ERR(p2wi->clk), + "failed to enable clk\n"); parent_clk_freq = clk_get_rate(p2wi->clk); p2wi->rstc = devm_reset_control_get_exclusive(dev, NULL); - if (IS_ERR(p2wi->rstc)) { - dev_err(dev, "failed to retrieve reset controller: %pe\n", - p2wi->rstc); - return PTR_ERR(p2wi->rstc); - } + if (IS_ERR(p2wi->rstc)) + return dev_err_probe(dev, PTR_ERR(p2wi->rstc), + "failed to retrieve reset controller\n"); ret = reset_control_deassert(p2wi->rstc); - if (ret) { - dev_err(dev, "failed to deassert reset line: %d\n", ret); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "failed to deassert reset line\n"); init_completion(&p2wi->complete); p2wi->adapter.dev.parent = dev; @@ -276,8 +262,7 @@ static int p2wi_probe(struct platform_device *pdev) ret = devm_request_irq(dev, irq, p2wi_interrupt, 0, pdev->name, p2wi); if (ret) { - dev_err(dev, "can't register interrupt handler irq%d: %d\n", - irq, ret); + dev_err_probe(dev, ret, "can't register interrupt handler irq%d\n", irq); goto err_reset_assert; } From patchwork Tue Mar 24 18:26:52 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Atharv Dubey X-Patchwork-Id: 42 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFA881E5B88 for ; Tue, 24 Mar 2026 18:27:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376871; cv=none; b=h9Hyl1CRIVYqghLu3WY+oQWWpkQEcZAjYVQ/oPJjsLllEaKxY0jzqsKk4Q/2yPVGexb6OSqn8ZchK5JsMJpL1C1Zs0dw5zGtyw7wPH9UlY0NrohfnsvmNZ0KL+/rb2y3jPcqSdpjRBkxrL+sph4Af6YFDXmP+ecrb5LYykE0icM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376871; c=relaxed/simple; bh=INy7r9nqYAh8xRryTtp2F3L3u24eOCBCoOZXV2Ktc3E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=O04Ufd66178xn3svLWMUgYt07c7V9Uljc/XtsZy3n57I20NzGT/qZ84/1BZDJ4JTwCkZMP0X6yQUclf4dP5agf+lJats+P0pFW33neKOqaLUupoeT9uVkctPxtAGKjcRZKaK6uvSESMj3/vlom01pVQ0ZB8mvyUt1Dqs184TT2c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mUJjIldV; arc=none smtp.client-ip=209.85.215.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mUJjIldV" Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-c7358a7a8d1so941363a12.3 for ; Tue, 24 Mar 2026 11:27:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774376870; x=1774981670; darn=lists.linux.dev; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=YOUVvE5FNmjkaySdFPrc+7+hSpPNsoY2HaGuj8AkFfI=; b=mUJjIldVN5AKK7KhJV0hY9Z5CufoomuWXkkV5VfLBkurmPyaFGm0GGvJeAa+rNamrb uLshf453p5slIcSPGRDtxkWmWMOr1WrHVjhCtzx0A2IShlVJyUPe77yjFMnrKRLdn2Sr ogRuc7fqdl/DzwztrwJHJ+mP2RtYnStgqN+bWay+qi9DvSr2XtWdbTXGquTazdUS4nxS s5ihmCOmqD4ABu5hFv5wl8Eg3SurrCb1glyFPEi4zQX4oGMtbj62DlvClR2fe+HDOdvk XleNSF/7dgzjp96XTtS6mZQuGEcgZykWRC6eQ1Xdar/HeeHoqWsOVy2TOCPTPTmbrKvJ BUng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774376870; x=1774981670; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=YOUVvE5FNmjkaySdFPrc+7+hSpPNsoY2HaGuj8AkFfI=; b=lWO/bmdvNfc+N22nYNU47190ZO8aib/kwBZ7LUvOoUWNepQXrHfsGN3mF815EsfNUC 5qkQgUVE/iEdchJv14UaKliZCbf+FNM59xwsXrULcWL81xHX1PjhQMc3nXeudXE4nxAK 3bsClOFXykZAcfZhH2MgYDwGAupFaWanVnfe5wnp+LGrHFudEPpgqOxd5KVnQ9L1QodD BJhuzouYMJSAbdL8YmNI8GBmg/OOUEGZHO0Lw5Znx3DzzK93+Yd7knkmVaThavGPMNcM RUuqfTt1csrLsnK6kadw0uuLQdc4nKZjWXKwYTyOV2qA2M6Gr3dzDs20lkzbOGc0thhr M2ig== X-Forwarded-Encrypted: i=1; AJvYcCVwwq58W+Ud15lY1fa/uO0ijkVzXYKDlxPxqziuXaveKHuaIxFvOz/oOhh9yzUNDjmltXp8BI+7aYaXRQ==@lists.linux.dev X-Gm-Message-State: AOJu0YztEV5p8Ki2ePpmU9Jx7cICTFyzX6GS4b7NCnE3QwJpAeJIQtQD +nFeWz899yvpbk3Quuv/4w3vET9ve24nAxr62GkhcKZZ2QtIT5XfYJhT X-Gm-Gg: ATEYQzwS0SKNijm8jsMgETMSqYqIRGCHzYeMwfIrX2+2Q+QHdHv4IhZ4a6vODLuX3z0 gN5AC8m21osoQYqxDzvHLhhSrsoQ+R4rogP/Uea2zzq4+6FT423CDpf7paG/0gsAxDJVQFeHoa8 RgmZcOPoWJed9GcvQugr52M/Q7qRqY43btLs42MHb9cYTEocvetHtOqtNE1T8+OZ//XZ7LYuHij dRztWCLSF+B4+vmVHt4hIMuTSqMRuWdy/XmRsKu15togUCoraU2N/Hdkhuk5dMJGbNT8jW3JiPH z7zfZu7CRnRPBY5LuRGHDGNbuKnUb2EF8xRl2l78PfX5AJzWcuRslwXsExjo79GgzdgkakQNENn AhScZE8WGeq5GuPhMZeGTxdhUBUjS04Ar83d8KGkIcsD9uwSVCsdex3Rj5VJoEqMEFndEHnuU+M sNNTk5/Aw5QDFBPOacBY94uVVDoQ69qNCQ9ktC X-Received: by 2002:a17:90b:1dcd:b0:35b:a656:a60a with SMTP id 98e67ed59e1d1-35c0dcf48dbmr341601a91.8.1774376869963; Tue, 24 Mar 2026 11:27:49 -0700 (PDT) Received: from [127.0.1.1] ([103.216.213.160]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c0d6060b5sm350576a91.17.2026.03.24.11.27.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 11:27:49 -0700 (PDT) From: Atharv Dubey Date: Tue, 24 Mar 2026 23:56:52 +0530 Subject: [PATCH 04/10] i2c: stm32f7: Replace dev_err() with dev_err_probe() in probe function Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20260324-deverr-v1-4-7e591cce33a3@gmail.com> References: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> In-Reply-To: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> To: Till Harbaum , Andi Shyti , Laxman Dewangan , Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Pierre-Yves MORDRET , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Patrice Chotard , Orson Zhai , Baolin Wang , Chunyan Zhang , Jean Delvare Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, Enrico Zanda , Atharv Dubey X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774376818; l=6197; i=atharvd440@gmail.com; s=20260314; h=from:subject:message-id; bh=s9JDU7GcgsnDDFXsrCxagGOfCSdKXg3wGsXTsgZz2H0=; b=ah0pTzAjwcV8FwCOGin97Y4dMl89Nw1GTUGKElGrgDchfwSWIGhdZL4fJM5yOH/LB2Vze2ERu 5pFUk9n36AADxerpZp4V7L4H+yM/I6gEVGRW6UOTZNuNCinHlE0yV/c X-Developer-Key: i=atharvd440@gmail.com; a=ed25519; pk=T6i1xWOKT/RUSDYATSgyVG/4X7ac8jPjRSG1mMAcqVk= Status: O From: Enrico Zanda This simplifies the code while improving log. Signed-off-by: Enrico Zanda Signed-off-by: Atharv Dubey --- drivers/i2c/busses/i2c-stm32f7.c | 78 ++++++++++++++++------------------------ 1 file changed, 30 insertions(+), 48 deletions(-) diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c index 70cb5822bf17..e7cc7f0fb56c 100644 --- a/drivers/i2c/busses/i2c-stm32f7.c +++ b/drivers/i2c/busses/i2c-stm32f7.c @@ -481,28 +481,22 @@ static int stm32f7_i2c_compute_timing(struct stm32f7_i2c_dev *i2c_dev, int ret = 0; specs = stm32f7_get_specs(setup->speed_freq); - if (specs == ERR_PTR(-EINVAL)) { - dev_err(i2c_dev->dev, "speed out of bound {%d}\n", - setup->speed_freq); - return -EINVAL; - } + if (specs == ERR_PTR(-EINVAL)) + return dev_err_probe(i2c_dev->dev, -EINVAL, "speed out of bound {%d}\n", + setup->speed_freq); if ((setup->rise_time > specs->rise_max) || - (setup->fall_time > specs->fall_max)) { - dev_err(i2c_dev->dev, - "timings out of bound Rise{%d>%d}/Fall{%d>%d}\n", - setup->rise_time, specs->rise_max, - setup->fall_time, specs->fall_max); - return -EINVAL; - } + (setup->fall_time > specs->fall_max)) + return dev_err_probe(i2c_dev->dev, -EINVAL, + "timings out of bound Rise{%d>%d}/Fall{%d>%d}\n", + setup->rise_time, specs->rise_max, + setup->fall_time, specs->fall_max); i2c_dev->dnf = DIV_ROUND_CLOSEST(i2c_dev->dnf_dt, i2cclk); - if (i2c_dev->dnf > STM32F7_I2C_DNF_MAX) { - dev_err(i2c_dev->dev, - "DNF out of bound %d/%d\n", - i2c_dev->dnf * i2cclk, STM32F7_I2C_DNF_MAX * i2cclk); - return -EINVAL; - } + if (i2c_dev->dnf > STM32F7_I2C_DNF_MAX) + return dev_err_probe(i2c_dev->dev, -EINVAL, + "DNF out of bound %d/%d\n", i2c_dev->dnf * i2cclk, + STM32F7_I2C_DNF_MAX * i2cclk); /* Analog and Digital Filters */ af_delay_min = @@ -567,8 +561,7 @@ static int stm32f7_i2c_compute_timing(struct stm32f7_i2c_dev *i2c_dev, } if (list_empty(&solutions)) { - dev_err(i2c_dev->dev, "no Prescaler solution\n"); - ret = -EPERM; + ret = dev_err_probe(i2c_dev->dev, -EPERM, "no Prescaler solution\n"); goto exit; } @@ -624,8 +617,7 @@ static int stm32f7_i2c_compute_timing(struct stm32f7_i2c_dev *i2c_dev, } if (!s) { - dev_err(i2c_dev->dev, "no solution at all\n"); - ret = -EPERM; + ret = dev_err_probe(i2c_dev->dev, -EPERM, "no solution at all\n"); goto exit; } @@ -674,11 +666,9 @@ static int stm32f7_i2c_setup_timing(struct stm32f7_i2c_dev *i2c_dev, i2c_parse_fw_timings(i2c_dev->dev, t, false); - if (t->bus_freq_hz > I2C_MAX_FAST_MODE_PLUS_FREQ) { - dev_err(i2c_dev->dev, "Invalid bus speed (%i>%i)\n", - t->bus_freq_hz, I2C_MAX_FAST_MODE_PLUS_FREQ); - return -EINVAL; - } + if (t->bus_freq_hz > I2C_MAX_FAST_MODE_PLUS_FREQ) + return dev_err_probe(i2c_dev->dev, -EINVAL, "Invalid bus speed (%i>%i)\n", + t->bus_freq_hz, I2C_MAX_FAST_MODE_PLUS_FREQ); setup->speed_freq = t->bus_freq_hz; i2c_dev->setup.rise_time = t->scl_rise_ns; @@ -686,10 +676,8 @@ static int stm32f7_i2c_setup_timing(struct stm32f7_i2c_dev *i2c_dev, i2c_dev->dnf_dt = t->digital_filter_width_ns; setup->clock_src = clk_get_rate(i2c_dev->clk); - if (!setup->clock_src) { - dev_err(i2c_dev->dev, "clock rate is 0\n"); - return -EINVAL; - } + if (!setup->clock_src) + return dev_err_probe(i2c_dev->dev, -EINVAL, "clock rate is 0\n"); if (!of_property_read_bool(i2c_dev->dev->of_node, "i2c-digital-filter")) i2c_dev->dnf_dt = STM32F7_I2C_DNF_DEFAULT; @@ -698,8 +686,8 @@ static int stm32f7_i2c_setup_timing(struct stm32f7_i2c_dev *i2c_dev, ret = stm32f7_i2c_compute_timing(i2c_dev, setup, &i2c_dev->timing); if (ret) { - dev_err(i2c_dev->dev, - "failed to compute I2C timings.\n"); + dev_err_probe(i2c_dev->dev, ret, + "failed to compute I2C timings.\n"); if (setup->speed_freq <= I2C_MAX_STANDARD_MODE_FREQ) break; setup->speed_freq = @@ -710,10 +698,8 @@ static int stm32f7_i2c_setup_timing(struct stm32f7_i2c_dev *i2c_dev, } } while (ret); - if (ret) { - dev_err(i2c_dev->dev, "Impossible to compute I2C timings.\n"); - return ret; - } + if (ret) + return dev_err_probe(i2c_dev->dev, ret, "Impossible to compute I2C timings.\n"); i2c_dev->analog_filter = of_property_read_bool(i2c_dev->dev->of_node, "i2c-analog-filter"); @@ -2175,10 +2161,8 @@ static int stm32f7_i2c_probe(struct platform_device *pdev) return -ENOMEM; setup = of_device_get_match_data(&pdev->dev); - if (!setup) { - dev_err(&pdev->dev, "Can't get device data\n"); - return -ENODEV; - } + if (!setup) + return dev_err_probe(&pdev->dev, -ENODEV, "Can't get device data\n"); i2c_dev->setup = *setup; i2c_dev->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res); @@ -2279,7 +2263,7 @@ static int stm32f7_i2c_probe(struct platform_device *pdev) ret = dev_pm_set_wake_irq(i2c_dev->dev, irq_event); if (ret) { - dev_err(i2c_dev->dev, "Failed to set wake up irq\n"); + dev_err_probe(i2c_dev->dev, ret, "Failed to set wake up irq\n"); goto clr_wakeup_capable; } } @@ -2305,9 +2289,8 @@ static int stm32f7_i2c_probe(struct platform_device *pdev) if (i2c_dev->smbus_mode) { ret = stm32f7_i2c_enable_smbus_host(i2c_dev); if (ret) { - dev_err(i2c_dev->dev, - "failed to enable SMBus Host-Notify protocol (%d)\n", - ret); + dev_err_probe(i2c_dev->dev, ret, + "failed to enable SMBus Host-Notify protocol\n"); goto i2c_adapter_remove; } } @@ -2315,9 +2298,8 @@ static int stm32f7_i2c_probe(struct platform_device *pdev) if (of_property_read_bool(pdev->dev.of_node, "smbus-alert")) { ret = stm32f7_i2c_enable_smbus_alert(i2c_dev); if (ret) { - dev_err(i2c_dev->dev, - "failed to enable SMBus alert protocol (%d)\n", - ret); + dev_err_probe(i2c_dev->dev, ret, + "failed to enable SMBus alert protocol\n"); goto i2c_disable_smbus_host; } } From patchwork Tue Mar 24 18:26:53 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Atharv Dubey X-Patchwork-Id: 41 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED2D2224AF2 for ; Tue, 24 Mar 2026 18:28:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376882; cv=none; b=LVbF3mG45/8g0QaOP0cg080uhRDOVK6ZxtQwmAFv9i63eVg5YfA53CeH+AE9rPfwTmMMRSRgJ0cBigckKpjs/JMx0UrBhxmk6jAH/WTDeRq9U6u9SGJlvnoCKHGuhXZ58A7/3sD+2tJTuYHsJpahyRaqe17Gx7XwKJZFYrdb3xU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376882; c=relaxed/simple; bh=Og+ag9IkwKlXlRqp73B5hnPk+W9xiNL+UaCwuonyITY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dLXkgCCLAicXxuz16FkNMsO6UguvM7n8k/myIs2H2e57VpUSYibj8B+bL/3Yvel/mpUDUagFG/tXIWEJOET2xlJWxk7ymhIrHF/KShjTR1pHr4NiIukTbyX9/wYYA0T0tBbH5+51oy8/ipHp1kQMAS/0DjeqgeAyG9gFeyr1wE8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=V8j8hZEY; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V8j8hZEY" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-35b905a05a8so3382925a91.1 for ; Tue, 24 Mar 2026 11:28:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774376880; x=1774981680; darn=lists.linux.dev; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=HHa+g9Yvknw/nsgWzBDeK9srp0wKwbZMTd0+ms6kC4c=; b=V8j8hZEYNlC4R+hsYqc6FeQjiDkinxOQ8TD4XGqaeYEYYdigKvhSIHu4DoMRQe3EIv eHxnhp4vF3Cji7QL1JNV2hlcwhshZfbo+HRgAuFM5g3Tk94kKbKaQlLf3X/3nlO7KQHR ywOu/DbTXeYKcvcRl9D3Wx0Fnk+l/DqCfKmGzOoVUukx7wo0HyMcwM/IpI4kZYfxz81s Q/GOTeaSaEkoN8m8tCK9zRQhzOUFDqSbevZzbYm2icreCv9LEDs1e41rXI50DV6pscFK 9KGL92ZW2HYfxzCB42eJ4KbIAsMf69Yl/nVeoOK93WCXmhOpZM4R2GfsLOUHenAaKN8n 7GNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774376880; x=1774981680; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=HHa+g9Yvknw/nsgWzBDeK9srp0wKwbZMTd0+ms6kC4c=; b=GoCuotWBbMYa289xWPJLWugOGmZFexWIZ3SXqD2XoHmRgOwyNjHYWaSSubu+YUXJKA +CV0eZQ3y1c8JDcWVKvwGW+jbcoSUIjUnyzheNX8CUBKa4pgGsaLJCsuWysYpB63dHmo fIAJ2JbI5WzBFRsen6K27G1UVlcyi7moDvHmu/WlVuWBSBAVIej+lgqOk7oXbdvPPgyp 2ueD/lzIMHTRR338b9WKmLATRQP/3uTTwS+R593oObsUBTWU1p5j/2/d/Auxmy6PD87u wo0Zy6LDrEEk8xG24HK8KVSqNx6WnfnHVUUgF4TaZbqCIOXBmBMY6IhV2CIO72hveaNC gkVg== X-Forwarded-Encrypted: i=1; AJvYcCUAPxgpTtRb9GNm8+fKVps7E2GDtuV8+gJsTCSdvFfkuJ/UYEZlS9Nx0i5Iz/T/LfJBLDJ22WiFq5bjjg==@lists.linux.dev X-Gm-Message-State: AOJu0YxNHTT40ABoHEYSx3tjs6tzoe0bIBHsAOg8/d9pkHYrA+aCIsKt 7GJ7SjStR6hFdAkS5QCMea/fTiYIWY7mo7u5jVuWg8+zZOs0Hl3+UKNp X-Gm-Gg: ATEYQzzSx7OjYP48O58eyi8WC5p7T+zvWES3va3f4uqs7LdFBIpYz6gQ2CsF5v+cedV kpdcmVaSpZfolB9gLsqITAoO38BJI+OZ3hSQcN8Pq2R7pmEDiqO71q9cWhWPAY3UR/cBfmPKo8K ++eYt5vURUlFIXpSUFxJp4/nm83lRgDMhip9eXfR24wqGGP7IYfJStWm5WBExc9ruugd5UEwVGb cf4XefT5QqcdIMX/as/BYppsT0M1Fi9g/TC5cjoJJSe6HCiyW9gMVmA4qumP7+IslQhu0VcgrcC UQd/5dqZbLCnfhlFh/Nd4f9TE6hAp3ABiRXNd7p1QawWFCeZYtxmbAtNY6VHUXEYOVcaR/ysu6N FMoKBDRVUa4PdRnnoh23wIodA2fALgObIBGN3jVAAL9mqxjr+WiIE9t/qypToDwPf307C9KQQon NxOTz8QbcvdTklCX4yO0dL4KSDCA== X-Received: by 2002:a17:90b:4ec6:b0:35b:e551:90d2 with SMTP id 98e67ed59e1d1-35c0dd95828mr337562a91.28.1774376879990; Tue, 24 Mar 2026 11:27:59 -0700 (PDT) Received: from [127.0.1.1] ([103.216.213.160]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c0d6060b5sm350576a91.17.2026.03.24.11.27.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 11:27:59 -0700 (PDT) From: Atharv Dubey Date: Tue, 24 Mar 2026 23:56:53 +0530 Subject: [PATCH 05/10] i2c: stm32f4: Replace dev_err() with dev_err_probe() in probe function Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20260324-deverr-v1-5-7e591cce33a3@gmail.com> References: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> In-Reply-To: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> To: Till Harbaum , Andi Shyti , Laxman Dewangan , Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Pierre-Yves MORDRET , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Patrice Chotard , Orson Zhai , Baolin Wang , Chunyan Zhang , Jean Delvare Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, Enrico Zanda , Atharv Dubey X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774376818; l=3441; i=atharvd440@gmail.com; s=20260314; h=from:subject:message-id; bh=fUyekU3vIj3XVF9IEZZuF8p06qRSr8GpHENT4b6dCL0=; b=Lv6diY6U8yOO+wFg03BiFqyP3QS+BUZjUWZZhiQKaL58Ge1g8J4dtHf+S+KQwwxbmw5DUKteO KpFdph3BhEcCYkTzwZIrFSEDvv+nlC32lTjIg5IZhXq8rp8u8lOOdaA X-Developer-Key: i=atharvd440@gmail.com; a=ed25519; pk=T6i1xWOKT/RUSDYATSgyVG/4X7ac8jPjRSG1mMAcqVk= Status: O From: Enrico Zanda This simplifies the code while improving log. Signed-off-by: Enrico Zanda Signed-off-by: Atharv Dubey --- drivers/i2c/busses/i2c-stm32f4.c | 53 ++++++++++++++++------------------------ 1 file changed, 21 insertions(+), 32 deletions(-) diff --git a/drivers/i2c/busses/i2c-stm32f4.c b/drivers/i2c/busses/i2c-stm32f4.c index b3d56d0aa9d0..44e8b04962bb 100644 --- a/drivers/i2c/busses/i2c-stm32f4.c +++ b/drivers/i2c/busses/i2c-stm32f4.c @@ -163,11 +163,9 @@ static int stm32f4_i2c_set_periph_clk_freq(struct stm32f4_i2c_dev *i2c_dev) * to hardware limitation */ if (freq < STM32F4_I2C_MIN_STANDARD_FREQ || - freq > STM32F4_I2C_MAX_FREQ) { - dev_err(i2c_dev->dev, - "bad parent clk freq for standard mode\n"); - return -EINVAL; - } + freq > STM32F4_I2C_MAX_FREQ) + return dev_err_probe(i2c_dev->dev, -EINVAL, + "bad parent clk freq for standard mode\n"); } else { /* * To be as close as possible to 400 kHz, the parent clk @@ -175,11 +173,9 @@ static int stm32f4_i2c_set_periph_clk_freq(struct stm32f4_i2c_dev *i2c_dev) * maximum value of 46 MHz due to hardware limitation */ if (freq < STM32F4_I2C_MIN_FAST_FREQ || - freq > STM32F4_I2C_MAX_FREQ) { - dev_err(i2c_dev->dev, - "bad parent clk freq for fast mode\n"); - return -EINVAL; - } + freq > STM32F4_I2C_MAX_FREQ) + return dev_err_probe(i2c_dev->dev, -EINVAL, + "bad parent clk freq for fast mode\n"); } cr2 |= STM32F4_I2C_CR2_FREQ(freq); @@ -772,22 +768,19 @@ static int stm32f4_i2c_probe(struct platform_device *pdev) return PTR_ERR(i2c_dev->base); irq_event = irq_of_parse_and_map(np, 0); - if (!irq_event) { - dev_err(&pdev->dev, "IRQ event missing or invalid\n"); - return -EINVAL; - } + if (!irq_event) + return dev_err_probe(&pdev->dev, -EINVAL, + "IRQ event missing or invalid\n"); irq_error = irq_of_parse_and_map(np, 1); - if (!irq_error) { - dev_err(&pdev->dev, "IRQ error missing or invalid\n"); - return -EINVAL; - } + if (!irq_error) + return dev_err_probe(&pdev->dev, -EINVAL, + "IRQ error missing or invalid\n"); i2c_dev->clk = devm_clk_get_enabled(&pdev->dev, NULL); - if (IS_ERR(i2c_dev->clk)) { - dev_err(&pdev->dev, "Failed to enable clock\n"); - return PTR_ERR(i2c_dev->clk); - } + if (IS_ERR(i2c_dev->clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(i2c_dev->clk), + "Failed to enable clock\n"); rst = devm_reset_control_get_exclusive(&pdev->dev, NULL); if (IS_ERR(rst)) @@ -807,19 +800,15 @@ static int stm32f4_i2c_probe(struct platform_device *pdev) ret = devm_request_irq(&pdev->dev, irq_event, stm32f4_i2c_isr_event, 0, pdev->name, i2c_dev); - if (ret) { - dev_err(&pdev->dev, "Failed to request irq event %i\n", - irq_event); - return ret; - } + if (ret) + return dev_err_probe(&pdev->dev, ret, + "Failed to request irq event %i\n", irq_event); ret = devm_request_irq(&pdev->dev, irq_error, stm32f4_i2c_isr_error, 0, pdev->name, i2c_dev); - if (ret) { - dev_err(&pdev->dev, "Failed to request irq error %i\n", - irq_error); - return ret; - } + if (ret) + return dev_err_probe(&pdev->dev, ret, + "Failed to request irq error %i\n", irq_error); ret = stm32f4_i2c_hw_config(i2c_dev); if (ret) From patchwork Tue Mar 24 18:26:54 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Atharv Dubey X-Patchwork-Id: 40 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9CDF3A381B for ; Tue, 24 Mar 2026 18:28:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376894; cv=none; b=EwR3O5mV+3vB4T9fQmNh3HT00uMtzApvhqaB0VOBdtgwlNbOwL1qo6RdM+HtuaWOOsF2mGEYv8yK66kTKbD8+jCZEt9Zf+d2Vmyqa0OeUz+FQbGEFDMGFKOAoOrjS4mnX2BWXhbtJW7iFCQGx1XxrfE+BrZDDbrPuRJ2moivYjg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376894; c=relaxed/simple; bh=iap5qBBPM9+z7GkIgQPTPNBQ4CZotIn48Ss9ISZDGxI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Jwwqv+OlDbildmBgZwJlBbQ2cc2vABgXCA343uN2nItoO7KhndO2ki/eeH4qeh1EkHAN/z5NP+/P6Iq/sNWkEuUnSWXdJDpqqua/6tFAIjmINEGzS43qoKDMpVsqg88d/8vQ8esN3mC5JNYlHuaPq9phkS1jGv7EGEAgUnpGOZ8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lWB8/k8g; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lWB8/k8g" Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-c70c112cb61so990299a12.0 for ; Tue, 24 Mar 2026 11:28:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774376892; x=1774981692; darn=lists.linux.dev; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=LOh7L59SGXDe0n/0/CxydhLmu3Ccl2K/OUt14k5rUoM=; b=lWB8/k8gAUAY5JNPMgew8WaCkNATMVUuDaiXItR/+u/Jzw56PK4U5qiz8kOjpTGA6c TiGUyHtWFfZRFfLvWB3G+e4Mfj2adYaXw6vg8gncL2JcWOGyAY/5/aaNuLKizDUB/B4M FWVgIXiCzNIohyJPVaFgm3NDju6exhXswS94QfuOF8wxRCWrwpSGu3iAwGVRNX5yZo3a sdokWx6l0672fCxnIkrvHlZw+Cd69j12iDiH/1BGaCcnaz00XI/TC2lQmpk4jju/sqRj ff8L7q2J7zErJy4jzxAjdhCFt+opZdNTZzDSygEGEMWFLSLht4g/YwPO/Rf60nM3Snc/ lEFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774376892; x=1774981692; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=LOh7L59SGXDe0n/0/CxydhLmu3Ccl2K/OUt14k5rUoM=; b=lRVrPOjql5gDJZ8SZOS1YThR0YzbY06zbt+K+HaFFXYosqZeLZG/JKqyemCXB04dyq 8ovET9VP4Gku03l9cWQBUEovWPuDmxL2UEYV8txNgp6TD+pwIJIQzu0iOSuBfV+ZaWwi K+wCvgRf6AsgvWHKfexEfZATYdLMeJmhtmmR1LR39W846ZN9kHJiSRsjFcCpr1V9gY5+ H5cEPl9UB2v6dCZMfn79ykuuzLFsRdoL7y7mSUG+HJZxtBCgr94UICu9EZbD9hEOmIHl OXY9T4U6+LzNj4t8LUIUv1g0VEAFUMW9pAYNnzYPZzd9cYAkzEAe9r7Kcx7dQohQtv1+ LJrw== X-Forwarded-Encrypted: i=1; AJvYcCVHFJVgYfQeRAqZMrTK2TcadGCwjnH+7dWbBA+YWtWzqn6EfRlXOZKKjVziiHw9g2zNDgLP9eCMc7lctA==@lists.linux.dev X-Gm-Message-State: AOJu0YwNKNyrfAi82sM3STOztxrFrYET+jiyAXO8tKxG791OPCz6Qhtz wvr7KCbIWjMbVWmTEMD8nFIxzfMQUEQi1iuXXJahitH2TtoNqJ3BjlRn X-Gm-Gg: ATEYQzyT/YbiADVLJnMLq6YL3yksEM9mGZM0IjkOeNTXcIJ2Qnr5y6+0U0kSg7xvuy2 4060KuTliIhrqBzIT6A0wv8Pkl+hpEk91k30iG87CietUD2WqslwXYCHjHe20Sk9jJU4JRdqr4P 5sBW+u6Au7GSD7rMv692yvrfG+aw9aBk+e2mxvA1od1AWlN3jilwzYZcin8vXu4aGBzT+OXH3CG KafPdiF4HveOh6lzmEA3pxFcMmRfDNh/dEGyZlcSEPIAC/39pT9L3iOx27kF0JGdEFJxmFiCuTA IybQKpw7Sv6LmKXxCj/rCgbfioTAHHLV6s/GekBIIbeQiD/G1Y+FeEbimEoV0nC/h0UBkxxnxwR jwORYklSmevyZLNsLbsaO6ezLrigUSTksxrNk4chjHCu+2V+zCz5Jh7b8XJbiAsqWKLmXqg7S5o k4lj2yinbq6kJF020jrR2TQmISyQ== X-Received: by 2002:a17:90b:4a4f:b0:359:f22:8879 with SMTP id 98e67ed59e1d1-35c0ddb253amr350462a91.22.1774376892133; Tue, 24 Mar 2026 11:28:12 -0700 (PDT) Received: from [127.0.1.1] ([103.216.213.160]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c0d6060b5sm350576a91.17.2026.03.24.11.28.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 11:28:11 -0700 (PDT) From: Atharv Dubey Date: Tue, 24 Mar 2026 23:56:54 +0530 Subject: [PATCH 06/10] i2c: stm32: Replace dev_err() with dev_err_probe() in probe function Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20260324-deverr-v1-6-7e591cce33a3@gmail.com> References: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> In-Reply-To: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> To: Till Harbaum , Andi Shyti , Laxman Dewangan , Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Pierre-Yves MORDRET , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Patrice Chotard , Orson Zhai , Baolin Wang , Chunyan Zhang , Jean Delvare Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, Enrico Zanda , Atharv Dubey X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774376818; l=1144; i=atharvd440@gmail.com; s=20260314; h=from:subject:message-id; bh=fGh6XbxSkvU5zsFALrHQqBdXVjE2X7LO7LjtYihQc1Q=; b=bSr5WSYN2sBbQ56eV/RU7Nsc30A+f8iif2b8KvF+i2QPU4oV/n2gxZwRlmFwYUL0Sn4WgwU3t BHbt5Op51GJBjc0aJ76ljbLTb0hDHykJdiMU+4SpjB/VkJQQUf6r5CT X-Developer-Key: i=atharvd440@gmail.com; a=ed25519; pk=T6i1xWOKT/RUSDYATSgyVG/4X7ac8jPjRSG1mMAcqVk= Status: O From: Enrico Zanda This simplifies the code while improving log. Signed-off-by: Enrico Zanda Signed-off-by: Atharv Dubey --- drivers/i2c/busses/i2c-stm32.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-stm32.c b/drivers/i2c/busses/i2c-stm32.c index becf8977979f..064e47d6c96f 100644 --- a/drivers/i2c/busses/i2c-stm32.c +++ b/drivers/i2c/busses/i2c-stm32.c @@ -39,7 +39,7 @@ struct stm32_i2c_dma *stm32_i2c_dma_request(struct device *dev, dma_sconfig.direction = DMA_MEM_TO_DEV; ret = dmaengine_slave_config(dma->chan_tx, &dma_sconfig); if (ret < 0) { - dev_err(dev, "can't configure tx channel\n"); + dev_err_probe(dev, ret, "can't configure tx channel\n"); goto fail_tx; } @@ -60,7 +60,7 @@ struct stm32_i2c_dma *stm32_i2c_dma_request(struct device *dev, dma_sconfig.direction = DMA_DEV_TO_MEM; ret = dmaengine_slave_config(dma->chan_rx, &dma_sconfig); if (ret < 0) { - dev_err(dev, "can't configure rx channel\n"); + dev_err_probe(dev, ret, "can't configure rx channel\n"); goto fail_rx; } From patchwork Tue Mar 24 18:26:55 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Atharv Dubey X-Patchwork-Id: 39 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97F963A3825 for ; Tue, 24 Mar 2026 18:28:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376907; cv=none; b=XOvqML5BwvJ+T2jKK7ydlkbTbuFixKBFqWykgZSlPP7vXlx+Z08eKnE6hBEMJG/jEogNiiYYeR/X46UD49pHvTu6r4YiX4uFhWAYRbcLQdh+frH2DsEafAy+LBmBTk8Yu2TXcmmhz6SxaeK43DtAl9FV8dUX/nThKSB46qq44Jo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376907; c=relaxed/simple; bh=cDcTMwkXqvLZxNGPDMHwcK5wJhpj2l1qGF/0VyfBQEI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nqjGKfvfU/2wMN365TbJvU8AEY1Z2s+rQhfaO/+yIpNWoNqY8qewFv4nDNbDNbZ0J2RYvoJh0nzWxKOGLYR7nTCbgxOipUBEDo6M7l3QytxK9+laMObQVGkNNqfFTqFOoyeO5CMWh3M9MqvTilwn34y+y0KshuaZQAaU655/2pk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cnmEz0ES; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cnmEz0ES" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-35a1d4a095bso113202a91.0 for ; Tue, 24 Mar 2026 11:28:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774376904; x=1774981704; darn=lists.linux.dev; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=7jbYoDFFKwnOMKQiaSrjwW8IJ/VZkZBU3IOohjNwPSU=; b=cnmEz0ESYyRH5TqYJ2O9XTimgjgXweww0n1jqYluFZ9GCtWwoxrAN3Qrqyfw/rmT/5 F9IbJUrE4zXp5psIAW687E3XI4OLW+tQuU0tVdTBtu8fg4/C8SlSMLu2dXVGqsiHwx67 1p+0jnbuHdeHI4mE3PKzaQBkYW4CYBkPWgSlDgLheGGtTHNcFU04owqnqo1gQF9N7Lqn XhMIxo4P9aZecskaKeZjXMlknsalhDfWQADgj/jSB/gt7fcgL6yMVg+uCVlagUZ7OlVL HbkPtdlCMMOdGmzM69ER3CcromnRd99jMYrC28QE5wFy/so13E99gQTWx5UvIohlzY4q Qi2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774376904; x=1774981704; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=7jbYoDFFKwnOMKQiaSrjwW8IJ/VZkZBU3IOohjNwPSU=; b=Sn1NrdqXuJxQ35A6nRsKvGLH6hITCJCzDcYF3Y/qu02Tt1acyda2m6xfztY7K6GR6c ZftNwO9eCLJo2XBqaQQIKM4c2vVmV6Qa6cZmYo1yRardnNE0MIZMic68fCoWVVyFnCJ+ 9hmRSvMBo2O+2dTP/xkvKXSc3SGPwLISr0140WbbUHTbMiPJ+gJzMCIHJG+fKufyHunG 1718iYyil7eYYxkqn5sK2dj1Nr+E5yMFQrACf5tAnRjoHykIyeiQndRFWVVChTq2ME0w 9CyFyhqJlBvpNsW+zOoX3jm5jQbB6rMa1C14G+I7O44YpaCr5p8e4hhDOsn6IiejrcQn 0juw== X-Forwarded-Encrypted: i=1; AJvYcCXKJ342iNHGxDcY03CFL+p8h+v1E/29CRWhsFbeeBakm1MmPiG7Cm2UrZ29D4rCYtEU5wGDmxjN4QBBhQ==@lists.linux.dev X-Gm-Message-State: AOJu0YzPFxCZ9Z0SXTZI0R6+GAO6BH1GYe9Pgm/mGrinpSXKFAfCIGre 3L/+GvHd/+fezzMCf7jNsduVd8WLpI0JvdGtLXF73Ok51nUmt/OjJe4O X-Gm-Gg: ATEYQzwNDIA02iI2HCCXRW/zkA7ao8UCV3x/cDqCuTV7Um+idvwI9JZHobxfsT/0qSq 44SrhC6ou51rJ9pZj6zxKPr/wtS58/6KxPuwbpPDo0N1bffRxG4hEdRMLiO9GGfDjdDMf8fL64d nKd1NTZGhza/17A6WFNUUpNRujdEDjl/7h5/s+tRn59aOm9OGUDk2iW0K7rChCRIzuuxT19GUns HeljRoe+Y5Z855tc4wNXPIa7KI7C17xsVDlJMDBrzDKhpM3CK8o9mTTWtX9A1XPkVugWcrz5uSL UHHLYIl1hsGRUJ5vkFHA04urvft5DPjywWBlGP8aBkIrRKS9ENC6hPa1/sliolofilqB6p5igAf k+C/U1BBATfDzGoUdbowYFXlIKJ57BRs1lkl5qFllnwqw3EcL5pcyNcxRb9KSJV0NAnkCCU89jl dte0CIgMhfziO50Buhgcoc4H8ofw== X-Received: by 2002:a17:90b:3c07:b0:35b:a0f0:8327 with SMTP id 98e67ed59e1d1-35c0d1001a9mr618620a91.2.1774376904310; Tue, 24 Mar 2026 11:28:24 -0700 (PDT) Received: from [127.0.1.1] ([103.216.213.160]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c0d6060b5sm350576a91.17.2026.03.24.11.28.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 11:28:23 -0700 (PDT) From: Atharv Dubey Date: Tue, 24 Mar 2026 23:56:55 +0530 Subject: [PATCH 07/10] i2c: st: Replace dev_err() with dev_err_probe() in probe function Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20260324-deverr-v1-7-7e591cce33a3@gmail.com> References: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> In-Reply-To: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> To: Till Harbaum , Andi Shyti , Laxman Dewangan , Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Pierre-Yves MORDRET , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Patrice Chotard , Orson Zhai , Baolin Wang , Chunyan Zhang , Jean Delvare Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, Enrico Zanda , Atharv Dubey X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774376818; l=2664; i=atharvd440@gmail.com; s=20260314; h=from:subject:message-id; bh=QTq/SsBBXUdzBzLen+lO5rBpYhODcjwD4XTKabWXWjM=; b=6uYv7INtZBtXz/5CGPPLnmZfr7dOa2FHZwl9/oOHXGn01WGXqmOPkElSojC2emL6vTKD8y1gU mA1lXC4EoXKCgHD1s/6elwyP7MOynX9ePlEaoKUiP69Jyq2pL/sIZCs X-Developer-Key: i=atharvd440@gmail.com; a=ed25519; pk=T6i1xWOKT/RUSDYATSgyVG/4X7ac8jPjRSG1mMAcqVk= Status: O From: Enrico Zanda This simplifies the code while improving log. Signed-off-by: Enrico Zanda Signed-off-by: Atharv Dubey --- drivers/i2c/busses/i2c-st.c | 34 ++++++++++++++-------------------- 1 file changed, 14 insertions(+), 20 deletions(-) diff --git a/drivers/i2c/busses/i2c-st.c b/drivers/i2c/busses/i2c-st.c index 751ea421caaf..3f89c2145741 100644 --- a/drivers/i2c/busses/i2c-st.c +++ b/drivers/i2c/busses/i2c-st.c @@ -775,17 +775,15 @@ static int st_i2c_of_get_deglitch(struct device_node *np, ret = of_property_read_u32(np, "st,i2c-min-scl-pulse-width-us", &i2c_dev->scl_min_width_us); - if ((ret == -ENODATA) || (ret == -EOVERFLOW)) { - dev_err(i2c_dev->dev, "st,i2c-min-scl-pulse-width-us invalid\n"); - return ret; - } + if ((ret == -ENODATA) || (ret == -EOVERFLOW)) + return dev_err_probe(i2c_dev->dev, ret, + "st,i2c-min-scl-pulse-width-us invalid\n"); ret = of_property_read_u32(np, "st,i2c-min-sda-pulse-width-us", &i2c_dev->sda_min_width_us); - if ((ret == -ENODATA) || (ret == -EOVERFLOW)) { - dev_err(i2c_dev->dev, "st,i2c-min-sda-pulse-width-us invalid\n"); - return ret; - } + if ((ret == -ENODATA) || (ret == -EOVERFLOW)) + return dev_err_probe(i2c_dev->dev, ret, + "st,i2c-min-sda-pulse-width-us invalid\n"); return 0; } @@ -808,16 +806,13 @@ static int st_i2c_probe(struct platform_device *pdev) return PTR_ERR(i2c_dev->base); i2c_dev->irq = irq_of_parse_and_map(np, 0); - if (!i2c_dev->irq) { - dev_err(&pdev->dev, "IRQ missing or invalid\n"); - return -EINVAL; - } + if (!i2c_dev->irq) + return dev_err_probe(&pdev->dev, -EINVAL, "IRQ missing or invalid\n"); i2c_dev->clk = of_clk_get_by_name(np, "ssc"); - if (IS_ERR(i2c_dev->clk)) { - dev_err(&pdev->dev, "Unable to request clock\n"); - return PTR_ERR(i2c_dev->clk); - } + if (IS_ERR(i2c_dev->clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(i2c_dev->clk), + "Unable to request clock\n"); i2c_dev->mode = I2C_MODE_STANDARD; ret = of_property_read_u32(np, "clock-frequency", &clk_rate); @@ -829,10 +824,9 @@ static int st_i2c_probe(struct platform_device *pdev) ret = devm_request_threaded_irq(&pdev->dev, i2c_dev->irq, NULL, st_i2c_isr_thread, IRQF_ONESHOT, pdev->name, i2c_dev); - if (ret) { - dev_err(&pdev->dev, "Failed to request irq %i\n", i2c_dev->irq); - return ret; - } + if (ret) + return dev_err_probe(&pdev->dev, ret, + "Failed to request irq %i\n", i2c_dev->irq); pinctrl_pm_select_default_state(i2c_dev->dev); /* In case idle state available, select it */ From patchwork Tue Mar 24 18:26:56 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Atharv Dubey X-Patchwork-Id: 38 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 429F72459EA for ; Tue, 24 Mar 2026 18:28:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376918; cv=none; b=hfCIN0Ridq6NYls4ywU1/bBzCL8Qry4sfATzUYY0SWIPZK+Oj2xDr+acmfyLYCCXS88L5zRO7ixGoqWzfnssXiWNPX/8DkavPSrivN8dH4gOMYvExa2+kaWvWlbGuDgZdod5M0/1r39J/XNMdGMuugsTC1eIgz6itMrBKUdsEoM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376918; c=relaxed/simple; bh=InYIOZ74uRoVGHRDFdN9ukawBsa/EDFlsLY4lGClCxs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IVGFmzJCvuraX+ILvY1RILu+2b/xJBWjWfwc1uB/zLmdUVNy1tqROTDnJaMDwncDb1F3KKOGdENm6peBvtdg9OWeujq2fi38CDge8IpXGHpxkh31aPfYboTv6LvKWvt4valeVj4Id+46rC7qLnYz01hPwiWxrlNoAnXT2w4UsdI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XzEKxz/d; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XzEKxz/d" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-358e3cc5e7eso3159534a91.0 for ; Tue, 24 Mar 2026 11:28:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774376916; x=1774981716; darn=lists.linux.dev; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=pWQFrxeJ9xbwYy1VhHH7N7bPolG8RRVJqSZfUbUVPdk=; b=XzEKxz/dSQSJVvDJEje5vMbbFhX6vtHeHokUkwNdbP65OwRG7iuo//4Zg3Fl5dB3Jc 9TzPMf5fxB7pjMgc2kCnxmfh6aiymbjudelSl81qLWLEck9LVdjYa/nujWjq+Tl6TA4t 5btMTI8pqdd/IWo14snakqSHIFT55hQwpFu02Np1ksghrrnxdsK+V+k8WzKDm5szVNdz xQUUzdDt+8IhToVZCV6QgB9MCxrJurjpBITj7i10N3MDatJ2VxVDkaYfuVxngXKa34V0 +6py40zxIHH1f1UhpihvANV0zDAs/moJePyMLid4O9isNA26hqAlRMNtnL53+DeD3Pfc oebg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774376916; x=1774981716; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=pWQFrxeJ9xbwYy1VhHH7N7bPolG8RRVJqSZfUbUVPdk=; b=Pf0gedTAgDTm4XmnCr/ZxwB9giyxlonXePl5mPd9Bf4enno1MfY2WvgwxeVegZ3s00 aNcQjOlMC30aV+H7X9Dj5U3dWjrDsBtUxJ2F3fzoFrcTgWQK7K+ROwhotWOi4PgWFDAl isXawDeEtZH0gW12NtAPNMtgOROo8iDESU/j27YX/vAkEFP5m1nuoZfMpVR6gCyZ5zsN bkDmFatPZbmxUDwWRhVM6vSnquGNAwQw8B3y1OAN5JtTJR/r4QNjMH6M2xyeJzgDcd7M WWilwEcS5hpJYJPK9Yvpj/e9qQRqOJv61AHfn+Pc+i8aIdMN2ZIcIhYgCPIgZz7eU2/6 7ygQ== X-Forwarded-Encrypted: i=1; AJvYcCUjPUDA3VCQN9+R4uvrDDNzeJEFRESPPqbFYnAm22SGwkCa2rHPPvVnTBqzSAZVKADirgxiKB097H3Skg==@lists.linux.dev X-Gm-Message-State: AOJu0YzN7O5lK4Xk8/imHF7M+ZW0SEdHSKHYRrSWLBS9xJG23Rm6f9JQ BsGQNJQIemmQA1SLnFn42xTWtStTKNz0twdh+l0ENa3J8qLpy2YOUrqX X-Gm-Gg: ATEYQzw+StBmJKnGcdxb70nIjwHJZx/njL/uMHvq2S9wZUpuRM9q8U2O15htGHqtvGF Go0Rw5BGFMq9X8skwhoAFKVkA7UW7SDc1xiNwG2VScyHarj0ms1y+8Lb54CmHF42XTjwQ8rpHTd 3zmuFQPZvh78/rnjFDO+j546SPqlFXJJzTFrqShRXpkFDIPjV/fZnVn0G+wuOWG1+lqyQd+/Ay/ w9SuMZAQFe8mvozEpdMdHEJpRO92LM4ARPWqORF7X1aEruYHIG+ZMnP7rwJzoSiOQ8Qkbk8QQXh TGzSS+edUi0vvBp9EUT9uvSinNu31ni9z2MVhiVgW5fXZxfQk6C5AK1Tzkr4Zpl8ZZNVqJfQpWB Q5UmE+M2Kag2dCvcqmQ267oG5Sp7goUmJ1ORDrS1dueC+c9OewN+BVNxkCp7Uyr4gb+DDNQLLqu NNufAPoWcR/XC/0885VsHpTH53Mw== X-Received: by 2002:a17:90b:17c8:b0:35b:e555:f19 with SMTP id 98e67ed59e1d1-35c0ddc5abamr302415a91.25.1774376915602; Tue, 24 Mar 2026 11:28:35 -0700 (PDT) Received: from [127.0.1.1] ([103.216.213.160]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c0d6060b5sm350576a91.17.2026.03.24.11.28.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 11:28:35 -0700 (PDT) From: Atharv Dubey Date: Tue, 24 Mar 2026 23:56:56 +0530 Subject: [PATCH 08/10] i2c: sprd: Replace dev_err() with dev_err_probe() in probe function Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20260324-deverr-v1-8-7e591cce33a3@gmail.com> References: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> In-Reply-To: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> To: Till Harbaum , Andi Shyti , Laxman Dewangan , Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Pierre-Yves MORDRET , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Patrice Chotard , Orson Zhai , Baolin Wang , Chunyan Zhang , Jean Delvare Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, Enrico Zanda , Atharv Dubey X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774376818; l=1529; i=atharvd440@gmail.com; s=20260314; h=from:subject:message-id; bh=ASHKLgyhVdhgUS0PF+wcYp1muqF4w//oNCLBXZkcUHY=; b=hXROFYzb3OmT3cxRxEoFIuEeGuiZJd8xLM4x0yhyQx4WWK4SUYX6zSFRnwpUkd47L0bbPAvtp mE3F0pCOHTsA7C6xaX1n86n4DvW3PrzzB2RQAlr/W45yvtlvUvwnwXb X-Developer-Key: i=atharvd440@gmail.com; a=ed25519; pk=T6i1xWOKT/RUSDYATSgyVG/4X7ac8jPjRSG1mMAcqVk= Status: O From: Enrico Zanda This simplifies the code while improving log. Signed-off-by: Enrico Zanda Signed-off-by: Atharv Dubey --- drivers/i2c/busses/i2c-sprd.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/i2c/busses/i2c-sprd.c b/drivers/i2c/busses/i2c-sprd.c index 1b490525d8dd..7b321a956fca 100644 --- a/drivers/i2c/busses/i2c-sprd.c +++ b/drivers/i2c/busses/i2c-sprd.c @@ -469,11 +469,10 @@ static int sprd_i2c_clk_init(struct sprd_i2c *i2c_dev) i2c_dev->adap.nr, i2c_dev->src_clk); i2c_dev->clk = devm_clk_get(i2c_dev->dev, "enable"); - if (IS_ERR(i2c_dev->clk)) { - dev_err(i2c_dev->dev, "i2c%d can't get the enable clock\n", - i2c_dev->adap.nr); - return PTR_ERR(i2c_dev->clk); - } + if (IS_ERR(i2c_dev->clk)) + return dev_err_probe(i2c_dev->dev, PTR_ERR(i2c_dev->clk), + "i2c%d can't get the enable clock\n", + i2c_dev->adap.nr); return 0; } @@ -548,13 +547,13 @@ static int sprd_i2c_probe(struct platform_device *pdev) IRQF_NO_SUSPEND | IRQF_ONESHOT, pdev->name, i2c_dev); if (ret) { - dev_err(&pdev->dev, "failed to request irq %d\n", i2c_dev->irq); + dev_err_probe(&pdev->dev, ret, "failed to request irq %d\n", i2c_dev->irq); goto err_rpm_put; } ret = i2c_add_numbered_adapter(&i2c_dev->adap); if (ret) { - dev_err(&pdev->dev, "add adapter failed\n"); + dev_err_probe(&pdev->dev, ret, "add adapter failed\n"); goto err_rpm_put; } From patchwork Tue Mar 24 18:26:57 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Atharv Dubey X-Patchwork-Id: 37 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3B142459EA for ; Tue, 24 Mar 2026 18:28:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376929; cv=none; b=MdkMrhxUIRyAkKNO5Ctp3z0+Gcmd+gXKKrU1je4aCfDlGNFDYu23ky51XupD8yLJmriYMOs7HIfxPvEMyOszELccqjsEroIHVxXidcpegtfqCXDl2ydC9hjd2VUnU/BtDqt4bZFv8yRAeaab4hGzxzdYlwGiygWqH5p6PcDZ/4A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376929; c=relaxed/simple; bh=WclG9/5UCAVmNpJ6wIy91+8u1Ud041oHxz1zl+TJNjA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Dijt42eQETM+0aqErgM/D9o5QgXaXuU8DMlFLQCdwq/tCZJ6qMWO29IcMYSzIMXMucTS6lElG0wggN+9WL0xTdjJXilz9kZE4KSJpBkeRSwu2KunEkHZI0HxVP4vV7kZaE0rJsl5LNM8QB8iHO3+Plsug7N9z+T8xKOZQDstYU0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rA//LVMR; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rA//LVMR" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-358e3cc5e7eso3159604a91.0 for ; Tue, 24 Mar 2026 11:28:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774376927; x=1774981727; darn=lists.linux.dev; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=TNhN09MjB5vo7WQrY09vfIIZoGUP1LY8sfZbk/6EDLE=; b=rA//LVMRZTtzch0iwI6h4u/FUf9irItj+DEqHPjHXQVDSJo9LpBwIG6LYXlYhnxKFM NwGUiVoo2qsOpfTK6O88b3xlYzLyMTn3cEyF+qgC6Zb6dWmjjpK/oEATZjwrjD+iPSi9 CzDkJDW8mt4SxBKzhFwLdtawEr63Z9ldAipj3qP/xT9AUEJwjn65AXhE7n4hUkuYCrrM muTr7/W/PCGesA1DcaKMdCqnOxVNUq44QCIF7LaAmt8uP7mZjzun/kW93SKmAKj7Mz2w SdEeoCnx2B2OBBh7wyXiRq1OGT7Evx4pHKH2ian60yU39ELrAhAbFjKvkGvKR3IPgxaC hg4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774376927; x=1774981727; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=TNhN09MjB5vo7WQrY09vfIIZoGUP1LY8sfZbk/6EDLE=; b=BmkcnVNvOdJP9rM1dzJf3meYxMsO2DYhru78Og6eV7vylV4Vhy65N1bz2FuMEYvJzS iX+htSCJy3e0gakVrHCMirHik9Wy2pjdfleRfjiCtbsyVNmqfkcNWHE23nnkIsi6WVA6 xaUsk7eRnD1y7DyYtK1a3x0limRxkseJJsuYfVfnXPrhV6gjAXqmFmpGtiP0zWwlVGqb mRckYRhYOhoy65nQ7HpPDTmUJTGHENJwWR9EjzBpwL2WCnepR2y/Pd4ZhUi6U+3Z4ux6 1BFCYX9IKmE3h/nJktqjxT2i0PwETOKSFNGMSPxy3a47LhumZJpNwNoGLr9qLDftNjci CZBw== X-Forwarded-Encrypted: i=1; AJvYcCW4doq8DFQBXw8WoN9MkDbZJ3bTTPZPMXtXFT3j+DCt/OVdhG9k0qw4VLjvDtrPOeAzY046hDLsxVmaLg==@lists.linux.dev X-Gm-Message-State: AOJu0YyBAi2Ee0ByLiJqKtczgTUH+Sd1Q3VWkL52G4/20+fCbeBcF7B4 YDHuRndpn+fiMUyJBp1YQmel3J+W0nWCJSZTqxD0tHW6KhzHXQnXZ4qB X-Gm-Gg: ATEYQzwzWRpDKZKK01ncdPV6J/T6noQwqG7+rHp03R11+Xwf33cCpYblicc87WWIBTd 6T2QrovjkInb0xxFcNsEadvFEI5e70+WHHJPLvfksx7gik7adEGxMQkRDqw7lmYMTr76H7uDGJJ expfwY47AjX3AZaawNczMipe1GZO/bmulsva1jWLIDkhx36OLqsNvBWxA6Bs6C/55RZuuS/oWKv T3eI1AfFuJXaWtl2YTeYUXHxGR1/chSC/Em90lWLNQnPvjNIQegbO89VvSqASkBu8Pn/wS5RN08 4JtoY0DdbV774BYWO7ksB4z6vLdYC5YZY7rp0E36c9KxC1c+BprIdQZfLt0ZjXu//YnFf/Nxg1h eF1lvxlaxu4uqbRFUoW1SEPqAS5E7jNq1EBrRgJIrCMIgDiLKNU6eGffsFz5LvzvPuJYEHL/qfP MpZUPIFiNyGnEDamkx8EkPiJokfSHwQ6V0hDB+ X-Received: by 2002:a17:90b:1d8a:b0:35b:e5ba:c0c8 with SMTP id 98e67ed59e1d1-35c0ddd9ed9mr320446a91.28.1774376927304; Tue, 24 Mar 2026 11:28:47 -0700 (PDT) Received: from [127.0.1.1] ([103.216.213.160]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c0d6060b5sm350576a91.17.2026.03.24.11.28.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 11:28:46 -0700 (PDT) From: Atharv Dubey Date: Tue, 24 Mar 2026 23:56:57 +0530 Subject: [PATCH 09/10] i2c: sis96x: Replace dev_err() with dev_err_probe() in probe function Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20260324-deverr-v1-9-7e591cce33a3@gmail.com> References: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> In-Reply-To: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> To: Till Harbaum , Andi Shyti , Laxman Dewangan , Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Pierre-Yves MORDRET , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Patrice Chotard , Orson Zhai , Baolin Wang , Chunyan Zhang , Jean Delvare Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, Enrico Zanda , Atharv Dubey X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774376818; l=2523; i=atharvd440@gmail.com; s=20260314; h=from:subject:message-id; bh=2gYAVvyUJk/qxHL4KJceROL4iNDzsuJ4eDXGcgjkpVk=; b=vB2gL2qhGY3YL/cIJqmvowLCaQEngaBk72sJRkrwCl3oRTHnnpcQvD7hzPfvDqHKUYnT4Wr6Y Zfn7Uu0NXm6B/rb6bM9jYBJr8GEREU1oPwc+1RRqWHn4xFjESwTrs7U X-Developer-Key: i=atharvd440@gmail.com; a=ed25519; pk=T6i1xWOKT/RUSDYATSgyVG/4X7ac8jPjRSG1mMAcqVk= Status: O From: Enrico Zanda This simplifies the code while improving log. Signed-off-by: Enrico Zanda Signed-off-by: Atharv Dubey --- drivers/i2c/busses/i2c-sis96x.c | 30 +++++++++++++----------------- 1 file changed, 13 insertions(+), 17 deletions(-) diff --git a/drivers/i2c/busses/i2c-sis96x.c b/drivers/i2c/busses/i2c-sis96x.c index 77529dda6fcd..eee41dc9d706 100644 --- a/drivers/i2c/busses/i2c-sis96x.c +++ b/drivers/i2c/busses/i2c-sis96x.c @@ -245,23 +245,19 @@ static int sis96x_probe(struct pci_dev *dev, u16 ww = 0; int retval; - if (sis96x_smbus_base) { - dev_err(&dev->dev, "Only one device supported.\n"); - return -EBUSY; - } + if (sis96x_smbus_base) + return dev_err_probe(&dev->dev, -EBUSY, "Only one device supported.\n"); pci_read_config_word(dev, PCI_CLASS_DEVICE, &ww); - if (PCI_CLASS_SERIAL_SMBUS != ww) { - dev_err(&dev->dev, "Unsupported device class 0x%04x!\n", ww); - return -ENODEV; - } + if (ww != PCI_CLASS_SERIAL_SMBUS) + return dev_err_probe(&dev->dev, -ENODEV, + "Unsupported device class 0x%04x!\n", ww); sis96x_smbus_base = pci_resource_start(dev, SIS96x_BAR); - if (!sis96x_smbus_base) { - dev_err(&dev->dev, "SiS96x SMBus base address " - "not initialized!\n"); - return -EINVAL; - } + if (!sis96x_smbus_base) + return dev_err_probe(&dev->dev, -EINVAL, + "SiS96x SMBus base address not initialized!\n"); + dev_info(&dev->dev, "SiS96x SMBus base address: 0x%04x\n", sis96x_smbus_base); @@ -272,9 +268,9 @@ static int sis96x_probe(struct pci_dev *dev, /* Everything is happy, let's grab the memory and set things up. */ if (!request_region(sis96x_smbus_base, SMB_IOSIZE, sis96x_driver.name)) { - dev_err(&dev->dev, "SMBus registers 0x%04x-0x%04x " - "already in use!\n", sis96x_smbus_base, - sis96x_smbus_base + SMB_IOSIZE - 1); + dev_err_probe(&dev->dev, -EINVAL, + "SMBus registers 0x%04x-0x%04x already in use!\n", + sis96x_smbus_base, sis96x_smbus_base + SMB_IOSIZE - 1); sis96x_smbus_base = 0; return -EINVAL; @@ -287,7 +283,7 @@ static int sis96x_probe(struct pci_dev *dev, "SiS96x SMBus adapter at 0x%04x", sis96x_smbus_base); if ((retval = i2c_add_adapter(&sis96x_adapter))) { - dev_err(&dev->dev, "Couldn't register adapter!\n"); + dev_err_probe(&dev->dev, retval, "Couldn't register adapter!\n"); release_region(sis96x_smbus_base, SMB_IOSIZE); sis96x_smbus_base = 0; } From patchwork Tue Mar 24 18:26:58 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Atharv Dubey X-Patchwork-Id: 36 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED846396566 for ; Tue, 24 Mar 2026 18:28:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376939; cv=none; b=Uud4/OasCOtvIbCpHbmefs4c7bvHwJ4/tm3zkRsB/wHxsjYzf0hUmYPpxDzcq2toPb6+i+Vm/VyE+DJVJ2lW+Dnb9Sp8t5QT05Dv4dlHjxcckzPT3IBmBnkyJ3gp6Y+HQxsHKm81+75DfXODjmtHmkYxYUu5r9DQD6XXEMxaxcc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376939; c=relaxed/simple; bh=7g/jARnkhTd3DIs23AFH73jSfHB7zbCwImSIcA8YsoQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Ohp3b8P+M6PxygPUx2BuQPkmewe8Maek9bds8ARAV7656EDfiyddE1Z+T6CvbPR3i8ZPLKPmq5OTIxXJQytffywvy7BDUAtgAR2KrgOA9dgWvM7dWzyvai/lxDuD8VUG2gp8yEwLefbqy7zIYBRN/NOCRH8Kgk//JLDe8LYdawo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=p7MMC0WY; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="p7MMC0WY" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-35a07c4b17dso2114498a91.2 for ; Tue, 24 Mar 2026 11:28:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774376937; x=1774981737; darn=lists.linux.dev; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=2MPILU45gcDsKK8jp+8jqoirIZBgcXX7ZY0CuqSl9cY=; b=p7MMC0WYCPcXlw3g+8tcE0QpCVybh2N90yBzSOEtv0daPKKYjFv0KYZ74ExXIxH90s S5BCIIhhyXaWpZz98qAsZb6eIbq/SmNcu6Fu6fr27CFAzmwe5eFcGTm5LtoKIeZVbQTW +U0s11s2vOZO8Bz4WpojrTUFYLxWaUe5waBeLd/0N7KNW6MTPIjjmVdLIGu7MrIRNtLJ pwzCUHXB2hOrB+9kHzgA635mzD+V05hjOrUKvIFe3eKjWbMNtWJYvaFjk7ySoMGr4Bcy Ne8VG3MM4l+D8DFBhUa/0WH9XRLvAHJMcOSXv33rk/YxG4Gu012uh8wWl5+PdttmYvJD TO7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774376937; x=1774981737; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=2MPILU45gcDsKK8jp+8jqoirIZBgcXX7ZY0CuqSl9cY=; b=cziW2e4aVbgyV8lIQndJ+47tb8jWjYB/GpmnQbOC84mdRUvZKnBCO9LJ9RcjvwX5Av jbvQCz9vbA9NjBsxRar/2TCkE4TlLvzmCmu048Ovb/r6ReClevO42K7/PXbEK/WXxm+H oEZz09gXy6KaS+IjQOwOTByauTtWhmeuvpRBlPiouXPa++prI4tuSOeAEyehBAlzSvBg bYg8VvX+xbRvHN6kpsRZk/sqg9AJOMv2WpGgr4NeEV7B1aEIQG+R8dtWbgt01+7Vaktw z1zYTclxzBFTso+APAVgZCS8jeuASpxwvYxtxacp1YDcdy4Wooi7mIJYyECqgOWYgE/E vKDw== X-Forwarded-Encrypted: i=1; AJvYcCWaD6r4OIVbo4DF9kl4ZruCZ/MIzZzZ6U+qbGfiZAI/0t1HgoonHxuLy3mkirzresV6rqZUyrCgXawILw==@lists.linux.dev X-Gm-Message-State: AOJu0YzgxwZgTQmfuKqPuQAkkdxurBIjiUL+MvrVyjLzysfmV1M7peKn 8jRa1AgO9wATFssGY47XXqSC+pRbO40QNeTaWxIwmzw3SVe/Oug2u/7F X-Gm-Gg: ATEYQzzLWd4fwyRk1HIR1yHpU635CeGoNmT9wdg+cCFbuxj3PTU00viGIgolE/Sb+fx jfeO2uj2pqTv7+1zei28/4uyLTQj+qMthekJYFEbZJGIbkssM17WnfPuhA6pK5tgTqUb9Fd3mbZ 0RMeWWMQjCI7QYmD5BGadA9ewDO0RsG9+hd4DZMsOIEJn6EjAYyXuGvvt2lHrvUNK8O9zyYpN/e PK7Re3ks/KxRvbu0W0QiE18i6Ept+HFz4DEDWcqorih7Ud5bteNsyF3GahWnFevWP21R5ICOwu8 wcXU7hacxwDMsrmLVYwYocw/inLiDuRPPhgVEzvB7C/86FK5a/TmRuHBnTtRGDvcK55wbFyPNIV o6K7zIX7GKh5VTV6sLi73DNRS1qKgySX2gpbHV8nvqHe3a9gmxGdBgtXyJUonQkIwoPktIGBB4y 0DBhE5pDrKSFzrT12dkR7ZG6KYHQ== X-Received: by 2002:a17:90b:3dc4:b0:35b:929f:7e8f with SMTP id 98e67ed59e1d1-35c0dd1000bmr297824a91.13.1774376937217; Tue, 24 Mar 2026 11:28:57 -0700 (PDT) Received: from [127.0.1.1] ([103.216.213.160]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c0d6060b5sm350576a91.17.2026.03.24.11.28.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 11:28:56 -0700 (PDT) From: Atharv Dubey Date: Tue, 24 Mar 2026 23:56:58 +0530 Subject: [PATCH 10/10] i2c: sis630: Replace dev_err() with dev_err_probe() in probe function Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20260324-deverr-v1-10-7e591cce33a3@gmail.com> References: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> In-Reply-To: <20260324-deverr-v1-0-7e591cce33a3@gmail.com> To: Till Harbaum , Andi Shyti , Laxman Dewangan , Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Pierre-Yves MORDRET , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Patrice Chotard , Orson Zhai , Baolin Wang , Chunyan Zhang , Jean Delvare Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, Enrico Zanda , Atharv Dubey X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774376818; l=2804; i=atharvd440@gmail.com; s=20260314; h=from:subject:message-id; bh=nhsfDSLdFe3nGX23EexwATKRFgvnwZsN/uRkVIgsfDc=; b=MfTL2nua2/UaTOkuHox/mofQ9uGkaQFwD4ef2QTeyEIJWKrK1affTlrqYL2fD+dQbiqZ2kQf1 368O9MeLyraCsNY7XiqbLSbdhihgwtkeZhLhsjgkAnvnbcpMTIg+zrj X-Developer-Key: i=atharvd440@gmail.com; a=ed25519; pk=T6i1xWOKT/RUSDYATSgyVG/4X7ac8jPjRSG1mMAcqVk= Status: O From: Enrico Zanda This simplifies the code while improving log. Signed-off-by: Enrico Zanda Signed-off-by: Atharv Dubey --- drivers/i2c/busses/i2c-sis630.c | 31 +++++++++++++------------------ 1 file changed, 13 insertions(+), 18 deletions(-) diff --git a/drivers/i2c/busses/i2c-sis630.c b/drivers/i2c/busses/i2c-sis630.c index a19c3d251804..3d0638c2bc51 100644 --- a/drivers/i2c/busses/i2c-sis630.c +++ b/drivers/i2c/busses/i2c-sis630.c @@ -431,24 +431,23 @@ static int sis630_setup(struct pci_dev *sis630_dev) in acpi io space and read acpi base addr */ if (pci_read_config_byte(sis630_dev, SIS630_BIOS_CTL_REG, &b)) { - dev_err(&sis630_dev->dev, "Error: Can't read bios ctl reg\n"); - retval = -ENODEV; + retval = dev_err_probe(&sis630_dev->dev, -ENODEV, + "Error: Can't read bios ctl reg\n"); goto exit; } /* if ACPI already enabled , do nothing */ if (!(b & 0x80) && pci_write_config_byte(sis630_dev, SIS630_BIOS_CTL_REG, b | 0x80)) { - dev_err(&sis630_dev->dev, "Error: Can't enable ACPI\n"); - retval = -ENODEV; + retval = dev_err_probe(&sis630_dev->dev, -ENODEV, + "Error: Can't enable ACPI\n"); goto exit; } /* Determine the ACPI base address */ if (pci_read_config_word(sis630_dev, SIS630_ACPI_BASE_REG, &acpi_base)) { - dev_err(&sis630_dev->dev, - "Error: Can't determine ACPI base address\n"); - retval = -ENODEV; + retval = dev_err_probe(&sis630_dev->dev, -ENODEV, + "Error: Can't determine ACPI base address\n"); goto exit; } @@ -469,11 +468,10 @@ static int sis630_setup(struct pci_dev *sis630_dev) /* Everything is happy, let's grab the memory and set things up. */ if (!request_region(smbus_base + SMB_STS, SIS630_SMB_IOREGION, sis630_driver.name)) { - dev_err(&sis630_dev->dev, - "I/O Region 0x%04x-0x%04x for SMBus already in use.\n", - smbus_base + SMB_STS, - smbus_base + SMB_STS + SIS630_SMB_IOREGION - 1); - retval = -EBUSY; + retval = dev_err_probe(&sis630_dev->dev, -EBUSY, + "I/O Region 0x%04x-0x%04x for SMBus already in use.\n", + smbus_base + SMB_STS, + smbus_base + SMB_STS + SIS630_SMB_IOREGION - 1); goto exit; } @@ -511,12 +509,9 @@ static int sis630_probe(struct pci_dev *dev, const struct pci_device_id *id) { int ret; - if (sis630_setup(dev)) { - dev_err(&dev->dev, - "SIS630 compatible bus not detected, " - "module not inserted.\n"); - return -ENODEV; - } + if (sis630_setup(dev)) + return dev_err_probe(&dev->dev, -ENODEV, + "Compatible bus not detected, module not inserted.\n"); /* set up the sysfs linkage to our parent device */ sis630_adapter.dev.parent = &dev->dev;