From patchwork Thu Oct 22 12:31:02 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 3690 Return-Path: X-Original-To: noreply@patchwork.local Delivered-To: noreply@patchwork.local Received: from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114]) by mxe881.netcup.net (Postfix) with ESMTPS id 2FA021C1F46 for ; Thu, 22 Oct 2026 14:34:05 +0200 (CEST) Authentication-Results: mxe881; dkim=pass header.d=kernel.org; spf=pass (sender IP is 172.105.105.114) smtp.mailfrom=linux-sunxi+bounces-26794-noreply=patchwork.local@lists.linux.dev smtp.helo=tor.lore.kernel.org Received-SPF: pass (mxe881: domain of lists.linux.dev designates 172.105.105.114 as permitted sender) client-ip=172.105.105.114; envelope-from=linux-sunxi+bounces-26794-noreply=patchwork.local@lists.linux.dev; helo=tor.lore.kernel.org; Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.77.114.92]) by tor.lore.kernel.org (Postfix) with ESMTP id 76584336A1 for ; Thu, 22 Oct 2026 12:34:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass header.oldest-pass=0 smtp.remote-ip=127.0.0.1 ARC-Seal: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=pass; t=1792672438; b=5q0e76GizfZkyDmBHeAkZzWlGX7wDcoLhXOwPoArz6ZtBwbJ5GraDTTFCWrlfajcqHbz +djcfcxOCx9jzasvu2ipxpqSpTPcYmPGaBJmLH/PtoKnjcF/+wVdNejJTjut1TUbNjNLP Pf8srY5KKbnhU4X0cpQPZ98LmZnXG/0OfHaTMuOph/fHJ8hB7VgGuUP59oFrDrDnkStVs Gh/M8OeTlV6GK+GCoDRMq8aqYtoSe+bAfvJTzZiTV5JpZg7pTkZL+bJEqH1+hBgSePbvg yD2Ohl/VpiHnXE9pF+hfu9KwP1n2Bq6mEXIOUV3OuiLpW+V4cdNHTIvm5qsx51rBXLw== ARC-Message-Signature: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792672438; h=X-Original-To:Received:Received:DKIM-Signature:From:Date:Subject: X-Mailing-List:List-Id:List-Post:List-Help:List-Subscribe: List-Unsubscribe:List-Owner:Precedence:MIME-Version:Content-Type: Content-Transfer-Encoding:Message-Id:References:In-Reply-To:To:Cc: X-Mailer:X-Developer-Signature:X-Developer-Key; bh=R5NqjsBtdfSlBxgApwXp7wa9JoQIf7G6bjvd02RO+To=; b=BL4SI0KHhcvafwlcoICpAiN0o6GWLdidj/0P3FnGxc6ORmWR1LFsihc3narsNCuvgSod yLb08VQZo+vt7UKDyUakgPsvNit70Zv52q+nlaPlxo4MEzPkKY0eju4NkNveudV1BGiAD Fzx/YOILVCzNx4PGESABWgfQDIE0BVSQqinhDiuUSHaIHRGddFo91x6rmwFOgNSi8qrbm TSe11Dp3mr4ZV+J9Z1yvDyiprrm+yD6nMueWVz9pqxvE8blpipci6EjLpno1nYkU8HWfq 3diecyw3zmx6mOcN8Hlt9CRAXcriVYSQ6SDn4AjmCP2FUbwoBUI6+O1cLyeJNecPWSw== ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=XG0gN8fW; arc=pass header.oldest-pass=0 smtp.remote-ip=127.0.0.1 Received: from localhost.localdomain (localhost [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BFF9B606A31E; Thu, 22 Oct 2026 12:33:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=XG0gN8fW X-Original-To: linux-sunxi@lists.linux.dev Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792672438; b=ndMx0OoMwlcepgOc3nFTp9QzlSonXgfGaEpX8RV52LGK+F6/mbtQ85GqC9DGTFFqOmbS zBAcUCTAIoY86kgQW7CLs5ogfdNV+cqk5pLrIjgJ32sS79TmOF4N66yxXC7wLgSIvJcIA Ck8WcKDqPJXXyPm7E/1NUdSGDwKuI1t9R/j65YX6I5S6zJ+zIx4ONelCMsL0hbOe6kCB7 DFPgsAjqjtC8qRTpU+MU6p2pgDILYdBzHLeizoewjyYwq0iIvMXVwzl0Fjo6PdehRD4od GYDsJHouQnirz1xWHAsgVdZECGKQcLo11i5+XQAH6D5oIZJDnR4U5Ait29k79DtaJ+w== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792672438; h=Received:DKIM-Signature:From:Date:Subject:MIME-Version:Content-Type: Content-Transfer-Encoding:Message-Id:References:In-Reply-To:To:Cc: X-Mailer:X-Developer-Signature:X-Developer-Key; bh=R5NqjsBtdfSlBxgApwXp7wa9JoQIf7G6bjvd02RO+To=; b=UXsVdOIMyIyW4QUMOmd4GbUAhK7qnfzwNGr7hzki2zJiP8BjUnR7hQp6OalzsVIIGhCo PbyhgmSbRGsuTsXYYx1W4xWCGC5jt2EfGY8IaN0JQXqfObqgDqPT2qjkkOjLmQtngv7HK TM2pT3ug+Txezh0w7nqc/1YMkG5AYjYSWSWSm+h2ZqdGZWsig3MambGdPnSihlt76xEbQ Eh4AopEeRRccn/dwb2EGS9VvoSQQyY8pucvZ0x55opMPyMqni1G+h6vqZvrplHCLsRgvT Jkb33tdT1gVdX7PtqPwBOwhGHnQjrL8wL3+7U1ivUN7cAlQJTEO1WeK8yvE7u7kgglg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=XG0gN8fW; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6148C606A319 for ; Thu, 22 Oct 2026 12:33:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 86F5B1F000C3; Thu, 22 Oct 2026 12:33:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792672438; bh=R5NqjsBtdfSlBxgApwXp7wa9JoQIf7G6bjvd02RO+To=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=XG0gN8fWDlyEoORJM9sSAOwW8Qf0rV7hZIISN56tWT1/z3daT+Kq7Bt/JmfAtOSEY BCTAgMZF2fwBJvVzsSZI3vTnU78SmEm2kg6vNEBgHiEkiQgtHJJSJhW2ZJcxZ8I13W mKQgEfZ9okkd330sFutQ27OW1q4zM9osF8eudipU2pDVwykX9uTMrOlWM25QAarBXz jGNNi7fp6fdl1v/bTgxnNYeKwgnSnaOkthxQJeN/QYdaIdxpPAiagk3terbNoGmZku uFOlP6JKAjZDZwiuknxeMWJXxg9nBnj25FldGjLUF++OB+3oZSko+L8LCbC/bg+g83 TNsLXWGyyGuvw== From: Maxime Ripard Date: Thu, 22 Oct 2026 14:31:02 +0200 Subject: [PATCH v2 03/59] drm/atomic-state-helper: Rename connector_tv_reset to state_init X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Message-Id: <20261022-drm-no-more-connector-reset-v2-3-0b7e4e85b1e8@kernel.org> References: <20261022-drm-no-more-connector-reset-v2-0-0b7e4e85b1e8@kernel.org> In-Reply-To: <20261022-drm-no-more-connector-reset-v2-0-0b7e4e85b1e8@kernel.org> To: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, Maxime Ripard , =?utf-8?q?Ma=C3=ADra_Canal?= , Chen-Yu Tsai , Dave Stevenson , Raspberry Pi Kernel Maintenance , Samuel Holland , linux-sunxi@lists.linux.dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=4565; i=mripard@kernel.org; h=from:subject:message-id; bh=4UEBRjahnLkdgx7ZqR/1VzPz62Lw2lvUFE2DNgvNxQo=; b=owGbwMvMwCmsHn9OcpHtvjLG02pJDFm3mPq2/Gd78sBJLX/KhosfrPxCFidzTC6tXOdj++Qri 1euwfTvHVNZGIQ5GWTFFFmeyISdXt6+uMrBfuUPmDmsTCBDGLg4BWAi3JMYG7avuqMZcEj0W1q4 u4NveHnVDhaZzQXTtD/teXo+/dWlZo7+mnsXnriWr2TcuPzO+vncExnrDN7I1a1kmHDx8evP3Qe dXh5Lep8f8kai+f7qQudyo3rhz52TzKu50qtv+MoFTb6k1fQGAA== X-Developer-Key: i=mripard@kernel.org; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-Rspamd-Server: rspamd-worker-8404 X-Spamd-Result: default: False [1.81 / 15.00]; RBL_SENDERSCORE(2.00)[172.105.105.114:from]; MAILLIST(-0.18)[generic]; MIME_GOOD(-0.10)[text/plain]; BAD_REP_POLICIES(0.10)[]; HAS_LIST_UNSUB(-0.01)[]; FROM_NEQ_ENVFROM(0.00)[mripard@kernel.org,linux-sunxi@lists.linux.dev]; RCVD_COUNT_FIVE(0.00)[5]; R_DKIM_ALLOW(0.00)[kernel.org:s=k20260515]; FROM_HAS_DN(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_TWELVE(0.00)[12]; ASN(0.00)[asn:63949, ipnet:172.105.96.0/20, country:SG]; DBL_BLOCKED_OPENRESOLVER(0.00)[tor.lore.kernel.org:helo,tor.lore.kernel.org:rdns,linux.dev:email,igalia.com:email]; FORGED_SENDER_MAILLIST(0.00)[]; TAGGED_FROM(0.00)[bounces-26794-noreply=patchwork.local]; ARC_ALLOW(0.00)[subspace.kernel.org:s=arc20261015:i=2]; R_SPF_ALLOW(0.00)[+ip4:172.105.105.114]; DKIM_TRACE(0.00)[kernel.org:+]; TO_DN_SOME(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[100.103.45.18:received,100.77.114.92:received]; MID_RHS_MATCH_FROM(0.00)[]; DMARC_POLICY_ALLOW(0.00)[kernel.org,quarantine]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; FREEMAIL_TO(0.00)[linux.intel.com,suse.de,gmail.com,ffwll.ch]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[172.105.105.114:from] X-Rspamd-Queue-Id: 2FA021C1F46 X-MORS-Enabled: yes X-MORS-DOMAIN: patchwork.local X-MORS-HOSTING: hosting172546 X-MORS-USER: hosting172546 X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= Recent commits renamed other reset helpers to use the state_init suffix when they only initialize properties rather than allocate or update the object state itself. drm_atomic_helper_connector_tv_reset() falls in the same category: it initializes the analog TV properties from the kernel command line defaults without allocating any state. It also reads the connector state through connector->state, coupling it to the reset path. Rename it to drm_atomic_helper_connector_tv_state_init() and pass the connector state explicitly as a parameter. This decouples it from the reset hook and prepares for the conversion to atomic_create_state where connector->state is not yet assigned. Signed-off-by: Maxime Ripard Reviewed-by: Maíra Canal --- Cc: "Maíra Canal" Cc: Chen-Yu Tsai Cc: Dave Stevenson Cc: Raspberry Pi Kernel Maintenance Cc: Samuel Holland Cc: linux-sunxi@lists.linux.dev --- drivers/gpu/drm/drm_atomic_state_helper.c | 13 +++++++------ drivers/gpu/drm/sun4i/sun4i_tv.c | 2 +- drivers/gpu/drm/vc4/vc4_vec.c | 2 +- include/drm/drm_atomic_state_helper.h | 3 ++- 4 files changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_state_helper.c b/drivers/gpu/drm/drm_atomic_state_helper.c index 565947c544fe..3534925636d5 100644 --- a/drivers/gpu/drm/drm_atomic_state_helper.c +++ b/drivers/gpu/drm/drm_atomic_state_helper.c @@ -502,14 +502,15 @@ EXPORT_SYMBOL(drm_atomic_helper_connector_tv_margins_state_init); /** - * drm_atomic_helper_connector_tv_reset - Resets Analog TV connector properties + * drm_atomic_helper_connector_tv_state_init - Initializes Analog TV connector properties + * @state: the DRM state object * @connector: DRM connector * - * Resets the analog TV properties attached to a connector + * Initializes the analog TV properties attached to a connector */ -void drm_atomic_helper_connector_tv_reset(struct drm_connector *connector) +void drm_atomic_helper_connector_tv_state_init(struct drm_connector_state *state, + struct drm_connector *connector) { struct drm_device *dev = connector->dev; struct drm_cmdline_mode *cmdline = &connector->cmdline_mode; - struct drm_connector_state *state = connector->state; struct drm_property *prop; uint64_t val; @@ -572,7 +573,7 @@ void drm_atomic_helper_connector_tv_reset(struct drm_connector *connector) state->tv.hue = val; - drm_atomic_helper_connector_tv_margins_state_init(connector->state, connector); + drm_atomic_helper_connector_tv_margins_state_init(state, connector); } -EXPORT_SYMBOL(drm_atomic_helper_connector_tv_reset); +EXPORT_SYMBOL(drm_atomic_helper_connector_tv_state_init); /** diff --git a/drivers/gpu/drm/sun4i/sun4i_tv.c b/drivers/gpu/drm/sun4i/sun4i_tv.c index ce22f1662c0c..ea86f8a6a35e 100644 --- a/drivers/gpu/drm/sun4i/sun4i_tv.c +++ b/drivers/gpu/drm/sun4i/sun4i_tv.c @@ -409,5 +409,5 @@ static void sun4i_tv_connector_reset(struct drm_connector *connector) { drm_atomic_helper_connector_reset(connector); - drm_atomic_helper_connector_tv_reset(connector); + drm_atomic_helper_connector_tv_state_init(connector->state, connector); } diff --git a/drivers/gpu/drm/vc4/vc4_vec.c b/drivers/gpu/drm/vc4/vc4_vec.c index 215b5d3dc5c5..7ab77f97df31 100644 --- a/drivers/gpu/drm/vc4/vc4_vec.c +++ b/drivers/gpu/drm/vc4/vc4_vec.c @@ -381,5 +381,5 @@ static void vc4_vec_connector_reset(struct drm_connector *connector) { drm_atomic_helper_connector_reset(connector); - drm_atomic_helper_connector_tv_reset(connector); + drm_atomic_helper_connector_tv_state_init(connector->state, connector); } diff --git a/include/drm/drm_atomic_state_helper.h b/include/drm/drm_atomic_state_helper.h index 4dac741af22c..5e8619aeef21 100644 --- a/include/drm/drm_atomic_state_helper.h +++ b/include/drm/drm_atomic_state_helper.h @@ -72,5 +72,6 @@ void drm_atomic_helper_connector_reset(struct drm_connector *connector); struct drm_connector_state * drm_atomic_helper_connector_create_state(struct drm_connector *connector); -void drm_atomic_helper_connector_tv_reset(struct drm_connector *connector); +void drm_atomic_helper_connector_tv_state_init(struct drm_connector_state *state, + struct drm_connector *connector); int drm_atomic_helper_connector_tv_check(struct drm_connector *connector, struct drm_atomic_commit *state); From patchwork Thu Oct 22 12:31:28 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 3692 Return-Path: X-Original-To: noreply@patchwork.local Delivered-To: noreply@patchwork.local Received: from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114]) by mxe881.netcup.net (Postfix) with ESMTPS id DF3E01C1F3C for ; Thu, 22 Oct 2026 14:37:04 +0200 (CEST) Authentication-Results: mxe881; dkim=pass header.d=kernel.org; spf=pass (sender IP is 172.105.105.114) smtp.mailfrom=linux-sunxi+bounces-26795-noreply=patchwork.local@lists.linux.dev smtp.helo=tor.lore.kernel.org Received-SPF: pass (mxe881: domain of lists.linux.dev designates 172.105.105.114 as permitted sender) client-ip=172.105.105.114; envelope-from=linux-sunxi+bounces-26795-noreply=patchwork.local@lists.linux.dev; helo=tor.lore.kernel.org; Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.77.114.92]) by tor.lore.kernel.org (Postfix) with ESMTP id 26C3A371E7 for ; Thu, 22 Oct 2026 12:35:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass header.oldest-pass=0 smtp.remote-ip=127.0.0.1 ARC-Seal: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=pass; t=1792672531; b=bekpaESV0qZ7AVk2G0ZSb7ULRKYaqEWwhWz2rdlSBJyGVri9DdVec/6HxYrMXB4OFzRs Xp4eJZIyXia4tP+mGSa9VkpjP9D4R4Mccy6tSg2ef+yCeV2ZbccB27yNrtug5bRDQZF6P B1L8byjl414n/Lp//e3cDk8boV/YOT0+wiT+cqbLrfoKTWf7wO9MAOt6sRFuSZVy7Zctu cnNASkDbl5vjSbf8FfRgntT9ymQTWNHV8jx/iMnN0PMJ2zIL2aeOB4T90UnA+C1Z3Y6pQ tWQ9aXwXGV80H4it04T58ZV7bUyc//vkCQr1XKYDkQNyOkgxresJEFbnN4/9MIjpdHA== ARC-Message-Signature: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792672531; h=X-Original-To:Received:Received:DKIM-Signature:From:Date:Subject: X-Mailing-List:List-Id:List-Post:List-Help:List-Subscribe: List-Unsubscribe:List-Owner:Precedence:MIME-Version:Content-Type: Content-Transfer-Encoding:Message-Id:References:In-Reply-To:To:Cc: X-Mailer:X-Developer-Signature:X-Developer-Key; bh=oc0PrDV8DEK9WJ2O0W/WsptT1VrI37wtjGjJETAFueg=; b=R1PkxXoHQm63wQF8tCXGDNJnyIhZzSGudARQwOMxJ4qeAVMC4O9MN/FUHKHyn8HyaiDk ZmbKbj+nX86qLw2M8hV9sCZAdqw3LUaP6vHu7FIkF7SMMHFFGAYjEXvQv/YWD5YDD0C3C z8NKXztSNVLBsL4BiPChS7xkiU22NAxhH5UV2bRgEKE9C4fVB/Lb3td8lKIsnLlI/3GjH Q1brJPrf1R6V1OI6DsSIk2kI/j0cZa/B86rHtCTjJBqOyImWtqU2gqU1bQk7fByrhEFav dEFTyeXmA6XwQTKNFC1A05oQm9lb37lCsvhwh2sr1ya2Q2BDnhAYKARM9JuFmsoCSGg== ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=lZvpiEef; arc=pass header.oldest-pass=0 smtp.remote-ip=127.0.0.1 Received: from localhost.localdomain (localhost [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 88820606A319; Thu, 22 Oct 2026 12:35:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=lZvpiEef X-Original-To: linux-sunxi@lists.linux.dev Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792672531; b=xIsMlgafFI9Vvmlg72LyESU+STNE4ejw7kTZCZoMxGBjTNAiXhE+QzpFUbed2gNNHf15 j51PeJgRKWJ5fdYNS5fkjaKdDngS9g30P1rh3ZQwXy5MDNiBK6zxjsgiUR2uzS0mt5Gt5 bm7qq3TXKX+LRdHYAK/SnVxk46a0BWwd4usAF4lDQvmQS12euGWCNQfSXtLCNUlzV5tGW BIyFWs6FL282lxltVJ2ENegTMtnMFN6ikWDFo9ORYAGaB/YQiIaiYCFnH2uYcUeUzBnZf 8xIv02vMGmmg/7MyHYhnyZ3GhGzGI0rbj6snGFOJqwGJ+lgYlkkbp54h7ksfrtjBMlg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792672531; h=Received:DKIM-Signature:From:Date:Subject:MIME-Version:Content-Type: Content-Transfer-Encoding:Message-Id:References:In-Reply-To:To:Cc: X-Mailer:X-Developer-Signature:X-Developer-Key; bh=oc0PrDV8DEK9WJ2O0W/WsptT1VrI37wtjGjJETAFueg=; b=KXUolIBWpA/JBIoDGQ1okGjJkycKoSnDqmiR5QLO+kcRvs7uhoiZQrBVLAqiZITt3wUT wOMIB54n4Kkaer92fflXG6G7mv4LyB/iHHZ9B1SJvliKkzRqn2QaFc5u9eTM8nR5hb9FA 99jLpLdYp0U5blu7KdnPEQt9mgJpNK+OFN2tKBIT4MF4X17RiOWgbDS/LjXz1iexQYsgl +xUJGh6iu7VausNO6FZdhB4mXf0jnpSHVTwB3pE8/UdLsxIMgq+LO/sxAlmMS4rrh2/ao 1st2ltoXUrSne7VTtask8IyVxCPhKnH5C2Y1/q4qTUv5RA3gFtbdJQE/N0emV31zAlA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=lZvpiEef; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B0DF606A31A for ; Thu, 22 Oct 2026 12:35:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 824891F000C2; Thu, 22 Oct 2026 12:35:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792672531; bh=oc0PrDV8DEK9WJ2O0W/WsptT1VrI37wtjGjJETAFueg=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=lZvpiEefz+J1z7asoaUVeevFYmJ0ilsklS3JSRCWHN9idEqjaw1ZfWg8klXPQKKU2 4gtD8fr2LB4aNvKEVAsy5HmNGezDXG3IO/eI4JpyPRUB/ZAaH7jhE4IM1ya9LKgniX OilP20IZTfxRomwB790JM2seButz6cZTR1YWNdC/8Sotf2APBQeU2c5NLhHBCzZWEv +SOFv9VYADXVPv6pq7FzcfRgcACZO+CkQn//jboED+lhqww8jWKnxkv11CqhG3udZK cUgxIQVoDrytfgXteeqtiwKPpl+7LeNm5oPJHRsnnt9PpbhiC9JzHAwiHJ1T6vYqsd M4Fla1ZnLXV7Q== From: Maxime Ripard Date: Thu, 22 Oct 2026 14:31:28 +0200 Subject: [PATCH v2 29/59] drm/sun4i: Switch to drm_atomic_helper_connector_create_state X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Message-Id: <20261022-drm-no-more-connector-reset-v2-29-0b7e4e85b1e8@kernel.org> References: <20261022-drm-no-more-connector-reset-v2-0-0b7e4e85b1e8@kernel.org> In-Reply-To: <20261022-drm-no-more-connector-reset-v2-0-0b7e4e85b1e8@kernel.org> To: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, Maxime Ripard , Chen-Yu Tsai , Samuel Holland , linux-sunxi@lists.linux.dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2555; i=mripard@kernel.org; h=from:subject:message-id; bh=WhXdr0caQxsD2xQ8xxnX9ce6ERhKkrPc/zQA/D7z/Z0=; b=owGbwMvMwCmsHn9OcpHtvjLG02pJDFm3mGZtK9motz3I+YikXsFPt5DEgph45gMi1yuez36gX vVwSdLyjqksDMKcDLJiiixPZMJOL29fXOVgv/IHzBxWJpAhDFycAjARwxzG+srFU1b1/LZzr5nG e/bCHf/iJBPW6c8Uj8wpMk3RC3v46HP+tI4m/gWbFdpeKzDPrl5nwVgfeX5Nqd+E9w6ck9f0OIT J/i1YHjWdxZRdqm2h04VwnyUnC5JDFW5tKNx9TOtM7ZeWJVcB X-Developer-Key: i=mripard@kernel.org; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-MORS-Enabled: yes X-MORS-DOMAIN: patchwork.local X-MORS-HOSTING: hosting172546 X-MORS-USER: hosting172546 X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= The sun4i connector implementation uses the deprecated drm_atomic_helper_connector_reset() as its reset hook. Switch to drm_atomic_helper_connector_create_state() instead. Signed-off-by: Maxime Ripard --- Cc: Chen-Yu Tsai Cc: Samuel Holland Cc: linux-sunxi@lists.linux.dev --- drivers/gpu/drm/sun4i/sun4i_lvds.c | 2 +- drivers/gpu/drm/sun4i/sun4i_rgb.c | 2 +- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_lvds.c b/drivers/gpu/drm/sun4i/sun4i_lvds.c index 6b98d20a8890..f3f035c9260f 100644 --- a/drivers/gpu/drm/sun4i/sun4i_lvds.c +++ b/drivers/gpu/drm/sun4i/sun4i_lvds.c @@ -66,5 +66,5 @@ static const struct drm_connector_funcs sun4i_lvds_con_funcs = { .fill_modes = drm_helper_probe_single_connector_modes, .destroy = sun4i_lvds_connector_destroy, - .reset = drm_atomic_helper_connector_reset, + .atomic_create_state = drm_atomic_helper_connector_create_state, .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state, .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, diff --git a/drivers/gpu/drm/sun4i/sun4i_rgb.c b/drivers/gpu/drm/sun4i/sun4i_rgb.c index 3da9a9283c6e..c930dd899875 100644 --- a/drivers/gpu/drm/sun4i/sun4i_rgb.c +++ b/drivers/gpu/drm/sun4i/sun4i_rgb.c @@ -157,5 +157,5 @@ static const struct drm_connector_funcs sun4i_rgb_con_funcs = { .fill_modes = drm_helper_probe_single_connector_modes, .destroy = sun4i_rgb_connector_destroy, - .reset = drm_atomic_helper_connector_reset, + .atomic_create_state = drm_atomic_helper_connector_create_state, .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state, .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c index d504ae583294..1b7ae9b327c1 100644 --- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c +++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c @@ -838,5 +838,5 @@ static const struct drm_connector_funcs sun6i_dsi_connector_funcs = { .fill_modes = drm_helper_probe_single_connector_modes, .destroy = drm_connector_cleanup, - .reset = drm_atomic_helper_connector_reset, + .atomic_create_state = drm_atomic_helper_connector_create_state, .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state, .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, From patchwork Thu Oct 22 12:31:46 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 3691 Return-Path: X-Original-To: noreply@patchwork.local Delivered-To: noreply@patchwork.local Received: from sto.lore.kernel.org (sto.lore.kernel.org [172.232.135.74]) by mxe881.netcup.net (Postfix) with ESMTPS id 6CA5E1C1F20 for ; Thu, 22 Oct 2026 14:36:38 +0200 (CEST) Authentication-Results: mxe881; dkim=pass header.d=kernel.org; spf=pass (sender IP is 172.232.135.74) smtp.mailfrom=linux-sunxi+bounces-26796-noreply=patchwork.local@lists.linux.dev smtp.helo=sto.lore.kernel.org Received-SPF: pass (mxe881: domain of lists.linux.dev designates 172.232.135.74 as permitted sender) client-ip=172.232.135.74; envelope-from=linux-sunxi+bounces-26796-noreply=patchwork.local@lists.linux.dev; helo=sto.lore.kernel.org; Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.77.114.92]) by sto.lore.kernel.org (Postfix) with ESMTP id 76863604A5E for ; Thu, 22 Oct 2026 12:36:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass header.oldest-pass=0 smtp.remote-ip=127.0.0.1 ARC-Seal: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=pass; t=1792672596; b=2pki/PTYnKt3jTVpfAOpcC201PhzC1wNqNFehEEtBwflpaGhcaGNl7I7XD13lKPpsLYX /Zyz8GwVg8TpRrkddf6MbvHpjf23seWLWidT2Kmiei6JB8XfPJjOBw3j1KgqsGoolOeVp 8ORq/GPFAjRgQ0opx79SOTk1fvDDZeJJtn4A18AC283ci6WJaowNe0RUl+XMsfbaSCy8m 3aqRC7aQfhdOwXcp3NW1cAUWIe6ya9ld102pxToj7u+E/CsGnzuYKIZLK4z31qwWM7wZr 3C9xfIjRz5TlI2/NH2Z06O1ly93GCJNYJDKDIs9b1hZeCGDQM3G5eD8sTlvvf+eQOag== ARC-Message-Signature: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792672596; h=X-Original-To:Received:Received:DKIM-Signature:From:Date:Subject: X-Mailing-List:List-Id:List-Post:List-Help:List-Subscribe: List-Unsubscribe:List-Owner:Precedence:MIME-Version:Content-Type: Content-Transfer-Encoding:Message-Id:References:In-Reply-To:To:Cc: X-Mailer:X-Developer-Signature:X-Developer-Key; bh=LUcl12gwkN8B7VfualkhTFi3SbBn5mj0wBC5eClpxhE=; b=VapB+j2G4UhQsrPq4ZxJ3avjTHdgK8gIwMKovCC16Oxn5VXAw7h8io+rUHvnWvtAyy7V 2Q2ulxgCUa7tKGFlPhzKC7Fk++4LkKc+0dJijQR1uOeR19/cda8S7MJLbsJA6D+h0oJKP adkVApxrmFIUHsuO0kRL1g+W70KVNgD8upu5ivjtpAfjIpdD4/W7iUtWJZXVDFWj0+Vi7 1AetDdXJwIi4tlAfz8PkOFDz0VeMozUxRVGJjfH3cyV4ACeS25HxlVhwnaEyO3A8c6H7a vJZYKvl0nSlKD21hlI6vADxCURh4TeWn57LQa3Lqq4+lXPKXa8cZ0fX8wLCZ1vnewXg== ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=cswfRlBX; arc=pass header.oldest-pass=0 smtp.remote-ip=127.0.0.1 Received: from localhost.localdomain (localhost [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 580FF606A31A; Thu, 22 Oct 2026 12:36:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=cswfRlBX X-Original-To: linux-sunxi@lists.linux.dev Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792672596; b=ZA+7OGMqOREH6bfNq3yv5P6+QFgumTaI2oVLbEtabRf3MDf/oXbkJGxyp27ztyqxh7py EOxdvWzKD4lxCAkp+ivCIbH1Qxy+w1ySmLrXy+wLqQrUW8jCrcXl3FbNA3dsbIORVxjW9 qe0Vx//hDOQ7A4QuHTmg88GRKtu7Mes7rb8WOpL/dJQyf76LSa+Zm4RmmX0xSKBM7MVcD i7lxERJD993SB/GxTgCum57I9fPqPvBQ+CuS2mO6AJ5m88+/nEuFJxFKgbgO3E5Njn7PN pc+K0XL5+slleRq6qxz6laeILcu5aY++3S9h5Upveg87RIEhHrZIwR2As0OyggtwKRQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792672596; h=Received:DKIM-Signature:From:Date:Subject:MIME-Version:Content-Type: Content-Transfer-Encoding:Message-Id:References:In-Reply-To:To:Cc: X-Mailer:X-Developer-Signature:X-Developer-Key; bh=LUcl12gwkN8B7VfualkhTFi3SbBn5mj0wBC5eClpxhE=; b=IFKZ31HA6V0TER7xODU+3Hz9YPgQAK2w1mPGxvZm7a4Wo+8CHqfxetohQU6+K7UTERlv ZnBHsigsvh71hUiPfHIekL3z8Qj3+9HuP3+VihS/P0BSsiXTm0iSzkBN9i+uzKeR8v2Gh 1IahEwkSsYZWKXfO8YOzQTtYwxkKLKYaQyGbmNy8geYyPAHahKZVsHYVNnhH1HJPqhXnX Z+Skna3Vig7znOg3wbP/IRHKih6Lzk9PtTTP4A8+VOWSjQ0v23DdFlcpnivDZnlikX+/D jGrM87z+/DAYiNYQ/BcA/HjDEkXHTFryp+crTOukUKNOM455cFTNjazsOmrEmG5VXCQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=cswfRlBX; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F14C5606A319 for ; Thu, 22 Oct 2026 12:36:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1AEFE1F000C1; Thu, 22 Oct 2026 12:36:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792672595; bh=LUcl12gwkN8B7VfualkhTFi3SbBn5mj0wBC5eClpxhE=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=cswfRlBXSmu5Mf4wULxcuKDDwWwZVpnZtPbJVn+Pnn3Mx9bV8cUq9FrPs65Kj2udo j8r7bdY2G57A9CICKPS7OVn5H0rwEqnTtdMvl3EL0JCnNAO0VHXznJKm3buV2UmJzC 0qi5iG0XoRnGTfHuhbiv2vBpuig9rabuUbo5un5scReQcaWfey6CeRLcIBZ/iVRil5 ArUy6XZAMYYhFI1oTQ9bfHIPrtU4KAwXFvCBu1EnOmMyYMc64za2IZQ2XzZvwO4Mtw yK6U468EmHmA8WtO4inedGH+LCxyH6YS7VUr5WllA3nfEHGJ9UbUPQBZNic24cu6yU TjM4k/zpMaUGg== From: Maxime Ripard Date: Thu, 22 Oct 2026 14:31:46 +0200 Subject: [PATCH v2 47/59] drm/sun4i: hdmi: Convert to atomic_create_state X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Message-Id: <20261022-drm-no-more-connector-reset-v2-47-0b7e4e85b1e8@kernel.org> References: <20261022-drm-no-more-connector-reset-v2-0-0b7e4e85b1e8@kernel.org> In-Reply-To: <20261022-drm-no-more-connector-reset-v2-0-0b7e4e85b1e8@kernel.org> To: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, Maxime Ripard , Chen-Yu Tsai , Samuel Holland , linux-sunxi@lists.linux.dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2001; i=mripard@kernel.org; h=from:subject:message-id; bh=w9nESPjYXbVij1sc0qXET6/o4C+Z94CFJROMxWaY4s4=; b=owGbwMvMwCmsHn9OcpHtvjLG02pJDFm3mBbFnSo1su/UKjKwK88JnW+9uFD55b0lVndrhT37l yRfWhXSMZWFQZiTQVZMkeWJTNjp5e2LqxzsV/6AmcPKBDKEgYtTACZyWoOxVlQua5f721N//mTX hq+f/KHPlW3lSUsxKZ/QlSc0OpjX35m5XMdk9R+xcvdpna7H2E5/Y2yYdHfzm/tPVU/3BQslOGx 7diA41M5RPIJB65iMsNa07Iq/bJobmHcs2fFa7XFegfblZk4A X-Developer-Key: i=mripard@kernel.org; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-Rspamd-Server: rspamd-worker-8404 X-Spamd-Result: default: False [1.81 / 15.00]; RBL_SENDERSCORE(2.00)[172.232.135.74:from]; MAILLIST(-0.18)[generic]; MIME_GOOD(-0.10)[text/plain]; BAD_REP_POLICIES(0.10)[]; HAS_LIST_UNSUB(-0.01)[]; FROM_NEQ_ENVFROM(0.00)[mripard@kernel.org,linux-sunxi@lists.linux.dev]; RCVD_VIA_SMTP_AUTH(0.00)[]; ASN(0.00)[asn:63949, ipnet:172.232.128.0/19, country:SG]; RCVD_COUNT_FIVE(0.00)[5]; FROM_HAS_DN(0.00)[]; TAGGED_FROM(0.00)[bounces-26796-noreply=patchwork.local]; R_DKIM_ALLOW(0.00)[kernel.org:s=k20260515]; DBL_BLOCKED_OPENRESOLVER(0.00)[sholland.org:email,sto.lore.kernel.org:helo,sto.lore.kernel.org:rdns,linux.dev:email]; FORGED_SENDER_MAILLIST(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; R_SPF_ALLOW(0.00)[+ip4:172.232.135.74]; DKIM_TRACE(0.00)[kernel.org:+]; TO_DN_SOME(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[100.103.45.18:received,100.77.114.92:received]; ARC_ALLOW(0.00)[subspace.kernel.org:s=arc20261015:i=2]; DMARC_POLICY_ALLOW(0.00)[kernel.org,quarantine]; FREEMAIL_TO(0.00)[linux.intel.com,suse.de,gmail.com,ffwll.ch]; RCPT_COUNT_SEVEN(0.00)[9]; MIME_TRACE(0.00)[0:+]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[172.232.135.74:from] X-Rspamd-Queue-Id: 6CA5E1C1F20 X-MORS-Enabled: yes X-MORS-DOMAIN: patchwork.local X-MORS-HOSTING: hosting172546 X-MORS-USER: hosting172546 X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= The sun4i HDMI connector reset implementation creates a pristine state and initializes the HDMI state. It does not perform any hardware reset. Since this is equivalent to what atomic_create_state expects, convert the reset function to an atomic_create_state hook that returns the initialized state. Signed-off-by: Maxime Ripard --- Cc: Chen-Yu Tsai Cc: Samuel Holland Cc: linux-sunxi@lists.linux.dev --- drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c index 3084f6570c29..58626d0562ae 100644 --- a/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c +++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c @@ -291,9 +291,17 @@ sun4i_hdmi_connector_detect(struct drm_connector *connector, bool force) } -static void sun4i_hdmi_connector_reset(struct drm_connector *connector) +static struct drm_connector_state * +sun4i_hdmi_connector_create_state(struct drm_connector *connector) { - drm_atomic_helper_connector_reset(connector); - __drm_atomic_helper_connector_hdmi_state_init(connector->state, + struct drm_connector_state *connector_state; + + connector_state = drm_atomic_helper_connector_create_state(connector); + if (IS_ERR(connector_state)) + return connector_state; + + __drm_atomic_helper_connector_hdmi_state_init(connector_state, connector); + + return connector_state; } @@ -302,5 +310,5 @@ static const struct drm_connector_funcs sun4i_hdmi_connector_funcs = { .detect = sun4i_hdmi_connector_detect, .fill_modes = drm_helper_probe_single_connector_modes, - .reset = sun4i_hdmi_connector_reset, + .atomic_create_state = sun4i_hdmi_connector_create_state, .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state, .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, From patchwork Thu Oct 22 12:31:47 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 3693 Return-Path: X-Original-To: noreply@patchwork.local Delivered-To: noreply@patchwork.local Received: from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114]) by mxe881.netcup.net (Postfix) with ESMTPS id 362C01C0120 for ; Thu, 22 Oct 2026 14:37:18 +0200 (CEST) Authentication-Results: mxe881; dkim=pass header.d=kernel.org; spf=pass (sender IP is 172.105.105.114) smtp.mailfrom=linux-sunxi+bounces-26797-noreply=patchwork.local@lists.linux.dev smtp.helo=tor.lore.kernel.org Received-SPF: pass (mxe881: domain of lists.linux.dev designates 172.105.105.114 as permitted sender) client-ip=172.105.105.114; envelope-from=linux-sunxi+bounces-26797-noreply=patchwork.local@lists.linux.dev; helo=tor.lore.kernel.org; Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.77.114.92]) by tor.lore.kernel.org (Postfix) with ESMTP id 8365E2FFFE for ; Thu, 22 Oct 2026 12:36:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass header.oldest-pass=0 smtp.remote-ip=127.0.0.1 ARC-Seal: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=pass; t=1792672600; b=SzsheHWhG3spPVwZ/5FNWMKEAWVS7DOYe3jIttl0uiyQIHAjnvFnsRBBnqDBeG12TNRw nX8BcUfiwhxw1JKDqdkkkdUrA4Wi8gzRRhNmqBGhRzfJtM4UR6ZpyEI18AtOfqLk2mCJf M6hB9uBS77odIQDshKz9ScrsaxRwD1P2BszcgsUqwRG6jRVxxAua47JJYjNgUHSxrePFS /7dKoPlxCTgvd4nxXs9QZvq4A3VhT9GBgCAqg+sjlBL/fQDL7XTRFQ5lcnd1hgbTDWQK7 uisV+AtOTEplmlahRJb57MYDskNMLbS90pps2vPK6rbndZmuOl+jMopXKF7abVVNYnw== ARC-Message-Signature: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792672600; h=X-Original-To:Received:Received:DKIM-Signature:From:Date:Subject: X-Mailing-List:List-Id:List-Post:List-Help:List-Subscribe: List-Unsubscribe:List-Owner:Precedence:MIME-Version:Content-Type: Content-Transfer-Encoding:Message-Id:References:In-Reply-To:To:Cc: X-Mailer:X-Developer-Signature:X-Developer-Key; bh=iift74J2BcJLjOmAJCEOfXrZiV7cQ7a8CkgROfOHGRw=; b=C9gzza+roaxJukuv0AdMuyVAuywkvnIHmib38rCIlkXlfhHvle37okaKjUcLxD5+y3HK v3pT+Al8Hf2IJrJjR419QevTSpTCvicb06yt5t32j4TmaV0iLRwi4pK/PzDZP/6l8txqW llENa6c1Hpwbp8NLr8ylz2FQ5nB1Bvv8xbUkTaO6dLiPkTII/cEj8nnMba3lXKWBH+4Zb MxDTOS1XtMg4hgeDbvcJRX+FxiuqwSTsndwiFO8CuyKuVBFBcK69HMEdBoBgV8MKD4QFw Bm9lCcCuDJhrWtMvhym2lheD8iyi1q9/299E0WoqhuYtOVUKZ7zLombAuwb/G5tjN6Q== ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=LBCVytlP; arc=pass header.oldest-pass=0 smtp.remote-ip=127.0.0.1 Received: from localhost.localdomain (localhost [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E5270606A31D; Thu, 22 Oct 2026 12:36:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=LBCVytlP X-Original-To: linux-sunxi@lists.linux.dev Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792672599; b=3KO2U5nw8bc1fku/o78auVFlox2AfROgXqE0sG+YCYFrAmL5knNtiWA2R/iG4H2TB2pk zOpBgbvsCYdz/7vBVNaEZfOwGuxM7cRalJ8kyCK6z/YRZcp6TeqJXffbGi0fusmhXa3K5 LeziZOp6fz/ak0ZYhcUFNeDPcO4WMrkkEEKBLWW+bLJSP8Z03FPLkAFJhjzl5MaC9EbdI 2nG7I36lfFJtHGv2kYJ7TpcB9vPOCFmcGnicl80Y9eA/BhJEmWeAbUtpCBKZg7TaThaCq T4IMbJkm65U9MrIae+jECuFxQjTbURzO82EzwOV637uVecumtjJQoYnQxpqr1O4V7Cw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792672599; h=Received:DKIM-Signature:From:Date:Subject:MIME-Version:Content-Type: Content-Transfer-Encoding:Message-Id:References:In-Reply-To:To:Cc: X-Mailer:X-Developer-Signature:X-Developer-Key; bh=iift74J2BcJLjOmAJCEOfXrZiV7cQ7a8CkgROfOHGRw=; b=vQbX5N0QYV+dD+qNyPo2sDf2qZOVFrH14BQhxVuea9WU5mIXg99qDQNKxRUtJreR66tm VLM6OEc+mhygHmhTMaCCc2QYwIqk2p06CpfMnojQwF5IcBmNAgEbwrvvYCXhy0f9BNopP ZLt1UBc+yOqNKGtZ/hw6YxlsN1jp4tq/waNxZ329U0+Jh5dZu4scTNi3ZOVQx671qfv9y RCvVgZzLGbPpXIjE3jKN0lny8fnnWzh8o+H/V8cYvc6Q6ReJtCnZqCUaUmRwNcH33Op9N +C3og0q3L0dmEM/odG4lz04Ky6cTMALXBgcF1B+JxAT264HRCMwpIkg2zu2hKdWrjNw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=LBCVytlP; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89CDA606A319 for ; Thu, 22 Oct 2026 12:36:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A03191F000C1; Thu, 22 Oct 2026 12:36:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792672599; bh=iift74J2BcJLjOmAJCEOfXrZiV7cQ7a8CkgROfOHGRw=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=LBCVytlPZLp9NTcJ1osQup2EPLx0c4fjVq+psH90YyFdkTSHc273LtfflcybyZgXl VHKSEqhgX4G6pVzXgDhYTjk5B2dwiQ32GaXZsgCyGWDP2cgVxY8YKChdJCQAGL5m1M yB930PgWb+Irmxw1vSCOJlqdlg9nbKhOfcsn6Mnp4nMMtdHhuAmpSzbtFDLRv3tdA7 hDNVplx7C/70ZrJ6rNUPHAgnjQgjV6CD48XpGga1oRQjNr958x0MwBsqo1YZ+xmDs5 UDwIq6eWeYUw+WuGomqZuhLjeC+TUU4bE2k3PAGD6auW8h/CwUAIqRXiaNa2m6Wtyp rqn93UJgF6ugA== From: Maxime Ripard Date: Thu, 22 Oct 2026 14:31:47 +0200 Subject: [PATCH v2 48/59] drm/sun4i: tv: Convert to atomic_create_state X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Message-Id: <20261022-drm-no-more-connector-reset-v2-48-0b7e4e85b1e8@kernel.org> References: <20261022-drm-no-more-connector-reset-v2-0-0b7e4e85b1e8@kernel.org> In-Reply-To: <20261022-drm-no-more-connector-reset-v2-0-0b7e4e85b1e8@kernel.org> To: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, Maxime Ripard , Chen-Yu Tsai , Samuel Holland , linux-sunxi@lists.linux.dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1967; i=mripard@kernel.org; h=from:subject:message-id; bh=kGTs0Nop/pM8g/eLbAmv9j8gKg2hgWhBLCx8ej3AHWQ=; b=owGbwMvMwCmsHn9OcpHtvjLG02pJDFm3mBZFvz61VjRo4229FStbl1mnXXJ9t7itXvGK36udU 7bMuWOwo2MqC4MwJ4OsmCLLE5mw08vbF1c52K/8ATOHlQlkCAMXpwBMpMKSsaFdwM9Y2f2fQPDH K4GVi3k+/nhynKFpxuPDl6f3fi1m3PafayFXZmPlgjpV70UsGtMUPBgbWm/+rHE/3XSp85Old09 45IRVaW7XakTM1m6e+ibxteNDFaM3kxMOMCjUrXGSW79mxRoRAA== X-Developer-Key: i=mripard@kernel.org; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-MORS-Enabled: yes X-MORS-DOMAIN: patchwork.local X-MORS-HOSTING: hosting172546 X-MORS-USER: hosting172546 X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= The sun4i TV connector reset implementation creates a pristine state and initializes the analog TV properties. It does not perform any hardware reset. Since this is equivalent to what atomic_create_state expects, convert the reset function to an atomic_create_state hook that returns the initialized state. Signed-off-by: Maxime Ripard --- Cc: Chen-Yu Tsai Cc: Samuel Holland Cc: linux-sunxi@lists.linux.dev --- drivers/gpu/drm/sun4i/sun4i_tv.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_tv.c b/drivers/gpu/drm/sun4i/sun4i_tv.c index ea86f8a6a35e..a68e5f7a03d2 100644 --- a/drivers/gpu/drm/sun4i/sun4i_tv.c +++ b/drivers/gpu/drm/sun4i/sun4i_tv.c @@ -406,8 +406,16 @@ static const struct drm_connector_helper_funcs sun4i_tv_comp_connector_helper_fu }; -static void sun4i_tv_connector_reset(struct drm_connector *connector) +static struct drm_connector_state * +sun4i_tv_connector_create_state(struct drm_connector *connector) { - drm_atomic_helper_connector_reset(connector); - drm_atomic_helper_connector_tv_state_init(connector->state, connector); + struct drm_connector_state *connector_state; + + connector_state = drm_atomic_helper_connector_create_state(connector); + if (IS_ERR(connector_state)) + return connector_state; + + drm_atomic_helper_connector_tv_state_init(connector_state, connector); + + return connector_state; } @@ -415,5 +423,5 @@ static const struct drm_connector_funcs sun4i_tv_comp_connector_funcs = { .fill_modes = drm_helper_probe_single_connector_modes, .destroy = drm_connector_cleanup, - .reset = sun4i_tv_connector_reset, + .atomic_create_state = sun4i_tv_connector_create_state, .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state, .atomic_destroy_state = drm_atomic_helper_connector_destroy_state,