mbox series

[v3,0/4] Add hstimer support for H616 and T113-S3

Message ID 20260428-h616-t113s-hstimer-v3-0-7e02178a93ee@mmpsystems.pl (mailing list archive)
Headers
Series Add hstimer support for H616 and T113-S3 |

Message

Michal Piekos April 28, 2026, 4:26 p.m. UTC 
Add support for Allwinner D1 high speed timer in sun5i hstimer driver
and describe corresponding nodes in dts for H616 and T113-S3 SoC's.

D1 and H616 uses same model as existing driver except register shift
compared to older variants. 

Added register layout abstraction in the driver, extended the binding
with new compatibles and wired up dts nodes for T113-S3 and H616 which
uses D1 as fallback compatible.

Signed-off-by: Michal Piekos <michal.piekos@mmpsystems.pl>
---
Changes in v3:
- Removed left over dead code from v1
- Link to v2: https://lore.kernel.org/r/20260426-h616-t113s-hstimer-v2-0-e65e9dc0c9da@mmpsystems.pl

Changes in v2:
- Change driver handling of different offsets to using quirks
- Change from t113s to d1 as the fallback compatible string
- Fix conditional compatible matching
- Link to v1: https://lore.kernel.org/r/20260419-h616-t113s-hstimer-v1-0-1af74ebef7c5@mmpsystems.pl

To: Daniel Lezcano <daniel.lezcano@kernel.org>
To: Thomas Gleixner <tglx@kernel.org>
To: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzk+dt@kernel.org>
To: Conor Dooley <conor+dt@kernel.org>
To: Chen-Yu Tsai <wens@kernel.org>
To: Jernej Skrabec <jernej.skrabec@gmail.com>
To: Samuel Holland <samuel@sholland.org>
To: Maxime Ripard <mripard@kernel.org>
Cc: linux-kernel@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-sunxi@lists.linux.dev
Cc: Andre Przywara <andre.przywara@arm.com>

---
Michal Piekos (4):
      dt-bindings: timer: allwinner,sun5i-a13-hstimer: add H616 and D1
      clocksource/drivers/sun5i: add D1 hstimer support
      arm: dts: allwinner: t113s: add hstimer node
      arm64: dts: allwinner: h616: add hstimer node

 .../timer/allwinner,sun5i-a13-hstimer.yaml         |  9 ++-
 arch/arm/boot/dts/allwinner/sun8i-t113s.dtsi       | 11 +++
 arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi     | 10 +++
 drivers/clocksource/timer-sun5i.c                  | 84 +++++++++++++++++-----
 4 files changed, 94 insertions(+), 20 deletions(-)
---
base-commit: dca922e019dd758b4c1b4bec8f1d509efddeaab4
change-id: 20260413-h616-t113s-hstimer-62939948f91c

Best regards,
--  
Michal Piekos <michal.piekos@mmpsystems.pl>

Comments

Daniel Lezcano May 6, 2026, 11:28 a.m. UTC | #1 
On 4/28/26 18:26, Michal Piekos wrote:
> Add support for Allwinner D1 high speed timer in sun5i hstimer driver
> and describe corresponding nodes in dts for H616 and T113-S3 SoC's.
> 
> D1 and H616 uses same model as existing driver except register shift
> compared to older variants.
> 
> Added register layout abstraction in the driver, extended the binding
> with new compatibles and wired up dts nodes for T113-S3 and H616 which
> uses D1 as fallback compatible.
> 
> Signed-off-by: Michal Piekos <michal.piekos@mmpsystems.pl>
> ---

Applied patches 1 and 2

Thanks
Michal Piekos May 6, 2026, 2:41 p.m. UTC | #2 
On Wed, May 06, 2026 at 01:28:22PM +0200, Daniel Lezcano wrote:
> On 4/28/26 18:26, Michal Piekos wrote:
> > Add support for Allwinner D1 high speed timer in sun5i hstimer driver
> > and describe corresponding nodes in dts for H616 and T113-S3 SoC's.
> > 
> > D1 and H616 uses same model as existing driver except register shift
> > compared to older variants.
> > 
> > Added register layout abstraction in the driver, extended the binding
> > with new compatibles and wired up dts nodes for T113-S3 and H616 which
> > uses D1 as fallback compatible.
> > 
> > Signed-off-by: Michal Piekos <michal.piekos@mmpsystems.pl>
> > ---
> 
> Applied patches 1 and 2
> 
> Thanks

Thank you.
I will spin shortly next version with suggested correction for patch 3.
Daniel Lezcano May 6, 2026, 3:15 p.m. UTC | #3 
On 5/6/26 16:41, Michal Piekos wrote:
> On Wed, May 06, 2026 at 01:28:22PM +0200, Daniel Lezcano wrote:
>> On 4/28/26 18:26, Michal Piekos wrote:
>>> Add support for Allwinner D1 high speed timer in sun5i hstimer driver
>>> and describe corresponding nodes in dts for H616 and T113-S3 SoC's.
>>>
>>> D1 and H616 uses same model as existing driver except register shift
>>> compared to older variants.
>>>
>>> Added register layout abstraction in the driver, extended the binding
>>> with new compatibles and wired up dts nodes for T113-S3 and H616 which
>>> uses D1 as fallback compatible.
>>>
>>> Signed-off-by: Michal Piekos <michal.piekos@mmpsystems.pl>
>>> ---
>>
>> Applied patches 1 and 2
>>
>> Thanks
> 
> Thank you.
> I will spin shortly next version with suggested correction for patch 3.

So patch 1 and 2 are unchanged in v4 ? (missing reviewed-by: Chen-Yu BTW)
Michal Piekos May 7, 2026, 7:58 a.m. UTC | #4 
On Wed, May 06, 2026 at 05:15:49PM +0200, Daniel Lezcano wrote:
> On 5/6/26 16:41, Michal Piekos wrote:
> > On Wed, May 06, 2026 at 01:28:22PM +0200, Daniel Lezcano wrote:
> > > On 4/28/26 18:26, Michal Piekos wrote:
> > > > Add support for Allwinner D1 high speed timer in sun5i hstimer driver
> > > > and describe corresponding nodes in dts for H616 and T113-S3 SoC's.
> > > > 
> > > > D1 and H616 uses same model as existing driver except register shift
> > > > compared to older variants.
> > > > 
> > > > Added register layout abstraction in the driver, extended the binding
> > > > with new compatibles and wired up dts nodes for T113-S3 and H616 which
> > > > uses D1 as fallback compatible.
> > > > 
> > > > Signed-off-by: Michal Piekos <michal.piekos@mmpsystems.pl>
> > > > ---
> > > 
> > > Applied patches 1 and 2
> > > 
> > > Thanks
> > 
> > Thank you.
> > I will spin shortly next version with suggested correction for patch 3.
> 
> So patch 1 and 2 are unchanged in v4 ? (missing reviewed-by: Chen-Yu BTW)
> 

Yes. Patch 1 and 2 are unchanged in v4.
Sorry for missing reviewed-by. Was to quick.

Michal