mbox series

[00/26] dmaengine: Remove redundant error messages on IRQ request failure

Message ID 20260709135846.97972-1-panchuang@vivo.com (mailing list archive)
Headers
Series dmaengine: Remove redundant error messages on IRQ request failure |

Message

Pan Chuang July 9, 2026, 1:58 p.m. UTC 
Commit 55b48e23f5c4b6f5ca9b7ab09599b17dcf501c10 ("genirq/devres: Add
error handling in devm_request_*_irq()") added automatic error logging
to devm_request_threaded_irq() and devm_request_any_context_irq() via
the new devm_request_result() helper. The helper prints device name,
IRQ number, handler functions, and error code on failure.

Since devm_request_irq() is a static inline wrapper around
devm_request_threaded_irq(), it also benefits from this automatic
logging.

This series removes the now-redundant dev_err() and dev_err_probe() calls
in dmaengine drivers that follow these devm_request_*_irq() functions,
as the core now provides more detailed diagnostic information on failure.

Pan Chuang (26):
  dmaengine: fsl-edma-main: Remove redundant dev_err()/dev_err_probe()
  dmaengine: fsl-qdma: Remove redundant dev_err()/dev_err_probe()
  dmaengine: loongson-loongson1-apb-dma: Remove redundant
    dev_err()/dev_err_probe()
  dmaengine: mediatek-mtk-cqdma: Remove redundant
    dev_err()/dev_err_probe()
  dmaengine: mediatek-mtk-hsdma: Remove redundant
    dev_err()/dev_err_probe()
  dmaengine: mmp_pdma: Remove redundant dev_err()/dev_err_probe()
  dmaengine: moxart-dma: Remove redundant dev_err()/dev_err_probe()
  dmaengine: owl-dma: Remove redundant dev_err()/dev_err_probe()
  dmaengine: pxa_dma: Remove redundant dev_err()/dev_err_probe()
  dmaengine: qcom-gpi: Remove redundant dev_err()/dev_err_probe()
  dmaengine: sf-pdma-sf-pdma: Remove redundant dev_err()/dev_err_probe()
  dmaengine: sh-rcar-dmac: Remove redundant dev_err()/dev_err_probe()
  dmaengine: sh-rz-dmac: Remove redundant dev_err()/dev_err_probe()
  dmaengine: sh-shdmac: Remove redundant dev_err()/dev_err_probe()
  dmaengine: sh-usb-dmac: Remove redundant dev_err()/dev_err_probe()
  dmaengine: sprd-dma: Remove redundant dev_err()/dev_err_probe()
  dmaengine: st_fdma: Remove redundant dev_err()/dev_err_probe()
  dmaengine: stm32-stm32-dma: Remove redundant dev_err()/dev_err_probe()
  dmaengine: stm32-stm32-dma3: Remove redundant
    dev_err()/dev_err_probe()
  dmaengine: stm32-stm32-mdma: Remove redundant
    dev_err()/dev_err_probe()
  dmaengine: sun4i-dma: Remove redundant dev_err()/dev_err_probe()
  dmaengine: sun6i-dma: Remove redundant dev_err()/dev_err_probe()
  dmaengine: tegra20-apb-dma: Remove redundant dev_err()/dev_err_probe()
  dmaengine: ti-edma: Remove redundant dev_err()/dev_err_probe()
  dmaengine: uniphier-xdmac: Remove redundant dev_err()/dev_err_probe()
  dmaengine: xgene-dma: Remove redundant dev_err()/dev_err_probe()

 drivers/dma/fsl-edma-main.c              | 23 +++++++----------------
 drivers/dma/fsl-qdma.c                   |  4 +---
 drivers/dma/loongson/loongson1-apb-dma.c |  4 +---
 drivers/dma/mediatek/mtk-cqdma.c         |  5 +----
 drivers/dma/mediatek/mtk-hsdma.c         |  5 +----
 drivers/dma/mmp_pdma.c                   |  4 +---
 drivers/dma/moxart-dma.c                 |  4 +---
 drivers/dma/owl-dma.c                    |  4 +---
 drivers/dma/pxa_dma.c                    |  6 +-----
 drivers/dma/qcom/gpi.c                   |  5 +----
 drivers/dma/sf-pdma/sf-pdma.c            |  8 ++------
 drivers/dma/sh/rcar-dmac.c               |  5 +----
 drivers/dma/sh/rz-dmac.c                 |  8 +-------
 drivers/dma/sh/shdmac.c                  |  6 +-----
 drivers/dma/sh/usb-dmac.c                |  5 +----
 drivers/dma/sprd-dma.c                   |  4 +---
 drivers/dma/st_fdma.c                    |  4 +---
 drivers/dma/stm32/stm32-dma.c            |  6 +-----
 drivers/dma/stm32/stm32-dma3.c           |  5 +----
 drivers/dma/stm32/stm32-mdma.c           |  4 +---
 drivers/dma/sun4i-dma.c                  |  2 +-
 drivers/dma/sun6i-dma.c                  |  4 +---
 drivers/dma/tegra20-apb-dma.c            |  6 +-----
 drivers/dma/ti/edma.c                    |  8 ++------
 drivers/dma/uniphier-xdmac.c             |  4 +---
 drivers/dma/xgene-dma.c                  |  5 +----
 26 files changed, 34 insertions(+), 114 deletions(-)

Comments

Wolfram Sang July 9, 2026, 2:26 p.m. UTC | #1 
On Thu, Jul 09, 2026 at 09:58:04PM +0800, Pan Chuang wrote:
> Commit 55b48e23f5c4b6f5ca9b7ab09599b17dcf501c10 ("genirq/devres: Add
> error handling in devm_request_*_irq()") added automatic error logging
> to devm_request_threaded_irq() and devm_request_any_context_irq() via
> the new devm_request_result() helper. The helper prints device name,
> IRQ number, handler functions, and error code on failure.
> 
> Since devm_request_irq() is a static inline wrapper around
> devm_request_threaded_irq(), it also benefits from this automatic
> logging.
> 
> This series removes the now-redundant dev_err() and dev_err_probe() calls
> in dmaengine drivers that follow these devm_request_*_irq() functions,
> as the core now provides more detailed diagnostic information on failure.
> 
> Pan Chuang (26):
>   dmaengine: fsl-edma-main: Remove redundant dev_err()/dev_err_probe()
>   dmaengine: fsl-qdma: Remove redundant dev_err()/dev_err_probe()
>   dmaengine: loongson-loongson1-apb-dma: Remove redundant
>     dev_err()/dev_err_probe()
>   dmaengine: mediatek-mtk-cqdma: Remove redundant
>     dev_err()/dev_err_probe()
>   dmaengine: mediatek-mtk-hsdma: Remove redundant
>     dev_err()/dev_err_probe()
>   dmaengine: mmp_pdma: Remove redundant dev_err()/dev_err_probe()
>   dmaengine: moxart-dma: Remove redundant dev_err()/dev_err_probe()
>   dmaengine: owl-dma: Remove redundant dev_err()/dev_err_probe()
>   dmaengine: pxa_dma: Remove redundant dev_err()/dev_err_probe()
>   dmaengine: qcom-gpi: Remove redundant dev_err()/dev_err_probe()
>   dmaengine: sf-pdma-sf-pdma: Remove redundant dev_err()/dev_err_probe()
>   dmaengine: sh-rcar-dmac: Remove redundant dev_err()/dev_err_probe()
>   dmaengine: sh-rz-dmac: Remove redundant dev_err()/dev_err_probe()
>   dmaengine: sh-shdmac: Remove redundant dev_err()/dev_err_probe()
>   dmaengine: sh-usb-dmac: Remove redundant dev_err()/dev_err_probe()
>   dmaengine: sprd-dma: Remove redundant dev_err()/dev_err_probe()
>   dmaengine: st_fdma: Remove redundant dev_err()/dev_err_probe()
>   dmaengine: stm32-stm32-dma: Remove redundant dev_err()/dev_err_probe()
>   dmaengine: stm32-stm32-dma3: Remove redundant
>     dev_err()/dev_err_probe()
>   dmaengine: stm32-stm32-mdma: Remove redundant
>     dev_err()/dev_err_probe()
>   dmaengine: sun4i-dma: Remove redundant dev_err()/dev_err_probe()
>   dmaengine: sun6i-dma: Remove redundant dev_err()/dev_err_probe()
>   dmaengine: tegra20-apb-dma: Remove redundant dev_err()/dev_err_probe()
>   dmaengine: ti-edma: Remove redundant dev_err()/dev_err_probe()
>   dmaengine: uniphier-xdmac: Remove redundant dev_err()/dev_err_probe()
>   dmaengine: xgene-dma: Remove redundant dev_err()/dev_err_probe()

One patch per subsystem for such trivial changes, please.
Vinod Koul July 14, 2026, 12:06 p.m. UTC | #2 
On 09-07-26, 16:26, Wolfram Sang wrote:
> On Thu, Jul 09, 2026 at 09:58:04PM +0800, Pan Chuang wrote:
> > Commit 55b48e23f5c4b6f5ca9b7ab09599b17dcf501c10 ("genirq/devres: Add
> > error handling in devm_request_*_irq()") added automatic error logging
> > to devm_request_threaded_irq() and devm_request_any_context_irq() via
> > the new devm_request_result() helper. The helper prints device name,
> > IRQ number, handler functions, and error code on failure.
> > 
> > Since devm_request_irq() is a static inline wrapper around
> > devm_request_threaded_irq(), it also benefits from this automatic
> > logging.
> > 
> > This series removes the now-redundant dev_err() and dev_err_probe() calls
> > in dmaengine drivers that follow these devm_request_*_irq() functions,
> > as the core now provides more detailed diagnostic information on failure.
> > 
> > Pan Chuang (26):
> >   dmaengine: fsl-edma-main: Remove redundant dev_err()/dev_err_probe()
> >   dmaengine: fsl-qdma: Remove redundant dev_err()/dev_err_probe()
> >   dmaengine: loongson-loongson1-apb-dma: Remove redundant
> >     dev_err()/dev_err_probe()
> >   dmaengine: mediatek-mtk-cqdma: Remove redundant
> >     dev_err()/dev_err_probe()
> >   dmaengine: mediatek-mtk-hsdma: Remove redundant
> >     dev_err()/dev_err_probe()
> >   dmaengine: mmp_pdma: Remove redundant dev_err()/dev_err_probe()
> >   dmaengine: moxart-dma: Remove redundant dev_err()/dev_err_probe()
> >   dmaengine: owl-dma: Remove redundant dev_err()/dev_err_probe()
> >   dmaengine: pxa_dma: Remove redundant dev_err()/dev_err_probe()
> >   dmaengine: qcom-gpi: Remove redundant dev_err()/dev_err_probe()
> >   dmaengine: sf-pdma-sf-pdma: Remove redundant dev_err()/dev_err_probe()
> >   dmaengine: sh-rcar-dmac: Remove redundant dev_err()/dev_err_probe()
> >   dmaengine: sh-rz-dmac: Remove redundant dev_err()/dev_err_probe()
> >   dmaengine: sh-shdmac: Remove redundant dev_err()/dev_err_probe()
> >   dmaengine: sh-usb-dmac: Remove redundant dev_err()/dev_err_probe()
> >   dmaengine: sprd-dma: Remove redundant dev_err()/dev_err_probe()
> >   dmaengine: st_fdma: Remove redundant dev_err()/dev_err_probe()
> >   dmaengine: stm32-stm32-dma: Remove redundant dev_err()/dev_err_probe()
> >   dmaengine: stm32-stm32-dma3: Remove redundant
> >     dev_err()/dev_err_probe()
> >   dmaengine: stm32-stm32-mdma: Remove redundant
> >     dev_err()/dev_err_probe()
> >   dmaengine: sun4i-dma: Remove redundant dev_err()/dev_err_probe()
> >   dmaengine: sun6i-dma: Remove redundant dev_err()/dev_err_probe()
> >   dmaengine: tegra20-apb-dma: Remove redundant dev_err()/dev_err_probe()
> >   dmaengine: ti-edma: Remove redundant dev_err()/dev_err_probe()
> >   dmaengine: uniphier-xdmac: Remove redundant dev_err()/dev_err_probe()
> >   dmaengine: xgene-dma: Remove redundant dev_err()/dev_err_probe()
> 
> One patch per subsystem for such trivial changes, please.

Yes pretty please
Pan Chuang July 15, 2026, 6:44 a.m. UTC | #3 
On 2026-07-14 20:06, Vinod Koul wrote:
> On 09-07-26, 16:26, Wolfram Sang wrote:
>> On Thu, Jul 09, 2026 at 09:58:04PM +0800, Pan Chuang wrote:
>>> Commit 55b48e23f5c4b6f5ca9b7ab09599b17dcf501c10 ("genirq/devres: Add
>>> error handling in devm_request_*_irq()") added automatic error logging
>>> to devm_request_threaded_irq() and devm_request_any_context_irq() via
>>> the new devm_request_result() helper. The helper prints device name,
>>> IRQ number, handler functions, and error code on failure.
>>>
>>> Since devm_request_irq() is a static inline wrapper around
>>> devm_request_threaded_irq(), it also benefits from this automatic
>>> logging.
>>>
>>> This series removes the now-redundant dev_err() and dev_err_probe() calls
>>> in dmaengine drivers that follow these devm_request_*_irq() functions,
>>> as the core now provides more detailed diagnostic information on failure.
>>>
>>> Pan Chuang (26):
>>>   dmaengine: fsl-edma-main: Remove redundant dev_err()/dev_err_probe()
>>>   dmaengine: fsl-qdma: Remove redundant dev_err()/dev_err_probe()
>>>   dmaengine: loongson-loongson1-apb-dma: Remove redundant
>>>     dev_err()/dev_err_probe()
>>>   dmaengine: mediatek-mtk-cqdma: Remove redundant
>>>     dev_err()/dev_err_probe()
>>>   dmaengine: mediatek-mtk-hsdma: Remove redundant
>>>     dev_err()/dev_err_probe()
>>>   dmaengine: mmp_pdma: Remove redundant dev_err()/dev_err_probe()
>>>   dmaengine: moxart-dma: Remove redundant dev_err()/dev_err_probe()
>>>   dmaengine: owl-dma: Remove redundant dev_err()/dev_err_probe()
>>>   dmaengine: pxa_dma: Remove redundant dev_err()/dev_err_probe()
>>>   dmaengine: qcom-gpi: Remove redundant dev_err()/dev_err_probe()
>>>   dmaengine: sf-pdma-sf-pdma: Remove redundant dev_err()/dev_err_probe()
>>>   dmaengine: sh-rcar-dmac: Remove redundant dev_err()/dev_err_probe()
>>>   dmaengine: sh-rz-dmac: Remove redundant dev_err()/dev_err_probe()
>>>   dmaengine: sh-shdmac: Remove redundant dev_err()/dev_err_probe()
>>>   dmaengine: sh-usb-dmac: Remove redundant dev_err()/dev_err_probe()
>>>   dmaengine: sprd-dma: Remove redundant dev_err()/dev_err_probe()
>>>   dmaengine: st_fdma: Remove redundant dev_err()/dev_err_probe()
>>>   dmaengine: stm32-stm32-dma: Remove redundant dev_err()/dev_err_probe()
>>>   dmaengine: stm32-stm32-dma3: Remove redundant
>>>     dev_err()/dev_err_probe()
>>>   dmaengine: stm32-stm32-mdma: Remove redundant
>>>     dev_err()/dev_err_probe()
>>>   dmaengine: sun4i-dma: Remove redundant dev_err()/dev_err_probe()
>>>   dmaengine: sun6i-dma: Remove redundant dev_err()/dev_err_probe()
>>>   dmaengine: tegra20-apb-dma: Remove redundant dev_err()/dev_err_probe()
>>>   dmaengine: ti-edma: Remove redundant dev_err()/dev_err_probe()
>>>   dmaengine: uniphier-xdmac: Remove redundant dev_err()/dev_err_probe()
>>>   dmaengine: xgene-dma: Remove redundant dev_err()/dev_err_probe()
>>
>> One patch per subsystem for such trivial changes, please.
>
> Yes pretty please
>
Thanks, I'll merge them in v2.

Best Regards,
PanChuang