mbox series

[00/75] drm/connector: Convert all drivers to atomic_create_state and remove reset

Message ID 20261014-drm-no-more-connector-reset-v1-0-586c9c026823@kernel.org (mailing list archive)
Headers
Series drm/connector: Convert all drivers to atomic_create_state and remove reset |

Message

Maxime Ripard Oct. 14, 2026, 5:26 p.m. UTC 
This is a follow-up to the plane and CRTC reset removal series, and
part of a larger effort to remove the reset hook from all KMS objects.

The connector reset hook is overloaded: it is called both at probe
time to create the initial software state and during suspend/resume to
reset hardware and software state. These two roles have different
requirements, and the reset hook is not fallible, making error
handling difficult for the initial state allocation path.

While reset has the semantics to reset both the software and hardware
state, the vast majority of implementations and all the helpers only
reset the software state, making them equivalent to
atomic_create_state in practice. The atomic_create_state hook makes
this explicit: it only allocates and initializes a pristine state
without any side effect, and returns the state pointer or an ERR_PTR
on failure.

This series converts all connector drivers tree-wide from the reset hook
to atomic_create_state, then removes the reset hook from struct
drm_connector_funcs entirely. The conversions were done using a
combination of Coccinelle semantic patches, mechanical one-line
replacements and manual adjustments.

Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Maxime Ripard (75):
      drm/panel: Add atomic_create_state support
      drm/adp: Switch to drm_atomic_helper_connector_create_state
      drm/amdgpu: vkms: Switch to drm_atomic_helper_connector_create_state
      drm/amdgpu: dm: Switch to drm_atomic_helper_connector_create_state
      drm/arm: komeda: Switch to drm_atomic_helper_connector_create_state
      drm/aspeed: Switch to drm_atomic_helper_connector_create_state
      drm/ast: Switch to drm_atomic_helper_connector_create_state
      drm/bridge: analogix-anx6345: Switch to drm_atomic_helper_connector_create_state
      drm/bridge: analogix-anx78xx: Switch to drm_atomic_helper_connector_create_state
      drm/bridge: chrontel-ch7033: Switch to drm_atomic_helper_connector_create_state
      drm/bridge: lontium-lt8912b: Switch to drm_atomic_helper_connector_create_state
      drm/bridge: megachips: Switch to drm_atomic_helper_connector_create_state
      drm/bridge: nxp-ptn3460: Switch to drm_atomic_helper_connector_create_state
      drm/panel: Switch to drm_atomic_helper_connector_create_state
      drm/bridge: sii902x: Switch to drm_atomic_helper_connector_create_state
      drm/bridge: simple-bridge: Switch to drm_atomic_helper_connector_create_state
      drm/bridge: synopsys: dw-hdmi: Switch to drm_atomic_helper_connector_create_state
      drm/bridge: tc358767: Switch to drm_atomic_helper_connector_create_state
      drm/bridge: tda998x: Switch to drm_atomic_helper_connector_create_state
      drm/bridge: ti-tfp410: Switch to drm_atomic_helper_connector_create_state
      drm/exynos: Switch to drm_atomic_helper_connector_create_state
      drm/fsl-dcu: Switch to drm_atomic_helper_connector_create_state
      drm/hisilicon: hibmc: Switch to drm_atomic_helper_connector_create_state
      drm/hyperv: Switch to drm_atomic_helper_connector_create_state
      drm/imx: ipuv3: Switch to drm_atomic_helper_connector_create_state
      drm/logicvc: Switch to drm_atomic_helper_connector_create_state
      drm/loongson: Switch to drm_atomic_helper_connector_create_state
      drm/mgag200: Switch to drm_atomic_helper_connector_create_state
      drm/mipi-dbi: Switch to drm_atomic_helper_connector_create_state
      drm/msm: dpu1: Switch to drm_atomic_helper_connector_create_state
      drm/qxl: Switch to drm_atomic_helper_connector_create_state
      drm/renesas: shmobile: Switch to drm_atomic_helper_connector_create_state
      drm/sitronix: st7571: Switch to drm_atomic_helper_connector_create_state
      drm/sitronix: st7920: Switch to drm_atomic_helper_connector_create_state
      drm/solomon: ssd130x: Switch to drm_atomic_helper_connector_create_state
      drm/sti: Switch to drm_atomic_helper_connector_create_state
      drm/stm: Switch to drm_atomic_helper_connector_create_state
      drm/sun4i: Switch to drm_atomic_helper_connector_create_state
      drm/sysfb: Switch to drm_atomic_helper_connector_create_state
      drm/tegra: Switch to drm_atomic_helper_connector_create_state
      drm/tests: Switch to drm_atomic_helper_connector_create_state
      drm/tiny: arcpgu: Switch to drm_atomic_helper_connector_create_state
      drm/tiny: bochs: Switch to drm_atomic_helper_connector_create_state
      drm/tiny: cirrus: Switch to drm_atomic_helper_connector_create_state
      drm/tiny: gm12u320: Switch to drm_atomic_helper_connector_create_state
      drm/tiny: pixpaper: Switch to drm_atomic_helper_connector_create_state
      drm/tiny: repaper: Switch to drm_atomic_helper_connector_create_state
      drm/tiny: sharp: Switch to drm_atomic_helper_connector_create_state
      drm/udl: Switch to drm_atomic_helper_connector_create_state
      drm/vboxvideo: Switch to drm_atomic_helper_connector_create_state
      drm/vc4: Switch to drm_atomic_helper_connector_create_state
      drm/virtio: Switch to drm_atomic_helper_connector_create_state
      drm/vkms: Switch to drm_atomic_helper_connector_create_state
      drm/xen: Switch to drm_atomic_helper_connector_create_state
      drm/atomic-state-helper: Rename connector_tv_margins_reset to state_init
      drm/atomic-state-helper: Rename connector_tv_reset to state_init
      drm/bridge: synopsys: dw-hdmi: Convert to atomic_create_state
      drm/meson: Convert to atomic_create_state
      drm/gud: Convert to atomic_create_state
      drm/sun4i: hdmi: Convert to atomic_create_state
      drm/sun4i: tv: Convert to atomic_create_state
      drm/tests: hdmi: Convert to atomic_create_state
      drm/vc4: hdmi: Convert to atomic_create_state
      drm/vc4: vec: Convert to atomic_create_state
      drm/connector: Remove drm_atomic_helper_connector_reset()
      drm/amdgpu: dm: Convert to atomic_create_state
      drm/malidp: Convert to atomic_create_state
      drm/ast: Convert to atomic_create_state
      drm/i915: Convert to atomic_create_state
      drm/nouveau: Convert to atomic_create_state
      drm/rcar-du: Convert to atomic_create_state
      drm/tegra: Convert to atomic_create_state
      drm/vmwgfx: Convert to atomic_create_state
      drm/connector: Remove __drm_atomic_helper_connector_reset()
      drm/connector: Remove reset

 drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c           |  2 +-
 .../amd/display/amdgpu_dm/amdgpu_dm_connector.c    | 32 ++++----
 .../amd/display/amdgpu_dm/amdgpu_dm_connector.h    |  3 +-
 .../amd/display/amdgpu_dm/amdgpu_dm_mst_types.c    |  4 +-
 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c   | 14 +++-
 .../display/amdgpu_dm/tests/amdgpu_dm_audio_test.c |  2 +-
 .../amdgpu_dm/tests/amdgpu_dm_backlight_test.c     |  2 +-
 .../amdgpu_dm/tests/amdgpu_dm_connector_test.c     | 90 ++++++++++++++--------
 .../display/amdgpu_dm/tests/amdgpu_dm_crc_test.c   |  7 +-
 .../amdgpu_dm/tests/amdgpu_dm_helpers_test.c       |  2 +-
 .../display/amdgpu_dm/tests/amdgpu_dm_irq_test.c   |  2 +-
 .../amdgpu_dm/tests/amdgpu_dm_mst_types_test.c     |  4 +-
 .../display/amdgpu_dm/tests/amdgpu_dm_wb_test.c    |  2 +-
 .../drm/arm/display/komeda/komeda_wb_connector.c   |  2 +-
 drivers/gpu/drm/arm/malidp_mw.c                    | 18 ++---
 drivers/gpu/drm/aspeed/aspeed_gfx_out.c            |  2 +-
 drivers/gpu/drm/ast/ast_dp.c                       | 19 ++---
 drivers/gpu/drm/ast/ast_dp501.c                    |  2 +-
 drivers/gpu/drm/ast/ast_sil164.c                   |  2 +-
 drivers/gpu/drm/ast/ast_vga.c                      |  2 +-
 drivers/gpu/drm/bridge/analogix/analogix-anx6345.c |  2 +-
 drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c |  2 +-
 drivers/gpu/drm/bridge/chrontel-ch7033.c           |  2 +-
 drivers/gpu/drm/bridge/lontium-lt8912b.c           |  2 +-
 .../drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c   |  2 +-
 drivers/gpu/drm/bridge/nxp-ptn3460.c               |  2 +-
 drivers/gpu/drm/bridge/sii902x.c                   |  2 +-
 drivers/gpu/drm/bridge/simple-bridge.c             |  2 +-
 drivers/gpu/drm/bridge/synopsys/dw-hdmi.c          | 12 ++-
 drivers/gpu/drm/bridge/tc358767.c                  |  2 +-
 drivers/gpu/drm/bridge/tda998x_drv.c               |  2 +-
 drivers/gpu/drm/bridge/ti-tfp410.c                 |  2 +-
 drivers/gpu/drm/display/drm_hdmi_state_helper.c    |  3 +-
 drivers/gpu/drm/drm_atomic_state_helper.c          | 68 ++++------------
 drivers/gpu/drm/drm_connector.c                    |  8 --
 drivers/gpu/drm/drm_mode_config.c                  |  4 +-
 drivers/gpu/drm/drm_panel.c                        | 14 +++-
 drivers/gpu/drm/exynos/exynos_drm_dpi.c            |  2 +-
 drivers/gpu/drm/exynos/exynos_drm_vidi.c           |  2 +-
 drivers/gpu/drm/exynos/exynos_hdmi.c               |  2 +-
 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c          |  2 +-
 drivers/gpu/drm/gud/gud_connector.c                | 20 +++--
 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_dp.c     |  2 +-
 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c   |  2 +-
 drivers/gpu/drm/hyperv/hyperv_drm_modeset.c        |  2 +-
 drivers/gpu/drm/i915/display/intel_connector.c     |  6 +-
 drivers/gpu/drm/i915/display/intel_sdvo.c          |  6 +-
 drivers/gpu/drm/imx/ipuv3/imx-tve.c                |  2 +-
 drivers/gpu/drm/logicvc/logicvc_interface.c        |  2 +-
 drivers/gpu/drm/loongson/lsdc_output_7a1000.c      |  2 +-
 drivers/gpu/drm/loongson/lsdc_output_7a2000.c      |  4 +-
 drivers/gpu/drm/meson/meson_encoder_hdmi.c         | 12 ++-
 drivers/gpu/drm/mgag200/mgag200_vga.c              |  2 +-
 drivers/gpu/drm/mgag200/mgag200_vga_bmc.c          |  2 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c      |  2 +-
 drivers/gpu/drm/nouveau/dispnv50/disp.c            |  9 ++-
 drivers/gpu/drm/nouveau/nouveau_connector.c        | 25 +++---
 drivers/gpu/drm/nouveau/nouveau_connector.h        |  3 +-
 drivers/gpu/drm/qxl/qxl_display.c                  |  2 +-
 .../gpu/drm/renesas/rcar-du/rcar_du_writeback.c    | 15 ++--
 drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c  |  2 +-
 drivers/gpu/drm/sitronix/st7571.c                  |  2 +-
 drivers/gpu/drm/sitronix/st7920.c                  |  2 +-
 drivers/gpu/drm/solomon/ssd130x.c                  |  2 +-
 drivers/gpu/drm/sti/sti_dvo.c                      |  2 +-
 drivers/gpu/drm/sti/sti_hda.c                      |  2 +-
 drivers/gpu/drm/sti/sti_hdmi.c                     |  2 +-
 drivers/gpu/drm/stm/lvds.c                         |  2 +-
 drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c             | 17 +++-
 drivers/gpu/drm/sun4i/sun4i_lvds.c                 |  2 +-
 drivers/gpu/drm/sun4i/sun4i_rgb.c                  |  2 +-
 drivers/gpu/drm/sun4i/sun4i_tv.c                   | 16 +++-
 drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c             |  2 +-
 drivers/gpu/drm/sysfb/drm_sysfb_helper.h           |  2 +-
 drivers/gpu/drm/tegra/dsi.c                        | 17 ++--
 drivers/gpu/drm/tegra/hdmi.c                       |  2 +-
 drivers/gpu/drm/tegra/sor.c                        | 13 ++--
 drivers/gpu/drm/tests/drm_atomic_commit_test.c     |  2 +-
 drivers/gpu/drm/tests/drm_atomic_test.c            |  2 +-
 drivers/gpu/drm/tests/drm_connector_test.c         |  4 +-
 drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 17 +++-
 drivers/gpu/drm/tests/drm_probe_helper_test.c      |  2 +-
 drivers/gpu/drm/tiny/appletbdrm.c                  |  2 +-
 drivers/gpu/drm/tiny/arcpgu.c                      |  2 +-
 drivers/gpu/drm/tiny/bochs.c                       |  2 +-
 drivers/gpu/drm/tiny/cirrus-qemu.c                 |  2 +-
 drivers/gpu/drm/tiny/gm12u320.c                    |  2 +-
 drivers/gpu/drm/tiny/pixpaper.c                    |  2 +-
 drivers/gpu/drm/tiny/repaper.c                     |  2 +-
 drivers/gpu/drm/tiny/sharp-memory.c                |  2 +-
 drivers/gpu/drm/udl/udl_modeset.c                  |  2 +-
 drivers/gpu/drm/vboxvideo/vbox_mode.c              |  2 +-
 drivers/gpu/drm/vc4/tests/vc4_mock_output.c        |  2 +-
 drivers/gpu/drm/vc4/vc4_hdmi.c                     | 32 ++++++--
 drivers/gpu/drm/vc4/vc4_txp.c                      |  2 +-
 drivers/gpu/drm/vc4/vc4_vec.c                      | 16 +++-
 drivers/gpu/drm/virtio/virtgpu_display.c           |  2 +-
 drivers/gpu/drm/vkms/vkms_connector.c              |  2 +-
 drivers/gpu/drm/vkms/vkms_writeback.c              |  2 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_kms.c                | 23 ++----
 drivers/gpu/drm/vmwgfx/vmwgfx_kms.h                |  3 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c                |  2 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c               |  2 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c               |  2 +-
 drivers/gpu/drm/xen/xen_drm_front_conn.c           |  2 +-
 include/drm/drm_atomic_state_helper.h              |  9 +--
 include/drm/drm_connector.h                        | 12 ---
 include/drm/drm_mipi_dbi.h                         |  2 +-
 108 files changed, 392 insertions(+), 331 deletions(-)
---
base-commit: 91f52e99824b0beebb48cad51bbda81437af8664
change-id: 20260709-drm-no-more-connector-reset-45ee14d7c62c

Best regards,

Comments

Maxime Ripard Oct. 16, 2026, 3:06 p.m. UTC | #1 
On Wed, 14 Oct 2026 19:26:23 +0200, Maxime Ripard wrote:
> This is a follow-up to the plane and CRTC reset removal series, and
> part of a larger effort to remove the reset hook from all KMS objects.
> 
> The connector reset hook is overloaded: it is called both at probe
> time to create the initial software state and during suspend/resume to
> reset hardware and software state. These two roles have different
> requirements, and the reset hook is not fallible, making error
> handling difficult for the initial state allocation path.
> 
> [...]

Applied to misc/kernel.git (drm-misc-next)

[05/75] drm/arm: komeda: Switch to drm_atomic_helper_connector_create_state
        commit: 849b1119cb1f429667bf3e79cba86ad397087ab7
[11/75] drm/bridge: lontium-lt8912b: Switch to drm_atomic_helper_connector_create_state
        commit: 80512a4f295c52caf1394677d9c80738b68c8831
[12/75] drm/bridge: megachips: Switch to drm_atomic_helper_connector_create_state
        commit: 9a4a55df74880acf7c2b954d6011aab579db5f5e
[24/75] drm/hyperv: Switch to drm_atomic_helper_connector_create_state
        commit: 7b9c28149a291451ada4c3e9fc7fd2ae13f36bc5
[25/75] drm/imx: ipuv3: Switch to drm_atomic_helper_connector_create_state
        commit: 75da1ba5a3c36dca76206ec8e90bebcfc3641c64
[35/75] drm/solomon: ssd130x: Switch to drm_atomic_helper_connector_create_state
        commit: 9ec42580ccceb54bd8e0b044729a98e4f345b522
[39/75] drm/sysfb: Switch to drm_atomic_helper_connector_create_state
        commit: af36b2313c54e10b832298033b8be2fd50746c96
[51/75] drm/vc4: Switch to drm_atomic_helper_connector_create_state
        commit: c81e4d88c3ed73483a99a90f56cc80c80eebc863
[67/75] drm/malidp: Convert to atomic_create_state
        commit: 8b32d0652db9bb6b01055311e1cce5e3c4b70137

Thanks!
Maxime
Maxime Ripard Oct. 16, 2026, 3:12 p.m. UTC | #2 
On Wed, 14 Oct 2026 19:26:23 +0200, Maxime Ripard wrote:
> This is a follow-up to the plane and CRTC reset removal series, and
> part of a larger effort to remove the reset hook from all KMS objects.
> 
> The connector reset hook is overloaded: it is called both at probe
> time to create the initial software state and during suspend/resume to
> reset hardware and software state. These two roles have different
> requirements, and the reset hook is not fallible, making error
> handling difficult for the initial state allocation path.
> 
> [...]

Applied to misc/kernel.git (drm-misc-next)

[02/75] drm/adp: Switch to drm_atomic_helper_connector_create_state
        commit: db1de27aca30ebaad04aea74ac21e4c4fb531a37

Thanks!
Maxime