drm/sun4i: mixer: Fix layer init code

Message ID 20260218183454.7881-1-jernej.skrabec@gmail.com (mailing list archive)
State New
Headers
Series drm/sun4i: mixer: Fix layer init code |

Commit Message

Jernej Skrabec Feb. 18, 2026, 6:34 p.m. UTC
Code refactoring dropped extra NULL sentinel entry at the end of the drm
planes array.

Add it back.

Reported-by: Chen-Yu Tsai <wens@kernel.org>
Closes: https://lore.kernel.org/linux-sunxi/CAGb2v65wY2pF6sR+0JgnpLa4ysvjght5hAKDa1RUyo=zEKXreg@mail.gmail.com/
Fixes: 5fd711adc0ba ("drm/sun4i: layer: move num of planes calc out of layer code")
Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
---
 drivers/gpu/drm/sun4i/sun8i_mixer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Chen-Yu Tsai Feb. 19, 2026, 3:51 a.m. UTC | #1
On Thu, Feb 19, 2026 at 2:35 AM Jernej Skrabec <jernej.skrabec@gmail.com> wrote:
>
> Code refactoring dropped extra NULL sentinel entry at the end of the drm
> planes array.
>
> Add it back.
>
> Reported-by: Chen-Yu Tsai <wens@kernel.org>
> Closes: https://lore.kernel.org/linux-sunxi/CAGb2v65wY2pF6sR+0JgnpLa4ysvjght5hAKDa1RUyo=zEKXreg@mail.gmail.com/
> Fixes: 5fd711adc0ba ("drm/sun4i: layer: move num of planes calc out of layer code")
> Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> ---

Reviewed-by: Chen-Yu Tsai <wens@kernel.org>
  
Chen-Yu Tsai Feb. 24, 2026, 5:50 p.m. UTC | #2
On Wed, 18 Feb 2026 19:34:54 +0100, Jernej Skrabec wrote:
> Code refactoring dropped extra NULL sentinel entry at the end of the drm
> planes array.
> 
> Add it back.
> 
> 

Applied to drm-misc-next in drm-misc, thanks!

[1/1] drm/sun4i: mixer: Fix layer init code
      commit: 744629904c68bde847c31819f23482d09152f810

Best regards,
  

Patch

diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.c b/drivers/gpu/drm/sun4i/sun8i_mixer.c
index ce9c155bfad7..02acc7cbdb97 100644
--- a/drivers/gpu/drm/sun4i/sun8i_mixer.c
+++ b/drivers/gpu/drm/sun4i/sun8i_mixer.c
@@ -321,7 +321,7 @@  static struct drm_plane **sun8i_layers_init(struct drm_device *drm,
 	unsigned int phy_index;
 	int i;
 
-	planes = devm_kcalloc(drm->dev, plane_cnt, sizeof(*planes), GFP_KERNEL);
+	planes = devm_kcalloc(drm->dev, plane_cnt + 1, sizeof(*planes), GFP_KERNEL);
 	if (!planes)
 		return ERR_PTR(-ENOMEM);