[2/3] arm64: dts: allwinner: sun55i-a523: Add LED controller

Message ID 20260225160828.1687643-3-wens@kernel.org (mailing list archive)
State New
Headers
Series arm64: dts: allwinner: sun55i-t527: avaota-a1: Enable LEDs |

Commit Message

Chen-Yu Tsai Feb. 25, 2026, 4:08 p.m. UTC
The A523 SoC family features an LED controller that is identical to the
one found on previous SoCs.

Add a device node for it, and one of the possible pinmux settings. This
setting is used on the Avaota A1.

Signed-off-by: Chen-Yu Tsai <wens@kernel.org>
---
 .../arm64/boot/dts/allwinner/sun55i-a523.dtsi | 22 +++++++++++++++++++
 1 file changed, 22 insertions(+)
  

Comments

Chen-Yu Tsai Feb. 25, 2026, 4:14 p.m. UTC | #1
On Thu, Feb 26, 2026 at 12:08 AM Chen-Yu Tsai <wens@kernel.org> wrote:
>
> The A523 SoC family features an LED controller that is identical to the
> one found on previous SoCs.
>
> Add a device node for it, and one of the possible pinmux settings. This
> setting is used on the Avaota A1.
>
> Signed-off-by: Chen-Yu Tsai <wens@kernel.org>
> ---
>  .../arm64/boot/dts/allwinner/sun55i-a523.dtsi | 22 +++++++++++++++++++
>  1 file changed, 22 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> index 09bd149bbf51..b8263e2872af 100644
> --- a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> @@ -170,6 +170,13 @@ i2s2_pi_pins: i2s2-pi-pins {
>                                 bias-disable;
>                         };
>
> +                       /omit-if-no-ref/
> +                       ledc_ph_pin: ledc-ph-pin {
> +                               pins = "PH19";
> +                               function = "ledc";
> +                               allwinner,pinmux = <5>;
> +                       };
> +
>                         mmc0_pins: mmc0-pins {
>                                 pins = "PF0" ,"PF1", "PF2", "PF3", "PF4", "PF5";
>                                 allwinner,pinmux = <2>;
> @@ -300,6 +307,21 @@ ccu: clock-controller@2001000 {
>                         #reset-cells = <1>;
>                 };
>
> +               ledc: led-controller@2008000 {
> +                       compatible = "allwinner,sun55i-a523-ledc",
> +                                    "allwinner,sun50i-a100-ledc";
> +                       reg = <0x02008000 0x400>;
> +                       interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>;
> +                       clocks = <&ccu CLK_BUS_LEDC>, <&ccu CLK_LEDC>;
> +                       clock-names = "bus", "mod";
> +                       resets = <&ccu RST_BUS_LEDC>;
> +                       dmas = <&dma 42>;
> +                       dma-names = "tx";
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       status = "disabled";
> +               };
> +
>                 ths1: thermal-sensor@2009400 {

I Forgot to rebase this patch before the thermal sensor one in my tree.
I can fix this when applying, so please still review the patch.

ChenYu

>                         compatible = "allwinner,sun55i-a523-ths1";
>                         reg = <0x02009400 0x400>;
> --
> 2.47.3
>
  
Jernej Skrabec Feb. 25, 2026, 4:57 p.m. UTC | #2
Dne sreda, 25. februar 2026 ob 17:14:51 Srednjeevropski standardni čas je Chen-Yu Tsai napisal(a):
> On Thu, Feb 26, 2026 at 12:08 AM Chen-Yu Tsai <wens@kernel.org> wrote:
> >
> > The A523 SoC family features an LED controller that is identical to the
> > one found on previous SoCs.
> >
> > Add a device node for it, and one of the possible pinmux settings. This
> > setting is used on the Avaota A1.
> >
> > Signed-off-by: Chen-Yu Tsai <wens@kernel.org>
> > ---
> >  .../arm64/boot/dts/allwinner/sun55i-a523.dtsi | 22 +++++++++++++++++++
> >  1 file changed, 22 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> > index 09bd149bbf51..b8263e2872af 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> > +++ b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> > @@ -170,6 +170,13 @@ i2s2_pi_pins: i2s2-pi-pins {
> >                                 bias-disable;
> >                         };
> >
> > +                       /omit-if-no-ref/
> > +                       ledc_ph_pin: ledc-ph-pin {
> > +                               pins = "PH19";
> > +                               function = "ledc";
> > +                               allwinner,pinmux = <5>;
> > +                       };
> > +
> >                         mmc0_pins: mmc0-pins {
> >                                 pins = "PF0" ,"PF1", "PF2", "PF3", "PF4", "PF5";
> >                                 allwinner,pinmux = <2>;
> > @@ -300,6 +307,21 @@ ccu: clock-controller@2001000 {
> >                         #reset-cells = <1>;
> >                 };
> >
> > +               ledc: led-controller@2008000 {
> > +                       compatible = "allwinner,sun55i-a523-ledc",
> > +                                    "allwinner,sun50i-a100-ledc";
> > +                       reg = <0x02008000 0x400>;
> > +                       interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&ccu CLK_BUS_LEDC>, <&ccu CLK_LEDC>;
> > +                       clock-names = "bus", "mod";
> > +                       resets = <&ccu RST_BUS_LEDC>;
> > +                       dmas = <&dma 42>;
> > +                       dma-names = "tx";
> > +                       #address-cells = <1>;
> > +                       #size-cells = <0>;
> > +                       status = "disabled";
> > +               };
> > +
> >                 ths1: thermal-sensor@2009400 {
> 
> I Forgot to rebase this patch before the thermal sensor one in my tree.
> I can fix this when applying, so please still review the patch.

Values are correct, so with a rebase this patch is:
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej

> 
> ChenYu
> 
> >                         compatible = "allwinner,sun55i-a523-ths1";
> >                         reg = <0x02009400 0x400>;
> > --
> > 2.47.3
> >
>
  

Patch

diff --git a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
index 09bd149bbf51..b8263e2872af 100644
--- a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
@@ -170,6 +170,13 @@  i2s2_pi_pins: i2s2-pi-pins {
 				bias-disable;
 			};
 
+			/omit-if-no-ref/
+			ledc_ph_pin: ledc-ph-pin {
+				pins = "PH19";
+				function = "ledc";
+				allwinner,pinmux = <5>;
+			};
+
 			mmc0_pins: mmc0-pins {
 				pins = "PF0" ,"PF1", "PF2", "PF3", "PF4", "PF5";
 				allwinner,pinmux = <2>;
@@ -300,6 +307,21 @@  ccu: clock-controller@2001000 {
 			#reset-cells = <1>;
 		};
 
+		ledc: led-controller@2008000 {
+			compatible = "allwinner,sun55i-a523-ledc",
+				     "allwinner,sun50i-a100-ledc";
+			reg = <0x02008000 0x400>;
+			interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&ccu CLK_BUS_LEDC>, <&ccu CLK_LEDC>;
+			clock-names = "bus", "mod";
+			resets = <&ccu RST_BUS_LEDC>;
+			dmas = <&dma 42>;
+			dma-names = "tx";
+			#address-cells = <1>;
+			#size-cells = <0>;
+			status = "disabled";
+		};
+
 		ths1: thermal-sensor@2009400 {
 			compatible = "allwinner,sun55i-a523-ths1";
 			reg = <0x02009400 0x400>;