diff mbox series

[2/3] dt-bindings: arm: sunxi: Add Baijie HelperBoard A133 compatible

Message ID 20260503191842.2736130-3-alexander.sverdlin@gmail.com (mailing list archive)
State New
Headers
Series Add support for Baijie Helper A133 board |

Commit Message

Alexander Sverdlin May 3, 2026, 7:18 p.m. UTC 
Baijie HelperBoard A133 is a development board around their A133 Core
board.

Signed-off-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
---
 Documentation/devicetree/bindings/arm/sunxi.yaml | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Conor Dooley May 5, 2026, 4:39 p.m. UTC | #1 
On Sun, May 03, 2026 at 09:18:37PM +0200, Alexander Sverdlin wrote:
> Baijie HelperBoard A133 is a development board around their A133 Core
> board.
> 
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
> ---
>  Documentation/devicetree/bindings/arm/sunxi.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
> index e6443c266fa1..52b42779a283 100644
> --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> @@ -96,6 +96,11 @@ properties:
>            - const: allwinner,ba10-tvbox
>            - const: allwinner,sun4i-a10
>  
> +      - description: Baijie Helper A133
> +        items:
> +          - const: baijie,helper-a133
> +          - const: allwinner,sun50i-a100

Should there additionally be a compatible for the som here?
Looks like there is a product called the "helperboarda133 core board"
that is soldered on here but has a separate product page.

The dts/dtsi probably should reflect this too?

> +
>        - description: BananaPi
>          items:
>            - const: lemaker,bananapi
> -- 
> 2.53.0
>
Conor Dooley May 5, 2026, 4:40 p.m. UTC | #2 
On Tue, May 05, 2026 at 05:39:09PM +0100, Conor Dooley wrote:
> On Sun, May 03, 2026 at 09:18:37PM +0200, Alexander Sverdlin wrote:
> > Baijie HelperBoard A133 is a development board around their A133 Core
> > board.
> > 
> > Signed-off-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
> > ---
> >  Documentation/devicetree/bindings/arm/sunxi.yaml | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
> > index e6443c266fa1..52b42779a283 100644
> > --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> > +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> > @@ -96,6 +96,11 @@ properties:
> >            - const: allwinner,ba10-tvbox
> >            - const: allwinner,sun4i-a10
> >  
> > +      - description: Baijie Helper A133
> > +        items:
> > +          - const: baijie,helper-a133
> > +          - const: allwinner,sun50i-a100
> 
> Should there additionally be a compatible for the som here?
> Looks like there is a product called the "helperboarda133 core board"
> that is soldered on here but has a separate product page.
> 
> The dts/dtsi probably should reflect this too?

My wording here was not clear enough, I meant that your dts/dtsi
reflect the fact that there is an independent board deserving a
compatible.

> 
> > +
> >        - description: BananaPi
> >          items:
> >            - const: lemaker,bananapi
> > -- 
> > 2.53.0
> >
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
index e6443c266fa1..52b42779a283 100644
--- a/Documentation/devicetree/bindings/arm/sunxi.yaml
+++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
@@ -96,6 +96,11 @@  properties:
           - const: allwinner,ba10-tvbox
           - const: allwinner,sun4i-a10
 
+      - description: Baijie Helper A133
+        items:
+          - const: baijie,helper-a133
+          - const: allwinner,sun50i-a100
+
       - description: BananaPi
         items:
           - const: lemaker,bananapi