[16/16] media: sun6i-isp: Add support for frame size enumeration
Commit Message
This implements the enum_framesizes operation, which reports support for
even sizes.
Signed-off-by: Paul Kocialkowski <paulk@sys-base.io>
---
.../media/sunxi/sun6i-isp/sun6i_isp_capture.c | 22 +++++++++++++++++++
1 file changed, 22 insertions(+)
Comments
Hi Paul,
On Mon, May 18, 2026 at 2:02 PM Paul Kocialkowski <paulk@sys-base.io> wrote:
>
> This implements the enum_framesizes operation, which reports support for
> even sizes.
>
> Signed-off-by: Paul Kocialkowski <paulk@sys-base.io>
> ---
> .../media/sunxi/sun6i-isp/sun6i_isp_capture.c | 22 +++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_capture.c b/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_capture.c
> index 372b9331bd6d..e638ec32c7cd 100644
> --- a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_capture.c
> +++ b/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_capture.c
> @@ -452,6 +452,26 @@ static int sun6i_isp_capture_enum_fmt(struct file *file, void *priv,
> return 0;
> }
>
> +static int sun6i_isp_capture_enum_framesizes(struct file *file, void *fh,
> + struct v4l2_frmsizeenum *frmsize)
> +{
> + if (frmsize->index)
> + return -EINVAL;
> +
> + if (!sun6i_isp_capture_format_find(frmsize->pixel_format))
> + return -EINVAL;
> +
> + frmsize->type = V4L2_FRMSIZE_TYPE_STEPWISE;
> + frmsize->stepwise.min_width = SUN6I_ISP_CAPTURE_WIDTH_MIN;
> + frmsize->stepwise.max_width = SUN6I_ISP_CAPTURE_WIDTH_MAX;
> + frmsize->stepwise.min_height = SUN6I_ISP_CAPTURE_HEIGHT_MIN;
> + frmsize->stepwise.max_height = SUN6I_ISP_CAPTURE_HEIGHT_MAX;
> + frmsize->stepwise.step_width = 2;
> + frmsize->stepwise.step_height = 2;
> +
> + return 0;
> +}
> +
> static int sun6i_isp_capture_g_fmt(struct file *file, void *priv,
> struct v4l2_format *format)
> {
> @@ -522,6 +542,8 @@ static const struct v4l2_ioctl_ops sun6i_isp_capture_ioctl_ops = {
> .vidioc_s_fmt_vid_cap = sun6i_isp_capture_s_fmt,
> .vidioc_try_fmt_vid_cap = sun6i_isp_capture_try_fmt,
>
> + .vidioc_enum_framesizes = sun6i_isp_capture_enum_framesizes,
> +
> .vidioc_enum_input = sun6i_isp_capture_enum_input,
> .vidioc_g_input = sun6i_isp_capture_g_input,
> .vidioc_s_input = sun6i_isp_capture_s_input,
> --
> 2.54.0
>
Tested on a LicheePi Zero Dock (V3s) with the ov5647 camera setup.
The enum_framesizes implementation behaves as expected and reports the
supported even frame sizes correctly.
Tested-by: Arash Golgol <arash.golgol@gmail.com>
Reviewed-by: Arash Golgol <arash.golgol@gmail.com>
@@ -452,6 +452,26 @@ static int sun6i_isp_capture_enum_fmt(struct file *file, void *priv,
return 0;
}
+static int sun6i_isp_capture_enum_framesizes(struct file *file, void *fh,
+ struct v4l2_frmsizeenum *frmsize)
+{
+ if (frmsize->index)
+ return -EINVAL;
+
+ if (!sun6i_isp_capture_format_find(frmsize->pixel_format))
+ return -EINVAL;
+
+ frmsize->type = V4L2_FRMSIZE_TYPE_STEPWISE;
+ frmsize->stepwise.min_width = SUN6I_ISP_CAPTURE_WIDTH_MIN;
+ frmsize->stepwise.max_width = SUN6I_ISP_CAPTURE_WIDTH_MAX;
+ frmsize->stepwise.min_height = SUN6I_ISP_CAPTURE_HEIGHT_MIN;
+ frmsize->stepwise.max_height = SUN6I_ISP_CAPTURE_HEIGHT_MAX;
+ frmsize->stepwise.step_width = 2;
+ frmsize->stepwise.step_height = 2;
+
+ return 0;
+}
+
static int sun6i_isp_capture_g_fmt(struct file *file, void *priv,
struct v4l2_format *format)
{
@@ -522,6 +542,8 @@ static const struct v4l2_ioctl_ops sun6i_isp_capture_ioctl_ops = {
.vidioc_s_fmt_vid_cap = sun6i_isp_capture_s_fmt,
.vidioc_try_fmt_vid_cap = sun6i_isp_capture_try_fmt,
+ .vidioc_enum_framesizes = sun6i_isp_capture_enum_framesizes,
+
.vidioc_enum_input = sun6i_isp_capture_enum_input,
.vidioc_g_input = sun6i_isp_capture_g_input,
.vidioc_s_input = sun6i_isp_capture_s_input,