diff mbox series

[v10,01/69] video/hdmi: Introduce HDMI version enum

Message ID 20260731-dw-hdmi-qp-scramb-v10-1-294364b2cf15@collabora.com (mailing list archive)
State New
Headers
Series Add HDMI 2.0 support to DW HDMI QP TX |

Commit Message

Cristian Ciocaltea July 31, 2026, 4:19 p.m. UTC 
Add an enum to represent HDMI specification versions.  This will be used
by upcoming changes to associate HDMI connectors and bridges with a
maximum supported version and to simplify handling of version-dependent
features.

Reviewed-by: Maxime Ripard <mripard@kernel.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
---
 include/linux/hdmi.h | 12 ++++++++++++
 1 file changed, 12 insertions(+)

Comments

sashiko-bot@kernel.org July 31, 2026, 4:25 p.m. UTC | #1 
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `hdmi_version` enum includes `HDMI_VERSION_2_2`, but there is no HDMI 2.2 specification.
--

--- Patch [1]: [PATCH v10 01/69] video/hdmi: Introduce HDMI version enum ---
commit 15fb027a48288332d9771472bd4b270e1f7f2d4b
Author: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>

video/hdmi: Introduce HDMI version enum

This commit introduces an enum to represent various HDMI specification
versions. It is intended to be used by upcoming changes to associate
HDMI connectors and bridges with a maximum supported version.

> diff --git a/include/linux/hdmi.h b/include/linux/hdmi.h
> index 8dab78e1f61bd..b80a5ee63bb23 100644
> --- a/include/linux/hdmi.h
> +++ b/include/linux/hdmi.h
[ ... ]
> @@ -27,6 +27,18 @@
>  #include <linux/types.h>
>  #include <linux/device.h>
>  
> +enum hdmi_version {
> +	HDMI_VERSION_UNKNOWN,
> +	HDMI_VERSION_1_0,
> +	HDMI_VERSION_1_1,
> +	HDMI_VERSION_1_2,
> +	HDMI_VERSION_1_3,
> +	HDMI_VERSION_1_4,
> +	HDMI_VERSION_2_0,
> +	HDMI_VERSION_2_1,
> +	HDMI_VERSION_2_2,

[Severity: Low]
This isn't a bug, but is HDMI_VERSION_2_2 intended to be here?

The latest major specification family released by the HDMI Forum is 2.1, and
there is no HDMI 2.2 specification.

Could this have been conflated with HDCP 2.2, which is frequently used
alongside HDMI 2.0/2.1? Including a non-existent version could lead to
incorrect capability reporting if drivers attempt to set it as a maximum
supported version.

> +};
> +
>  enum hdmi_packet_type {
>  	HDMI_PACKET_TYPE_NULL = 0x00,
>  	HDMI_PACKET_TYPE_AUDIO_CLOCK_REGEN = 0x01,
diff mbox series

Patch

diff --git a/include/linux/hdmi.h b/include/linux/hdmi.h
index 8dab78e1f61b..b80a5ee63bb2 100644
--- a/include/linux/hdmi.h
+++ b/include/linux/hdmi.h
@@ -27,6 +27,18 @@ 
 #include <linux/types.h>
 #include <linux/device.h>
 
+enum hdmi_version {
+	HDMI_VERSION_UNKNOWN,
+	HDMI_VERSION_1_0,
+	HDMI_VERSION_1_1,
+	HDMI_VERSION_1_2,
+	HDMI_VERSION_1_3,
+	HDMI_VERSION_1_4,
+	HDMI_VERSION_2_0,
+	HDMI_VERSION_2_1,
+	HDMI_VERSION_2_2,
+};
+
 enum hdmi_packet_type {
 	HDMI_PACKET_TYPE_NULL = 0x00,
 	HDMI_PACKET_TYPE_AUDIO_CLOCK_REGEN = 0x01,