[v2,1/2] arm64: dts: allwinner: h616: orangepi-zero2w: add 24-pin expansion overlay
Commit Message
The optional 24-pin expansion board carries two buttons on LRADC channel 0
and an IR receiver. Keep them out of the base board .dts: with the board
detached the LRADC input and the IR receiver pin are not driven and float,
which can produce phantom key presses and interrupt storms.
Provide them as a devicetree overlay instead, following the existing
sun8i-orangepi-zero-interface-board.dtso approach.
Tested on: OrangePi Zero 2W (Allwinner H618) with the 24-pin expansion board.
Signed-off-by: Vladimir <anykey196@gmail.com>
---
arch/arm64/boot/dts/allwinner/Makefile | 2 +
.../sun50i-h618-orangepi-zero2w-24pin.dtso | 42 +++++++++++++++++++
2 files changed, 44 insertions(+)
create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h618-orangepi-zero2w-24pin.dtso
Comments
Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [High] dt: mmc-pwrseq-simple silent clock failure due to incorrect clock-names
- [High] dt: missing pinctrl for RTC 32kHz clock output
- [Low] dt: use of magic number for RTC clock index
--
commit 97053bae21777f073acfc22535e6c83308625172
Author: Vladimir <anykey196@gmail.com>
arm64: dts: allwinner: h616: orangepi-zero2w: add SDIO WiFi/BT (AW859A)
Enable the SDIO bus (mmc1) and power the on-board AW859A (UWE5622)
WiFi/BT combo through an mmc-pwrseq-simple that resets WL_REG_ON (PG18), with
the 3.3 V and 1.8 V supplies and the RTC 32 kHz clock.
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h618-orangepi-zero2w.dts b/arch/arm64/boot/dts/allwinner/sun50i-h618-orangepi-zero2w.dts
> index ff9b40352a545..7d473274c06c0 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h618-orangepi-zero2w.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h618-orangepi-zero2w.dts
> @@ -189,3 +189,43 @@ &usbphy {
[ ... ]
> + wifi_pwrseq: wifi-pwrseq {
> + compatible = "mmc-pwrseq-simple";
[Severity: High]
Does this node need pinctrl properties to physically route the 32kHz RTC fanout
clock to its output pin (PG10)?
During the probing of the wifi_pwrseq node at boot, without specifying
pinctrl-0 = <&x32clk_fanout_pin>; and pinctrl-names = "default";, the pin
remains in its default state. This physically disconnects the clock signal from
the external WiFi/BT chip.
> + clocks = <&rtc 1>;
[Severity: Low]
Is it possible to use the CLK_OSC32K_FANOUT macro defined in
include/dt-bindings/clock/sun6i-rtc.h here instead of the magic number 1?
This would improve readability and consistency with other Allwinner device
trees.
> + clock-names = "osc32k-out";
[Severity: High]
Does the mmc-pwrseq-simple driver expect the clock name to be exactly
"ext_clock"?
When probing the wifi_pwrseq node, because this patch uses "osc32k-out",
devm_clk_get(dev, "ext_clock") returns -ENOENT. The driver treats -ENOENT as an
optional clock being absent and silently continues without enabling the 32kHz
clock. This causes the WiFi/BT module to fail to initialize or operate reliably.
> + reset-gpios = <&pio 6 18 GPIO_ACTIVE_LOW>; /* PG18 */
> + post-power-on-delay-ms = <200>;
> + };
> +};
@@ -57,6 +57,8 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-orangepi-zero2.dtb
dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-x96-mate.dtb
dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h618-longanpi-3h.dtb
dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h618-orangepi-zero2w.dtb
+dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h618-orangepi-zero2w-24pin.dtb
+sun50i-h618-orangepi-zero2w-24pin-dtbs := sun50i-h618-orangepi-zero2w.dtb sun50i-h618-orangepi-zero2w-24pin.dtbo
dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h618-orangepi-zero3.dtb
dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h618-transpeed-8k618-t.dtb
dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h618-yuzukihd-chameleon.dtb
new file mode 100644
@@ -0,0 +1,42 @@
+// SPDX-License-Identifier: (GPL-2.0-or-later OR X11)
+/*
+ * Device tree overlay for the Orange Pi Zero 2W 24-pin expansion board.
+ *
+ * The expansion board provides two buttons wired to LRADC channel 0 and an
+ * IR receiver. These are only present when the board is attached, so they
+ * are deliberately kept out of the base .dts: on a bare board the LRADC
+ * input and the IR receiver pin are not driven and float, which can cause
+ * phantom key presses and interrupt storms.
+ *
+ * Apply on top of:
+ * arch/arm64/boot/dts/allwinner/sun50i-h618-orangepi-zero2w.dts
+ */
+
+/dts-v1/;
+/plugin/;
+
+#include <dt-bindings/input/input.h>
+
+&lradc {
+ vref-supply = <®_vcc3v3>;
+ status = "okay";
+ wakeup-source;
+
+ button-1000 {
+ label = "KEY_1";
+ linux,code = <KEY_1>;
+ channel = <0>;
+ voltage = <1000000>;
+ };
+
+ button-1600 {
+ label = "KEY_ENTER";
+ linux,code = <KEY_ENTER>;
+ channel = <0>;
+ voltage = <1600000>;
+ };
+};
+
+&ir {
+ status = "okay";
+};