[v2,5/7] arm64: dts: allwinner: sun50i-h6: Add missing SRAM region for video engine
| Message ID | 20260711135959.3616919-6-wens@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-sunxi+bounces-24348-sunxi=pue.re@lists.linux.dev> X-Original-To: noreply@patchwork.local Delivered-To: noreply@patchwork.local Received: from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114]) by mxe881.netcup.net (Postfix) with ESMTPS id C20521C0790 for <noreply@patchwork.local>; Sat, 11 Jul 2026 16:00:24 +0200 (CEST) Authentication-Results: mxe881; dkim=pass header.d=kernel.org; spf=pass (sender IP is 172.105.105.114) smtp.mailfrom=linux-sunxi+bounces-24348-noreply=patchwork.local@lists.linux.dev smtp.helo=tor.lore.kernel.org Received-SPF: pass (mxe881: domain of lists.linux.dev designates 172.105.105.114 as permitted sender) client-ip=172.105.105.114; envelope-from=linux-sunxi+bounces-24348-noreply=patchwork.local@lists.linux.dev; helo=tor.lore.kernel.org; Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by tor.lore.kernel.org (Postfix) with ESMTP id F28A53012BC6 for <noreply@patchwork.local>; Sat, 11 Jul 2026 14:00:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AFACB2C21FF; Sat, 11 Jul 2026 14:00:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hL2iwygs" X-Original-To: linux-sunxi@lists.linux.dev Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3C7428726E; Sat, 11 Jul 2026 14:00:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783778411; cv=none; b=RgqtBxy6IB1yO1xyaRQJ8t6wPGZroaL8uQpUn5LcVqLYbVsLZxULhbPTIe9emOVL8+gA+4jqx+jjmvTA6+m+X8aRYsbmOiDVqQux6+ZcVuc9yGQeFbCI7PpHtQ9BnaDe8P/luXiBohMAILTaKkCXfsU/xDeJUAugho25bJq4m00= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783778411; c=relaxed/simple; bh=h8HnPa9jPNT9KN5lGEI/AtSgYlDiW6l80zMgBH26b/I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Br88QggPQq4RJZh8sHIO591+BwDjJZC7jbWmCK1ClPTV1kwyMexSg17UErMRSwPFIRUunCxaAUmfuJZU+4xsQoVmumKeAIwkAKfvjjssr3WK88jgGStQLUB/us9vEkxdoE25AZyxMzh7edCDG2fWkzrWqwrD13D5lV/BKzWZ7Tk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hL2iwygs; arc=none smtp.client-ip=100.103.45.18 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 496841F00A3E; Sat, 11 Jul 2026 14:00:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783778409; bh=lHn+VlrPP8+DG9eMf2EHuMFbxRRlTlKli3GayR7WGoQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=hL2iwygst/9gzBKYB3gR43vvXyMtPra1B9ErC5aSzTvxX6k4t83pD2fsU0jrX5ez9 02o/BWBEz8SMjpfhcU4yoUpo8zGAYfb+JBGF+TPxMR1IOP0IxuLgR6jPHsACHJ2QYQ pLVz6Syx2bvGSzhtYeduRL9T60iirIJL6czgoWXqVqsf/Jj3y/W6Km7oUnOQ088O3g T9L/3zjDGvMu0wxO2g/wmgj00Wn/Iyg4kL0UcKS5Tb26lYBT82KSL/eDD9pCqqNZaD LcY+v141/EYqUct2Up0Nt6FiJ+3VZDuOoJBNYrVWq90PQH9cLL3+FmhgF0h2yHVrxI JwGqvyYV+yqNg== Received: by wens.tw (Postfix, from userid 1000) id 65CBB6018D; Sat, 11 Jul 2026 22:00:06 +0800 (CST) From: Chen-Yu Tsai <wens@kernel.org> To: Maxime Ripard <mripard@kernel.org>, Paul Kocialkowski <paulk@sys-base.io>, Mauro Carvalho Chehab <mchehab@kernel.org>, Chen-Yu Tsai <wens@kernel.org>, Jernej Skrabec <jernej@kernel.org>, Samuel Holland <samuel@sholland.org>, Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, devicetree@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jernej Skrabec <jernej.skrabec@gmail.com> Subject: [PATCH v2 5/7] arm64: dts: allwinner: sun50i-h6: Add missing SRAM region for video engine Date: Sat, 11 Jul 2026 21:59:56 +0800 Message-ID: <20260711135959.3616919-6-wens@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260711135959.3616919-1-wens@kernel.org> References: <20260711135959.3616919-1-wens@kernel.org> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: <linux-sunxi.lists.linux.dev> List-Subscribe: <mailto:linux-sunxi+subscribe@lists.linux.dev> List-Unsubscribe: <mailto:linux-sunxi+unsubscribe@lists.linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspamd-worker-8404 X-Spamd-Result: default: False [-0.66 / 15.00]; BAYES_HAM(-5.50)[100.00%]; RBL_SENDERSCORE(2.00)[172.105.105.114:from]; SUSPICIOUS_RECIPS(1.50)[]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; MAILLIST(-0.15)[generic]; BAD_REP_POLICIES(0.10)[]; MIME_GOOD(-0.10)[text/plain]; HAS_LIST_UNSUB(-0.01)[]; TAGGED_RCPT(0.00)[dt]; FREEMAIL_CC(0.00)[linuxfoundation.org,vger.kernel.org,lists.linux.dev,lists.infradead.org,gmail.com]; FUZZY_BLOCKED(0.00)[rspamd.com]; PRECEDENCE_BULK(0.00)[]; RCPT_COUNT_TWELVE(0.00)[17]; DBL_BLOCKED_OPENRESOLVER(0.00)[tor.lore.kernel.org:rdns,tor.lore.kernel.org:helo]; FROM_HAS_DN(0.00)[]; RCVD_COUNT_FIVE(0.00)[6]; R_DKIM_ALLOW(0.00)[kernel.org:s=k20260515]; DMARC_POLICY_ALLOW(0.00)[kernel.org,quarantine]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; DKIM_TRACE(0.00)[kernel.org:+]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(0.00)[+ip4:172.105.105.114:c]; FORGED_SENDER_MAILLIST(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:63949, ipnet:172.105.96.0/20, country:SG]; FROM_NEQ_ENVFROM(0.00)[wens@kernel.org,linux-sunxi@lists.linux.dev]; RCVD_TLS_LAST(0.00)[]; ARC_ALLOW(0.00)[subspace.kernel.org:s=arc-20240116:i=1]; TAGGED_FROM(0.00)[bounces-24348-noreply=patchwork.local]; RCVD_VIA_SMTP_AUTH(0.00)[] X-Rspamd-Queue-Id: C20521C0790 X-MORS-Enabled: yes X-MORS-DOMAIN: patchwork.local X-MORS-HOSTING: hosting172546 X-MORS-USER: hosting172546 X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= |
| Series |
arm64: allwinner: h616: Support Video Engine
|
|
Commit Message
Chen-Yu Tsai
July 11, 2026, 1:59 p.m. UTC
The SRAM C region contains a partial alias to the VE SRAM already
referenced by the video engine. To avoid access through this alias
window, the region should also be claimed by the video engine.
Add a reference to the SRAM C region to the video engine node.
Fixes: b542570e5605 ("arm64: dts: allwinner: h6: Add Video Engine node")
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Signed-off-by: Chen-Yu Tsai <wens@kernel.org>
---
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] Adding a second phandle to the `allwinner,sram` property has no effect at runtime because the sunxi_sram driver infrastructure hardcodes parsing to only the first index. -- --- Patch [5]: [PATCH v2 5/7] arm64: dts: allwinner: sun50i-h6: Add missing SRAM region for video engine --- commit 8b2bcf328faa458d85d11e3cef06ddda86e2e10e Author: Chen-Yu Tsai <wens@kernel.org> arm64: dts: allwinner: sun50i-h6: Add missing SRAM region for video engine This commit adds a reference to the SRAM C region in the video engine node to prevent access through a partial alias window. > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > @@ -205,7 +205,7 @@ video-codec@1c0e000 { > clock-names = "ahb", "mod", "ram"; > resets = <&ccu RST_BUS_VE>; > interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>; > - allwinner,sram = <&ve_sram 1>; > + allwinner,sram = <&ve_sram 1>, <&de2_sram 1>; [Severity: Medium] Will the second phandle be silently ignored during runtime? Looking at the cedrus driver, it calls sunxi_sram_claim() during probe. However, the underlying infrastructure appears to hardcode index 0 when parsing this property: drivers/soc/sunxi/sunxi_sram.c:sunxi_sram_of_parse() { ... ret = of_parse_phandle_with_fixed_args(node, "allwinner,sram", 1, 0, &args); ... } Does the driver infrastructure need to be updated to parse multiple indices before this device tree addition takes effect? > iommus = <&iommu 3>; > };
On Sat, Jul 11, 2026 at 10:08 PM <sashiko-bot@kernel.org> wrote: > > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: > - [Medium] Adding a second phandle to the `allwinner,sram` property has no effect at runtime because the sunxi_sram driver infrastructure hardcodes parsing to only the first index. > -- > > --- Patch [5]: [PATCH v2 5/7] arm64: dts: allwinner: sun50i-h6: Add missing SRAM region for video engine --- > commit 8b2bcf328faa458d85d11e3cef06ddda86e2e10e > Author: Chen-Yu Tsai <wens@kernel.org> > > arm64: dts: allwinner: sun50i-h6: Add missing SRAM region for video engine > > This commit adds a reference to the SRAM C region in the video engine node > to prevent access through a partial alias window. > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > @@ -205,7 +205,7 @@ video-codec@1c0e000 { > > clock-names = "ahb", "mod", "ram"; > > resets = <&ccu RST_BUS_VE>; > > interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>; > > - allwinner,sram = <&ve_sram 1>; > > + allwinner,sram = <&ve_sram 1>, <&de2_sram 1>; > > [Severity: Medium] > Will the second phandle be silently ignored during runtime? > > Looking at the cedrus driver, it calls sunxi_sram_claim() during probe. > However, the underlying infrastructure appears to hardcode index 0 when > parsing this property: > > drivers/soc/sunxi/sunxi_sram.c:sunxi_sram_of_parse() { > ... > ret = of_parse_phandle_with_fixed_args(node, "allwinner,sram", 1, 0, > &args); Yeah, no. Sashiko's context needs to be updated. This was changed in commit be99eb936b4f ("soc: sunxi: sram: Support claiming multiple regions per device") in v7.2-rc1. > ... > } > > Does the driver infrastructure need to be updated to parse multiple indices > before this device tree addition takes effect? > > > iommus = <&iommu 3>; > > }; > > -- > Sashiko AI review · https://sashiko.dev/#/patchset/20260711135959.3616919-1-wens@kernel.org?part=5
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi index 72ce1a75647b..88c6e3e105c0 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi @@ -205,7 +205,7 @@ video-codec@1c0e000 { clock-names = "ahb", "mod", "ram"; resets = <&ccu RST_BUS_VE>; interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>; - allwinner,sram = <&ve_sram 1>; + allwinner,sram = <&ve_sram 1>, <&de2_sram 1>; iommus = <&iommu 3>; };