diff mbox series

drm/sun4i: Fix resource leaks

Message ID 20260226163836.10335-1-ethantidmore06@gmail.com (mailing list archive)
State New
Headers
Series drm/sun4i: Fix resource leaks |

Commit Message

Ethan Tidmore Feb. 26, 2026, 4:38 p.m. UTC 
Three clocks are not being released in devm_regmap_init_mmio() error
path.

Add proper goto and set ret to the error code.

Fixes: 8270249fbeaf0 ("drm/sun4i: backend: Create regmap after access is possible")
Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com>
---
 drivers/gpu/drm/sun4i/sun4i_backend.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Jernej Skrabec Feb. 27, 2026, 6:01 p.m. UTC | #1 
Dne četrtek, 26. februar 2026 ob 17:38:36 Srednjeevropski standardni čas je Ethan Tidmore napisal(a):
> Three clocks are not being released in devm_regmap_init_mmio() error
> path.
> 
> Add proper goto and set ret to the error code.
> 
> Fixes: 8270249fbeaf0 ("drm/sun4i: backend: Create regmap after access is possible")
> Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com>

Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej
Chen-Yu Tsai March 14, 2026, 1:13 p.m. UTC | #2 
On Thu, 26 Feb 2026 10:38:36 -0600, Ethan Tidmore wrote:
> Three clocks are not being released in devm_regmap_init_mmio() error
> path.
> 
> Add proper goto and set ret to the error code.
> 
> 

Applied to drm-misc-next in drm-misc, thanks!

[1/1] drm/sun4i: Fix resource leaks
      commit: 127367ad2e0f4870de60c6d719ae82ecf68d674c

Best regards,
diff mbox series

Patch

diff --git a/drivers/gpu/drm/sun4i/sun4i_backend.c b/drivers/gpu/drm/sun4i/sun4i_backend.c
index 6391bdc94a5c..e989f75c09b7 100644
--- a/drivers/gpu/drm/sun4i/sun4i_backend.c
+++ b/drivers/gpu/drm/sun4i/sun4i_backend.c
@@ -881,7 +881,8 @@  static int sun4i_backend_bind(struct device *dev, struct device *master,
 						     &sun4i_backend_regmap_config);
 	if (IS_ERR(backend->engine.regs)) {
 		dev_err(dev, "Couldn't create the backend regmap\n");
-		return PTR_ERR(backend->engine.regs);
+		ret = PTR_ERR(backend->engine.regs);
+		goto err_disable_ram_clk;
 	}
 
 	list_add_tail(&backend->engine.list, &drv->engine_list);