[v2] arm64: dts: allwiner: h5: OrangePi PC2: add ethernet LEDs
Commit Message
This patch adds support for Ethernet LEDs. Keep the default LED settings.
Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
---
Changes iv v2:
- add defaullt-state property. Previously, the LEDs were dark by default.
---
.../dts/allwinner/sun50i-h5-orangepi-pc2.dts | 22 +++++++++++++++++++
1 file changed, 22 insertions(+)
Comments
Hi,
you mispelled "allwinner:" in subject.
Dne nedelja, 27. september 2026 ob 21:38:18 Srednjeevropski poletni čas je Aleksander Jan Bajkowski napisal(a):
> This patch adds support for Ethernet LEDs. Keep the default LED settings.
Reword message. "This patch" should be removed. Check other commits for examples.
Other than that, it looks ok.
Best regards,
Jernej
>
> Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
> ---
> Changes iv v2:
> - add defaullt-state property. Previously, the LEDs were dark by default.
> ---
> .../dts/allwinner/sun50i-h5-orangepi-pc2.dts | 22 +++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts
> index 6e57ee19e799..c23315994799 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts
> @@ -7,6 +7,7 @@
>
> #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/input/input.h>
> +#include <dt-bindings/leds/common.h>
> #include <dt-bindings/pinctrl/sun4i-a10.h>
>
> / {
> @@ -132,6 +133,27 @@ &external_mdio {
> ext_rgmii_phy: ethernet-phy@1 {
> compatible = "ethernet-phy-ieee802.3-c22";
> reg = <1>;
> +
> + leds {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + led@0 {
> + reg = <0>;
> + color = <LED_COLOR_ID_GREEN>;
> + function = LED_FUNCTION_LAN;
> + linux,default-trigger = "netdev";
> + default-state = "keep";
> + };
> +
> + led@1 {
> + reg = <1>;
> + color = <LED_COLOR_ID_AMBER>;
> + function = LED_FUNCTION_LAN;
> + linux,default-trigger = "netdev";
> + default-state = "keep";
> + };
> + };
> };
> };
>
>
On Sun, 27 Sep 2026 21:38:18 +0200, Aleksander Jan Bajkowski wrote:
> This patch adds support for Ethernet LEDs. Keep the default LED settings.
>
>
Applied to sunxi/dt-for-7.4 in sunxi, thanks!
[1/1] arm64: dts: allwiner: h5: OrangePi PC2: add ethernet LEDs
https://git.kernel.org/sunxi/linux/c/265ffb8d8dfe
Best regards,
@@ -7,6 +7,7 @@
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/input/input.h>
+#include <dt-bindings/leds/common.h>
#include <dt-bindings/pinctrl/sun4i-a10.h>
/ {
@@ -132,6 +133,27 @@ &external_mdio {
ext_rgmii_phy: ethernet-phy@1 {
compatible = "ethernet-phy-ieee802.3-c22";
reg = <1>;
+
+ leds {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ led@0 {
+ reg = <0>;
+ color = <LED_COLOR_ID_GREEN>;
+ function = LED_FUNCTION_LAN;
+ linux,default-trigger = "netdev";
+ default-state = "keep";
+ };
+
+ led@1 {
+ reg = <1>;
+ color = <LED_COLOR_ID_AMBER>;
+ function = LED_FUNCTION_LAN;
+ linux,default-trigger = "netdev";
+ default-state = "keep";
+ };
+ };
};
};