[v3,2/5] dt-bindings: arm: sunxi: Add Baijie HelperBoard A133 compatible

Message ID 20260517234134.2737320-3-alexander.sverdlin@gmail.com (mailing list archive)
State New
Headers
Series Add support for Baijie Helper A133 board |

Commit Message

Alexander Sverdlin May 17, 2026, 11:41 p.m. UTC
Baijie HelperBoard A133 is a development board around their A133 Core
board. Introduce a compatible for both the Core and the development
boards.

Acked-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
---
Changelog:
v3:
- no separate section for "core" .dtsi
v2:
- introduced baijie,helper-a133-core compatible for the Core (SoM) board

 Documentation/devicetree/bindings/arm/sunxi.yaml | 6 ++++++
 1 file changed, 6 insertions(+)
  

Comments

sashiko-bot@kernel.org May 17, 2026, 11:50 p.m. UTC | #1
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing standalone compatible entry for the Core board.
--

commit 76fcabeafe7a55386e6089c83f652ab14cf4b7ec
Author: Alexander Sverdlin <alexander.sverdlin@gmail.com>

dt-bindings: arm: sunxi: Add Baijie HelperBoard A133 compatible

Baijie HelperBoard A133 is a development board around their A133 Core
board. Introduce a compatible for both the Core and the development
boards.

> diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
> index 9e4627f97d7e3..845b5a93686e7 100644
> --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> @@ -96,6 +96,12 @@ properties:
[ ... ]
> +      - description: Baijie Helper A133
> +        items:
> +          - const: baijie,helper-a133
> +          - const: baijie,helper-a133-core
> +          - const: allwinner,sun50i-a100
> +

The commit message states the intent to "Introduce a compatible for both the
Core and the development boards."

Since this items list requires exactly three elements, it correctly validates
the development board, but it appears a device tree written solely for the
standalone Core board would be rejected.

If the Core board were used with a different custom carrier board in the
future, would it need its own standalone compatible entry?

For example:

      - description: Baijie Helper A133 Core
        items:
          - const: baijie,helper-a133-core
          - const: allwinner,sun50i-a100

Does omitting a standalone entry for the Core board limit flexibility for future
designs based on it?
  
Conor Dooley May 18, 2026, 4:47 p.m. UTC | #2
On Sun, May 17, 2026 at 11:50:06PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] Missing standalone compatible entry for the Core board.
> --
> 
> commit 76fcabeafe7a55386e6089c83f652ab14cf4b7ec
> Author: Alexander Sverdlin <alexander.sverdlin@gmail.com>
> 
> dt-bindings: arm: sunxi: Add Baijie HelperBoard A133 compatible
> 
> Baijie HelperBoard A133 is a development board around their A133 Core
> board. Introduce a compatible for both the Core and the development
> boards.
> 
> > diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
> > index 9e4627f97d7e3..845b5a93686e7 100644
> > --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> > +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> > @@ -96,6 +96,12 @@ properties:
> [ ... ]
> > +      - description: Baijie Helper A133
> > +        items:
> > +          - const: baijie,helper-a133
> > +          - const: baijie,helper-a133-core
> > +          - const: allwinner,sun50i-a100
> > +
> 
> The commit message states the intent to "Introduce a compatible for both the
> Core and the development boards."
> 
> Since this items list requires exactly three elements, it correctly validates
> the development board, but it appears a device tree written solely for the
> standalone Core board would be rejected.
> 
> If the Core board were used with a different custom carrier board in the
> future, would it need its own standalone compatible entry?
> 
> For example:
> 
>       - description: Baijie Helper A133 Core
>         items:
>           - const: baijie,helper-a133-core
>           - const: allwinner,sun50i-a100

This example is complete crap, compared to the point that is apparently
being made about different carriers.

> Does omitting a standalone entry for the Core board limit flexibility for future
> designs based on it?

Obviously not.
  

Patch

diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
index e6443c266fa1..f65bf1a549d4 100644
--- a/Documentation/devicetree/bindings/arm/sunxi.yaml
+++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
@@ -96,6 +96,12 @@  properties:
           - const: allwinner,ba10-tvbox
           - const: allwinner,sun4i-a10
 
+      - description: Baijie Helper A133
+        items:
+          - const: baijie,helper-a133
+          - const: baijie,helper-a133-core
+          - const: allwinner,sun50i-a100
+
       - description: BananaPi
         items:
           - const: lemaker,bananapi