media: sun6i-csi: bridge: Remove duplicate mbus format entries

Message ID 20260527124552.33815-1-arash.golgol@gmail.com (mailing list archive)
State New
Headers
Series media: sun6i-csi: bridge: Remove duplicate mbus format entries |

Commit Message

arash golgol May 27, 2026, 12:45 p.m. UTC
The driver reports MEDIA_BUS_FMT_UYVY8_2X8 and
MEDIA_BUS_FMT_UYVY8_1X16 twice when enumerating supported media bus
codes.

Remove the duplicated entries from sun6i_csi_bridge_formats[].

Signed-off-by: Arash Golgol <arash.golgol@gmail.com>
---
 .../platform/sunxi/sun6i-csi/sun6i_csi_bridge.c      | 12 ------------
 1 file changed, 12 deletions(-)
  

Comments

Paul Kocialkowski May 28, 2026, 7:41 a.m. UTC | #1
Hi Arash,

On Wed 27 May 26, 16:15, Arash Golgol wrote:
> The driver reports MEDIA_BUS_FMT_UYVY8_2X8 and
> MEDIA_BUS_FMT_UYVY8_1X16 twice when enumerating supported media bus
> codes.
> 
> Remove the duplicated entries from sun6i_csi_bridge_formats[].

Looks good to me, thanks for taking care of this!

> Signed-off-by: Arash Golgol <arash.golgol@gmail.com>

Reviewed-by: Paul Kocialkowski <paulk@sys-base.io>

All the best,

Paul

> ---
>  .../platform/sunxi/sun6i-csi/sun6i_csi_bridge.c      | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_bridge.c b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_bridge.c
> index d006d9dd0170..0bec0cd7620e 100644
> --- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_bridge.c
> +++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_bridge.c
> @@ -113,12 +113,6 @@ static const struct sun6i_csi_bridge_format sun6i_csi_bridge_formats[] = {
>  		.input_yuv_seq		= SUN6I_CSI_INPUT_YUV_SEQ_YVYU,
>  		.input_yuv_seq_invert	= SUN6I_CSI_INPUT_YUV_SEQ_YUYV,
>  	},
> -	{
> -		.mbus_code		= MEDIA_BUS_FMT_UYVY8_2X8,
> -		.input_format		= SUN6I_CSI_INPUT_FMT_YUV422,
> -		.input_yuv_seq		= SUN6I_CSI_INPUT_YUV_SEQ_UYVY,
> -		.input_yuv_seq_invert	= SUN6I_CSI_INPUT_YUV_SEQ_VYUY,
> -	},
>  	{
>  		.mbus_code		= MEDIA_BUS_FMT_VYUY8_2X8,
>  		.input_format		= SUN6I_CSI_INPUT_FMT_YUV422,
> @@ -143,12 +137,6 @@ static const struct sun6i_csi_bridge_format sun6i_csi_bridge_formats[] = {
>  		.input_yuv_seq		= SUN6I_CSI_INPUT_YUV_SEQ_YVYU,
>  		.input_yuv_seq_invert	= SUN6I_CSI_INPUT_YUV_SEQ_YUYV,
>  	},
> -	{
> -		.mbus_code		= MEDIA_BUS_FMT_UYVY8_1X16,
> -		.input_format		= SUN6I_CSI_INPUT_FMT_YUV422,
> -		.input_yuv_seq		= SUN6I_CSI_INPUT_YUV_SEQ_UYVY,
> -		.input_yuv_seq_invert	= SUN6I_CSI_INPUT_YUV_SEQ_VYUY,
> -	},
>  	{
>  		.mbus_code		= MEDIA_BUS_FMT_VYUY8_1X16,
>  		.input_format		= SUN6I_CSI_INPUT_FMT_YUV422,
> -- 
> 2.34.1
>
  

Patch

diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_bridge.c b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_bridge.c
index d006d9dd0170..0bec0cd7620e 100644
--- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_bridge.c
+++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_bridge.c
@@ -113,12 +113,6 @@  static const struct sun6i_csi_bridge_format sun6i_csi_bridge_formats[] = {
 		.input_yuv_seq		= SUN6I_CSI_INPUT_YUV_SEQ_YVYU,
 		.input_yuv_seq_invert	= SUN6I_CSI_INPUT_YUV_SEQ_YUYV,
 	},
-	{
-		.mbus_code		= MEDIA_BUS_FMT_UYVY8_2X8,
-		.input_format		= SUN6I_CSI_INPUT_FMT_YUV422,
-		.input_yuv_seq		= SUN6I_CSI_INPUT_YUV_SEQ_UYVY,
-		.input_yuv_seq_invert	= SUN6I_CSI_INPUT_YUV_SEQ_VYUY,
-	},
 	{
 		.mbus_code		= MEDIA_BUS_FMT_VYUY8_2X8,
 		.input_format		= SUN6I_CSI_INPUT_FMT_YUV422,
@@ -143,12 +137,6 @@  static const struct sun6i_csi_bridge_format sun6i_csi_bridge_formats[] = {
 		.input_yuv_seq		= SUN6I_CSI_INPUT_YUV_SEQ_YVYU,
 		.input_yuv_seq_invert	= SUN6I_CSI_INPUT_YUV_SEQ_YUYV,
 	},
-	{
-		.mbus_code		= MEDIA_BUS_FMT_UYVY8_1X16,
-		.input_format		= SUN6I_CSI_INPUT_FMT_YUV422,
-		.input_yuv_seq		= SUN6I_CSI_INPUT_YUV_SEQ_UYVY,
-		.input_yuv_seq_invert	= SUN6I_CSI_INPUT_YUV_SEQ_VYUY,
-	},
 	{
 		.mbus_code		= MEDIA_BUS_FMT_VYUY8_1X16,
 		.input_format		= SUN6I_CSI_INPUT_FMT_YUV422,