| Message ID | 20260613-a733-dts-v1-public-ready-v1-4-7787c94681db@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-sunxi+bounces-23799-sunxi=pue.re@lists.linux.dev> X-Original-To: noreply@patchwork.local Delivered-To: noreply@patchwork.local Received: from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10]) by mxe881.netcup.net (Postfix) with ESMTPS id 34F971C0135 for <noreply@patchwork.local>; Sat, 13 Jun 2026 11:42:44 +0200 (CEST) Authentication-Results: mxe881; dkim=pass header.d=kernel.org; spf=pass (sender IP is 172.234.253.10) smtp.mailfrom=linux-sunxi+bounces-23799-noreply=patchwork.local@lists.linux.dev smtp.helo=sea.lore.kernel.org Received-SPF: pass (mxe881: domain of lists.linux.dev designates 172.234.253.10 as permitted sender) client-ip=172.234.253.10; envelope-from=linux-sunxi+bounces-23799-noreply=patchwork.local@lists.linux.dev; helo=sea.lore.kernel.org; Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.90.174.1]) by sea.lore.kernel.org (Postfix) with ESMTP id 4D91430BD3E5 for <noreply@patchwork.local>; Sat, 13 Jun 2026 09:42:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EB9ED3B3BFC; Sat, 13 Jun 2026 09:42:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Uf/ZT06/" X-Original-To: linux-sunxi@lists.linux.dev Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1C5032B115; Sat, 13 Jun 2026 09:42:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781343733; cv=none; b=k2dMDPcmSqywG4ElT7LmQS9nkMeZR1FLvA1ZARmMa98VG1ZpEN2CueQ1ZMIsVD/rbtv0PZaPtpEzuY23S+11Lh22MUp49xA9mjaAoRXkXz3Nk4J9Kmj/Tg9BgNIvxuHF3J7blO81fPQbfvbA/H+BXmcSy9W8DzMt9OA/s5Ks7xc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781343733; c=relaxed/simple; bh=K3NSNpo9bYvrRkVd6BA97gap7TGSqpSPnzHzv28qtIA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ru2wQDVGEB9/PYWewA+dp+HJu2s5WjrC31noIyFHyy6GYH+0w5bi6VqVzMudsRJ1AZgXV5NQjGytrxCLUQsahSD1gxiufmAWIbexl+8ZZoYxQuw0WxQS06IWtYHOjDiO8vG1Jx+gDCQGInu89bdD70hWAyZlTpi4aYNGB9/wELw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Uf/ZT06/; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPS id 75CE4C4AF13; Sat, 13 Jun 2026 09:42:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1781343733; bh=K3NSNpo9bYvrRkVd6BA97gap7TGSqpSPnzHzv28qtIA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=Uf/ZT06/TJDVvFRDYnIeJY9enLWXaWv18k/d57YXEQXchFp+XqYpjfjrSHO5TE+AD MLqpphn3Uh/pFFH3u36VRHgxlPoKLPsuoyMjTp9giKQoI6Qo/s7JR+O4c5XDo05sD2 wdhvv9pdzPVstpBcuLu+j0mnVyHLXbO1gBzseu8gP+BEkF6Q/pc3a5DGr8Tn/XFvnI 6yy0hOwGo6fAFc+th8cVKc5k995VqMPmuyOTjISRwck2HVrKHn6ORh7V7XThbRY5g4 4x4uOwCeSzJmDi+4i9RC51bvMUo4DWWpZZZSfLA8LNBeZMI3lo/rXbHLAksSCELBY1 9oo0ZipOkLFzA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 694F7CD98D6; Sat, 13 Jun 2026 09:42:13 +0000 (UTC) From: Enzo Adriano via B4 Relay <devnull+enzo.adriano.code.gmail.com@kernel.org> Date: Sat, 13 Jun 2026 05:42:16 -0400 Subject: [PATCH 4/4] arm64: dts: allwinner: add Radxa Cubie A7S Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: <linux-sunxi.lists.linux.dev> List-Subscribe: <mailto:linux-sunxi+subscribe@lists.linux.dev> List-Unsubscribe: <mailto:linux-sunxi+unsubscribe@lists.linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260613-a733-dts-v1-public-ready-v1-4-7787c94681db@gmail.com> References: <20260613-a733-dts-v1-public-ready-v1-0-7787c94681db@gmail.com> In-Reply-To: <20260613-a733-dts-v1-public-ready-v1-0-7787c94681db@gmail.com> To: Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>, Chen-Yu Tsai <wens@kernel.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, Samuel Holland <samuel@sholland.org>, Maxime Ripard <mripard@kernel.org>, Ulf Hansson <ulfh@kernel.org> Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, Enzo Adriano <enzo.adriano.code@gmail.com> X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1781343732; l=2364; i=enzo.adriano.code@gmail.com; s=a733-cubie-a7s; h=from:subject:message-id; bh=WglawFMrtY9x8pOjuPdnu6SXc40mYnW0SaPFITAFqtE=; b=GbPhqn66Lz40aOjXStKHF233v3bsLzM1ml6LsXpvkrLn92HN/jl3uoeOECLYFwLIOOTvAKgWs elncJREMxH/DYHkJnIGC2PGIqP1I/hQiHA0jjrPTsST7XrK6bualNwq X-Developer-Key: i=enzo.adriano.code@gmail.com; a=ed25519; pk=5S3Wmdqa4XfCdeZF/HfeYqnQF8GN9JGt3SE1cxqSX8E= X-Endpoint-Received: by B4 Relay for enzo.adriano.code@gmail.com/a733-cubie-a7s with auth_id=820 X-Original-From: Enzo Adriano <enzo.adriano.code@gmail.com> Reply-To: enzo.adriano.code@gmail.com X-MORS-Enabled: yes X-MORS-DOMAIN: patchwork.local X-MORS-HOSTING: hosting172546 X-MORS-USER: hosting172546 X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= |
| Series | arm64: dts: allwinner: add A733/Cubie A7S DTS support | |
Commit Message
Enzo Adriano via B4 Relay
June 13, 2026, 9:42 a.m. UTC
From: Enzo Adriano <enzo.adriano.code@gmail.com> Add the Radxa Cubie A7S board description with serial console and SD card boot support. Ethernet remains disabled until the GMAC210 wrapper, clocks, resets, MDIO, PHY reset, PHY power, and link behavior are proven. Signed-off-by: Enzo Adriano <enzo.adriano.code@gmail.com> --- arch/arm64/boot/dts/allwinner/Makefile | 1 + .../boot/dts/allwinner/sun60i-a733-cubie-a7s.dts | 48 ++++++++++++++++++++++ 2 files changed, 49 insertions(+)
Comments
Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider: - [Medium] The `&mmc0` node is missing the `cd-gpios` property (or `broken-cd` / `non-removable`), which may be necessary for proper SD card detection. - [Low] The new DTB entry in the Makefile breaks alphabetical ordering. - [Low] The fixed regulator node name does not match the required device tree schema. -- commit f3152d16f1d4c4fabab01c5ee230d7994c9a7898 Author: Enzo Adriano <enzo.adriano.code@gmail.com> arm64: dts: allwinner: add Radxa Cubie A7S Add the Radxa Cubie A7S board description with serial console and SD card boot support. Ethernet remains disabled until prerequisites are proven. > diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile > index d116864b6c2b3..824cc35152db8 100644 > --- a/arch/arm64/boot/dts/allwinner/Makefile > +++ b/arch/arm64/boot/dts/allwinner/Makefile > @@ -56,6 +56,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-2024.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-h.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-plus.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-sp.dtb > +dtb-$(CONFIG_ARCH_SUNXI) += sun60i-a733-cubie-a7s.dtb [Severity: Low] This isn't a bug, but should this entry be placed further down? Strict alphabetical sorting dictates that sun60i should appear after all the sun55i entries to avoid merge conflicts. > dtb-$(CONFIG_ARCH_SUNXI) += sun55i-a527-cubie-a5e.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun55i-h728-x96qpro+.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun55i-t527-avaota-a1.dtb [ ... ] > diff --git a/arch/arm64/boot/dts/allwinner/sun60i-a733-cubie-a7s.dts b/arch/arm64/boot/dts/allwinner/sun60i-a733-cubie-a7s.dts > new file mode 100644 > index 0000000000000..453761a963237 > --- /dev/null > +++ b/arch/arm64/boot/dts/allwinner/sun60i-a733-cubie-a7s.dts > @@ -0,0 +1,48 @@ > +// SPDX-License-Identifier: (GPL-2.0-only OR MIT) > + > +/dts-v1/; > + > +#include "sun60i-a733.dtsi" > + > +/ { > + model = "Radxa Cubie A7S"; > + compatible = "radxa,cubie-a7s", "allwinner,sun60i-a733"; [ ... ] > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + reg_vcc3v3: vcc3v3 { > + compatible = "regulator-fixed"; [Severity: Low] This isn't a bug, but does this regulator name trigger a dtbs_check warning? The standard device tree binding expects the node name to match the pattern ^regulator(-[0-9]+v[0-9]+|-[0-9a-z-]+)?$. A standard name like regulator-3v3 or regulator-vcc-3v3 should be used instead. > + regulator-name = "vcc-3v3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + }; > +}; > + > +&mmc0 { > + vmmc-supply = <®_vcc3v3>; > + bus-width = <4>; > + no-mmc; > + no-sdio; > + status = "okay"; > +}; [Severity: Medium] The commit message states this adds SD card boot support, but is the cd-gpios property missing from this node? Without cd-gpios or an explicit broken-cd fallback, the MMC core might fail to detect card presence. If the kernel assumes the slot is empty, it will not probe the SD card, causing root filesystem mounting to fail.
Dne sobota, 13. junij 2026 ob 11:42:16 Srednjeevropski poletni čas je Enzo Adriano via B4 Relay napisal(a): > From: Enzo Adriano <enzo.adriano.code@gmail.com> > > Add the Radxa Cubie A7S board description with serial console and SD card > boot support. > > Ethernet remains disabled until the GMAC210 wrapper, clocks, resets, > MDIO, PHY reset, PHY power, and link behavior are proven. > > Signed-off-by: Enzo Adriano <enzo.adriano.code@gmail.com> > --- > arch/arm64/boot/dts/allwinner/Makefile | 1 + > .../boot/dts/allwinner/sun60i-a733-cubie-a7s.dts | 48 ++++++++++++++++++++++ > 2 files changed, 49 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile > index d116864b6c2b..824cc35152db 100644 > --- a/arch/arm64/boot/dts/allwinner/Makefile > +++ b/arch/arm64/boot/dts/allwinner/Makefile > @@ -56,6 +56,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-2024.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-h.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-plus.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-sp.dtb > +dtb-$(CONFIG_ARCH_SUNXI) += sun60i-a733-cubie-a7s.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun55i-a527-cubie-a5e.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun55i-h728-x96qpro+.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun55i-t527-avaota-a1.dtb > diff --git a/arch/arm64/boot/dts/allwinner/sun60i-a733-cubie-a7s.dts b/arch/arm64/boot/dts/allwinner/sun60i-a733-cubie-a7s.dts > new file mode 100644 > index 000000000000..453761a96323 > --- /dev/null > +++ b/arch/arm64/boot/dts/allwinner/sun60i-a733-cubie-a7s.dts > @@ -0,0 +1,48 @@ > +// SPDX-License-Identifier: (GPL-2.0-only OR MIT) > + > +/dts-v1/; > + > +#include "sun60i-a733.dtsi" > + > +/ { > + model = "Radxa Cubie A7S"; > + compatible = "radxa,cubie-a7s", "allwinner,sun60i-a733"; > + > + aliases { > + serial0 = &uart0; > + mmc0 = &mmc0; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + reg_vcc3v3: vcc3v3 { > + compatible = "regulator-fixed"; > + regulator-name = "vcc-3v3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + }; > +}; > + > +&mmc0 { > + vmmc-supply = <®_vcc3v3>; > + bus-width = <4>; > + no-mmc; > + no-sdio; > + status = "okay"; > +}; > + > +&pio { > + uart0_pb9_pb10_pins: uart0-pb9-pb10-pins { > + pins = "PB9", "PB10"; > + function = "uart0"; > + }; Besides sashiko bot comments, these pins should go to main A733 DTSI, like it's done for other SoCs. In any case, it's a bit early for DT. At least clocks should land before. Best regards, Jernej > +}; > + > +&uart0 { > + pinctrl-names = "default"; > + pinctrl-0 = <&uart0_pb9_pb10_pins>; > + status = "okay"; > +}; > >
Hi Jernej, Thanks for taking a look. > Besides sashiko bot comments, these pins should go to main A733 DTSI, > like it's done for other SoCs. > > In any case, it's a bit early for DT. At least clocks should land before. Agreed on both points. I'll move the UART0 pin definition into the main A733 DTSI for the next revision, following the other Allwinner SoCs. I will also hold off on sending a v2 until the A733 clock prerequisites are in a better state, unless maintainers prefer a different ordering. For now I'll keep this series as a checkpoint and continue tracking/testing the RTC, clock and pinctrl prerequisite work. Best regards, Enzo On Sat, Jun 13, 2026 at 7:37 AM Jernej Škrabec <jernej.skrabec@gmail.com> wrote: > > Dne sobota, 13. junij 2026 ob 11:42:16 Srednjeevropski poletni čas je Enzo Adriano via B4 Relay napisal(a): > > From: Enzo Adriano <enzo.adriano.code@gmail.com> > > > > Add the Radxa Cubie A7S board description with serial console and SD card > > boot support. > > > > Ethernet remains disabled until the GMAC210 wrapper, clocks, resets, > > MDIO, PHY reset, PHY power, and link behavior are proven. > > > > Signed-off-by: Enzo Adriano <enzo.adriano.code@gmail.com> > > --- > > arch/arm64/boot/dts/allwinner/Makefile | 1 + > > .../boot/dts/allwinner/sun60i-a733-cubie-a7s.dts | 48 ++++++++++++++++++++++ > > 2 files changed, 49 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile > > index d116864b6c2b..824cc35152db 100644 > > --- a/arch/arm64/boot/dts/allwinner/Makefile > > +++ b/arch/arm64/boot/dts/allwinner/Makefile > > @@ -56,6 +56,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-2024.dtb > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-h.dtb > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-plus.dtb > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-sp.dtb > > +dtb-$(CONFIG_ARCH_SUNXI) += sun60i-a733-cubie-a7s.dtb > > dtb-$(CONFIG_ARCH_SUNXI) += sun55i-a527-cubie-a5e.dtb > > dtb-$(CONFIG_ARCH_SUNXI) += sun55i-h728-x96qpro+.dtb > > dtb-$(CONFIG_ARCH_SUNXI) += sun55i-t527-avaota-a1.dtb > > diff --git a/arch/arm64/boot/dts/allwinner/sun60i-a733-cubie-a7s.dts b/arch/arm64/boot/dts/allwinner/sun60i-a733-cubie-a7s.dts > > new file mode 100644 > > index 000000000000..453761a96323 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/allwinner/sun60i-a733-cubie-a7s.dts > > @@ -0,0 +1,48 @@ > > +// SPDX-License-Identifier: (GPL-2.0-only OR MIT) > > + > > +/dts-v1/; > > + > > +#include "sun60i-a733.dtsi" > > + > > +/ { > > + model = "Radxa Cubie A7S"; > > + compatible = "radxa,cubie-a7s", "allwinner,sun60i-a733"; > > + > > + aliases { > > + serial0 = &uart0; > > + mmc0 = &mmc0; > > + }; > > + > > + chosen { > > + stdout-path = "serial0:115200n8"; > > + }; > > + > > + reg_vcc3v3: vcc3v3 { > > + compatible = "regulator-fixed"; > > + regulator-name = "vcc-3v3"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + regulator-always-on; > > + }; > > +}; > > + > > +&mmc0 { > > + vmmc-supply = <®_vcc3v3>; > > + bus-width = <4>; > > + no-mmc; > > + no-sdio; > > + status = "okay"; > > +}; > > + > > +&pio { > > + uart0_pb9_pb10_pins: uart0-pb9-pb10-pins { > > + pins = "PB9", "PB10"; > > + function = "uart0"; > > + }; > > Besides sashiko bot comments, these pins should go to main A733 DTSI, > like it's done for other SoCs. > > In any case, it's a bit early for DT. At least clocks should land before. > > Best regards, > Jernej > > > +}; > > + > > +&uart0 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&uart0_pb9_pb10_pins>; > > + status = "okay"; > > +}; > > > > > > > >
diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile index d116864b6c2b..824cc35152db 100644 --- a/arch/arm64/boot/dts/allwinner/Makefile +++ b/arch/arm64/boot/dts/allwinner/Makefile @@ -56,6 +56,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-2024.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-h.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-plus.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-sp.dtb +dtb-$(CONFIG_ARCH_SUNXI) += sun60i-a733-cubie-a7s.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun55i-a527-cubie-a5e.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun55i-h728-x96qpro+.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun55i-t527-avaota-a1.dtb diff --git a/arch/arm64/boot/dts/allwinner/sun60i-a733-cubie-a7s.dts b/arch/arm64/boot/dts/allwinner/sun60i-a733-cubie-a7s.dts new file mode 100644 index 000000000000..453761a96323 --- /dev/null +++ b/arch/arm64/boot/dts/allwinner/sun60i-a733-cubie-a7s.dts @@ -0,0 +1,48 @@ +// SPDX-License-Identifier: (GPL-2.0-only OR MIT) + +/dts-v1/; + +#include "sun60i-a733.dtsi" + +/ { + model = "Radxa Cubie A7S"; + compatible = "radxa,cubie-a7s", "allwinner,sun60i-a733"; + + aliases { + serial0 = &uart0; + mmc0 = &mmc0; + }; + + chosen { + stdout-path = "serial0:115200n8"; + }; + + reg_vcc3v3: vcc3v3 { + compatible = "regulator-fixed"; + regulator-name = "vcc-3v3"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + }; +}; + +&mmc0 { + vmmc-supply = <®_vcc3v3>; + bus-width = <4>; + no-mmc; + no-sdio; + status = "okay"; +}; + +&pio { + uart0_pb9_pb10_pins: uart0-pb9-pb10-pins { + pins = "PB9", "PB10"; + function = "uart0"; + }; +}; + +&uart0 { + pinctrl-names = "default"; + pinctrl-0 = <&uart0_pb9_pb10_pins>; + status = "okay"; +};