mbox series

[RFC/RFT,0/2] net: stmmac: Add support for Allwinner A733 GMAC210

Message ID 20260731-allwinner-a733-gmac-support-v1-0-d0a8732bfa82@baylibre.com (mailing list archive)
Headers
Series net: stmmac: Add support for Allwinner A733 GMAC210 |

Message

Jerome Brunet July 31, 2026, 4:30 p.m. UTC 
The A733 GMAC210 is a DesignWare MAC 5.20 with an Allwinner glue close to
the A523 GMAC200 already supported by dwmac-sun55i, but with a few
significant differences:

 * The glue configuration registers are a dedicated MMIO region of the
   controller instead of a syscon register.
 * That region is inside the controller reset domain, so the reset must be
   released before the configuration is written, and must not be asserted
   again afterwards or the configuration is lost.
 * The DMA channels have their own interrupt lines.
 * A PTP reference clock and an AHB reset are needed.
 * The controllers do not require a power domain (AFAIK).
 * The TX clock delay value is 5 bits wide instead of 3, split over 2
   register fields.

The DT changes for the A733 and the Cubie A7A board are not part of this
series and will be sent separately through the sunxi tree.

Tested on a Cubie A7A, RGMII with an external PHY on GMAC0.

Full disclosure: at the moment there is a problem with EEE/LPI while
testing on the Cubie A7A. If the device stays in LPI mode long enough, the
link sometimes (but not always) goes down, coming back up when the device
exits LPI mode.

I'm currently working around the problem by adding the following
properties to the PHY node:

	eee-broken-100tx;
	eee-broken-1000t;

Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
Jerome Brunet (2):
      dt-bindings: net: sun8i-emac: Add A733 GMAC210 compatible
      net: stmmac: Add support for Allwinner A733 GMAC210

 .../bindings/net/allwinner,sun8i-a83t-emac.yaml    | 130 +++++++++++++++---
 drivers/net/ethernet/stmicro/stmmac/dwmac-sun55i.c | 145 ++++++++++++++++++---
 2 files changed, 242 insertions(+), 33 deletions(-)
---
base-commit: dc59e4fea9d83f03bad6bddf3fa2e52491777482
change-id: 20260731-allwinner-a733-gmac-support-163bde10c152

Best regards,
--  
Jerome

Comments

Andre Przywara Aug. 6, 2026, 12:06 p.m. UTC | #1 
Hi,

On 7/31/26 18:30, Jerome Brunet wrote:
> The A733 GMAC210 is a DesignWare MAC 5.20 with an Allwinner glue close to
> the A523 GMAC200 already supported by dwmac-sun55i, but with a few
> significant differences:
> 
>   * The glue configuration registers are a dedicated MMIO region of the
>     controller instead of a syscon register.
>   * That region is inside the controller reset domain, so the reset must be
>     released before the configuration is written, and must not be asserted
>     again afterwards or the configuration is lost.
>   * The DMA channels have their own interrupt lines.
>   * A PTP reference clock and an AHB reset are needed.
>   * The controllers do not require a power domain (AFAIK).
>   * The TX clock delay value is 5 bits wide instead of 3, split over 2
>     register fields.
> 
> The DT changes for the A733 and the Cubie A7A board are not part of this
> series and will be sent separately through the sunxi tree.
> 
> Tested on a Cubie A7A, RGMII with an external PHY on GMAC0.
> 
> Full disclosure: at the moment there is a problem with EEE/LPI while
> testing on the Cubie A7A. If the device stays in LPI mode long enough, the
> link sometimes (but not always) goes down, coming back up when the device
> exits LPI mode.

I saw that the MAXIO PHY *vendor* driver disables exactly those two 
modes, so is this maybe more of a PHY problem?

Cheers,
Andre

> 
> I'm currently working around the problem by adding the following
> properties to the PHY node:
> 
> 	eee-broken-100tx;
> 	eee-broken-1000t;
> 
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> Jerome Brunet (2):
>        dt-bindings: net: sun8i-emac: Add A733 GMAC210 compatible
>        net: stmmac: Add support for Allwinner A733 GMAC210
> 
>   .../bindings/net/allwinner,sun8i-a83t-emac.yaml    | 130 +++++++++++++++---
>   drivers/net/ethernet/stmicro/stmmac/dwmac-sun55i.c | 145 ++++++++++++++++++---
>   2 files changed, 242 insertions(+), 33 deletions(-)
> ---
> base-commit: dc59e4fea9d83f03bad6bddf3fa2e52491777482
> change-id: 20260731-allwinner-a733-gmac-support-163bde10c152
> 
> Best regards,
> --
> Jerome
> 
>